From nobody Tue Sep 29 09:08:35 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011036.outbound.protection.outlook.com [52.101.57.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC2413C908; Mon, 10 Aug 2026 09:27:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354055; cv=fail; b=Y/cgoNL5bCuYg/9oMmTgyfxrRVRLYD57jLRzeZ2KN5aFo3Jpj2BGKwuZ+OZcHHTWVsz6jpgozAqLbJ5AKFebw0izaZOUmjCU/3pDCalGGkKrP6h7CJ3/V1m79sEZPkswnAvGHmRGCCRAoV15Ry2kfxfoQfolj90qbF7wiwuqidI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354055; c=relaxed/simple; bh=wPHsImfmtEe41G8iyeWq143SZFiEQhcc08P2sxjKJVI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W6UhfNHF+xX8Eeix75gy539uKFeXQyFAd7QVWIKnQAnLlVKwoYScakH4gAKXq1jmW1u+yb0R9CMHx9dRuJyWmkVKs8c2NnbH+JaDopYpoirM2m2dPEOpHkhC0KexDu7L8waHIlWW3zHZNujxJtq60bxJuFC3ZcAPdCx4zyaWgws= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Km80K1ao; arc=fail smtp.client-ip=52.101.57.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Km80K1ao" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mguW+EmyfTrb1gSebFywcR8TTloPz1y2CTKoPhRu9xDRhK2etBNaWbiq5qsjAXORDkRIlgcMqLcf4t9K+PkEIzCR9BgrIeSrKdzH90CsPSNOZpsyxsGqGYiuLMpNR2kvwRN27Sr8HyidNSLHGec/Yh2MF5IwT2gYypw3CtO4V68MTvk1fuXehAwvUkVku6qHNoGzVW1LNQEUn0MhkvmOX93OCyxPDfPw3PMVJhnyIIOAP1fShKpZ/+eURbUgIx2oqANd1e/cCcabqNG5MbaPPtIYrJ2ZkEUhGvhUB6JKUrwUAZxgVBr/0pLg/Ea26PdXX/KV+Urdywuq9c4qRrzJZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WSaw6JxYXlPvpCrOt8rsSiZl3OVFFOfODDtMpbqYFl4=; b=EJb5LM5tlGjeKeDQMXj+zUB5Gj6wu355Zv0ROhJ5rdcE2RacjSeASNArF7s/smsFSld/ff+5sFUxtinzF6+CRjrHQmfUmA/R4o4beKxBh1qrvBvH8KwH368wbvLxYIBFPUjjKhA8PTyFTci3Xi93+n+zmXOmXpAWO+ya1AnZNJ3AgcVvAnmKiwDi+tXU3uOv5SlAiks6asU3Uka8jLLVzlnZYF+Sgcdls8IUlflnzQGtG92AuavcwYyoyQVv8ZAxQaNyOGMBsTx5HHSYIw0/W8JMn1Sxuqu4qHaQevILzEEYui+ZV0Y9Rpc2MnFmBW5tUJ3N1Ew1qKkeZEJFXPxhdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WSaw6JxYXlPvpCrOt8rsSiZl3OVFFOfODDtMpbqYFl4=; b=Km80K1aooqS1aXPnnUCisl9AV06OaIHN+cwJbPiCjDq50BAk5J+p1zb/zqnfbnVhyltgXecIV4AhyG5XAYaaqPxEs+2s0LeFlWErSMqgYUk7CRFmSoLRIsjFLZLSrs2X2R4ImWj9kSlfv5XQveaTexul8G/rnMNpRKH9giCpqqh6c4yohs0xvfIDWFj5GfkfObqYlER7CCEHHEhVpls8vIaUOHJbH006dK1tkABeMjEd7xJaffZK8swnBBvogdm460rMwwOzAXLpBYZzWcjs+5QLVNn5lTyHQrNwcLAztshp1C29VTIm+xmamP7sGgU62vMNtL2w+oizqqPy1zgQKw== Received: from CH0PR13CA0007.namprd13.prod.outlook.com (2603:10b6:610:b1::12) by DM4PR12MB7600.namprd12.prod.outlook.com (2603:10b6:8:108::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 09:27:25 +0000 Received: from CH1PEPF0000A34A.namprd04.prod.outlook.com (2603:10b6:610:b1:cafe::6e) by CH0PR13CA0007.outlook.office365.com (2603:10b6:610:b1::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.11 via Frontend Transport; Mon, 10 Aug 2026 09:27:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH1PEPF0000A34A.mail.protection.outlook.com (10.167.244.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 09:27:24 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 10 Aug 2026 02:27:09 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:01 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 10 Aug 2026 02:26:53 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V2 1/5] net/mlx5: HWS, Print more details for bad completion Date: Mon, 10 Aug 2026 12:26:26 +0300 Message-ID: <20260810092630.3137666-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260810092630.3137666-1-tariqt@nvidia.com> References: <20260810092630.3137666-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34A:EE_|DM4PR12MB7600:EE_ X-MS-Office365-Filtering-Correlation-Id: f6212169-0d0d-4ed3-825e-08def6c1966b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|82310400026|36860700016|1800799024|6133799003|18002099003|22082099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: YFMEs3D//2LA5pKDRilxaGZW6a4CSYqdJakZ7V5Igt4fo21HWC98MqzyGYxAMtD2+ktTvJAGQ5hBkh3rqWG1lug4q7eP4beMZgYJE4Alzu2Clsy1hKQg2Vo1PkmrDm+mG+6hkEGH9EgX81MipvLpCWcKTP6SyTKuRAXGqG3G+xf/tyAFBhu8cQB+GCURMhEGTPf+0BQlWww9diS2sAZxLaRwvnWU767U0ZkmrAsrJF1kO9ocLr3NvIc5+jN/6FUTH/TJhUNPiI4AiDYswSVCqHWNRjXOTjwEBd5xUmgIOkCTHfsVL9J/GTEdQmvtqqv9W5R4PEE5H1FPzgOThjj68seL3ldoKiE68RFezWSDnmRXXFZstlbAF1hkgiCDU8mx9taz2+AbBmVm92BAQ1VwWIsRxv42B9N7/zyYQwUHvirUXqgFdsCuKZyyFaFmfFvwWnMobVbrzd8QTSTM0FbaM2WW6GJ/OnKpSFOr2bTi7e4hUulQ3+e1PAQ3s/wJ1ycH374J9F7HBjNSfWlQqPhaP79HCUJcRrL3iZHSjZTHDATlRCIqSpJf3xxSemLBDO7weP2tswYQndTN6k/C23hwNSxQQ89d++d8y/Ii45LZ2RrUyeWiBK6j99dDirau4WYyqcaAh04jXalJEhcWXc6n0RYcOgN6fqssbryiz7qKrLmcZdL4V9IfVZNbFlDdNkAWP51h144kQATroGN2yRm6Fw== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(82310400026)(36860700016)(1800799024)(6133799003)(18002099003)(22082099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RFlVfaA1woZCwpuKklradZ/h1M2/LJ3/zg1p6oImP+uCjmKxe68QRhcNPDEZjhC5NjpD7V8QlC/K5oJJeoV+XZHmhZ1Ewub7HSwkzrPDsxS9XV0QX0YkSquWHoZarrqmyTLv5dk2owucJWayrtvYvF5nYVAIO7/MLRHeUsL474LSCjXzG0vSpr4/6XDFsylJ3wKMg7dzEO7Jwe5n9uqX3il5tlHmOD7ZPy4vNljaXzS7UmNVqz/NJhc0hg/S5atEBFuEPHu1Pv5YPRbNfdLtZSGGHkCOD5cOXyHH9GPIKx1Kqd2ylDf7//Dk0IFnGtFOXt595ejKuomzhPImBs3XF9BwxNTMg0XlOl03f1o2xYDJqcoHxVddOlgO1qkG8120XZaAk6OOOJuw3OyG20JbCseyrU1hX0np0pcAHNbZamWao8RgiVcrMFFJLRNN5Kho X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 09:27:24.4521 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6212169-0d0d-4ed3-825e-08def6c1966b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7600 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When polling for completion returned completion with error, parse some more details: QP number and WQE count. Also, extract all the long value-to-string if conditions to a short value-to-string functions: do it for rule resize state, rule status, and syndrome. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/steering/hws/send.c | 68 +++++++++++++------ 1 file changed, 49 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index aed009aec4fe..1c9206f74aaa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -344,6 +344,36 @@ hws_send_engine_update_rule_resize(struct mlx5hws_send= _engine *queue, } } =20 +static const char *hws_rule_status_to_string(enum mlx5hws_rule_status stat= us) +{ + switch (status) { + case MLX5HWS_RULE_STATUS_CREATING: return "CREATING"; + case MLX5HWS_RULE_STATUS_UPDATING: return "UPDATING"; + case MLX5HWS_RULE_STATUS_DELETING: return "DELETING"; + case MLX5HWS_RULE_STATUS_FAILING: return "FAILING"; + default: return "NA"; + } +} + +static const char *hws_rule_resize_state_to_string(u8 state) +{ + switch (state) { + case MLX5HWS_RULE_RESIZE_STATE_IDLE: return "IDLE"; + case MLX5HWS_RULE_RESIZE_STATE_WRITING: return "WRITING"; + case MLX5HWS_RULE_RESIZE_STATE_DELETING: return "DELETING"; + default: return "UNKNOWN"; + } +} + +static const char *hws_gta_syndrome_to_string(u8 syndrome) +{ + switch (syndrome) { + case 1: return "SET_FLOW_FAIL"; + case 2: return "DISABLE_FLOW_FAIL"; + default: return "UNKNOWN"; + } +} + static void hws_send_engine_dump_error_cqe(struct mlx5hws_send_engine *que= ue, struct mlx5hws_send_ring_priv *priv, struct mlx5_cqe64 *cqe) @@ -352,6 +382,7 @@ static void hws_send_engine_dump_error_cqe(struct mlx5h= ws_send_engine *queue, struct mlx5hws_context *ctx =3D priv->rule->matcher->tbl->ctx; u32 opcode =3D cqe ? get_cqe_opcode(cqe) : 0; struct mlx5hws_rule *rule =3D priv->rule; + u8 syndrome; =20 /* If something bad happens and lots of rules are failing, we don't * want to pollute dmesg. Print only the first bad cqe per engine, @@ -364,26 +395,17 @@ static void hws_send_engine_dump_error_cqe(struct mlx= 5hws_send_engine *queue, =20 if (mlx5hws_rule_move_in_progress(rule)) mlx5hws_err(ctx, - "--- rule 0x%08llx: error completion moving rule: phase %s, wqes le= ft %d\n", + "--- rule 0x%08llx: error completion moving rule: phase %s (%d), wq= es left %d\n", HWS_PTR_TO_ID(rule), - rule->resize_info->state =3D=3D - MLX5HWS_RULE_RESIZE_STATE_WRITING ? "WRITING" : - rule->resize_info->state =3D=3D - MLX5HWS_RULE_RESIZE_STATE_DELETING ? "DELETING" : - "UNKNOWN", + hws_rule_resize_state_to_string + (rule->resize_info->state), + rule->resize_info->state, rule->pending_wqes); else mlx5hws_err(ctx, "--- rule 0x%08llx: error completion %s (%d), wqes left %d\n", HWS_PTR_TO_ID(rule), - rule->status =3D=3D - MLX5HWS_RULE_STATUS_CREATING ? "CREATING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_DELETING ? "DELETING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_FAILING ? "FAILING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_UPDATING ? "UPDATING" : "NA", + hws_rule_status_to_string(rule->status), rule->status, rule->pending_wqes); =20 @@ -423,6 +445,15 @@ static void hws_send_engine_dump_error_cqe(struct mlx5= hws_send_engine *queue, " rule 0x%08llx: |--- syndrome =3D 0x%x\n", HWS_PTR_TO_ID(rule), err_cqe->syndrome); + mlx5hws_err(ctx, + " rule 0x%08llx: |--- QPN =3D 0x%x\n", + HWS_PTR_TO_ID(rule), + be32_to_cpu(err_cqe->s_wqe_opcode_qpn) & + 0xffffff); + mlx5hws_err(ctx, + " rule 0x%08llx: |--- WQE_CNT =3D 0x%04x\n", + HWS_PTR_TO_ID(rule), + (u32)be16_to_cpu(err_cqe->wqe_counter)); } =20 mlx5hws_err(ctx, @@ -433,13 +464,12 @@ static void hws_send_engine_dump_error_cqe(struct mlx= 5hws_send_engine *queue, HWS_PTR_TO_ID(rule), (be32_to_cpu(cqe->byte_cnt) & 0x80000000) ? "FAILURE" : "SUCCESS"); + /* syndrome is in the lower 2 bits of byte_cnt */ + syndrome =3D be32_to_cpu(cqe->byte_cnt) & 3; mlx5hws_err(ctx, - " rule 0x%08llx: |------- SYNDROME =3D %s\n", + " rule 0x%08llx: |------- SYNDROME =3D %s (%u)\n", HWS_PTR_TO_ID(rule), - ((be32_to_cpu(cqe->byte_cnt) & 0x00000003) =3D=3D 1) ? - "SET_FLOW_FAIL" : - ((be32_to_cpu(cqe->byte_cnt) & 0x00000003) =3D=3D 2) ? - "DISABLE_FLOW_FAIL" : "UNKNOWN"); + hws_gta_syndrome_to_string(syndrome), syndrome); mlx5hws_err(ctx, " rule 0x%08llx: cqe->sop_drop_qpn =3D 0x%08x\n", HWS_PTR_TO_ID(rule), be32_to_cpu(cqe->sop_drop_qpn)); --=20 2.44.0 From nobody Tue Sep 29 09:08:35 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010031.outbound.protection.outlook.com [40.93.198.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 923193AEF4F; Mon, 10 Aug 2026 09:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354059; cv=fail; b=ZYYjG9mzBQ5UZYAn3x+svXNp36AKtbzUShFnincpQZlHv9YZtZnybLGrwrMKGSF6T6FGTt4J3d4vZaEO7hnGjWBoZ9CF579DTxP6Vqm1dKPQWi7lgHFk3IjuBRWuLI3/Fw4Az/5zo66JeGJhmv8bozuaGrejrmXxCiD+k+ttfd4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354059; c=relaxed/simple; bh=0m8mCVS+W6tXKvqCGJc5a6INAggMb6XXEK/0w5v29z8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NWGlzdy2sMSA28cBhK6tTKZSLfEa1dKclNAS+TIqukgxP9a7bppFFYDWoV5Z/pHP6NJKlJsxvzhStaeUSchT4rRYxengNyLWZyxaATXLt+c9ydsRq3Lb3n5GX7gmR7y9bERspdjUvK2Bu5rlEU9JMPOqVXB6+QVTHL38Ps+xVqE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=l3+e8fYo; arc=fail smtp.client-ip=40.93.198.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="l3+e8fYo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PBhugScsisudpxmiyEeNmPCf0jr2dOKDRm1XQKyu7Xseq6N+DuPUFct33hMZbKnMaU6Vef3dW+S3wdGFPCRzuktfsIhRDzXTkJz1VYfGafxa7nWmisCEDChxkFaBtft+phsZL/gglVrhAI5zYBF0ZTyc9RNwnDWVkOgjYwNeDpAQ7Xxhw8ewcc+YH/D9/45G1UJmwSLQcJMkrwqGKHiLyNq3hQQog8eAoDkVd8r0CX2ds1TP0cJy3DzUgB/8X2HgNhM0tP27aMszlu0NS1tmyMk6xBYMLd/22FNc+Q/gBZp3D8Ydqj/JyXcnY5VA0YBBCgcQ6pdaN2Jxzu2ffRYozQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QMwqRO2GT1S34YUWsQdcgV++iivfvLQglnsQWEcU1Ss=; b=TyScU6sFj3O4KZ+pZJNYD4xudbMDwIp/5RgeiMRhhgpXlGtLkSIRzYQRiJNCGd1S4PvVTu5EB7+bi2hdQzKEDEoDBRU56BaTUaLB/fw5P3QeyK7Go7Nf/NKgZCC+Wzpaaf0FoHI5xWK1KiBShwjJ2/lLo0LemyOCuxRBWvw3BXNF+cplueducc8BfopqulB1Q6QDDl1fZmjk6smY9kjEK6R77H/K7Ufa8VtS4evrkTgNKj62Mp45LCdadCLXNi+f2vER/jgJcCkV2OtombtwVGzQ8f35cDMHM1C6qKrI56zn4GULZcYJvUfisyd56F5bvNNfd/PUV9sADj0AzHmBkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMwqRO2GT1S34YUWsQdcgV++iivfvLQglnsQWEcU1Ss=; b=l3+e8fYo9T17pUJ6vMaJKCkOR0/U7+bazJuvoz8IVGMpbA5gsh4mkMKIQwtYVYzll/pAhN4VEyMkOdF2BYUoX7YFHI5skCX77qCf9Uc6Wsc306muP2uNYyLP3xJrc8NBGeR9K+j4aDCL0JFx8xB8gDhvv9StWA4+1lSftr9Vbds5e/fFbOAuOzDD5Z4nuKQPhGujtvy4QD0i3J+LHUJigylAAHGWmxibl1m6qhKVUaa/tXl4u+aOU/Z09/rRab0oDHfQZeBzMIpNiYdLJSWga47BSoiqrvvYu4eyPAsYuxMS1Cjzo+/DhtvP238at4H2hMX0DLZXN2SfqklT9rkn6w== Received: from BLAPR03CA0061.namprd03.prod.outlook.com (2603:10b6:208:329::6) by IA1PR12MB6385.namprd12.prod.outlook.com (2603:10b6:208:38b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 09:27:31 +0000 Received: from BL02EPF00029929.namprd02.prod.outlook.com (2603:10b6:208:329:cafe::4) by BLAPR03CA0061.outlook.office365.com (2603:10b6:208:329::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 09:27:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BL02EPF00029929.mail.protection.outlook.com (10.167.249.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 09:27:29 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:11 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:09 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 10 Aug 2026 02:27:01 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V2 2/5] net/mlx5: HWS, Log syndrome on STC modify failure Date: Mon, 10 Aug 2026 12:26:27 +0300 Message-ID: <20260810092630.3137666-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260810092630.3137666-1-tariqt@nvidia.com> References: <20260810092630.3137666-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029929:EE_|IA1PR12MB6385:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d53d25e-e1c7-4ad2-a307-08def6c19962 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|376014|7416014|1800799024|82310400026|10067099003|56012099006|11063799006|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: HRhkfGQ0W7ER7TdNGGnmx/+4P0pIJkupvZ69hcz8TVZiq72eflKbhIs9qFdJsZBOOngowEhWuD78sZScp9/4geAy5TH9BTdPwAvs+Ft8fft8tDLHCYOCObem8yLoWzCPiu+cIs8SHrAhUbwzXRaHZr9HIwULtpqKggXdjm1+EYk9vrHDeid2vdmK7mN0XYF1IforkFyC+t2Wrs2xYgrJzhKoYgZf851b4ckNjOnkPGLL0Uefymj4Pxjqu9tOPf7QPfMy5BaVZsKw+8vS815llXTRzfnO2q+O/fb4PkX4xSaeFdG0oeJlgCVMOCkUdKyjF7YDG9q18/fYaT2AsWee372U1DuKVKt/iYpOs5BhlFuT9StaZqxarC0ZPW1zTOY/4WKYCEn7RchSrpx8YKF82mc+oAZf0Qv8zhahDkcYYu+zKMEjlm6R3L4/nlpI3ffc5UtOL6ZdAk1uAQjC/M0ukiRuQLGAwfGWopun9SnNsieG7LWn8Gvc3Pu9NMT4EX6Uz9QEb5DPUg+miIBooTgf0+9K3puZJVAljlkt53t6KvmjwtaqpX9sSFUpaVVzv5hu7o5AagzXQa1DKatnh5C9Iay0hZv6AER+zP0CRZWsVIZdW2nfpqZ9FwYdkeWDOtZ7hPHxRGUxY1nMFyjgcI2Tn995zdkVIGwGjYJ6i94117hH00jzkY5P4JWty/Odqvj6h21QSKti0T8SGvFkfYaoXA== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(376014)(7416014)(1800799024)(82310400026)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 38J/T+E6rFGuu+zdv6EcwnI1fHH4/pdroMrEr2vgkkF/6SSrWNx8HTfsb5vmCgV63tGlhNm6tyX45e3P7aOU8D2QnQLQuJxopbXwUnyoUReYKbR3J7ADXZghgUfd9+qy4oilDxYezwY8AxkL7s/WTi1mFyA5FBjmcnhSNSaqx7BWgvFgimPVyNQWOh9mrt85M8ukia7bptS9jGYc1a7OaNJdO8ESRbYK1aGXpL1Ir1vPKE8Xdd41RPriwy1ER7PFhVF8WYNw3aATquAH331S//P1+yVFgl5qDTIhjo7z0IrlbcKPkhA3oer2AEt8zZYmApDlWICiNVm0dQZ2OgYxQaiqk9gein0qe1d8u9Nt6ohuFzKgLnczc5mq+q4zjuTnTBofEbl/QBeY5ScXGHsd5dbZ60iRz0J6WlPfXW8kesqYWD4HHZ3EjkBcRsEwmCsv X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 09:27:29.3977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d53d25e-e1c7-4ad2-a307-08def6c19962 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029929.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6385 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When mlx5_cmd_exec fails for STC modify, include the command syndrome from the output buffer in the error message to aid debugging. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index 8fae90101653..2cdc03421433 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -611,9 +611,11 @@ int mlx5hws_cmd_stc_modify(struct mlx5_core_dev *mdev, =20 ret =3D mlx5_cmd_exec(mdev, in, sizeof(in), out, sizeof(out)); if (ret) - mlx5_core_err(mdev, "Failed to modify STC FW action_type %d\n", - stc_attr->action_type); - + mlx5_core_err(mdev, + "Failed to modify STC action_type %d, err %d, syndrome 0x%x\n", + stc_attr->action_type, ret, + MLX5_GET(general_obj_out_cmd_hdr, + out, syndrome)); return ret; } =20 --=20 2.44.0 From nobody Tue Sep 29 09:08:35 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010052.outbound.protection.outlook.com [40.93.198.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 543243AFB03; Mon, 10 Aug 2026 09:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354061; cv=fail; b=esD/atSQFpGBx7Rpaxjva9+pbMEmVn7Hfo/FfvtdwlxRgWQwWmLHiGxR8XyN/1NaHpsO5CVHSjOb8sHzXQKAKwEKOxccMqFEKcIE1fEPHtard1zaMTZQI7Adzgx6x/b184Hpmyzcac92RlsuTgYBYrL7gU5/TrDmNIwMvLdnve4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354061; c=relaxed/simple; bh=/GCqifligbeh/pm5JS4f1e4WhClbttnsEWTGKyv8m7Y=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EOO4uheSKDRQhJkptHal+0AdjNf1b6ad6z/gipHrVqg1+Odq1OAyvWA/RANxP8YuKAUJJA3rvhwzLK9yqlSBwAEJxIPqf7fKNS7EK5YhxMS+0HGtV6D0ACU1f8qNoUaNsP0NOXVfJTC6loA9tIJiZx0F7hMZcvIkR9x4ktN28X0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ZbFtM2xx; arc=fail smtp.client-ip=40.93.198.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ZbFtM2xx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LT3M8vQjAnpjxOaTfk4SG/FpFps4V8VxgdDY0ye3dRkmrkDN72VMnpbSPvNGgt36LQXDSYbAA2XhfkQJ8uBVQU4sVWKa1sq/ebT4DAZM1zCbGSWV8wwEymrnAUvOITc7jdbo+UmarVYNBLuidz28y1+udjR7GY+6M5YLLT6XAH3fZb2Gyau879G3kZmJBUnVVLn8wB9CtN6mhN3n4yw4JlMhYe9ijo1gMFwKQEkZpw7o6p1Ih9WGyXcQnvtaHNLGMi4it6DYknDumv0olh7pe3PvKIFu74LIFeIh+6y5JJeUBp6Bxu9uSz4EWYMG/qnLBeIyUznjHzkBsHvOvbU0xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R2A0NGAxy8AMJNr03AXwLbFBp1YCre7sWvchJGAg7oI=; b=vsn8zUNeuqcvTl7MkkOGJ5hNLQbhc9opL6Ny07BW3yLnVZgpHVjxKWc4L16SpGMQ4iAqilndmqg6u1d00EKixkkXNeO6puqloVmqtWwYWpsGXDCmmDcl+BekPenSWAKMEKE/AHZmMKEkCmnI6fr36lJJsZZ0JRRPCDYyX4AOdfLwoe1JlkWGAlJVv/fcsnsY0FKl0OqHYME+t0WlHVAMXMP1Ru1Q/983xkjxRp3Cpa7474eznmUaeZk1hSDiAsecduVyrhzK8YApzgyhihdvjJabfTxhCdl95d/FyJbw5PHAxQYav9ogHrv3USaDwSOKMESu7WaPeQsh57PUuPEu6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R2A0NGAxy8AMJNr03AXwLbFBp1YCre7sWvchJGAg7oI=; b=ZbFtM2xxsAf1LQmHru/1USTIOE3aGf/F3FWX3i9p7d28UXinpdg3/IkQnHjstxrJOoFVs+1T65GhJgUEJiYIWYOL7c3a5yR0x3zFP4M5vBLAJcoDZIb64+qYcamCLNUCoF3LcVVMD9TpKTGD19XSHa5yfYZ/a2e1KWp+g0F/ilc9uc4zkBiu1GkyiDWy7q8kBpjefiZl41jUfMZQOkPPUVfkES92tn/RxjmhZOYS76G8eSAyeJMu/j2c92z3xy9Lo+Q3FtTrKE4pNAmsQdC+FmQRWv0WnwscdM24escoK98tr8DH6eV5jh73rUJiNwsyD1N0qykyH4Lqsq1Yxa2mlg== Received: from BLAPR03CA0038.namprd03.prod.outlook.com (2603:10b6:208:32d::13) by PH0PR12MB5677.namprd12.prod.outlook.com (2603:10b6:510:14d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 09:27:34 +0000 Received: from BL02EPF00029928.namprd02.prod.outlook.com (2603:10b6:208:32d:cafe::5) by BLAPR03CA0038.outlook.office365.com (2603:10b6:208:32d::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 09:27:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BL02EPF00029928.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 09:27:33 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:17 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:16 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 10 Aug 2026 02:27:09 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V2 3/5] net/mlx5: HWS, Set the num of queues only when alloc succeeded Date: Mon, 10 Aug 2026 12:26:28 +0300 Message-ID: <20260810092630.3137666-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260810092630.3137666-1-tariqt@nvidia.com> References: <20260810092630.3137666-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029928:EE_|PH0PR12MB5677:EE_ X-MS-Office365-Filtering-Correlation-Id: 57e2fa99-d4bc-44ab-a630-08def6c19c07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|36860700016|82310400026|23010399003|1800799024|11063799006|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: I+Lw/+jxwYn9fq/b7Y1xJ5OoDSWT48cIWVImonjP43YIjTLMXbIznTbK7ojfz4WzdzRx/8PuZKPok1lbD1KzEp042qL5hxbZjvOq89f4NNBqrJ3YB6AL38XCK37C4hU05juxecDfYqCjLvQ/FdgyZGdMjr6e22prS5NrRTtC99IKtyGu6GQI9bFk/soyhqdovDFwUTfWch+E3D6AhtB3UQb8B7aTfMLROigtXVxoB18uede7BzWOaweceO2Qr8MF6rfKPEdVyfzqFkzDs4tCZaVk3FucV4LPXOJJkBGel/xdtOk9hcSHpl/F4Hdvr/AHfiXRJh7I48PXcR+9seiCMVXCwBdNZZwHsoYfQJ2lLBfYhy14JHCKqCac3wWitskIUwn3Yda+Wy5abT1llAeXS2i78Whg2XbOZE5PEvi098+RYMxnWPZ3sCiJkYxPduTK+UmvcpTMidy2EJ+gayYx9v0iIeCeOdB928xXTgbQmRFxdqc6KK9WIGngzYYqMjzarEv7PIwbJ6yLllFjiwzRKUHPw0yJwUMtbHtH6gGPbhxs3xMmkKAsuWcAbvuxhwyT1f67XW6qMd2T80Fvz2/YjW3azkwQFbLLp/xrFsq59tyDnXegKJk0nWE3HM9p62PBa0R/CG9ab+YkHxaum/V+FYV8BTUFk1GdxfYwFzBwu6KBsjuLBZq1XJFkQu8JeT+OTrsg5OozdTBRdLxTYqB60g== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(36860700016)(82310400026)(23010399003)(1800799024)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hBs7p9pNxyOOjdIkCCnuEvMnLIhuV2jBvsEWk+5IXHjB1vTI0dBoVprtMTkQw1SH4d2i0e7KfFNWjf/Fa1GKIMG3US2bvhmjWsC3Sqoec36ss8JjeIeGCAnKE46l8ADKnWB+0mzA0IO8RiolwYC/3ui4gX+5M4HieVXwD87kDYW+2iK3YlIULVO3EsBjvyavNSyfd/Pj71On4YsFR77dYBPxmjo1KzZDgWmctw8U3XwoMjabiVtRAKp2bnJ55pTQwlxK9NC5oZGfYiC7DsNnK32oYaJlyQKiseDQ+M8DC5NeJF65/8Jo4czV3tq7xd53xMrMFIa5r4sJAK+qpWn7yvx5FU7pfvDhA9+xcKX+k290Okx+KR4bzO9tC2mVSkyuth7zOqM4eEBf0mHmWG0bzdILXObpKsusoQ5ob9aq8Hbj3qz9FhYcypYHEuedAkut X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 09:27:33.8163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57e2fa99-d4bc-44ab-a630-08def6c19c07 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029928.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5677 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When initializing send queues, set the number of queues only when allocations are over. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index 1c9206f74aaa..f0c3a2bda0c7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -1121,8 +1121,6 @@ static int hws_bwc_send_queues_init(struct mlx5hws_co= ntext *ctx) if (!mlx5hws_context_bwc_supported(ctx)) return 0; =20 - ctx->queues +=3D bwc_queues; - ctx->bwc_send_queue_locks =3D kzalloc_objs(*ctx->bwc_send_queue_locks, bwc_queues); =20 @@ -1134,6 +1132,8 @@ static int hws_bwc_send_queues_init(struct mlx5hws_co= ntext *ctx) if (!ctx->bwc_lock_class_keys) goto err_lock_class_keys; =20 + ctx->queues +=3D bwc_queues; + for (i =3D 0; i < bwc_queues; i++) { mutex_init(&ctx->bwc_send_queue_locks[i]); lockdep_register_key(ctx->bwc_lock_class_keys + i); --=20 2.44.0 From nobody Tue Sep 29 09:08:35 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013030.outbound.protection.outlook.com [40.93.196.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE5323AB496; Mon, 10 Aug 2026 09:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.30 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354076; cv=fail; b=qDPTrxAzEm9A8ScQqmy9RlcyrtAV5b4mEJR9XbreNdLknvPIAS8eWvMOIZx7px54L2Y3AAyNKgdEHh8vWHyioIe9g7/hSu3KpvCRpPWgMMZV/qDvaBZIKw0Oi6PMRnV0swmLqeaw4zVdvRTBsFUkxpixHUjosihUJuZvHgRMcMk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354076; c=relaxed/simple; bh=BqdBky2MpSvkGrYn8twM8y154qItT/kJtjkfI/3F3vE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u2GpVlGkNk2j7M5G9hENLXRkIaF6e/GxOUzJypzIHziVCQpVBhuQ5kSwOuncnA/qDpT+AEVpQ6qmOWs4pjXKSUTK2gwJZ/tq31uqf2WewRPOVLtNkC2BrNj6j8JZ/phZVC8YnGyJ1+1e7hrFZDf8ITdHFvPvd2/hnQmLgCX/I/Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NB4cFGTb; arc=fail smtp.client-ip=40.93.196.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NB4cFGTb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vxaza2TL2zKAMQTaRn+NXVIzHzbtxFehlAX4dcv9lgZsCTx+xZwQ5EZq8DY9A6ToAavNSxWYXE66E3eG4Oo+l9ULl13gpzTdkNiWd04jfsYNs9129nqslXHoD5rFCFbFWcCE1W1dNg2jt9M1iyJHQGMQwUCdlnfKouIFRPSQAxXAy7bZgu9oZygchlYt/L2WYDHW2cR8MT4/Y3F/V5+zAeDaEdTCcQt772HoNU+rXcSeH2t6ilq0KXJgp3VQhaaD2kHSkJnSJijlu2DqOJiMMegGm4YX+9u2kR3BgH5codHjkC3ZKJvN2jOE8gP51dZVJwY89mA1ZpVY5y1Ds5FUsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=waAq3pvXpaIpOkJbZrJVLU1YE3sH/BXHRAoWZqWHDQ8=; b=LhC+it6BNfZsFhVAmGGl/EQKpTnzHnA0CS7OZfRq798/4lcisBzJAPdw3O3/91c8YNrrKm/qwP5bj+MdTRm/UqAUIxLH+oFckT6qP59rZYrePuiL6xwExiqJD6MWHSwrHI+7Ans+mhRpa1BH4uQpQLnzJjrAEIHYHElu6QjtqoTQqI7yBV1F0NvrGncHfYVGnv1v7P6M4cpK8cwVzR2g+3jp1TvqhzEtalguOmxPxV2NmgJV+R76/3JSBWfyxPR+jpiBgdYuF9LUt5CYzp/gH/kV5v2g7zulXHPml7LEbkBBORliRfDjImLRLyC+0qcxb3XrXvv/uOJbL0X+51jCyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=waAq3pvXpaIpOkJbZrJVLU1YE3sH/BXHRAoWZqWHDQ8=; b=NB4cFGTbJ7BO56SRUayl1IlcQg1UeWgiReC4Wy9cTSJNJR16tNBxnz4CkUmln5LEtWLdZYuGtzHIitDCIhPsO40K/eXNlpYVCCdl7LtuGkO5m8PzQKHdgR5BRITm7ve22i9GsTRZUc57+G8yJZtJzYPuNWJdAsWZsug17s6S31UFKG/ZgnBLE2jeN6SX6jcsfKOJa7MpUN6PQQkhIusQMytAzQwOBnDgZsPA6kDQHVvd900IcGDRyHWgMYtKZp9zrIkpS9P0C6IhlJB1enze/BVzrJV0ru3EWt6A1JEFRGxKxOf11eYBpKrL2bv9yQO/6Pjn6Tgsub6UBVO2X70PRw== Received: from BLAPR03CA0063.namprd03.prod.outlook.com (2603:10b6:208:329::8) by DM4PR12MB5892.namprd12.prod.outlook.com (2603:10b6:8:68::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 09:27:45 +0000 Received: from BL02EPF00029929.namprd02.prod.outlook.com (2603:10b6:208:329:cafe::13) by BLAPR03CA0063.outlook.office365.com (2603:10b6:208:329::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 09:27:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BL02EPF00029929.mail.protection.outlook.com (10.167.249.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 09:27:45 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:24 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:23 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 10 Aug 2026 02:27:17 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V2 4/5] net/mlx5: HWS, Remove redundant MLX5_SET in RTC creation Date: Mon, 10 Aug 2026 12:26:29 +0300 Message-ID: <20260810092630.3137666-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260810092630.3137666-1-tariqt@nvidia.com> References: <20260810092630.3137666-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029929:EE_|DM4PR12MB5892:EE_ X-MS-Office365-Filtering-Correlation-Id: 75a7503b-3191-46f0-7bc8-08def6c1a2fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|7416014|376014|36860700016|1800799024|18002099003|22082099003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: lsd6FdT63fELhtjXjI0rFDrb4Xmcmd90dM27T3BdwL9N/q8XMhBrc0RdSpdOzYVYRt3snmkj0/Fa8pLmH4D+GgHRgD+Wehx4oq3L6TFeGyS/U4e70beOQXOwqsCeVSIOoGc2mz3Av0SDNbIGVuuYkqVs2eKSIkIN1wB41UIFfDmxzOh+DCS90pjysm8Wc88sQfR/xINZ42CfQh7/d+rWZlWgZ8zFgeMDT90llvb6+/naw8SI5ZfDNP6k2HrmesJ1DaEGsSynlICmrRZRmz5abdeULZXKDlyND1IF1APOEAJdm5QHxGXvw47keE7WMc5Ek4Mb8SItcE/lu1gLxNu8MEUcCxuFFHrkjmuFOvd4a9KYqBBwrkuIYA3LPhY/sRoTNmtLQX3XLIWcsxvYPMI/PNLKLrM+fMEDPj8CVLOzJ4pJEK50JUtHUY3pRyjqu8NRfTZARomSnVz52mt8nDGxIu27SqjWHSP8HnupwuxZg1o4SifUvvWlooTYoilhEzDaMhyCYss1ghzkS96vfAL6U696/3WIc4cxI3xVOxYmnOttt7iNwgESRvqSMUntWJ5VIZxP1ntERr2warD8ljaB+Ufm28cnTl1vDrRA1XgRwqWkRHyb3ihlKGmUrHztpEC6CTuRj+/fo8dBXSgm5wrdXDMHoc8/NDuzdMDHurcJinb6n+fKyhBw8tyjNZ/SkTCseu9BfMku6WOL0gsT/rsFSg== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(7416014)(376014)(36860700016)(1800799024)(18002099003)(22082099003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MUyzbVBcNhcv9i4svGDYgzgajIA3Dsf9H/KBcLi3tVW7VWLLdisY9ROvlIO2gkF9tTPQoBK3dsFJlc/DdvNqjjSBwBXqzl20mWya4IPaMlXUMTvhlvrOEGaQoaAzesEgNk+unOfpeONDBzaPky9t/yPAesYIqgW2j5WMkhRPyZBHgXfTkeE8EHJDP3FxC/JvDb2ZgEHkss+D3u6UFoAqPVJhFzeUp54ZRu+BsTLwx9joRP595ByfH8Ff3sAP7XEGotGtdvdd6oSZZqaLeCyzjKCOsN7RskJeHMGejNgGzUKIli0LrzHc5qslWEK4x02xycTLNrvbu7C2qzVRiwdVzxkpfZntM/oEx7LcySRNydwvou1Dwnh15iQuvgM2Y7tnTLnzLmIVfFcw9Q+FAp4Rl/JCX/NzBP6cQKiLiK9d0GBXF1eE0cVvdpcHHcxVKPi+ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 09:27:45.4822 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75a7503b-3191-46f0-7bc8-08def6c1a2fa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029929.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5892 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Remove duplicated setting of field in mlx5hws_cmd_rtc_create(). Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index 2cdc03421433..3782d793550d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -398,7 +398,6 @@ int mlx5hws_cmd_rtc_create(struct mlx5_core_dev *mdev, MLX5_SET(rtc, attr, update_method, rtc_attr->fw_gen_wqe); MLX5_SET(rtc, attr, update_index_mode, rtc_attr->update_index_mode); MLX5_SET(rtc, attr, access_index_mode, rtc_attr->access_index_mode); - MLX5_SET(rtc, attr, num_hash_definer, rtc_attr->num_hash_definer); MLX5_SET(rtc, attr, log_depth, rtc_attr->log_depth); MLX5_SET(rtc, attr, log_hash_size, rtc_attr->log_size); MLX5_SET(rtc, attr, table_type, rtc_attr->table_type); --=20 2.44.0 From nobody Tue Sep 29 09:08:35 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010068.outbound.protection.outlook.com [40.93.198.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2610831B82B; Mon, 10 Aug 2026 09:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354076; cv=fail; b=UMa0RgUJUy1HGFbA4PIIslL89+7uijTMV7+bQy0UPQJcRG6qmsN/WJeUvM+fG6JBcDz4KC9oA85w3QBFcTXTxFqZl4EzTJA15yTB11cl58eHG41wd8RmiAnBHKBUoeh6U8bdKlucEFm0QCxmO2cm1zym40+fnNOIymIaMyCevjI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354076; c=relaxed/simple; bh=ZfmuYhxhzd7qOVmX2xgtJ3BnW+EAFsqjVi7n0Yy9Uvk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qrZ81Btln+X234QYgcaTjHD7ZNIgTEHpuu4yixpv8+E9G85++BnJtfapBRN85BoCQyhexnMDvYK2Pb+JbpuFs/kmyzyyWgtddYsWL9UPncEzHtHjTT93ieTbfTx8njJdXAyjcA0Qrh6Wbv/VzmbSeqNUobE+TNuAVV7NjzsIFGg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=emVIIZbA; arc=fail smtp.client-ip=40.93.198.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="emVIIZbA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rF6apNT139UqFc7q+B+TgN0G2Vu3ER0G19OZ+Bzlvd4pqMt5UKOScCU5S7SpYOAJFficNuKTPzZp1fHt0kc4g2Yvv2fRZL4lsQdzc6I4L4fJhsAGYsN/Ng8jT3CJwHO4v6nCW5fwOtYM+uRP4xbWrjWsnDPpD2Gn0mjsQvNY1ndNDA35YU42dS/WPDBTQ/boMyzezWNrq2qhsOorD9tsSGfyE/Ni+YUL36Ldfqx3FD19j4szhKQByRFmOHVx5zSJMUB4RMw3y0P7xRYFnqmNo4SEbpgBi0+LfznZxIPnc8ejQ/WkcaYjQunlAnZUYar6aynJGwQM1NXPsUrhAMu/zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fw336ks0vWngNLjiNjUDNAt3ba7wb2b7GXRkR/DneGU=; b=rH9IHbz1X+3inA6xmXJ7vi2y7RsbQradKxHo8YlRGZtjlWEgET9E6h086bP1KfOmrZb6OyOnOKW/3KIOsUz6EBOIkrygZgjw3HGK6+1HPI218jIjttFvTIoLTX75X6XKwZVzTzArfsUxx11kPSfTKuYYeRydkXZgKxEqjxc93Sf2liCRV1nQxIAoTU5dOFrD/R0HcGzv1zp5KdeSnq57LCaDiI603xnh90CE328dMwr+DDVmPvonoEQx0h2K3qhMXj2/wb0GO/HCwZrOvG0z6dHMEsF5apX+6NmyU4dJsEFUqPC0z0zbj+5ksTk9O3ROPaFRVk25cLPKpoy0kQrtRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fw336ks0vWngNLjiNjUDNAt3ba7wb2b7GXRkR/DneGU=; b=emVIIZbA5Ypk3jLLMgtsSeeJ2suJPsY+8Q0AiEz8ey2U8nCi4nx+CPnvvCuDJmucNj8tu2d1BrS/X4SRwugygvCbZBPBjU+sTRLthVaCTbN+S6NCbfL9G0VIyzGcbm7xJh13c4Zapq4RVgX0gCjBrKeFGjWPuNnt7Bc/yaKoTjak34J9FPtVkEyBdNRlwH4Sspct5zku5O13DLyU19rmdLnmmsn+jvE4AdaqEst+5qWjdm2xjiU8VuSe7jCwaCYbnLPUo3r+nPm+bsjqGKwkuP4xbkIO3pGmWM7hVFzUkwLhwyPRrL2KGaPdkrWlmLsWyoTIcZho/MIRq8vkrxuXEg== Received: from CH2PR20CA0025.namprd20.prod.outlook.com (2603:10b6:610:58::35) by MW3PR12MB4457.namprd12.prod.outlook.com (2603:10b6:303:2e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.15; Mon, 10 Aug 2026 09:27:51 +0000 Received: from CH1PEPF0000A346.namprd04.prod.outlook.com (2603:10b6:610:58:cafe::76) by CH2PR20CA0025.outlook.office365.com (2603:10b6:610:58::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 09:27:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH1PEPF0000A346.mail.protection.outlook.com (10.167.244.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 09:27:50 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 10 Aug 2026 02:27:31 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 10 Aug 2026 02:27:30 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 10 Aug 2026 02:27:23 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V2 5/5] net/mlx5: HWS, Remove redundant FW command when reading caps Date: Mon, 10 Aug 2026 12:26:30 +0300 Message-ID: <20260810092630.3137666-6-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260810092630.3137666-1-tariqt@nvidia.com> References: <20260810092630.3137666-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A346:EE_|MW3PR12MB4457:EE_ X-MS-Office365-Filtering-Correlation-Id: cff54b7a-eee1-484e-53ff-08def6c1a5d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|23010399003|36860700016|11063799006|56012099006|22082099003|18002099003|10067099003; X-Microsoft-Antispam-Message-Info: DFYEAijhFyz//UD/t5UMI59Fkwgihtmc2AG16jDJpbAXyS/rrR+wyAl4J8JSCe2EjdJ/rifuApxKe9/dQjEyuy//rfYfoE0RV32YtIm8klPWRDqRmCEVAoAEyPDcMCfFTfDbXhaRPMEdYUiW+osJVC29b7c9Nfu3SpY/BIvjDwe7jb1J7KB5vPoPy6DtrH5JWG9yfGg47IMOpXxd1S7Nl5Z+O2a65ttY1pcZMexcud4iX2vDKfF/ciOZUsjrMJIXIJX6JlgQd5vR3BIYZGIkA70cHjJIPUfqLH3dOoylMEGdsyYOCT+GKEyZzbOTrWiKnkPValcR6rg2HbpeoJIRdDXLsrN7xvo30+iUBMPc3pxPmK0SZuCyUjyhHtcHsgi9Dl2e8xLUAk1Mn1l52EpDLiEq0y5g3NCvMDIN48OJAeLG1uZhyiuWOUUITAPm4woxduz8r//Asy7ohMTswELkbBydHwbenRQvfrgVQZ16uSPvkFIJSVWMssvvOGVO5B0DpP03dp/0RqCZ4rBMhiXFXvAwlldebWtp5tOglyV4COonIwROFiw3dO5L0ffff4dIJPWCa806CVHrR7y7MFsNz5b+8IM9NYIRcQiyOur/IQBusCJI349cP4RYHP+WNYrOJ7YGI4EPNqQgb2PfTrTskhnupI8T/pTemTk9JpJsN990yiB4cOWwVRZBoH2QxDUCv9svbVYxmRVJo4u6LJTIbw== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(23010399003)(36860700016)(11063799006)(56012099006)(22082099003)(18002099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ISGABVf5vlSNLBxKGEs08hffODg0rYEsB6+1Mo56fGWZdY8WsIms/yylW6tHYzvSA1Gwp34PPcF4h3q+uY62hr0F5PTxJMgfUr+HzsHf+m7cx64LcM7bpsqnvsWFDaV2vS4rSqOjKWh2mCqTJLbPCyphGLx2R2vFfMdV0UIWOYki+5utHDWBd3ZfcRicrKQjazj7iLshoEEeE+Jo/tJ7FNr1fGhVgKaWfWhPlYhzJ6O3pjIb0N+T9fDVZRyPgFNuNOrFaKxWHwQw4AjIiSIVW84PGTb2N3qxxNSQNdSn2okcHii1MiIoPFjoQkiV9ScMDQ+VqfAuscQHazn58Jt2pdkFtHQD8CX6UqWmjjSHGn7ArZriID4Y2K9MBDUAB16qZDG3Xg3vA+JU+d33Ytth4gBbMF33B1MoV+JnrtQvuIjutETQMmccRtCAjReHiggh X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 09:27:50.3175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cff54b7a-eee1-484e-53ff-08def6c1a5d6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A346.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4457 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Remove redundant FW query that isn't really in use. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index 3782d793550d..775dc5c2d7a6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -1182,12 +1182,6 @@ int mlx5hws_cmd_query_caps(struct mlx5_core_dev *mde= v, capability.e_switch_cap.merged_eswitch); } =20 - ret =3D mlx5_cmd_exec(mdev, in, sizeof(in), out, out_size); - if (ret) { - mlx5_core_err(mdev, "Failed to query device attributes\n"); - goto out; - } - snprintf(caps->fw_ver, sizeof(caps->fw_ver), "%d.%d.%d", fw_rev_maj(mdev), fw_rev_min(mdev), fw_rev_sub(mdev)); =20 --=20 2.44.0