From nobody Tue Sep 29 09:08:29 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95C7F39CCF9; Mon, 10 Aug 2026 09:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786352854; cv=none; b=kDhKfLFiMWr+Fy74JjSr6iH4+w6KIy9K2xhdnfiPkuXT92kpWzjJhXtSi74XlVEukNQ26nOau2q8a0o6ant80EKIg9by8VrTpTOXIdAFeznVwcWP8Azb+TRkjs4miP1Kh2qBiTy0lAhay81twPQiP85xyL79jvOnpL18hHT66aQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786352854; c=relaxed/simple; bh=xa78jNuHvayG1KaCaq7REqe7r+ZZLRS4/vOo4+m26K8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kT42X0uevlNIyOYg0Rq+MzhaM3UBKBruSQTLiuarccT+bIKjuB8JldjK4YmysxMJKPFZXpmXWChqm94TtzMQoMGoBZF/peRB+c4O5zothwBOQmflU1CNJcd4OKRdCLoHp/UI3l+A86pwWinrKKCFqtTPrvt1qTlwJEMa0Tny10Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=p9pjXXIR; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="p9pjXXIR" Received: from CPC-namja-026ON.redmond.corp.microsoft.com (unknown [4.213.232.21]) by linux.microsoft.com (Postfix) with ESMTPSA id 7192520B7166; Mon, 10 Aug 2026 02:07:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7192520B7166 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1786352829; bh=Bx26xf7cHtvbDBbCkLmMLyTj3yU5wo6z0sqPBJm9JBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p9pjXXIRyC0Kg1gTcXxO6D8U226lLA1H4p1gYy4Pj91Tet/vs8/e8+FG+V5YILE0G WfwbHqQHKea9392eXQl97GZsIdqSYSudP7Rjse3m0yVgR8P9nd0mCAmfBfiDbWg7ie FE54+YmQqTS+XxZrBg2reozGYl7RIgZfgRwgIiWA= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "Joerg Roedel (AMD)" , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: "H. Peter Anvin" , Suravee Suthikulpanit , Vasant Hegde , Robin Murphy , Rob Herring , Shradha Gupta , Aditya Garg , iommu@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] PCI: hv: Set irq_retrigger callback for the Hyper-V PCI MSI irqchip Date: Mon, 10 Aug 2026 09:07:13 +0000 Message-ID: <20260810090716.2325295-2-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810090716.2325295-1-namjain@linux.microsoft.com> References: <20260810090716.2325295-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Hyper-V vPCI MSI irqchip never installs an irq_retrigger() callback. On CPU hot-unplug fixup_irqs() migrates the interrupts which are affine to the outgoing CPU to a new target. If an interrupt still has its pending bit set in the outgoing CPU's IRR at that point, fixup_irqs() resends it on the new target through the irqchip's irq_retrigger() callback. As the Hyper-V PCI/MSI chip does not provide that callback, the pending interrupt is silently dropped, which can result in lost interrupts, stalls and "No irq handler for vector" messages during CPU hotplug. Install irq_chip_retrigger_hierarchy() as the irq_retrigger() callback for the Hyper-V PCI/MSI irqchip, so that a pending interrupt is resent on its new target CPU via the parent x86 vector domain. Fixes: 4daace0d8ce85 ("PCI: hv: Add paravirtual PCI front-end for Microsoft= Hyper-V VMs") Cc: stable@vger.kernel.org Suggested-by: Long Li Suggested-by: Thomas Gleixner Reviewed-by: Aditya Garg Reviewed-by: Shradha Gupta Signed-off-by: Naman Jain --- drivers/pci/controller/pci-hyperv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/p= ci-hyperv.c index cfc8fa403dad6..89816a2bd7cd3 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -2119,6 +2119,7 @@ static bool hv_pcie_init_dev_msi_info(struct device *= dev, struct irq_domain *dom info->ops->msi_prepare =3D hv_msi_prepare; =20 chip->irq_set_affinity =3D irq_chip_set_affinity_parent; + chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; =20 if (IS_ENABLED(CONFIG_X86)) chip->flags |=3D IRQCHIP_MOVE_DEFERRED; --=20 2.43.0 From nobody Tue Sep 29 09:08:29 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 725423AB286; Mon, 10 Aug 2026 09:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786352861; cv=none; b=uc27wb2dIpu66OiZpneIXEQd9FHmswIQWy9YZlNUono2ZOlmvAOQxtNBvPoz5kfnq1jeLoYALJlkpj9NcIfDM8cclOxoCzAcg/1HhfpZcaKMjVWWUBKeROmbTLyOeTSQssws9PBNQK0uKJ7omF+2QMnGPV86k1LZKA/BmL3sZhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786352861; c=relaxed/simple; bh=8hRhto7yu1YdfxQ/es9BJ2LPlFdXAoHdDj6NeWX6zQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LCVqUZxB1fzNHAux/JyAtKHFXbkGjK9PuM1fuy9X80ebixOyvpD9Xc3mcNdd9Lvlbijp+oBmmSztyahhxULmVm41Qa8a0tMS4OtxjEIeEQ/t1uExGeAaT94jbWT1XiLcossfWLrGo2Pt4M3SmjSXBlJJVw/RRFi6b6dRPSs5n6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=FmGA0vpI; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="FmGA0vpI" Received: from CPC-namja-026ON.redmond.corp.microsoft.com (unknown [4.213.232.21]) by linux.microsoft.com (Postfix) with ESMTPSA id B879020B7168; Mon, 10 Aug 2026 02:07:10 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B879020B7168 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1786352836; bh=aP+Szq1FgVdmKtut4AqYblFcxzvyIhDJq4aWTv43pM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FmGA0vpIITa1t3cnGHPp6hbpx5ttlLd3lihgXL9JsMZ9vT+09rk4r5XxE0gXo/6bW Juxs3m4kaRvwSZ8XofRV/ExMfU4hgBfDAz2AndojxBcVhvDG485LEwwRjBbDHm/JaO gsx3tIzuMlMadVShlG2Bo3IC6hAOeF8Nq8Fu6oJA= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "Joerg Roedel (AMD)" , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: "H. Peter Anvin" , Suravee Suthikulpanit , Vasant Hegde , Robin Murphy , Rob Herring , Shradha Gupta , Aditya Garg , iommu@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] x86/irq: Use irq_chip_retrigger_hierarchy() in fixup_irqs() Date: Mon, 10 Aug 2026 09:07:14 +0000 Message-ID: <20260810090716.2325295-3-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810090716.2325295-1-namjain@linux.microsoft.com> References: <20260810090716.2325295-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fixup_irqs() re-injects a pending interrupt on its new target CPU by looking at the outermost domain chip and invoking its irq_retrigger() callback directly. That only works when the outermost chip happens to install an irq_retrigger() callback, which is not guaranteed for every irqchip and could lead to lost interrupts on CPU hot-unplug. Use irq_chip_retrigger_hierarchy() instead, which walks up the interrupt hierarchy until it finds a chip that implements irq_retrigger(). While at it, move the loop-local variables into the loop scope and use a scoped guard for desc->lock. VECTOR_RETRIGGERED is now set only when the retrigger succeeds (irq_chip_retrigger_hierarchy() returns non-zero) instead of unconditionally. This is harmless today since apic_retrigger_irq() always returns 1, and arguably more correct. No functional change intended for chips which already provide an irq_retrigger() callback on the outermost domain. Suggested-by: Thomas Gleixner Reviewed-by: Shradha Gupta Signed-off-by: Naman Jain --- arch/x86/kernel/irq.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 30122f0b3af96..ef1bdd3c4659a 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -466,11 +466,6 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_posted_msi_notification) /* A cpu has been removed from cpu_online_mask. Reset irq affinities. */ void fixup_irqs(void) { - unsigned int vector; - struct irq_desc *desc; - struct irq_data *data; - struct irq_chip *chip; - irq_migrate_all_off_this_cpu(); =20 /* @@ -489,22 +484,18 @@ void fixup_irqs(void) * vector_lock because the cpu is already marked !online, so * nothing else will touch it. */ - for (vector =3D FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; vector++) { - if (IS_ERR_OR_NULL(__this_cpu_read(vector_irq[vector]))) + for (unsigned int vector =3D FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; = vector++) { + struct irq_desc *desc =3D __this_cpu_read(vector_irq[vector]); + + if (IS_ERR_OR_NULL(desc)) continue; =20 if (is_vector_pending(vector)) { - desc =3D __this_cpu_read(vector_irq[vector]); - - raw_spin_lock(&desc->lock); - data =3D irq_desc_get_irq_data(desc); - chip =3D irq_data_get_irq_chip(data); - if (chip->irq_retrigger) { - chip->irq_retrigger(data); + guard(raw_spinlock)(&desc->lock); + if (irq_chip_retrigger_hierarchy(&desc->irq_data)) __this_cpu_write(vector_irq[vector], VECTOR_RETRIGGERED); - } - raw_spin_unlock(&desc->lock); } + if (__this_cpu_read(vector_irq[vector]) !=3D VECTOR_RETRIGGERED) __this_cpu_write(vector_irq[vector], VECTOR_UNUSED); } --=20 2.43.0 From nobody Tue Sep 29 09:08:29 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 528943A7F70; Mon, 10 Aug 2026 09:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786352868; cv=none; b=ONiwSDBAdFGKni9aWVz5VJnsk0oHQ7e8VGM+bDiLc/gcw4ZFFCF0UQK17F0O/Wj54q8GBB+6/7+6Ly7NCfUs0Yzs80d/mlQK7Tv/k/KpvWLAEmgs79byUy/lbiNzG6rO46I9a6P2LFpLJsC+VB2k4/5FzGuTI3NmyYOOsY3VXs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786352868; c=relaxed/simple; bh=dq/A2v5+etrksRvi7qmuduZ/iZcd5D3k4Vz3TrAHijI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m6CIRly+BOHD1+F4AcS8vuS3wWmXd+beUTNeFcCWfn1LC80gLoUFN2oa52Qfh2bNooT0GXi0KYBiTNeH8o4j863A8/uY3CxYMELdhzdxyyvMWtyGEIMqpwE1cOMQ5BHR6vjTZ2nNACWLP9ApWTUF7BTPsmbhLGhK5PoRH3zEM+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=mv6MNBpM; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="mv6MNBpM" Received: from CPC-namja-026ON.redmond.corp.microsoft.com (unknown [4.213.232.21]) by linux.microsoft.com (Postfix) with ESMTPSA id 95E3520B7167; Mon, 10 Aug 2026 02:07:17 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95E3520B7167 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1786352843; bh=96bTBIBFEOW1MixlLS37u+fHUKwiZbfrMXUEqQ5FKdo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mv6MNBpMGh49OBoBNSZrTktPX2/sHn0UFTqSMpYPOimrzS7Wgt6jY/kcb9651YdU/ SBwec8CmDhESP2bUTPgSEDi2NrEMcObDPDxap5qTCYiByXJ+WrIaHOG6shjl0HSGAy JKcfZriaGEt6wkTRFizUN147xudxZBjWKtSu2qMo= From: Naman Jain To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "Joerg Roedel (AMD)" , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: "H. Peter Anvin" , Suravee Suthikulpanit , Vasant Hegde , Robin Murphy , Rob Herring , Shradha Gupta , Aditya Garg , iommu@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] x86/irq, iommu/amd, PCI: Drop redundant irq_retrigger inits Date: Mon, 10 Aug 2026 09:07:15 +0000 Message-ID: <20260810090716.2325295-4-namjain@linux.microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810090716.2325295-1-namjain@linux.microsoft.com> References: <20260810090716.2325295-1-namjain@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With fixup_irqs() now using irq_chip_retrigger_hierarchy() and the generic resend path (try_retrigger()) already falling back to it, installing irq_chip_retrigger_hierarchy() as the irq_retrigger() callback on the outermost domain chips is no longer required. The hierarchy walk reaches the x86 vector domain's apic_retrigger_irq() for all of these stacked domain chips. Remove the now redundant irq_retrigger() initializations from the outermost domain interrupt chips. msi_set_affinity() is the only site that invoked the outermost chip's irq_retrigger() directly. Convert it to irq_chip_retrigger_hierarchy() so the x86_init_dev_msi_info() initialization can be dropped as well. No functional change intended. Suggested-by: Thomas Gleixner Reviewed-by: Shradha Gupta Signed-off-by: Naman Jain --- arch/x86/kernel/apic/io_apic.c | 2 -- arch/x86/kernel/apic/msi.c | 4 +--- arch/x86/kernel/hpet.c | 1 - drivers/iommu/amd/init.c | 1 - drivers/pci/controller/pci-hyperv.c | 1 - 5 files changed, 1 insertion(+), 8 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 7d7175d012288..18f49a251f23b 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1857,7 +1857,6 @@ static struct irq_chip ioapic_chip __read_mostly =3D { .irq_ack =3D irq_chip_ack_parent, .irq_eoi =3D ioapic_ack_level, .irq_set_affinity =3D ioapic_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_get_irqchip_state =3D ioapic_irq_get_chip_state, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | IRQCHIP_AFFINITY_PRE_STARTUP, @@ -1871,7 +1870,6 @@ static struct irq_chip ioapic_ir_chip __read_mostly = =3D { .irq_ack =3D irq_chip_ack_parent, .irq_eoi =3D ioapic_ir_ack_level, .irq_set_affinity =3D ioapic_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_get_irqchip_state =3D ioapic_irq_get_chip_state, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP, diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c index 66bc5d3e79db3..aad2f15eb2176 100644 --- a/arch/x86/kernel/apic/msi.c +++ b/arch/x86/kernel/apic/msi.c @@ -137,7 +137,7 @@ msi_set_affinity(struct irq_data *irqd, const struct cp= umask *mask, bool force) * IRR. */ if (lapic_vector_set_in_irr(cfg->vector)) - irq_data_get_irq_chip(irqd)->irq_retrigger(irqd); + irq_chip_retrigger_hierarchy(irqd); =20 return ret; } @@ -246,7 +246,6 @@ static bool x86_init_dev_msi_info(struct device *dev, s= truct irq_domain *domain, info->ops->msi_prepare =3D x86_msi_prepare; =20 info->chip->irq_ack =3D irq_chip_ack_parent; - info->chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; info->chip->flags |=3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP; =20 @@ -313,7 +312,6 @@ static struct irq_chip dmar_msi_controller =3D { .irq_mask =3D dmar_msi_mask, .irq_ack =3D irq_chip_ack_parent, .irq_set_affinity =3D msi_domain_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_compose_msi_msg =3D dmar_msi_compose_msg, .irq_write_msi_msg =3D dmar_msi_write_msg, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 8dc7b710e1250..2bb7a6f466af3 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -509,7 +509,6 @@ static struct irq_chip hpet_msi_controller __ro_after_i= nit =3D { .irq_mask =3D hpet_msi_mask, .irq_ack =3D irq_chip_ack_parent, .irq_set_affinity =3D msi_domain_set_affinity, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_write_msi_msg =3D hpet_msi_write_msg, .flags =3D IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP, }; diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index ea3377e61aa5c..0c362e86a09d9 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -2468,7 +2468,6 @@ static struct irq_chip intcapxt_controller =3D { .irq_unmask =3D intcapxt_unmask_irq, .irq_mask =3D intcapxt_mask_irq, .irq_ack =3D irq_chip_ack_parent, - .irq_retrigger =3D irq_chip_retrigger_hierarchy, .irq_set_affinity =3D intcapxt_set_affinity, .irq_set_wake =3D intcapxt_set_wake, .flags =3D IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_MOVE_DEFERRED, diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/p= ci-hyperv.c index 89816a2bd7cd3..cfc8fa403dad6 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -2119,7 +2119,6 @@ static bool hv_pcie_init_dev_msi_info(struct device *= dev, struct irq_domain *dom info->ops->msi_prepare =3D hv_msi_prepare; =20 chip->irq_set_affinity =3D irq_chip_set_affinity_parent; - chip->irq_retrigger =3D irq_chip_retrigger_hierarchy; =20 if (IS_ENABLED(CONFIG_X86)) chip->flags |=3D IRQCHIP_MOVE_DEFERRED; --=20 2.43.0