From nobody Tue Sep 29 09:46:29 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8151531E8 for ; Mon, 10 Aug 2026 07:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786345835; cv=none; b=b6Ef9G1tIC/TRma4xCEcTC5nEmAPaMokISxYC2MH0NaFB6klm6CWKebrREe7uz05xsTv7jKO0q+GuJO0//hNAqICoV387AiU/HmB7KgCulUU1F5WCy+w4gAuA05t+8d+KpZ3jn5crxLDv7ch3OCaKUnCGEe0DUR4VI9QrdskU04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786345835; c=relaxed/simple; bh=bpIjd0JSD5iJRN7x9LGStehSlvHl6S8vFDF2XG8IT5E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AAcZ7xw7tGB5oi3FsSrsOwnO29vGOua5OVxhNyLHekDL2/K4vaprJgUY2Bv+DrClSQIUmAGgRH4aax/z1dSDRK68egQbHjRC4hrXg3fjTZVEu+tAym8w4pFS0bQqw73So9qT+4R5rH89B01SJb5fdwlEwivUPh5E15CU6d0o3lo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GIGXe26l; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIGXe26l" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so1106716a91.0 for ; Mon, 10 Aug 2026 00:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786345833; x=1786950633; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=K9nB2oQTUrELANq8ic+RN9MK7QqxEtLte4dfvgMoHiU=; b=GIGXe26lI/TFLIbuV5I3bqbtNqSesCPncoGg1JRRMe/QP8dtQHbgahbJgnXvPrttXy Bz2JzIeSo6q6QZuJO/sWY2XgeG45ShNcYEJovaI9BMD3MN4tT1Fiub9d02W/adFwikHK dwU3uMSqnk1YHlmSLfWbIVx1yF/Y6/zmmZrpWa7EFz0uSEf75WfwmdA9MrULezXyTbK/ buU8ESxvSSauJtHMRSw0qJwoKfrXjNbPYErZ35sUCXCVnMu5uiHRe0E40mvcf5kTZh5X pCcpNv7P4UMob365YEGDe1Z59gBiavBVaA0fAfJb7xU9OH6OuSGpcKrSiE3P7uPD/Ca/ pG8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786345833; x=1786950633; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K9nB2oQTUrELANq8ic+RN9MK7QqxEtLte4dfvgMoHiU=; b=RXSnC7ZLCb5hLnzugdHsW+axwInYwGIRjsLJQSEY5k8H0gM7vAFrdSuD0om2LY9jXz TLmsD44pXw3Q6uyU9P19ZLMktNjMl/VhnXqkL3b5xUT5bktjSE9qEQIVOVI/V07+F3W5 3MAaEjgTCvzezU2TEiBwuPdb6Z9O1NE/vzcPyICw4Y+CEB5xVLXpwZFpy2sRiUklPBdD QuBxS4cIQ3hhG8OMmFwJdQpZ8ap1KMb31qR1TMtVXui0B2i+boj6cNUOqFfuuM3rPcGO OFVQfLgaJDpcs5U8WgHZgLLTpV8seDcW9dv1bDteYOGi+kF6cPREr3SODiAq+NdbH5Tx xYIw== X-Forwarded-Encrypted: i=1; AHgh+Royra22WfIYLLEcnk/m2wxSP/twnJOF7trCvUVUQTHvegLha567rott13IS4cBt5fCuPbysXjdrNRwQPio=@vger.kernel.org X-Gm-Message-State: AOJu0YyndzYtGmOdACxYQ0oEmtt87lLWqH2lVUIG/h2Is+GOBFOd9gnC Ict2RHA6IDWlu+vKWCRUnYMx//h3KvFtSSV+XagnK0U0eGCJUqSlMf9Y X-Gm-Gg: AR+sD132taO6d7bL8VkKKLVp5zZLj3cSLiciPCO9eOC9X1Be0K03r5y7WVoLPf/CHTS sAOKnYVYKvFaPAEtcxYFPUK8E/QURkrTjZKtPeyHhtcu8wvFoEf5TYJbN1Lw7+GC2r4CtEqOWQT gtvqJ5x01e5W3BgjzA+L+8QJdZK/oqIEVnt6qJKyC0RLslsZoEpGwaFtt8xTH6Jb5FVc98mssBo AlfEksIBuhZjXiPygh/4FtyWPZP1bOpP83onym2xlQkDVhDqy+bU4IHJPNPyWwajqlPfd3t8nX3 yZLZbc1z25tPsmi9qcMA4S/6PG0sYVT82VcMzIu6h4ik0w+snOI3r+lrZY1spK1qCOq+wQqtRUp zq3XemnMmol+Wbn0nhoOvPws8+zqNFLeJL4mxLkBSjizgXqDSaSbmFMQiEbtqKKUB7bAtFvMQGC sB1XE2uiEMJSsG63BBHvT3hCdSt5b5VP1/YazeYwJThMPIh3SGgT9+ZO5uIb1PRg== X-Received: by 2002:a17:90b:3d91:b0:38e:9ca8:e99 with SMTP id 98e67ed59e1d1-3928461bf33mr7453914a91.5.1786345833007; Mon, 10 Aug 2026 00:10:33 -0700 (PDT) Received: from localhost ([103.210.95.64]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39085c393d5sm13679304a91.0.2026.08.10.00.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 00:10:32 -0700 (PDT) From: Raushan Kumar To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Raushan Kumar Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in HalBtc8723b2Ant.c Date: Mon, 10 Aug 2026 12:39:17 +0530 Message-ID: <20260810070917.114190-1-mitramaurya80@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unnecessary curly braces around single statement if/else blocks throughout the file, as flagged by checkpatch.pl. Signed-off-by: Raushan Kumar --- .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 118 +++++++----------- 1 file changed, 48 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b2Ant.c index 6da6940c9043..56d6e79a6008 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c @@ -35,49 +35,43 @@ static u8 halbtc8723b2ant_BtRssiState( (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) btRssiState =3D BTC_RSSI_STATE_HIGH; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else { - if (btRssi < rssiThresh) { + if (btRssi < rssiThresh) btRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } else if (levelNum =3D=3D 3) { - if (rssiThresh > rssiThresh1) { + if (rssiThresh > rssiThresh1) return pCoexSta->preBtRssiState; - } =20 if ( (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) btRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else if ( (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_MEDIUM) || (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_STAY_MEDIUM) ) { - if (btRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (btRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) btRssiState =3D BTC_RSSI_STATE_HIGH; - } else if (btRssi < rssiThresh) { + else if (btRssi < rssiThresh) btRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_MEDIUM; - } } else { - if (btRssi < rssiThresh1) { + if (btRssi < rssiThresh1) btRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } =20 @@ -104,49 +98,43 @@ static u8 halbtc8723b2ant_WifiRssiState( (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) wifiRssiState =3D BTC_RSSI_STATE_HIGH; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else { - if (wifiRssi < rssiThresh) { + if (wifiRssi < rssiThresh) wifiRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } else if (levelNum =3D=3D 3) { - if (rssiThresh > rssiThresh1) { + if (rssiThresh > rssiThresh1) return pCoexSta->preWifiRssiState[index]; - } =20 if ( (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) wifiRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else if ( (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_MEDIUM) || (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_STAY_MEDIUM) ) { - if (wifiRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (wifiRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) wifiRssiState =3D BTC_RSSI_STATE_HIGH; - } else if (wifiRssi < rssiThresh) { + else if (wifiRssi < rssiThresh) wifiRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_MEDIUM; - } } else { - if (wifiRssi < rssiThresh1) { + if (wifiRssi < rssiThresh1) wifiRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } =20 @@ -168,7 +156,7 @@ static void halbtc8723b2ant_LimitedRx( u8 rxAggSize =3D aggBufSize; =20 /* */ - /* Rx Aggregation related setting */ + /* Rx Aggregation related setting */ /* */ pBtCoexist->fBtcSet(pBtCoexist, BTC_SET_BL_TO_REJ_AP_AGG_PKT, &bRejectRxA= gg); /* decide BT control aggregation buf size or not */ @@ -181,7 +169,7 @@ static void halbtc8723b2ant_LimitedRx( =20 static void halbtc8723b2ant_QueryBtInfo(struct btc_coexist *pBtCoexist) { - u8 H2C_Parameter[1] =3D {0}; + u8 H2C_Parameter[1] =3D {0}; =20 pCoexSta->bC2hBtInfoReqSent =3D true; =20 @@ -318,11 +306,10 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_= coexist *pBtCoexist) } else if (pBtLinkInfo->bA2dpExist) { algorithm =3D BT_8723B_2ANT_COEX_ALGO_A2DP; } else if (pBtLinkInfo->bPanExist) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANHS; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR; - } } } } else if (numOfDiffProfile =3D=3D 2) { @@ -332,11 +319,10 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_= coexist *pBtCoexist) } else if (pBtLinkInfo->bA2dpExist) { algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; } else if (pBtLinkInfo->bPanExist) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_SCO; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } } } else { if ( @@ -348,20 +334,18 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_= coexist *pBtCoexist) pBtLinkInfo->bHidExist && pBtLinkInfo->bPanExist ) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } } else if ( pBtLinkInfo->bPanExist && pBtLinkInfo->bA2dpExist ) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_A2DP_PANHS; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_A2DP; - } } } } else if (numOfDiffProfile =3D=3D 3) { @@ -388,11 +372,10 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_= coexist *pBtCoexist) pBtLinkInfo->bPanExist && pBtLinkInfo->bA2dpExist ) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID_A2DP; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID_A2DP_PANEDR; - } } } } else if (numOfDiffProfile >=3D 3) { @@ -417,7 +400,7 @@ static void halbtc8723b2ant_SetFwDacSwingLevel( struct btc_coexist *pBtCoexist, u8 dacSwingLvl ) { - u8 H2C_Parameter[1] =3D {0}; + u8 H2C_Parameter[1] =3D {0}; =20 /* There are several type of dacswing */ /* 0x18/ 0x10/ 0xc/ 0x8/ 0x4/ 0x6 */ @@ -430,7 +413,7 @@ static void halbtc8723b2ant_SetFwDecBtPwr( struct btc_coexist *pBtCoexist, u8 decBtPwrLvl ) { - u8 H2C_Parameter[1] =3D {0}; + u8 H2C_Parameter[1] =3D {0}; =20 H2C_Parameter[0] =3D decBtPwrLvl; =20 @@ -473,16 +456,14 @@ static void halbtc8723b2ant_SetSwRfRxLpfCorner( bool bRxRfShrinkOn ) { - if (bRxRfShrinkOn) { + if (bRxRfShrinkOn) /* Shrink RF Rx LPF corner */ pBtCoexist->fBtcSetRfReg(pBtCoexist, BTC_RF_A, 0x1e, 0xfffff, 0xffffc); - } else { + else /* Resume RF Rx LPF corner */ /* After initialized, we can use pCoexDm->btRf0x1eBackup */ - if (pBtCoexist->bInitilized) { + if (pBtCoexist->bInitilized) pBtCoexist->fBtcSetRfReg(pBtCoexist, BTC_RF_A, 0x1e, 0xfffff, pCoexDm->= btRf0x1eBackup); - } - } } =20 static void halbtc8723b2ant_RfShrink( @@ -504,7 +485,7 @@ static void halbtc8723b2ant_SetSwPenaltyTxRateAdaptive( struct btc_coexist *pBtCoexist, bool bLowPenaltyRa ) { - u8 H2C_Parameter[6] =3D {0}; + u8 H2C_Parameter[6] =3D {0}; =20 H2C_Parameter[0] =3D 0x6; /* opCode, 0x6 =3D Retry_Penalty */ =20 @@ -743,7 +724,7 @@ static void halbtc8723b2ant_SetFwIgnoreWlanAct( struct btc_coexist *pBtCoexist, bool bEnable ) { - u8 H2C_Parameter[1] =3D {0}; + u8 H2C_Parameter[1] =3D {0}; =20 if (bEnable) H2C_Parameter[0] |=3D BIT(0); /* function enable */ @@ -775,7 +756,7 @@ static void halbtc8723b2ant_SetFwPstdma( u8 byte5 ) { - u8 H2C_Parameter[5] =3D {0}; + u8 H2C_Parameter[5] =3D {0}; =20 H2C_Parameter[0] =3D byte1; H2C_Parameter[1] =3D byte2; @@ -824,7 +805,7 @@ static void halbtc8723b2ant_SetAntPath( u32 fwVer =3D 0, u4Tmp =3D 0; bool bPgExtSwitch =3D false; bool bUseExtSwitch =3D false; - u8 H2C_Parameter[2] =3D {0}; + u8 H2C_Parameter[2] =3D {0}; =20 pBtCoexist->fBtcGet(pBtCoexist, BTC_GET_BL_EXT_SWITCH, &bPgExtSwitch); pBtCoexist->fBtcGet(pBtCoexist, BTC_GET_U4_WIFI_FW_VER, &fwVer); /* [31:= 16]=3Dfw ver, [15:0]=3Dfw sub ver */ @@ -2197,13 +2178,11 @@ static void halbtc8723b2ant_RunCoexistMechanism(str= uct btc_coexist *pBtCoexist) { u8 algorithm =3D 0; =20 - if (pBtCoexist->bManualControl) { + if (pBtCoexist->bManualControl) return; - } =20 - if (pCoexSta->bUnderIps) { + if (pCoexSta->bUnderIps) return; - } =20 algorithm =3D halbtc8723b2ant_ActionAlgorithm(pBtCoexist); if (pCoexSta->bC2hBtInquiryPage && (algorithm !=3D BT_8723B_2ANT_COEX_ALG= O_PANHS)) { @@ -2221,9 +2200,8 @@ static void halbtc8723b2ant_RunCoexistMechanism(struc= t btc_coexist *pBtCoexist) if (halbtc8723b2ant_IsCommonAction(pBtCoexist)) { pCoexDm->bAutoTdmaAdjust =3D false; } else { - if (pCoexDm->curAlgorithm !=3D pCoexDm->preAlgorithm) { + if (pCoexDm->curAlgorithm !=3D pCoexDm->preAlgorithm) pCoexDm->bAutoTdmaAdjust =3D false; - } =20 switch (pCoexDm->curAlgorithm) { case BT_8723B_2ANT_COEX_ALGO_SCO: --=20 2.55.0