From nobody Tue Sep 29 08:25:36 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E59F43552D for ; Mon, 10 Aug 2026 18:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385413; cv=none; b=rT1m1zI2xLj3AWWhF5nj9fJWaU8iRNmR+izYjrGb5VRyI7y3tGkEHhNNX59J26nGOOBjBJmoL+rf3+iqDbHXv1iMFc5K4WdImT9W3IO2eaOQvrRRAxA8HoIP92HJ+aoi9+g/s37KIU8JXzREeIzjjQv1PzSCUmGBLtXyPlqUA1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385413; c=relaxed/simple; bh=bJXRfg3f1kV3ccy2QSpAR+7YljKtfWl7hXv2p8G7tDE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=HzC8kJbztQiBUftjtrXaG0Mg6SSfcWJhun3W+VwW75yrWqVw5mH/UdJ2QkW/J2iS8YhMX1N6q0U+koB9I19gKDbBlpJOirIHumh3uDVtaUyLBjPu2B0BFFFyrPHKzlLiOpsXc8Bt5E642ECtfrYxhO7N99+fT0am2SMla8TsgaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XnwI6LS7; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XnwI6LS7" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-498012a61f6so6145e9.0 for ; Mon, 10 Aug 2026 11:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786385410; x=1786990210; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=MxlbjW9Gub36tupqbS+bClfYkYoCr7n6Y2ztqAqDsEc=; b=XnwI6LS7t2Z8W2Cz9lwjpXK5z1zDiWF5FkF+g89cWWTRLra+eHUcZmvL0kM9g5PXpQ bO/yMV75GuZ7BRlehxzAcfy72re7jKYuOR5TPnzZ2GGn/AN527WOD4EUSwNf3rnXZ2Ux AQnPksMFoGFMKwdJqHf7tJNKNybNXNEThi/75dNUAAXrSQZ9lQbb1IEsLoHVOZGYAK4Y YdtkxSPEVUN2SHq4Vv8lYpZOLf2mVst9y76V/SIsImlaGLx/uDiEkFLKliSobPYyltHf Lr2xVsu8MTGX5p3Rs4ceoVLXV/xiiRBQg/VjWQwHUfaMPdqA4EcsPmXZNIv2FI9JtTYI qMdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385410; x=1786990210; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=MxlbjW9Gub36tupqbS+bClfYkYoCr7n6Y2ztqAqDsEc=; b=b/OC3vp5hrDL+0mCv4hMkow15Ug3a52yiKZAYqoNE0m+a6u9GGEASuP2SFgEjuZ+eV azm6iWV/MXxk2D65Dx4N0NOz/yjzxN53NLFu3ef6WsEGRtmYZkOLG+j8KSnkWE42S/fM bojQxfqy2TkdT+WiAVoSS6aKxzX7BzCCX4b4JWZsdR3O//9c8KVp7YcXtxPgyzPxFVvs fHTPOhM1fPwq42d6ARJdx8CPw7Dxln+Zl6lB/6iz+Z3ocQRQOgd8qJMxcpPQF9HihnC1 OiWbiubxSLreKCe1k0MCV2Oit73KZ8vc0zQtofCaTgZc1qVI9XLfvGsPl7X5HtHCsfWi EGmQ== X-Forwarded-Encrypted: i=1; AHgh+Rrb49Ah78N/q6gJgYcY9lcqf/E3bqN7zpIchUenJeA+cUFVpC6GmrNn0s8zaMKVIeb5Z3CiGqkq9GEBkf4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf84hPRtUrssEhpAqlFw1LrGJYCM8XZQVyXwKQRGlhdCuSaMex RQ8IllndPBsTihGEGtE/Zkyi4Oopp8yRnh33ooELQMZth7YUoyygbwQfMtJrMxuGrA== X-Gm-Gg: AR+sD13OeS2zjQmhsIvvzaeA9XSpBTSfAHjbakqJovH0z29P4QNqYB3GnJI8T0aWUOR BYzUidJaQudtCglsEvtp9IIaZzdbrWZaNF+FFr/Yx97AAzwqZTP4hRqcbofj0Y7qZUK4Zkn/+EZ zK2pFOYmumn7R2/bPcRVuA2zkuAf9Hn+QVHbouSMBlBkmeLqBt30FtNCTZ5byBNYdYKy3FiVCHn x4d/WBNjCzqRaH2XoQNecH7yKfumbT8MBqwyNIA8Bg7pMoeDie42zZa2jSr6mKdvdGXWYz7WdbT v+JiAGN4FAHMWAJXbBDFYKQUP4SAtAYphI8Ejihcq23N/LfNFumYBqz8rPZShcWWJco3Rz0qLlO v2Br64IVN72REo7q0AspYZdOP+WE5dIuiiPHXf7VCipWyd3JBPA/9IMQNfmmJ0uRA25e5xNGPcv 39PJDzLRiWnsOBP/1pG01uH7UOh+3ssUXwMS14bnq7hxIYbPzAmJQU0/EvNrkpSoqVQ3X/562ri u+vNT+6y9SiWObFVVWWd9zN79KIbJI3aXnxELGcFW/15Fo= X-Received: by 2002:a05:600c:4288:b0:495:3ffd:5e39 with SMTP id 5b1f17b1804b1-499745be994mr58225e9.3.1786385409115; Mon, 10 Aug 2026 11:10:09 -0700 (PDT) Received: from localhost ([2a00:79e0:288a:8:5c4:b02b:cff6:9cc6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499740e13e3sm9004625e9.10.2026.08.10.11.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:10:08 -0700 (PDT) From: Jann Horn Date: Mon, 10 Aug 2026 20:10:01 +0200 Subject: [PATCH v2] mm/page-writeback: document folio_mark_dirty() locking more explicitly Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-set-page-dirty-warnings-v2-1-1bd40fadfacd@google.com> X-B4-Tracking: v=1; b=H4sIAPgTemoC/4WNQQ6CMBREr0K6tua3gCmuvIdhUcunfKMtaStKC He34AFcvsnMvIVFDISRnYuFBZwokncZ5KFgZtDOIqcuM5MgT6AE8IiJjzrnHYU087cOjpyNvAK AHkDUZVOxvB4D9vTZn6/tj+PrdkeTtrutMVBMPsy7ehJb779lElzwujS6q1QDCtTFem8feDT+y dp1Xb9B6MN50QAAAA== X-Change-ID: 20260810-set-page-dirty-warnings-4000f0015394 To: "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jann Horn X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786385403; l=2530; i=jannh@google.com; s=20240730; h=from:subject:message-id; bh=bJXRfg3f1kV3ccy2QSpAR+7YljKtfWl7hXv2p8G7tDE=; b=df8Qhd2Ukq3GZytYeSVtH/STCIAEcIKcgxQNFYPewQdmLafxN/6eI7SK/34O21LsVc2ZWwJz7 KDS3Rs9yYdZCQoVCsnjhEF0af9LPwr0Xw2mJuc5ohMjYJYaw+SCGnq8 X-Developer-Key: i=jannh@google.com; a=ed25519; pk=AljNtGOzXeF6khBXDJVVvwSEkVDGnnZZYqfWhP1V+C8= We have had bugs where set_page_dirty() was used on a page from GUP without appropriate locking, leading to UAF, in: - KVM, see https://lore.kernel.org/r/20260810-x86-kvm-setpagedirty-v1-1-85f180892d4= f@google.com - i915, see commit 0d4bbe3d407f ("drm/i915/userptr: Try to acquire the page lock around set_page_dirty()"). - VMCI, see commit 5a16c535409f ("VMCI: Use set_page_dirty_lock() when unregistering guest memory") - kpc2000 staging driver, see commit b6d13bd9f2c1 ("staging: kpc2000: kpc_dma: Convert set_page_dirty() --> set_page_dirty_lock()") I think set_page_dirty() and folio_mark_dirty() need more explicit documentation on how they should be used with pages from GUP; so add a comment on top of set_page_dirty() and make the comment above folio_mark_dirty() more explicit. Signed-off-by: Jann Horn Reviewed-by: Christoph Hellwig Reviewed-by: Jan Kara --- Changes in v2: - reword commit message to drop references to out-of-tree drivers, and instead add more examples of upstream bugs - Link to v1: https://patch.msgid.link/20260810-set-page-dirty-warnings-v1-= 1-53cad4890808@google.com --- mm/folio-compat.c | 1 + mm/page-writeback.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/mm/folio-compat.c b/mm/folio-compat.c index a02179a0bded..6212fdd6761a 100644 --- a/mm/folio-compat.c +++ b/mm/folio-compat.c @@ -41,6 +41,7 @@ void set_page_writeback(struct page *page) } EXPORT_SYMBOL(set_page_writeback); =20 +/* Read the comment above folio_mark_dirty() regarding required locks! */ bool set_page_dirty(struct page *page) { return folio_mark_dirty(page_folio(page)); diff --git a/mm/page-writeback.c b/mm/page-writeback.c index e98748112d1e..b0ab687c83be 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2773,6 +2773,11 @@ EXPORT_SYMBOL(folio_redirty_for_writepage); * in this folio. Truncation will block on the page table lock as it * unmaps pages before removing the folio from its mapping. * + * .. DANGER:: + * Do not use this on a folio obtained from a function like + * get_user_pages_fast() without holding appropriate locks; you might w= ant to + * use set_page_dirty_lock() or folio_mark_dirty_lock() instead. + * * Return: True if the folio was newly dirtied, false if it was already di= rty. */ bool folio_mark_dirty(struct folio *folio) --- base-commit: db2ddb87143519e20a95aa36c60b36107b736a58 change-id: 20260810-set-page-dirty-warnings-4000f0015394 Best regards, -- =20 Jann Horn