From nobody Tue Sep 29 08:22:55 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8FDC40E8FC for ; Mon, 10 Aug 2026 15:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376537; cv=none; b=apqz61yWEjN+nMCJnUJAr9JSBJ9Z2ru2vshV/ImT+ACZoOE6+mXlrWIPqRG/0s9nPIY+pdOte9Yjf2LaIOU3r3a/Ki8clxo0Tr67Im4lR7JwmPvnWJSw1M7uaIih9vRNxpZnn3+F8Lpe2ZHqDHCmadQgrIj6vah1srYVHz1u+vo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376537; c=relaxed/simple; bh=MxJGfWyqHkmujFHgf6OYxUEmpp0WeZEB1egj1qYnlP4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LvKUwGPDI3GSL0+Fg/fdrJPKqk8KkbS0Lhr7J0IqQEenywVvbtY5mJQluNItZF4fTl1+2S5B7TQr+/aioxqKQCGntnIwaHo42TJn+GFYSwhkGT8pYZmHYmjYxQpPwjWstOJMDMuOIqVJl3zG3IIIKsnHKbZgrSSl8tbwqTFdseo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SgeQAnFQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g6vlTQ8E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SgeQAnFQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g6vlTQ8E" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWIJg1729062 for ; Mon, 10 Aug 2026 15:42:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rU3nSZ9YOSVhbe0tEc9W8hDnA4xNDc4U0VkZpFIzSy0=; b=SgeQAnFQ6OUrue2u tzCoZX7bv25HSmH3HVJ/IWfJD7HbF1DYSwZePJMGXzZgwip+v6+m38Vc+MM5WYF3 YqFkaeluIKvLv86RisM56hPiMmENGVHt74MuKokXif8DFOrrMT3Q7A0lJJ5kLxH5 bi2pG/ltnTFFePNiQ7A3Su6JLpim1S5LKfz/cFvIFNs2KlmzJPDEb1R3BIwwVe1b 85c041TpnBSBoDHc/9I3PYkyaN9knarA7RhWMe2ZyqDP0EkE1P4LoVKxXHwtTiOF j99j6VH3vBnMPfvdxbf4smmtWyFzKHKrFHtO8jJjvX92XTGZD/VpVnUqcZEfbU09 5ltSkQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v5a9r5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:14 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bfe3fa93bso19408321cf.2 for ; Mon, 10 Aug 2026 08:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376533; x=1786981333; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rU3nSZ9YOSVhbe0tEc9W8hDnA4xNDc4U0VkZpFIzSy0=; b=g6vlTQ8EFojVwY19zKX3EvDYNmC1lzxIibpEB5O2FMcLYjDBrNrpKly7eseElCx+kj cP/DD8PMc9S+MxSJbquLyYVmntqFqhT8DM8hAbGgs8fKqbP9fxNWNswxixhctguYwaja WaRCrj1+oFHYPF+LhAvLa51+8wyrpcRBmWSwsytSiEjRunYcB+NSAbQ5ZSzxb2tV9Mv8 vnxH8T+FzNNTPXzosLl2RND+45QA11VRBtRhEbD5SScTPerECMJht+cFqW1XMiRn9M3U vtxOHzMWFsDxvfH96UXTM+ITvnbnixMEu+BxZPOWOIJlhKNPRFoSzytNoXTtBntK3eYC KGgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376533; x=1786981333; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rU3nSZ9YOSVhbe0tEc9W8hDnA4xNDc4U0VkZpFIzSy0=; b=L6lccDGnr4/IC9tHnkMCp3Gng6rCyFUCFD+mhn4y9uc/713FzzCytTGwZFcoTe/G+h esVU4wjGCZP24JBhiZPyepcrjiTjlmC6ewC0iPnlbWa5tGvGTApO8i1TCPW5V95H33Fd TeW0+CrWtRZZL4vMCE7nZUiEFjjV4i9KDgOKwlJbpZNQ6gVypCoTg1MrtpgbdxRg+tjM TGPuETPZORO01D4XIlbxLYNjzgBm8MpNlMIS28D1n3i+0m4jIhnkXXLIuVb9gRiiLnCB bUwGl0XkhUd+f2APHNU6JhpF0B7aP+eD/DxaZy3FJXUFXArJjQRWr1FO55SpgcxY79QE mErA== X-Forwarded-Encrypted: i=1; AHgh+Rowe+T6JF6WAMF6RL+VeXLQAItfMKgFjMRvup2pAdsa0GcE8zxww7C2ryVtXjgEVzFKbNMxw+7nxnDW1ys=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm4QA36oZ3oA1jbF9kJ9gKB9dYijD2L6roDS9PeeYc1d+yJKIE P0NjtqN7DAJkMy8tl/9de3rUuUsRVGGy/gBNAhtuKPsUEIYYG6a91AFjZkgfda3UqEf3cAg6GwM 3UsDJ8aS8SwmAI5HKSjnAjmRrh0b5xTNqII4iW/ILk3KJHqYScvtRtLALvOTQ6iQeBxc= X-Gm-Gg: AR+sD11uv9yqcITc1zyjrfB2+1TjdpN0OVWsAPfwSf+pAKFDZPXX6HET21G4ltE4iBF x6wEnEHvAvB59LBZu54i2PCpZfL5bzv1eJhii8fDJrYRb3uZNS8sm/s7z0Y6jGeqpw0SEQ0IOBH ZDNR/MmKTOM/owWEf3VTaCNQaTVH6ctUjtZ3yKp3iHQ5NNGKaJ8/A0Ws6neKdgKzjMQYb6jjsLj wuEXwnUWV5rNBusWTs9ZVMAzMoqZmll8OBvgdy9uzxsloDSyqI5SeEYaGa/hnAjz2smpktGgDIL fNsrUx3MHHd8aQX5HLgUu3dOJmPQRfHEOv2EVibqg/bYzEt2G1lj8B9iwz4RpUsTc1PudbTFtLp JxAAgN9aLJZmi3h3h0iWGup7tlKFtMBg9dEgFnDPI47eUHoPU1gv7iJVIbaU3PuVpdumecNZYxB DIBzcJ9KXw+mQfKg== X-Received: by 2002:ac8:6546:0:b0:51c:e14:87ae with SMTP id d75a77b69052e-52ce614ec09mr547787651cf.34.1786376533398; Mon, 10 Aug 2026 08:42:13 -0700 (PDT) X-Received: by 2002:ac8:6546:0:b0:51c:e14:87ae with SMTP id d75a77b69052e-52ce614ec09mr547786761cf.34.1786376532932; Mon, 10 Aug 2026 08:42:12 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:11 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:05 +0300 Subject: [PATCH 01/10] dt-bindings: pinctrl: qcom,tlmm-common: allow functions on the HSIC pins Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-1-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1970; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=MxJGfWyqHkmujFHgf6OYxUEmpp0WeZEB1egj1qYnlP4=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ1blxwDXx0EKhs5r8iUduX/mB8v1LvJ+OavmxPuvYp4RV 0xbl+p3MhqzMDByMciKKbL4FLRMjdmUHPZhx9R6mEGsTCBTGLg4BWAiH76x/7OWcQ5nSctTfrv4 mI2agkXarencdQLBcfucH8opH3VdL6B6Yu3D+7rJic9XzgqUE0u6H8fVZvdvuq6Vd/8hH9M3C9i sHO6bTTDSM0wW79xyKCEn26fEMPuq0ow6j9AiXqW509OlDS4HFWvyLBD2/nupL9Kd71Vt4NcLIS W+sdGH+WtOeC0oOq6x8WL8z8TIGOZGbwvdHZuM0iq/xzsYyF44qBL/R9J93uYFPd37Vs7aFjZl2 p3Ld4oulr1e+1fNYe/HtHd7ZnZkr+HawPZILWCpYf2jBYqZRhu0bC2qhbkDp2wTtmharfBqk1On UVzZjTPlf2fXRa2ZKl589NmfpsMrdv2UVajOrb5uX9YHAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfXz0P6VbQ8h+IU gs39gAW+kOgRQuowE2P/dXYC0bTjc9topH8wsYbQFGJQmwJHEhKYPrR4UPytFjVK1cJ3sLugF6W yRedTRGV+HxH1SDnxuGBPGUnq+m6WOM= X-Authority-Analysis: v=2.4 cv=J6qaKgnS c=1 sm=1 tr=0 ts=6a79f156 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=ajVk9B4GSH7WaVlF-OgA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: e2zvDWesgw-EC-zYKzp40R4GdFI0YL2t X-Proofpoint-ORIG-GUID: e2zvDWesgw-EC-zYKzp40R4GdFI0YL2t X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX4LacVc8Um7WQ k54Pj46/qjKyvF7Xy03z51XWFZguo7d5TLp9VE6lRWXX/BfXKV6c+eB2qtmQAr/OnREWsY8fz/S MVQgaGKtPFklIllYe2zd1hXl3+okOIbuwLF4BQoXPQKnxzFL0McNA50YCVelP1SF80PF++rcI6P Kk+ecIIQLyrS/Mk62xt7mNIr7C8GuY3Ek2voCwXUJNxero99VaouwVh4T3kw+cEJn00gRAHtf1B CwkhiJ9FosDzBUSnrkR61Ak70UgkkYTo6qDmsdJMPvznOvyg/4vGYEvjHuYzHBTPTzQh9G2k0Vk IF4kAU/5kr+fGFi8QWR9ATegTkR9dx+HtGkf1yas11XidOLVKFhSQOHOjbOGDfZSqum1/taJgKT wZeLJmhmhUViIpnz29dNCfgHKVjTgPRQUE/zqSSHUIoMYWgg0Ln3qQVI51U1AEtNiUdPZmf984p XUhNCy32LGRq8nvOc+A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The common TLMM state schema requires the function property for GPIO pins and forbids it for all special pins. That rule is wrong for the MSM8974 HSIC pads: unlike the SDC pads, hsic_data and hsic_strobe are muxable pin groups (between the gpio and hsic_ctl functions, see HSIC_PINGROUP in pinctrl-msm8x74.c), and the msm8974 schema already lists hsic_ctl in its function enum. As a result any valid HSIC pinctrl state fails validation. Extend the function-required conditional to cover the HSIC pins and add the now-required function to the msm8974 example. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml | 1 + Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml index a9aff442824c..d9178b265268 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.yaml @@ -161,5 +161,6 @@ examples: =20 hsic-state { pins =3D "hsic_data", "hsic_strobe"; + function =3D "hsic_ctl"; }; }; diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yam= l b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml index aec72e8c0621..e10aff02be89 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml @@ -95,7 +95,7 @@ $defs: properties: pins: items: - pattern: "^gpio" + pattern: "^(gpio|hsic)" then: required: - function --=20 2.47.3 From nobody Tue Sep 29 08:22:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C37940A952 for ; Mon, 10 Aug 2026 15:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376540; cv=none; b=cSNpTxGbFM5yiNjlY/LC6LFtaNEMY9qnVI3eA3avD7NKtj1GO6s67NnFfE22WD25tVxEcs714UdLoYjs3IJSOw++Phu/z6iIjZEF1cUlf88HcvSUlLsOQQv835uNCjidBcTsh6y0pkW9mYalWtvqLLXpAm8u1b+fI1iy0avnN+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376540; c=relaxed/simple; bh=NB1VGGbjbuOxIk5Mw7HUiu/hvGDkUOwfKdlFHlZ7Ols=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OOoz3mBivEW0UBWjm4uAczgRFEsB/77dOtMpDeBu4jTrxfZKheRByOSGG6fPqALyuCfzJzZ7lWT0TgkZThCpcDUn1h/6oavqMGyv1faiaV39czaHvUnr4d3H6LNylSrUNqZXjdkJCXYfGQbLREaYSPFW0YRkS8UX+zWr8BYDKO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B1sP4ybl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jOGONjvA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B1sP4ybl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jOGONjvA" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWFoh1754219 for ; Mon, 10 Aug 2026 15:42:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OxKMXPPwMwKGvDo0ioQdxZL+9a9h+gbyqaNwhVID2zg=; b=B1sP4yblbzOduPve iSSvRJzvgNVdCY8JDaqMydOS9IKFXwgyoG1k2rukfNtSnXkRSjpvRFWHb4YFm0sQ nWVvlAS8wMC3VuIawDssRKi7FcYM/HsoEQ2/ezyB3YQ4LLDgKNp7ldMeHFAmLLsf siNRlYIpLthmjoEjj2NF49ipzInIrG+EztFqnTvfP97cMpZiLrFKLDVecaYTIepb 9SlTyrUuBxFyXEuYozPqtm4LjoSmQRcYdID1Yd8KsnF+0zsYyk3eRsD+lCQf7W3p Ru2BvhQLkv2/RnubtVmdhZce7vUhNN05tKxHxqfk2MZ6N7GO0Pz0KSmRcKUIj16c uXoNVQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v4aa8h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:17 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51bf321d786so25601511cf.1 for ; Mon, 10 Aug 2026 08:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376537; x=1786981337; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OxKMXPPwMwKGvDo0ioQdxZL+9a9h+gbyqaNwhVID2zg=; b=jOGONjvAuANZrQpTRf6Iq7RFw3iKLXBdjOsUWDtU1CynMtgB2CSvXWXZVkR0aJhCsV 3WKWS8PZ9fuMbx+hGyVrrTRCxh+smrZXAufsAsIst3toIWn7fkplU55/aVS+0aMP2Jem mjE4Fb8D97DFAcDJYHOxjP2EbYrNFhHt9n0CE3Nbe3Otvgl6VMm0C4pHJx0+iEeRk05O 0zeqrMP+i8gMpDRGX+8N0L326ZbGb9h3qpEFlV6lqlT00zd9srO8cVnys2lFqilBY2qq aBtWSumkBqGxY73k1IbocKW/pxg+SApjgOObWvO5GhJ6UTKHF3OCuOg01y1v0YIq/R/+ tUtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376537; x=1786981337; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OxKMXPPwMwKGvDo0ioQdxZL+9a9h+gbyqaNwhVID2zg=; b=SgxWRFJsDUujttQZSe0rv0/tcBQYiM1GxvbjTag0ZKvUCXGfs7xO9A97/7XsTLJEzI fYn01vgxrXkHtH+A7bwXVL9yL7qEgybgNhvF1i36yzdbhYj8p7VVBNNPmGLjUJoxxIpH craUDFxxs8/7zh+sBtWc+zrVT13ZgM0QbXD0pev9lJCrDafDgKBg1HRPj1Fd/mZl3SRM l4IelDR4Wx9+gGb1VwYD8Web64W3quxuFDZNyPj+T3K76veT8s2QSi33kYULmYqdcKXg cg9Z0xnf3ApM9u1GDMvpJBEkSfbN32qcQZhewRVt7pIAWLDIpIuFdplXb0Ll5nsr17Yv xPCA== X-Forwarded-Encrypted: i=1; AHgh+RrocMG+Ri82I+jJrJ2HDZolf/luQxcXVc9pO0Dc68xW0JnZqMP7GuEttkRIeiMWGNN+5tuWi6sqHFUqyHw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9NB/lgZWPzclL/QOeN3HGelPTuX+BDGZxO2vZS0RjZqW0BxGd cAgbgE9LSwKG/uioCymlkB2auygER9tUwrJEEcoDT43G1sTGSS1xifXLGItrqt+5rmbe82NxqwG mR44/wW7m6F0r1vyv2yAEexUcOvSH5aaCot388VM8bByPPLXuzU8hRuimsuScwUj9tk8= X-Gm-Gg: AR+sD13LmQ6JlcyfbB35fiB7lx8+WcpGq1IS/MDViUX+n7/8/EsJL+jVAK0cPtDA1Wd pzaoc7qqSQjIQyDmD9Hm8OvjMckid5URD8cobtiluB6/GkB7lJnEix57GCwCwxJntmBpacjZ/mB d1xxaWt3o0y/i0ImU8ELEMIlIaf8ANK6N2Qcjum0dftnBCsicxl+r0FCjY+sfrtpfIgJVlyDUnQ eaYYPKnMwDHxHLX3tZ4Va8yQWrmHhSKHJ7wad8GnyYCkFTHXgeeyCz/b8oq4p6iRyACY34kvyeS EjvaIaO8RvrrJ5OnVEjyEqTFk17m7yr91VZ5uxQ96NpY+HdV8bRiWufbZpsI5jkqka9hpcgYbZl fABzOgjU9gg1cmSb0dHHdVb9hsNA9KD6rk6MZxMxMBFQoGVhd7pymc2m8Eenc0qT3LDVUBNYCeN Vn1/RW2Ki5fFYnpA== X-Received: by 2002:a05:622a:1454:b0:527:f0a:ccbc with SMTP id d75a77b69052e-52d18e6ee99mr257127241cf.18.1786376537308; Mon, 10 Aug 2026 08:42:17 -0700 (PDT) X-Received: by 2002:a05:622a:1454:b0:527:f0a:ccbc with SMTP id d75a77b69052e-52d18e6ee99mr257125181cf.18.1786376536013; Mon, 10 Aug 2026 08:42:16 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:13 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:06 +0300 Subject: [PATCH 02/10] dt-bindings: usb: ci-hdrc-usb2: allow the HSIC PHY as the ULPI child Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-2-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1337; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=NB1VGGbjbuOxIk5Mw7HUiu/hvGDkUOwfKdlFHlZ7Ols=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFQBGUr6d17A5+31t5SJIcxfjs+sTCgcn3b4 0l8511XhQuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUAAKCRCLPIo+Aiko 1W9vB/9CocINfSQYnk27Gf5su/THJJGCq7QRj9tRZuzDC31t0zy/eyaGi/RXGdB1S1h+vwmBjk3 r+PKXXgB3nfaqiAaNZHsFQmoqNkVRZajicGwipkCsEDiQzJ4j/99Ui5JCrIPzJQsDeVc4wqf28h a+NcKyVR13lBq9YdKMmLU8MGZYO/3bE7MB2fuIn6MmsZ9AYnIfgH7mZfPTq8yYe4nI+lAR9YK7B uaTO9oAIvJS0rwBKkCa76gqYckqSYFjYSDWBVj31cwTqWh4Yx8Aa3XmV5VoWcv8i2ct7ZZmN9Lj giA41d8vYvliv7yjlbs/AvZcyf6R1hgbtxcxp5GIit1fUWGk X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: aOnw_5JUnBRQnyOyEJxkYhIQkTbC2RoP X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX1WRFHOPf7QR4 KgGlenFphMpKuBxbkJCHt6l4ZL3zSQ6UPk7stTFZdbzmqhfmK8T7udD+iUKDbtsihlmZtog+23u HStSLiY8iJjD87ogWjeT6GcQAx/Sk3U= X-Authority-Analysis: v=2.4 cv=W5EIkxWk c=1 sm=1 tr=0 ts=6a79f15a cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=PYw3GZkS7KwsNStVb70A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX4/7fXdhWZgv5 QBGd6jEjathtX16h1AS0eJ8hzQ+WG6xnmtFgFqwJGz/2FG974ElHGjlgs+Htdgq94ABM5Okgc/W Iju5f0dziFS7XcdiydAgrR7qnrOU2cjtwLqM36x99QFGEED7W5RMVfgDWkWUfSrVEMqbD/2ux2q MhoFVFv2hFDKkRjbub9vao89INDDZy0PWDGwpP2/l549vEsiq2r0burRRQ7+FUHhYh5/KEakcXH +M8PJWdrAVSS9XYiIxKyorZHNMDBWB6FeK/BgJ1w2Nwf3jmox8+nsvYc4yIyiX8fnsmvD6oLNeR i8M4HU9K9J6Vy1cqpteXA1WfZpGebdA2RkLxWtPyk3TIrdvgDIS2cU4zyS4+3BIS/L9Owo8CgVL ZrqXX+y1qY4wP9MPChm30kKj4oWNAIKbsF5+fZN6OP8O8w998OpSXY57Wa7ws9/Jr6C50DgEWyV u215YBDu/wZSK9dW5tQ== X-Proofpoint-GUID: aOnw_5JUnBRQnyOyEJxkYhIQkTbC2RoP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The Qualcomm HSIC USB PHY (qcom,usb-hsic-phy.yaml) is a ULPI device: its driver is a ulpi_driver, so the PHY node must be a child of the chipidea controller's ulpi node. The ci-hdrc-usb2 schema however hard-codes the ULPI phy child to the qcom,usb-hs-phy.yaml schema, so any HSIC controller instance fails validation with bogus clock/reset/compatible errors. Allow the ULPI phy child node to match either the HS PHY or the HSIC PHY schema. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Docu= mentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml index 620b564914d4..97ebf9e031dd 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml @@ -83,7 +83,9 @@ properties: "^phy(-[0-9])?$": description: The phy child node for Qcom chips. type: object - $ref: /schemas/phy/qcom,usb-hs-phy.yaml + oneOf: + - $ref: /schemas/phy/qcom,usb-hs-phy.yaml + - $ref: /schemas/phy/qcom,usb-hsic-phy.yaml =20 required: - compatible --=20 2.47.3 From nobody Tue Sep 29 08:22:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CA91418357 for ; Mon, 10 Aug 2026 15:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376544; cv=none; b=K0KHgyQdmPS+tIstGRXva/GBtNUUA6RbfQhl1EuH6mGtgZqVggAJjabwOCAMeLt7/CiLk7moL+pa4aD4EVDiRA/2773jYXzmJ0y+sZm5MyHdE1b4q8ZSzYQejecROqVkkaY/J48nvdh0bRoqSdyOOWeqgmQNkRr44bgJTcDU6hY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376544; c=relaxed/simple; bh=0CI3mvu26e7yA8lXB+SGW6FHaZ290+w5/6/G0cJEMAA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bl3taQ8t5wOMB32qmBtuJa11lrRZlHM38+k2Mvd+k0V2mqm4frUXY0ZKSWOe1rnXsYcH4I85nTRxu90Cnjfhr+8DLq65YV0taOqs3DnWGo6WDtVBrlAAaDK7xPhY4FWambV5kSyZMU3tuN/h7oZ5jMy/q0t5v8aWc8tbLdbe8pE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZcV9Mp7S; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g2139EzV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZcV9Mp7S"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g2139EzV" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWecZ2345308 for ; Mon, 10 Aug 2026 15:42:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wb7qvpUp/pGm2ninxxAE+oyyMl7XsWm9X5sYC8bZaf8=; b=ZcV9Mp7SANLg3D5T PWLMytl00vS/dew4AbD067kvdt36FpqHJ6AjCy7ZFwOHr9kt137MO3GgFXgScuoW nM3pAZXnEDUjIaql7nTSuDyMD7/PjTIx2pOpxGUcMl4NEU8sOqWls+XAEr65C7Y8 XaQJpLZpa+y35XROU+5SZCpYp/mEx9h415znrRBtb3YGcnixmxYVnlKoDf7Hvo1v GsXXJ8+sqkS2oE+CYGn8J916dKe0t3XNL3mPJ8WxOhG4CTJFc9H13jIL4qiJhGA0 lv/LSw1yCmWc/n5gEODXbb7NEUvjXCDJhtqXZ71Ur1F3xXNnKBI/CSBOvmjQUuMP eG3k2Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy18xubwd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:19 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c0e702df8so28584731cf.2 for ; Mon, 10 Aug 2026 08:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376539; x=1786981339; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Wb7qvpUp/pGm2ninxxAE+oyyMl7XsWm9X5sYC8bZaf8=; b=g2139EzVk4c+Dh9HKQTF78EbgMDgEkt3njcuBnUnLR0kKjxLAMrS9QCNvbrSeybY5n moJKNJ84f63g+g203h8CT4ArS+WhlmRhBtQ2a9qVdVOjapRUzQr3wSPNoXdUgC2VX9bM woIzDLt+/WAHdpS066nUEfmFsmAn8XLetZScA9rf9WskgFDdvMHL68yLahpVh/1M8Mp1 I5tyiPagsqEkCQaA1wMs/ZnNrJh6hIrJzHMdxRh58fxW8i6D5zeLSmv1nV0ExiPUgBfb b6X0q2IVKE9SYWPi6iUJX4N8AcKw5ZbGuU36sg2kigrbQRE2yVvcqv4PU1tmeZNEi8YW zuvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376539; x=1786981339; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Wb7qvpUp/pGm2ninxxAE+oyyMl7XsWm9X5sYC8bZaf8=; b=pf02PSnakNnFVUiqRkMyLD61pSpfWhQnpaTPjgCkGxxq1VnyTjvmMsxSzcBJaF2Mgf ZiyyF6Nj3uh5lHWe9gL/HHTXzMzP6TI0SuIJ6PbWjBGetXXWVsvk0cxmw/FQfZCfpPlT eOH+++kGcq6eFhoJWIiR1EsEpF8b86Q1PywYJCUglmUU5z5ojE0HmzIZYB+Owlj0f++B CMTiPWVqi6w9fWiMqfRbVwi8bZScFojtEI6yRH3a+JWZLGTtqGh2Pw6zfGf0OX79IgJo aKRLO/EjQWmqaPSxXXwoAOqNtQsqsfYDLQA2/4Zw0vH84nvDAHjziAKe6SxziJuzSAL9 KKJw== X-Forwarded-Encrypted: i=1; AHgh+RrqvSOIMOKtXwlgfF4peXqldUCxHrWNybU8sRn3HxtgWIX31SR1eIM0G+O5N7OqV3wCYO/G+gSAUSjbSK4=@vger.kernel.org X-Gm-Message-State: AOJu0YxKjRHIkVDzuQVoE1DrDJcCZgsWm941UHchGpdPBmY46Q+9oUtV BMWY0i0xtT0Ers9aPkxiRue4goDRl5K3yhfA5TLQwX8XuR2jMbncdpcdBDNkqRzOZ3uGAplOX2B A+VJRzdQifh+jd76RQU5nl/mzxt3/m6QHkqHEGJQK09j7hr3cXLhb/qvZMehc18WQNmc= X-Gm-Gg: AR+sD13eb9ssStoFQhrjJYz/CgDIZrW+hNn0YiG5j/8lFEb5TgSlhouuQkX1SPun+E9 cSpzsjjiNImRubHfA6IPZJVL7G4ssDBwY++I+m/D5vCXPjieQrJ7DONffd008LV1UhaLAizWzgz 5A+0HcCJu6MNJ6qZPFuAXRDLQon024CtfQ+3LXqmvRm4XMJU/x7J8IhGpnoUMh4oedNeO10KJt9 HpTfO0HhXdQGytwp9A+D8by74G3QfEzVr8NfNFNEoVM08PXoykApMQhffgPI2Oz+KCBJno9wXWH qAWj4HbUFtuWWs09OVJ/rSB0w8L7DQoWeu26EIUyZZWna6T6h8vrT9ODdUVdINEhXpm6i+yeqQJ CFZ61q2AqAbG5XFFnzJV2q7BEml1OCs8HP6WtVvFy9OMsnv5D2xfpYEGwHpHZO6Qpf4oUIHNvRT N8sH4HO43bGhHJZg== X-Received: by 2002:a05:622a:c8c:b0:51c:19af:6341 with SMTP id d75a77b69052e-52ce61d2d25mr497522941cf.36.1786376538891; Mon, 10 Aug 2026 08:42:18 -0700 (PDT) X-Received: by 2002:a05:622a:c8c:b0:51c:19af:6341 with SMTP id d75a77b69052e-52ce61d2d25mr497521651cf.36.1786376538133; Mon, 10 Aug 2026 08:42:18 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:16 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:07 +0300 Subject: [PATCH 03/10] phy: qcom-usb-hsic: do not run the sleep calibration clock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-3-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3001; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=0CI3mvu26e7yA8lXB+SGW6FHaZ290+w5/6/G0cJEMAA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFQE6VzvzxQPylH9ol+I79Tpmlw5MGkv8b25 1iWSPmFw6CJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUAAKCRCLPIo+Aiko 1XrJB/4k7QGxbIKLgD8fuU+VZfJP2y/wpC+a0n4C6NJVVqJBicGgCy3AQ8RQPMNajILbjcTmnxs 42Um3fhKY+5SXieGB3CFYJEOjlA79/KNfLs3M9M8Tqy/OVFOG3m1xDW7BCK7urRoWIVBu7kSbYn 4QlCcu4hYZ4rVVDHGgBhXtsV3Ke4vXH0fpEWTn3rvqTf7hU5BbwX4Wu7MMhp5R70vbXirrZcjXv nI3gVSk18M6Zo27KaVZOf8A19KNnRvRSq++A9OuCeo6MhNWEK7/46RwMvafaMZdu1utqdf24XCk XI0jmDgzo5lFr620llmYyMLV77/QUORAmmowPAq9SCJ394y0 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX3jwi+CQ2lz5O UkcK4E0lEeVf2OfK5khf3kmdxkNkJDH8zx48EQnt7YTiTZA0IuIVhj2uCIkp8TW4ZtdGX4Jz5n7 u0gzrq7+oqGtyom3mpjI4yRrwr/2qPM= X-Proofpoint-ORIG-GUID: gEEBeriwHnve_NumDdk0zJWTABrYJT9V X-Proofpoint-GUID: gEEBeriwHnve_NumDdk0zJWTABrYJT9V X-Authority-Analysis: v=2.4 cv=bfZbluPB c=1 sm=1 tr=0 ts=6a79f15b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=h5QO6Q66eTtlMCYmI04A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX/FnJ2U9Xivlw IFiJW7uJ0MHFAvonFNKfBAeB6fj6lgZ0XNMpTu1Zo1wbFJNSJpTuLn71To3LEvTl35h9fz6qJvp MvonFRlmDU1T9x1qEtipkB7Vh3FaBFG2fTsdM0dWmeoo7htu3pqKZSlaTVTMTF5X0ZUe5S385Fe pV/2DNnHJE56IKgjWaJZEcod0TcdvU8kSBcMYaa7oO+AMEFMaMSmyJYFeR4DKNoDUwBeYKA7gxb MxcbZEHbbuYuE50Spgr16M0lFCYKhUYMPBAQX3LC/WwJOk/8KywwTEDJkH2YuqT89Sa28X5ODfa vPpIFtWoz10tiYB/Nl5AKBhI5k73yUH3xNo62737JTtUcFFvCXN8yBm5EAhd9pfMfA969EO104B /cDh5LepW8XpPhytCdkYF3ovP40nccp8P0t9d5jtkLMo/TxRSQTByj3KudKIAP3HAx4uzAxHVPt 6z8BMAk8NdId2Vj8I0g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 With the cal_sleep (32 kHz IO calibration sleep) clock running, the HSIC PHY engages its sleep calibration: the strobe/data pad calibration converges to different values than with the active calibration alone, HSIC_CFG reports the sleep calibration state, and the port no longer detects a device connect - an onboard HSIC hub signalling its attach after reset is never seen (observed on the APQ8074 Dragonboard against its USB4604 hub, by comparing the ULPI register state against the vendor kernel, which never enables this clock: with cal_sleep enabled ULPI HSIC_CFG reads 0xab and the pad registers 0x0f/0x0d, without it 0xa9 and 0x10/0x10, matching the working vendor configuration). Stop requesting and enabling the cal_sleep clock. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c b/drivers/phy/qualcom= m/phy-qcom-usb-hsic.c index 20f6dd37c7c1..b670ec364a2d 100644 --- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c +++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c @@ -20,7 +20,6 @@ struct qcom_usb_hsic_phy { struct pinctrl *pctl; struct clk *phy_clk; struct clk *cal_clk; - struct clk *cal_sleep_clk; }; =20 static int qcom_usb_hsic_phy_power_on(struct phy *phy) @@ -38,9 +37,13 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy) if (ret) goto err_cal; =20 - ret =3D clk_prepare_enable(uphy->cal_sleep_clk); - if (ret) - goto err_sleep; + /* + * The sleep calibration clock must not run: with it enabled the PHY + * engages sleep calibration (the strobe/data pad calibration + * converges to different values and HSIC_CFG reports the sleep + * calibration state), and the port does not detect a device connect. + * The vendor driver never enables this clock. + */ =20 /* Set periodic calibration interval to ~2.048sec in HSIC_IO_CAL_REG */ ret =3D ulpi_write(ulpi, ULPI_HSIC_IO_CAL, 0xff); @@ -76,8 +79,6 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy) =20 return ret; err_ulpi: - clk_disable_unprepare(uphy->cal_sleep_clk); -err_sleep: clk_disable_unprepare(uphy->cal_clk); err_cal: clk_disable_unprepare(uphy->phy_clk); @@ -88,7 +89,6 @@ static int qcom_usb_hsic_phy_power_off(struct phy *phy) { struct qcom_usb_hsic_phy *uphy =3D phy_get_drvdata(phy); =20 - clk_disable_unprepare(uphy->cal_sleep_clk); clk_disable_unprepare(uphy->cal_clk); clk_disable_unprepare(uphy->phy_clk); =20 @@ -125,10 +125,6 @@ static int qcom_usb_hsic_phy_probe(struct ulpi *ulpi) if (IS_ERR(clk)) return PTR_ERR(clk); =20 - uphy->cal_sleep_clk =3D clk =3D devm_clk_get(&ulpi->dev, "cal_sleep"); - if (IS_ERR(clk)) - return PTR_ERR(clk); - uphy->phy =3D devm_phy_create(&ulpi->dev, ulpi->dev.of_node, &qcom_usb_hsic_phy_ops); if (IS_ERR(uphy->phy)) --=20 2.47.3 From nobody Tue Sep 29 08:22:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E71EC418373 for ; Mon, 10 Aug 2026 15:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376545; cv=none; b=uL2PWXnUsC0j4slV8zyBZgoPOfRcjHpCqcFjPtIfedX6HUb8o17uddc2bXlM8ehA2Zt28QJ+xvJa2XvA4U7PLjQfTG6RpN7t6ovlS4DTyZBI4lTcdLxXgFAkBbp+m2pg0LFX2z+GTnh37qf4HWIURanxB9gQZVT3f63KFBiHIi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376545; c=relaxed/simple; bh=TkrMMSM5qDrBbFDzv/+VaChi5RjS9zkmjtBE4vr35Do=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SZ1WVnlcVbOgkRK8cHuhipP/V9peTWrhMW/ulQAiO+5tAPbtJoACXZSOW1KmqGksvjiuiDJ/waaugVRZRpyqelDyLnr/2hg/c0/brDQHa3as3Q00gS6iWLXa/lkowlSgvhBYhZLX7iMteU9kN+qJ+VntupjkflPQyEomPjYvFCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AeS01/Ct; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OIpjQuXD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AeS01/Ct"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OIpjQuXD" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWGeF2034929 for ; Mon, 10 Aug 2026 15:42:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /Ol8WpcEjj06q3ha1b2ZdRY+l9xpEFrE+uyJaWfhLJI=; b=AeS01/Ct5gaVVxuL BGhfFfceoK4d/rRNfiK6ZSBPbIpCmCzbID+VKl8ITCe0wUSneI9auDdnRDDCCxnL qWwlYHDL5E9bwviIOlH0k/YWs17jIxRilWjf7FFiABa5ps70gB3DNSl6kqjyICT0 42xgyUXtCx19u+YkHhjfC/+SiHf6UQJmCQ2yGgwUuCsrQ2ACF1pxLEna9abtBIMC fWV/IyyDRRiI5M0aZgOb0HaYD/J7lIK2aha2Dik8zf3jWDjf27XBW0bmDFH3mMmP r4la1VhTPJ53QWl8P6mgI+hRNBfeM02sX5PPWpygAtInFV94rLSqqAgBHRHhryZ/ UaF/PQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8vhjb1p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:21 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c1d137a68so46201121cf.3 for ; Mon, 10 Aug 2026 08:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376541; x=1786981341; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/Ol8WpcEjj06q3ha1b2ZdRY+l9xpEFrE+uyJaWfhLJI=; b=OIpjQuXD2oVjibNDNjZb5aFeg7LEYm5UJY3rdPzMLNIBDQoHv51y4up3cQkw3q3NDF fhbciJ6c8jV9HzU79dHaVu1Bw1dTEvEEGTR5guvkCGNaI4bsvhrGd8qF93NNHkWbImzj uMFHpOwncS10JOSCHywRct5zAhNL/PZpQpa6WEKcDdWjOcuo9bLfO6wc0yxnFjqfqUVP ODrVgzl5pxrNkPFireImN8JgArLlUviIHGTIjYH5tR9WBvDOh4AV2ihrjvvAX5aYV1oP vPGctcfbkQe5CcoE0gqUbyRKMayq2QE93tZtCnZmRUBEfLOYPAKGD6iPwchyu2mnbAXw l7Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376541; x=1786981341; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/Ol8WpcEjj06q3ha1b2ZdRY+l9xpEFrE+uyJaWfhLJI=; b=ezbzAUKZui0D/Xey8H4bK6csIrdZAPxawJqRe9g/OtnkzEHDjplwHbdi9BcrkDRH8H qBLfMgbFIiXn15xrkSQtgYPUO4uM/x7KL1uhX0y8GoNSWfyqGfvvZwLLFo0Yux0LaYUF E6VDaxvLIdT4yuzDGHkwxjrpzXjLj3bXLo0S8NYAhnk7B8mvIKffDxJx0wsiYXa6rDdu X46N954XGldbgtPVoVmcsiMV4MZsxuuydRxz5g2qgBtP3Kr8O0MB77lBnUO9aFJ6odcQ U6TXuOivcEPZaaegFq8mJwaVLQP9o7cYpIsBwcn1DwYCm7pzb6p7fYfx/8yVgIFdtlwA H9Rw== X-Forwarded-Encrypted: i=1; AHgh+RqUhITiuHQC5aA3+80fp/OajJtplIEledotU2yAUBDIr/jZUZm+NMXturVJ/w8z0eVUKO274TarCuSr9l0=@vger.kernel.org X-Gm-Message-State: AOJu0YwcCEZ2BDysUwE2KS4sFLnlz3jABRpOWGy9MHz7U1BVoMAfyCvj rPLOAeHM+JVEtOfy7clN6Sd/xzpPFcPtHba8JdbXmh8YZkqPBrt2YM/OfOZZzVGDpd7ZMivM6EB UGa25xqnuQxyBYtkZvCgP0gqEopKorFbk4RjewXwqZcv5kupFVojGBVOfxhv0J/XbGNQ= X-Gm-Gg: AR+sD12LmEamhmaW/oqWDw8T6u5HcqAYiQ9/T3exaBsSMXbKlQnMf6Gyjdj5u4QSDPd na0CXQMFjMnOYe6oYVrg+FxKMj4n/WGrVM2Khs9Dknkx4FnYHoFllmGu8H5niMEdbToRpvUuNt3 R6JHcuErkyhuXvuNyEb98oKw/TjccrTmJ1S9ltVjigX3RY+6WNAqeOkwVSFhtHNu0AQVw+Uoaaz mkCILMxRvtd2dQIwA/pxyrBEn4qhKXH/CUxz2sZNz+eTssiz2u0J4MJoXfgXGQxwMnl0OC+Zycx BMRGvlEibjnzVYrsFdua+PVwb7cp4SxtaGYx0gNNpbr1jjw/2dD7nMcMZm3azpAgCVHSqxWp0n+ PqWcZtMjqWpHwldvf4KrnV1wgFIOuQ1VRKyxWF4cchxCOAfqmAxr1HeLML8iUsQRgTPWQXBhhau hCEQJTAo9etgmGVg== X-Received: by 2002:a05:622a:1f1a:b0:528:3142:d466 with SMTP id d75a77b69052e-52d20a920d3mr252033661cf.41.1786376540809; Mon, 10 Aug 2026 08:42:20 -0700 (PDT) X-Received: by 2002:a05:622a:1f1a:b0:528:3142:d466 with SMTP id d75a77b69052e-52d20a920d3mr252032531cf.41.1786376540166; Mon, 10 Aug 2026 08:42:20 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:18 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:08 +0300 Subject: [PATCH 04/10] phy: qcom-usb-hsic: engage HSIC mode from phy_calibrate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-4-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2853; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=TkrMMSM5qDrBbFDzv/+VaChi5RjS9zkmjtBE4vr35Do=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFQhLz1oU44aOjR1xi5aFB9HrDQMTdOWypAd O9oOzFRa32JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUAAKCRCLPIo+Aiko 1WzIB/wPUZAdSQaPXXJvH1bFmntgi2oxFK1T9jsaAfhtC18IWwtDkzXwfNlhfk3AR0XZmGY5UiP jjQmoXwuwt/VtjrilmmUZx+u6hDAXj0Zr9EXcb9Fo3CzLGNTgRNxoXu6V3Z+7f95saFMXWBPRS1 iFeT+5aDaRKCydJtyiI83UIVsC5DaW4p12w/1A8f3yxDD3KZayrQ57H5az4GkXml707CRQxLm4W pJ2Wp+9PXIMGEA9EuoqvAdtxrvhMdgmAz7JqCU2sd/YbFJO0ls1bXVkQOmqcuno1MxGNGc6qfXa nyCZ/v/i0ylhMp2Z/RBbFkaPoFNGFX930//CM7CRhxNKITVX X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=MMtQXsZl c=1 sm=1 tr=0 ts=6a79f15d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=0xrA-bSJ-g1zX4FYa4YA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 35_2yOrdPXe6S1L53Gd-qlv8A-yLU9dI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX0YJ6jfbdb9sH HvqWHhLlamegmQbJiq4FtCnCxWBVVtn+GkJD4RONdagjpRocIAU3B3p2P62L2gb6yQY2dBdH2MC vMsVpmLPKqCc/dokvPxnUJbzCUG5aoS6TCZbFELO2r/Cm3RoeP2HkjxSdw/j5EsHZ+qlYAn88oZ /IZCw5xDDRgg2pi2PqFJ6QV8CkZatynmI/pv134j8jTmuzNoPqvUOjMp3hq81F+XXhQXhB5R2hf xizL3m/KMsqDjE4HTTrCQW1Sp8++HtQGaQUU7zE0W0qIdZ8zD4mhZPKciZXtvL3iXM5TK36sCPd 19l+mwf1nRERi99hQJiob9pUKCF0JeGjUqu8PMkE+yt+A9K08k1MplI06D1E1Agueiiw0g2IstK TJ5bw9B0T/JAB0IrlTq0LRISQZZoEySov0u8iQLH81gjfu8NXtKbAAjpXsSAQYAM75N/LkMianW 9VqtOpmYrZ1jxYwkjbg== X-Proofpoint-GUID: 35_2yOrdPXe6S1L53Gd-qlv8A-yLU9dI X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfXwrf6v7CGTJjx QSmlB32pYHcDB7v4+9JFCZXAbydTt8YyK6OczGxuOoKkNFob3btz1tHFkpUY2PWK8VGAdkdvCq5 Zi3FLPeaPEKtVbi/Rf2L/2UzaQ9qukc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The PHY power-on sequence ends by engaging HSIC mode. With chipidea, power-on runs before the host is started, and the HSIC connect of an already-present device is latched at the moment HSIC mode is engaged: performed before the host runs (and before an onboard hub is taken out of reset), the connect is lost and the device is never seen. This is why the APQ8074 dragonboard USB4604 hub never enumerated on mainline while the vendor kernel - which performs the whole PHY sequence after usb_add_hcd() - sees it on every boot. Keep the calibration setup and the pad mux in power-on, and move the HSIC mode enable (and the auto-resume disable) into the calibrate op, which the chipidea host now invokes after the host is up and the onboard device reset has been released. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 32 +++++++++++++++++++++-------= ---- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c b/drivers/phy/qualcom= m/phy-qcom-usb-hsic.c index b670ec364a2d..e0637522eb82 100644 --- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c +++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c @@ -63,17 +63,6 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy) } =20 ret =3D pinctrl_select_state(uphy->pctl, pins_default); - if (ret) - goto err_ulpi; - - /* Enable HSIC mode in HSIC_CFG register */ - ret =3D ulpi_write(ulpi, ULPI_SET(ULPI_HSIC_CFG), 0x01); - if (ret) - goto err_ulpi; - - /* Disable auto-resume */ - ret =3D ulpi_write(ulpi, ULPI_CLR(ULPI_IFC_CTRL), - ULPI_IFC_CTRL_AUTORESUME); if (ret) goto err_ulpi; =20 @@ -85,6 +74,26 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy) return ret; } =20 +static int qcom_usb_hsic_phy_calibrate(struct phy *phy) +{ + struct qcom_usb_hsic_phy *uphy =3D phy_get_drvdata(phy); + struct ulpi *ulpi =3D uphy->ulpi; + int ret; + + /* + * Engage HSIC mode only now, with the host running and the + * downstream device out of reset: the connect is latched at this + * point, and a hub that has already booted asserts it right away. + */ + ret =3D ulpi_write(ulpi, ULPI_SET(ULPI_HSIC_CFG), 0x01); + if (ret) + return ret; + + /* Disable auto-resume */ + return ulpi_write(ulpi, ULPI_CLR(ULPI_IFC_CTRL), + ULPI_IFC_CTRL_AUTORESUME); +} + static int qcom_usb_hsic_phy_power_off(struct phy *phy) { struct qcom_usb_hsic_phy *uphy =3D phy_get_drvdata(phy); @@ -97,6 +106,7 @@ static int qcom_usb_hsic_phy_power_off(struct phy *phy) =20 static const struct phy_ops qcom_usb_hsic_phy_ops =3D { .power_on =3D qcom_usb_hsic_phy_power_on, + .calibrate =3D qcom_usb_hsic_phy_calibrate, .power_off =3D qcom_usb_hsic_phy_power_off, .owner =3D THIS_MODULE, }; --=20 2.47.3 From nobody Tue Sep 29 08:22:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CC640F744 for ; Mon, 10 Aug 2026 15:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376547; cv=none; b=N+/rmI8FXHRIYxgMQUAkctZ1U9tPDdGqgOSVZjzJHq7GngjGMhv0Dssj/8Z0m56ycj5tqUvHsGe+unGKMBlIMzCz5y7qBw0QU27/c8aO41NUVeYyJKPbn+Yp+Kdj/+ATAwp5ucKnQ3m+WQ/zJmIFLhdy/rjqE3OA1Rw5Qwr9/Pg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376547; c=relaxed/simple; bh=zF09fnAjSPFGZsQfp4IpqRrDJjz7DPLi1N/LYmSBNLw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EebhLnCUpzzJV39jLll7sYH6C5MuMCgRO9CSfJKjoFUUJv2DwmrADIQhox6wahea0Xb/CRC72YQc1YNiCywGbUKXnA8PLwBhVbSnqDiAJ1eZ+Luhr7kLSyYTk83RJePqtWqjEYKHOneKW4Zc/XqkXOkfGt4Gz6M+NshQ+p0kDw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UOLHK9R4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L0kbGDwD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UOLHK9R4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L0kbGDwD" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWMpi1982804 for ; Mon, 10 Aug 2026 15:42:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ykiz7/WLXu1Pqam7m96oprgwnXnPFLvlLQkcUT1pgeA=; b=UOLHK9R46ffmVQXv ZQwEq0a8ewE8eq3tOwO3f74Jy+opbpXLRpw0AfxuMocVObs4gccOCaHSC7B6KtW/ Wu4wxcdUOPOLna37bl4kE36gdF5UyjLY5PMj7iT2oz68GvPmS0d+J3wz4QjujuZl KLCMRFs0OnwbyLeg1XSEnuIA21OO3dLet1Tc3BmgZGqN3Jm7LPh05V1Z0NbkLZWh I6Ku4DNJA07pPrUr179BdqnHp68BQwdIlvZtDxzmjQrhGuQiMoV8ynniqzX1pFaq j2KelKK4eBONxuHXtVIdgI6Ars/v8WGxfuu9gb5bIovsLeNt3M8y0vMPWyqUxrKe VF55QA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v6tcb0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:23 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51a8b0a08d2so14152231cf.0 for ; Mon, 10 Aug 2026 08:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376542; x=1786981342; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ykiz7/WLXu1Pqam7m96oprgwnXnPFLvlLQkcUT1pgeA=; b=L0kbGDwDI7RUPxEOO/23XDhK4ce3Pke4+nlMb2OKoa6rwBrYNObfg9HKQV/bXJHkA2 /CgaY3sxEravvkLBrJI/1EYQCMH6wAiour5cDpfPDWrAaO0CGMRjwsZXp21Rhvi9vUoB BzCzQY+1pPqN67fKwb07Liys+DyYAD7IuugY6jDBm83hDVq6JxJfkmQLHPk3U1cIrh7w l0b7wcmx7ECZEtpWRH2VlVr8BA8JPABSsQEA74KmePPSxcVD3tCfbj4kXMCrfp1JXvPd VaqGJr0JmlIYxM/qWNkGRlIR0b2CStbnJJDzEK3FBz3g7xn1tarKfksDUlJ+P4EBwonD E9mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376542; x=1786981342; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ykiz7/WLXu1Pqam7m96oprgwnXnPFLvlLQkcUT1pgeA=; b=NFSs0Sv50TyYHsZLIvcWNQTIKWWzB9EK2fLKxnHaNFZLxL9B7V7Zfvx2NYQAoIRS/L IqYmtiT3tMk0Blzd5oUW1K55p7djmmMliVvNznHt2so/e3KNR+32kH2UMU/pNTTqmrdw ahzuBbUiCXpXRz1ch1QV/iAyhMGJedeQd27sEGtAVSWKDUUF5EEwa3TY/6AdQt9G3nW4 YbXF833u2Ow8LIgtEKoNv6XcnWD/73DGH3cQ2x3MMXQyB6yeFRUHYI+uiu05KUvuNEg9 zd/Vz1vQDrGj/Z795WtfGwwDle/8qfyztWAgOOGn8jhXu64bUZ92jACbHyWOLcT0xTeq mOhA== X-Forwarded-Encrypted: i=1; AHgh+RrodrXWbErYC2gmp8XCQ8C3Fpb3Scf5wz2piK+mC0MB3rL32Qba4i10CtM7UVWtiX6FIkcSTQTdg/k9WXc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywytl0p7IxVdiXHCEKuAZIKd/xrifdHJLYqWYbUO7YsnCKxZeL2 14ZKbHsw2OK+swpfhuHuk//AnELjkaZv8pZaO15pB7i+Qb70Tfk1qjDCzng5BJn13nkZKZXzCGO JCVcNEpqcuIhVm55cop9+oyQMhdORPr9dyxfdpDDUy4QhAMkSjNUjOhR3beQl69NorAE= X-Gm-Gg: AR+sD13je1NWF1pBvOcdqJAuBv5vsTUhEv+V4JynZy6vSiIbSs7OQgq5eTNn+8lPqp6 D8DwUsdlUKYXs4sgZCRZHlLurgaDXlCDjmB6kzSMHcfJdRbbpo/y6lrvOAhJM31kMcVRjNiWP+k 722raxbIf07aiLhTR/a0krMllKaZSgBk4iPqBSwEJ1lXiJmlXqW3VH7UrJE67H8ElhpsodM9S3S R1ukoetPLU24AMfLDhxwvXYnOvKSTCg/HORPGb+E9hufUp10MGCub+5ZQnNVDjH9QNYfvP+wYSX DOY7HE/t6eoOGdVmXkYbcHbcgjEGdU8WW97siRAbzXpnmEpdcOeP+a571NfgXL5t/a6wmUMe3RR zYuhrhCdcuArI5yLwc1VyPDs/559tBOHcL2ru1pmXTCAu+syL0yJD0kVUP7HyEveg4vk02RKgsc aZ2YQFU87WwzFYXg== X-Received: by 2002:a05:622a:593:b0:51c:21d1:3852 with SMTP id d75a77b69052e-52ce5f63740mr455151691cf.5.1786376542479; Mon, 10 Aug 2026 08:42:22 -0700 (PDT) X-Received: by 2002:a05:622a:593:b0:51c:21d1:3852 with SMTP id d75a77b69052e-52ce5f63740mr455151151cf.5.1786376542016; Mon, 10 Aug 2026 08:42:22 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:20 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:09 +0300 Subject: [PATCH 05/10] usb: chipidea: msm: support the HSIC asynchronous wakeup interrupt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-5-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2640; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=zF09fnAjSPFGZsQfp4IpqRrDJjz7DPLi1N/LYmSBNLw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFQprX64U/4DCFpJiS14RtCBnDgkvwJpjJKW lTiyOQZ8kyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUAAKCRCLPIo+Aiko 1W2AB/4guuqVz3+TvJnK5H8xdLnO5BEYGr+vZ7ygvrf0WZfuL4F1BLUJwTmRESF5lD/QlFQZemG IwfL5qsbQDRHMZhbNYcrgh1msxLpuSwmO+RCqWlG6mZbMiwHGCFfYq9Xa0TEoE9A7Cwi9x9KDD8 Tm/0C1wFxNGJf8uCRkSsy5efA8Ijx5smouZxEsNmJrQJ8zyDQ4c/n5UwtyOTl8RG1NwpBV8z//t im+bU+E6xQeyEb9oMQ/BOjcG0xg8uOP4bXVCcn9B4pdveKZv3UN3yGCbHYbkK8frrxGdLmJDe8n t4bCyvugfQo97me6aPjdAhjJgTH8IhMsPP8mTtvXY4fZmCLL X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX745sfou4sNxv Z29c60lnP4Xemm5o6N+frEQILkkbtkV10z4Okq1ndcLkTXE40gTz/AwI5N5VjfMthAP6xBLExvu dkGc1a0LNchoHCrr7+tHuTNsfYMnmco= X-Authority-Analysis: v=2.4 cv=PvijqQM3 c=1 sm=1 tr=0 ts=6a79f15f cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=a4gATcTAGDG0ZWSRqCQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX8pzyh4uSUavV rw8S3tvf4zTc9vRwKwzR4qFR7O/eDadbsxs82ZHHwQaYyYDQ8ffnGMuzWUM5fTXOBX9qNNgrFhq WmRNdG0TgifQ1YZZYmWKVzG+ZhgTbH9Jv2L2qJ61YVQUdVt5m5VXdR5SlKapDVM7iI3KV/teble QaYTfVsmeyX1BIK+KhPFc/YVywFn2onoBQof7T2J58IDTUFsWO6JxSzk85+zGRcUDXO6e8mXqJ0 5he7hA7hXYBnEb0REQ1K7jRWi90iwGOmWqoi5TeFFXG6EFpjq0KrV+xtg8+n3gORF+8QJChhIEw wJrewUe1sVs0cxBBy7qDeLlSFCUBx3c+7AC/ju8l6e0RyKTRSvSUxX9pE74CUEYH8qusjTzXyUl InGYxXrzw/TwJbqSOPliCWXDVRIDJ3niRt5DsquN1IMsW2rTKH7iOTD7FlPdKJ4ad+wsjSLdEii ItcaQdls2RQmbJtYdww== X-Proofpoint-GUID: 2TxFeiF73Rpi6DklU4JLPR1Yu2dTvuT1 X-Proofpoint-ORIG-GUID: 2TxFeiF73Rpi6DklU4JLPR1Yu2dTvuT1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 clxscore=1015 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The HSIC instances of the chipidea controller runtime-suspend with their clocks gated whenever the bus is empty. HSIC has no VBUS-style connect detection: a device (such as an onboard hub coming out of reset) signals a single connect event, and if the controller is suspended at that moment the connect is never noticed and the device never enumerates. The hardware provides an asynchronous wakeup interrupt that fires on HSIC bus activity while the controller is in low power mode. Pick it up as an optional second interrupt and attach it as a dedicated wake irq of the core device, so the PM core arms it over runtime suspend and resumes the controller when the bus reports activity. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov --- drivers/usb/chipidea/ci_hdrc_msm.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_h= drc_msm.c index 3ab3daa78e34..e28ea87f9898 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include #include @@ -173,6 +174,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pd= ev) { struct ci_hdrc_msm *ci; struct platform_device *plat_ci; + int wake_irq; struct clk *clk; struct reset_control *reset; int ret; @@ -261,6 +263,19 @@ static int ci_hdrc_msm_probe(struct platform_device *p= dev) =20 ci->ci =3D plat_ci; =20 + /* + * The optional second interrupt is the asynchronous wakeup interrupt + * of the HSIC instances: without it a bus connect arriving while the + * runtime-suspended controller has its clocks gated is never seen. + */ + wake_irq =3D platform_get_irq_optional(pdev, 1); + if (wake_irq > 0) { + device_init_wakeup(&plat_ci->dev, true); + ret =3D dev_pm_set_dedicated_wake_irq(&plat_ci->dev, wake_irq); + if (ret) + dev_warn(&pdev->dev, "no wakeup interrupt: %d\n", ret); + } + pm_runtime_set_active(&pdev->dev); pm_runtime_no_callbacks(&pdev->dev); pm_runtime_enable(&pdev->dev); @@ -279,6 +294,7 @@ static void ci_hdrc_msm_remove(struct platform_device *= pdev) struct ci_hdrc_msm *ci =3D platform_get_drvdata(pdev); =20 pm_runtime_disable(&pdev->dev); + dev_pm_clear_wake_irq(&ci->ci->dev); ci_hdrc_remove_device(ci->ci); clk_disable_unprepare(ci->iface_clk); clk_disable_unprepare(ci->core_clk); --=20 2.47.3 From nobody Tue Sep 29 08:22:55 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D72E341166E for ; Mon, 10 Aug 2026 15:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376548; cv=none; b=oLPKLUFybB2eDXlc66aOapbK7z1tO5CWYqAXlJUMgtZehnERBLlaj0WktD0nU76fLCZK9liWNSoomiqh6pMbYHD54wNtijiLWYVW+fxcMB2E14JotqsN7B+q8R/LcVck8+Zsj5efmPNLk0uVvEjaAfOC5TbzGS4FLuV96XJRATM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376548; c=relaxed/simple; bh=W5fwrw87A/zYMZyvs0ZH/Ywonomd67B2W25bvL7eGxM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Prq3Wez7/iwGw7rjGlhfvoUgapnZvgPRmSxTIw30A6Teo21rk/00i7y43XSmfqhwzbxHNipd7w8PidqsBRRPwjoaJZMTF2d6vTqZwABMhtJkILx7FcMjN/uBQOsiGCLsuEjeuxEddTozv3j7UjiLBKI+GaYoMCedldsZCiFZf4U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c09Tmmx7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c6ypL9TS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c09Tmmx7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c6ypL9TS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWYCM3201753 for ; Mon, 10 Aug 2026 15:42:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GCrGDHyDrQa95r9/bHjjtu86fmQgfeBAEBBhKsMFLXQ=; b=c09Tmmx752QBOxka QruGFk8j0cco/ou2TFU+r7Mm7vIHwXva7N1cvwsrPPeGtdPb2Zx4QX6jn/z+rRGe lmTJgrJ+BPzUYNHfzazialSmqEOsWI2pxPE9gzWPN/WH9+sY1kOxAbxUQAOYMX4f mJqcQ+HoEW5dfQYD79VOxrTrVIr03RvSOiv0Bk3E1NVGH0H3+UsU91aiGWqrZrY6 h1bCL+top/z/VE7fmcWdhdeOf0WXZXjVTGfb8tNA1+epGVvZl8LXkwwHU3VoYrQl 6YCUdBnITbwlKAFlklcM2nstm3hGhzxLqbzP/8DqfBVb3FiWpkout2iHX6b9rskC zyZ3vg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy19kkbtg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:25 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c083f1818so21752691cf.0 for ; Mon, 10 Aug 2026 08:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376545; x=1786981345; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GCrGDHyDrQa95r9/bHjjtu86fmQgfeBAEBBhKsMFLXQ=; b=c6ypL9TSg8zDFj27x7R2r415/Y5aFP3NdmYO03jZLRpPEkUCBTLVZRpVPKMVl5BXep Y+lgH/1bLruAb5JXW0SUgxDHBe2tjnN6IcWD527TMnJQPXNE9cZV3xtnSSESvd1g6jd0 B9bnlHk8ndc+76C3yIREAhkh0O2Tm8u7rPkJXVIbnX+5+ROO/ExJIe9abld23C+6Kqiv JwOq8G1SrJ9jmi2gQTXibSjiSSawZCI55M+2MQYoyuYyhVDIlJhtzQ1B2fFZ7WRZQDx/ 0SUCDA5ZYGgrC4XZvBh9g1MTJtARb+EHv4XoomXh0wsthf8VMIMVmpiSKPVZSMfKikpo 1zuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376545; x=1786981345; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GCrGDHyDrQa95r9/bHjjtu86fmQgfeBAEBBhKsMFLXQ=; b=PsfRWlmKtc3uXXw98ygularaWh3UHSPJDX9ep4u/qVpvYf2TsXPOCYvIt1AUQmskC4 U0fCZOYXjtUqpJS6pixDJW0484LA5C5+i9EvyseX2y67dVUC5ScTBNKtFwDSxSriBNMw 0eM+0FcxTxlL8vXNTgQJMsvj+2Swj9fUgEOPot2E8dolPzu3rIScH9QhrLxsCQFoGp4K Ie5zW18mi1YeNKJ2y6d4yKFA0psojMVeAr4AJlp+AFUIdlfJwEIo+2y0vXOvSpedwxgz a3THoKFTOzVbQqBc3YRMAjLIyY8/htFA3JZAbLKDcU7BLEV+qotdDVujQNvTWDGw2kBZ Xpmg== X-Forwarded-Encrypted: i=1; AHgh+RpNiQgtB4VKNhZqMTgvUdLi2FXt/pObqjMEIqCljdW1Hzb21oyuFF3e0F1+lK1j9Q/pt7eFZx4ANatj1Wk=@vger.kernel.org X-Gm-Message-State: AOJu0YwXT4k+Nbm1la5YcjVAieNghCRcqmOZB33Fizcmxh5h3GmX4BXq kUR+mNXuNhCcNz2rMkX2QMkktK6xFF/oDlyAunCTj7zn+n6L6XAl5fPxA1QiBfm37aAmejtvDkv m51OEx9W9n9srZdhasZtyMKsNoytotXIVwov22BXJo8C7aTvf1De+9jQvC+OBgt9Mi/A= X-Gm-Gg: AR+sD13E2Ak/JHBTcc7CrpK5GOJHDzdL8Hsdf43gz0j744vPG6YerX6C4LiuIoeQoKW ApVT+jyGEIEAlqrwQQzBvXoNz/xjpY+Sy3dtvh81zfz5iip7xRXQVhXV0okcoBp2E4OQU7fE8oL l1q3sYgYBbdM5mXyiT3tYiu16UXT7YkyjHBtHUN8BFLcF5ps7nlvn2Unf+Z5oR4iGZSUTVkeTOL vu8wm7cnzwz+U7+fQXaZuxU2Mj+L8YjwgiJJAxMSBa8r0eIzPvwkfK2SEmCbk7FVde84moAMoZP YqI686seyk7UAdsxtrtYiNcMYUn4osvT1vD8qJVGayB4Bk8OSXcxAyzVBfR4Hm2lDdYa3aJb1tc C2eDcpHI90m7AIhumhNSdwYbQ1vjzqgd2HmhmB8ZeZJ1819rfldudxZ2LnKk8NQHmiN351l3A+C 8hR3yJsra8t0baDg== X-Received: by 2002:a05:622a:58c4:b0:51c:963:cafc with SMTP id d75a77b69052e-52d20a814eemr255582061cf.41.1786376544553; Mon, 10 Aug 2026 08:42:24 -0700 (PDT) X-Received: by 2002:a05:622a:58c4:b0:51c:963:cafc with SMTP id d75a77b69052e-52d20a814eemr255581111cf.41.1786376544064; Mon, 10 Aug 2026 08:42:24 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:22 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:10 +0300 Subject: [PATCH 06/10] usb: chipidea: msm: keep the glue device runtime-active Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-6-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2213; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=W5fwrw87A/zYMZyvs0ZH/Ywonomd67B2W25bvL7eGxM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFQhTQDcU2q5OpKlPcQt9+901ij4/eO0pNy/ HSEWtd7m3iJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUAAKCRCLPIo+Aiko 1atgB/9L0zN0A8qyBtwd82vNyEPK5KczZuUzbj/WjMLPPb+4l0Q3ash4UwV7mMg5NN/ewuxYNK/ lL6Ywgcv+8x4aToz+jDBwPPDYjmzgBezMgBtUW22NvPUG6+efLudrkNisso2Au+ATDaxP6BAcce kkpONMN8GRn9mrLWwGCMmROlJslpvJSeGzvc4nFbtku9clhrJKi2mHQFeI2lBzBIaGBH+K12Mk+ Mn0hmMZCBnyZ/bvBGVA20M9wIuCyJXgRDwIpFTldc0FFhhwuoSRIB8HE1wWVoVzMZ/Q3twkGmxR 76E4RQOFwkp4nJdrNElE2LUMNEJzBT1hBg9xYM0eSRC5B2qH X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: VoVICb0R3cHGqQBB-tIsgItvVeEpxA-_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX+oSrMEBwMyxa mmmz7Xmi+2+y1a76ss8xb8rlFGYJuMarRf+JXQzYnOEbdmxx57LYbPNayiUZ9SI0WS7xXcSWjR5 POSa2ymlvbjjaK9CgcjjSBvmy0RnZsS0PhwqFfII/l+odoDEmTuzOdjJrMYsR98wt/obhDdwpsJ izGqgJFSpiDYly7kUjCUhmYsREVKr7fjJDNle8KK7K6o/45Rl7ihkJd7wCOCHBdh8FyrzU1ASV5 1Tir5i/uTkPqRqq/H0QvP5TsPz+7Uq5w6qvn44ZR8zZF3fKePlh0WM1bZGhTZdPjZVoUiwImPJo 8st+Ab3ojPDuoXgqAJDSRcFoQq/excv1fdNFpLjIypHwFER08X4GtZ7iZOtrCHBqKfLe+8OlvGp bb25jQitXMXJt/ZuTR4VMaa+EcXPWHK8YILeY8Gz4eE4e4hsAvplKdKoNMqLHTzOeBCauUJwYi9 FQUvxquhAktbzWH1LvA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX5qE6jH+IdYeD iw1iJ7ecd8JBSVBJbVRmZx+quU3pNazqVJA9uCJCI1IC3XluWbtmNQFuiEqxQy5V1bqrOWncJlG 0ap2t0eF5BsFZbhTo2CONYy187DDYWc= X-Proofpoint-GUID: VoVICb0R3cHGqQBB-tIsgItvVeEpxA-_ X-Authority-Analysis: v=2.4 cv=abxRWxot c=1 sm=1 tr=0 ts=6a79f161 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=Gq4z8NyD3fEPJbr1v9MA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The msm chipidea glue enables runtime PM with pm_runtime_no_callbacks() and nothing pinning it active. Right after a successful probe the driver core's pm_request_idle() runtime-suspends the glue (the ci core child has runtime PM disabled, so it does not hold its parent), and when the glue sits in a power domain - the HSIC instances live in the USB_HS_HSIC GDSC on msm8974 - genpd then powers the domain off underneath the running controller. The EHCI register file reads back zeroes, an onboard hub's connect is never seen, and subsequent bus accesses into the unpowered block wedge the interconnect, eventually taking the whole SoC down. Pin the glue runtime-active so the domain stays powered for the lifetime of the controller. Proper low-power handling can later be built on the child's runtime PM together with the HSIC wakeup interrupt. Fixes: 2d0cdcc5a0e4 ("USB: gadget: Implement runtime PM for MSM bus glue dr= iver") Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/usb/chipidea/ci_hdrc_msm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_h= drc_msm.c index e28ea87f9898..9a9410a814e5 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -276,7 +276,13 @@ static int ci_hdrc_msm_probe(struct platform_device *p= dev) dev_warn(&pdev->dev, "no wakeup interrupt: %d\n", ret); } =20 + /* + * The glue owns the controller's power domain (the HSIC instances sit + * in a GDSC): if it runtime-suspends, the domain is powered off + * underneath the running controller. Pin it active. + */ pm_runtime_set_active(&pdev->dev); + pm_runtime_get_noresume(&pdev->dev); pm_runtime_no_callbacks(&pdev->dev); pm_runtime_enable(&pdev->dev); =20 @@ -294,6 +300,7 @@ static void ci_hdrc_msm_remove(struct platform_device *= pdev) struct ci_hdrc_msm *ci =3D platform_get_drvdata(pdev); =20 pm_runtime_disable(&pdev->dev); + pm_runtime_put_noidle(&pdev->dev); dev_pm_clear_wake_irq(&ci->ci->dev); ci_hdrc_remove_device(ci->ci); clk_disable_unprepare(ci->iface_clk); --=20 2.47.3 From nobody Tue Sep 29 08:22:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35AC4411A04 for ; Mon, 10 Aug 2026 15:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376550; cv=none; b=qC68kmyluIC9cOCn8fOoucmHTcKC4iumHes5LgKD0ThW3UvpQOKqhs6FUnN6o4g5KmSQg6P0OGJVL8ohUpcpykx0h9GdzJWJdANypnq+VHc/pqwOxveBAY9ZRkRS/UQFFpp4ZZQU+CJKfLUSMXBayR/HU1udP4Si4mqmZPQEaYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376550; c=relaxed/simple; bh=KOQNNO81+830lW+Q5k5LUwxKxi+2T+vtgXBl8cZSLfw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JAkreJAtch8XrCFE0/Z/t0po9jav9LClPKPRcSdN2gQvqu6p6g3A+p9z40Ac/npq78wIjeuq1gGrPZzHOoiVk02874NYcm701cBsSihRdPnShW9bbqkNQ1BWEy8E6jeIXKoo/6Zwi9xadM16nj1/jz4pdrFk+d/5Kl3/ZP+HbnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jxdmszqn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j9mgvsxs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jxdmszqn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j9mgvsxs" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWP0U1982865 for ; Mon, 10 Aug 2026 15:42:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VwWUHl7i5SxMpjZvZ8DdyGzjAdldYolgun/dp8YjJTM=; b=jxdmszqn7wOWgM4g BQIxMCEhb7VA4IFBuq8zWvTYwal3EbxIy/TY5wi9PbaOaFD1LL+aH97yZQ7HvRI9 K26RBeI/XFAlm6QmUZU0OsNQ6QV5rCutbp/nt7TkwZCpgbg9+BAcxfN8M4pSEQgx IwaQarj+/eWbFERrk8p7OKo1JOdPLkIGAd5uBlAXoqTjybvAXITMGVGG1AHSXLLb NYpTv/JCbDXfMIlGe8OL+AofhJ5H1jwNd28tyyrlGH9odQjNmWPuMTuz/F8oTrKy pcQ9IuPXo2pcRVkOeXjJFikBf1YOZK+XbYtt/rjtZvyzSefQ0RqUcHsUW8MXPtDk GujWBg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v6tcbc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:26 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1d137a68so46202721cf.3 for ; Mon, 10 Aug 2026 08:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376546; x=1786981346; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VwWUHl7i5SxMpjZvZ8DdyGzjAdldYolgun/dp8YjJTM=; b=j9mgvsxsu4ySRN0CuyL2zQIg5Fk2Uvkd9lFYSq7Fy8s6pi0QzY5z1+W4Jod/EC1vuC fsEKyy5iyKG7uBLOqKa4m8UDe2ndvsBKLgjNgA/JZD0pVVJ9ayT80BMrpXlGXUVVRM/l stHPRdnqEm2L1wqFeF4c6AXxOAe8Bo0yyiD3Zy7ZER00nKXvusyVYR8xzDaNchBQi8jK rgFb44OvTOZHa11yzXqcB7w8+vSONo+Z7T99UWDidQcCqx1gRNvT5hOTbpR0CBld1kR2 Og20TRSXdBF4SpiCaD4AthIczO+fCrvSipwL/KZcbS274neJ5OndIcyq8r0sDi47f894 zVAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376546; x=1786981346; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VwWUHl7i5SxMpjZvZ8DdyGzjAdldYolgun/dp8YjJTM=; b=DHzJXezPM+55AEO5U7f/lcLNtRCJdMHnUsxVXpyz2sR2QmlNRVtkz/5ZWp488XaoVx s2ZY+KMLNhioxVYuHtk9LD3BK8SgbfriIgyYTL4Dgy2VdG+dsReCU0VleIYmNlOV7K1t qMRpe0dVcgE18tbuCsWx/Hv4vq1Pq8YSsbPhSz2bEYCRiRENxShXBS2W4Mbow0w0b/bt w3d+YUhMTetTGQsSJUzd6GnbylCYJCJ4W9eY2WDR64uWTvBVBmzUWshI598DYz4A2X2F Y5GQt9CTPJE7s4HpqZu1RI3Gl5ew9STBJxmku3Lwicd43WbMIgN56aplLpvz2jGH/pBe QV0g== X-Forwarded-Encrypted: i=1; AHgh+RrQXelQf5OV8RjSmehzvgvix2lBiC3nVvQ36zISceox539rej5bSU6bp9be3U5OMnuxLcyuypZ6WRR4zRM=@vger.kernel.org X-Gm-Message-State: AOJu0YzDOF5zkXtIYSfNLZCy5BQ5N2vjbc8300w3DeFzNQhL/Yn8/ehk 3+xtbX0En2iAL6xjWWlM3ofFszZy+yfsFY/Msu32ysTTfQl1NcOgq8PZMzlQAOxxKOIjyQfCP++ 6J3inbc9tSjNqf8Sc123YUbV6Q3/uvHTWiabnKVxBt7LKVE4mHPllfqZT4heHL7QTzhc= X-Gm-Gg: AR+sD1161aL7J54HnLe5XzCvabs+f9CesEWe/SaRC7BV7GgYYVWGwrYyMLpANjOgrx3 27NpsGqoWJJt6johOUPC+h2a3N3MIFENdMh4lKDy/zMMCSoq6/YfWjFK187B0XfTcAv9snJnRty MQi2Zq4UpHQ89ek0AvLlZK9e3xDlapK5kxBg4bvEjkMGYDR7QLbAVz8QpRH0qsKJML+Qbb6p2ku W7usYADKv+eP39QPW9VxpcpwgT16hd53+GMQRZNPmUVDd6iI/h0ldCJI9emSwi4ANrMfRkoHPpT NdpXoRv1yljsdOgk2DyARAMcdMc+6G63eDYj5Nn3VRFiwYSP4IwozSvjufbFlgJGmDG8AFjQFam E0olAXkq1Gk1jXBIo7IC32Q/JgXygsivfIjJ5PeH/hCTxAFIo6CV7Vj2f9UbNJz9LgPOZIRIS/t z+W4qXJfuh7+QVHQ== X-Received: by 2002:a05:622a:1e14:b0:51c:d52:6049 with SMTP id d75a77b69052e-52d20a10f1amr262582571cf.28.1786376546328; Mon, 10 Aug 2026 08:42:26 -0700 (PDT) X-Received: by 2002:a05:622a:1e14:b0:51c:d52:6049 with SMTP id d75a77b69052e-52d20a10f1amr262581891cf.28.1786376545891; Mon, 10 Aug 2026 08:42:25 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:24 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:11 +0300 Subject: [PATCH 07/10] usb: chipidea: msm: do not force the TX FIFO idle on HSIC instances Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-7-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1439; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=KOQNNO81+830lW+Q5k5LUwxKxi+2T+vtgXBl8cZSLfw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFREDbAEKMO2A2Qs9sERI3xq59bkDCER9uEc 7ajvN/A67+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUQAKCRCLPIo+Aiko 1cMKCACItVH4hSeLJfpkqgtM3Mn+A0oSAX0xdpecK5aC/leaBuzd+gGevn7S9wcw4VTojJH0NY9 dlDqP/dudfyiT5l7h3bhhYGIq/UmrMHFXjWHdY2u62V1hYgendPYLbXSSpPAeOKKKE2p/amEH6M uVck/ccgyD2q4xOK2AXuzcyH5Zm9vobVl0taSLfCTB7wvYltD46LNhXdMLePE9DFsID4VJLdFbh 9Wth5gRpr2OSRCyTDtM9tzLupcOH33DHNSyCImYJuWTGYg9LnDODCk1HKcyN8/XMFFdlWX5hJcL hugegT0rjwOPAlYMZpozWbu4BwtyYPhlag1ogWOEb1BpZdyC X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX5+XkbN39tDbj tlBbjnBZWDzPC513vG/B2XbJxmqeqXXdxxl015KrDARtr/VN39lGMvg9J9balO5HgX/DiPNhvDi 7iQ1HBH2yfYTp/1bnTkdZ7HoKJsABjM= X-Authority-Analysis: v=2.4 cv=PvijqQM3 c=1 sm=1 tr=0 ts=6a79f162 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=Nuiyuvcmx6Gf9mYuf-0A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX1isTo5Lq0GVH FBo7FPkl8hge6JUKM0SJcjQf1nxDG3b4lIvqybqFr/ZhzPGsU/M1+FWbSpDjWH9kaNYqEhW1O7k U6V+7LChWsMHUqOvjR5PlwX28i17bChYTH0XDXE/bSf5BUZko7nCsJ5lzu5PIiY3qpafo+ete+G mzcVsrUP+zUNd2YDQK/FGnfgUf1d//ow8XnriyiNQoH/7uQyAF3gLiQPW+/nBYF/Ah3GUanTFPd +nl3tDUSJNKedoVJE5GxqjgbiEeYWsH2K4VJZa7CnvCJZ+OhfuAFj5H6EZ6noF19Cjv8pBMGJSr 67Bjj2+cPvPpzguOJPsp/p4QSo/3CAF0A9ocHwEKPaVLGED2/cy8Ca51sGdPXkjqBY6oE1BX4Uw RAlWSsLpUtkM/PKc2tO59i50pGUnioo6Dzjzw1EWLS+wVNRqSuOX67Gmijq4Ax10WBoWB/5sLRk fsjxutgwATuX0athfGQ== X-Proofpoint-GUID: wOsTTRYaSxGfRTk9tAGP1C_I1vjjlx_c X-Proofpoint-ORIG-GUID: wOsTTRYaSxGfRTk9tAGP1C_I1vjjlx_c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 clxscore=1015 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The controller reset handler unconditionally clears GENCONFIG[TXFIFO_IDLE_FORCE_DIS] as a workaround for an RX buffer collision issue. The vendor HSIC host driver never applies this workaround on the HSIC instances and leaves the bit at its power-on default (set), so clearing it makes the HSIC instance diverge from the known-working configuration. Skip the workaround for HSIC instances, like the neighbouring GENCONFIG_2 write already does. Fixes: 47654a162081 ("usb: chipidea: msm: Restore wrapper settings after re= set") Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov --- drivers/usb/chipidea/ci_hdrc_msm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_h= drc_msm.c index 9a9410a814e5..69be194f8e27 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -108,8 +108,9 @@ static int ci_hdrc_msm_notify_event(struct ci_hdrc *ci,= unsigned event) hw_write_id_reg(ci, HS_PHY_AHB_MODE, 0xffffffff, 0x8); =20 /* workaround for rx buffer collision issue */ - hw_write_id_reg(ci, HS_PHY_GENCONFIG, - HS_PHY_TXFIFO_IDLE_FORCE_DIS, 0); + if (!msm_ci->hsic) + hw_write_id_reg(ci, HS_PHY_GENCONFIG, + HS_PHY_TXFIFO_IDLE_FORCE_DIS, 0); =20 if (!msm_ci->hsic) hw_write_id_reg(ci, HS_PHY_GENCONFIG_2, --=20 2.47.3 From nobody Tue Sep 29 08:22:55 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7249E41D4E9 for ; Mon, 10 Aug 2026 15:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376552; cv=none; b=PpDnrG7Nfe77LzgtwMVKUSacPcKTE1RejMCDudZ88L4t98k637nnMzQAB8CEVJ4nTIgDTj/0k59/MToyLNLfNF3+bsDKjtYF4qio6SsBsiDA2atS54Npq3eluP8eysW7JBLwlZKOGLEQ9wEoX6DC7WFz5tsBuhXym9HSnc5Dcec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376552; c=relaxed/simple; bh=R49ER/gxWRxFuxGE0BY6zWUSKOzrVJjau1n5zkgccSc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wh81fEiUKJODowe7LUWphEmzmI7kiy4vvKuo1lBqnqHsTQ97RdJ7dBzrsxjZAZo8rct+laUNOh261dnIPAS5HUH/DPtWk4F3pDx16a+i1w9qAx6RRqDO1FVBuhPdZf5u2zn2WpVNUlin8HDIvR1bDXHo/uebdkguUoyGM7oS9WA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SLk9K5Ou; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U9KSyMIO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SLk9K5Ou"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U9KSyMIO" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWFcb1754218 for ; Mon, 10 Aug 2026 15:42:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G023oLebHt08Iu7D2qcmQMAHLSYQBvIdenvFL+u+nwk=; b=SLk9K5OuBVnrUOZC rdbgp1eW96WQpkm8EMy01WP0jGIJm+UHURPbr8FxxjakPCIlNo7rrTkY1F70+ZUa TGl2nLUpCe5rlF3jhFVCWxIe0bMsTXSVq4J5QQ0VFp/HjbzZFvTJw0g6F8bxQVqy 8tG77u7nhwjz2ClrDzQ1GD3G7miQAMxQ7K4Gv/CBsDD806au1cE+NLCPBl8zf++f embyyuGU4P6S8waNtkpgHUz2L5DE5ZEAFGdz0ZGoY8lSIpPmLTYEV1O9jwrDvAME P4Wz9Jvbow0YALM+8Bdz+sTJ56bTguzxmSV77o0rKEmyS3Z8tHvdZffYQdZSHE51 vm0R/A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v4aa9x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:29 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c0199faafso24300151cf.3 for ; Mon, 10 Aug 2026 08:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376549; x=1786981349; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G023oLebHt08Iu7D2qcmQMAHLSYQBvIdenvFL+u+nwk=; b=U9KSyMIOihyWbKH4ERIdANqaLvBPbMpNSs65tFEwN6Bvb04NwVeodtKzeolzLf6AdX E8c4XcQyFSzepQ0xDYJ/dDr/D5Z6ocKfTmRYRn/YUI55RPBfdH2BYm8drDdVOXbGyNx0 cH50zkj44Jgjh1VRl3XVm59pdqX1w8wnBI1PpOUqaxPpXaVFVx0ynsWN72ELeqw6HKOB VjhPcA4bUDHTwenkYlWtXyBfmSXTuY/JEEAuM9inW4mQ5wEzp4Ga1kQ+nTavYhmXx1Qw yR4oo9n7/z9l42/trU7w2TiZD3ZUysX0tmKnLAK0NuXHUsREd2YkfQS10eZvJK2E3z5K TnZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376549; x=1786981349; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G023oLebHt08Iu7D2qcmQMAHLSYQBvIdenvFL+u+nwk=; b=Iad+ptCsUbc/vLiIYJxm3etu8pZi9m6KGzIXPVR+nVph/AoW6Qt6hCYOhkAEtTkVQU joccOadM6cA8oWep7IRP3Fi9JXmQSVi4NOITpYfV8NQ+pUyhESAxVcX7/N20jtUMLIFR 1qklvW5T0EotBJNOYcQBqDhUvcgjbevI+pJOMbTEl1sAVXU9hjzVIy707nScPwe+EDyx nEwWUid2fMlStfq1fRSg9rVAzrFsQDcauA7Qtrc6MUP8ynzwuwmhPuxHtK/H6F7ur3Er sbHw5TiFlUJuebK7s3YOWglVaPoMG/nGnzK/HQJ8bKgRa+udrs70/GdqFcs7DXYHJoac BSSg== X-Forwarded-Encrypted: i=1; AHgh+RqMbcYIOZmPCBsNZSE8Y3Szb3sD60sR4tjMRcoE/hoeOTq7LzYrds3Okj2FkjRTiUptV/u10ynLIN8bHQY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo5aA4wnBv/RCIn5tf3hIqDjVq3dHABafmUZE4yWRNs18cNmTE T/HU8h/7iKy+U9dOoqlxhrz7ATI57q8hEBpMUuiRZ5A2Cf+moLibKjF7rfWYaTBerXtyDoqXm9V Hbue3AgsmlBrS40ZpwaGI7HLPjfyaNxfPPf3GLfftDx6XlKRQkK8C5W0RE7iDjlmu55U= X-Gm-Gg: AR+sD13LhfJprzojEsP1oVc4NJy31BwvphClx16fVfToRCZe7MRABmqzSyCRDQiZJxn f99P1kEg9neIp5lOK5dw8Tvw07g1TcKX3aGX7j+rifqa8xJOFJASqmQQFFeNNUoHBPr0MHQKhgE DKCDaJSYJ92Jauoxhc94wEqwhY4DaLjIIqRZ8zdQCJF55HIMoLDLw3OC23zL7e4ZUzIrka6hhT4 g+J9yfjuKh81sxwGBH4SiD9YbSHJWcHdE4+f+R8e4DjvZPMyzlfYTmwH3CzQ3Kt/H89L42EKdEH Fdc3P13jC9vQrLzS4n2MKQJF10YyhwXKLGQ+7r+AJN662FNVRA+GDgJbA6tZdb4A4tHVY5PKUHU e6LxOuiNUFmDaQwOxs3KDB5LylImXQWm5IXaENipDtN+UtfYiBkV8SaJGGvJD7NunswcqP4a3iA 1ORUHP1oLmX6yKdQ== X-Received: by 2002:a05:622a:228d:b0:516:d699:a99b with SMTP id d75a77b69052e-52ce61f545cmr485605521cf.40.1786376548418; Mon, 10 Aug 2026 08:42:28 -0700 (PDT) X-Received: by 2002:a05:622a:228d:b0:516:d699:a99b with SMTP id d75a77b69052e-52ce61f545cmr485604671cf.40.1786376547907; Mon, 10 Aug 2026 08:42:27 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:26 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:12 +0300 Subject: [PATCH 08/10] usb: chipidea: host: calibrate the PHY after starting the host Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-8-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1522; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=R49ER/gxWRxFuxGE0BY6zWUSKOzrVJjau1n5zkgccSc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFRaxbm8F1hM5ExceXw17O2BVdmuXAN+50T5 3dOXwsrWl+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUQAKCRCLPIo+Aiko 1ZmYB/9S4PXJJai/uHxYRI7nxMrsVvpp2b+iA+rEMo9LCswUf7RBmFudNegJUuknF9U6NNGPSeR 88vQVX4Hh2wdfwLgLhN0vi63hpMJGo7u01+G5ofvjwRYoVm8uYpuWe6H0sXvmPPdh7NzZ9LT/75 A97e7bvPfBxLYnRTeiQB6SffN/11ZcKjZvp4n+S4kQhVQpPBEvc55rOKI0VBgkMefBU1Y1VJRYK ZMq/GD4B7GsNCYRBdj+HyIiK1cy/dInPM3ZpsHawE+k4q6U+9wMedJtl9supoeuGUycF0gc/fr6 I8LeTJq97zdnsCZxJBKuUJDhkv9Ok/6frP+w+lcAYFd64Cu6 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: J1OR8WETbCx2B-vbDup8pH56xAmeYB-W X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX4MsN15m+N2BR qTQqZqHL8n1OMScgf1T7fCNt8Ifs8onfh2hIiRKW3b6jhwC+YM0zLoKLqfG12GrI4qWiOEP1UC6 Cokmf6iFMtUT2C1+rWMvuEw1yV5zJ4A= X-Authority-Analysis: v=2.4 cv=W5EIkxWk c=1 sm=1 tr=0 ts=6a79f165 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=eoJ_6RDj2L3Ezgz4JzAA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX8HYE6YCGSoJ0 OWXk0E8OAC1cry9E8Iw4VZfAEDtmCBHTjUUkMBB+dGUzQ0UUD4YqU9vP0Zyj3d9gkeUBHRNXcM1 in04A+jKkNWRuYbfv0nFxMe7dCRGHvkjKGJEX2hA5fkybAhlAiO+g9wrbWoV+oaPY9XJ1kcQnDc Q4poA+KxUWKboq+Un//rhc7bFVIsFYLwoiQyCYKa/S1IXOJN6Vl/rZrcoQOkNLdoWar1ORMwUla RKQLNzX0oJLTG5wVpqZ7ESIHzRb4yLEYGddhkGwZKAH6LzAjJ2NWaCQvADTCVkH6yNwBZWAg72t lvz57iwA8O48uthXLzrhkhk4VEfiWVO3qZO3WLm68KYzVK0xWkhFZ1d3BKj/5fqO0bt7lCyMLn6 Rz1M9SNW1Eqc7fzpSHVH5JFNRSgd2Gg58qVlXxOESHeaa7QSMZEcdk/KsHPu7i+NAOhGw6Ohv8g c3uuJLYUAFvHADE5Vsg== X-Proofpoint-GUID: J1OR8WETbCx2B-vbDup8pH56xAmeYB-W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 Some PHYs need a final programming step after the host controller is up: the Qualcomm HSIC PHY latches the device connect at the moment HSIC mode is engaged, so that write must happen with the root port already running, or an already-connected HSIC device (the strobe/data lines have no hotplug) is never seen. The generic PHY framework provides phy_calibrate() for exactly this kind of post-init fixup and dwc3 already calls it; the chipidea host does not, leaving no place for such PHY work. Call phy_calibrate() once the HCD has been added, next to the existing i.MX HSIC active-event hook which serves the same purpose. PHYs without a calibrate op are unaffected. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Acked-by: Peter Chen Reviewed-by: Konrad Dybcio --- drivers/usb/chipidea/host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index ced6076a8248..62bb2999edb6 100644 --- a/drivers/usb/chipidea/host.c +++ b/drivers/usb/chipidea/host.c @@ -15,6 +15,7 @@ #include #include #include +#include =20 #include "../host/ehci.h" =20 @@ -192,6 +193,9 @@ static int host_start(struct ci_hdrc *ci) (ci->platdata->flags & CI_HDRC_IMX_IS_HSIC)) ci->platdata->notify_event (ci, CI_HDRC_IMX_HSIC_ACTIVE_EVENT); + + if (ci->phy) + phy_calibrate(ci->phy); } =20 return ret; --=20 2.47.3 From nobody Tue Sep 29 08:22:56 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF79F412C14 for ; Mon, 10 Aug 2026 15:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376555; cv=none; b=NaZUXhkndxWuyq9uywjFqqdo/KGheUtordKFFA3jsoQ9Zsv43wdC8cAfhDtOinmuYscq+8z9c8iPuHpgurxroBcPaHg4Posto2oRMsaNeqzH6z9TltPYNOQ4IqTi1G+5IPv/UsRbWpuEP611N0JPKmcwh85Bf578WmHWV0HjTQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376555; c=relaxed/simple; bh=AoZJqVVSo+ZoP1B5mllGlVyWEAwh6nCg4CrfFN4+HPk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ut/aFmvYGOMY8YcEXA88ZsiG4g4M2RV1JybWoXLQQJ2qRqrdmxC8akMK6T4ZApHeHHZV7Px7dgt5drBAvy2hW8yR4vJj7K/saKAA9VDuTC82GEIDyhNg26fKt14kwH2EtdbFlbv8ve3rHqKQi4EGeMWiVk/CyiU2P5FBJL2i9mM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jHfxMlLM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Boah+KDx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jHfxMlLM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Boah+KDx" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWNwa2057448 for ; Mon, 10 Aug 2026 15:42:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I+hOVlvodWUaHCF6f8ct+3ncKE/NpJynp45drgitce8=; b=jHfxMlLMUSqIKNqk RolHCMaBomN8/F0ZFjIgz3uMj8kZs+53IRllyuqSJaYSntJUDOynfw2sW2iDmA4s AHNWQbEKcsOpvHfF2KlpsL2zGfFme3o2+gvJzvdc7yc3UwZr/61Vq3TddCuvVWzo xu6ZuVez09e6JysCkQsZbQT55ZSi/Q2lwEp/g4/UDzulrP5CXybWoldpzSe3xn4F vFzYAqmTqh7hd3Lub26fS0Mlwbwb30zqycD5ckTRuqeat1+CfEcfRLCrxukLGvgh Jne7RezkSJpqmfbCW0TT7rvPT7dn/pS/jmNSkkdZw67XrOlUV6WxMP+vVQ4Yg0il LqMfqw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v2acsw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:32 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8ec3314f65fso19957016d6.3 for ; Mon, 10 Aug 2026 08:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376552; x=1786981352; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I+hOVlvodWUaHCF6f8ct+3ncKE/NpJynp45drgitce8=; b=Boah+KDxIm/dlVZaMzOjdtgH3m9/N1ZCLkFKauPobCece2j9TVYQLQqE4bKiA4fOqk ZZfKZA1GUbLE/vQHGLdHrBjZwr++MLHZkolB0X6UmZ0Y4tcPcSnAhJ/u1tj2NP1Hqv3K Tl3cMKVNSIWsqENTRFuNpg4IsiqNa94gczBv42xZCCmzuEPx1CVY/AoKz2NCv+2EEq5Q 0O/9LjshjQfoRqrMGtXgjleNYRAFLeDP5Mf1f+VcXVjubarkJhMWAUrqztJy8z+kgylw Fq5TTkqESEVSzsD17AFH47fTkB0OB4mHmQRHYzx3s7ACqTlwQscmcjgqE1IJaK0qOzad AzYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376552; x=1786981352; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=I+hOVlvodWUaHCF6f8ct+3ncKE/NpJynp45drgitce8=; b=Tycbnzs7mtuj4I56Buj8Dk8T41AR7FCU417RfJ1ChC5l8v6z7wzbqYmP4S4PY/nDKG bN0mzIq01xom3s0gZOXCc00quefH6ndT9ycDkA6wEtzGgL6jHdFjH+jbHt+Aa6o+IWas cZ1k5HjDMkRBDmdIVS5v0yFUg0DLMLGiYFN+hEXUBDYvDqB4KanwKwIC32LuPbkHsaRf fZIvkwtf0/7fNn6GzxuI2rNaTwhMAGCMqFDW18XcZulFfDEtUSfV74Fo7hIJV8/JkDLY z4zfKyjjAyuG+zrbaqwnEHbz+GqjqOC7OmtfcFoXK8Yy3tRA/1xTrG4EtBYuWT/XQb9F oDBg== X-Forwarded-Encrypted: i=1; AHgh+RoBJi22s9sLKlDGefkPqw77svwWtShAwGwTrNGe+iPVXWsZfiloc27UY/Gs3+Xg8NoVqpwrwlphT9rxUxQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywjde2xWjbkxgx4AHLnhtAO2I75PfBI1eDZ+6Rr6Hvj6K3WvpHX OjnMya3nLu3055VwoyNouwsjBj16ivudZ9B1xIq/sACh7UMemaEP9nfoZvoFGf4KpJU6aaxzA+T 3F+4bxQFUSY6i9m/r2bwmdzatOP0r9MnvKmTLBQswO5ZZOu/5DcYRTvcF2coE6fNmer0= X-Gm-Gg: AR+sD129nAMNwYfNz6Dr922SlEhcbXCW55TtLbK7Jc+Lu2l77oXuRKRomQ3NdW/tqBX +vDfOqIMYJ8Z14f9VQnDaZOVaApHr0ts3wmNmKUbjXYnnWeUGm5Pocxfzqoc+2PxX9Me6+fu00D 5hFdxjDBfUiqJakqrsDSz9nqvh3QmVqny8XSkJZ5+yjBGvGK2jfkdsQ8aiRqdZanZe0eXQ0MHY9 bVb4OOb0i35v1OgR2vmQW7noEu75J6+OnmXdtvKPKegXB5WHKMTzseI3BkSDChdFMU2GmNPhD9e hgY6Je59Mw7BVXM2P9+Q1fs2KvDi/1lquioorfJ3+3o16uYWu+oUB/N1BnnQN+mnb0QSaO5YGjx Mc2eiahXVfp848kpUA9mQc4olQ3qHgiT/rdBDP6rHBSEyk4ixcw16ssfaH81jAkFbnIN6PtxQ91 IbBsgI14Cg27g+bQ== X-Received: by 2002:a05:622a:1f09:b0:51c:167d:b328 with SMTP id d75a77b69052e-52d4c251541mr32256411cf.40.1786376550321; Mon, 10 Aug 2026 08:42:30 -0700 (PDT) X-Received: by 2002:a05:622a:1f09:b0:51c:167d:b328 with SMTP id d75a77b69052e-52d4c251541mr32255431cf.40.1786376549857; Mon, 10 Aug 2026 08:42:29 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:28 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:13 +0300 Subject: [PATCH 09/10] ARM: dts: qcom: msm8974: add the HSIC USB controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-9-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3085; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=AoZJqVVSo+ZoP1B5mllGlVyWEAwh6nCg4CrfFN4+HPk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqefFRg39N0tUH8uaZmrJ4GFul6JSkWDtgH3bqy rr5MP2jP92JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannxUQAKCRCLPIo+Aiko 1SiVB/40EuDT4bcTQdsQdEN3kOWqySmkpWkj9bLL9kuiS+NlkLln6QGcFc13/zxSkQSk16yZEZ1 h1K+H0irtCBFzFGTidDD9UA/gadXnkDrAwxrO363i3O2rr0HPV0bwmf2pZO1vsEyu2Nv352E0I8 SzD0FflaDxjAJw11WAHgly1oyJq176j8h5+3ONtci7mAV+2N9m+zFJtVrNxz2QmZoMr5VrwgqgS qU/4/Pg/4oEKd790sT7a2LSAXiIrG961BRz8xhsORLvADKhfalwb++/kX9yXPjjgGq/FXx0uFxF ML67h1d8LFVTGKXfnticFrcAaXfHw5Gcci0GGDf6IGAZqsl9 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=S9PpBosP c=1 sm=1 tr=0 ts=6a79f168 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=SNm9lHMw0LAWI6_J5M0A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: aWenRU6PCzuPvLvKWFX-3BSmqbAZi20c X-Proofpoint-GUID: aWenRU6PCzuPvLvKWFX-3BSmqbAZi20c X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfXwQjWIEUzLeX9 JqZYtQldl2LPH+JwCNls4jYXOweS78UuvZSRduYX9+2+1/qiXAi3VR2ElEMz3khj/kuPS+GNiH6 BB1JNWBe05sgKmi0zo68gIHhxfOIU6WI80sNfrro56bQnUWINDGZDgpN4rvoVULuF/I8iFJh1NI tZYvrKPhba2dDa8CJWowVGScOcxnI7sbhOaD4DQiVgLjYQ+hBUTxBubGZIhUZOdvxad7RWeu17E tPeLW1smim0ZydVarBRdHCvaGNea0OAobXfHb1HI5bDdF2bK+KGyoXEgB2P7uNIAcv5ebI7FilO aQLGUCgHvGDuGzL5N6OCIV2rhytp565CYgONhnwbdTtrg3ng+hmYvsVHA8Tg3ho7p+6WbcGKLf8 WwtXSrAL19z5vVsPU4NygqfD0Fw5rreSEs6xJ4zVKporC0Ep2TfaGBQETBvuoFxMxGVKjBr+3O/ zvmrmEVukhWQ/sYPoHg== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX2kGYA0AD5cAT bgLDeWKp1/8ViIa4j1fLpKxKfdusEQAmBMiAVMyHO/+VRldW76c9+KXv+/KoPVm0EMdbimrWF+i XdpxYsKE1t7XpSAc1AJ1BTJ9rb7gtmE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The MSM8974 HSIC USB host - a third Chipidea controller with a dedicated HSIC PHY on the special hsic_strobe/hsic_data pads - is not described, leaving boards with HSIC-attached hubs or modems without upstream support. Add the controller and PHY nodes. The PHY is a ULPI bus driver present inside the ulpi subnode. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Reviewed-by: Abel Vesa --- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 71 ++++++++++++++++++++++++++++= ++++ 1 file changed, 71 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/q= com/qcom-msm8974.dtsi index bac3c8772e0a..72cd369927b2 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi @@ -760,6 +760,49 @@ usb3_ss_phy: phy@f92f8830 { status =3D "disabled"; }; =20 + usb_hsic: usb@f9a00000 { + compatible =3D "qcom,ci-hdrc"; + reg =3D <0xf9a00000 0x200>, + <0xf9a00200 0x200>; + interrupts =3D , + ; + assigned-clocks =3D <&gcc GCC_USB_HSIC_SYSTEM_CLK>, + <&gcc GCC_USB_HSIC_CLK>, + <&gcc GCC_USB_HSIC_IO_CAL_CLK>; + assigned-clock-rates =3D <75000000>, + <480000000>, + <9600000>; + clocks =3D <&gcc GCC_USB_HSIC_AHB_CLK>, + <&gcc GCC_USB_HSIC_SYSTEM_CLK>; + clock-names =3D "iface", "core"; + resets =3D <&gcc GCC_USB_HS_HSIC_BCR>; + reset-names =3D "core"; + power-domains =3D <&gcc USB_HS_HSIC_GDSC>; + phys =3D <&usb_hsic_phy>; + phy-names =3D "usb-phy"; + phy_type =3D "ulpi"; + dr_mode =3D "host"; + ahb-burst-config =3D <0>; + + status =3D "disabled"; + + ulpi { + usb_hsic_phy: phy { + compatible =3D "qcom,usb-hsic-phy-msm8974", + "qcom,usb-hsic-phy"; + clocks =3D <&gcc GCC_USB_HSIC_CLK>, + <&gcc GCC_USB_HSIC_IO_CAL_CLK>, + <&gcc GCC_USB_HSIC_IO_CAL_SLEEP_CLK>; + clock-names =3D "phy", "cal", "cal_sleep"; + #phy-cells =3D <0>; + + pinctrl-names =3D "init", "default"; + pinctrl-0 =3D <&hsic_gpio_state>; + pinctrl-1 =3D <&hsic_state>; + }; + }; + }; + usb: usb@f9a55000 { compatible =3D "qcom,ci-hdrc"; reg =3D <0xf9a55000 0x200>, @@ -1677,6 +1720,34 @@ tlmm: pinctrl@fd510000 { #interrupt-cells =3D <2>; interrupts =3D ; =20 + hsic_gpio_state: hsic-gpio-state { + data-strobe-pins { + pins =3D "gpio144", "gpio145"; + function =3D "gpio"; + drive-strength =3D <2>; + bias-pull-down; + }; + + ctl-pins { + pins =3D "hsic_data", "hsic_strobe"; + function =3D "gpio"; + }; + }; + + hsic_state: hsic-state { + data-strobe-pins { + pins =3D "gpio144", "gpio145"; + function =3D "hsic"; + drive-strength =3D <12>; + bias-disable; + }; + + ctl-pins { + pins =3D "hsic_data", "hsic_strobe"; + function =3D "hsic_ctl"; + }; + }; + sdc1_off: sdc1-off-state { clk-pins { pins =3D "sdc1_clk"; --=20 2.47.3 From nobody Tue Sep 29 08:22:56 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C0642379A for ; Mon, 10 Aug 2026 15:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376556; cv=none; b=ENhC0l8qPoWe3HzORmqQ0s7OfKtGgg9ojhlMF9xR818HKMq7MXHh0pawcw6JntVpJ34pPPEPlE3oudAJ5lG/FUufqVut+hIk/pldsInPR55RwdV2kNYX+AYt9ld2kC+wL17PpjZOg3iMahUG/PytqRnSBv6npQjOWF0DR/VOUNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786376556; c=relaxed/simple; bh=vDDm9UNNeBZngu98OmnO9mFNj134tAZMEgio5MqFpBQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k9RcBEsM+rY4EOEhPiegYRVwsvolPAHMW1UCtH5tyNDUDHdJLZ1ViFQ/Jca9Gm70AN5rqQnx/DyPUn1Df4UxgTrrpZoqNaULDw/gp9JenbkPm11TfkyCuUz4QIp5tmrqhOi/7BpqXvV88DTpJSziUcg+JkpaWkOUIiQ6S19sOTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=akwxgGYi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gUHJpBdU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="akwxgGYi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gUHJpBdU" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AFWDk03201353 for ; Mon, 10 Aug 2026 15:42:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vKWiI1N+R0cjOLHZF/QZRa5LZDuo/wMrVcjfTjWK7o8=; b=akwxgGYiNPm5S6/R anwWFKN6u5wXh1RpndWx0GoZzEvRB9Q4YUuBSeCNqbSLlmREGasCbyNPAFBdnVj3 OID1TpwEwliR9wN+DOJu4bEHENYrriebnfAzzn15Cn4ZFvA/m3CXwmxk2C3VUL9l ZMZwml/RTa+xuu4areXhKv2T2x+NbY0XErjsMYHSnPeR3mdCPveC2YmO5YvbJ6Uc xgf/Je96SLn/+j1YOTMFjoUfqhTRBxuLOpvckdPrDQp/x//F6ynUO4PWLSRR2EI3 N85cahiSExYKnkN7dRtVVMgcqzXFxy1Vwcfj3dZb+hcnmeKahHgzgbq9r8mYQID0 3KxkoA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy19kkbu8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 15:42:33 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5174a23afcbso24282291cf.3 for ; Mon, 10 Aug 2026 08:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786376552; x=1786981352; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vKWiI1N+R0cjOLHZF/QZRa5LZDuo/wMrVcjfTjWK7o8=; b=gUHJpBdU9wvGU4Yp3qwuzzvGY72Kf5mNRn7pWgGH8+4oGP99hEQtDaCnUUpyvUFPNu igPAt9gsSQOVOVrYhN1SMZMwZGTGElocBN4MxOo3i5F0fofzD4bUjHrbzrPwAWBa16bS HnwGW3auX8Y6pzMI43r75INM+DhYwmdF2FhTEz/h65oaS+YySp5xLu2pFBz6TkfaR93X aOZisndKwKgXf88KD+88KfxuoA+RpVP5f4Cc3bfrQM8jYt4J0YDo9rZKYuaEdggWpJKu 1UgWSmYgN1zyczlAk8QfIHznmnLlpkRmvW5h8zcl8o5CfAM/RRd+zB3/gmw21n1/asHv dIzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376552; x=1786981352; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vKWiI1N+R0cjOLHZF/QZRa5LZDuo/wMrVcjfTjWK7o8=; b=sP2K4DAukKTErlFEx1iZcZmv7+xGptBmSmDe1UDOirD+neWbyqP6p4RpboHYAxaLkq iItrFat5dsaxBThTY69xUMfDwUMCiyzHvdfed7zJz+gBW5EFk5Z+4QjoIm82h/55m/XY 85yzcwZuu7PFBAAeWhwd6iu0s6ZgHa3uWkhIckIo3ctQt5PRi4WibpWgEtLKaXt2ZZtj 3Iq+lEnem526miVp/lVo8fu71BYguNCf40kNflw6QAMg/NvsRYM1jcjRba/ssCKeQybP fbolyUY6n07FVLnU4UM0ijmS2neQ8HOHSfk6Xnh8pw0+OHyAqOnCLtQxDJB/JO1IyD3y GTXg== X-Forwarded-Encrypted: i=1; AHgh+Ro3wV0NDKd5GL123lXd7+q5GPS1ANF7eQP8XrAFSZwkm8i6d+g//27sTUjt+ghbqXoGEyRCrbUzwnLxd3w=@vger.kernel.org X-Gm-Message-State: AOJu0YwD5a+eI25Oj9mAQNswtj0gVaJ+0TDLfNJc4CEfoeFXtuZ0QvkE XnhbF/An7JPMfSpVqwCl7UYNftNiAMPcvyNzjAms8ROKDd79a8IbWERWsy0W8gQRLhz0jF2XuO3 99eBISJrf2IeV32dEsBampIeez8+KBCTBDqt9N72Io9m8HN/lyb5KseUIZNZHDbsxZRs= X-Gm-Gg: AR+sD10E/2Cg9q8epyXNWuQORES/AcSgNy2rNgGmaCDmoWkWHGGcDjuYL/NdwjK+FV8 kPgjmM10DehXh2i435wwgq4W+Sjp5GoR340HoOX1ivJ5Z37pVygXzA5VgyOP3vwG7zY6R4w/UyA RESr/coq4ZKdwXVC5izqm/NOYbbSu5pSuLdUKotgqmqyDZR4v76zrlQdOUohuQoPFqGppxsda7Y A+nmvDRSxYpuJttAVqpFI//jSr1Dqoi7MP3CHV1NNVVS4Ilap9Vj3BWI52JD+t3GctOBAsLQ6cA 7F3qgxVoDjy3lFe1VROREl9EWj9sxj2LfYTlTZmJmV5y9co34mTsAlu/Q0Ym8fG4r4dnkagoKTD jkZGSz83DnNvO8oR7CwaXgwNZZmSS2VfzvLE94pKcWKfddjvf1NtBU/d52VLxuHc8lpE9kyb2zb rR9vxFvRwwdtMjVg== X-Received: by 2002:ac8:5cc5:0:b0:51c:207f:6524 with SMTP id d75a77b69052e-52d1919e59dmr265069781cf.37.1786376552381; Mon, 10 Aug 2026 08:42:32 -0700 (PDT) X-Received: by 2002:ac8:5cc5:0:b0:51c:207f:6524 with SMTP id d75a77b69052e-52d1919e59dmr265069211cf.37.1786376551886; Mon, 10 Aug 2026 08:42:31 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3056f1bbdsm2071673e87.82.2026.08.10.08.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:42:30 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 18:42:14 +0300 Subject: [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable the HSIC host Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-msm8974-usb-hsic-v1-10-e5f93ea76ffa@oss.qualcomm.com> References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1766; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vDDm9UNNeBZngu98OmnO9mFNj134tAZMEgio5MqFpBQ=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ1blx0DxUsOgB3I8DaoFadt+iH/JjhX68Vl7069yvqQUu 5qu1bqdjMYsDIxcDLJiiiw+BS1TYzYlh33YMbUeZhArE8gUBi5OAZjI2f3s/7OLY/ZetjCx/rFQ 50HID9O4R5eSlr52Wb7Mjzs9J23y/jCD6xp2O7h3FXfMFb7+PbHfkmXKvmaFGzEN2T0tug8CZuT UWchwZxd8TLvSse6Tc6FYxtRZXklLFIOU/Nm4+W2SfjmGp7TGcPp5xByzcc2yKZ9w+vxO7XNuoT qry9YX3VkvvviGQ4PV8QPL+VgsTXlmvuhJOV5fHHB+t1t1kC2PQPMRoZffui/Wi0ULG5/7eeHN8 gZ9juWri/RkO7+HZqWZuhSLLDys3zttx+tPZSZdvGkzhYKCBSJS1xYdXLZ9psj5BMFrpUJ5c9Km Mynsm/s/ZteSbGPVVx4avTuav0+5PvntR/EXJ4vqhFIA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: bfONMLJ0JySxih3e2ojnqMREs7HIXE9p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX7WvzMYNlxWrw 83sTyzy0WvPCMHnP4QEXHQopor7jyDJJ1U1cfG++mUvqr5tjX3DZDMIfA3ycIiMA+FsUM2jg9lV TaemqkYC2dszhIUTaR8RUUwzZlQl1wY9Hqumw0f6JoZujiir+1wJ+hdRHQotHVFrUsKh7CNPmIK BkAMJySLTRWCEWfu80YvwdWemvloHBuw0iB8I3ovRNu0MrgUYrjXA+ea4ObA2vi1RTGYKm3CAkE OhmJn5QcvtFk77FeOvQ5OzB8pyL5naf0TKNF9JuBnUZdgSPtU5IqvrdF1b4cOrv9POFj6bpPi5X QRg5xstrXbtaqi/gruWbdQ+kJnjjMhn+cjwMOHui1+5NYgVwApMkgoE4NvXMHhMDyvlQnF8R5U5 3PD9MCuo7FqgQUtokkbSPzbAUG1vHHOZ7kwTNbzQJgkY8WRljG1t96CvNhsRYs3fL7JS2SY/7h3 5QnBZeAvPsH86lq26Ew== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEzNSBTYWx0ZWRfX4At5sshmErzk uLCZjnLazFTz4cIwVHAS+BV/4O0Eq4O8EB3jX3N1Uc0BFHk2R8Wvv0F95tpp6ZSMHBTCaBOD5n0 2pwxssBgPhHM/9rbXvB8wsdotx28SCk= X-Proofpoint-GUID: bfONMLJ0JySxih3e2ojnqMREs7HIXE9p X-Authority-Analysis: v=2.4 cv=abxRWxot c=1 sm=1 tr=0 ts=6a79f169 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=VFyZVMh9rlY2QtTs7IkA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100135 The dragonboard carries an SMSC USB4604 HSIC hub, but with the HSIC controller undescribed the whole HSIC-attached part of the board is dead. Enable the HSIC controller. The USB4604 hub isn't controllable through the I2C because of the board design issues, so reference it as a simple USB device, describing the reset line. Assisted-by: Claude:claude-fable-5 Signed-off-by: Dmitry Baryshkov Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio --- .../arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts | 27 ++++++++++++++++++= ++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts b/arch/arm= /boot/dts/qcom/qcom-apq8074-dragonboard.dts index 083fd8fa0aea..02183b37ddbe 100644 --- a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts +++ b/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts @@ -158,6 +158,14 @@ &mdss { }; =20 &pm8941_gpios { + hsic_hub_rst_default: hsic-hub-rst-state { + pins =3D "gpio8"; + function =3D "normal"; + drive-push-pull; + qcom,drive-strength =3D ; + power-source =3D ; + }; + msm_keys_default: pm8941-gpio-keys-state { pins =3D "gpio5", "gpio23"; function =3D "normal"; @@ -487,6 +495,25 @@ &usb_hs2_phy { qcom,init-seq =3D /bits/ 8 <0x1 0x63>; }; =20 +&usb_hsic { + pinctrl-0 =3D <&hsic_hub_rst_default>; + pinctrl-names =3D "default"; + + status =3D "okay"; + + #address-cells =3D <1>; + #size-cells =3D <0>; + + /* SMSC USB4604 hub, standalone mode (SMBus config not usable) */ + hub@1 { + compatible =3D "usb424,4604"; + reg =3D <1>; + clocks =3D <&rpmcc RPM_SMD_CXO_D1>; + reset-gpios =3D <&pm8941_gpios 8 GPIO_ACTIVE_LOW>; + vdd-supply =3D <&pm8941_s3>; + }; +}; + &usb3 { dr_mode =3D "host"; =20 --=20 2.47.3