From nobody Tue Sep 29 08:26:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9083412279 for ; Mon, 10 Aug 2026 14:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373515; cv=none; b=WuFQri3zdkBPrQ/X/uSG6HZlwjmvveXOon0Rhabu3SdZBZYWw3eYhfBqzuM9b6shkO/DY5NPb8D8S/7iC9czqyi8aU0jGLdIxzIjubiOjx2SEaX6RWPCtj23pELG4AfsWU5q3E9Y3j3tkhSdA3iwPpwlnbaPAouO6iEoV2lNqPY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373515; c=relaxed/simple; bh=r7E8ZVmX9Up1oISda84Old2tqIxw9+NGvdtLAuv610g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ubtx5b+HJVIjD+plm1DlrlYfIMZ+oRvkNPcgj9hnCEFDpoEzrGVxCW3Hebe5L1Ylk70m9cDNdZ+HmYZZbj2wOQRPQuVuehad9cTVgh2tyK+cNWBRsaTghtI6tKphVlZFo4pmFbg08y1AHCkWazpk2zFbtnTgtXDybB90ixzxtrg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h0iBKJiv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X61MWarL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h0iBKJiv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X61MWarL" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67ACj2ww915809 for ; Mon, 10 Aug 2026 14:51:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aDFyPqw10Ep82ElDuZGKcT1q4iRZM5kCL+pWZOCaT5o=; b=h0iBKJivkSLJmqBV Y+JcftgGcaGnvzQ+Wfkzz+L9SNN+MCGpFTfG/92s2hjvMAI3O0QM8NcaHIxz6qTR UvbfhzNT5nqKVX3mIjF4GkZQQ3ASdMY1KSjR2zfWPeSYpy+FOjf2cwyEZqDCt3i/ TiSrl8Jg3N2Dh1dx6ewpTMkb3G/SbYgF703AQPVJTJIqQukmhE1ruRjQqbaNOnnY P4APEQNESwMiybS3RZVNxizROrIT790tQXTyz0WnOqOCbPqCg7TE2FwqOMWYAM3f 2QCbXSm2Pk2qRBxe100K5hgYc7IHnO0jpFDmxrH03Ima4IV+2BMkrtoqUagFkw+W v7eGxg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v921m8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 14:51:53 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8f08560ea44so20363986d6.1 for ; Mon, 10 Aug 2026 07:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786373512; x=1786978312; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aDFyPqw10Ep82ElDuZGKcT1q4iRZM5kCL+pWZOCaT5o=; b=X61MWarLe/88Sy0k6qe/CQ2L65mKq00oEdzHscnA9MEy5dlvxq8EMSWYjl87dg1VDp EZHOMVplTV6XfhqVVJ/7mZ85KL77+19LRf5erkPrqfuj+qTNDy0Bs8IuyfITcapQ+R6W rknoRe1yOoCEYxR3eM/DQsrrXyT8dn4Q2MQ7t3nMyW8p+vtW2czDGdDl5yBXLizOFGav PXcjeqLPOn1Q6ynHNJuOmp5BiaJ5nxvEXOKaA8g7wPmF5O9rmhsY47CInoXwCD48yyoF d+tkC8u5cu+adSXzMQtoVgVVf9N7E1p2SsrHep3t/KcMNFS95RHr9Fqxz+y+RTii7Dxx F73A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786373512; x=1786978312; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aDFyPqw10Ep82ElDuZGKcT1q4iRZM5kCL+pWZOCaT5o=; b=GNKrANPN0iTYPOQD9LG6rfKCBvW70xkjjDPE3EFydSNQB4DxZgtsBH4qqpjq0ymfEV viHReVPCuV0wchZTMfvFEWzZW8b4jV/vGextu7BPjgnSM83Mf4vPO1JIfp0lxJcaO3FF rnvHkuvaFiWfLccj1vP5ruNK/pvPQtFUtAx1VobCl9edPRi9Cokq7qbs9erNWfFO3oll 4PSZB6bb0Lb3fIeI/c6X5/LdOS+nFdxik2q9UpEgycJpIUmdv38sGs/tSwyQe8D1SaLJ LC6VIryojjEFKdlREJ6n/aa8w+fSRW/XyvM95s+Cho9O0u3P4IiDKnclowwur3W48W/g 1FZQ== X-Forwarded-Encrypted: i=1; AHgh+Rrmh0M9vgiIGW/+lUW3Psmb0h7CvEaoXSd/l6Acn1sRyjmtXTPCQevFoCicw8/dVC2QZ+pPvBpmR0baIWw=@vger.kernel.org X-Gm-Message-State: AOJu0YzruHExYuTwx3WiIhvst9aBB9vhurR7JgIeOuwPQwc9e9pM0Msj v2UcsA06TcDfN5fWJqWW7OfZ3ZVAtw1TQU0b7+fbpl7T1Otw2auxJV9IcCqtOalWsVuX71hpkew FhMWqLfrGo8E1RrqYglDTxy/TGXnt60KF72x72Byyg/CRHYSO1vVhqcSLImKC9Muh9pfKWZ9e/O E= X-Gm-Gg: AR+sD13d4MFI15fBNt7Wl8Ko0psI7BePTZRj2rVtinxqs3Y5JbfdxF7LQpw9D/08DiV v7r+7BUZFGvKZ1zp6E9eVDG40PoHb8vUW1zM6A9IkU95iKlLMwVw8bLUQpsjIgyh19zrZjLXtHk Zh37OVYjJwojQ4Rg+OiaJ0ZY8Ylo1fqIOIefihYmZrW0tjmXlcBPhbVPPLW3k7hAVF+6IHufuix FOUS/9FAd4OqbZcuHkdrB4ZrTt8pw4C0CcipeRGFbS9Nq7RMnxihJkj8ES5n75SN0DeNYWJZOU9 XISgSnxWP4fy93NBK9L1mMvyo3zNFyfVnFfYnPwlMBsBxLHbecGBpGJbrWdx14DwKa6IjNsbZo0 HZ3Odh3FDEYHPAkIOd4aVppdXBZ4lWd1+MV/QuxWvlsuwB6s5vlKUxbrPbiJW66ovjL078vENN3 FpxC+MopPf5FzLVA== X-Received: by 2002:a05:622a:2b49:b0:527:6d4a:1970 with SMTP id d75a77b69052e-52d20a7bc1amr264405111cf.38.1786373512056; Mon, 10 Aug 2026 07:51:52 -0700 (PDT) X-Received: by 2002:a05:622a:2b49:b0:527:6d4a:1970 with SMTP id d75a77b69052e-52d20a7bc1amr264404441cf.38.1786373511644; Mon, 10 Aug 2026 07:51:51 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fddd6a796sm22489661fa.36.2026.08.10.07.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 07:51:50 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 17:51:46 +0300 Subject: [PATCH 1/4] drm/imx: ipuv3-plane: do not advertise separate alpha formats on DC planes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-imx53-fix-hdmi-v1-1-fff9b1b17f25@oss.qualcomm.com> References: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> In-Reply-To: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Greg Kroah-Hartman Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1545; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=r7E8ZVmX9Up1oISda84Old2tqIxw9+NGvdtLAuv610g=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqeeWDVybdK+bajyFR2U9qOC1Id33rHVYsMqrqR jGBG/sFn9yJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannlgwAKCRCLPIo+Aiko 1atqB/9Q8iKGctDO3jyDeWnHHP8qLR6BFfYSRKtvv7cIX14gCWNXxKcaDHsXJ1Eef1sHbQjrM8i rC3deEXGiUV1610r+8ro3YZjtsVFpED1MV73KjDSHp7skOMTFskWtM7zZDr42w+VZ0Ym62vcyQT 4qXT/xUsZE/M8EQixz8cx8/TqdOSl6/zmqjGSBjvPKu0Zv+I0/DDIvKgx6eamKtOp9/8Nx7N8Ml Mmisre1dwGHWqBxx3hF2Ub4X7iRhYUMTLFuQN8vMlaB6nPLiqNnVp99lotDQ0emD9PXrNau6OM2 ilucfD44wB6zE0lkddulgXdP2fC9GQWxudLWE+2Bv518op4D X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX7BKt0imB/bHu NDXYrygiTvc+jzJDYwWvBi3TO0cZiP+U+wFtob6VPQIxE3KrtDZ3YcXEvNm3nkX6t6MZ2qf9O0K 64vIWGonxorqHXJQ4LNEGzQedbJ+uXc= X-Proofpoint-ORIG-GUID: uFDIuLY3zERCDgiqLT7AJlkx63pGU1Hw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX31aKTXmyJIZU 9FhIEqm/M20xkC0KwtId1A4V1ya4Jfbc5pGTCBidAwlYRbxBC6FRkNtIfdz9ieoPmKAoT2wksqg wd1pWGTW/8oqyinpv74fJJxqsFAw1Dm7ii9ziJsxdte5gHogLfQ0BqUB8NJDgL7zpQ9II0XXifz QdMqZdbaVeQTXKpBk36LGyUkmAxiD75loRZJgOj8QTjUKAeDYUCJqQ0SQKQ8zVFMGgvw3UU+hHN caxbNedZReimg1j026dmHv67pZRZo2AzTrlPe65ld3CHquQDkjteLAldGsjqvpr9+htZBpD4fbn /P7hkF/rpOfS16KqckjlCcz9yOGKWuj1nhgc33CcHH+KnXCKfUj07KUIQrY2aoOPK4odIcR+2mn 58RFgq/iHTPNbmRNsm+SSCfv1ZqYfqLhgtP23FLceufG5sJFfjLZyz2mE1NNfy+mzqbktSLe40r 49nYNE5m+plj0FZ+3fQ== X-Authority-Analysis: v=2.4 cv=T5m8ifKQ c=1 sm=1 tr=0 ts=6a79e589 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=YURt6oeoqR9mFI1qLTQA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: uFDIuLY3zERCDgiqLT7AJlkx63pGU1Hw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100128 Separate alpha formats need a companion IDMAC channel, which only the graphics (DP) channels have. ipu_channel_alpha_channel() has no case for IPUV3_CHANNEL_MEM_DC_SYNC, so ipu_plane_get_resources() leaves alpha_ch at NULL for planes on the DC path. Yet ipu_plane_rgb_formats[], used for exactly those planes, still advertises the six *_A8 fourccs. Userspace picking one of them gets past ipu_plane_atomic_check(), which never looks at alpha_ch, and ipu_plane_atomic_update() then dereferences the NULL channel in ipu_cpmem_zero(). On i.MX53 this is reachable from any client scanning out on DI1. Drop the separate alpha formats from the RGB list. Fixes: f6b50ef14ea8 ("drm/imx: ipuv3-plane: add support for separate alpha = planes") Assisted-by: Claude:claude-opus-5 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c b/drivers/gpu/drm/imx/= ipuv3/ipuv3-plane.c index c7ec09e557c1..a0fd39eebbbc 100644 --- a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c @@ -96,12 +96,6 @@ static const uint32_t ipu_plane_rgb_formats[] =3D { DRM_FORMAT_BGRA8888, DRM_FORMAT_BGRX8888, DRM_FORMAT_RGB565, - DRM_FORMAT_RGB565_A8, - DRM_FORMAT_BGR565_A8, - DRM_FORMAT_RGB888_A8, - DRM_FORMAT_BGR888_A8, - DRM_FORMAT_RGBX8888_A8, - DRM_FORMAT_BGRX8888_A8, }; =20 static const uint64_t ipu_format_modifiers[] =3D { --=20 2.47.3 From nobody Tue Sep 29 08:26:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15F69414A11 for ; Mon, 10 Aug 2026 14:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373517; cv=none; b=InTCEbV3HXRABGaIlyLCZHX6Mp3GP11o6jyDLQgCKGvVo9Tbk4F6+L506QL9KLTG8HxD/d2pa8/XNksVapvHifQfltbi0uG1jP74/MN4G1UOFpJFU3UUt3lov6yn23aa5p7n7B3lpWNiI4zcnbh4hp7/3gIBOK89rptX858HP+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373517; c=relaxed/simple; bh=4QNydV7spsaEfA/iL4Q6QeiitR6lJ+BPeYG4Ij6Ga+0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UznGP0jy4bW4zVjHgRcAGpPDpW5HQd+rG6AvZiTFBwgJcNeLcULKr9G5z+PAI9575Wq1utWFgMr2MSvmqKa6epuYks0Oz+QXaZSC7WDp3cwCCIMHCdoii4MMlN8g39cxJMZB6WvAlrXI71Vk1SlWuDJ2SNzZw50BtjmTbrHKzTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RVQ1ypgp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LxvmfYiG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RVQ1ypgp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LxvmfYiG" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67ACjIjC1959795 for ; Mon, 10 Aug 2026 14:51:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gTJShaQ8ly4nCUgfAoU7CUotG9qknpirLcGSxiDk/hs=; b=RVQ1ypgp1BFX3scU OT8O+riaE4uKn+q9KFborw84tavN8QSApDN8x2eRpiIOghrkb2ntcXm+05j69IcK 8rJv7zuF20n5XQpIvlu7SXMHz+3Yz2OipjwZVCGD4QIC61fWtcDmY9hwwz0oX/El UsvHaZ0nV6GGhgGz92PMrUzyATC87tcqln32NwrwP4zt/gqHDJN4d3PgtzlO/9eY LkTExkVvxFBGHi8OB5hpxq4KbPb3hQI2Ixjny8yme8MU7U0Wpdhlw4HD3cei3O/g 8pUDUCm/XtnNqdQIwABalCd0Bsc543e4yy5OQuNmWYfK8gI0AA9GknCy39NYMjjr iQa4sA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy18xu46c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 14:51:54 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1d137a68so45125171cf.3 for ; Mon, 10 Aug 2026 07:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786373514; x=1786978314; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gTJShaQ8ly4nCUgfAoU7CUotG9qknpirLcGSxiDk/hs=; b=LxvmfYiGXtH/YVcIzq8srIFBgGqbHZ275dwL2wbgTST19Jztb5fbRO8OJrgxMVxKFx VILM1lnCQskxZCTzuA8pOdyh5jO7c15MNgDfTKYVB0zbYfuR+BTWMsCQ48vR+Yje6oZv Gg7vEBC/EVtbCcvMzn2xoP9wkkTnO2KZH4/Udjr+hLxHtJsd+zcvH19ZGJgFJtYi9c0r 8nEZOe8AKDDIMaqlE47O8Ju6qq7SJGcusnc3AmAMJWdxrpK9Ilz++z0irOv87ZBP7w+I 31+E2zEN+2sO8nMOveefd21s0qOIwYTMxPrEU6nDoyaHjNFAXOQZfCtCTR/q93O/JEx5 LtPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786373514; x=1786978314; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gTJShaQ8ly4nCUgfAoU7CUotG9qknpirLcGSxiDk/hs=; b=lREr4PWl4iMRNvMGW1b3OWmpQFXJFaRuqQJQIOuXz4PMBfFb39lFTyZjHGaYipCWen uTNzXHWb5EevSDmZE1gr+SZsp4QY8c3O+31IjWnli7YHmQbrFcnCYHn8MAaXixg012Vx sUz9zLsPPGyn2Th2iG/Cw5NQ9T4htTpkyEjYK/ABZoi6gurZTMACbqxx6xtGNP9XAqBO NbE0TATeFjFH8iOidgMeow4DtuhObVnBX+12d20fxWpY+hUOHWA0HBYcRDNyEZWKC9gJ M5TkWzyj3nDDgNhdhBo+mPMVgrHTkDhGZqlmpBz9orFTNl2n4gGLEVTyxnqTtEARpOiB CHVg== X-Forwarded-Encrypted: i=1; AHgh+RoZyG0PUTQ8URcEaPrZVdvjHy99dKOsYqdqZ0Fye9cu3/LlWJ9b7CIiUgBuyDGtLpXf6u1xYCJotEOm8gw=@vger.kernel.org X-Gm-Message-State: AOJu0YwX1hZFopOhBSElfPC53WBKRV6WRS70vcPlkX5zmPriCArjg2LA CsHsmrm1Z4iC9dzIc5DjsI+CDKe7LPFNvW/2asFkb1IwM49rnKaSWlCAQRrzozK9+3eOKkp6DUO N50UiDw/7rfgYeyaDK9NWxeweG4Xd9UBQFnBe9G3gxL8QUQ/+laEGKIRWcFR9bEQ93OmHjsvOss A= X-Gm-Gg: AR+sD11Yrm1pd9gGw73UthKNJ0TBfZwjY0evSTG+AJICqv5wHAqmQs/A5KO0ewkRUsk HTxc4EjBGKa+smYTm7C6hndTPEkDU3fuveOrISX+XIRe4VBVVfDcVwykZjfSYJmrAd5++TfhyPL y8cQt1h1cbLQDCeENgmL44dxCPWtfYGJ6if11Iz+F5ozW8AkilMzn+V4p01twje06tIQd9Wn94O ELUC0ulwxEcSMHnOT71cbgRGJp3Px2xS9LVzqO2VI/Pg5XOcrxBWsWJyJSfirktfURycRXd3VJD GgqZn8EiX32m3SvXiTOeM+m1vBzJMOqDLpWq+lMCXJ5CYH/IzN6qlEHFAfe98IoXWVnmhmhNsem a0XcFcdB+kgrxXpKxoTduxds55MkUJI/ncBmuPqzZI/Az6dSlQJlpi5jguKeqGFgl8zv5YjvHdj W3y/nhR73CWGqLQQ== X-Received: by 2002:a05:622a:58c4:b0:51c:1ff:2512 with SMTP id d75a77b69052e-52d20a50c50mr250088781cf.33.1786373514103; Mon, 10 Aug 2026 07:51:54 -0700 (PDT) X-Received: by 2002:a05:622a:58c4:b0:51c:1ff:2512 with SMTP id d75a77b69052e-52d20a50c50mr250088001cf.33.1786373513541; Mon, 10 Aug 2026 07:51:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fddd6a796sm22489661fa.36.2026.08.10.07.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 07:51:52 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 17:51:47 +0300 Subject: [PATCH 2/4] drm/imx: ipuv3-plane: add the pixel blend mode property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-imx53-fix-hdmi-v1-2-fff9b1b17f25@oss.qualcomm.com> References: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> In-Reply-To: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Greg Kroah-Hartman Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4122; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=4QNydV7spsaEfA/iL4Q6QeiitR6lJ+BPeYG4Ij6Ga+0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqeeWDajN8HOrxXriFLb5kPXKQed7DBCYPlTJEJ 6eIFR+YSEGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannlgwAKCRCLPIo+Aiko 1WDVCACsjxkK997hWtj+NXAjCYxxBz2W6w7JaFqnwMTnQ/6a7fuwFDQ/RDQt/KSf0OCi2oUXplT o0PnrMFfRFPX25OQ9sxayIMVGb6M6261clcl9AQbWCBRf6vXz36soQ85Ip9v0Gxct33+c7IQ3Bd T4QLf6tDW4GDzwdFAlizX/BwMnM1k/7zjHyFa2W/MdTkm4TNJbmRzRzeO+V0b3GtLikKxebyiQZ t9GIeGES4E+xy3S7VSDpw0F9/ZVmEKhBA8HRTYl3QBmR6hQEsVakMphFpuqW1Nl5SJd3CphA32T V94et7o/IiGBQPQYmnDf0RZBiz4tmOooj6n8LGfkK56WHvkn X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX44+sOTb1ztOS b7TVAOQKsy+98H0z20WlSbhUZ2HK9CyL6qsaQq5P8QYsbLKMcT53aTUI/drYn2FnNWSYHPIoNt6 N25MfChCLdQhePftyh/y/75qPeWIIpo= X-Proofpoint-ORIG-GUID: BB4iQZ26QLN72M_KMMzMdzKWjXu_10HZ X-Proofpoint-GUID: BB4iQZ26QLN72M_KMMzMdzKWjXu_10HZ X-Authority-Analysis: v=2.4 cv=bfZbluPB c=1 sm=1 tr=0 ts=6a79e58a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=5XQbaQfSCqgvYuQxrhgA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX2MwHTjWwf8cY WLPODEv6+17Z84s3jxX4jcGxAk5q22TJTVy7RjsZY84y3QSAX0JycEKFg2DMqiiv/P0kKgBCDwM 98wV3AhUuyHJrKJK84RaQkRALh/6gnTzwnMOaW/Xda8YUMQ6D7hviUqCUHc6pUaXfAWVQNlZkzC 4gblig1x8tog7AXd1wMgWNYDNLQ8fUpTc0IFTMavPNtA5hO5E1rjdl85o/zavrBQVFZVZvbduhn 0JoiOz1ZjET4btFcOjc9R60jbRlrzB58oPHkcFBjm4GyCjUElRNr/l0nzFKJnEEayz5bUyf4aos +j/rjEa1ruJgHdtweoZFdaRmmXCqczw4Q0DaUYBdlma7jVRGNcKGNx9eTX26vV0Yk9/R6J5Mlto dz8BalwC/FqQLYhoBIJFsRmMf6cS6Tf4p5s8unY1UIsTV0y+RFfv5xVLnUSJdNkUdIja9Mgemor RDjR7zWMsRW4zyfYfzQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100128 All three IPUv3 planes advertise formats with an alpha channel, but none of them ever created the "pixel blend mode" property, so userspace has no way to learn how that alpha is interpreted. drm_mode_config_validate() points this out once per plane at every boot: WARNING: drivers/gpu/drm/drm_mode_config.c:872 at drm_mode_config_validate [PLANE:35:plane-0] pixel format with alpha exposed but blend mode not set= up The DP blends the foreground over the background as fg * alpha + bg * (1 - alpha), i.e. it consumes coverage alpha and has no premultiplied mode. Planes that are not part of a DP flow have nothing to blend against and ignore alpha entirely. Create the property accordingly: PIXEL_NONE and COVERAGE for the DP planes, PIXEL_NONE alone for the rest, and honour the resulting blend mode when deciding between global and per-pixel alpha. __drm_atomic_helper_plane_reset() defaults pixel_blend_mode to PREMULTI unconditionally, so override it in the driver reset. Fixes: e6245fc78b65 ("imx-drm: ipuv3-plane: allow local alpha in ipu_plane_= mode_set()") Assisted-by: Claude:claude-opus-5 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 43 +++++++++++++++++++++++++++++= ---- 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c b/drivers/gpu/drm/imx/= ipuv3/ipuv3-plane.c index a0fd39eebbbc..bde5892264f4 100644 --- a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c @@ -291,8 +291,32 @@ void ipu_plane_disable_deferred(struct drm_plane *plan= e) } } =20 +static unsigned int ipu_plane_blend_modes(int dp_flow) +{ + if (dp_flow =3D=3D IPU_DP_FLOW_SYNC_BG || dp_flow =3D=3D IPU_DP_FLOW_SYNC= _FG) + return BIT(DRM_MODE_BLEND_PIXEL_NONE) | + BIT(DRM_MODE_BLEND_COVERAGE); + + return BIT(DRM_MODE_BLEND_PIXEL_NONE); +} + +static unsigned int ipu_plane_default_blend_mode(int dp_flow) +{ + if (dp_flow =3D=3D IPU_DP_FLOW_SYNC_BG || dp_flow =3D=3D IPU_DP_FLOW_SYNC= _FG) + return DRM_MODE_BLEND_COVERAGE; + + return DRM_MODE_BLEND_PIXEL_NONE; +} + +static bool ipu_plane_use_pixel_alpha(struct drm_plane_state *state) +{ + return state->fb->format->has_alpha && + state->pixel_blend_mode !=3D DRM_MODE_BLEND_PIXEL_NONE; +} + static void ipu_plane_state_reset(struct drm_plane *plane) { + struct ipu_plane *ipu_plane =3D to_ipu_plane(plane); struct ipu_plane_state *ipu_state; =20 if (plane->state) { @@ -304,8 +328,12 @@ static void ipu_plane_state_reset(struct drm_plane *pl= ane) =20 ipu_state =3D kzalloc_obj(*ipu_state); =20 - if (ipu_state) + if (ipu_state) { __drm_atomic_helper_plane_reset(plane, &ipu_state->base); + /* the helper defaults to premultiplied, which the DP lacks */ + ipu_state->base.pixel_blend_mode =3D + ipu_plane_default_blend_mode(ipu_plane->dp_flow); + } } =20 static struct drm_plane_state * @@ -593,8 +621,8 @@ static void ipu_plane_atomic_update(struct drm_plane *p= lane, case IPU_DP_FLOW_SYNC_BG: if (new_state->normalized_zpos =3D=3D 1) { ipu_dp_set_global_alpha(ipu_plane->dp, - !fb->format->has_alpha, 0xff, - true); + !ipu_plane_use_pixel_alpha(new_state), + 0xff, true); } else { ipu_dp_set_global_alpha(ipu_plane->dp, true, 0, true); } @@ -602,8 +630,8 @@ static void ipu_plane_atomic_update(struct drm_plane *p= lane, case IPU_DP_FLOW_SYNC_FG: if (new_state->normalized_zpos =3D=3D 1) { ipu_dp_set_global_alpha(ipu_plane->dp, - !fb->format->has_alpha, 0xff, - false); + !ipu_plane_use_pixel_alpha(new_state), + 0xff, false); } break; } @@ -930,6 +958,11 @@ struct ipu_plane *ipu_plane_init(struct drm_device *de= v, struct ipu_soc *ipu, if (ret) return ERR_PTR(ret); =20 + ret =3D drm_plane_create_blend_mode_property(&ipu_plane->base, + ipu_plane_blend_modes(dp)); + if (ret) + return ERR_PTR(ret); + ret =3D drm_plane_create_color_properties(&ipu_plane->base, BIT(DRM_COLOR_YCBCR_BT601) | BIT(DRM_COLOR_YCBCR_BT709), --=20 2.47.3 From nobody Tue Sep 29 08:26:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B89413D99 for ; Mon, 10 Aug 2026 14:51:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373519; cv=none; b=CxPSLBA1XHER2+WoX4XBYwtPdDjQU2+R6TDeUnrd1D2qWu9bIWxrKzbPPtWhRcBjYz1gsrLPWtp4TEO/UWe0hoEbCneJx9h8Py4QFKIpa3l8oiy4K3XnxpIfLI9loq38SOEfInGjaB5FdILktc+JZMHaeKQV9nksVu9Ab+6eEs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373519; c=relaxed/simple; bh=7lyUVLekb6zlqpOSAGMVtbpV+Z1fQct7CYaiDbqLUpc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V0tbDUtRu6om6LY1k+xKuysTLy7gtr+fRTkHcoDladSHV1XryjzrO7FbACPxV7RftBoSLTfq9nmCbcKYIJEw4MxhA49ZEvgFxOHGwv2XOLpWg3qnheb/C2th9cPdubCGdIyglQoQoIFPSqcaZ0jaNX0S45cPVtz2/xB2fW8E0CU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nbbvljsH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RWsYL8je; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nbbvljsH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RWsYL8je" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67ACj87O2206661 for ; Mon, 10 Aug 2026 14:51:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GqPA7hXcyMthrwG82uXYojOfmSg9zyync4goyZRZBhQ=; b=nbbvljsHFd8NaMv9 60Ymbv+2UWGawpU++nYS+S9WZnBDLS/7oV14ocm8KpwPO4TDMCc/qcOXyrrG9D5b 1miWShnWj0qWH3VQniFaVj5QfYFZN/VBH8XhOA/bnJ2b3wcObKT3Th6P8TMTTeYG 3TGxGNJg9Qkfv/eNqg3wuVaRtOyvCLaVYargiDmRDg5U6+voU7YRysiwmC/hlJLP jvhwUDdsz0JSYOaxY9LaeSt4Sp0sd13XbMujRmBMiLD+NDqVKcJKBhwB4/ynaRuw UPR/joELBkeS626z5LSjRN0yqMdJbd0o1ApYpNRlQ7vISG3RNP1xSK9hTxTJmgzN 5UthdA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy8v3t2hj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 14:51:56 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1d137a68so45125801cf.3 for ; Mon, 10 Aug 2026 07:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786373516; x=1786978316; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GqPA7hXcyMthrwG82uXYojOfmSg9zyync4goyZRZBhQ=; b=RWsYL8jeHko9RJZ8a3gFrq0feqF7YKy78htnrTi8QovLmYszSyAB+GbYhcJxSZGZP+ uGQ2oDREmDnMDYd2KFCFWEMiktEcT1p8ryzbS2ZmCG1BVdaXoXUj4ykreE7myTk378V9 o4exiYUIEx7moFixaZVn0GWXQf4wjO16jzWgnPuMTTOG/RiKr3fnYIyMKlJ/TXVcMnGO j5N7Mpk0dYmIgW7AdvSwtdAm0VTm66Yzu6zrYb+2LQN5+4nfwhK4YADPGjqI6xaKEGJX trNwbpZQjGu/pmBNV3IOm0GXKF/q6D2QRdM86A+g/sUO12bwZNdKj3a52e+ztRJtFNRd gxBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786373516; x=1786978316; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GqPA7hXcyMthrwG82uXYojOfmSg9zyync4goyZRZBhQ=; b=E0zQA3CtmUm01Uyn7PxN9m59ge7dL3XhLSrBKpL/YzkU8ApapM1M6h/jrr545yp6IN n5qoJfjHBkV/Skttx0GWX6H4Aw9mdQrgF4KUj9KF/vWq6URdxOS6Ws4EG2gDjHjPbzQ5 b3lp0qbuWW4xsbIMVoFF3qz6TkyPXJ/NQkYquIIhdRAZqOnUBPvGLcpKrIc2IGfO7PC8 VG9CkwbM+hiVE/YEH1mXqbinOZE0IAWLryk4ifXRBoEj8hXK50vPwswPUy/V4vopazjJ CZVt80QjzC58zJP2kH22Z8tsI9XNCmeGaDvoRmhM93OnNPPGEAjrz0SMzuT0kW9JO/oO jHdw== X-Forwarded-Encrypted: i=1; AHgh+Rrk5i4T3CwM0rjGsoxIr0WI0NwXlkPHTPToAHF9GJtdk9rDbXq97N3ggjtl66VZWz3s3GJi4YBR0tcT6fQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyCERdmjPS7NhSTwo5C0ZG9p6n61RdRxGcCj3r1kkuySbeujh+l kEp9mA4uR4rOaN63M9qyGBz55OHM13PQ6BxYfEPcBMuWOk6as72SgAihs8YV8TyX3+JyGmdgh09 e5oarGEaIi5ygUFriSJK5uO2mTGSxAihDJGnA9K8rbzV7WGMP8qrlcvMlIjvHpvNxVHeaYO4gYn U= X-Gm-Gg: AR+sD13L9plsq65+m/GvgGE20Ic0PZ8fsfWpl13Ge+Bi43S3nfzVhg406/zP6McpFU3 V/JC+flUIxpP9Ow2Fzip/Wy91iuTO4CFRo7VI0UZjx617n5Y8jDrEcztAhKpO8r0vROfOztfYcv dgkoiBQgCa85eOQVTzwB9Usm7J1dWDfF40FDGI/RawKxOGRCbHhXyqjJHes+zryYbkLtAHMmJIc 5fyIUjz5HsOSJH2CkD7U8jC3WXWDMHpwjkWGkrtCti8/JlTYqCvH3mmFSHjjB+AhiWOVn22D+h9 PXYUfbRkxCtYrGqod+/bXE3JIW6wTLprIOYIiWTe358nMgMRiOZvyEeOAW1BMw+7SXbN3m1iubl HkZUFzzbeCMuYMQP5GB8dKuokC4ytvatmZUeMCM0Mer8RrL4y6/Id4TnGD83u2f/172kYuevJya BphcPtFo5pRqQ9FQ== X-Received: by 2002:a05:622a:1f1a:b0:528:3142:d466 with SMTP id d75a77b69052e-52d20a920d3mr246432091cf.41.1786373515733; Mon, 10 Aug 2026 07:51:55 -0700 (PDT) X-Received: by 2002:a05:622a:1f1a:b0:528:3142:d466 with SMTP id d75a77b69052e-52d20a920d3mr246431491cf.41.1786373515360; Mon, 10 Aug 2026 07:51:55 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fddd6a796sm22489661fa.36.2026.08.10.07.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 07:51:53 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 17:51:48 +0300 Subject: [PATCH 3/4] drm/imx: imx-tve: probe DDC before claiming the connector is connected Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-imx53-fix-hdmi-v1-3-fff9b1b17f25@oss.qualcomm.com> References: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> In-Reply-To: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Greg Kroah-Hartman Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2249; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=7lyUVLekb6zlqpOSAGMVtbpV+Z1fQct7CYaiDbqLUpc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqeeWD9jjTXdp/CoYzaPsKhbyUM9+TRBy79PDfc XNO7eehHrCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannlgwAKCRCLPIo+Aiko 1WPOB/4hXVGf/LzwhsVzCfMkzOBW4qjN/Ris2XQ255uOOa/LZjSJgMWkQVFfI+0aN2uCQGqzWHH 4YQDal7J8s8zS30byb3gcc844q6FobFk+COFnofwcmZdJ28y2Vi0A2D1V86Frfq1s3KamI6jzdO R1Z6W0tynrioBOWxrcHGooKizE4yYiDsE/ExS+An0PoigjfeniNSsW0CGoYCRBbk5omAmriH06B V3CcHqMmV3ekT1hTga+WWyuEBPwqDuHrriCHNVUMq4jRHuObKlh7var03UcK2QaSbUpDjH43HPx I6eFwO/UtgiAybX2jJSdJpn4PJ10kpXUz2Utw0BgHGbFrFcd X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: PMpnKD9pdcfjJhqpuX4HeSZ-iYhpoxZN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX4xWIFKzoarst rEeu9pKyXG/VhoVRdnCOOFXCmdZYs/yKjHnHKifs9HS/I10nO0K6D8QTJO4QR1rWCJ9BIp96amQ 4LpS0Bb0HUT7Zh7XQ2svIGzATNpE0ec11XqyLNOxj7opvAu+epUYbPWMv0pHqWjfOTEoNIwOlOD nAQLHkdlqGVnkjbIezugCNTp9TE6IvKTA2MFJsgw5rOo/Qz8t78YUFPx+t2RbVfYR8gbXmYzGmr JJa1fgEgRzMLE+Z9TDx9P84rKu8usb0FjyVx/XSPV2c0ttgHEtyFSFktSt9k6mQlSoFwAe4NTGD Qxj8ReXyypFEQHfLrFdwbPW8P/jCGO2I+za4YYCQf/71bCaVtiI8YJCCxznGtT2nkkGt1+lCIdp uWf3V/mvJQGJ8QEkF8qGYlma7H/xSFyBlTkC7a5Lg4tEYCLwq28by+Fb983PMe/GDrlqCrtVSIB kTF1Bwyiowxgc4vXjgA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX8YekOeA7UBY+ DqF+io3eNgW9h2L0PbQgjWTgmPDcZYJMFYdJoTOZwerxb/ruCyYWYNloZPWe/zcT0oFVj+zf5jV OLUR/yhBGfMEe6MD2TS4nMkfVTTJ+w4= X-Proofpoint-GUID: PMpnKD9pdcfjJhqpuX4HeSZ-iYhpoxZN X-Authority-Analysis: v=2.4 cv=c+mbhx9l c=1 sm=1 tr=0 ts=6a79e58c cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=f-i-my0U1ELCb1aI9soA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100128 imx-tve provides no detect callback, so its connector is always reported as connected and always gets the drm_add_modes_noedid() fallback list, whether or not anything is attached to the VGA output. On an i.MX53 QSRB with the MCIMXHDMICARD fitted and nothing on VGA, the fbdev client therefore lights up both CRTCs: HDMI on DI0 at its preferred 1920x1080 (148.5 MHz) and the phantom VGA output on DI1 at the 1024x768 fallback (65 MHz). Both DIs are ultimately clocked from PLL4 - DI0 via di_pll4_podf, the TVE via tve_pred/tve_ext_sel - and every link propagates rate changes, so the TVE reprograms PLL4 underneath the already running DI0. DI0 stops generating valid timings, its IDMAC EOF interrupt (which ipuv3-crtc uses as the vblank source) never arrives, and every commit waits out its full 10 s: imx-drm display-subsystem: [drm] *ERROR* [CRTC:40:crtc-0] flip_done timed= out The TVE outputs have no hotplug detection, but a DDC response is decent evidence that a display is attached. The connector is already registered with its DDC adapter, so wire up drm_connector_helper_detect_from_ddc(). It reports the connector as disconnected when the DDC bus is there but nothing answers on it, and falls back to unknown only for boards that describe no ddc-i2c-bus at all, which keeps those working as before. Fixes: fcbc51e54d2a ("staging: drm/imx: Add support for Television Encoder = (TVEv2)") Assisted-by: Claude:claude-opus-5 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/imx-tve.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/imx/ipuv3/imx-tve.c b/drivers/gpu/drm/imx/ipuv= 3/imx-tve.c index e861b8b9d8fa..11ac69561eb8 100644 --- a/drivers/gpu/drm/imx/ipuv3/imx-tve.c +++ b/drivers/gpu/drm/imx/ipuv3/imx-tve.c @@ -322,6 +322,7 @@ static const struct drm_connector_funcs imx_tve_connect= or_funcs =3D { static const struct drm_connector_helper_funcs imx_tve_connector_helper_fu= ncs =3D { .get_modes =3D imx_tve_connector_get_modes, .mode_valid =3D imx_tve_connector_mode_valid, + .detect_ctx =3D drm_connector_helper_detect_from_ddc, }; =20 static const struct drm_encoder_helper_funcs imx_tve_encoder_helper_funcs = =3D { --=20 2.47.3 From nobody Tue Sep 29 08:26:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1513D42A7B0 for ; Mon, 10 Aug 2026 14:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373521; cv=none; b=uN9raxnmDVWzZoWzPdmPpF6ybSbnLbYUvqLKLupYlyudAFUThqFYmB6oVmk6tXKTp+Qr0yI3GOTIcEP78G1QirbXP5WtRsmk9ZNa6XlX1AofuT9Gz88aJBKxDdsZQDux7Lv4T6WFEqgeTTTsf+eyll1UroetWNLAMP7aYZx/8SA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786373521; c=relaxed/simple; bh=AJVGyN6ABsrumW1cS+QhP8uMJiKdvZ4L17DP94TV7oo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qXrJqN6WUks34fK3gQq2yIZq4sv3RrO9hPlO0kys1si2y84HdlThqsz490P+FAr37lOU+f3/eE7GH0yRKhVD1YS9d4M58Zq7zsbo7JAHnHIOrrr6B64xXnbRWR6Rpd1Y4+OV2lWr4ivp6Rg5jaGF2wjssPjnA1zLf0felOcw4X8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ImZqAgwN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QjVyFMM/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ImZqAgwN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QjVyFMM/" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67ACjFD51308962 for ; Mon, 10 Aug 2026 14:51:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kTqFwWAy8gxz1MmUqc7zci3CtGF3y+5TmAl/jfQIgWc=; b=ImZqAgwNjTbYRndF Lb892AhJfvCwZs3t0nPq9Lnk6u1N/mrzwPU1guaeZL3Fpgu5Avs6XoQvzJ8/Xknz 2eYfQB/asrZAoA1VF2GDa2CZvdPU7gTXRI17ExTK6+0rd4VtT+f3wRgCaGDbNyyR wcWhSfdml8kZJS88B2fAFxP+576pw8W4kJR3p77wNhf1rzv3uFDqTSuNW3xfUPKz Z+s/LARBMQEjcjfhoBX6n5cChK8yGCzyR45n9tO3CYXNwpl9xVrH4OAFLS17Bczx PRIo6om31kyIMEPOBcd+iEVrb9fnbJA79h+yGAfFjBHgNljf17Ys4WyLAbGzcNUG HFhsSw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fyccqs64c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 14:51:59 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e62e3459fso172558685a.0 for ; Mon, 10 Aug 2026 07:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786373518; x=1786978318; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kTqFwWAy8gxz1MmUqc7zci3CtGF3y+5TmAl/jfQIgWc=; b=QjVyFMM/nRQs65vtDOp7oojXvpTX30F7pd6eVbNgT+RMvIMQ+Ma2zQLrthGdL+F5G1 A1ve+1iroxz58YAd0P1Xg/FNQZlXbQXfWHEqSv+xEtJd0XueEbMwqFQVlPIxk19W64AN X49S5Rp/LwylqbFxo3UUgslkI/bIRbi120SMi6x6j52NDObnu+Cc9NoSCG/htBkKzNaA LXhAdy6QdevMW4lsqHicRCn6qbYs8cs//JouaqmRLz/BmRPC3Gb/casER/ITz2cxlNxU neYSZh+8coYafoItJ+30Nhds97VjHlLDdRb4eJUY1PxVFqBn+bm5ccH5tb6xNNunzvN0 QA1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786373518; x=1786978318; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kTqFwWAy8gxz1MmUqc7zci3CtGF3y+5TmAl/jfQIgWc=; b=OWugvIEtl06CD3uWCF0oee201wPvbcnhcsBF7WDImFxmjZJT8Y3UeP1hJHfGjGssuY hzinkkXW7krtyVCfSk1Sb/mY0aek9J8Ng1P8/U/iNAqzp7keSHiz3isZ96emWXt7Q0lo zVAjQLB5L5cKNhQA1m/YCbxhMY1Ylqw/wv1s2+F9FGeax4hE3re5Gek8oNcqtrIhfoSC dA+CVgufdaEKgY5DC1KFa5vV1EZFYPLy77YsAlFubRyLizRB5MkVRbya5Y4xTf0NBU+0 XK6MJc0NIs1zHzRuJdpFtb6Gj9O02SSe6/cfs4d5WyWBGAuPDfvgj5+eewEJ1QpFwD8W E73A== X-Forwarded-Encrypted: i=1; AHgh+Rp0hm5UVcxddDVCJ1q384ovntelYLBA4NJwmAlu7X3hG7nN4AY/vDSdMYeKZtH3F+epSaDH2QrmNaC0DgM=@vger.kernel.org X-Gm-Message-State: AOJu0YxTOcXa7s+iTxyPqI0ot+Sc5DehHLT8EkjFlD9xhwjh0+p517tu nkujZju7e9F13fJvCL+KJuLzTF7CxQS3SvSDiu7QMyf6IjUzakZdKxYStgit21Lm4b9WkJu9rdH AWHT5BvAP6m7irXZ90gXEg6ECKL3qFkgcEsKV5GUUaY+amwp+gEGpALN2l15SU8bViVFpEPP7K9 U= X-Gm-Gg: AR+sD13L/F1LbAWm8m9LqXXEu9a+khrDMT75bb100+40A0HH+xEnCXkXcVqw9r89AAX heY6wAl8hE4xsRb+UEE0RWZGp9Bb8SavkwmrquFkhX3Zaho9y2QHZAfTZ60i+ktqIvTBmBnsNEb TLmVfbHuaGwZmD4HnNB3+dfsdIvFkyy6bAbr4T3N+Y4on6QGNIIgrIY3W2rF3WZKoxS/bN6IeEO 4SJTa1a2wHF63YL4c5slVJGnOYbZL0/w7vVjagJZ0awC3LOgOQFq7E6mhdBdt5ZEIGbIu3r3QyE 8vCa15Z8AfeS8SNPY8aXo2+o69jkRCQyiG9wQCwHTwwu/Cucn+JJMu2MQK2sh0oIhfAgAzRz42Z TdhhY3eb8ygdKSnVz6tkxJT9huZnQ9VYZaJBlnbqUALgb4is1AoE5dKUv6FmZf1fqT71+iqDL3b YGu97OVHgO3sE+mQ== X-Received: by 2002:a05:622a:5806:b0:51b:f40b:2fb3 with SMTP id d75a77b69052e-52d4be1ab03mr27753871cf.9.1786373518196; Mon, 10 Aug 2026 07:51:58 -0700 (PDT) X-Received: by 2002:a05:622a:5806:b0:51b:f40b:2fb3 with SMTP id d75a77b69052e-52d4be1ab03mr27753211cf.9.1786373517789; Mon, 10 Aug 2026 07:51:57 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fddd6a796sm22489661fa.36.2026.08.10.07.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 07:51:56 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 10 Aug 2026 17:51:49 +0300 Subject: [PATCH 4/4] gpu: ipu-v3: di: report an unattainable pixel clock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260810-imx53-fix-hdmi-v1-4-fff9b1b17f25@oss.qualcomm.com> References: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> In-Reply-To: <20260810-imx53-fix-hdmi-v1-0-fff9b1b17f25@oss.qualcomm.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Greg Kroah-Hartman Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=AJVGyN6ABsrumW1cS+QhP8uMJiKdvZ4L17DP94TV7oo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqeeWDuniPTM7aG8qyd3SuSyxN4T3e+ikAJWC8I 5rfNOm136aJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCannlgwAKCRCLPIo+Aiko 1QRbCACEWOb6JNOqxsn82iOBHRW8q/uQaofmrqxQRemzL4NXdIOQdzJ1B+QcB6YfmOh0AiJElgX vQ3NGPnp880zSiX3vPetajSr8oI1v7lRGW3EPKl/xn5vkxvVKLCJt4La2VKHhy31UV7rTBrdDPO BIJ8J8ZvVSlq/oWe4b63AMCfm4j1u0Yr6fCCpQ+FS5QTux+jqVasFHOX36lLE4X7y1BegpsKpvH s4OIzyMHPrptSM28z5ClQ7ARSXTIzGoF5ZJJrFqpKEMDxYnQ2rExs2TYM5hDThkZFiGcnp08Lot Q+i/4s/xBGVsPHWKyPQ8RBh8BUUlEhcbv2CtQafRVRFbOazG X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: W387_ZVmlU_fWGfuuWfenAgl7Py-CQpb X-Proofpoint-ORIG-GUID: W387_ZVmlU_fWGfuuWfenAgl7Py-CQpb X-Authority-Analysis: v=2.4 cv=WNVPmHsR c=1 sm=1 tr=0 ts=6a79e58f cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=_XsFwZo-ejPuOgsMvnoA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX9ocCZwd1kNio JDNsUe45PMcDwgG1KnRAyjzLg2ggGDoFfVeT+w0ZmWOQWDLGGKZWCRXVGg7d1++sfVTQxWCPrmS 7RrcpHyYvlt2BW5TsWkN+MRK1lFXT3xEbMHWheLuF2xcJoyrhf+R2NZkrcWPvWJtE4vxCt+QfDv MPioOf/MN7jI8Q1mf1CrowB60zKTBh7rbIh36z7zCS3Jh96Q9k2lxWDX4lr21KDDZpD0XoXxlwv FeJh9m3N+ziMALApi/CGdwjqqOGm68p50wzise2251if1ilDJ0/NJ5YNRMgnBIHXSXuciUWkDkL pfM87KfFhEp7Loa7PlE433+MzuAh4kEnNwV+6oj5942UXVieaXCuxPUYnvpTybshZyCwkXB8sV7 lwHU4tqqgyaQ+aG2xzOYtP2HQweBEX4tUZsa2HwVRLNrq3djbMwhKD9ijRIdnubelmrvOYO6LUv JGR3qOuOQXX8NPs/Qtw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDEyOCBTYWx0ZWRfX8PICcP/5GRbm 7W6rbPZf3JcbYS9QQBcc/MSQfemvmN8PDESP/4rju1yUuciFSGJ84FP9nehMsKVWIA3e2yMjygQ QRU41RYdxXVGN3sOWpmpwTueQQ2wk+0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_03,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100128 When the DI cannot be programmed to the requested pixel clock the only symptom is a "flip_done timed out" ten seconds later, because the display never starts and the IDMAC EOF interrupt that ipuv3-crtc uses as its vblank source never arrives. Working out that the clock is at fault currently requires rebuilding with dynamic debug enabled. Print an error when the rate the DI ends up with differs from the requested one by more than 1%. The CLKMODE_SYNC case is skipped, as there the encoder programs the pixel clock after this runs. Assisted-by: Claude:claude-opus-5 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/ipu-v3/ipu-di.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c index 0a34e0ab4fe6..c971c37356f4 100644 --- a/drivers/gpu/ipu-v3/ipu-di.c +++ b/drivers/gpu/ipu-v3/ipu-di.c @@ -497,6 +497,22 @@ static void ipu_di_config_clock(struct ipu_di *di, clk_get_rate(di->clk_di), clk =3D=3D di->clk_di ? "DI" : "IPU", clk_get_rate(di->clk_di_pixel) / (clkgen0 >> 4)); + + /* + * With CLKMODE_SYNC the encoder programs the pixel clock after us, so + * there is nothing to check yet. Otherwise the rate is final, and a + * wrong one only shows up later as a "flip_done timed out". + */ + if (!(sig->clkflags & IPU_DI_CLKMODE_SYNC)) { + unsigned long rate =3D clk_get_rate(di->clk_di_pixel) / + (clkgen0 >> 4); + + if (abs((long)(rate - sig->mode.pixelclock)) > + sig->mode.pixelclock / 100) + dev_err(di->ipu->dev, + "DI%d: cannot generate %luHz pixel clock, got %luHz\n", + di->id, sig->mode.pixelclock, rate); + } } =20 /* --=20 2.47.3