From nobody Tue Sep 29 10:32:41 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE99357D10 for ; Sun, 9 Aug 2026 07:33:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786260794; cv=none; b=ieRrV0pfOHa0o5ThVsDhn9wZMlJA5Vw8ZDYjFxgqbxuEsLf7fkdrs2b2JN/NlNzMs1+Vd3FUvpWaSW7RrWnwwplojtyHomVq1Iv9DUCU4qSJ1VGYWnQPqzmcB8ZxTsfn/OPaJLlhuu9LLojk54QFS1Ym5yXINmCGwBEspfev/pY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786260794; c=relaxed/simple; bh=KjB2Lr+gNrW4tPidywgCIXL5Whe6bg7M2THcOPT44YY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AiPvfT+U3D5+leBKFQQI0vN1RW1Ks94ObEoFt6jiAAAjWcMzPwXFvkjRQ2eXbQMa6wEUzeh2rWZmR7lswGgHgufX6sIGVpyL2CDJrlCa18ssreQ2dQ9MTlaXdTlqWUFBfKfjrKpxWAk1A5w4D3AehtS+W1sIaLrI0M5EVCkYRDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SKwGycuY; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SKwGycuY" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cf452def93so26356475ad.1 for ; Sun, 09 Aug 2026 00:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786260793; x=1786865593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ENfS7OBp/4A8ZLshWeb8VKrRLZVv7nV81r8Jw7UB3zw=; b=SKwGycuYH2x5dibFopnT7XL5r9+OqAmBy/jwRWdl5pHaFYoOYEoEku6NVXQF15dUvp kmYafpC+zlgOgy1lTlpwoz1EArXmdZSgXSFTs/TYXfExeq5p/9UGN+PH1iYiOJopsZ95 +BbP/cH+XdYiwO2XIOVajPSvMAjnJUjqd+Uls57kLW5WA/N/nD2FfC/UxaGsVZ5DA8Xg cyJEJw+ekr0vuiC9HtdUdGK8YcTyaEq1n5Qwq+GEg1sSoCHccUJr4zPJy9P2Ve9SwRJ1 uOJt74YI92EfViyGCZ7eOFg4uX/x8FNaePCYvI3DLiLE9ZKDj48RRnRFiccgj8l8pvTJ jNlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786260793; x=1786865593; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ENfS7OBp/4A8ZLshWeb8VKrRLZVv7nV81r8Jw7UB3zw=; b=dgfxXZkHRQsqnOZ2YyZN5hVuBmtY/GhD2XGSYdckSEjrBgJSAiKJHZDZuuTiUKIOtM KS2RdROpuBlXw77kYPxxpBboE+0OD0p8vR3VGJnCbgZvVjVkCdwwtDlFjZLCuDV83H/N goE210wBtRBTPccbztgJnCqwJQIEB1mhAMAuix1IxtNZabe9fPlnzB1K+uvksrsxgKcD 2IsVUuAdO2MhqdXLyFaIQPVsNMtJzC2WwlIakoSSRzYP74leAiqMXJXo9SO7AUZSwLR5 Yx/TtX+1SG4Hm7KcDgm9j897ZjPmCYpj+uW6PW45orGN9Kgp+P7N698KTGaCnrhtBANA TUUA== X-Forwarded-Encrypted: i=1; AHgh+RpJBa22ckycGVt3W9oFdyrjLmrCr/ku00JnWR+DYDaMRUM81FqGifAK8K0nCLPcWFgYNpjn+bTdBSv2+ZU=@vger.kernel.org X-Gm-Message-State: AOJu0YxA6HxsDLfw4j/pvO2E0khJU2MNpvXU3RaV45gZDsAnxFw3a5q2 EvQBfnQfZ8BnbBkwCmJQDGFyE6YMzfVkMCAvCjWp9Xf/eAqcBMSsyIp0 X-Gm-Gg: AR+sD129+xJVXxStrLD7g3gRWxViPamQlX9MBfl54a+7nG2NYGRX2139BxN000f3Wv9 v4n1X0bY5ZSExqHq2d9aZkVVkaWRpszeoscGbHtVKz3nP8pupFNOV93nx6rU9hAn1pX6dkEp5M9 MAVTU5B7XBHkk40JtfhyUCNxdLK0u87h7znZ5xYb+YFlLgyvhAlCQ4zWg7rs+LMl5z+A7Rti5aP r8c0VNMfJiFV8BRp0IjlNHlx4ubsjoAG7fYXMODzn0KNi9pOM9NtJArIacAQggDKOLNeCaoVyjy zG7lZvrJaS24gX43VoRI4TJh8sanCt6QTtxjY9A5o5ED6URJWwqdfc7lYtSe4GokA3SToGDBB/5 DY4qX/Vv5uqbCbu7RzumJkuz4zcAlgMtMefXxiQPtPSyMVmLiWaYpACO/0+9vIZRYA8QjSar9iS ssf0MYVTChO1wcsBBxnXmdRHHAHC6CZiaSjf44gdvgIiKBraYPlwGRHA== X-Received: by 2002:a17:903:2383:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2d2b2de58dcmr124370505ad.7.1786260792633; Sun, 09 Aug 2026 00:33:12 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39085f5e33fsm10540532a91.14.2026.08.09.00.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 00:33:12 -0700 (PDT) From: Guangshuo Li To: Mika Westerberg , Andy Shevchenko , Andi Shyti , Ben Dooks , Dirk Brandewie , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] i2c: designware-pci: fix autosuspend cleanup during teardown Date: Sun, 9 Aug 2026 15:30:55 +0800 Message-ID: <20260809073055.2980971-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" i2c_dw_pci_probe() calls pm_runtime_use_autosuspend(), but i2c_dw_pci_remove() does not call the matching pm_runtime_dont_use_autosuspend() during teardown. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to the driver remove path. This issue was found by manual code inspection. Fixes: 18dbdda89f5c ("i2c-designware: Add runtime power management support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Acked-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-pcidrv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busse= s/i2c-designware-pcidrv.c index 468287922363..f1f4955f9a3f 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -300,6 +300,7 @@ static void i2c_dw_pci_remove(struct pci_dev *pdev) =20 i2c_dw_disable(dev); =20 + pm_runtime_dont_use_autosuspend(device); pm_runtime_forbid(device); pm_runtime_get_noresume(device); =20 --=20 2.43.0