From nobody Tue Sep 29 09:48:17 2026 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B39C8395ADB for ; Sun, 9 Aug 2026 15:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786287858; cv=none; b=NSK4HHdP7WcLzyUb5oQJHc6VRTG2DQqof7ZU0sgz40e08VFIRN8OpBz1CLN5xxD+J0i5oGF853FhNVtnPXw7HO1ZM3CCZBh4ROdbEMtoyDMT5GZ/HmVJUUsqZYdXz6ekll+bAsyxfB0WC7n2xQxrRQqXQ9gMU3BD1VbLnfYUNQA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786287858; c=relaxed/simple; bh=SQubqO9s+SFQ+/u9mawBkGl4SqexqjyU9fvp4DUIUc0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=O0STWHI+ApnLsyzz1L77WkDc3gUNpvpYBOEasLubM4xqJFLiWQiAvwC15Rxk7ZTX3CNEkwDl8Wx+dK8LJXjgCgljLNG8dUPGjjTnJVHWIFuq7FEbbnUBcSXANp7f3d07FrRhRBdJ0kXljg0BSpA1isMu2Nz1Msoru3fqwH+D2VA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=XYWhG7aN; arc=none smtp.client-ip=148.163.135.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="XYWhG7aN" Received: from pps.filterd (m0167068.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 679AZLek4192024 for ; Sun, 9 Aug 2026 11:04:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pps01; bh=e7MG7FcsFjAqmMigfCDPr1wrq2 eq1+bdZSypJg/Psa4=; b=XYWhG7aN/SESWN+WZysRoKQQUtJBoHIj+jchDKEW36 XTrhqYjHXq8yLMdRf9/KUcPtQbd57WD4wmLbwJbK41mPCKld+ZMvm0P45opEFTbP tT4cCac9ZK49ohYPTLGdHi6+8rxj9lIztUdloodqELl9CFS0eCOBtmtGpjiZRFR7 0P+LNRXmjFZcixjXvG0J1flsoPgMyUhIkelJTdGGV5M7SN5QpGoaMHcUXJXVhPVa zH7q83FP38ins9aMYqq+UooSBFVjYQSNhzTzSoSlwlzxQXIUlc30Pfx9IKqzSrIx Gk7ELv+uAphrihFZjcoHZe8WrOvY1jQmYVbbV5Fe603g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 4fwxqpd9cy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 09 Aug 2026 11:04:09 -0400 (EDT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c0408254aso37716261cf.0 for ; Sun, 09 Aug 2026 08:04:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786287849; x=1786892649; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=e7MG7FcsFjAqmMigfCDPr1wrq2eq1+bdZSypJg/Psa4=; b=KsCyff+a6xLC/wBW+8KZCxArcNsAIi+r5KwkA5j3QhEXZnvDMWDMwz8Pt8uqAlGzdb swd6WGVg34E+qGimVKRHurRi+qIXzSxL6aPOmfrabDLHmfjRQLB8/q/qZ6ipGZkGtXKt Ffa9iy6plKgP4NRrfN/JuUb3S9nPzsfkltq6nc4Dq1Ar3H1DYblS2bpONzvmThDZ2Pkc FgCUmC8vpC1ApLNND+AT2radg6tH+yGTVRLPScfFkrnjT9UWrBymGuJsPFqyuX07o7/Q C/1DS8t2lvsvhTfIwhUnM7+jvBuvztSV8rd3YGQbWygmvUSfY9zO7qEcAA0tN/ZDSsDz TY+w== X-Forwarded-Encrypted: i=1; AHgh+RozyZUdceNEN52x2RP5yuyu0zUfDLa+haXU2FsRVzlghrXiCGYbsbgKOM8bH1UoCrBamHrwo1m511IpgII=@vger.kernel.org X-Gm-Message-State: AOJu0Yym3ozP878xh36iX5tWmz+0xIjT8b0l7ypUln2FbdwMmsYCRaHe Dg9PS4GRwpkv9dUbkddtivc7W/LKYi9UYVt5UUU30GqiPLM86/Sz85alpvTNIzfJnMaZ38XjjsL o+ISDiLD4O/0dEaeF9z+zmH0q1rEWS66cxilFvBFUELsh6uYXLXqkUACAYNfG2g== X-Gm-Gg: AR+sD13vGHKBqYT1SD9DlkgjtZvaqFmdaOwZrQq+I4q/mS6nK0HS248SSFouoLMFRLI GccAi0gTedY8/4tX9m0ng6+Htz+NEYlxC5X8jOIP0V43kBdZ9Gcmtty4iAaZLnoZAj7NlgwVrQS KH7cfXwQEnVeCqLfksk2Iwkr8E0INym1aJzorrTrqp0Z2AFjIW8cnhaF1hx6xaYdFlej1kXdPgH wo/SDOubNlJwu1EX4yiMhNNo+NqSpSp4sy6JFZzZJJTzRd03V78ZLsKjLFNVF6Da7dHGJj4kcWU h/Yw5G9uV/M1ncLuJwmMcSVUlW4juHNHL57/CN1jz2kV+TEVdWzUc9ccV1Wqag/juiuwHEeNxEq lW5/ILL4= X-Received: by 2002:a05:622a:1341:b0:51c:d1c:10e2 with SMTP id d75a77b69052e-52d237a7091mr127493071cf.12.1786287848971; Sun, 09 Aug 2026 08:04:08 -0700 (PDT) X-Received: by 2002:a05:622a:1341:b0:51c:d1c:10e2 with SMTP id d75a77b69052e-52d237a7091mr127492151cf.12.1786287848537; Sun, 09 Aug 2026 08:04:08 -0700 (PDT) Received: from [127.0.1.1] ([77.137.73.83]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48002145966sm22739200f8f.5.2026.08.09.08.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 08:04:07 -0700 (PDT) From: Tal Zussman Date: Sun, 09 Aug 2026 11:04:01 -0400 Subject: [PATCH] libceph: remove the dead dirty path in ceph_put_page_vector() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260809-ceph-put-page-vector-v1-1-57ab2a08ec90@columbia.edu> X-B4-Tracking: v=1; b=H4sIAOCWeGoC/yWMQQ6DMAwEv4J8xlIKFFK+gjgkqVPMAaIEEBLK3 3Hb42h35oJEkSlBX1wQ6eDE6yLwKAtwk1k+hPwWhkpVrdLqhY7ChGHfMBgZD3LbGrF5amtrY3T nWxA1RPJ8/rLD+Oe021nO3xbkfAOwTU6zeAAAAA== X-Change-ID: 20260809-ceph-put-page-vector-458bb3aa87f6 To: Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786287846; l=2359; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=SQubqO9s+SFQ+/u9mawBkGl4SqexqjyU9fvp4DUIUc0=; b=mmUDFWJpkw7shOltkrqGihujdrIK1G2QxItb8lvwMc0+pv5sCid9hWVTOLN9NEqA/t8wKEDUZ s3eKjyGB1glB2DiEWkiyZVCJ2avLwRyWhsS6R3V/uVCtfvjy46lhE27 X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA5MDEzNCBTYWx0ZWRfXwvV0QcR2+5Br 8x+77IiHYISf5lRf+YiocQCXCrsn183vee302pgtkx3IWOnLe0Zy7MLXafIOzBwVprgfD/XgpTw 2DcdDPnsJqh7xPKkxb3jTjNosXHr8gaR4HUmsxzwBuf1FZTmpit23HIQpT2Xf4DkZpSW2KIU5r+ 8SNZBmA63IQ4zhcwFfNRAZv387ab7RqrtZWXdM0MhIgL3Th1SEkWMRcGmVKpcm8Hws/hunow1Ua ZNaoj5EKvD7ejjtffHDKVH1BTqEKdVYVGKX59aGCEO8bYcECIUEbxjM0HN1zasp+8z4PEd0Ls9F Ax/JsRgNDLrePHxHs1fVIFqkhx/ncJj0e/f4r86krJ/N7EogwAicjwoqzM6UxYdz3GOi+Avg7oq tSaQSTJzc1O8ml/EIT2pkYbf5JHKWQuh0kfnMBeGnkTOznuEFGWRbUFU63ZL0QYCIAWxeTUsVcu F8zUs05JyaEtyB50Ltg== X-Proofpoint-Spam-Info: AW1haW4tMjYwODA5MDEzNCBTYWx0ZWRfX/WhSvI+mN0m8 ptRjLqXbeLgJOoK/XWRFLLFwS1xUNC109DCW5019znIeRQbZx9c3I5EKGlNYVhdjqyl8VIHx872 yMUgDUxNHJq1dlGR1GYS4K0cGK3PBbQweRbtDC441ImH7E7ukDi4 X-Authority-Analysis: v=2.4 cv=ZYEt8MVA c=1 sm=1 tr=0 ts=6a7896e9 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=JbOfF7l4Ow3Rg3+6t581KQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=usPcmh10W0ubT8QP8_c3:22 a=8TkoBnpJMLDG3-7EqBQA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 3-eA_iMi16_Qdw-IQC6FfameGR8MJS4c X-Proofpoint-GUID: 3-eA_iMi16_Qdw-IQC6FfameGR8MJS4c X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11869 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=10 spamscore=0 malwarescore=0 impostorscore=10 suspectscore=0 clxscore=1015 adultscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=10 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608090134 The only caller of ceph_put_page_vector() passes dirty =3D false, so the branch is dead code. Remove it along with the parameter. This removes a call to the deprecated set_page_dirty_lock(). Signed-off-by: Tal Zussman --- fs/ceph/addr.c | 2 +- include/linux/ceph/libceph.h | 3 +-- net/ceph/pagevec.c | 7 ++----- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index e2da3ab9f808..83752f3688fa 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -257,7 +257,7 @@ static void finish_netfs_read(struct ceph_osd_request *= req) if (osd_data->type =3D=3D CEPH_OSD_DATA_TYPE_PAGES) { ceph_put_page_vector(osd_data->pages, calc_pages_for(osd_data->alignment, - osd_data->length), false); + osd_data->length)); } if (err > 0) { ceph_subvolume_metrics_record_io(fsc->mdsc, ceph_inode(inode), diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h index 63e0e2aa1ce9..3098306e6173 100644 --- a/include/linux/ceph/libceph.h +++ b/include/linux/ceph/libceph.h @@ -313,8 +313,7 @@ int ceph_wait_for_latest_osdmap(struct ceph_client *cli= ent, =20 /* pagevec.c */ extern void ceph_release_page_vector(struct page **pages, int num_pages); -extern void ceph_put_page_vector(struct page **pages, int num_pages, - bool dirty); +void ceph_put_page_vector(struct page **pages, int num_pages); extern struct page **ceph_alloc_page_vector(int num_pages, gfp_t flags); extern void ceph_copy_from_page_vector(struct page **pages, void *data, diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 858359873c4d..828b003aa2fc 100644 --- a/net/ceph/pagevec.c +++ b/net/ceph/pagevec.c @@ -10,15 +10,12 @@ =20 #include =20 -void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty) +void ceph_put_page_vector(struct page **pages, int num_pages) { int i; =20 - for (i =3D 0; i < num_pages; i++) { - if (dirty) - set_page_dirty_lock(pages[i]); + for (i =3D 0; i < num_pages; i++) put_page(pages[i]); - } kvfree(pages); } EXPORT_SYMBOL(ceph_put_page_vector); --- base-commit: 30c0913a2b44a66dc17283a88489b3f3e12f4327 change-id: 20260809-ceph-put-page-vector-458bb3aa87f6 Best regards, --=20 Tal Zussman