From nobody Tue Sep 29 10:32:46 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B093E340A57 for ; Sat, 8 Aug 2026 19:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786215939; cv=none; b=NXPUglZ07vgX/UGTomittfepRyTWOQpOOA0cW48Q/anWzxXwXRN1WM2Vx3si2Y7VUwPfMfnLJOcGhmy001bLSDClMPPH7sAStJ5WRJvCCH9ylvbpNToBF5l/KHfeT7QpM2CqSCbf7psgrPHzWBxHnRjcWMuAGx9rRpkRQGEoe+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786215939; c=relaxed/simple; bh=29yw0q8z7NtZRI32lw6jEXo+x9RKXuP/0Z3y3Whaq1U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=A3JDqgqchgjRUDyLtKSL5IUJSo7G58QtfCb3yR9KGrlzwY+YPKUTSCd4+8NJaorcDicsyI+rLpawaTy0+iob2Q+tHWd24X+F6u7fCTLfTCGkjSQYGR5gF1Zi2FsOys8QYEJB51LiqBxk9nCCzUZ8aWXhC+NK9cStCDzzhqYk22M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K6zorYar; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K6zorYar" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-495757ccbc1so6823805e9.2 for ; Sat, 08 Aug 2026 12:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786215936; x=1786820736; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=W9BnzvGcSpznT+V9trtve8n8y5TcNog+miG6h2jf2mU=; b=K6zorYarzPH+wBG2F3wxKjcsYk6x/sy4FWnW62Fgqi7zmUZMG6Iq1M3Q9KpyXyhYnB R+Lo4AzO0Xo3Y26UXHzqCG835nxwNa42fuNYZ8M7FQ4lgvbcYeSs3FfulR/OuckAIpMG npruwx2sLvme6qaISSnxqpqncAEA0Bxdibb3+k0yxIM8NGQC49c99baYKc4yykueYvGA 2UxTeNWw+TEnYpOwpJcjtaEdeXq/V+VuSq09LRJ3VY9byW/D0GFbB9qJqgsr+fvbZdqF y8BeT5zX6bDRNcR2UoqLFyfTndMPq2AiZ6KN//+ecfwr2GF6GTgsJFbQ1j5BX50Z7rCl 3HZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786215936; x=1786820736; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W9BnzvGcSpznT+V9trtve8n8y5TcNog+miG6h2jf2mU=; b=OISLl2OnE1A0IvQvskNoILva+gIov/FQGlqLexI8ZuyhtXRT/YBgw8aoP8/p7uK8j0 S33NywXRvUumZGGBdXgmlh4BrytG+FBDX1CTJ4qTA7LWh9wggOghOh1VQNwoFrXnxBZD wc7oySbEVtzA1IrMf9PuiNi/1cuwpmyarqax9PtHf3+MBAKzNnQsT8CP5BXyPmiVWg4o 9DvIMrcc95GQXgzA5Z9nG4CxE6MM2X60v4RaeyQEU3axtuViNhFGZoW/r6qn1qED3lwb 1ma7ND/3waR8ag7RUoKalnvz6+llqOz8cMEjRq9hZD0wviov93cSSH3gw6zoGtSw4O+k pakw== X-Forwarded-Encrypted: i=1; AHgh+Rqg2ziwwINpkAZZLmps1lTPdQpuuH1ElHUAMqqegK5UBzg20gHPYRTb/3qH/0rpe+VpreUMzhJXYSiUNxc=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ0vNRe6W2gw74iVwlx4MLZMVVVTZcvINnB1nYsQBShajrpcZT znYcEBgXCRuwjFfuxQf6icsUGHd9Ba8KMvdt2TUi44hU5qmDyArMl2DL X-Gm-Gg: AR+sD109lt1FsFJEM7K3HuIjHcYSiCLjyFis93IGWAcy38SqMwGo+KAAeB8id0u97tx iXnExtbw88mB5P7RZdgKQytOP783sMWeEDG9I+t+kApgHI8MjdsecWfNoO3xDSzh/tDEaYouxU9 3DWXuYsg2bOgzVI7zpuybNJItzvRpBzmDO7Vi6AQ9Rc0hZJiZkh95UWDvNN8WbHN5hwO6jfsJne 9xEwDoS650PUShXLcn6ZNyQOCvvQY7ww2VI0JZxfZ0odYlZobCkYdBaNMBt9oZ165dMCxkl1x/U 43hMHubip5us2NqcjPWY2KhVH4YA0mJYW5MDZwG/CLdN123I4MdAMoEmy+Psjfr+B582CbpHOxc OQUAvesXO9VDv2xPGc1/t+AtJ/CK+FXRnyQGSA6VpG8FCNqLgxOhpVrygAWsHxF9A7/h9k0F50p +dHA7DelR8THgG9RFdIBHmSWA646oDE2x8D/v8N4/BiGz29YqTZtVfoI4RvWXkoE3n0n+CIJZTj dM0t4TwhlHBdhNJPAU/SLMg5+HuHl5q8X9awDjGtnL4+r4Y7FzboP2QekpZzl1DlUAZkx4FDEXX 3Du3P8T5O4k6FI7UpIeZQ/P9p1Cmbf0dYqA= X-Received: by 2002:a05:600c:3b0a:b0:493:c47f:3c55 with SMTP id 5b1f17b1804b1-4994e71d7b0mr393658775e9.5.1786215935751; Sat, 08 Aug 2026 12:05:35 -0700 (PDT) Received: from MacBook-Pro-von-Karl.localdomain (dynamic-077-007-004-134.77.7.pool.telefonica.de. [77.7.4.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995e9e702dsm164974455e9.3.2026.08.08.12.05.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 08 Aug 2026 12:05:35 -0700 (PDT) From: Karl Mehltretter To: Jiri Kosina Cc: Karl Mehltretter , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: haptic: don't write an uninitialized value to unhandled usages Date: Sat, 8 Aug 2026 21:04:17 +0200 Message-Id: <20260808190417.87415-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fill_effect_buf() initializes value only for the four haptic usages handled by its switch, but writes it to field->value[] for every usage. An unhandled usage can therefore receive either an uninitialized value or one left over from the previous usage. hid_output_report() then serializes that value into the effect's report buffer. Skip unhandled usages instead. This also matches switch_mode(), which only updates fields it recognizes. Found with Clang's -Wconditional-uninitialized. Fixes: 344ff3584957 ("HID: haptic: initialize haptic device") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- drivers/hid/hid-haptic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-haptic.c b/drivers/hid/hid-haptic.c index deadab28cdbef..66d90f0f78a3b 100644 --- a/drivers/hid/hid-haptic.c +++ b/drivers/hid/hid-haptic.c @@ -187,7 +187,7 @@ static void fill_effect_buf(struct hid_haptic_device *h= aptic, value =3D waveform_ordinal; break; default: - break; + continue; } =20 field->value[j] =3D value; --=20 2.53.0