From nobody Tue Sep 29 10:33:02 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6607731328E for ; Sat, 8 Aug 2026 15:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786202554; cv=none; b=cZQGaqARPsk2SAmQ9xT6wvWcg4WS7oJXnYB4KrupXTW3dQA8QHLqTBo/zPUOOPaw/qL0RBOCPPMsiu/hkWbqotkIe6a2hdPDASEKl9OnRTZiaTbwDLaIfaxHEt9t7avTAaKuAHTEjow9YLnGe76fIbiKMvDnGiTsRdDNGrRxP/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786202554; c=relaxed/simple; bh=pUVoEvqTkBts2j5M0WNdQpyr1pnzEIN9t25AtarzmiI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RyRpCrCv2i1ZOdKR2vrqZbK4bWUJYJ0p1jgpe2AQm3sD8D0SGifxq4qxXtOy2VvlmNxu7f2fj6l47mYXU2cX+zh+7goErhM2m6rxhxwhuH5+3IKD/eAyZsbppNEjt+yvFgXRe9+HT1amW4kvtsTNni0QmOz3YmcQ5nfj5czZYg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GcDCOcWC; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GcDCOcWC" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cacb8416a1so5093505ad.1 for ; Sat, 08 Aug 2026 08:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786202551; x=1786807351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bn5LTk57U4QWCUdbGncuYOxjBXWL7RxJ7HrZaPl5EUU=; b=GcDCOcWCJt1t3arAoAbWBmnwSy7oPG4AGkSJveTC8F3QP4ZRku5WgEJOEHqeJABkrj 6501iqlJcYPOJIfXHZC//6yJCD2VJYzpY7rVp3mzzL3hD/aoDmPUkmLUXUinS5fYtPzU L2KoEdufBCN8vMdQJGtPExrDMYQzDzevQQjL5V+3m4oRroMQ50qWnyeabOo3JAbeUOlM bEm9pYZx+FN8e4xGMHYfLiZh717NZQE+dEukBmGqtkj6bk3PdhZ0KADbfYn5cpBCT+jY +Qnyd9m/b4rkteA2W7ni9swcvqNKBJ/PXT7SpYa6Wejg7S/L7KMOAD/TW4KS+WviDyBw 1fbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786202551; x=1786807351; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bn5LTk57U4QWCUdbGncuYOxjBXWL7RxJ7HrZaPl5EUU=; b=CFOcN+gXG94TAQBtbWK6SOTXSiELJFIdz0w31P4eUNRRntYkoBFOavmzc9pdFtkNI3 /MFTHZluC/UJ/1t48VZXsaud2/TUoaI06UDVMzZfiR5hMxREgGS7WWBeLZZhGVuiNEwp 5sDXk9JW3SlUV5Vr575Se5/TdIbXRVC/E+PFgqvIkTSqvUlBccYstQPMWmhivUYcZxXt 5oW0uO4sj5a40HQNkxrUnrnWH6L+n3gVmfqWG5OoE46xVUHa4dtRv/0CvueYJG1Adi3x MMjB7CmqLydArGPmxO46trj1a65qSsAnywYZBc1nl4dmU5okIiqTKI4Q1KYVLTNF5WPx 0oJg== X-Forwarded-Encrypted: i=1; AHgh+RoF3XQGdldeq6XcTHuni9yLWzLnnr3Nq/MCoJdM7gz3KF6LTfZODpb4uMyQTQILLBbQraLTq3C72KJ0mWY=@vger.kernel.org X-Gm-Message-State: AOJu0YyS+PlXNITDASuKRwqJ2+ofCqlYUA4S68FPT4uM6uR024rriKZp 7w4a02/1hT1bHzpYdP2mYddkNy4/7mjOVDs+xKcycrJcbRwQ4s+hfhCv X-Gm-Gg: AR+sD11WK4uHm6TheXuk9AFsyokfEb0AJdHNJsy2o7oO1c8hso5j8O4OUDF8RTO95Ix 1mzEFwfCVl9nEhYNCzvVF2N9DWHdqCqNcV2Y7q5oh1xxKVQ0ZmmbxHLmbCrIONvsNGbQq3iiokK 3fvghNg3dxgwBXrQBthCnVqkxzDJ804OkrxaSvO+RBBbxXSluyRhh983BlcijngexcDTpiLEInS cZtuomPyUQAAtzV/nEXJ/n27DHeFTvtd73b0hD+rgkx9BFWzHh7HRyCKLkhamvXTaknJmIMW+aC BGRyuig/aJ/aKpA2G8CWV7Ig5W7Ow8leZt9I7jn0px/18Jdf+6o3g0M5lWfr/vZmG68qPsIqvBG m0jdYrT/lTreq7nKfczl5KsS4RD6eN4xRt3jTIak8M8tkNny2aO5hzvnqY4Uc5lZCnNO1ZZkiLY qbHDNF42Ocfay31+XbqTXkFM0Y1ytXNwaC6KVfO6xmXLlT/V+XDw== X-Received: by 2002:a17:902:ef02:b0:2bf:7b62:a038 with SMTP id d9443c01a7336-2d2a898f9abmr104950805ad.9.1786202550819; Sat, 08 Aug 2026 08:22:30 -0700 (PDT) Received: from lgs.. ([101.36.111.22]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d16b446bd3sm19442305ad.61.2026.08.08.08.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 08:22:30 -0700 (PDT) From: Guangshuo Li To: Elie Morisse , Shyam Sundar S K , Andi Shyti , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] i2c: amd-mp2: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 23:22:20 +0800 Message-ID: <20260808152220.2938557-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" amd_mp2_pci_probe() calls pm_runtime_use_autosuspend(), but amd_mp2_pci_remove() does not call the matching pm_runtime_dont_use_autosuspend() during teardown. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to the driver remove path. This issue was found by manual code inspection. Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/i2c/busses/i2c-amd-mp2-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-amd-mp2-pci.c b/drivers/i2c/busses/i2c-= amd-mp2-pci.c index 5b41d18b62d3..2b7f7b3cddc5 100644 --- a/drivers/i2c/busses/i2c-amd-mp2-pci.c +++ b/drivers/i2c/busses/i2c-amd-mp2-pci.c @@ -371,6 +371,7 @@ static void amd_mp2_pci_remove(struct pci_dev *pci_dev) { struct amd_mp2_dev *privdata =3D pci_get_drvdata(pci_dev); =20 + pm_runtime_dont_use_autosuspend(&pci_dev->dev); pm_runtime_forbid(&pci_dev->dev); pm_runtime_get_noresume(&pci_dev->dev); =20 --=20 2.43.0