From nobody Tue Sep 29 10:33:02 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4466E2D12ED for ; Sat, 8 Aug 2026 15:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786202273; cv=none; b=Rga4lhjMkXoBlrpi98sOdd3WvwxpK5bqp2KLoWa7x4VNBaL5m3Phle27thKz7xs3dFHPtVypn7MXBddI80WSCI1OWU/etwtjRFrKWqDrP4vPCPtNvdDvrFSUkApOHE0hzxyOGfCIv2KctVW4xaIBcwUp3uEUaO4Mfb/94ccIWQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786202273; c=relaxed/simple; bh=xssF2DxPlOYLL/bp5ut8oCHqoOExGf4sNpWxtIRWBpc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gD7IfGnJdIuQ5mwmtpezvn6z+YvpbitkVM3wXLwzoEOXa9iVihYUx1PEWCdvUUPf2SwL/4udnV4rEiWI33ZHl022BIOkKzbZybK2S6qzoZZqrDIz24/kdS2WHIeG7LlRJ68CJ6rtePKseI92JxerMuSPAFMLgcz1DNJO3GeVF6Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JQp3flAY; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JQp3flAY" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84862b0d5aeso489932b3a.2 for ; Sat, 08 Aug 2026 08:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786202271; x=1786807071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=I4mXlEdYH/oZx/ClkXFbjfrGF0NBgv0NP1SaOJhxp9k=; b=JQp3flAY6Nj0jlUNocaSczF3vhorJOuxIN+ncj1B3EHuSz5O6Gqkl1rLXrLF30lcxv yh03NgXAtbxxA5enBvqTg2Ff7DaU2UCBncCGdt4mkx/GkyydbdT7/lmfNNwe0W2UUsbW 7y7IAvoZuMwB3PezpYSbVG0uEciwHEbMoEraXXUjWCRyBSAudeH8DZ/Yzhn6oUO4z2Sh isZGlzaJlLlwcNwMwlf2BSpBUJgd7rT7RZqH2DC9zobVfgWbEiPbXoOZ1igjSvAyZn1C 2K9R73wVsvPmbU7te7XizLGWJRviPJS0bu5kLiUDMMqcWfQeimKdOl7QJ1NrwlGeczVs ly6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786202271; x=1786807071; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I4mXlEdYH/oZx/ClkXFbjfrGF0NBgv0NP1SaOJhxp9k=; b=DJFNEIF3CDObhcI9m7sZOLDMoj6nkYFtDj8LTHUkK/79H8Z9tmOq9SuDbG9JKEUF8t U71suT6EKthBYUP0VXJwKMrgMaETRlEbC/7Ju1OKqIqFGxooW3vASpXJPjRyfpk8l8Jr b7p/zIt+GqUw6sp8/pzQLFlHL1aFlRKKSUrB2+/uH79m8Jw+HY+ATlR6CPf0D+ZiwWvz miLocNY7Et7R9wTuw8YoHYBWw5HSprtEC8qYr5smsWiYPJ3/DyOhN0vAQNziXjSTt9wP M2/lQlnMZ76a1AG2jOEjEyvzoRxk7W91XZa3WEFhgrpnVy+FhsrU1akDEfS5/cms7et4 7idQ== X-Forwarded-Encrypted: i=1; AHgh+Rqg1TQwfdRkt18voGc2p7RLMeGZXuyVxvaJUIwAfN0+8/xzFPXLUL/YhDLxTnrzfdJNmR/QZSDEY59mpmI=@vger.kernel.org X-Gm-Message-State: AOJu0YwRHHpplDPGOFhgXloyX83+rDkNm6P0VwD+uj9VtLGmMvu+8LjM jFRt55JluYLfqLBskzpxwkjSt8u7w87Wnpu7GxgqVrMfObmutSvuadHN X-Gm-Gg: AR+sD10oIJeZAcso4car1M5/dly1XnQHHumHAHMda88bebIOjXZXmpnjmcmd67L0ntV 2MTobwkRF6gQg8fyGWLD/8YtdXi8nRl+4w+YDUgk5GWB8tvViFlz7T2QAMRTYU+8Gnl97ai1Sw8 W3qbBh3UmeGaZkshnVTk+KIRNSpMGjilhBtNaeO3qoUt7Rh/oKNIBxp6UA3+eYAqI3IQCDexnCK epkFeKGKde3l3/FutWt1sO0IG26+NbJgMjQc0+K0qcXFaWALYUm5emIdDo6DUb4q0KChZ13OEXo q9YxNz5Msjidv/XJ0gNR1i9jhs/uDqwn66qjefx3b56Mi1BuM857QyxMneJ/dQ6dySheUuctnSV h//FxRNk/Xh5/8CVQUdfbK7KQY1VfSyL0mdS+MBaLX+YTV/mi/X3F4XMol8KsetQiAhkT88HqOd MUNSp3alEfWIQQ/CacOjZoimuSLLNinFmHrmReyLCT6enx3jC2u0jK2y7FXztWqA== X-Received: by 2002:a05:6a00:99c:b0:847:80f5:c616 with SMTP id d2e1a72fcca58-84f2dfc89b0mr34455767b3a.10.1786202271396; Sat, 08 Aug 2026 08:17:51 -0700 (PDT) Received: from lgs.. ([152.32.188.52]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe8f35b0c3sm1953618a12.15.2026.08.08.08.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 08:17:50 -0700 (PDT) From: Guangshuo Li To: Even Xu , Xinpeng Sun , Jiri Kosina , Benjamin Tissoires , Sakari Ailus , "Danny D." , Guangshuo Li , Abhishek Tamboli , Mark Pearson , Srinivas Pandruvada , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] HID: intel-thc-hid: intel-quickspi: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 23:17:36 +0800 Message-ID: <20260808151736.2934050-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" quickspi_probe() calls pm_runtime_use_autosuspend(), but quickspi_remove() does not call the matching pm_runtime_dont_use_autosuspend() during teardown. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to the driver remove path. This issue was found by manual code inspection. Fixes: 6912aaf3fd24 ("HID: intel-thc-hid: intel-quickspi: Add PM implementa= tion") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Even Xu --- drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/driv= ers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c index 4ae2e1718b30..3c87519aca84 100644 --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c @@ -713,6 +713,7 @@ static void quickspi_remove(struct pci_dev *pdev) quickspi_hid_remove(qsdev); quickspi_dma_deinit(qsdev); =20 + pm_runtime_dont_use_autosuspend(qsdev->dev); pm_runtime_get_noresume(qsdev->dev); =20 quickspi_dev_deinit(qsdev); --=20 2.43.0