From nobody Tue Sep 29 10:33:02 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6273290D2 for ; Sat, 8 Aug 2026 15:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786201208; cv=none; b=RZWwWcgu+iV1Ie8BY39y5Qvy6ks6E6rCAA0luVT23ZPpbHe1sDUKYCZRtlOIGHM7ifWiy4YXUn1StYGPJeSlwrnGIpbszzJ340uStITSJKm8Hz916HEeqWhFJz5hoFOtl8BhP4quAVoChbcp0Rk9XRxERcD8d17ZHyCwC+KO+qs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786201208; c=relaxed/simple; bh=GfW2YEBWG6q+0lA0pPenck81sZPjv90TsJei2jwNBls=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FaCb1wNaMRbBB464jk2mXm6HKORPhN24ffxmJ3BTP1oYgrpVeDacBRXrC0BqZivXhzzqxhJlL8M3Z/oq71PqMkYnrPqQspGT0yBb2SQVpkiqg7gG6TH6q8hDnnnM029rHKDFhCUkPvbdNkkvCs/uV/TZSKH+k1epfx4WoO8CiHA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jAFbbBrr; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jAFbbBrr" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38e041ea211so512886a91.0 for ; Sat, 08 Aug 2026 08:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786201205; x=1786806005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=oOONO+kZ83xynxRyUTPEoSdvpl1Q3Luqgq4ZyfoVH8o=; b=jAFbbBrrja3AI2d3/h4bTqZuDrqhui73COWcWo83t7STmUinCVT1pq6QKlsoBDCq0e CZV9DdSilcSi+fAAWxZo+bFn9lvhTbsvJqw3GA83wyoBPvhAaGhASgpNKpjf9Djrf6s5 wEA3QcvXj4/e/glGutvvTPUaHIv7yciB7GjyFdTX3x/A6Q1YbIhaQLhfRGur8ilZFp4E 8w1y5HlPItpIJWt23yYDTwH+LBMlPDyGp1A2bsXFO78wagnpJQmIAkSVaGTKiWv7t3S8 gKiPH4pyDolzsREzb8xHvrJODvyD/zwoYbtNyZ20+dCf+sh6O/7XLPUZWXUVvnFfMcYJ e8Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786201205; x=1786806005; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oOONO+kZ83xynxRyUTPEoSdvpl1Q3Luqgq4ZyfoVH8o=; b=Hz1pMUmUVIH1aVR+mEBdYctRxOToYPDgtvqp9oYnESTGYQwP3X+XbSHkhz8nzXQjAC NQDjNIvaymrYAruPDDD+TI4HauekMnUetg8dDRkaVk9iL0HAYSp6RsqPo/kcbdKQrP34 /qcA7IfCRtkC7vF5QkKLZw/wVKe9rDUa5y9Ci4DkVxpko4rY62aoIkLb2wGMeEFTJwGw eu8k3fFZPKZQ/ydpzW+9S8+4uXBdm+r3SJkRUXfr3xgvG8ApSB4WVnGQ50M4O1lulYME lctzyDYVmN5MkByZ7aSDU/YfSksOnCrspzc940R59Begv9DGgrkf5nvmlDee9lSyAirw HzbQ== X-Forwarded-Encrypted: i=1; AHgh+RrdT2SGGUYOUi95jefdMMJDLyhynwdFWYI1dG1ruWPEZ6GdA6e/WZZlKDvX1oR29Z+LqNknqh7OpObQWTI=@vger.kernel.org X-Gm-Message-State: AOJu0YwqlNCLUb5s1/VynXNi3IqvkWJqG+7+fTB10W/+K2DEK5UxGBIU BsayDeVDPp1BuBJAGkNNdnbhf51UhAfg7fTqPLYRb6TPcS6Kch5Ln9b6 X-Gm-Gg: AR+sD13VelzWQW6f2ldJI7iRtNnY7CFIec6q5j97J13bFH3urpgg3IqoxwwnpWBkOUi B5j4fCLKrjrbAQBc5rg/gq/9iJm3yBeVno79OoyFyFVzyftueNpDlLZ+TPQSu53XPLwlRsnVPLa PPi9OvZF4Rzaz9UJ/r73txbngYvgCh1h88czlnftdrJHFFJDx+HzlFUWadAmLtx2kZiFzdlUXLn 0sREfY4SKsYLHF8mWmVQRTr0GwHuGNvIQVSa1n8KVEM4jqunO2df/WOL1h9yLQ4Wjdj/bcgJ3YP X39XKzc3d5fLAn3sUfmDdGAs2bSjqFbuP33df+i2B7soMmCr8DEY2z/Ii6N76gdNk4fRhUaHmSV HVqwDciwfsM5L7R7FKUA2Xmrr6qW9Rg6QmuhrgHKIJwWWJvut//4FlUT+WGGGNT44SiCx7TZI48 PZOnozewo8cqTgsVEwcTucywSpWwce0NT7WjW18kD4LBw= X-Received: by 2002:a17:90b:528c:b0:37f:bfd6:8b40 with SMTP id 98e67ed59e1d1-3903c5993cemr32295133a91.5.1786201204670; Sat, 08 Aug 2026 08:00:04 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fc6f13dsm6447642a91.1.2026.08.08.08.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 08:00:04 -0700 (PDT) From: Guangshuo Li To: Even Xu , Xinpeng Sun , Jiri Kosina , Benjamin Tissoires , Sakari Ailus , Guangshuo Li , Mark Pearson , Srinivas Pandruvada , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] HID: intel-thc-hid: intel-quicki2c: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 22:57:48 +0800 Message-ID: <20260808145748.2926096-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" quicki2c_probe() calls pm_runtime_use_autosuspend(), but quicki2c_remove() does not call the matching pm_runtime_dont_use_autosuspend() during teardown. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to the driver remove path. This issue was found by manual code inspection. Fixes: 5f420e8215c6 ("HID: intel-thc-hid: intel-quicki2c: Add PM implementa= tion") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Even Xu --- drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c b/driv= ers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c index 46d3e9a01999..4126c2408d98 100644 --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c @@ -774,6 +774,7 @@ static void quicki2c_remove(struct pci_dev *pdev) quicki2c_hid_remove(qcdev); quicki2c_dma_deinit(qcdev); =20 + pm_runtime_dont_use_autosuspend(qcdev->dev); pm_runtime_get_noresume(qcdev->dev); =20 quicki2c_dev_deinit(qcdev); --=20 2.43.0