From nobody Tue Sep 29 11:55:31 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC9F03115BD for ; Sat, 8 Aug 2026 13:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786194157; cv=none; b=sv2sSae34JHOnwcm6XukdsG6zMHmr6hY5XVRPlXYKg3VfrPVnOZp82cDJmjXBp0dCqe7N6XGb8rrs41FrGFrU4t18uEPLNoTdSRRyd2AQFdbo8qCutDhuhKS7CAgoH7YuDZqn8P1Q4ie18qL0tSY722SKEgqvLEP41CJaTDw64c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786194157; c=relaxed/simple; bh=Eu2DxpzXT2B2CoowyfVggZHqw8b/0SXNWN1PQiInjI4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hLJaAjNomehq/RSWAJM99XSn92YWcJ8Z0Es7muIdqeLQo2f4lx4PFjhpF9OzCdLoXEqNnRDVx88STmIsXsnmWkDUL+Vqyh6ej9mYZqtWqv/mZFOsIDWaaYdWVsWAKqj7WXMvyoxKWUKoTEweMmcHp/gJrSGzuHL5aLay05nkdYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vrp22tvc; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vrp22tvc" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cc97653887so5221245ad.1 for ; Sat, 08 Aug 2026 06:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786194153; x=1786798953; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ujnNvGTSQxsZnZMjDYqn4ikZo1KrqP6vWqNprtUTP2Y=; b=Vrp22tvcgAXKg+vbZ4duMjeMbripE82VHekNYB4gq/ODT+3T0ifEboiWb07LGBkLFR i5IGGBr8cpYRIhlJUG8sJFSqXo9DuiQbuETP0qh71Y358/UY5+rc2oGxSSAOEetLtCL3 rLuVgqOKMsmM5mMXlIsTOQx3eE4stzlUE0WjDzVbqd9GgMoAFUiXocj/zC3kXDQyn8TO WIXdKtg5hfCLqNpqBNw+KhOUL49IPVR1uagcWyc/lQ6K+4VG9WhKd43yoBUdcXjzryIx FHCElBX0pAlmHXNqae9awMN31a+OfT8eTHg8WeE5w3Ou45/Tdo9P2Jbp9BTDzPMNpLpX nsyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786194153; x=1786798953; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ujnNvGTSQxsZnZMjDYqn4ikZo1KrqP6vWqNprtUTP2Y=; b=eMKzWlr8eiapPIcJ6DNIOcN1oIwY5lceYbV2utWqZL1T0MQ8W2TU5RCxNtx0/8LymT 79VgqWo/IwY7DCO3UjetWb8x9ubEZy2dQdiVxt4bbymEwNm8m2HcqVG+xlnmKWuferxq H2l4EkqPJqe00S4iJ/8iHPjTt0VRS4m23FMcBfWILLYyVuWxI+MrAArS6N4s9N52XpOe ocFoKlRdk34hZ/NGSFI5pDXDwPCLaO7TuadRYCkDHszlJ7m3vnyt22mTxQsDI1SAqSvw YOXbxbpQrOCvf9wxyvmrr7zVpisM8/qnkL5+91h10Ic8MGSv7hmboJTGova+vJKyzRlS VZAQ== X-Forwarded-Encrypted: i=1; AHgh+RpD9aZYwtr/oipOhBvJGGMv2PwOl6qsgSpZp2wpdI1n4loG+Qza0GLUMe1J1IkdfbvqLXd9d8L039UGRCs=@vger.kernel.org X-Gm-Message-State: AOJu0YyGIA4stzKn9zB/rSHBHR/v/2Yqloz83T7uJ6fvS0b3ozp3QKDB JPaR1DBEjXiPMuwDxM30vXTvuWGbrLite/TSvdhwNQstAfwZjEUIxVRk X-Gm-Gg: AR+sD11KaSk/dodAowH8v+pRZpnRmHYawADe3chwZucak70f53p78X4xN8JuEGwno5J 6P8ETnm80zUm/ZO09bc/+oDG7TOAoy2cOhlm8SU/0l4TBU9ZdMXDuPmdFWYwzxm3s+/Zje92idC B54RitOowY0U9zF+HngU09ojWqnAJF0WAe1ZwXen3oydvA9y8plyCr+bQODdGYj9hU2BKV+qrEu nKZ1FExFMv4RBiVg/jLibTbiW91BsUeMUcChjBEoZH63rvecFXt5dy2BYrd2trvGvEFT/SOOB9D 3BX+fewkxWrewu4kdRCVk1q7GuMLuClxypaPLXDg/FOH+2MwLzt80KbbcH/J8BKgK0iSk+ATl6E adrl0kM8cxxditM4xsbYk5tpbaqz+w9uyRfdPvAwIS5WFpBAh5lVGdYPpbBZt1KVSVOri/QxAyW IdHCQ4bB8+0Gvs69v0UcDMaiifn33ApOIaleQO1r9YO1TN X-Received: by 2002:a17:902:cccf:b0:2d0:cc92:f7b8 with SMTP id d9443c01a7336-2d0cc9302a7mr351828965ad.2.1786194153328; Sat, 08 Aug 2026 06:02:33 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d14ccae6f8sm18582125ad.1.2026.08.08.06.02.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 06:02:32 -0700 (PDT) From: Guangshuo Li To: Qiang Yu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vasily Khoruzhick , dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] drm/lima: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 20:59:53 +0800 Message-ID: <20260808125953.2842241-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" lima_pdev_probe() calls pm_runtime_use_autosuspend(), but its failure path does not call the matching pm_runtime_dont_use_autosuspend() before disabling runtime PM. The remove path has the same issue. In particular, lima_pdev_remove() explicitly sets the autosuspend delay to -1 while autosuspend is still enabled. A negative autosuspend delay can increase usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend(), this reference is not dropped before runtime PM is disabled, leaving usage_count unbalanced. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() calls to the probe failure and remove paths. This issue was found by manual code inspection. Fixes: 50de2e9ebbc0 ("drm/lima: enable runtime pm") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/gpu/drm/lima/lima_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_dr= v.c index 9a0eb1092ad3..9bd44c191e6c 100644 --- a/drivers/gpu/drm/lima/lima_drv.c +++ b/drivers/gpu/drm/lima/lima_drv.c @@ -434,6 +434,7 @@ static int lima_pdev_probe(struct platform_device *pdev) return 0; =20 err_out3: + pm_runtime_dont_use_autosuspend(ldev->dev); pm_runtime_disable(ldev->dev); lima_devfreq_fini(ldev); err_out2: @@ -456,6 +457,7 @@ static void lima_pdev_remove(struct platform_device *pd= ev) =20 /* stop autosuspend to make sure device is in active state */ pm_runtime_set_autosuspend_delay(ldev->dev, -1); + pm_runtime_dont_use_autosuspend(ldev->dev); pm_runtime_disable(ldev->dev); =20 lima_devfreq_fini(ldev); --=20 2.43.0