From nobody Tue Sep 29 11:19:25 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92F0A1E515 for ; Sat, 8 Aug 2026 12:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786191664; cv=none; b=V0ZEVM2wsV3ARRHxHM8LPFehkSlXKajTxip49xZldIt9/VPpZ7mUPF9F7QtE2/0pnWKkOfXOXA6577fGERK6axcQUAVN251X9ZZKRpAFa7Z28urHBTsqhvc6TP0U40S8/6MQ6LH4RFdjzY4+J/ry35RnnMCa084KcO5BGeSCAy8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786191664; c=relaxed/simple; bh=WcSZxId+S34IwFArlRF3UDh/7T6p4oXgwuErWrRWT8Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jxYjaokWUSEz3jnz/xYlzH2TJ3heRsb3BbR9J17UC2iEWCK9uHFoKQWbHqzde1FxB4DuHc6ZU3mlNppziOBdfleA+CwVaNyxnS0rq9o81gbA+RrsE1lzS2KUplX/43ydItcqvsupM7oj3jzytvpdfipH/koJI/04f2Lfc/Mbg6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RDXM3Lxz; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RDXM3Lxz" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4954afac04bso4117955e9.0 for ; Sat, 08 Aug 2026 05:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786191662; x=1786796462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Le9aTN9I4Hkl8j6KgLggOKWGuXynZHIQztDuT7nEfQs=; b=RDXM3LxzYbTabf2ClDp7GlxLVsUeCLf7nU3/LQaZdxPzgjK1MSOMmylEsB17ose8AV rK+ixDwHzKlLMK+ivJ7LriBbBgMRsVNH7wcP6kMylxDjM4x2a0bCNoWxCqDO1FrALiCw GHgnGbt23yP3L/4F9jOQv2lSmptxxbf8Ef9j/Ui2jILeibQ3YiETaa09cf1NaOqJiibC peKVI7N1M2Vi7avP1XxItgcW0YkPc8GqVVPmm2uF9BBmoUuoQcakaUFb92AetsJT5zuv s1Eq4EBijpNFtJMA7mTf8pVc/col2d5tQoVnrbF01Y8hD1YxnHYLydB0Ui2ZGboJBcXq DvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786191662; x=1786796462; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Le9aTN9I4Hkl8j6KgLggOKWGuXynZHIQztDuT7nEfQs=; b=oeL1yTH+tngHivLO2aTgxzkE35ITjeqxJizGhwbX9GK53Gnu7HsV0AXarQ8W6nydyC MWfc42xIk2n4ErcfL0cVrQf9FymU5vlgog4oOAs8Tbp2oX4FpC0TOpj0kFj9YNt32p1A sp4UHY6Iclq1Apew4BUtP5I/cVyoBagdetjL2Ljw6ruw1/jjJEjFo8SIOGc3ZU0gtovt HBt+sBZO4Yao0QCGvqn15DFtVrYiUzhJ11a8gjOHDDYKq2bVtml1HAm1H8Igs9YCbvXd eNm/3wu8ZbfykD5VTU9iDIWxL4+fTQpJfq0szYi6GGDsHmFcwiYBfrZnq+FlJcavBCmU mNvQ== X-Forwarded-Encrypted: i=1; AHgh+Rol0WxGEPIqFd5Ck7gmoZmD+P1IsZ5Nl1vh7OahraoekcGWtZPVeYp8vA6h88K/wUfN3OmOIFST8I/YL/0=@vger.kernel.org X-Gm-Message-State: AOJu0YzB8keMSkn6SXfOilzoZsJINSVRLgo+6MPQElyPixEq6DL4MBGe +ao84Guh0KcOWGSAkgnep8/vFU2ERVz0kUdHnSTa76P2WXyhPYHfUTw9 X-Gm-Gg: AR+sD131uVsroerktaNsEZ8nyRVntkj3x+fcq0QBvNb6sSsournlt6esLZBS0CE5w3K 5q9Kejlj+6b3n6zgS1uoDl0Nez4k97d2LSAqKAywlhWMTAdkr5nwA2c9pPkGGJtXBusQ0fqDQxt vegI+9Tc5AzMPUGuPOyicW01s0qqYojNdHoXW7C1sG8MmuFK0HqA8iSFpCw/9mZ/FYzVbjY5U8W RDHJUzL4i0L0m85hHYDpCAIQ58i6gQTHvxWANVvD/o0Pr2rFj9Gh/v+4AwQp1LE/bwwgjMJXqti TzO9YrUamIhtfu+8I79FFH969MiIT8ZPzwgm3pvzRN5i7xVEY0MYh2nXm/D8q72/L4Z+kMta9Z5 jbpEGuTmKLJvbktC7T5JjwMUd7QY5oeGFOTE83blL3wrm/5/oJrRx9yl86ANVgA/5bHAde08QOv rOU9OCghgiV8EbhwB9T2SevOtggMD4ia7CYwJ9R6KWm4kPOnzDWrcdhDBazPBdsdKtnYqrTSej9 yKArH3lswo51EivfYXwmJj7CGBDrlv5YTpuZNnr2XnKt6ttBzsY/NZzaDwSmF7BgYWqN9dMiJDm 6eXmCKv8sCjqotVnTs2v X-Received: by 2002:a05:600c:c8a:b0:493:eed4:7210 with SMTP id 5b1f17b1804b1-49961992a4amr87924775e9.11.1786191661566; Sat, 08 Aug 2026 05:21:01 -0700 (PDT) Received: from localhost.localdomain (dynamic-077-007-004-134.77.7.pool.telefonica.de. [77.7.4.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542851d6sm249365395e9.12.2026.08.08.05.21.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 08 Aug 2026 05:21:01 -0700 (PDT) From: Karl Mehltretter To: Dan Williams Cc: Karl Mehltretter , Dave Hansen , Jonathan Cameron , Davidlohr Bueso , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] memregion: fix cache invalidation warning message Date: Sat, 8 Aug 2026 14:19:43 +0200 Message-Id: <20260808121943.72939-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" WARN_ON_ONCE() takes a condition, not a message. The string literal is always true, so the warning still triggers but the message is never printed. Use WARN_ONCE(1, ...) instead to print the message and keep the once-only behavior. Found with a Coccinelle script. Clang's -Wstring-conversion also flags such calls but is not enabled in kernel builds. Fixes: 1156b4418db0 ("memregion: Add cpu_cache_invalidate_memregion() inter= face") Assisted-by: Claude:claude-fable-5 coccinelle Signed-off-by: Karl Mehltretter Acked-by: Jonathan Cameron --- include/linux/memregion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/memregion.h b/include/linux/memregion.h index a55f62cc5266..50a6d2ed432e 100644 --- a/include/linux/memregion.h +++ b/include/linux/memregion.h @@ -58,7 +58,7 @@ static inline bool cpu_cache_has_invalidate_memregion(voi= d) =20 static inline int cpu_cache_invalidate_memregion(phys_addr_t start, size_t= len) { - WARN_ON_ONCE("CPU cache invalidation required"); + WARN_ONCE(1, "CPU cache invalidation required"); return -ENXIO; } #endif --=20 2.39.5 (Apple Git-154)