From nobody Wed Sep 30 12:59:23 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5190F1E515 for ; Sat, 8 Aug 2026 12:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786191548; cv=none; b=qzbGr40EcMirgJR7NekZHxTKeGTcwATGDC3vqcpPLAAIQRYjM8z6+oD5WkY8CsQoTH8UAzMWxDq0IubQQn7jOX/dpuYeYtTXeU6y/cGpvR4GfQb3GJQPOlQVvwNVFtsedVl6xrD+Ve7Y0kmHojILa93WHvLytiLsbkPx/Oo73go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786191548; c=relaxed/simple; bh=QCtL85J2Iq5Kaj2qkyZecqzvZw4O2YgB8I7SK/QDQgI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BZ1EiObG5gppEQWLFzkDpitqGuWa+q68lA+x7yx6XNWAvV23qE0HNwQiAaM4ctRDKPlahzJvSJ13PuyVYED06B5647HnO+iAuVI+fJwMcd4yMORM+oxV4NTEvxCdLEz7eu5bhWZLFJqg4YRVn+kuynj8+C7qsID4ifbJCcZPmjA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eeNU4G95; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eeNU4G95" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47f703a9d05so220690f8f.0 for ; Sat, 08 Aug 2026 05:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786191545; x=1786796345; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=kFo+FAm9dOuD7sRaxc5XvG2wnDlTsCrM8DjnwJd9TPY=; b=eeNU4G95SurkCEgdQZslPmkrCwv56wd7jFv8bnpjSHHuITbYi9FDBHzC+wYof1okh7 A2//8B7s1hHm1r0CjG9QbjfGb+l7BUETURxXyL/DomlosUKwrlDBGXOGU7KIQMHL27z/ 1Majpq4xEfy0c6DF33dtmVJJM49c/k1Uz3yBmgxFSlG0SPx99IoYG1GPdrxFyPqVEnIA AcwKA+MotQtiX3DpTeUbiKliOh7YObN4IpkMr2cjnHbpR1CKNmCcyw3WFDB71pSHwbpq X4QO5r7CmXR4puXSIuFN9xaj5Q7eSIiuX1W/x+O7wdj6ufZk+0+Dmk6RhtcTV3OngQ/X njBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786191545; x=1786796345; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kFo+FAm9dOuD7sRaxc5XvG2wnDlTsCrM8DjnwJd9TPY=; b=nN7+fCe7ul9F/u7qOIOsqgqERV739D73Caou9ToNaezLtPrERk09B+n6yZXbRckQ6q x56xWPl8A/b0k7XhtDXmBjpmde32VjocVoFbI+bBLgD+zys/ORfykCK/61E847Eb6XxT Hj563l75GefNGgHbbhG4G5G5c0ylrexxAhICDecvNp7rbwzwmWF5/fTFXRChrMiA5XRi rsIQyVtWroP60vJ895AN8VZqWFc7qW4+c/Z9de9Edp3AOEu0agO/BpRq93WdHH+jMqvt je7dD3mvIp/p12jvYzPGWbznvhqEfHonIrwSNhfQNoHDVyNLFli6T2mEPFJk9XXfaj4N Te4A== X-Forwarded-Encrypted: i=1; AHgh+Rqe1ugjnmSW+VGJRo8Qe/4l26e4Taq0SlRO0YRS+SKuSiZY5u9A/yhF4NzNDWplYVv0LAFWbyaJ2vC7/9I=@vger.kernel.org X-Gm-Message-State: AOJu0YwBh7wiDDQHiMa76yY7qsrf9AyO+N7OfZ7SYNRk8U/ZMAvrxJqI bh8FRoWIPhl1PwM4QqupCa6HfF7g+6yVR1a6XV6VCB/WZ1rc3w4PhVq4 X-Gm-Gg: AR+sD12sgKMj1ULBLFZM5aZiM+WNZScXYB6v88VeSG12SkUpSg6LScf4vvrur4Vayer nlrGIbcpzL0Jqm2nrk+txNf3sxPRBqvNbHaRZYCAMkbDIXaHXo9Pi1MKhhMQcpUPi+u21j9d6tp PMxvAOxQYTttPg5X7JNUeTZhYY2vkRgbirb46oC2p+kNLuUN6ug0YjUhRxKD+98tudF4Udbz6Nn Av8WXkShNuqKdc/IFc1+HYy9flS++b8TxIUYMUEGHs6f1l6GR7UP2qw5n8Ows2rKso+PYPrIOMN T2/e2vnevNJcZuW1zlAhsc2W+AOl1FPfQKQceO/Ocm4Uc0VCBizfzQsRDZgWq2V9hFrkTr0qiMZ f/+9eY5lABbSN6yPpWApvDCmz3rakixrJpdICT6M2k8TK7PAL6mZ0NeegzyiTAyO5O6STKMFyob g341Ogt7tQBThOU9t01CGaEJObKOesNNnva9kEDfDtx4UJ1j2Fylc6zDYL3wQXOk5qsyd7Y72ZU tNp6DIhQ73eUn1BmCp2u/sf8SJ5cZ429KcOGlNIwYowLuLONguZ8XAwyq9XWzBhGVtyPD2YaoVr wjNK5VVt2UB4nvNBhx+pDbPkByfp+3o= X-Received: by 2002:a05:600c:470a:b0:493:f318:3bc6 with SMTP id 5b1f17b1804b1-4995e0df176mr112874695e9.13.1786191545414; Sat, 08 Aug 2026 05:19:05 -0700 (PDT) Received: from localhost.localdomain (dynamic-077-007-004-134.77.7.pool.telefonica.de. [77.7.4.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995421fee8sm212371525e9.7.2026.08.08.05.19.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 08 Aug 2026 05:19:05 -0700 (PDT) From: Karl Mehltretter To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: Karl Mehltretter , David Airlie , Simona Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] drm/amdgpu: fix GTT manager warning message Date: Sat, 8 Aug 2026 14:17:45 +0200 Message-Id: <20260808121745.72691-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" WARN_ON_ONCE() takes a condition, not a message. The string literal is always true, so the warning still triggers but the message is never printed. Use WARN_ONCE(1, ...) instead to print the message and keep the once-only behavior. Found with a Coccinelle script. Clang's -Wstring-conversion also flags such calls but is not enabled in kernel builds. Fixes: 7554886daa31 ("drm/amdgpu: Fix size validation for non-exclusive dom= ains (v4)") Assisted-by: Claude:claude-fable-5 coccinelle Signed-off-by: Karl Mehltretter --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_object.c index f98bfba59a2c..f2ea881d39e3 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c @@ -565,7 +565,8 @@ static bool amdgpu_bo_validate_size(struct amdgpu_devic= e *adev, =20 if (!man) { if (domain & AMDGPU_GEM_DOMAIN_GTT) - WARN_ON_ONCE("GTT domain requested but GTT mem manager uninitialized"); + WARN_ONCE(1, + "GTT domain requested but GTT mem manager uninitialized"); return false; } =20 --=20 2.39.5 (Apple Git-154)