From nobody Tue Sep 29 11:55:26 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53A74377A97 for ; Sat, 8 Aug 2026 11:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786188178; cv=none; b=MmCCHa9AMBvBUZ/2Qhj38Cpc59ByDWsNj7lKkX2zl6G2lE+gC8hSnfxKwFx0NHZkqepUjvfe8e1XlbEHviA8axh+fv1+zN/+BecGW/58EQLZwTmwkdvBbJHSvv//5MMFL8Lae4LiiHWTzfMfntOvNkGRuhReL3xFaTzCY15SVGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786188178; c=relaxed/simple; bh=YmTG5vVK/FTTLwiYHkfLbcJlBmEgt7LnpaAC7mAvf8I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oG5K9y6VuFF8BuWtZgX1Tzl4QabiKKypRpDzD7U8dK4Ty1zCA97k6/6NuCtK+BTb4H1W2EeGKzyEdSRluzBC61be1upsyLsOreJrg6/Hv4YaGFZfzt4CGOe1mnspCu2+/06PRkCQ7ijeQ/dvObALqJO924Jcq7PkQes0xWMYEpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ByaBF6Iv; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ByaBF6Iv" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cfff5f88dbso6657005ad.3 for ; Sat, 08 Aug 2026 04:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786188177; x=1786792977; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=MEwID2P1yRmU8Feq+ODsi1JwIGprGXNdUwcJktuS+tc=; b=ByaBF6Iv7LYHgN28kQY44npWWC3vHDwDY+kSHIWm12IKGjmvgfFjw14t7xqflCi6FP cjWbUjwBMuySXxYhNhql9lS5TQ7ql3sM5CZuR9wjm8gn0jnOXTDrkeWFopmt+HJcmcKt b8CPYMnKP43GBVhK7aXXqc4sWk3dx0qlP86MXq2AfqG+7XN0ffP869YJwDA3oTrC9X6o 839TPXdf7bJ0PLT004h3F5O6slPPye8Bj0VH8xS8rWideciyN8y5DVW7uve+TsopUO72 lirD5HttjqYCj2o3mc+tCBOoWAXr3S/gxquo+c/dtLR5I0GOitaGnmrUU5IQVikjF9WA 0TFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786188177; x=1786792977; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MEwID2P1yRmU8Feq+ODsi1JwIGprGXNdUwcJktuS+tc=; b=QgQFl731b8YAYjH4V0fdAj/0EPlgf+a+z16dvT38p8dHsjGACeUmDlPMd9iIuhp9Xh fzi58p+b0lcT7rfSliQVF4VcpQZvL0M/znrwtJU+O6jL4apPLoEZVgjn3dnxh0comvgr 5dC14IMHjRcJ2Ii38hwJ8MysodRGyobbfbrjRpHDCZPxTCCnK7Gv5k1KOZ0Thn8+ta8Y 0KkoV5ixyluishrfzipYTV/SJV8El0z1+dRfE+AyeG5BfuR95J1DyAh6pg9pqbQvFx6M 9LKoMD7QOB2/hQVp1tvLYXNzFDXf1VxdfZAj5B4o/aEZYz5H+cpP8HDjtfQxW1HGMXNW 7/mw== X-Forwarded-Encrypted: i=1; AHgh+Ro+gJ4FFY7C9w9pDLwdGXi9IL83Xr56Ey9RIcKF3ez7PpUuVGWSiZ5wLy0CccCFAaIXGvssQR4MZ3pums4=@vger.kernel.org X-Gm-Message-State: AOJu0YywT+QBvWsKDU4JZg6XbDon3Yu7UFVjp9AiZBnmsDG68I7DiiQM q/Y5Yg/ghtDKLx9+TKO1l5ibAepEAa1xlRKW4nnuLgT3HjqfvElfZ612 X-Gm-Gg: AR+sD121aVZlocgT+gaII6m1B5SuvAIUWOdpw6S8e+Uf59XcBEb9ysejTQdfJz7B1Ms aZC2ku0iQRRIzfCYXZxbu9iUqDvKq5wEsZOxJIySpk8it/QCi8azp+VsqySElbRasDRyZ70LI/3 yr7TCUmcGhX6a1wdl6L+7RrPUX3WMlYYreU6rAdtM0kVDen2aPbbPH7Dg2AXtTWIKiBPoWSJ78p 3TZ+CpIUiQC+Etuy/KrGylNmL22YiOlpv4i3SgT/UHZQnURPmuJTKMY/zLKgHMwi5c+9n39rrhE C+AEYIXw10fTllScN80QJndyXgjS80RQvM1TH4WvMeZLOx8s5J7x9cP6rWBn8mufipjdvwJIikO rqNZ1jwU9qFbNzWauU6L7U84GFHO8qJNby9nxnanShj+zSRTlLC8iLFX9sMC806obtICiSdbQGN E8RH68Yv2Mq87fCGcTFsaM3ZU0K3ROoy7jav5h7MIwL6I= X-Received: by 2002:a17:902:ef4e:b0:2cf:b68a:2050 with SMTP id d9443c01a7336-2d0ca775824mr364281175ad.15.1786188176638; Sat, 08 Aug 2026 04:22:56 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d14dbeeda6sm18048745ad.42.2026.08.08.04.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 04:22:56 -0700 (PDT) From: Guangshuo Li To: Sinan Kaya , Vinod Koul , Frank Li , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] dmaengine: qcom: hidma_mgmt: fix autosuspend cleanup on probe failure Date: Sat, 8 Aug 2026 19:20:43 +0800 Message-ID: <20260808112043.2781244-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hidma_mgmt_probe() calls pm_runtime_use_autosuspend(), but its failure path does not call the matching pm_runtime_dont_use_autosuspend() before disabling runtime PM. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during cleanup, this reference is not dropped and usage_count remains unbalanced. Add the missing pm_runtime_dont_use_autosuspend() call to the probe failure path before disabling runtime PM. This issue was found by manual code inspection. Fixes: 7f8f209fd6e0 ("dmaengine: add Qualcomm Technologies HIDMA management= driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/dma/qcom/hidma_mgmt.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c index 4805ce390ffa..470c88f36d25 100644 --- a/drivers/dma/qcom/hidma_mgmt.c +++ b/drivers/dma/qcom/hidma_mgmt.c @@ -168,7 +168,11 @@ static int hidma_mgmt_probe(struct platform_device *pd= ev) pm_runtime_set_autosuspend_delay(&pdev->dev, HIDMA_AUTOSUSPEND_TIMEOUT); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_active(&pdev->dev); - pm_runtime_enable(&pdev->dev); + + rc =3D devm_pm_runtime_enable(&pdev->dev); + if (rc) + return rc; + pm_runtime_get_sync(&pdev->dev); =20 virtaddr =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); @@ -310,7 +314,6 @@ static int hidma_mgmt_probe(struct platform_device *pde= v) return 0; out: pm_runtime_put_sync_suspend(&pdev->dev); - pm_runtime_disable(&pdev->dev); return rc; } =20 --=20 2.43.0