From nobody Tue Sep 29 11:55:35 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4A483655D8 for ; Sat, 8 Aug 2026 09:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786182431; cv=none; b=hYX60mT1fUfKNj/0L224bYiDsB5SrFn11J+neYrlCmTM5s332uFB9KdvaEMPD78p9d+50Ws7LjUF7/v6yDm5ff23iMOurrB5YvU1KChHRgWWTc6HGgvtGFcDBpGBg5dEqc69PN6G8ZBX3EzSpGkVYpr0OD0QbwZmvZ3sRhGC0xM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786182431; c=relaxed/simple; bh=n+VHIM10UQAdsOrOgWwVd3HizjL61jNMNdfdNzv9CBg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VuEy9XiS8Yros6tJfC1AicstnSoSlyt9+cCMjJNLkM1uuRdg4DAFnwIu3rOgsZLk98ovRFoVD6+aL73hhFIn1zWgRjHhvSjZqfpOOP0dnB7dKpJdv3a3Du4NWipkCwrmeWg7YgMSg+aGfl3OScsg0K88xrWY7jPQ6vmU8xAgtM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mNPNuTdg; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mNPNuTdg" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso158958a12.2 for ; Sat, 08 Aug 2026 02:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786182429; x=1786787229; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Tyg/k3QHvoAlSDHqgJ9zjC2EsZ+xAbQy3JHE+24858g=; b=mNPNuTdg+jbnrMnh5lFO3AtQXsacgAv7WBq0wgfGs0uoej3WdA6v9hWhoIJ0xK13dk PI9cdzfmCItvjaEcmguNPOgq+BktK9RZF0mK8W/bAJdzv30w+DDas1dLHtQSyjlfXAE+ Haapmp3brnJv1Bv4a7hqiRJniSlwyEM3NV9PHesm/w5TBHxECO2XVwfeWTsK4GuXdkV/ 48C0VH4I+pVZ7EWp1EiZy2Y6epvdXBoZ9Sz6nULX3pWK5hjnk9Ih0J2StYVUEEhRSpfq UNzJ//3GdhBakHSzFWcjMzZseOM1784W6qCxN/CBzWIydJc+C8TlaKS73zmYyGI5Da+r b/TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786182429; x=1786787229; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Tyg/k3QHvoAlSDHqgJ9zjC2EsZ+xAbQy3JHE+24858g=; b=qVUZcjCTahiPBOISu4hRvquKPO9JpvmMbryXlYmwnT6ehVgwOVM9P6oVQ9135ORvaR AYJDYjPlQyPn6se3GUKjLHvu/CZVwN/gO4rMusKnOD78l4Qr+eKXDC0nGgHOXmWYO0ah +mhK/aFYumoPyJxxXMbkXQeICrwUXEi2xoPy7IGCYPmoUDKoiQoi/YYFjwqtfqyvrQ9J g8jjqtYE/N2KwNSl+KiZfJN2h4COI8KLRoK/GMoPoS5WcOwFfJuI5z0qLEJf/Wm9w8TW 9fhuu49PWGDTuIOIKUwMFPo7wjPOaHDvjLhyIRS0RaM1lrl4NjLrMYSAr7ZV8v0wjstB r7+Q== X-Forwarded-Encrypted: i=1; AHgh+RrlLFgl1IqXHSlfb092omek8V7yyo8Io32MQnP3dxhkIKpoDfVk7dISewoftchcBQc+JAR/xw1slFp4kuU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl0vmoMZLz6sKK2rFPYlif6Y+lAkFJ4sJWDoJGsiJ+Ho5kPKgy UA9WsTjuM7h9GloLOCBHQMJhJMjy4XyunBENKSOMR13TeJVtsjmwXJUW X-Gm-Gg: AR+sD10vYqYs1k1fFGtI7enk0borWtNntweINAHfE+Z9rItfC9kuvG9vW0vzfaCrwBA 3gYLRXpTkDF8qdoJtzKU6QxzN2UOS8JH7lXsiTg0GYmfN1sYtZORAPSWaGiaaUhkQsqWv3qsGO1 qHcloJPWDM/oyr3GvNX0XmDWIpsdzoQus8yP2/zhU2aVzsJKV/Gr7HtLGuTr5XG+DP0n92/gNdt 6KI+k+hf2ryAzz+65qx12xvpIUw8QfchMy3vu5s57iZfnrwviMBTNOqM4GZR6p1sT8izAfVHSkU PDRpiCV4w9vMpCauUQ8rAlaZWii3bc5E62lz6unKj/a6B3xEKhSTQ4pLxd+8veFYX0yyP0FewPh UPe8vlIXRhl4kJFYDLqFiAEpX+yQnBUKwQ8Ku2nm3z2oJu7RVLnzRRnTrBs4mdmcqx4NNNxb+Zl 27xug1yuAr1fsAZXDYPNi/KnoW95gKQa6o3gqN4UN2gLE= X-Received: by 2002:a05:6a00:4b02:b0:847:8acd:747c with SMTP id d2e1a72fcca58-84f2e022980mr30903415b3a.13.1786182429006; Sat, 08 Aug 2026 02:47:09 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a51e9fcsm1983113b3a.36.2026.08.08.02.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 02:47:08 -0700 (PDT) From: Guangshuo Li To: Vinod Koul , Frank Li , Russell King , Ulf Hansson , Krzysztof Kozlowski , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] dmaengine: pl330: fix autosuspend cleanup during removal Date: Sat, 8 Aug 2026 17:44:52 +0800 Message-ID: <20260808094452.2752443-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pl330_probe() calls pm_runtime_use_autosuspend(), but pl330_remove() does not call the matching pm_runtime_dont_use_autosuspend() when removing the device. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped and usage_count remains unbalanced. Add the missing pm_runtime_dont_use_autosuspend() call before restoring the runtime PM usage reference in the remove path. This issue was found by manual code inspection. Fixes: ae43b3289186 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power Mana= gement support v12") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/dma/pl330.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 25ba84b18704..8baadd104719 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -3204,6 +3204,7 @@ static void pl330_remove(struct amba_device *adev) struct dma_pl330_chan *pch, *_p; int i, irq; =20 + pm_runtime_dont_use_autosuspend(&adev->dev); pm_runtime_get_noresume(pl330->ddma.dev); =20 if (adev->dev.of_node) --=20 2.43.0