From nobody Tue Sep 29 11:19:28 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0C83370EC for ; Sat, 8 Aug 2026 09:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786181437; cv=none; b=Gp7+GBZA7dHY0hJOZNZarJ3XOJ0KEjiwIi7x8FoP9iqqAlStcxtj+V9FM+yvIARoVhM50VzYG65+1RIahSc/7YUkltYS3d2isS4wSAB296edp1kOtEyIbQ1fynMSDCDKiGIM+4YeSyCob8Z+yif31s36LV6Lwk3n6ImIOOWJcXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786181437; c=relaxed/simple; bh=JxTOJo4MhGNdlCG8FhGvKU8SJgXQL9LBKbPWw9wDuhg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rnY1IgbovuYL8kdHfql067+T5w9kJIlT4ppNwt7PDYruwxFXi+w30reowneebD0WnMI03AQ0TyMB5ETJKxjrUNGr8Xo7w24NMA+ujkJ3+EV3RV3tCC+Yi4p6BF9Xx9SZz5N5RM7YyumXoikmCdmAJvsYIR7Y1RY3F5tD5XvTUoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nhl1hSL2; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nhl1hSL2" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2d02b4c3601so4010615ad.3 for ; Sat, 08 Aug 2026 02:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786181434; x=1786786234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=gC2ItiHuCYFgaLZeaOk4o80zqG6tRez0H0meLhFxwtI=; b=Nhl1hSL2gAXO/Z5ct+p8mBtNu+R0MgjJZ3RvY5tZ/DxyWahhLJGietVQ+wZ3wG4iNI yWUXSxLbcL5JaYaMj5UhkyAWrKljpIAyu55jRO3QJZvEhK/7guejTmHNTN6dTi/lMyJI oQVNuXk1isTLeFgSSBSwSQHiS1drHS34j9d0R0GiJyD9co6yR2ROg8YZAkm5fOOiK3JU 2F9ujAcSL7hznpITjQyF0nyCJV/5uGjXFyWPbtfGmWEgT83/wf/CtLiDl4E+gSkUVFnG VoCm4lLjqdC4KXLqhUR3Rrsb/NeYSJmflqUzO5Na8pmQsCFQfybD8hp+5Jcw7h1CnmYt ogsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786181434; x=1786786234; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gC2ItiHuCYFgaLZeaOk4o80zqG6tRez0H0meLhFxwtI=; b=NFEBsoqSQCRaIFoPTUH5X1tL6U9hHCLy7DVM/dkZ/Zlqb6Vsz6R4fPgMISzXgAKptb ma4DscuDfmYARiJ2TrtmYa9/rYPT4Weyx84rxfvTQHXzSGPEsBgKaR7VMb6hVUod9yK2 ZKdVxZ0sULvRKPawy62UB69fn9fKapYzsNBVolcX1PvG5CBBQbsQnAzBzUkibpNhkZjm Si/ah+AV+m2vsw+OoDsiXQxB4RLIP1+WNoYFR0ZAUfzJ2jD78Odh0MBRs5s/BTGSocMc Kiz8pd9GZp53U7ONg4GqpuDcQ1U7bYQepoDgNYxL5hGBQ0kL6y1dbp0d6w0R48odrU5W L6mg== X-Forwarded-Encrypted: i=1; AHgh+RoCUGq0WXFYS5pBOiJKsGJHLfbwJEnFZeNxAIlFvrTSTBMg5pyonUKSz5eu3ZwoGIjbCPyVuWG0yrkTmFM=@vger.kernel.org X-Gm-Message-State: AOJu0YwxExg0byCJUGrXWZ0tY84MKeT3J2e/H0PnP25fFzWlgJIydi6b vxNUKRpSNbcRZaiErDLa+TpHW1GBTI5bRdpIwIYH43G8sWbejmLmMfrrRFgkjGAYbZc= X-Gm-Gg: AR+sD117+GlvxSKbkVEGmPbgZWUcxgTQdsTeqt9rZ+NG4p6vg4y8TgmxF/Aj9pOf7Em vILQiazDo1r1omrck4ihwXWgTuQYTpu0QtN0K2FQHaCma4m/ZY/IIGySkCiInPyEfN4BuCSlC57 nVEPF9AQGErVygpZPeIsYCtZNg56muu85mhA5QSLaRKGusXsUlUQ+5kv81CVgNO/lMlw8aTTteT gOH2g+gipW0CKa072h/paly5nE/InSwLl1cdzAGtADCnj+yueogWSBO2erPPjqC1c2oGre2EhUV 0s1JRW49BtFE7jZvlG5ppRqusqsvRpNcoYVlSjsEM0TYKmqE3KYJJ+ibG7qAggq83fHMHhcO5H2 EPd+bB9IpotBSwBOT9VC34if0ke0ouIoYOkM22Ps1Sf7VyLzWGYm3MeYwIXS21BkGpNuxLVh5mJ r9N1i+5kVNl5YMI5Q21ECAXCWPRpRSC+b5G3zmojlQlxGq2suObTwpQ5kPwiMq3guCjYMl X-Received: by 2002:a17:903:3201:b0:2d0:401c:2ebb with SMTP id d9443c01a7336-2d0ca7125cemr362470225ad.4.1786181434060; Sat, 08 Aug 2026 02:30:34 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d14ccac0f1sm17098055ad.7.2026.08.08.02.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 02:30:33 -0700 (PDT) From: Guangshuo Li To: Corentin Labbe , Herbert Xu , "David S. Miller" , Heiko Stuebner , John Keeping , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] crypto: rockchip: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 17:30:16 +0800 Message-ID: <20260808093016.2738659-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rk_crypto_pm_init() calls pm_runtime_use_autosuspend(), but the autosuspend setting is not undone if pm_runtime_set_suspended() fails or when runtime PM is later torn down by rk_crypto_pm_exit(). If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during cleanup, this reference is not dropped and usage_count remains unbalanced. Undo the autosuspend setting when pm_runtime_set_suspended() fails and in rk_crypto_pm_exit() before disabling runtime PM. This issue was found by manual code inspection. Fixes: a216be3964c1 ("crypto: rockchip - introduce PM") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/crypto/rockchip/rk3288_crypto.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index b77bdce8e7fc..cfca472f996f 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -150,14 +150,17 @@ static int rk_crypto_pm_init(struct rk_crypto_info *r= kdev) pm_runtime_set_autosuspend_delay(rkdev->dev, 2000); =20 err =3D pm_runtime_set_suspended(rkdev->dev); - if (err) + if (err) { + pm_runtime_dont_use_autosuspend(rkdev->dev); return err; + } pm_runtime_enable(rkdev->dev); return err; } =20 static void rk_crypto_pm_exit(struct rk_crypto_info *rkdev) { + pm_runtime_dont_use_autosuspend(rkdev->dev); pm_runtime_disable(rkdev->dev); } =20 --=20 2.43.0