From nobody Tue Sep 29 11:19:29 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35CA73C1D79 for ; Sat, 8 Aug 2026 09:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786181216; cv=none; b=f0YfYp/9+VcPDOAcvkG3lEzQ98fIp8ZZlwNjxGi4cNir62y+aermNxGLxmBSuINlDsVCdlZ05LWTLlnp39IU2i0j15az7AKJlsHPIu8nGqHDaR/OZ3P8k7ikeL21IMUn2Jlr0MCtZo3IjyLEO4zDH6uOXukX76lNXOFA7M3GjfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786181216; c=relaxed/simple; bh=KGQpJDG2e4eg5QZCBOxotyJ+R5vVftN3hOWih4qmIjY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sEJi8B6bmbo16euFmtDq/Ue8z9h31lC9hTdob2/i76Ji5ZG8RRKhGA5PPRGCD9rDaq3DzmzNEqt575F0C0XcFTcoQwBY7pkWIHGZ5rHPzbxTnZlG8rBjPdM/yjNeNJ9hOW7bf9c0EwlYErsRikZ75ZQSiB3kFTXBKW0L7V/fVvc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KIbZ8KQ5; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KIbZ8KQ5" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-84862b0d5aeso338247b3a.2 for ; Sat, 08 Aug 2026 02:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786181214; x=1786786014; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5/n5vs24CVZDYo6NRZWyHt3f4uc0JNiNtoLIec7JOs4=; b=KIbZ8KQ5uXWTHMx7IcqZVqi4W6Vuu/nMQSWPI5txuaIZi2Ynel5CkN/ts2lhxiMkFs ok+hs2pkFgVKJNQpLnXcE2ypU4GLJ7dai7PDvmTbJGP29GiKEp6VrRShTIIB9uz99fnl doQuchX6ZuVFJ/S+jyZr2zxwyOjXcAV+ZPcO1vH1Og8HZBv58LoejiJOCnaqtDx+bpJu AQrz5Ej7eFCb9FSfhhi8JGHIeuTdivI/WGBvNHpyyaNkCYgoL4UfRCAvQ0679YHiBe7f YVNgYJ6d2pzUYCoY0btSywXBdGou8zxMf6pNv/3uGZ0gsG33ldof+SRvwotw66MckzaH WkwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786181214; x=1786786014; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5/n5vs24CVZDYo6NRZWyHt3f4uc0JNiNtoLIec7JOs4=; b=rfaBHlIjwWYf3LeGp05PBXEiAG3Sn+DjP9IAThDAqowsV2axJrW5DB1cJQ8QIHoY6m r94JS2E3L1hKphBCARY5W1bUt+rRClYCAYoNsWiNXEbCQ9+EFC7jrgwejowVMb9lrc94 +6k+SUqEH0j8Zd9rqqVqPkFu1Tsj5m7xerK8cHEoaH0sVkFEmfVPpAMk2QsypwWoiIpQ jN2DGVEObp7NALkzYwIwhCowqTjr1t3KJHWbkzawVZyNC4XQ6h/rLeNzn9Z/J7+MGAXy s2v0j1SfMpeK9dMK1RBhZAlg9AawuYj3gAmPLF4u2XPxdoToogvNyx8+DOzvbkpJyVyj txyw== X-Forwarded-Encrypted: i=1; AHgh+Rqo3EdeEJC7euznoAhsR7VOpo5y+HIx3Tq6az5DAkgZXd0R4UffHT6PpMJ1QUv9DdhYrI1VVXyjdiCmSdw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6K32ZihFFz/Uca1EQXtl7CV+149f+ABucCnqPgAT31+puRYyj UI42mqwcTi3w85ktv7vQ8W7voEcNEZJSIiClUvR672WA/PY4AWeYs6i+ X-Gm-Gg: AR+sD129/Trbs5dJsWExifXhvgZ0wwZWJ8TFjE5GWI1iYe7bKbMHg0c+WS4CqJAU6hz CPELYh9eqZ8W4iX1c8TFWeLxPNtkD5LOpUiZ8i48MmXaseNIe8VDxqUT/FYtrDyBC7mG0H0xZ8T eXVwu3Pa6EcS8DDRqC/CBUgNO554ix+Itb3PY5MFbJVhqHwV8X0BXKmGojBfbfD+qT/YhpBXer6 GE9FZOwvR3QVeL+JjBAx0HsxrvMe/ZammFw4BmbxWP1VUbORW6fYapxBDUHcnGE/ahbl2u80uwC jEeWQ1RyYr9/xPzBG/oajJBvNWV9TlmK004GNn5ZsXIhjG1SH2jCBopv/ND3Ja0MjzQchSpsu6R C3coXkSES+nqmmejq+1A2iaaW3AecXlEsO/DA/IkZ0Xw+c6Of43lGmrnVNkusWxadwydqSXJ6wf Mjo/4WpR/hnomPZp3DJ9eqjjbJB3PSWJ2vDFrqpKeYuuDycU/NyQmVOzrByg== X-Received: by 2002:a05:6a00:a247:b0:845:4126:222b with SMTP id d2e1a72fcca58-84f2e00ea1amr36933658b3a.28.1786181214390; Sat, 08 Aug 2026 02:26:54 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a51f166sm1943751b3a.35.2026.08.08.02.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 02:26:53 -0700 (PDT) From: Guangshuo Li To: Corentin Labbe , Hans Ulli Kroll , Linus Walleij , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] crypto: sl3516: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 17:26:33 +0800 Message-ID: <20260808092634.2734292-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sl3516_ce_pm_init() calls pm_runtime_use_autosuspend(), but the autosuspend setting is not undone if pm_runtime_set_suspended() fails or when runtime PM is later torn down by sl3516_ce_pm_exit(). If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during cleanup, this reference is not dropped and usage_count remains unbalanced. Undo the autosuspend setting when pm_runtime_set_suspended() fails and in sl3516_ce_pm_exit() before disabling runtime PM. This issue was found by manual code inspection. Fixes: 46c5338db7bd ("crypto: sl3516 - Add sl3516 crypto engine") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Linus Walleij --- drivers/crypto/gemini/sl3516-ce-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/gemini/sl3516-ce-core.c b/drivers/crypto/gemini= /sl3516-ce-core.c index f7e0e3fea15c..f09a7f3445e4 100644 --- a/drivers/crypto/gemini/sl3516-ce-core.c +++ b/drivers/crypto/gemini/sl3516-ce-core.c @@ -381,14 +381,17 @@ static int sl3516_ce_pm_init(struct sl3516_ce_dev *ce) pm_runtime_set_autosuspend_delay(ce->dev, 2000); =20 err =3D pm_runtime_set_suspended(ce->dev); - if (err) + if (err) { + pm_runtime_dont_use_autosuspend(ce->dev); return err; + } pm_runtime_enable(ce->dev); return err; } =20 static void sl3516_ce_pm_exit(struct sl3516_ce_dev *ce) { + pm_runtime_dont_use_autosuspend(ce->dev); pm_runtime_disable(ce->dev); } =20 --=20 2.43.0