From nobody Tue Sep 29 11:19:27 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16888277818 for ; Sat, 8 Aug 2026 08:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786179576; cv=none; b=czn08TaRWFowzgnB+4Uul55kDrgCthgi+pAzFNY104AfOeRPVxwJ62ShUVoNXjQXtAHRYjvFjOIap8ZOALUd2L0UjOjlYWQB866e1BxivJRPTpLGBR/BKatRt5h/clSZtfsxIUtvCxa3cJEofsdVPVsAedHkwV9exAxhPdKkEHs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786179576; c=relaxed/simple; bh=k1jte4S6kmlNkWiF/TPSrh2PJp0JqoJa7csBL3XZxhw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FYs87s8uvKd8/Oz0qHQ4BDBFVcwoCbAlgXMFfcssuF828ewhaFXQnYmuJQBgEGPQ6UxoCEFkgwN2IrdoLotmu8CBLvnwTUZgyeDLgfrnv6rbCpGaQjD51xHWB2gl+zYFiqVfo1WvUtE/miWZ7V5LiEtW9KE2yWCAEvMJT3aeyf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wrg8I+gV; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wrg8I+gV" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ced3386430so4421215ad.1 for ; Sat, 08 Aug 2026 01:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786179574; x=1786784374; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=n/y7c/4lG8eevhNAw7vtPbWQQOLv7HTFTCbAr3jVwm4=; b=Wrg8I+gVL904edaMJxaKH+QL32pIWXbPwVMQNuYbQAVrI+fUEMsA7YjnudjQpfuWBu xvu3zpDZd0AY5HlP1KXvNloa0/e7Onod+QBQNTRIABUdA720QyRkHn0W6E3H7Uqmo55O gIsekM4GFMWJpig09+r1EvrmrOcD2ecqp/Qc2nx/CX2bmYM9Z4YK6gjkp2odap6Waq+9 LaGckMALUOXNwRpFWF6TfDwzi0MqNmRSEpkoWUM03uYrXOcfoB++TOROWNKpArP6Wx32 DafC1DNBSbO+AgX5VrZWoGtE5MMTjZKsXqS0zEtPVkrFi06DxNS2LU8R2/yQ0vlOc/x4 oYPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786179574; x=1786784374; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n/y7c/4lG8eevhNAw7vtPbWQQOLv7HTFTCbAr3jVwm4=; b=avFuhdoeKw39/Hq8/YpskoxMHalm9mrB7hVwPZzvaLESFoazwl4tWOb3MQeNJo0syE CXto8JoSwrwfT5eaOwp/gzPBU++zVfFaY2KURbjD0ZZRMT8d76bpfCcPblX1NncPY8S0 0xwBcUBABdQ9dPu2SGo+37YBsjP2RX5YU94EPRj+kc7d36sF9y4JldaCsAC9kzVWRKnW 1QZFdVgCC1VrCZCa145lRsVpfwiSgc3k9UJBxA1JhmPs3D/BA9wLvaLDDmagfn5AP5s5 L6VICsfs1My76m47NX3YtBclA8cigZMAjIyqAqXQz3vZY2kHisqUx0bOcDt4MHnwO1hn zyCQ== X-Forwarded-Encrypted: i=1; AHgh+RqcOop9XX6ybt5vpe3CDR4yeRDXJkGqrX2LJzWd17IZ271MeYBcX7oZgp6mYM0SgSmtMRjTFcwQV3qnkU0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7EOU+Ejy78Inya2aq3LocRIsrtjqO07S08AhekHtF10paglqz foSuFgnym1NPnMq7OZWD2ASeFZ74XZvt3M3H4jAiAFkMUeMReix43KpQ X-Gm-Gg: AR+sD11TR6KbeZzgIKUOsR00+8Z9IsC9Z9ak0Jz4DTAXHiJS+tZXwKPfvwIkc1oSw1w tL3+i7hf57KTYGYiCFUpP0bwZvLrmGBdYrRrDdwhG4oKGZfxdQYMFNnZguin1b+GXNTHeLOJzsS yLOARk11w5oyLzfRXI7ThNauNLqzDGtGDFM512X2Qvbd3G0CQMm7UbMAlAc1JapFTRiWzty6J3J ldMBVPdUhuQgRTjJVaIOEHvElIDqxUysVwughojv2CySdXE3kj4q5oZpYxR4/2KjMaizKUyCiL2 z09nN02gM67vJB3+xi6PT/FEU424y4TB1K6GYXPD28C7U551UZ84CR2Ihm8kozn5CFOSUN+G+4F TySVkBn/1o7oU8A8IM/LdDbei4zQbuLTo6RjlK0MVrEKs7SMKW+ZMyGVFZSq++tFS/Y9iAAU8GP vn8YX3/uK5rHeune8Zutb141ctwNzgY0lNm4A/htk9XuU= X-Received: by 2002:a17:903:37cd:b0:2ca:d9b3:715e with SMTP id d9443c01a7336-2d294b4b5b1mr126407935ad.9.1786179574331; Sat, 08 Aug 2026 01:59:34 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d16c4a6db2sm17431155ad.64.2026.08.08.01.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 01:59:33 -0700 (PDT) From: Guangshuo Li To: Corentin Labbe , Herbert Xu , "David S. Miller" , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Eric Biggers , Guangshuo Li , Arnd Bergmann , Maxime Ripard , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] crypto: sun4i-ss: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 16:53:37 +0800 Message-ID: <20260808085337.2715506-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sun4i_ss_pm_init() calls pm_runtime_use_autosuspend(), but the autosuspend setting is not undone if pm_runtime_set_suspended() fails or when runtime PM is later torn down by sun4i_ss_pm_exit(). If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during cleanup, this reference is not dropped and usage_count remains unbalanced. Undo the autosuspend setting when pm_runtime_set_suspended() fails and in sun4i_ss_pm_exit() before disabling runtime PM. This issue was found by manual code inspection. Fixes: 554c42b4efd4 ("crypto: sun4i-ss - enable pm_runtime") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c b/drivers/cr= ypto/allwinner/sun4i-ss/sun4i-ss-core.c index 35ef0930e77f..10c0f05994ed 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c @@ -304,14 +304,17 @@ static int sun4i_ss_pm_init(struct sun4i_ss_ctx *ss) pm_runtime_set_autosuspend_delay(ss->dev, 2000); =20 err =3D pm_runtime_set_suspended(ss->dev); - if (err) + if (err) { + pm_runtime_dont_use_autosuspend(ss->dev); return err; + } pm_runtime_enable(ss->dev); return err; } =20 static void sun4i_ss_pm_exit(struct sun4i_ss_ctx *ss) { + pm_runtime_dont_use_autosuspend(ss->dev); pm_runtime_disable(ss->dev); } =20 --=20 2.43.0