From nobody Tue Sep 29 11:55:25 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80793308F03 for ; Sat, 8 Aug 2026 08:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786178190; cv=none; b=Qv3T/pZOj+UIJYIFWvEWfyozngdqnV+82wLVYd/TZCpuaNRavJW/wlDMoGyIMpkjCL41drsWkQBz2smv9NcH7d8pWhyOFogN8ElEY1INTaUncXcm9dLC35HNAkME/059/qhI3Ha5JCXNlAUU2LljMSDwUWzapIYJL8oysFdGd2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786178190; c=relaxed/simple; bh=XJ/DKreYFvcZTMMtcuxtj6GX3d172qVUGH8mKiop0OY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W4iBiN6SyYZP5+GNvPy7zx0x3wepgLRlooCYXmuvkD1IN6xS5u7l5zivHLWT6H5fShhpc1ivjAkry2NtwyrdLH4Z+aqrUYU/so4cUJTOuU0VwnBnOe3kU2MknfmkbmQRUSXAhl1rWHQ1LxfvD+vUkK9kg+rFS7ZY9CaodM/P2R8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nLOCE1vi; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nLOCE1vi" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cc7e86e7aeso3148065ad.2 for ; Sat, 08 Aug 2026 01:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786178189; x=1786782989; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fdduiRQwuJsbrhFMnqTIsNuHvHg3FoBhY9JFBlVgCRM=; b=nLOCE1viDMM9gzwnbKjMFFQOKB5juXEd9s7/qX4kIlDlFHtLN2xFngNLpbdeK6gCKR frNRDXApB9so69IfVdu/y7TwhuOEUc1UYrMcsDg613fW7DtZTNap/btZdigNiphkwtH/ NXcu5RqeEx6xNc5Q635BpM/6Ye7QYwvFQGRKXEJ4h3nSX4wVaS+D34XKNxb9N744zQKA 5G/P+97/7GQt3TlIFY8OuKp1Azg713ypDPgQzWaITFFcQg1wSPK3BniPVXRTDh0tpJUH UlRUUJza67t54S4ZgZzIxFxhazZBUkxQCac09/46o+RHKg3DUdsgpSD8A7PFtcBMh0Dd Nn0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786178189; x=1786782989; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fdduiRQwuJsbrhFMnqTIsNuHvHg3FoBhY9JFBlVgCRM=; b=GB7LUqriaIMHfOBLWF13llg6mXQND1is1MT89giR06eYidQtvmutQ9kL7Jkgq7FBwr zHp1IuCeOPqc2HAwJILJQbQtkXqlzrhOzqaiEvHkDEYQXhVd0GUcu+zLXhZ2XPPROJq0 rkIk0+RcbgSiGUoBbzigrBbi0DP8MQCH3AwmegaadOsdxnWi87v6uyevzsBumDE1KcKN NBR/ocJdw/4a9/f8vG/QerhiHA1hXKXNzwijoBS8zbbJ61MS/McjrRwZkh1uiSMSxK0z FSoZq28sqrkJdM4ULPcv8yfQ3MEiQh5a2SaVvusb3/WeyM/IheTrkFSSP8ENMhQBgFnQ 0pAw== X-Forwarded-Encrypted: i=1; AHgh+RrLRD/AWQYvWXNFulMAWfVU+uS82d+BmOGE7/jBuA0HdjBYSZffjt2LaLcERXZDz4TWrgF1IXvSACfiqeI=@vger.kernel.org X-Gm-Message-State: AOJu0YxCMy6a+PAGb3TjDJXFn+7jLwSqTk6dnK7+70wuM/jpTGRECIZ5 5KnKnAZPAy8pLZpVCKTJZpjYULvqZa41lXqICiKjDDmP/sSFn9b35ATy X-Gm-Gg: AR+sD13o4GtZQGFOHfbfkNLeXvACWTR8Ub0+YIR4DdUxnlqRIHe0GLj5qX3cKyvjI4W nqua5CZyLf+ZhExGDt+NNoZdW2IFAgv0GCfhvc2CO9Ryipk0pTH4bOErtwMj3zkhg1QRRStm69A 8eXue9CyKdOaIifVuvko4UyqQXOxzfQj3WB5fKP22l+3DQNxxuMzr5pooN23jh2XOJwONPoAT2B JC4mVN+a8QFzY2vV8JJ0DaF+c0DpK4B2CGNzW7Az+b4oqW2KDxLq2GwCHsQoNw550XJAe5cUJ8S QVkCTpHud3qeGPryrDz2D1BEQetF7xMGeF1msmP4oiHsbRC8PxII8OrsIrD7mxnFnBnFyT8cf5q CBhcfhnZOvIP54F0z2/ET8HcCpsOos4s4CHmuV7iycSAtq88d5UhKLh83Tus9ZKkoXK6/XmFJj8 CSwOz4a9hAGuhCL7eY8rnr0cnR5qEwiTnpHMloxsEY/GRbEUkCjhoLLT4Dlw== X-Received: by 2002:a17:90a:dfd0:b0:38e:5ab7:ce9b with SMTP id 98e67ed59e1d1-3909d928d54mr15940827a91.21.1786178188696; Sat, 08 Aug 2026 01:36:28 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39086164982sm7682051a91.16.2026.08.08.01.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 01:36:28 -0700 (PDT) From: Guangshuo Li To: Herbert Xu , "David S. Miller" , "Mark A. Greer" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] crypto: omap-aes: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 16:36:12 +0800 Message-ID: <20260808083612.2698779-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" omap_aes_probe() calls pm_runtime_use_autosuspend(), but neither the probe failure path nor omap_aes_remove() calls the matching pm_runtime_dont_use_autosuspend() before disabling runtime PM. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped and usage_count remains unbalanced. Add the missing pm_runtime_dont_use_autosuspend() calls to both the probe failure and remove paths before disabling runtime PM. This issue was found by manual code inspection. Fixes: 5946c4a5e770 ("crypto: omap-aes - Convert to use pm_runtime API") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/crypto/omap-aes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index f31555c0d715..a6f5a689fbcd 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -1243,6 +1243,7 @@ static int omap_aes_probe(struct platform_device *pde= v) err_irq: cancel_work_sync(&dd->done_task); err_pm_disable: + pm_runtime_dont_use_autosuspend(dev); pm_runtime_disable(dev); err_res: dd =3D NULL; @@ -1269,6 +1270,7 @@ static void omap_aes_remove(struct platform_device *p= dev) =20 cancel_work_sync(&dd->done_task); omap_aes_dma_cleanup(dd); + pm_runtime_dont_use_autosuspend(dd->dev); pm_runtime_disable(dd->dev); } =20 --=20 2.43.0