From nobody Tue Sep 29 11:19:37 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B34743AE18D for ; Sat, 8 Aug 2026 08:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786177914; cv=none; b=Zh5RlUW2yTJatM8B07n45UrcfADS/uyh+Fh3ESiWoakoA3KQ3EO+hmqbjZ9t6PowYzwxQeHTIH1vhDyzhXUE+KmvRdHok1aXgsBlV5KVNSanCq0rKQhrJbCme89Qkv3Q6N8p37DkvLvaTpsVZI8xCQjlE7z/5a3k40VStPRTAW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786177914; c=relaxed/simple; bh=db+z0vzvh2BQdKuvYbDdNDQvp3bZssbayao5QvGWyjY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=F+VvP57tZq8Z5D+5GDO11a6k7UvqRXKpokBgj1BSVo0gX5PZajdBYPUzHFCLP1VfTFhVKO0FHlVMyz8+V3slPgiD8piCwUtZKK2agSnLf2yO+S1nsEst/zGw3fLhZkYSzI1WGxOzFzLIYM9i1RUkKOxgBomeX4pFrW7t27jUPxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MCN67prM; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MCN67prM" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e69bdb0fcso284844a91.1 for ; Sat, 08 Aug 2026 01:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786177913; x=1786782713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=VKPZin59jcLEgsj7vGd6U8AiKKUkanMgykS2/LGEdhs=; b=MCN67prM4Elkqg3Xn2YbkpLf71DQrzNvLmM0vC3rYlnzOzh2My3Mt22B4ogxxvkW8x 54W5i+7CEQ5qfEDdG+NgzFEdAlVDv9ShS/dbSsGCinc6ywL4/PdDqX9VC3KWUGVvPvRQ 8B1WTIOCnzvSGwS4AgGgiH15AggrJvRRiJw9t/DnqldlcUg4GYxdtCVg0EVUKzHrNixo 0qJptRckdkscUYpxZhl15GhGtkxPzo+ybKHN91j5Z+Ek9ahlNDRk1wLQZ6bf/IHAI8TI PzXAiGS6ziWRbE2n6knUeK1PK0ubq8M4HqplZJkI6gMrv9avzGj+2aZidrRcanRiElg2 C9oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786177913; x=1786782713; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VKPZin59jcLEgsj7vGd6U8AiKKUkanMgykS2/LGEdhs=; b=OjfqfSmoNROchaug+2blaVD69QCkL8wBVgMMDjxQhlq5Z8OFAWRjNOn+wUGGF7UNSA o+vp5N4VNRzbTB14vosmPeuCkhWqZcWpDwQpynuEfSZOgYEZU3Miu7dXzuwibKMmc3vS ZI29A1mRcD4Y6KdmmMydGXX8GdLoXb/sy9+x8vOxCrC7R3rylPyxeRg0MdAd3Z4kJepq UrArlLesbThgsd5w//37rOA7Ss/tRbvKuSTXVoXSZNLvHaJ0bxK5dP/kDXWhS9nIH8XE UZsNADHcmCtOXIcAq4ij/czF3DLUgLtIATCrG9DPwMA06IHt3uupnH7FyR5UA98q0vWB +PNg== X-Forwarded-Encrypted: i=1; AHgh+Rr2/exEMG+AD8AnQMlGPmvA+hySqozjlF810bKIQSWpMVDt/gFhy8d6060doEaIbjh9y9gD8lpMW23nqDE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfy/xmDCQJv41DYbakbtmL2hdOmfdj5eC3+O1ypPYKrQ2ZDzOZ 6j+QKzeg/Eax6fyWZ/f3qDuy13eeZtmmCIjsWYfwhEHDFHJAYfL8rTbo X-Gm-Gg: AR+sD115sGw/Sp4quon1TwRBS0ZUac3iMZa8O0fW0OLQvfFnzeeD6G2E9b5Kw4Lhpiv hZtLGaAXKEb023jaig5BxoAQRS0q6JZmBg4eF56M0y3hj1k9Cp7qTO2/GOIRVMnF3rJ6H6QPk8I pWbFqib8bCXeGV+C8TdGP2CZ78JasOddQ63z3U0ZjLOhseBQjVPag+aA1Op6vy03tJu8MSya7a4 huSB6G82AAZeY8cyjjf9YLiiUN/QbRWU67CQrkKZX5Jz58TpZkWPndN9Ou7CZv2HRwKzXdpNzjw sQUAVxhV3g25qR21BmGg+wg7kPXjclhIbUqARrfV82cgvqMx5jkXCwh8ElFfdjpTjW8INT2Opeq JCOuhfGdrRGZXByxS059o+/XeMvM/Qj+SLDPWRFlH8mE11HoDc5Za2w78pg5fDIY7JG7wUv0kTe hFbWM4sTuSCRoB0cIi7Ub2Ob3YEMc27ElNFN9o/qBGzCE= X-Received: by 2002:a17:90b:1d4f:b0:38f:7f60:ba35 with SMTP id 98e67ed59e1d1-3903c5381d6mr27967961a91.5.1786177913049; Sat, 08 Aug 2026 01:31:53 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39085de9f6asm7623040a91.7.2026.08.08.01.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 01:31:52 -0700 (PDT) From: Guangshuo Li To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Brian Masney , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dong Aisheng , Shawn Guo , linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] clk: imx: scu: fix autosuspend cleanup on probe failure Date: Sat, 8 Aug 2026 16:29:33 +0800 Message-ID: <20260808082933.2692878-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" imx_clk_scu_probe() calls pm_runtime_use_autosuspend() for non-CPU clocks, but its probe failure paths do not call the matching pm_runtime_dont_use_autosuspend() before disabling runtime PM. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during cleanup, this reference is not dropped and usage_count remains unbalanced. Add the missing pm_runtime_dont_use_autosuspend() calls to the probe failure paths before disabling runtime PM. This issue was found by manual code inspection. Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/clk/imx/clk-scu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 9b33df9967ec..6d29fcc2306d 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -542,6 +542,7 @@ static int imx_clk_scu_probe(struct platform_device *pd= ev) ret =3D pm_runtime_resume_and_get(dev); if (ret) { pm_genpd_remove_device(dev); + pm_runtime_dont_use_autosuspend(dev); pm_runtime_disable(dev); return ret; } @@ -550,6 +551,9 @@ static int imx_clk_scu_probe(struct platform_device *pd= ev) hw =3D __imx_clk_scu(dev, clk->name, clk->parents, clk->num_parents, clk->rsrc, clk->clk_type); if (IS_ERR(hw)) { + if (!(clk->rsrc =3D=3D IMX_SC_R_A35 || clk->rsrc =3D=3D IMX_SC_R_A53 || + clk->rsrc =3D=3D IMX_SC_R_A72)) + pm_runtime_dont_use_autosuspend(dev); pm_runtime_disable(dev); return PTR_ERR(hw); } --=20 2.43.0