From nobody Tue Sep 29 11:19:28 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78C6C4B04AF for ; Sat, 8 Aug 2026 06:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786170806; cv=none; b=OoeaCBCKXp2yAcwS/k8oLLJ6GvgdPCCla1pvVbwVuLKR31eu1bWKmQwEMb7RDtnRlxoTfFuvIDvufOrxQcDHt2hOsknn0EX5+G3cKAZNxsND+G0SHaavLw8waaL1FDUOPnHVxWdpPewZk3llZXB2HNG3m2NIfKEu3JaQRPrTgSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786170806; c=relaxed/simple; bh=1jFuc5tI3BP0vqwDzPn71TFCIAID12sy0Tl2c1q/3Uw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Pk96v7vDERhg3Gh7LZlkDmT9JYP6apcqfsxvED9YBx2utrtVoeP4rhhLNGdwC/xrL6ihAqTSSup++UPScs3ufHc6pYgn2hLT/6TdZVXhzRR5oiY0cUxEWMlhKku+Netz/er0rO0YDtl39uBS2YzVms7Ax9bp8hHUkqvT1Zpno1k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=bEpmm7yp; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="bEpmm7yp" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2d02b4c3601so3239145ad.3 for ; Fri, 07 Aug 2026 23:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1786170805; x=1786775605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=EVfLKOBoXlsoQX+adLzXxBoyONh9CYzhxwPG0dbz6v8=; b=bEpmm7ypd2Mi3BGr9NlyaFFvXOM2Hlz4wZEEKP8vlEkksFw+gaqp/IF2H2bNEzAOz5 guuooLvd6fnX5YI4Al37vum/wTmx+taPw6AMQTiJyylFSPwFuKKeeiz15jBmKJSTWnsg 2Dnd/mihge25LABEQVgKiQ6156BaRutmQZQzwRYtZBxZkchykaMYfJF90wq7ZetsurIe ZIqLlSHwfDTrK8qqdQ2tYJw7pyi6qVJaeyNgPMqokQLfBC1iGWIb5YEjEkt0xkI6x0Ln DDwh1192amcvTg2fsb8qRHiLmJV4WLVmefjBQt5TOP5+//PW7tqOcX/i2L6Hh469Xjho ffTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786170805; x=1786775605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EVfLKOBoXlsoQX+adLzXxBoyONh9CYzhxwPG0dbz6v8=; b=DKce8wO06Bm/FhQe3gh8egW3bmvJf6cUbstWj3ofWZ1QLj7WGATLlFaQdbmqMBg2YF rFr+x/6nB74NSpFYXsGrzhjft64EMFgdpO049k4wQTBPLOMzwQuxB8b06Ko8PQV9NCCJ 6X1suPkF0B+hWYV/dbZVzueIWuZiMK029cn0ZWZVIFxP8p5fsEhBI73DFgb1Ax3JNasn QKyl21GGfxI3pcF5rjFJX8Kalf/NC9mJCP7F0HRNBrrrvBZcKvglvtXfYD6l1mtBh80w hcPnqgq5A8N/yjT8OxAdJmFDJArCT01VZR4w2/oOnV74Q1+5MHKz93YL2cFM4GRtIz4+ 5R9Q== X-Forwarded-Encrypted: i=1; AHgh+RrbCbfQuQI2CUpWBvz6crLc04fIKEg9bfOPFkHPHfS92eCS3OIXfJER+8NYsPOFPR/Lkc/ibuhC/gJpvDI=@vger.kernel.org X-Gm-Message-State: AOJu0YwPthU7F5LpU+Tt5+nB96P1//dssb5papWYdcj89luBG1saGx/X GvOagGNnqeeoSfshQ2V56GWYY6RTd+emPW481IkhPWhdEVfSURaCF9iM/fvZBYqRqcY= X-Gm-Gg: AR+sD13EoEkVeupjfrE7yeOMX9Ry2gvK9RfgKt1ZBffWuAL46bF/1jU2/TFEG0hsCS0 I7ZC55zHP1XCutH0TUGjxkPDPtp6pWfGZxqqJ9/f9lXSldTvibhgRo/46zldlJDqeI31BK6+roI yTFUDRUGDUHMM8QnoM4ab/KUylHFZgUvWVMsHLcFtZvPJNfTrmpc5PWblS3f46mkYUIyfdWN8QX 04gU6y5OBxesfaL5Uuap0xnMen2PY4ghA6Uj4pmRbE/eEw5bbvoHaqw/Y446hognlCDfVhX2x9n 8HYbA+l/nvGnou8mHlur6e9wCc6znFXyX1NtIkwNpUCLzcL9fGM+9s2OmDT3Vb0r3IPepvvrpQR l95gkDcAPxbUlC/esk0IdHMZB9fN4fleyLb/aV+8sRnxQsVsQlNCnqH0K6VyfOmB9rVc/QonsIu 4SHLBOgRdogNQV2yQOYXfGMJyHRlBjCQYxucBvp8LPFOP/U/UFyrtCR7E2CU47gN/gJVLl3SqcE NG7uPZhYeE= X-Received: by 2002:a17:903:1746:b0:2cf:afe8:b722 with SMTP id d9443c01a7336-2d0ca761e0amr323978905ad.11.1786170804803; Fri, 07 Aug 2026 23:33:24 -0700 (PDT) Received: from hsinchu01.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d16c4a35c0sm15983645ad.63.2026.08.07.23.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 23:33:24 -0700 (PDT) From: Jimmy Ho To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Alexandre Ghiti , Hui Wang , Ben Dooks , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Jimmy Ho , Samuel Holland Subject: [PATCH] riscv: cpu_ops_sbi: retry checking if CPU is stopped Date: Sat, 8 Aug 2026 14:32:41 +0800 Message-ID: <20260808063242.20178-1-jimmy.ho@sifive.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a retry loop with a timeout to wait for the HSM state of the core being hotplugged down to properly transition to HSM_STATE_STOPPED. Suggested-by: Samuel Holland Signed-off-by: Jimmy Ho --- arch/riscv/kernel/cpu_ops_sbi.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/riscv/kernel/cpu_ops_sbi.c b/arch/riscv/kernel/cpu_ops_sb= i.c index ee6e4b5cc39e..41e577400591 100644 --- a/arch/riscv/kernel/cpu_ops_sbi.c +++ b/arch/riscv/kernel/cpu_ops_sbi.c @@ -5,6 +5,7 @@ * Copyright (c) 2020 Western Digital Corporation or its affiliates. */ =20 +#include #include #include #include @@ -87,8 +88,23 @@ static bool sbi_cpu_is_stopped(unsigned int cpuid) { int rc; unsigned long hartid =3D cpuid_to_hartid_map(cpuid); - - rc =3D sbi_hsm_hart_get_status(hartid); + unsigned long start, end; + + /* + * The core that is being hotplugged down might still + * be processing SBI ecall hotplug down. + * So, try again a few times. + */ + + start =3D jiffies; + end =3D start + msecs_to_jiffies(100); + do { + rc =3D sbi_hsm_hart_get_status(hartid); + if (rc =3D=3D SBI_HSM_STATE_STOPPED) + break; + + usleep_range(100, 1000); + } while (time_before(jiffies, end)); =20 if (rc !=3D SBI_HSM_STATE_STOPPED) { pr_warn("HART%lu isn't stopped; status %d\n", hartid, rc); --=20 2.43.7