From nobody Tue Sep 29 13:18:55 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CDE039B94F for ; Fri, 7 Aug 2026 19:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131668; cv=none; b=JFSDpYXb2rdT5T4bK71+5o3LStY9rgt05ewD73/7N5K2NTOMd49i8LUo24DiZrdIlkmzU+EjYEaSrXS8iMZHs+OTgHNxhl+alqlRdMNJKnrPflzInmE6Qpva55oK3TSaQnhMvc/rtSpy1KJll++16ZaW5KCPmp68dua269zgQo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131668; c=relaxed/simple; bh=6MU93lD7oPCvVgWA1NeStXtYPktufCBo3mj6HDbyAGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=emeVyerz5mopM7DjqJCX1Bqf8bJJu48w7R2PdEaO5Ezw6PRXT/ftTTt3n2ycQdw0gMceMjlWZv0UhrUpMpMM3kDRU3MCpcEYMScw+faqD45q7G6exi/GzTk7+JqSGaTQXFQyUQQDaVtQ+oJUW+PBj9QZyPauQDfDYZ71/ns0dDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=wUNpIoqs; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="wUNpIoqs" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-92ed19f4d60so158646785a.0 for ; Fri, 07 Aug 2026 12:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786131665; x=1786736465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y08cvUPAERT8DtacgubgZYXObs4Ve5NXsThRcrzdsK4=; b=wUNpIoqsqglIHJWespfQvDI+wIzIueSma7+g7/CuYQcYlcbJCgQgH/upekBdu2pR5Z yT5FShjL2dbUziGTtDPjB9rC5JEGyiBDAhZrAfsb6Yi+vZUktlynnW3wcXJlRRKkITmQ Fv4x5AvdvFd9bq2ChPlU0ct0st17xUyNmdd/gkYIQdiAAONKlTL+PAHGr53Rvg6h5AwE fniFjAvZ4V/M39C/QfRXNy0S3FoLN9ZzdiTaJDfMcykm2uakjqREYAGnF/NtGseExAVu HImC/D13CuRTGRDC1w4ISttWy9kJ1s9GL8/98TH05tBbXeyRFKrM/ie1Fuj87P/nVSyS 70HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786131665; x=1786736465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=y08cvUPAERT8DtacgubgZYXObs4Ve5NXsThRcrzdsK4=; b=e5T7rERRP5JZfrS4Rkf/ICCsKCB/2u/Dra0YtpoPKDAS3IMycPgV1NC2JIUj/vNghB q5jH2P4fZYQkuOPNJrS8l8Qxm5BW8eoBaPDHMWoIwcfOYUFZa53L7IJ72cGChFtLR6Zy kWHXQpSJjShz1BBbDRf0wwVBunKkcsyXGA1SVeFrKnZv6GVF7fT2uXfLWJOclhB4Q1pY NtAzEyOivZ3q/NCO/Excb+mLupC1FnZBjPHz/+gNjM+sVUZMfmqIyj6x8J37xJs43XVY PMONAedB1jDmjBKyb17SfyA9wmgDKQ8batbpyyhe5mkHbcQAE1yYLkKh3DJe7BoZXeNK Z07Q== X-Forwarded-Encrypted: i=1; AHgh+RoaNOLVbVVjhf7WW/5213ieEePFIZjd/028dPrMB0fmlUMlW6gBM7dPzJzwk8Ckc3uiOiKYVVqk6BEm/S0=@vger.kernel.org X-Gm-Message-State: AOJu0YzPA0ou4nZFu0fpOAci3IcdXsOFVMdF3irOrv3ONrL+oVCauEAN I56pfR/nuFN0ip/wGB3RvWtaXrNDRrCRwcHYy7RcXTxl8HY4ppx5wW66yQDTXBePxFA= X-Gm-Gg: AR+sD10IwfbrlhEleV6/qvIPaOgiQskJ0zYA6Ca35plGfw3OnkUJbvNeXZVLBPuheAb F0ClzI60w64WLm0KlydBihGSZzEGio9fxackCS8O3wgw7Du2s6wlj9OtkhxKARIENgl5jITe83x vHLVSYLHJGDkm6rx+femRQM6eienw/EJfzCbmX65HR+cG7fbik/l848R5UV2OI9Gc54jiWW6ryP 27PK45KG8rPEZdJ5vZmFYtPYiBx4kX5tVtDNewTInqo6HIlkqz6zwWlLee/4WC/wrzH+sQdm0Z1 VxUpkfK+wA6LJw7B6d2FihsFjIqGFOc1/DjcdBNcHi+F6Su7pLobi43p5C3HLZEN7KdvpW6Sp3l +a9SCKJaagrsQtASsCcXAW6e66QCZPMOo3JxmjbrY5jHYjzA24Tv3R1zLgSbACcD74B3BjgyqfC /7rSFcrHj7zQUNIXIcc5RclYw9wp6O86kbiiotWiQQoqZn7ya+ifx4ySxDBOWJvtJy X-Received: by 2002:a05:620a:400f:b0:918:7e9e:de74 with SMTP id af79cd13be357-9367b699973mr103767585a.17.1786131665023; Fri, 07 Aug 2026 12:41:05 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9366e03aeadsm219786585a.3.2026.08.07.12.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 12:41:04 -0700 (PDT) From: Alex Elder To: bhelgaas@google.com, robh@kernel.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Herve Codina Subject: [PATCH 1/4] PCI: of: drop the reg_num argument to of_pci_set_address() Date: Fri, 7 Aug 2026 14:40:55 -0500 Message-ID: <20260807194100.455599-2-elder@riscstar.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260807194100.455599-1-elder@riscstar.com> References: <20260807194100.455599-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reg_num argument passed to of_pci_set_address() is always zero, so get rid of it. Reviewed-by: Herve Codina Signed-off-by: Alex Elder --- drivers/pci/of_property.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/of_property.c b/drivers/pci/of_property.c index 75a358f73e694..505226b876c56 100644 --- a/drivers/pci/of_property.c +++ b/drivers/pci/of_property.c @@ -52,7 +52,7 @@ enum of_pci_prop_compatible { }; =20 static void of_pci_set_address(struct pci_dev *pdev, u32 *prop, u64 addr, - u32 reg_num, u32 flags, bool reloc) + u32 flags, bool reloc) { if (pdev) { prop[0] =3D FIELD_PREP(OF_PCI_ADDR_FIELD_BUS, pdev->bus->number) | @@ -61,7 +61,7 @@ static void of_pci_set_address(struct pci_dev *pdev, u32 = *prop, u64 addr, } else prop[0] =3D 0; =20 - prop[0] |=3D flags | reg_num; + prop[0] |=3D flags; if (!reloc) { prop[0] |=3D OF_PCI_ADDR_FIELD_NONRELOC; prop[1] =3D upper_32_bits(addr); @@ -131,7 +131,7 @@ static int of_pci_prop_ranges(struct pci_dev *pdev, str= uct of_changeset *ocs, continue; =20 val64 =3D pci_bus_address(pdev, &res[j] - pdev->resource); - of_pci_set_address(pdev, rp[i].parent_addr, val64, 0, flags, + of_pci_set_address(pdev, rp[i].parent_addr, val64, flags, false); if (pci_is_bridge(pdev)) { memcpy(rp[i].child_addr, rp[i].parent_addr, @@ -164,7 +164,7 @@ static int of_pci_prop_reg(struct pci_dev *pdev, struct= of_changeset *ocs, struct of_pci_addr_pair reg =3D { 0 }; =20 /* configuration space */ - of_pci_set_address(pdev, reg.phys_addr, 0, 0, 0, true); + of_pci_set_address(pdev, reg.phys_addr, 0, 0, true); =20 return of_changeset_add_prop_u32_array(ocs, np, "reg", (u32 *)®, sizeof(reg) / sizeof(u32)); @@ -458,7 +458,7 @@ static int of_pci_host_bridge_prop_ranges(struct pci_ho= st_bridge *bridge, /* PCI bus address */ val64 =3D res->start; of_pci_set_address(NULL, &ranges[ranges_sz], - val64 - window->offset, 0, flags, false); + val64 - window->offset, flags, false); ranges_sz +=3D OF_PCI_ADDRESS_CELLS; =20 /* Host bus address */ --=20 2.53.0 From nobody Tue Sep 29 13:18:55 2026 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C333B14D4 for ; Fri, 7 Aug 2026 19:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131668; cv=none; b=l1ohmYixlhl1NePC4N1WctXmDAAltcfTif9vu5mnIMjGclWs6VOLMdv59UyPiACODzjRfdqJn2Vz45+BJocfWzvL5qku6oLY9QavbODrSWzVwgjYJusrNvi1qVfhOHzEXl221+aKzUYCEBwnFmyBmTxQuWDGHi62fGsn3u3hvwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131668; c=relaxed/simple; bh=BtmQtSAcOc1sMwXsSXHd/N0LJhsNzGr+XDlMMcgHhfo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kzHF4rQLJkMcubqj160jCChFS6ZR3qgTA2Tt0B1hvvLArdJDothvRsj90iZCR310qzRKHgYqrIb4Qy0rG9nFYsGhXUmo7OdXByxxLxBQI0cSP2my6H4EUZnsAeeXymKCutORMMTsrS6ePaVH1JtJj3/YOg5Sw+buFFc1nznoNk0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=ITG1RMGL; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="ITG1RMGL" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-92e6c4a867cso256121085a.0 for ; Fri, 07 Aug 2026 12:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786131666; x=1786736466; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H/KJ6sckLCdEVJDbpdFqbeYqPNdthT6c5yyUBXrsMRU=; b=ITG1RMGLlJNcT4N6D+H2zBvMUKVBItYJwkylrVl3kCL5J/vmB0tct8n7JTnGCoU6sD 6pZJ1W1Rjn27hSOxGg7C5i6QcLRzdNiCUAZQeN6FhDBjhX8EqksZ1Onbc20rJl2kObB3 1blCGNJatFXKyjSvd2pOn2a6cPTI8+h+xqDZtFjrUzpqpKjAcYZAgXKJNrwwmcWlPVwn meU9FcJnReiMtNTfT2pv27Zrhh4PHPpGDgQNYlDagiIWgYVKHke/lGf/BVcw9Tt8WYnC zHzjBmfRv6/xPm+jYNRRrcwBuIzSj3TqWQN8H9C/worxVkrllDdj7j43kP8sgfiNtjS/ wJGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786131666; x=1786736466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H/KJ6sckLCdEVJDbpdFqbeYqPNdthT6c5yyUBXrsMRU=; b=Hdb8TG1hy0Ujr45CixL+L13Sdsfii+tS93f8kOOlR/Eg0xSf9wqpWBBW7Meue/IHpn 0jTrIqE699aikITy1fqYwGWqLH9FTRm+GuloT3KMXu3lnj28bF4iWjvQ0c6qBkHV2G3c de5Y52P6Fs5ZO+S01K7GCir19+UcFAwOhH5mtAWBgBfLZ4DVYjHHVcMXJxfu41vsySQ0 2DEOKjFghEgxCnGcp0wjLa6MO3NZsHGpa3XQc3EX9Solc1g2QkhYLoHcuC02fYELbd2R D20Z7gzSKceQAJrma3Nr4eJPXmezxtCIjD/YULujflNc9b+ZCq3RIXoW+swznzLqddDB 6hIA== X-Forwarded-Encrypted: i=1; AHgh+Rpj+jYc1vKZkgOp/kDvkHZ/3rooWODBXCd7p1KXAm4nToIol0NR2oxrAxTaL3ThsHjnYHM3xLj+PXhNaZg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5Mp7vxRiHIfC6hdFdB/GzdlBiZE269m5EDtUqEaMm3U0FVBSC 6kXN2zkqV9d41sE4ByZxisz7BSZI559UgYtnuUigY62ZRFkCuXG38axh1TyGXKfAgK8= X-Gm-Gg: AR+sD13aWAbbOIZbFbgMArnL6K1mBuozW6X7mwMc+B8ylXbaWsxm2V+QX/NsPj4kA0B v0HJLAAPNSbZh4hxnlWYXc9WxgNK+WSGedShDNIjCSzycb15+MQqX4RgPEvvmff5TAqeYS6HRQN /FGf5czq5nQa/0n6UJgCd/kSl67iNjlXolh0M0CcVJYgX8EqWP7uEyT4Ta6BR/cKzDxlLbGMrjV wZo5yKdlxMO1xgZFsf67cJanSe/KslQO4pRuEgYOjIRIB98LYWt0ZZ/6PgfhO8X7yYemqSxl4z0 pLSWJH9q4A+v2usTAE+1FioFAjTZ8XJXNqdu59eaHTPSmr/dy3orPPMGag/mmflW0XRgMCyvUS+ VviLLZaema/3xG4sP4MfWMuFiLg80b7COVXQqaAjCxd1924i/Dd4JbCWp6Zv+yJ2pGctIf5TMWy yrWsheYMxLKIE08MtZmmOpi5JwR4AKFqMQe6KcXC28GGValQvLMENBg7s3o4q1wty9 X-Received: by 2002:a05:620a:690a:b0:915:5cbd:1d96 with SMTP id af79cd13be357-93671f1a852mr727400785a.33.1786131665987; Fri, 07 Aug 2026 12:41:05 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9366e03aeadsm219786585a.3.2026.08.07.12.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 12:41:05 -0700 (PDT) From: Alex Elder To: bhelgaas@google.com, robh@kernel.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Herve Codina Subject: [PATCH 2/4] PCI: of: don't zero flags in of_pci_get_addr_flags() Date: Fri, 7 Aug 2026 14:40:56 -0500 Message-ID: <20260807194100.455599-3-elder@riscstar.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260807194100.455599-1-elder@riscstar.com> References: <20260807194100.455599-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The flags variable whose address is passed to of_pci_get_addr_flags() is zeroed before assigning a value to it. Skip the zeroing and just assign it instead. Reviewed-by: Herve Codina Signed-off-by: Alex Elder --- drivers/pci/of_property.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/of_property.c b/drivers/pci/of_property.c index 505226b876c56..22fea1905a080 100644 --- a/drivers/pci/of_property.c +++ b/drivers/pci/of_property.c @@ -82,12 +82,10 @@ static int of_pci_get_addr_flags(const struct resource = *res, u32 *flags) else return -EINVAL; =20 - *flags =3D 0; + *flags =3D FIELD_PREP(OF_PCI_ADDR_FIELD_SS, ss); if (res->flags & IORESOURCE_PREFETCH) *flags |=3D OF_PCI_ADDR_FIELD_PREFETCH; =20 - *flags |=3D FIELD_PREP(OF_PCI_ADDR_FIELD_SS, ss); - return 0; } =20 --=20 2.53.0 From nobody Tue Sep 29 13:18:55 2026 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38911418A52 for ; Fri, 7 Aug 2026 19:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131669; cv=none; b=jy38p95C2zgGAgk2ewX4v0G8Gs9h/Qj63PP46/s72qbExWDwKADWSNLZ9yg4xmV4sxSpcWoQqilpXF5NoXAnU1ZDpKgLqO5eF5zZW+Igr55DvUPc1+0kIa/B2EBiIaHh6AG+LrHBEVVyircMrntycEPV4FGTo2AYNBFmAGgEqog= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131669; c=relaxed/simple; bh=3Jdw+CyC9X0d79MV1LbaD6UPSSq5mFOk7p6L7fDLBfs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AERP4ulvNU/XrJ8BCMT9h8hberSmepSEShc4cU0Ag611iuSpd8dooXfmeDfCTEgey73EWCelba0CyYn+MoH2nayJKqcJOxZMm0IE9j/qmdmJgaZ7Ox7IHE+XbimetrpN6PKKsRsdg72eXfUdxOqN9+ed/FYmZ7vsGGKEITxp2LQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=SrwJmC3v; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="SrwJmC3v" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-92e50a650a0so206704885a.1 for ; Fri, 07 Aug 2026 12:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786131667; x=1786736467; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9BzvpIUyox01epeMSGpQoUeAfJbQUXyU3IcN4aSet1k=; b=SrwJmC3v4OcSq0HV0aH3Sj3t8lfjmybJyzHuKh1lcR+obSCHYa8DN5m9B3G8wjxvB+ 79/G4cnZYd1CZrI2WZhfnhdK4NsiOP0nbBr26xb9GEhNRFpq86a7MRjdJgp5t1s6PC/B nHs28ZgehCt5PX4eG9BTmDkR8VpWR7casy2OhNt9QJ52uoWanUx0dKl5MFct9GbpWc5u Z0GnX8l9MhivnpS684801Uh7ZPiKaXvAXVWDY3Syu2Uj0ELbX/aghryz7n3/Y6KTNdBg 0lPSfKDZYE7fSR907cOvJvikRKambS1ZmYe9Bk4NxrPcE9R9YRrerKodJgjATi3IElTI WEFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786131667; x=1786736467; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9BzvpIUyox01epeMSGpQoUeAfJbQUXyU3IcN4aSet1k=; b=W2xOB9n+aS4HU9F2XoMQTT43acPm4Nn6iffC8sInI1WP1X8LFLM/OEv4Hr6qF9TAJ1 /68Q0qFxRqJBY2OiW7iTsPlIz+th4Smtwi08QcfFOpdgA3yEAkSdtWQ5MYFXg8WX15Pg ZYetphCJJp7KJxvVkJ+F9njTODRt9aSRdk5fVDVKlx9IY7oYX4R8qTjuscvo64gUvNWA VkuUrUu84mPiwK70PRT+8xvCCipO0dZ2MSFbD2oIdH+NoatfTdScZzn1VuoxI8YTbHS/ 0a4p99lf0MHXnasHuHoM5mAkWfzBUGn7hMP10C9TWYBMIMc2hDl6XoR+V773IXEr2WMB //aA== X-Forwarded-Encrypted: i=1; AHgh+RrNhuDT0INyk8ec4ARpOtE7k9EpdbyC3r7OPkzDj0tDd4fEjA6G3EcRCzMbWg8wtMFyDoVeWvfwS3GPgpM=@vger.kernel.org X-Gm-Message-State: AOJu0YyTCjHT0NS6F15P9/xmcARSjBVJW5axivRG2HMUZur4Ttx3WZOr bJgtIQYg6V8srKa6i6Q4CEphjw6qTnbNXUCfeGWy9M2+p5GNtjl/wRDwV/S9AggypzQ= X-Gm-Gg: AR+sD11VLkeF3/MfiGJTe0ccInH9TSk6+WlloPEzjWRXaPhTodQW1nk8gZgLGmQmjWx 5z1TQ/d3a7oLg7H8JeKfwcOzv8cICNOjK2N2y4r3xQi5sqD2gDqIfo0px5JQsVi9+oG0ru88oP3 lG8DgJsE5YIKpmUKwJts0yg29yvq0W7pEHVhFuzS2FIbeGcQw/fMvNt5Emwiprot8Bu6z7Y5aAI Pt1MuEzprhl2iZ+K2g2oElbYSShUexjm5hGs/KqZbhEqJiIszAfOf1eUry6Hoe9RlMV9/Pt4Tsw xtoWVaRLGlE4+G+LVVDEvPLYb53hGJKfZgunRABUK0VuJpwDTYdHxj4gOLBnttQUVUgkfReXLXF BFLkRSGcFbVmOTe1Tf5tSUc4l3/AX+HT3MzVHDOUpNn5UpR7UIHElEwd0wyJWFg0d/No/A3pNpv Lg6YW8Ks/bg11KIvjplCvipMjn+PqanSP52fz7thGaEp9B4maUTSZjsBMccrTX315qqyMkiYSiB FM= X-Received: by 2002:a05:620a:3d84:b0:92e:e376:cf97 with SMTP id af79cd13be357-936492cfa45mr1927632185a.44.1786131667145; Fri, 07 Aug 2026 12:41:07 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9366e03aeadsm219786585a.3.2026.08.07.12.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 12:41:06 -0700 (PDT) From: Alex Elder To: bhelgaas@google.com, robh@kernel.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] PCI: of: make a flags argument optional Date: Fri, 7 Aug 2026 14:40:57 -0500 Message-ID: <20260807194100.455599-4-elder@riscstar.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260807194100.455599-1-elder@riscstar.com> References: <20260807194100.455599-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The address of a u32 object is passed to of_pci_get_addr_flags() so it can be filled with the computed flags value. Allow a null pointer to be passed, so that the validity of the resource's flags can be checked without filling in the flags value. Signed-off-by: Alex Elder --- drivers/pci/of_property.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pci/of_property.c b/drivers/pci/of_property.c index 22fea1905a080..5e1820b8bb79b 100644 --- a/drivers/pci/of_property.c +++ b/drivers/pci/of_property.c @@ -82,9 +82,11 @@ static int of_pci_get_addr_flags(const struct resource *= res, u32 *flags) else return -EINVAL; =20 - *flags =3D FIELD_PREP(OF_PCI_ADDR_FIELD_SS, ss); - if (res->flags & IORESOURCE_PREFETCH) - *flags |=3D OF_PCI_ADDR_FIELD_PREFETCH; + if (flags) { + *flags =3D FIELD_PREP(OF_PCI_ADDR_FIELD_SS, ss); + if (res->flags & IORESOURCE_PREFETCH) + *flags |=3D OF_PCI_ADDR_FIELD_PREFETCH; + } =20 return 0; } --=20 2.53.0 From nobody Tue Sep 29 13:18:55 2026 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 596AF41C302 for ; Fri, 7 Aug 2026 19:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131671; cv=none; b=VT0Qq1DsXNcL8oHuNW2CD0ooyRZnSHJ0fOql6NlLN59mclJbhVSAGtF5fiFO/zzfTP99Urt+NzdsKjLGyrpgJ6LxxDccv1+T0ZIK/svILAqn+QoDkXtFSEtQlhjv/IaOXc6zQjbE2GhD8bIQ+kCeobXq/VgDyaj6dGDnp8hYUdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131671; c=relaxed/simple; bh=hYodWpM6Q4Tyn72orHfZl9z8/Z+iKh5TvYtYdhoeo6E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J63osM4x9Inaziq83+J4LLcBh+ZXINF1gQjKPoJ2TBAo5pLVRmISelAv6pEd8vZ4cnBBiLn5i9nAnwUEgEocCK/FHDfZbgjvgDl+ixn0UHYeCeIw8/xZqs53v3bT6haxCssCdfw8vwG9Z0xhLhRkfv9Zlhewp/Y3AaYcu64aVyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=WrPWGZVk; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="WrPWGZVk" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-92f03daaa97so222878585a.2 for ; Fri, 07 Aug 2026 12:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786131668; x=1786736468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Lvk5a8L0OiCM9CkB/Syketa1Mo3vqjoq+QWQ6ts5wyE=; b=WrPWGZVkXdqWXBz/ZklA2m313TxQpGsFomwzA+KqIivHpisMQ+c0er2tecJsuUpYqQ xzaRvDAQPcz3ieP5KOevdGVxnLnAvZp2xk0KtVKRwsmzJvaA0Zl4s0BogOPFqN81wUXk U+zVGssOl1NPJtzrMPXWVUx2dJwd7H96Uk7Xs0MrhZt0VkpbSg6myjiJlopsBDtCdysm MxrK+YrthLb1AB+/HtEx0TFsThgfaCHM7KDxe2GcKwygjHJG5cqQo40AozQp532c25Eq Fd6P/HrIAK81mq0sY05iPYiP0qzVBPStYnsjC+SgQX94CbpYN41u+u4oi15ENScRB3V5 /o/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786131668; x=1786736468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Lvk5a8L0OiCM9CkB/Syketa1Mo3vqjoq+QWQ6ts5wyE=; b=nGc5x2dCDgrMqVIsNOCBYWc3ogUV9lXVVW3EUQRllRI9EVMyJLf6Y/K+R6LkXP1i/m hkP+hYpq8O7Eni0EuwIaepzs+lWrsQOcauX5lj7rcdvMl/9xWaQ1KuNBHJWn7GMnFVro VEexZEntmnxIOm/kbpTWy5modk7NnGRyFaza6fuQnNqSeTIQ7Il1W6ot90FusMfkej1v NNvxPUHGUnzaj8eWciJfDU2pldLf5ntPxPOqvGwWDbDqlcXN/ZlIryhG4F7xbumEI9df LLkX+fwyJ92xhqkHr8kO+GVsZKpa4+tQSu2CiRpP962CWOQCoIzj31MX2V65BwIzWQF3 hPBg== X-Forwarded-Encrypted: i=1; AHgh+RqQkx2GM8PpIl2+wfknB7Ze3eXja+zDeGFso0EtrF0bjkKbwC1BaJTNHMi+pnQzQVxWEcQtNB7v6BCdVIo=@vger.kernel.org X-Gm-Message-State: AOJu0YyYBm6hXiBxwIF1Zhb35zgOlKYqGh73Ttktm8P13ztJZ0alIh1n VDys8bvKXUV3ptPQKqeAlYsQR+oeOAaLesLubS3hmq8Qax0jHOdmS+tyzwHFDjpYI7k= X-Gm-Gg: AR+sD13cR/sWYZQxt1s0mb5N/NrUDvkl7BI8b09x4AyJbCLhgPyJWPoSjcrvIEQxmZY +ACkGO0X8hVGKlXToRQOnKp/CE8Ccjohit/i0q/zo69znnfpnCrgAhVNm3uD3Y/NCC7mqiGBlBl 5SMQ73gezveB2zAZgdESDZa1p24OCTsEyOCMuXhnTpSdXvEoBqK/BApHR7F636OZOJsYuc8sgiH alWRhd+1Zglqv8OLTdn608dSonlPkQQ+mXLB6q5af29XHnZo9liObpvBE9RUZGZbILnvrG+uad/ ZLMr3yZhzkEbzqAhyHccJPwv9sVYq6b6dN+2cx1zohxz/EpAHxOcER1TtWQ4enStN4YZUw7PpOU tM5sYNa3hrgXcs6BqcE6kg/kaX1l7zuoDiNmegk9VMn/K+G/4kwszOsaDU2T3wCzYAPh+5xmsDV 12XQK5poFmlY77sj4mycTGlfGMxDhlQNKYojzu0G117d5qLk8N1M/LviQVYWQ0nZCmZpdih6N96 X0= X-Received: by 2002:a05:620a:2616:b0:92e:4927:1ff9 with SMTP id af79cd13be357-936491302dcmr2831301585a.40.1786131668128; Fri, 07 Aug 2026 12:41:08 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9366e03aeadsm219786585a.3.2026.08.07.12.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 12:41:07 -0700 (PDT) From: Alex Elder To: bhelgaas@google.com, robh@kernel.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] PCI: of: introduce of_pci_verify_node() Date: Fri, 7 Aug 2026 14:40:58 -0500 Message-ID: <20260807194100.455599-5-elder@riscstar.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260807194100.455599-1-elder@riscstar.com> References: <20260807194100.455599-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 407d1a51921e9 ("PCI: Create device tree node for bridge") linked the PCI enumeration process together with devicetree, creating a devicetree node for discovered PCI bridges. Its successor commit ae9813db1dc5a ("PCI: Add quirks to generate device tree node for Xilinx Alveo U50") shows how to use a PCI final fixup quirk to also create a devicetree node for a non-bridge PCI device. These changes allowed devicetree overlays to describe components downstream of a PCI device, by providing a place to attach the overlay. Note that the dynamic devicetree node is only created if the device didn't already have an assigned node. Later, commit aa7b4bbcb3a1d ("arm64: dts: qcom: qcs6490-rb3gen2: Add TC9563 PCIe switch node") *pre-defined* devicetree nodes to represent the PCI device nodes that would (also) be discovered via the PCI enumeration process. The devicetree node in this case is created with the content from the DTS file. So when a (host) bridge is done being initialized during PCI enumeration, no node is dynamically created (the commits mentioned above do not apply). Ideally, any pre-defined PCI devicetree node would contain exactly the same information as whatever the dynamic creation process would produce (though it could include more). However that is not the case for the pre-defined Qualcomm RB3gen2 nodes. And in particular, the endpoint (function) nodes include this property: device_type =3D "pci"; This is simply wrong; that property is meant only for bridge nodes. Rob Herring requested that a runtime check to be added to spot this specific error, only for non-bridge PCI devices. (There are many things that could be verified for statically-defined devicetree nodes, but this is all we'll do for now.) Signed-off-by: Alex Elder --- drivers/pci/bus.c | 1 + drivers/pci/of.c | 27 +++++++++++++++++++++++++++ drivers/pci/pci.h | 2 ++ 3 files changed, 30 insertions(+) diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 655ed53436d3e..679afbc6d3109 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -351,6 +351,7 @@ void pci_bus_add_device(struct pci_dev *dev) * are not assigned yet for some devices. */ pcibios_bus_add_device(dev); + of_pci_verify_node(dev); pci_fixup_device(pci_fixup_final, dev); if (pci_is_bridge(dev)) of_pci_make_dev_node(dev); diff --git a/drivers/pci/of.c b/drivers/pci/of.c index 8b18c4ba845cf..b51bb14857e9e 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -663,6 +663,33 @@ void of_pci_remove_node(struct pci_dev *pdev) of_node_put(np); } =20 +void of_pci_verify_node(struct pci_dev *pdev) +{ + struct device_node *np =3D pci_device_to_OF_node(pdev); + + /* If there's no pre-existing node, there's nothing to check */ + if (!np) + return; + + /* + * Check a pre-existing devicetree node for errors. The PCI + * enumeration process gathered a lot of information about + * the device, and ideally it matches what the devicetree + * node says. + */ + if (pci_is_bridge(pdev)) + return; + + /* + * Currently we just verify that non-bridges don't contain a + * device_type =3D "pci" property. + */ + if (!of_node_is_type(np, "pci")) + return; + + dev_err(&pdev->dev, "\"pci\" device_type NOT VALID for PCI endpoint\n"); +} + void of_pci_make_dev_node(struct pci_dev *pdev) { struct device_node *ppnode, *np =3D NULL; diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 4469e1a77f3c1..6c19895c14914 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -1265,6 +1265,7 @@ static inline int of_pci_get_equalization_presets(str= uct device *dev, struct of_changeset; =20 #ifdef CONFIG_PCI_DYNAMIC_OF_NODES +void of_pci_verify_node(struct pci_dev *pdev); void of_pci_make_dev_node(struct pci_dev *pdev); void of_pci_remove_node(struct pci_dev *pdev); int of_pci_add_properties(struct pci_dev *pdev, struct of_changeset *ocs, @@ -1275,6 +1276,7 @@ int of_pci_add_host_bridge_properties(struct pci_host= _bridge *bridge, struct of_changeset *ocs, struct device_node *np); #else +static inline void of_pci_verify_node(struct pci_dev *pdev) { } static inline void of_pci_make_dev_node(struct pci_dev *pdev) { } static inline void of_pci_remove_node(struct pci_dev *pdev) { } static inline void of_pci_make_host_bridge_node(struct pci_host_bridge *br= idge) { } --=20 2.53.0