From nobody Tue Sep 29 13:19:53 2026 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A47AE397958 for ; Fri, 7 Aug 2026 14:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113260; cv=none; b=XmtSR7vstnC3NYUssM8CzTON54zd9SosG7n49H5z6gtM3erIcBIE3lupGMdtF/pFPXcW8R8qkKmsBQ7vkFYurQsNgur0WfZpkX3g4foQ5ZnaoUM66+vX4+OdWCKCKdkFj3Rde5gMYN7IU2UYiBphcOV542g5BbZ1+2aw+9485bI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113260; c=relaxed/simple; bh=Gz+37PUfQjBhTxlf8dUwuqycMMWTGkhudr9GTfU3QWY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ewHe+jKSrf1/Q7QgK5cNXFwj/89bVF/OsJQ9LKAUKowefrtZCbg60qg3uar4acUOJLODtTsmiiRZlOYrMgpXsenUNfeWfTmWvIJxX5JBH6kz0eg9GEG+2KnLZQ1iL3w8nTcxduBo9GvyOEHxYS795r0DSDsoG9qX6TgwSgy6K0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gX4Hkv5F; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gX4Hkv5F" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-81f64e8dfbcso52393717b3.2 for ; Fri, 07 Aug 2026 07:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786113257; x=1786718057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=MzF/w9lvZNrmRnz4jgcRkPusnf5swWX+v3tY1GV4EgY=; b=gX4Hkv5FNEUk0zBAWfg3txjl0QKk73bIlAvqOqWMjVZvvagn3VYB1DjayCWa1Jio3K e+8G+OkpONXWuJ6IxR00VIIOo/4BlCdtlEqKfc0NsErNZ7EaU8TiE2x8H/nwESpDlQsv azx4aUt2zwsIvjsSxCWAKw5aJC2zPgvIwqLisJzG7Mx0ak7JyHnjGwRcInBwx+okDUdO W15u9NOzQSdoW51DEXJGqgbVJ0S+R7MeSznjTDd0Ub1MvLggej2ep6EzSEqfjr9jNpTD zngYYCxlU7JSffcg+Ms7oJ44thQ8pleO/bQng7h4mZKhNGM0aiN5rC6AOYJCFuk6UrX3 xmcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786113257; x=1786718057; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MzF/w9lvZNrmRnz4jgcRkPusnf5swWX+v3tY1GV4EgY=; b=Vyp5c0jxCvM87OT+1P7BgKL4gLb1tvDa6RKeUmaCd/pcJuqUPuhpAMWga/xhdSGOC9 mWkd43lpKXYivz96nLTtrA6UMVPUw+KOyMx6ft6EYK7WZdPqA1cwk7eHEYPY5dmS829S mf4NmZ2dzEOwfszpFcyjx/eEqc3piYSJLxbGgBdLkIaltAjZMcE5r9CS61Zpf5i09XLO ycvxcXrfS477kek0amGxkCsW1z/HV16ckAFReVBoty7/RORCxR43tF9y7OMuRmHZq50F 0d9fagqwuvmAhMvpGq9hA+Y0lHafe1kaRwLDU1oP34A2fmd3qbC4o/Y0pbJNCjvnMOxq zTeg== X-Forwarded-Encrypted: i=1; AHgh+RqWAriZQ+BzNv0+8zwRAk2ClgYnHZ5wWonbx5tloBFn5V51rwkz58mF2NBI8UK89yoTnfAcGJ4kTxVqQJc=@vger.kernel.org X-Gm-Message-State: AOJu0YzLFXYzw8nH3nwSijGf4llIhYLX8fKeswJEr1391V7SrNhYHzPl C/soO+ugxxdDDyHswxe5cVZr6rDhJ55PLvG+KS5FkGx+Am7SuMoR36b6 X-Gm-Gg: AR+sD11LQtm5E54WlRR2ox/WOEk0/L7z8heQpGu5HQQiAWPeKCICDThusEtfB0Y5R7B qNyMD3goUlTUHUABPG55NMRB0ZzVPRaQPtzxzhmwU0k2wQ2+loiVCmK8+hRAoL2nNBJ9KsXOij3 NISdilmji7XxGWETggRHq1lHykBu4cjZ2y0LR0svkeSqav781KiGUlLRHvrrV6gkfcMHFsxpkww X6aG7GAIimWW2aYyTBZJjaVaBCFrtKhm2jY505Y8JFurdJ5iISSkUZtY1+Rl1u8UPvE+jGl/icy SWVeaBzGW25JQn6S5QjjtnhXMmIPttj5AGu5TGQTkR28r+8nJ+HjA2nALjlOZ+DfuZuwdN0SyBk l05O+wfV4M51npys0WxFP9DRqtoi2FThv29iOJ43wkYR7miMLYz5p0c4i8HOwEbV4fdcveLwDik QLOBqAqu4PBWOWjAMOQpb/sra4IoET242NgtA4Un2voEs= X-Received: by 2002:a05:690c:4988:b0:81e:c17d:7b8f with SMTP id 00721157ae682-820229a0a00mr138806907b3.31.1786113257374; Fri, 07 Aug 2026 07:34:17 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 00721157ae682-823f6238b91sm10227337b3.34.2026.08.07.07.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 07:34:16 -0700 (PDT) From: Guangshuo Li To: Min Ma , Lizhi Hou , Oded Gabbay , Karol Wachowski , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] accel/amdxdna: fix usage_count leak when autosuspend_delay is negative Date: Fri, 7 Aug 2026 22:32:00 +0800 Message-ID: <20260807143200.2500342-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" amdxdna_pm_init() calls pm_runtime_use_autosuspend(), but amdxdna_pm_fini() does not call the matching pm_runtime_dont_use_autosuspend() when tearing down runtime PM. If autosuspend_delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during driver teardown, this reference is not dropped and usage_count remains unbalanced. Add the missing pm_runtime_dont_use_autosuspend() call in amdxdna_pm_fini() before restoring the runtime PM usage reference and forbidding runtime PM. This issue was found by manual code inspection. Fixes: 063db451832b ("accel/amdxdna: Enhance runtime power management") Signed-off-by: Guangshuo Li --- drivers/accel/amdxdna/amdxdna_pm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/accel/amdxdna/amdxdna_pm.c b/drivers/accel/amdxdna/amd= xdna_pm.c index b1fafddd7ad5..7dcedb7c105f 100644 --- a/drivers/accel/amdxdna/amdxdna_pm.c +++ b/drivers/accel/amdxdna/amdxdna_pm.c @@ -73,6 +73,7 @@ void amdxdna_pm_fini(struct amdxdna_dev *xdna) { struct device *dev =3D xdna->ddev.dev; =20 + pm_runtime_dont_use_autosuspend(dev); pm_runtime_get_noresume(dev); pm_runtime_forbid(dev); } --=20 2.43.0