From nobody Wed Sep 30 13:54:32 2026 Received: from mail-yx1-f42.google.com (mail-yx1-f42.google.com [74.125.224.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 518E12F7EF9 for ; Fri, 7 Aug 2026 14:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786112088; cv=none; b=gGdslprPeNQYxgLQbLCHbzH3Sr1F4ak3d3b3a/LtnCWfxejYGL1atNDfslHxSU/1FNWa01KN2otmRkAGBUPj/Jw3fdLIsjkVIMnAVjF40Ckqh9/UC/fddxCxVe4QxuQVBIYH7EvVUkZqqnmpx+SoSN7zS3oBrfngNpws5admWRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786112088; c=relaxed/simple; bh=Knm8/0lGHsyA0j3ziKYyldxu+k+fKuRAA2B0NxTdea4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MeMD55J5hyKE5GDekz/gKmhXcy0iirHuQ/pDVGp404SfjjgHz+iuBgPeO37VBejH5NAlidIsiAQsjHHoEH/rvCUpnYEcl4FXqLW0ZvfhFfoVp4YPok9acCfRQ3zy9shSxy8Xj/MnM5vyxXY++20stDOGltQFF7DkKJW01+DbGRM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vvm0dwwi; arc=none smtp.client-ip=74.125.224.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vvm0dwwi" Received: by mail-yx1-f42.google.com with SMTP id 956f58d0204a3-6626b5ace23so3208275d50.0 for ; Fri, 07 Aug 2026 07:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786112073; x=1786716873; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=SIQfJy+HLPz7V25SxR2pVr49gT2baFVuKZhhaKE5MM4=; b=Vvm0dwwiByE4YmeWQ8QUyyjV5lyLgI3c5OiKq8E1s1RrLNFyDnAA/NnexYPDJ7aQeD qeDzY2VjQfbHTJG8j+jN1n38G1IfZTosrjIq4OOrB1roq5EREMXDGRDgmN+P4GqBnsrC YOG1ZW4BPjRsO9LYoANGzSaVHPgMeOX30M0XcBACyryfJe0e3bYsRus9Xdg+gP88mQpa 74C5zTLXu9pq1hUCNQl6iBew4XGW+QbaPATCJxRwxavETt+vq7uNbjgsE3zmUikTMMHI 86JSQ4EiJfskAUomQKgKuCFVWteEr/9JYXowoNIOZEwi6q+fKUafURBFd11S7MNuREWR +kTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786112073; x=1786716873; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SIQfJy+HLPz7V25SxR2pVr49gT2baFVuKZhhaKE5MM4=; b=Qx33OVhKKz6e1BBIAdGtqeuo8EcpadTIs6Nr8ZW8Muw0trFAAOSMIQN6iRlcPekOAK GKomk86312sJQ1RbnKeLpPOt6QgcvXAfPUlRcKFHz10VVDDaoSIiYmt8e9NhNoovz/h6 /j3T0MhDxQ1TyafEz0oSpWn+5uTjIT2nPYJ/K+PSddglnaVgCZ1bffU8hS1LNf3cXNEL wIeZhbzVCktuyTTQDd5RPlkBGjHQSUmuMe21ZPcWKpx8cIBWPY4UU90NLc6VOgRB3MM6 vynAM/4BZ2b3KCjsJKNQ9X8wJeZV6b85Pp4oCeKToxaNB274fBEJ3tCtxHRjk+fW+9fz xnWg== X-Forwarded-Encrypted: i=1; AHgh+RpMZS2DW68+Q5U2MopnPxMXxE6t5SmzQtwlQhPj9Mq0/CZDH4fT2788F6K1KIX9gro9Gqiif5JHKvejQ+M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+YIM5kooZ/GUuZx/OLw7roxxd8nQfxB/WOPWbmLXxTPqAYKD9 eR18O2eMuEx/JkbjPnM3eh5/84SumucsuxKsKbdxDjgFeHG3XDNMvj11 X-Gm-Gg: AR+sD138y3hY8udR7xZP3ztc1PTC1dBXe0xp+kJV/OaAbq+GMjq+K2T0rmQtns8RNJw UOgukWIrT49o+JN1mjtglXQ5HHpHl64M3pUUWrBNUERTY9HFRvTVas42dUzvjpHsTbQkDLOXMVE 84/ds8fLDlWPmmT796cGzaWUkkv236XnUV7RQTrewJMxAJOrPjU9FYR66vCRwiC6Nfqm4ytTap0 n+y06aRpyGRPg/SI0bS87Uz7d6y1h8kChc8ohuK78abVO3bcOvNTnmXBVR++80ZIQAqJOJr0BLQ KbW2akHTYoZWupXQekkaiTcGG1OMc0c7IAQPlVOPk4VYF087X7U2DyKPgV9EC8MHiFQTpEwtrQI qoDR5CU2EkggHXczOajcmE0xyYcRkrDAfxgbgSiYKtkcfezQnbY9AuMdwCfuwslMZg5REZjrr0E QhavUCJNo0cUdgHrBH5ysly+qCzka+OOyO4uxXxPcOHyd6+xMihf+rrxD2y41vv/AE9GbZ+pMmb V1uQYPHABgKtUyI/BhHbvVU X-Received: by 2002:a05:690e:13ca:b0:66a:d7e5:fcf8 with SMTP id 956f58d0204a3-66ad7e5fd1cmr44586d50.0.1786112072589; Fri, 07 Aug 2026 07:14:32 -0700 (PDT) Received: from bazzite ([2600:1700:6e98:230f:5137:431b:a531:5024]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66acad53674sm1274018d50.9.2026.08.07.07.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 07:14:32 -0700 (PDT) From: Vernon Di Carlo To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Vernon Di Carlo Subject: [PATCH] Input: xpad - fix button mapping on Razer Atrox Xbox One Date: Fri, 7 Aug 2026 09:14:19 -0500 Message-ID: <20260807141419.7930-1-vernondicarlo@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Razer Atrox Arcade Stick for Xbox One (1532:0a00) does not use the standard Xbox One input layout for its shoulder and trigger buttons. USB captures show that LB and RB are reported in bits 5 and 4 of byte 5 respectively, opposite to the standard Xbox One mapping. The digital LT and RT states are reported in bits 7 and 6 of byte 22 instead of the standard analog trigger fields. As a result, xpad currently reports LB and RB swapped and does not report LT or RT at all. Add an Atrox-specific mapping quirk to swap LB/RB and report LT/RT from their actual locations. Tested with a Razer Atrox Arcade Stick for Xbox One, USB ID 1532:0a00. Signed-off-by: Vernon Di Carlo --- drivers/input/joystick/xpad.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index feb8f368f..b9daa334e 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -50,6 +50,7 @@ #define MAP_PADDLES BIT(4) #define MAP_PROFILE_BUTTON BIT(5) #define MAP_SHARE_OFFSET BIT(6) +#define MAP_ATROX BIT(7) =20 #define DANCEPAD_MAP_CONFIG (MAP_DPAD_TO_BUTTONS | \ MAP_TRIGGERS_TO_BUTTONS | MAP_STICKS_TO_NULL) @@ -280,7 +281,8 @@ static const struct xpad_device { { 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 }, { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX= 360 }, { 0x146b, 0x0604, "Bigben Interactive DAIJA Arcade Stick", MAP_TRIGGERS_T= O_BUTTONS, XTYPE_XBOX360 }, - { 0x1532, 0x0a00, "Razer Atrox Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XT= YPE_XBOXONE }, + { 0x1532, 0x0a00, "Razer Atrox Arcade Stick", + MAP_TRIGGERS_TO_BUTTONS | MAP_ATROX, XTYPE_XBOXONE }, { 0x1532, 0x0a03, "Razer Wildcat", 0, XTYPE_XBOXONE }, { 0x1532, 0x0a29, "Razer Wolverine V2", 0, XTYPE_XBOXONE }, { 0x1532, 0x0a57, "Razer Wolverine V3 Pro (Wired)", 0, XTYPE_XBOX360 }, @@ -1110,8 +1112,13 @@ static void xpadone_process_packet(struct usb_xpad *= xpad, u16 cmd, unsigned char } =20 /* TL/TR */ - input_report_key(dev, BTN_TL, data[5] & BIT(4)); - input_report_key(dev, BTN_TR, data[5] & BIT(5)); + if (xpad->mapping & MAP_ATROX) { + input_report_key(dev, BTN_TL, data[5] & BIT(5)); + input_report_key(dev, BTN_TR, data[5] & BIT(4)); + } else { + input_report_key(dev, BTN_TL, data[5] & BIT(4)); + input_report_key(dev, BTN_TR, data[5] & BIT(5)); + } =20 /* stick press left/right */ input_report_key(dev, BTN_THUMBL, data[5] & BIT(6)); @@ -1133,10 +1140,15 @@ static void xpadone_process_packet(struct usb_xpad = *xpad, u16 cmd, unsigned char =20 /* triggers left/right */ if (xpad->mapping & MAP_TRIGGERS_TO_BUTTONS) { - input_report_key(dev, BTN_TL2, - (__u16) le16_to_cpup((__le16 *)(data + 6))); - input_report_key(dev, BTN_TR2, - (__u16) le16_to_cpup((__le16 *)(data + 8))); + if ((xpad->mapping & MAP_ATROX) && len > 22) { + input_report_key(dev, BTN_TL2, data[22] & BIT(7)); + input_report_key(dev, BTN_TR2, data[22] & BIT(6)); + } else { + input_report_key(dev, BTN_TL2, + (__u16) le16_to_cpup((__le16 *)(data + 6))); + input_report_key(dev, BTN_TR2, + (__u16) le16_to_cpup((__le16 *)(data + 8))); + } } else { input_report_abs(dev, ABS_Z, (__u16) le16_to_cpup((__le16 *)(data + 6))); --=20 2.53.0