From nobody Tue Sep 29 13:19:20 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 951D231AABF for ; Fri, 7 Aug 2026 09:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786095973; cv=none; b=m9r2rgPKcfJuI4Xm0JT/dwS+RdAT7pvBQklLH5LYjrpuUIBieF6t1kPJBDAxelBCPsGinnRe5lQhIK2DcRP1UrL/9oXaFSArOAmJgQEdezOlRyIuvPMM+eAmjz0KGiAFVv+q7b0FymkDoes0Uz3uFdi784pkkPRsZmKRaYzNljM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786095973; c=relaxed/simple; bh=pp/HNxJtm2qgKpoVk0PTHkP9OBX+9Rk9zKwRGrNHuqc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ewSG5Wl2aXtmBXjTKdd/PJSNeCW/kQjusGS6o6OhrxKRgu4QPXoETwLDTh31MRysLLtYBYZjYeUJFPC+x1HliaUip7eVz10GNgv9o7Lb2l3kgMKA8Vk37ZzhJlZPRULCUN7lOqIkD22Z/rqv41v3fHmYCVfN0/zWzsM4Zlrg0cc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jBdVsiZ7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jBdVsiZ7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786095970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=y0QGvq8Xmf+ZVN6jXbeinSkN5fKa+U8pqjn+i2I6yBQ=; b=jBdVsiZ7eENwSFR9Jjan3UFV6Sk8XPtF+OHLQMvt1SI0VdQwYmLeamrMx9vUbhIn+gIFEd XBZVLj1igRi4CFe5ewfOn3UXTFn3mHlgjtaCTJ4S7S/6SmLLDX+1wTBvtf+pbCv79i4oKD GQ/RsUuABloN1wjIIEPEbqWPloZchH4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-tpeMzjC4OemFQwF7jmX1VQ-1; Fri, 07 Aug 2026 05:46:02 -0400 X-MC-Unique: tpeMzjC4OemFQwF7jmX1VQ-1 X-Mimecast-MFC-AGG-ID: tpeMzjC4OemFQwF7jmX1VQ_1786095961 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C3DD18002F8; Fri, 7 Aug 2026 09:46:01 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.160]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 60ED31956049; Fri, 7 Aug 2026 09:45:57 +0000 (UTC) From: Tomas Glozar To: Steven Rostedt , Tomas Glozar Cc: John Kacur , Luis Goncalves , Crystal Wood , Costa Shulyupin , Wander Lairson Costa , LKML , linux-trace-kernel Subject: [PATCH] rtla/tests: Test actions in absence of threshold Date: Fri, 7 Aug 2026 11:45:55 +0200 Message-ID: <20260807094555.1244103-1-tglozar@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Content-Type: text/plain; charset="utf-8" Commit fafb66e5903c ("rtla/timerlat_top: Fix on-threshold actions firing on signal") fixed a bug where on-threshold actions were being triggered even without a threshold being set. Test all four tools with an --on-threshold action, but with no set threshold, and verify the action does not trigger. Signed-off-by: Tomas Glozar --- tools/tracing/rtla/tests/osnoise.t | 2 ++ tools/tracing/rtla/tests/timerlat.t | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tools/tracing/rtla/tests/osnoise.t b/tools/tracing/rtla/tests/= osnoise.t index 214fd40fc610c..352b302372453 100644 --- a/tools/tracing/rtla/tests/osnoise.t +++ b/tools/tracing/rtla/tests/osnoise.t @@ -98,5 +98,7 @@ check_top_q_hist "with conditional continue" \ "osnoise TOOL -S 2 --on-threshold shell,command=3D'if [ -f a ]; then echo= 2; exit 1; else echo -n 1; touch a; fi' --on-threshold continue" 2 "^12$" = "^2$" check_top_hist "with trace output at end" \ "osnoise TOOL -d 1s --on-end trace" 0 "^ Saving trace to osnoise_trace.t= xt$" +check_top_q_hist "action with no threshold" \ + "osnoise TOOL -d 1s --on-threshold shell,command=3D'echo BAD'" 0 "" "BAD" =20 test_end diff --git a/tools/tracing/rtla/tests/timerlat.t b/tools/tracing/rtla/tests= /timerlat.t index 5116857d7da45..1d317c851a0fa 100644 --- a/tools/tracing/rtla/tests/timerlat.t +++ b/tools/tracing/rtla/tests/timerlat.t @@ -136,6 +136,8 @@ check_top_q_hist "with conditional continue" \ "timerlat TOOL -T 2 --on-threshold shell,command=3D'if [ -f a ]; then ech= o 2; exit 1; else echo -n 1; touch a; fi' --on-threshold continue" 2 "^12$"= "^2$" check_top_hist "with trace output at end" \ "timerlat TOOL -d 1s --on-end trace" 0 "^ Saving trace to timerlat_trace= .txt$" +check_top_q_hist "action with no threshold" \ + "timerlat TOOL -d 1s --on-threshold shell,command=3D'echo BAD'" 0 "" "BAD" =20 # BPF action program tests if [ "$option" -eq 0 ] --=20 2.55.0