From nobody Tue Sep 29 13:19:51 2026 Received: from mail-lr2-f7.google.com (mail-lr2-f7.google.com [74.125.230.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9025A3C818D for ; Fri, 7 Aug 2026 09:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.71 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786094344; cv=none; b=Y4O9mitrA4nUslWjSi/18w5GlpHj6yKq45Ok3PSDnDUQbc9JAK9mU0XT2Y8DZvtE3TRxNonHlGTvdLV2Dw7mAbpDkIlkQbLXCsFZAWLNBszAtDU+fzKOAxCgfUmHmxR1O+5CJeXJT6EL7nUZOICFKVtaNahy9/wbSFwqZvfSiAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786094344; c=relaxed/simple; bh=t9Lm5Q/A2wiqcLU589YGQrHAVCaBgRmTAHdTIxzVTzc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Pd3Ts+gcGWPZIPNLh8YRegAl/zyqaIPFeqaRwH3EyI649PSnLagu0Z/0yR77o9mcW8smUYEAVIPOvwck4EOoEgsNp8qUehtkTF58d0+Pz2mbj/xIQqhxbAiWEHKGRpsz5dtBrz7FG7JwhtAGjvKhXrnU7JGmvI8nkTQjLZlJS/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LbuD67Xz; arc=none smtp.client-ip=74.125.230.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LbuD67Xz" Received: by mail-lr2-f7.google.com with SMTP id 38308e7fff4ca-39c689d1d48so15648071fa.1 for ; Fri, 07 Aug 2026 02:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786094341; x=1786699141; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=q0p3f/CYZv3LvBsxpZaJPm4mZZTrcQzfNJYPhxpBa2M=; b=LbuD67Xz2dtODUggoQdbKvZ32eh/yTmqcHhMExHS1QJ/09GbBd8NNGS1GWBjyn4Ogy fMEVCFZdT5JamO8eiNjsyM8HgGWJ75k0uwtHK1lNMeT/k0GnSbRxAnaAFwgkMAIRxQVz t7cq5zt2rM8aXbc9hJhW+1mUXZYld2HSaVJS+ja8CJPAf+KXedplFnTFf1YscCTpilZ0 QyzPwWl8H9dUxYYSrAg6olFmz5mynyDcTvNNATxfzSwYF0AwOaa8X5Mhj7oA8OUlcpYZ v6YKBWxqbjgcBi6jesMnfYequHjKhnH1IoyyeDsdyGUAdvBkkUnfZwJ0hPJbD7f2b7Yi J0fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786094341; x=1786699141; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q0p3f/CYZv3LvBsxpZaJPm4mZZTrcQzfNJYPhxpBa2M=; b=W5Xn5aNhk+LKWy0EZgUH0CUNUn+mTDdA4ZxMHrAyohkFns74r+yZW6/kFlMJwsimlu UZXAYbAu6XSEIFF7vHHzb25LCs2hN10lHfRIFHPyzGX53WUuLtAwDBBBYixSR71kJs/J 9O/Egq6QmyZKIa7HHmRG7Ci1qrFHzOj33qm9XY19Gh0r6uPMsoJRIYIHQVGxliUWkr/k lubWBbDcdukhw5lpbMcWBNIMbf2wMIAa+MxncN6rzdnGrSNa3umpdm+ySb4QkqVk7Dtx pjxuGYsmwsdyhDYX9r4YPvBv/y1F8x/IgZTWahdMBvd7Vc5brYliqi1xt+TZgdneXmP2 eVMA== X-Forwarded-Encrypted: i=1; AHgh+Rr4qpZzoBbQ3W26o+Ts+gyXjxPz29Ci01+SeUUmMuGsq9nT07MC3z9hqpmL0JpBU1+ApWNWnBrig1CGISY=@vger.kernel.org X-Gm-Message-State: AOJu0YxUQxNygGwLmH8efhOYY7KmQR7a4apF7XFrzaCA6CroFmLToNqo ZGki5az/xY+m2ynzWv7SGVZiHB95j96D9mifQlSn1l8URps+GQZdbTDS X-Gm-Gg: AR+sD13pemUMB8E4UJBY8xR0hB7Y/b1Dt87FmWgx7+1VJUBpIYe0O7YL9uNMXNsccEs Hjr6nMAzVqxiINjUXknAD1th9DvXM+A5u2F8MIqZaSu/HmorMjpw7W+lhRM6T3GomuTZ21rvcFw TnkAi6amjvHrmLuI7EABlfjogODaxD6ha1ddXK8oQ60tNq+vUc6dBn9IZ9S7KPCthDj8dDvQK7v ndF1iy6eHUYkk6NIPc2BFYpTywSFvyKJoA7gQyvjK4FbN21N5CWSQwRmFJHcvi8mqYHaQAm+No/ jQ1RKVS4Dj131BNkHMuxsPEkED6ZRvbN9ASB5LpnclwLU+R86AUpl5l/1IDMco3VCNmU8z2bwe/ aAcV1+zjLCpgqdFAcRou7Tiiyj7DBID5gfzWrJGGLtjUXhjAnsFomHGZxl1TVSIdSwRaq6cP2Vc IF2FPcsG7FM9LRVD2gNsiz06ogmyaF+yi9Uy4tB9Q+kSM2B4ApNTurwP5+LnsnQXZ6uP8DpF8uP r7//g== X-Received: by 2002:a05:651c:210d:b0:39f:b1f9:327b with SMTP id 38308e7fff4ca-39fd68db3damr7183621fa.31.1786094340316; Fri, 07 Aug 2026 02:19:00 -0700 (PDT) Received: from localhost.localdomain ([78.40.184.2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fddd52594sm2370361fa.25.2026.08.07.02.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 02:18:59 -0700 (PDT) From: Roman Demidov To: Satish Kharat Cc: Roman Demidov , Sesidhar Baddela , Karan Tilak Kumar , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] scsi: fnic: Fix invalid comparison for error Date: Fri, 7 Aug 2026 12:18:50 +0300 Message-ID: <20260807091852.13151-1-roman.demidov.nn@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current comparison err !=3D ERR_ECMDUNKNOWN is useless because err < 0 and ERR_ECMDUNKNOWN =3D=3D 5. The logic is that if the CMD_CAPABILITY command was executed, there is no need to respond to unknown errors. Therefore, the sign of the number in the comparison must be changed. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Roman Demidov --- drivers/scsi/fnic/vnic_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c index 991c86eb5aff..0e5ae0540d85 100644 --- a/drivers/scsi/fnic/vnic_dev.c +++ b/drivers/scsi/fnic/vnic_dev.c @@ -381,7 +381,7 @@ static int vnic_dev_cmd2(struct vnic_dev *vdev, enum vn= ic_devcmd_cmd cmd, if (result->color =3D=3D color) { if (result->error) { err =3D -(int) result->error; - if (err !=3D ERR_ECMDUNKNOWN || + if (err !=3D -ERR_ECMDUNKNOWN || cmd !=3D CMD_CAPABILITY) pr_err("%s:Error %d devcmd %d\n", pci_name(vdev->pdev), --=20 2.53.0