From nobody Tue Sep 29 13:20:40 2026 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A36AD2848A7 for ; Fri, 7 Aug 2026 13:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786110356; cv=none; b=FI+KlpRDi1xCwjWnqjY40jmxOM+aFc6PniVcDwnNI39v9ERs9wLYJ+yr7KV89MNA7OZlIRIlP+3OQrwTUg6KHo1RhIAtbgyq1nf2AUMlumZ4sCPWfeDTDB967WG+SBx2texizY9EZcvEa0pB1H481GQQiDr0PgRVxU45ThS8XbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786110356; c=relaxed/simple; bh=Wofetp5Z3P4R5mpun6SHZso3XMYSZwee2HG1xFyV7Cg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=dAzAkCknhRaov9EDqOmbRmLOS0h4wWRT/Kv3qfTLaquzitput11hmJ6uVtbF512z69MMzq+XXxIA24/pcpm3d9NYt86V7z+3G+9l1B6/Is6Zqw5B5Cno94+Ls/EoMHUeZ135D3t0gBulYZUUdeM1N5oDfMCny8uHBSjjDCskjIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marliere.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b=uOCa7ZdF; arc=none smtp.client-ip=209.85.161.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marliere.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b="uOCa7ZdF" Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-6b01981b541so1096143eaf.0 for ; Fri, 07 Aug 2026 06:45:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786110348; x=1786715148; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NYHzpticqacgoFvvmKPg0LdzFqxuqRmFxl8tGbCVxoQ=; b=NbQ5gwBVX8Y/YKwyHUwyCbplLbexLnFpBzq+cmL77kDkmslU3PhTthd8lHcI1k9Kl0 lPOfHN8AQ1OBtDT8sBmDaDk8F1xvUbKj6J0ZnliD9Mtl2ZD0HTk1h9Z0uUdZmYIYwdKs xJML+2Mm49fEpYckVWV047QxdzM6au5xb547RxYQ8Sec11EygiZmwNeTQp3/WIj33af7 zvoEJXvHgH3x2d60/tinby5olZvLBasZp61Nsq44zSRu5VIcMMSAzr609ppmxjQPkWlL OVeXen7HhLG/WtplnVjlXY9biDw6j3Ax+Q3P0mIK3p0sXDVA5s5wg393RXnMqROiv5tF Toxg== X-Forwarded-Encrypted: i=1; AHgh+RpxV61Ujgf++qM+oeasgGQqMJdiW3fvoDBBQs+MYuy0gCGZroTW8SRoHD+lgoQJLDhoBXz5S8D6PDhFxKM=@vger.kernel.org X-Gm-Message-State: AOJu0YzAd/rLK+UEub7rw4nP9O9DB6F6C18l487hu4AP1csjFsprzUWo vKg3LJs/GCx5Cw8Eoo92J1UeHKuC2/8LWinOWrECdYkkzlodhY3PV9cj X-Gm-Gg: AR+sD11aoHGBGoCBbL7t9V+yP66toQKGsm4pqTKUjqBRs4BI/0nK6oWHnvHcWNEAdyZ tdvdf5IZAPhp2ZBd5NZk7Ih6G3+CTsY2f/aTM1w47HN7niblv6YFkakjE2zOrJL7FP4NXvUtQD5 VsMwx19ZSsP8iXU20izbEO/s89FV1k9VvYPoBKMTuEpsuT1olASvQJoJ9iLUtRl5GY7PyzbhTj3 Mxu16KtQdBrRjoj6GP9v9axQDANsw02Z00NSxb5mE36r2z7kfKuhJTrs5jQ5bHKFWnV8S5fMu+C WLDT0GvYLPc4dx5JeOV7mL/LWTkoPRioJa9ZWEvt5K2rpneZdBfGMzYcAef4nZTXiG0+a3RL72O QepK6iGgGI7apSHAbHpWEBx6NjaLV6cnDAenOaGgmwyWRyPaI6GeQgdB7k9t21UWGhJEdyZtq+m NwfuGhJju+UUM6hUvBVWy1NFz1C5GI9WdROVuEWheXctzyBcGW87xGNi8Ie5fHqvN1gOGLIyURe ZEOMfiMwBozxP3q1OZPP3PND04oZ8ZtvwXWK1A0W5Q1IDPRi2zg8sKQauYtWKEyDkI= X-Received: by 2002:a05:6820:625:b0:6a3:7af2:90ef with SMTP id 006d021491bc7-6b03505ccebmr1978913eaf.6.1786110347530; Fri, 07 Aug 2026 06:45:47 -0700 (PDT) Received: from mail.marliere.net (137.65.66.34.bc.googleusercontent.com. [34.66.65.137]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6b02be475b6sm2333477eaf.11.2026.08.07.06.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 06:45:45 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 165D060A63; Fri, 7 Aug 2026 13:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marliere.net; s=dkim; t=1786110344; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding; bh=NYHzpticqacgoFvvmKPg0LdzFqxuqRmFxl8tGbCVxoQ=; b=uOCa7ZdFZyOvwZGap1qpbPMuVcmmLLPoNrMffIIb0u6nv1YTNAfvJTCpuDyNAd18HpZ+UW vv78CXtGT6PwjyoBDQFyNpy+Cjk0BRGDlyGnfCINvcrG6TlVg+zBu3n3k/dljeP0HKo6Bt CVHGspSRtubnmNexUly8pgJyr9O/Sq3s5FO7Hb6yB6aAv+eNEaK1nWBNH/VDS4zEu1iTUd eYqQJrDN4VKATmQMjTmXDf//n4EKE+ma+aVCbARDazZnft/XrBqSJrz0vtUEMTPS00lHyA 0YGriyzAihC4SUYHixgc8u7pygJhmkmm/gJPi5DkLf1PiLrd40vJdM8cXZOWaA== From: =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re_=28SUSE=29?= Date: Fri, 07 Aug 2026 10:45:27 -0300 Subject: [PATCH] selftests/bpf: Fail unbound UDP on sockmap update Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260807-selftests-bpf-sockmap-v1-1-8c4936fa03cd@marliere.net> X-B4-Tracking: v=1; b=H4sIAHbhdWoC/yWMQQ6CMBBFr0Jm7SSlIQJexbjolKlUsTSdYkwId 7fV5fv57+0gnDwLXJodEr+9+DUUaE8N2NmEO6OfCoNW+qwG1aPw4jJLFqToUFb7fJmI/dBOpEf bubGD4sbEzn9+3evtz7LRg22usfogI4yUTLBznSQbWhiO4wshFRNtkgAAAA== X-Change-ID: 20260807-selftests-bpf-sockmap-781db29c4f94 To: Shuah Khan , sashal@kernel.org, gregkh@linuxfoundation.org, Andrii Nakryiko , Eduard Zingerman , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michal Luczaj , Kuniyuki Iwashima , Jakub Sitnicki , =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re_=28SUSE=29?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openssh-sha256; t=1786110339; l=2195; i=ricardo@marliere.net; h=from:subject:message-id; bh=k0iKUTHaUwJH+lfQYJ0uFk2Hw3GHTUfbUqkLQYeb3Xc=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgguRCc5X8/UX9M40lkMnr//aFGOhce x5ezt8MFNUFlqYAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QLapkuTD1Pc2A9FxSADnN+MRQOVf6Y2X2KjShkDjUiDef/GSlF7Dxthz9YVZ2GWhKNqY1uiG9U5 6dfX4A+U/lwU= X-Developer-Key: i=ricardo@marliere.net; a=openssh; fpr=SHA256:pzhe0fJpYLz+3cZ33FFPhIfaUElk9CXPFFXmalIH+1g X-Last-TLS-Session-Version: TLSv1.3 From: Michal Luczaj [ Upstream commit 203b06932777b9ad5085319389dea566f5c2ca63 ] sockmap now rejects unbound UDP sockets. Adjust test_maps. While at it, check socket()'s return value. This effectively reverts commit c39aa2159974 ("bpf, selftests: Fix test_maps now that sockmap supports UDP"). Signed-off-by: Michal Luczaj Reviewed-by: Kuniyuki Iwashima Reviewed-by: Jakub Sitnicki Link: https://lore.kernel.org/bpf/20260707-sockmap-lookup-udp-leak-v4-4-f87= 8346f27ab@rbox.co Signed-off-by: Kumar Kartikeya Dwivedi --- Signed-off-by: Ricardo B. Marli=C3=A8re (SUSE) --- Hi, backporting commit 66efd3368ae1 ("bpf, sockmap: Reject unhashed UDP sockets on sockmap update") without this one broke the selftest in openSUSE CI: https://openqa.opensuse.org/tests/6147940/logfile?filename=3Dtest_maps.tap.= txt --- tools/testing/selftests/bpf/test_maps.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selfte= sts/bpf/test_maps.c index ccc5acd55ff9..d194b44ff8be 100644 --- a/tools/testing/selftests/bpf/test_maps.c +++ b/tools/testing/selftests/bpf/test_maps.c @@ -748,16 +748,15 @@ static void test_sockmap(unsigned int tasks, void *da= ta) goto out_sockmap; } =20 - /* Test update with unsupported UDP socket */ + /* Test update with unsupported unbound UDP socket */ udp =3D socket(AF_INET, SOCK_DGRAM, 0); - i =3D 0; - err =3D bpf_map_update_elem(fd, &i, &udp, BPF_ANY); - if (err) { - printf("Failed socket update SOCK_DGRAM '%i:%i'\n", - i, udp); + CHECK(udp < 0, "socket(AF_INET, SOCK_DGRAM)", "errno:%d\n", errno); + err =3D bpf_map_update_elem(fd, &(int){0}, &udp, BPF_ANY); + close(udp); + if (!err) { + printf("Unexpectedly succeeded unbound UDP update '0:%i'\n", udp); goto out_sockmap; } - close(udp); =20 /* Test update without programs */ for (i =3D 0; i < 6; i++) { --- base-commit: 74b69060ba6e44e20c2e4dc1847eca21db6e4a7c change-id: 20260807-selftests-bpf-sockmap-781db29c4f94 Best regards, -- =20 Ricardo B. Marli=C3=A8re (SUSE)