From nobody Tue Sep 29 13:20:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3902442A7BE; Fri, 7 Aug 2026 11:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; cv=none; b=cFMtxvbP0+oztasZ6WuNrV6YdfWTHv/3aYLuHZaacIWIkwnTLtZh1QO+B/LGwToYEbPdhkhUPIJ0onpPH6ZEZaEySW0Pvn0KsWtBatK9Mn5mLVGhb0KJjBmtQxIH2i5wW8KR3cNd7tGQmcPbrUjvSodCrHftkoKiCX4j0HG2dTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; c=relaxed/simple; bh=+O15LbmbYBLcfLKwgIYm2pNu9e7mrtaoQhULpVhOfYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E4H3l3jf1yWFlhsDsYv6F3JIviLnaEjmXiqpd0pMTTxQssw2FlXRvRrtHczynsqFJKQEI0miRNoUKPjyIv5kp88dgvnAbVBCU6a+6oPntHz9clhH7NQfB1ZwKYtq74IsOaC/393a6kcPxl57pGs01uC/wUOvpmNiroCalBydSjQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g4eFx3Vn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g4eFx3Vn" Received: by smtp.kernel.org (Postfix) with ESMTPS id E23A8C2BCB8; Fri, 7 Aug 2026 11:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1786101978; bh=+O15LbmbYBLcfLKwgIYm2pNu9e7mrtaoQhULpVhOfYA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=g4eFx3VnA0GThOh+2hOLjuHzgb2Rv/IEZvTy19h/kg6o5qvwm0T9+ARbNaZ5kb3QD ISA4hdostVJqwZh7rA7SCpQRZ1D3eZgD06igFmagMdT+QWyO4Snz12swLFIxJxZOoq FX334/wI+VwD4tYRJlRMThD9wka4e4gcKYYLvlkwvQteqGjiDG3dnWcTDZNKS6lGEB cKbDc+9MnD6SBbftlc1ETh3RdEJ6BvyeJfLS/qGdpl/prMlTpp59OfyQYaH00bLUxg Ph/MNAONuGF3UxrvbyQ0uNz02pfiVzYuDbB2wZnDKcgOpJtlTBOlmuMKSVkvux9kIn UFexwO8T7q2Hw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C26FEC5AC7C; Fri, 7 Aug 2026 11:26:18 +0000 (UTC) From: Pawel Zalewski via B4 Relay Date: Fri, 07 Aug 2026 12:26:08 +0100 Subject: [PATCH 1/4] char: use named initializers for acpi_device_id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260807-acpi-char-v1-1-742c450254dd@thegoodpenguin.co.uk> References: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> In-Reply-To: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> To: Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , Mattia Dongili , Weili Qian , Olivia Mackall , Herbert Xu , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, "Pawel Zalewski (The Capable Hub)" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786101977; l=1438; i=pzalewski@thegoodpenguin.co.uk; s=20260803; h=from:subject:message-id; bh=pvB6ZcDxtCyp+EzKE8EtX3iLA867vIHnUjBmQtM3fso=; b=YTbY0Byzh9twQPYPaHqXd78e8yC5EkKfcmlK50U7O+CtoiLA+mqwdKP+rCxcm/KFXqjUONHwc 5ttc+Vh3y7DDUljM+RW9A8CCTSGLrzvi/Eb1j0ysFpNwPIJOOL35IUN X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=W3zk1cb/wRnj6pNGbl3/2Zf3GmPA6IBpNHpDPyJ05k8= X-Endpoint-Received: by B4 Relay for pzalewski@thegoodpenguin.co.uk/20260803 with auth_id=913 X-Original-From: "Pawel Zalewski (The Capable Hub)" Reply-To: pzalewski@thegoodpenguin.co.uk From: "Pawel Zalewski (The Capable Hub)" Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. Also drop explicitly setting fields to 0 where it is redundant. While we are at it - unify the list terminator to have a single space between the brackets and no trailing comma. Signed-off-by: Pawel Zalewski (The Capable Hub) --- drivers/char/hpet.c | 4 ++-- drivers/char/sonypi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c index 285c6037417a..88d0d4750a6b 100644 --- a/drivers/char/hpet.c +++ b/drivers/char/hpet.c @@ -1004,8 +1004,8 @@ static int hpet_acpi_probe(struct platform_device *pd= ev) } =20 static const struct acpi_device_id hpet_device_ids[] =3D { - {"PNP0103", 0}, - {"", 0}, + { .id =3D "PNP0103" }, + { } }; =20 static struct platform_driver hpet_acpi_driver =3D { diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c index 9309cfb935be..fb6357ba69dc 100644 --- a/drivers/char/sonypi.c +++ b/drivers/char/sonypi.c @@ -1136,8 +1136,8 @@ static void sonypi_acpi_remove(struct platform_device= *pdev) } =20 static const struct acpi_device_id sonypi_device_ids[] =3D { - {"SNY6001", 0}, - {"", 0}, + { .id =3D "SNY6001" }, + { } }; =20 static struct platform_driver sonypi_acpi_driver =3D { --=20 2.55.0 From nobody Tue Sep 29 13:20:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F7B41D4EA; Fri, 7 Aug 2026 11:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; cv=none; b=J2378HYmJYKxlJtgtlhA7ctHtaEtQCRH7c5EUaPU3Gea2z303QMfjyAy5OZ8TsTKeDTtv9C7PvhzMON+TQaVP2F6iaeEYlc/FJQPT6oY4oBB4yAPsR0xunRDGJIwWAx2gSOTCxCx0wR1Q/6FidgegZYnkcVC+WjCc0wqypcmiro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; c=relaxed/simple; bh=s5yPAJHJCjoTyZze9sB8p14TVGQ8qTHTjfVTzn1EEYw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nTleUw6JiPURKb7D4FrLbBtfw28RAXBUmTPJhkuvVzOH8lC1qFbCQzzQq0eAJ1OpiX+7hW5Cysj5uzS7t3qlOBY3XeEtLLTqYay0r+O6m7ngbc7z+A+28C8kuqWx31y/NC6gCq9PBBsD1m0KTJmhp5/5nfuPNi4R6XdGzUQcUBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dojbjUTF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dojbjUTF" Received: by smtp.kernel.org (Postfix) with ESMTPS id F0B0EC2BCFA; Fri, 7 Aug 2026 11:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1786101979; bh=s5yPAJHJCjoTyZze9sB8p14TVGQ8qTHTjfVTzn1EEYw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=dojbjUTFEKuj/cQEkk918sx+Hby/sIcm8cpT/MhoERvERk2O5AhKM3LztiUhYxVKN xep33D7QbUFVcRDdtXvVaxUtRHtnqieueMGhDtQD03C327rDrANsCjL6viRVfkK7q/ go3ea5lQZKVpvxDpY5TZ8cvJgUv1L0SjXQ7BKuFUubrfnv8nm8KkhH3SexHLiN1xZ3 T2iCkYe5RrkQVxIoLN9E7C3SxZLIxNjdtU35IPw5US9LqeFX6bx72zie7ztsy64644 D+/Ok5saUUw77g3dtxlR1D8iiTr8e2Pw/wGhJPBhHfVuQ17flOYBWSyQ50yS1gFnYv BShjBNTbyFsLg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3FDEC5AC80; Fri, 7 Aug 2026 11:26:18 +0000 (UTC) From: Pawel Zalewski via B4 Relay Date: Fri, 07 Aug 2026 12:26:09 +0100 Subject: [PATCH 2/4] char: hw_random: use named initializers for acpi_device_id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260807-acpi-char-v1-2-742c450254dd@thegoodpenguin.co.uk> References: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> In-Reply-To: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> To: Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , Mattia Dongili , Weili Qian , Olivia Mackall , Herbert Xu , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, "Pawel Zalewski (The Capable Hub)" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786101977; l=1444; i=pzalewski@thegoodpenguin.co.uk; s=20260803; h=from:subject:message-id; bh=+xP/DyVMe1G4+tAB3K0pNQD1hmkjHQX41ImGXQMTrqo=; b=0HUTmx5EbpEP+CnAz7BzmRJIaxcloUiHZXMfz0ArQH/ota00MUtfLnrJJ+ZIOOqQOvhZmYEbW 0f34qLnp+dkBj5v+DUifGCk+mk1l3vixpU0WqVISP8BfnsFy3ocKq5F X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=W3zk1cb/wRnj6pNGbl3/2Zf3GmPA6IBpNHpDPyJ05k8= X-Endpoint-Received: by B4 Relay for pzalewski@thegoodpenguin.co.uk/20260803 with auth_id=913 X-Original-From: "Pawel Zalewski (The Capable Hub)" Reply-To: pzalewski@thegoodpenguin.co.uk From: "Pawel Zalewski (The Capable Hub)" Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. Also drop explicitly setting fields to 0 where it is redundant. Signed-off-by: Pawel Zalewski (The Capable Hub) --- drivers/char/hw_random/hisi-trng-v2.c | 2 +- drivers/char/hw_random/xgene-rng.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/hisi-trng-v2.c b/drivers/char/hw_random= /hisi-trng-v2.c index 6584ed051e09..9e0ecea56ad6 100644 --- a/drivers/char/hw_random/hisi-trng-v2.c +++ b/drivers/char/hw_random/hisi-trng-v2.c @@ -77,7 +77,7 @@ static int hisi_trng_probe(struct platform_device *pdev) } =20 static const struct acpi_device_id hisi_trng_acpi_match[] =3D { - { "HISI02B3", 0 }, + { .id =3D "HISI02B3" }, { } }; MODULE_DEVICE_TABLE(acpi, hisi_trng_acpi_match); diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xg= ene-rng.c index 1f4b95341c2e..222db3fb275b 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -296,7 +296,7 @@ static int xgene_rng_init(struct hwrng *rng) =20 #ifdef CONFIG_ACPI static const struct acpi_device_id xgene_rng_acpi_match[] =3D { - { "APMC0D18", }, + { .id =3D "APMC0D18" }, { } }; MODULE_DEVICE_TABLE(acpi, xgene_rng_acpi_match); --=20 2.55.0 From nobody Tue Sep 29 13:20:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 390FC42B725; Fri, 7 Aug 2026 11:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; cv=none; b=IlET/QmyjjjSPuqzs70dcjGcN3wsC4JficTKItPwZduPqyXZcHT6qaqi99oy3jd9b2Jx8srO0r2R52Wt2O3+5IJkFuLLWE1k6bw9MIe/MtmG4Vyvwd8n0lKdWEFw6kzYuzZAhsombEVEIbnTx3eUKmqQhNu7f9mAv00RJudMQH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; c=relaxed/simple; bh=oJO5h+nosdRoYIT0B8NHstUH+k1xdQUHRF77SsiPdNc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uuG9DXc+810f+D7aztb7fsTfkYqY3vh4WAkHndB9LfO+GApSzpNhOiFgI19lfciCis3qSmwcNKXrgRvp6QCeBTGQjhw/BbKyESiOgZb6IjdC3nJWffY6nv7LDVeBU+nAGPGf7WY3OoU93PotLrbX8X7xag2of3MvcRLlx9Zbsxg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iPjF0yHF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iPjF0yHF" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0B2F9C2BCF7; Fri, 7 Aug 2026 11:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1786101979; bh=oJO5h+nosdRoYIT0B8NHstUH+k1xdQUHRF77SsiPdNc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=iPjF0yHFTBYUHaLCnB/hFeEILsro+Iptxm5TIdCAa6pdVfML50CgXjySa291n7+QZ uyUFttA7++Zyhkx92n8a4m4CkXsdH+fU5RY98qtF/L4BEPngLAtnP+MEtK1z0ZfVDB 4iLUBcZKuAvRQHTGYnz183+MkCiODq3L9ViB64QlisuDTS6IQhYXJ+UI4dWq+rqowZ r89TBOwFBxc3Dt0PNj1T0sjqgVINP9oeg9DC3tyJOFXL9w2G9fpvERxPj63SfDeIxd FjqZtWQwmEe8BWOpHv25JqxGPf5s2tj+dI/P3WU7PuWeqZIVai0Fj/smsRaMfSit52 zZ6djvsmLZDwQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4AA0C5AC7A; Fri, 7 Aug 2026 11:26:18 +0000 (UTC) From: Pawel Zalewski via B4 Relay Date: Fri, 07 Aug 2026 12:26:10 +0100 Subject: [PATCH 3/4] char: ipmi: use named initializers for acpi_device_id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260807-acpi-char-v1-3-742c450254dd@thegoodpenguin.co.uk> References: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> In-Reply-To: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> To: Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , Mattia Dongili , Weili Qian , Olivia Mackall , Herbert Xu , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, "Pawel Zalewski (The Capable Hub)" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786101977; l=2063; i=pzalewski@thegoodpenguin.co.uk; s=20260803; h=from:subject:message-id; bh=KSRiDBr/KlyRDt2jepviaq+isDgvIHWz0zDwNFdjAOU=; b=bCJjHt/hyxm30i2BmzMj5Gp85SGiXlRWj3FSLgnvW2M2kAKEaM/kJIXMgIHKiz9Yg6JcxhmDj GMofNtEZ1cuBR5rNsqrIDtpnm5s7KCQGSJMAUcw6cnNwkzQ0hTvgOVy X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=W3zk1cb/wRnj6pNGbl3/2Zf3GmPA6IBpNHpDPyJ05k8= X-Endpoint-Received: by B4 Relay for pzalewski@thegoodpenguin.co.uk/20260803 with auth_id=913 X-Original-From: "Pawel Zalewski (The Capable Hub)" Reply-To: pzalewski@thegoodpenguin.co.uk From: "Pawel Zalewski (The Capable Hub)" Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. Also drop explicitly setting fields to 0 where it is redundant. While we are at it - unify the list terminator to have a single space between the brackets and no trailing comma. Signed-off-by: Pawel Zalewski (The Capable Hub) --- drivers/char/ipmi/ipmb_dev_int.c | 4 ++-- drivers/char/ipmi/ipmi_si_platform.c | 4 ++-- drivers/char/ipmi/ipmi_ssif.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_= int.c index 680ff15c30ab..d576a77df927 100644 --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers/char/ipmi/ipmb_dev_int.c @@ -360,8 +360,8 @@ MODULE_DEVICE_TABLE(i2c, ipmb_id); =20 #ifdef CONFIG_ACPI static const struct acpi_device_id acpi_ipmb_id[] =3D { - { "IPMB0001", 0 }, - {}, + { .id =3D "IPMB0001" }, + { } }; MODULE_DEVICE_TABLE(acpi, acpi_ipmb_id); #endif diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_= si_platform.c index bdc481ce1302..fa221cbb4b3b 100644 --- a/drivers/char/ipmi/ipmi_si_platform.c +++ b/drivers/char/ipmi/ipmi_si_platform.c @@ -387,8 +387,8 @@ static int acpi_ipmi_probe(struct platform_device *pdev) } =20 static const struct acpi_device_id acpi_ipmi_match[] =3D { - { "IPI0001", 0 }, - { }, + { .id =3D "IPI0001" }, + { } }; MODULE_DEVICE_TABLE(acpi, acpi_ipmi_match); #else diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index 07f1d2327bb7..2361103c5edc 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -2057,8 +2057,8 @@ static unsigned short *ssif_address_list(void) =20 #ifdef CONFIG_ACPI static const struct acpi_device_id ssif_acpi_match[] =3D { - { "IPI0001", 0 }, - { }, + { .id =3D "IPI0001" }, + { } }; MODULE_DEVICE_TABLE(acpi, ssif_acpi_match); #endif --=20 2.55.0 From nobody Tue Sep 29 13:20:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4070943031B; Fri, 7 Aug 2026 11:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; cv=none; b=WO3XbxLKbn+b9U1TUb11/OLphlsckKEjEpMdmSZsfDrbDCQgy4ZKAGNhS3eS0OP+dX9UMkPFc05xkfoxC0KNL94yiug41XB95zeJUdgGX8QOfI3qW6OoSFhWqfF3XPFgL/Z8IbARNHG1Z1IFBxTmQIHN44TgyG9XT+upgJP9o6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101979; c=relaxed/simple; bh=9gOzZNj+wbU5TkDdlRUSr50ZwJarBEuetrIJeXRxmBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KSByxadkaNJzCPoJuQdQWXFYvaGRbmuzlCUtJY4RZT5Ci09yaI2zKcpmqj8qpFkfP+4XCXuQzGNEUTroeIzLRV3ddWrtnLb9QNW9qoA4qoFRRufJma/V5kMU+/FW4/LcT+GWp8xH1QuU4GlmJlXQHe70Wt8dFiR79zJU4smKf4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IkWnZhi3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IkWnZhi3" Received: by smtp.kernel.org (Postfix) with ESMTPS id 18591C2BCFB; Fri, 7 Aug 2026 11:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1786101979; bh=9gOzZNj+wbU5TkDdlRUSr50ZwJarBEuetrIJeXRxmBI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=IkWnZhi3fthn0Dnw1wfUfv6vAEQLD1zwU1emsGkhtIKSeqMCgC2nrggKhKNgY6I33 Gtw5SDvVVFJeWE+pYoVOC02EbJ8LV67DnCEL3RiGV+XuLe+xeA5hTLwJAMNRALg31Y UwDF7HCFRZ2VJb6Ck13bM0TjVwQmV8qLllmWeXL0Zl4YD3E8Cfn1sBlyvLwCiSeZoi 8M9GFNk5+0lb+8lR5d7wUUq6J4365WE4en1Lr8mqZqdemXpfUu6UynYkn+Z5/gstxt bGnBegEUG6AVrDZzMFl6RPCTu57NnL0gcWV8mUTJ2egoIvA3+rVKoSuqher/LTjk4X n63hkZlXALCSA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01760C5AC9F; Fri, 7 Aug 2026 11:26:19 +0000 (UTC) From: Pawel Zalewski via B4 Relay Date: Fri, 07 Aug 2026 12:26:11 +0100 Subject: [PATCH 4/4] char: tpm: use named initializers for acpi_device_id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260807-acpi-char-v1-4-742c450254dd@thegoodpenguin.co.uk> References: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> In-Reply-To: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> To: Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , Mattia Dongili , Weili Qian , Olivia Mackall , Herbert Xu , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, "Pawel Zalewski (The Capable Hub)" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786101977; l=4406; i=pzalewski@thegoodpenguin.co.uk; s=20260803; h=from:subject:message-id; bh=/3HqANNdgwc+v+bCM8pvoBxFH0K5Gv93E5IVVo98Axg=; b=tf+58qMPqBQXxvk2WPfC/OQEoHIfmkXD63JrsmKQeLQrAB7+MHX/CG+u3PeHojtQrguurPS92 ZI4sHrI8wo+AOM+l+bNQmPulehYsu90b6a0bz8vi4w9YyUXFRQ6bsUD X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=W3zk1cb/wRnj6pNGbl3/2Zf3GmPA6IBpNHpDPyJ05k8= X-Endpoint-Received: by B4 Relay for pzalewski@thegoodpenguin.co.uk/20260803 with auth_id=913 X-Original-From: "Pawel Zalewski (The Capable Hub)" Reply-To: pzalewski@thegoodpenguin.co.uk From: "Pawel Zalewski (The Capable Hub)" Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. Also drop explicitly setting fields to 0 where it is redundant. While we are at it - unify the list terminator to have a single space between the brackets and no trailing comma. Signed-off-by: Pawel Zalewski (The Capable Hub) --- drivers/char/tpm/st33zp24/i2c.c | 4 ++-- drivers/char/tpm/st33zp24/spi.c | 4 ++-- drivers/char/tpm/tpm_crb.c | 4 ++-- drivers/char/tpm/tpm_tis.c | 4 ++-- drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 ++-- drivers/char/tpm/tpm_tis_spi_main.c | 4 ++-- drivers/char/tpm/tpm_tis_synquacer.c | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2= c.c index 81348487c125..d2bf9996760d 100644 --- a/drivers/char/tpm/st33zp24/i2c.c +++ b/drivers/char/tpm/st33zp24/i2c.c @@ -145,8 +145,8 @@ static const struct of_device_id of_st33zp24_i2c_match[= ] __maybe_unused =3D { MODULE_DEVICE_TABLE(of, of_st33zp24_i2c_match); =20 static const struct acpi_device_id st33zp24_i2c_acpi_match[] __maybe_unuse= d =3D { - {"SMO3324"}, - {} + { .id =3D "SMO3324" }, + { } }; MODULE_DEVICE_TABLE(acpi, st33zp24_i2c_acpi_match); =20 diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/sp= i.c index 5149231f3de2..6671977c44aa 100644 --- a/drivers/char/tpm/st33zp24/spi.c +++ b/drivers/char/tpm/st33zp24/spi.c @@ -262,8 +262,8 @@ static const struct of_device_id of_st33zp24_spi_match[= ] __maybe_unused =3D { MODULE_DEVICE_TABLE(of, of_st33zp24_spi_match); =20 static const struct acpi_device_id st33zp24_spi_acpi_match[] __maybe_unuse= d =3D { - {"SMO3324"}, - {} + { .id =3D "SMO3324" }, + { } }; MODULE_DEVICE_TABLE(acpi, st33zp24_spi_acpi_match); =20 diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index ceb4100ba400..671ba480a675 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -917,8 +917,8 @@ static const struct dev_pm_ops crb_pm =3D { }; =20 static const struct acpi_device_id crb_device_ids[] =3D { - {"MSFT0101", 0}, - {"", 0}, + { .id =3D "MSFT0101" }, + { } }; MODULE_DEVICE_TABLE(acpi, crb_device_ids); =20 diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 9aa230a63616..4bb18fb1df87 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -130,8 +130,8 @@ static inline int is_itpm(struct acpi_device *dev) #define DEVICE_IS_TPM2 1 =20 static const struct acpi_device_id tpm_acpi_tbl[] =3D { - {"MSFT0101", DEVICE_IS_TPM2}, - {}, + { .id =3D "MSFT0101", .driver_data =3D DEVICE_IS_TPM2 }, + { } }; MODULE_DEVICE_TABLE(acpi, tpm_acpi_tbl); =20 diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis= _i2c_cr50.c index b48cacacc066..dc8a5ec5799b 100644 --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c @@ -669,8 +669,8 @@ static const struct tpm_class_ops cr50_i2c =3D { =20 #ifdef CONFIG_ACPI static const struct acpi_device_id cr50_i2c_acpi_id[] =3D { - { "GOOG0005", 0 }, - {} + { .id =3D "GOOG0005" }, + { } }; MODULE_DEVICE_TABLE(acpi, cr50_i2c_acpi_id); #endif diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis= _spi_main.c index 61b42c83ced8..d2e37e667dd7 100644 --- a/drivers/char/tpm/tpm_tis_spi_main.c +++ b/drivers/char/tpm/tpm_tis_spi_main.c @@ -339,8 +339,8 @@ static const struct of_device_id of_tis_spi_match[] __m= aybe_unused =3D { MODULE_DEVICE_TABLE(of, of_tis_spi_match); =20 static const struct acpi_device_id acpi_tis_spi_match[] __maybe_unused =3D= { - {"SMO0768", 0}, - {} + { .id =3D "SMO0768" }, + { } }; MODULE_DEVICE_TABLE(acpi, acpi_tis_spi_match); =20 diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_ti= s_synquacer.c index 4927714d277a..c2d09315aa17 100644 --- a/drivers/char/tpm/tpm_tis_synquacer.c +++ b/drivers/char/tpm/tpm_tis_synquacer.c @@ -144,8 +144,8 @@ MODULE_DEVICE_TABLE(of, tis_synquacer_of_platform_match= ); =20 #ifdef CONFIG_ACPI static const struct acpi_device_id tpm_synquacer_acpi_tbl[] =3D { - { "SCX0009" }, - {}, + { .id =3D "SCX0009" }, + { } }; MODULE_DEVICE_TABLE(acpi, tpm_synquacer_acpi_tbl); #endif --=20 2.55.0