From nobody Fri Oct 2 01:07:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2391481FBC; Thu, 6 Aug 2026 15:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031687; cv=none; b=eeuDdrQsZpd8KhGSMhgqaDDEyA9moLNNAzhSnShvq8EYoDWlWSkBW/rKLOG8jiVhlziPsLHUCFMR3xD40kmtqJ0oyJzeuG7rZw26ymxxldNjpElQyGtP4094WkaDiMG7R34qbB3/RWqTRmppHsnrAP6ucGmiQzKzQtGS9wA9FXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031687; c=relaxed/simple; bh=cJhild7tj5C4HdDZCSijyw01evpaCANG62VwSL3U4Wo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d1UdNLLcBjvKKNGjFptRGAjruOIHWYvsEqofkHxbfEY5+7wPhQCsbzxzvAlafnNVC900eZna4yOerVQo6ab6ry9ppPUNUlmo57pXr4LPz5eAF4f1WfDqS9/dVMf3MVI6D0RbmJEceSKqv/qnm8xBvuD1rBlyzcP5SiEvNUQiBYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G4EilNZy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G4EilNZy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D2831F00A3A; Thu, 6 Aug 2026 15:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786031677; bh=fA/JaboSNDsEZkkigGD/qDoilPwlK5jX0t/qy95nR+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=G4EilNZyXyQAaS/Rld4UGwWHUy47AINYxRdn9pYzR6/Mv3ar/QSwsHag2oL16JF4z lpaNy+9MXtmn8+wOUspOJf99RrSZ02f4QP8Gwf8kC7htlHcwdeduHz7xPFzfdGpK5e JIL5umJInJnljbhbnqJctqoUd36OS49Rukum/uLuDr7ns267NL+yMtq7UYFIv3h8Fa 52CjtdoXD/4Co2YszQe/rWXzHfiS8h5UevZ4kuF6kttVf4e2orRI+l8Qd1C8vhndpf Wukt3eZcd7R3LZZUX8dZxGAhEGPb6lvIXCS0p2p5q7Wt8CJLCVCp6Rv5f3YmwA99ie I6zPWtByrYJiw== From: Dinh Nguyen To: bp@alien8.de, tony.luck@intel.com Cc: dinguyen@kernel.org, rounakdas2025@gmail.com, niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCHv2 1/4] EDAC/altera: Add suppress_bind_attrs so driver cannot get unbound Date: Thu, 6 Aug 2026 10:54:09 -0500 Message-ID: <20260806155412.1518582-2-dinguyen@kernel.org> X-Mailer: git-send-email 2.42.0.411.g813d9a9188 In-Reply-To: <20260806155412.1518582-1-dinguyen@kernel.org> References: <20260806155412.1518582-1-dinguyen@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The EDAC driver should not be able to be removed from userspace because a re-bind would clear out existing memory contents of an active running syste= m. With this change, remove the .remove functions because they will not ever get used. Fixes: 588cb03ea208 ("EDAC, altera: Add Arria10 L2 Cache ECC handling") Cc: stable@vger.kernel.org Signed-off-by: Dinh Nguyen --- drivers/edac/altera_edac.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 68846f583eeef..fe501c89dd0dc 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -453,15 +453,6 @@ static int altr_sdram_probe(struct platform_device *pd= ev) return res; } =20 -static void altr_sdram_remove(struct platform_device *pdev) -{ - struct mem_ctl_info *mci =3D platform_get_drvdata(pdev); - - edac_mc_del_mc(&pdev->dev); - edac_mc_free(mci); - platform_set_drvdata(pdev, NULL); -} - /* * If you want to suspend, need to disable EDAC by removing it * from the device tree or defconfig. @@ -481,13 +472,13 @@ static const struct dev_pm_ops altr_sdram_pm_ops =3D { =20 static struct platform_driver altr_sdram_edac_driver =3D { .probe =3D altr_sdram_probe, - .remove =3D altr_sdram_remove, .driver =3D { .name =3D "altr_sdram_edac", #ifdef CONFIG_PM .pm =3D &altr_sdram_pm_ops, #endif .of_match_table =3D altr_sdram_ctrl_of_match, + .suppress_bind_attrs =3D true, }, }; =20 @@ -517,6 +508,7 @@ static struct platform_driver altr_edac_driver =3D { .driver =3D { .name =3D "socfpga_ecc_manager", .of_match_table =3D altr_edac_of_match, + .suppress_bind_attrs =3D true, }, }; module_platform_driver(altr_edac_driver); @@ -803,22 +795,12 @@ static int altr_edac_device_probe(struct platform_dev= ice *pdev) return res; } =20 -static void altr_edac_device_remove(struct platform_device *pdev) -{ - struct edac_device_ctl_info *dci =3D platform_get_drvdata(pdev); - struct altr_edac_device_dev *drvdata =3D dci->pvt_info; - - debugfs_remove_recursive(drvdata->debugfs_dir); - edac_device_del_device(&pdev->dev); - edac_device_free_ctl_info(dci); -} - static struct platform_driver altr_edac_device_driver =3D { .probe =3D altr_edac_device_probe, - .remove =3D altr_edac_device_remove, .driver =3D { .name =3D "altr_edac_device", .of_match_table =3D altr_edac_device_of_match, + .suppress_bind_attrs =3D true, }, }; module_platform_driver(altr_edac_device_driver); @@ -2214,6 +2196,7 @@ static struct platform_driver altr_edac_a10_driver = =3D { .driver =3D { .name =3D "socfpga_a10_ecc_manager", .of_match_table =3D altr_edac_a10_of_match, + .suppress_bind_attrs =3D true, }, }; module_platform_driver(altr_edac_a10_driver); --=20 2.42.0.411.g813d9a9188 From nobody Fri Oct 2 01:07:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E92B483815; Thu, 6 Aug 2026 15:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031693; cv=none; b=R4nsioe8SoB4poPjrMovUe4v71f6fegVs9tiDkRi5cwxZdctckK0nHup8QJxX36D0KWCU0iqKovEx915y9CuE0YL9HmY0OFuUdXoVGv1mJ46hfqU79OR6swOGx0V/j1NcBzKbb2Wihx0qLC05684/j2s+xZs3IAys0dFYXu3YMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031693; c=relaxed/simple; bh=06j2gpu4umBpwkjj8hjl4gpaEcP90LVzzK0kC/1ZFno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U7oylwbvBOlo0bOoiT18N+wwKsFj0k02621lCbBqx78M8EKoXLhClYtcqLobe2qza7gvTTMSE78YPCBnEiQ9rbAWQyGUa1J7bSBnHIMCR5FvQP4gtvYvGUGO7KrijmZp94k6QBxPjMlypfcZap0Y8RA+7+YGahXIlLBYCrSp0DY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FEVOEg7i; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FEVOEg7i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37C231F00A3E; Thu, 6 Aug 2026 15:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786031677; bh=t/VRxkHHxFbRZakWbYvezpbjDo+InjUdt2X5B1+qbeo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FEVOEg7ii+FfpP5fYrZ300x++3ornc0HPKk8r55IkSpZPXMh9MOfgYLV4AW8qJpVM Pc4KgMGFxDbrBIJ0+naWMKJ66wuVbpNaUeNgTT0WvqeSudHYQrnL4z7R1ZpQZeX0LF VgUlgT2iDIo/3DYu4CRJKJs8gbFdCno0/o5SQZyPSvFJUUo3TiHMyUvon/4jwPX+qy xQvPrK+u0pFKc0CZ/R3Mi/4s2JVo2YHgyzThjqTCVHGrVgtLZwrNfhAeAEDKkW2sG9 EN/ht+Fr6m/KWZPdJ2Nau5TGbncpgR9IAmNAn+J3QuCDWG7nph1wiZfyJ2I/L0wadH pJzIGktNBBnew== From: Dinh Nguyen To: bp@alien8.de, tony.luck@intel.com Cc: dinguyen@kernel.org, rounakdas2025@gmail.com, niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCHv2 2/4] EDAC/altera: Drop __init from ECC setup paths for re-probe safety Date: Thu, 6 Aug 2026 10:54:10 -0500 Message-ID: <20260806155412.1518582-3-dinguyen@kernel.org> X-Mailer: git-send-email 2.42.0.411.g813d9a9188 In-Reply-To: <20260806155412.1518582-1-dinguyen@kernel.org> References: <20260806155412.1518582-1-dinguyen@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sashiko reports: Does suppressing sysfs unbinding fully prevent the execution of freed __init memory? If altr_sysmgr_regmap_lookup_by_phandle() returns -EPROBE_DEFER, the probe is deferred until after __init memory is freed. The a10 EDAC .setup callbacks (sdmmc, ethernet, nand, dma, usb, qspi) and their helpers (altr_init_a10_ecc_device_type, altr_init_a10_ecc_block) were marked __init. These run from the probe path, which may execute after init memory is freed -- e.g. a probe deferred via -EPROBE_DEFER that only succeeds once a late/module dependency appears, or a manual unbind/rebind. Calling __init code then dereferences freed memory. Remove __init so these functions remain valid at runtime. Assisted-by: Cursor:claude-4.8-opus Fixes: 788586efd116 ("EDAC/altera: Initialize peripheral FIFOs in probe()") Cc: stable@vger.kernel.org Signed-off-by: Dinh Nguyen --- drivers/edac/altera_edac.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index fe501c89dd0dc..d8a3438fb5f44 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -926,7 +926,7 @@ static int __maybe_unused altr_init_memory_port(void __= iomem *ioaddr, int port) return ret; } =20 -static __init int __maybe_unused +static int __maybe_unused altr_init_a10_ecc_block(struct device_node *np, u32 irq_mask, u32 ecc_ctrl_en_mask, bool dual_port) { @@ -1001,7 +1001,7 @@ altr_init_a10_ecc_block(struct device_node *np, u32 i= rq_mask, =20 static int validate_parent_available(struct device_node *np); static const struct of_device_id altr_edac_a10_device_of_match[]; -static int __init __maybe_unused altr_init_a10_ecc_device_type(char *compa= t) +static int __maybe_unused altr_init_a10_ecc_device_type(char *compat) { int irq; struct device_node *child, *np; @@ -1330,7 +1330,7 @@ static const struct edac_device_prv_data a10_l2ecc_da= ta =3D { =20 #ifdef CONFIG_EDAC_ALTERA_ETHERNET =20 -static int __init socfpga_init_ethernet_ecc(struct altr_edac_device_dev *d= ev) +static int socfpga_init_ethernet_ecc(struct altr_edac_device_dev *dev) { int ret; =20 @@ -1360,7 +1360,7 @@ static const struct edac_device_prv_data a10_enetecc_= data =3D { =20 #ifdef CONFIG_EDAC_ALTERA_NAND =20 -static int __init socfpga_init_nand_ecc(struct altr_edac_device_dev *devic= e) +static int socfpga_init_nand_ecc(struct altr_edac_device_dev *device) { int ret; =20 @@ -1390,7 +1390,7 @@ static const struct edac_device_prv_data a10_nandecc_= data =3D { =20 #ifdef CONFIG_EDAC_ALTERA_DMA =20 -static int __init socfpga_init_dma_ecc(struct altr_edac_device_dev *device) +static int socfpga_init_dma_ecc(struct altr_edac_device_dev *device) { int ret; =20 @@ -1420,7 +1420,7 @@ static const struct edac_device_prv_data a10_dmaecc_d= ata =3D { =20 #ifdef CONFIG_EDAC_ALTERA_USB =20 -static int __init socfpga_init_usb_ecc(struct altr_edac_device_dev *device) +static int socfpga_init_usb_ecc(struct altr_edac_device_dev *device) { int ret; =20 @@ -1450,7 +1450,7 @@ static const struct edac_device_prv_data a10_usbecc_d= ata =3D { =20 #ifdef CONFIG_EDAC_ALTERA_QSPI =20 -static int __init socfpga_init_qspi_ecc(struct altr_edac_device_dev *devic= e) +static int socfpga_init_qspi_ecc(struct altr_edac_device_dev *device) { int ret; =20 @@ -1598,7 +1598,7 @@ static int altr_portb_setup(struct altr_edac_device_d= ev *device) return rc; } =20 -static int __init socfpga_init_sdmmc_ecc(struct altr_edac_device_dev *devi= ce) +static int socfpga_init_sdmmc_ecc(struct altr_edac_device_dev *device) { int rc =3D -ENODEV; struct device_node *child; --=20 2.42.0.411.g813d9a9188 From nobody Fri Oct 2 01:07:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E639C48097C; Thu, 6 Aug 2026 15:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031687; cv=none; b=c+UjKV3YZHKihHjWbegEYV3y2Qt82NdRGVgIu+tFIz7wHBI//oKW+CUOMEA7QtOX46fm0NIaWdNlsdW/WuGAkmF1AnObZbF9w8K7E0+sXyYRzkiKVsmi1RIbnPHaGqLWnP+zyfr3WjLmVNH4V5iUsFXVKamhgZ3dWcOhhaaBK9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031687; c=relaxed/simple; bh=jzGL1qmq9aUI5fjdj/L8juoMvh3eVaHhnKk6Ix2U4qM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ev0TK/FzMnXxxItcXOTasHkqffzWMmicR8gF+V9ndxcMAYR9W/OlBEKN9n2FAINxHhFjxJR+ygD3/jzwDAIraRo4Oo2YkK8UKk5o61O3JN2PKNeYUk1jgQcERDI0BEdXDvBZub0dO70tz6LHJe92jruRx7bl8VAQIr2FixaI/KM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mYVyW5Nm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mYVyW5Nm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E73AA1F00A3F; Thu, 6 Aug 2026 15:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786031678; bh=IP4yAv7j7CcaHhlgDbcviVT5BzvHlHrIsRkF092L1HU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mYVyW5NmQq7WAmaWdWy3kiaOucRqKOw3v+qXMWVmY4goe1YfoTCfEphQujDDEg5Yw 1G+HTQakfee9Anb/Ch5r65jPWXRIxEK//b4c/Ww9sFrnqhtCVKHjjP5d4KuAZPV8Tc B8t5yPE4TkAcyyFMncJlI+ggQ0DQ8dBPEPjEE3pMm5/LlxiatnL3ZYbb0BLuTZ+Izx vi06jSsu8EXmEFPE+uB7AM0zEC6QbK+jz0eb5sMYQa53eF2OYEWPQzaqu1xaDRu+2L Q4S1RrHeP42HngtekwsWZqpfEefJsZYP0OwoyZhavJ+DSKcvfCV7nNsL2RhTkS0+vS PuZLObyHZssfw== From: Dinh Nguyen To: bp@alien8.de, tony.luck@intel.com Cc: dinguyen@kernel.org, rounakdas2025@gmail.com, niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCHv2 3/4] EDAC/altera: Fix code leak on dci allocation failure Date: Thu, 6 Aug 2026 10:54:11 -0500 Message-ID: <20260806155412.1518582-4-dinguyen@kernel.org> X-Mailer: git-send-email 2.42.0.411.g813d9a9188 In-Reply-To: <20260806155412.1518582-1-dinguyen@kernel.org> References: <20260806155412.1518582-1-dinguyen@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sashiko reports: If devres_open_group() fails, the function returns -ENOMEM without freeing the dci structure allocated earlier with edac_device_alloc_= ctl_info(). Free the dci structure if devres_open_group() fails. Fixes: c3eea1942a16 ("EDAC, altera: Add Altera L2 cache and OCRAM support") Cc: stable@vger.kernel.org Signed-off-by: Dinh Nguyen --- drivers/edac/altera_edac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index d8a3438fb5f44..ccdfb35178b69 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1516,8 +1516,10 @@ static int altr_portb_setup(struct altr_edac_device_= dev *device) altdev =3D dci->pvt_info; *altdev =3D *device; =20 - if (!devres_open_group(device->edac->dev, altr_portb_setup, GFP_KERNEL)) + if (!devres_open_group(device->edac->dev, altr_portb_setup, GFP_KERNEL)) { + edac_device_free_ctl_info(dci); return -ENOMEM; + } =20 /* Update PortB specific values */ altdev->edac_dev_name =3D ecc_name; --=20 2.42.0.411.g813d9a9188 From nobody Fri Oct 2 01:07:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E78B48035F; Thu, 6 Aug 2026 15:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031687; cv=none; b=cx84Gcy7o0TbozAQHtMhdJdxuAQiT7H6LQbQMjLZCDjrCJnS3y8dbsCXosASLuTnDTgNX3Mw/tlU1RNXTpvjAnilQbz01FBAdifMLF2e/ohLskHUXZlS341QAVmgukqFqM5oFuA57tCtORbcbppItbkp5AV2mF3kIpwkYO3867c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031687; c=relaxed/simple; bh=DVzmihv/iZvgSv2xI4pYd8cIUmwkRoWs8cAK8KYjTw8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HzjHO2d7t9TN0ETmlwvRlK6dE+wlKDXKpp+5dV0jznhFR1E/Ps6T/ydMecjg/w9xo0slr83UT2zHP82ucmu/5n43OFzK3JW1LmdmHeSBc4FaGWjGvq4d/l4IYA64W4jbnvPEeL4uL4uKtR/aXa7VfEpnMOjZVM5gszvDLQKgA5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZZNpA46e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZZNpA46e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A17BA1F00A3D; Thu, 6 Aug 2026 15:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786031679; bh=zu01nEYAjOItW35TYcUwmAsfZ0ZwoRmKBmJPUhqbpOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZZNpA46eY8mKAsz5zfFiWVGLs0h96TdFyy89Qqi4g1A4X/5MXcqcxOxXib1VOJkNl oX5HXQwgtcpu7IGsXsD2eFYI36Jb5YdIUdGJBR8R1WGP2Arh+VvrmDkZQnpdYDRfzj w4ZDYnokz3+TwHFW9vkEev0oCRwHWU5grCT7YJ3db6c7cnmEwvz4aYSGLzYhBhB3Sk pTUkMV/uvJ7AgRmcxe11o5uIGzHqoHs/jiQHpgY5g5OvRr6GcyHyhwRqvjxXBDjNV3 +/t7H6U09OtAhd7F3y5Z/umEpB7eiaLPRZz2Cdqiir/n9ifutTvo1n6CJvMRtt+vGI oi0SnYjwEsrTA== From: Dinh Nguyen To: bp@alien8.de, tony.luck@intel.com Cc: dinguyen@kernel.org, rounakdas2025@gmail.com, niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCHv2 4/4] EDAC/altera: Fix use-after-free in error paths Date: Thu, 6 Aug 2026 10:54:12 -0500 Message-ID: <20260806155412.1518582-5-dinguyen@kernel.org> X-Mailer: git-send-email 2.42.0.411.g813d9a9188 In-Reply-To: <20260806155412.1518582-1-dinguyen@kernel.org> References: <20260806155412.1518582-1-dinguyen@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In both altr_edac_a10_device_add() and altr_portb_setup(), the error path freed the dci structure before releasing the devres group. Since the managed single and double bit IRQ handlers use altdev(dci->pvt_info) as their data,= an IRQ firing between freeing dci and unregistering the IRQs could dereference the freed memory. Release the devres group first so the managed IRQs are unregistered before the dci structure is freed. Assisted-by: Cursor:claude-4.8-opus Fixes: 911049845d70 ("EDAC, altera: Add Arria10 SD-MMC EDAC support") Fixes: 588cb03ea208 ("EDAC, altera: Add Arria10 L2 Cache ECC handling") Closes: https://sashiko.dev/#/patchset/20260719211238.589402-1-rosenp%40gma= il.com Cc: stable@vger.kernel.org Signed-off-by: Dinh Nguyen --- drivers/edac/altera_edac.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index ccdfb35178b69..4c20fb9261608 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1593,8 +1593,13 @@ static int altr_portb_setup(struct altr_edac_device_= dev *device) return 0; =20 err_release_group_1: - edac_device_free_ctl_info(dci); + /* + * Release the devres group first so the managed IRQs are + * unregistered before dci (which contains the IRQ handler's + * data via dci->pvt_info) is freed, avoiding a use-after-free. + */ devres_release_group(device->edac->dev, altr_portb_setup); + edac_device_free_ctl_info(dci); edac_printk(KERN_ERR, EDAC_DEVICE, "%s:Error setting up EDAC device: %d\n", ecc_name, rc); return rc; @@ -1997,9 +2002,17 @@ static int altr_edac_a10_device_add(struct altr_arri= a10_edac *edac, return 0; =20 err_release_group1: + /* + * Release the devres group first so the managed IRQs are + * unregistered before dci (which contains the IRQ handler's + * data via dci->pvt_info) is freed, avoiding a use-after-free. + */ + devres_release_group(edac->dev, NULL); edac_device_free_ctl_info(dci); + goto err_print; err_release_group: devres_release_group(edac->dev, NULL); +err_print: edac_printk(KERN_ERR, EDAC_DEVICE, "%s:Error setting up EDAC device: %d\n", ecc_name, rc); =20 --=20 2.42.0.411.g813d9a9188