From nobody Fri Oct 2 01:08:04 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011000.outbound.protection.outlook.com [52.101.57.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 968651A5B9E; Thu, 6 Aug 2026 12:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019436; cv=fail; b=dTd5GfRYXHthCY8WPjJpD9OKBpDAIFq5ns3aukm8+nC4A0PqPur8Y+nEtJGk+8XLyxGIHwDjOY5Uo+TN+rCIIy1EmsgAzm0uSv3Wd4apDHu44iPfSl/k2o7zBnRlp+0oPvv7I4MGGeQ8JjibF/H+eoZvzeDIWQ/PzSMNwyEtsAM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019436; c=relaxed/simple; bh=V01T2JCUmHJWV8smZozAuZ7XZ+ivYKtR8YwI4l3HPWE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b8hMI/GWiWeB19EKepqfdF7JVuBSgLPoOMJXFFTRhWhA2aSmiypIJxXm6KUS3frAXFXl/PljP3cM0nSz/b5bd1Um297dDZILj5ym0C24zGxTYgezpyv9y4PZpUUzQ7yJqov+rgry2CYhXRC/n+Madg8j0u61nEHisI4Oh9pQsss= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=YQL36G1D; arc=fail smtp.client-ip=52.101.57.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="YQL36G1D" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HVsdIk97ep9E2OCyymqAgq/zSLT4JaEyzlueHhO8h6ATXk8/todS+bPnpr2yd9jU/fzStxdEqkUfYVafDBCyekmudCVzZyEJF6F4CPO8F0g8HygRn6SIy/0HjYZZ7T/Z9zfZMU5MQhJZUvqPlvrBI523NuWgs6VIPOB/9Zpu9Sxe//O7f4jSADVmmfHSsHjK/M5rw7fXrcOWn/xfl34egAbHLdwuMumRQoq64e2+eE0tBrM8XyPBYl96Y97DQJJxfIXFa5pU5JQDyMs8KoHgd9PCpkzBnX48e3wi9Njx0H1ymelX3Ha+Umu/5jTfG0NEH9sJAHaH3wPNFMD2TGqrkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aMr2PzXjVKx+mlfzQpG6ywcXQJeEdC5pYHaynlBCWCg=; b=DM3JmeAuCcfLKzmSC7GLHfJ/57AQW6gfbFkyuiT1m6pbuvn6HyXJMczWAlv0EfnWL71P/vJUr+FJPX1W1Q2ihBZA4z0Q/pse2bi1rr6STiYV59CfBAZroa85wBw2tQaIF2u4KjaPFrwnp8NYs+qnQ5yyPYX5BAY4zR84x0nzi2Q8dqQNchwkJl9ukjwwcPbk989Mf2FKo/Ew1IA5i8HHNACtf9poZnGvL0RqWS7x3Sm2ngDHHlD4QoiXesJUGBBYSCUfIovrLb8tXy06+1d3mgTXTrqtdWbkI4JwdGe10upjFpu40hvKqk0fpWfVyiXleVlQPyYKXxa4AowN7Z8YWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aMr2PzXjVKx+mlfzQpG6ywcXQJeEdC5pYHaynlBCWCg=; b=YQL36G1D75GzhGgeUqaE//yASHyoCSlzdvai4ZX7juRT9I4/zZw2RaKin+BljpWcoG3KHkD5o6aqEso0ziU/0k3uNFqJlEZ0ylFq9fXgHXMjvVhjLl2a24Pkt94Xb9qDucPIlw4J2wd753h3bmk/eCl3etT038+JvApMc9n+LEQ= Received: from CH0PR08CA0004.namprd08.prod.outlook.com (2603:10b6:610:33::9) by PH8PR12MB6697.namprd12.prod.outlook.com (2603:10b6:510:1cc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 12:30:24 +0000 Received: from CH2PEPF0000009E.namprd02.prod.outlook.com (2603:10b6:610:33:cafe::64) by CH0PR08CA0004.outlook.office365.com (2603:10b6:610:33::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.21 via Frontend Transport; Thu, 6 Aug 2026 12:30:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH2PEPF0000009E.mail.protection.outlook.com (10.167.244.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 12:30:24 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:23 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:22 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 07:30:19 -0500 From: Golla Nagendra To: , , , , , , , , CC: , , , , Subject: [PATCH 1/6] dmaengine: zynqmp_dma: Fix alloc_chan_resources error cleanup Date: Thu, 6 Aug 2026 18:00:09 +0530 Message-ID: <20260806123014.2120447-2-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260806123014.2120447-1-nagendra.golla@amd.com> References: <20260806123014.2120447-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000009E:EE_|PH8PR12MB6697:EE_ X-MS-Office365-Filtering-Correlation-Id: 3749d5f1-fbfa-4506-a7fb-08def3b67d0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|7416014|376014|1800799024|23010399003|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: PIMYzeWXFeQnQPsQ5gOt2dUhIKDoSWlea7wWx9uFYxJgVzVGzKimaoYB0d+BKkywngcdWojG49q8hULWjHC+Vt/EK6N4x8wNHNjBoBaYzkVomDdErjTJTkwJOpLprjbObwOCTmwxPAjvuhAg3pOFGFA9i4dI4rqHJG1m2GOFTPoROcgAa7ozN0ZbRg7L4amNqQYOFrQK/OJZ1ZLjDQ63r50DlH09TfR1Sc8YZHjiP1JxYJZdf0SEYZylZ6rX7B/6Y8O3yFF42LGlEkRPjGSiTjgZPuVKRGVQFuircV2B79qODVJuLHkXLk0Hs4mK4xcgayy9f/LUMus8L2/pHLNQ9aX4ILMLG2S88jCypyPd8VzDvfa4JrWXNldfdRl/3WCaZXkJ42BYLyP8B8mjnOxw8/dgmdkTqngUzDCrcdX4ydTZ3kbQQCAftb8jCakwFCcDs1b8l+5RCUuktVzhqxGX4msyHP3xD0KCWZRSkAArenT/McWOFmcucMbgVhVqeS5RMBnXRwgOg+gpw5h0ISjxwqdw4MkvHb0RJJyw0FiIo78WWC4Urur4IpwmZ4Pj/8HggwFwnVAwI+qRSnC7djP+hKYctcwUIt2IrwSbmIpaAYIVtV+27zM9Ii8OROB7zKrzXjlpkOnQDAiO+xKlo5cIFu2x5oFdvtpVuxtt0+cVFa9r9nl73WLBWDFk5453rD2FvO+9641Grw69AMFRgZKnYg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(7416014)(376014)(1800799024)(23010399003)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DXkPpmNCD5fNWV9ZxCPR5Lx5Da4ITANtYJganl17CqkH5EZ4CFXhydGINHY4K/McFTMrmbIFtfkOZndTGKRsJXbOJv7bNVdLk47LGjLF/CNvBPhBK8DnenHLxl9xI5DG0PauxcQ7jwt6tqbY20ou/ctQNptghNAs6CwrSD6pULl3SwQFUF2vd8/XT5jKpCeS6lDCV++QdYD0HtD5PuFrRAVX85VRA+LlRu/9Sqm+ztXS0Aqoc0gtJAshUZ/rqLJ5YtzZcWHRScyyQQHeZu7fu6XSbgdhtD0LqwFDSml9TihnlZKjQELhg0MUG8eZucDJDUTzf7uVy5KnwwCyXVgmY2JSUeG+wNsPDryfouo45sXWVYo/K+7WRa39mtd8PrjuX6UW8qsi5jMxVdOq/aKBGSz49STEFjJEXhdqpJ6UOdAPqRhtTkoXsf8rtToHWTXo X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 12:30:24.0317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3749d5f1-fbfa-4506-a7fb-08def3b67d0f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000009E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6697 Content-Type: text/plain; charset="utf-8" Channel resource allocation can fail after runtime PM has been acquired and after part of the descriptor state has been initialized. Without proper rollback, the error path leaks a runtime PM reference and, on coherent allocation failure, also leaks the software descriptor pool. Fix this by balancing runtime PM usage before returning an error and releasing any partially allocated software descriptor pool. Fixes: 8982d48af36d ("dmaengine: zynqmp_dma: Fix PM reference leak in zynqm= p_dma_alloc_chan_resourc()") Signed-off-by: Golla Nagendra --- drivers/dma/xilinx/zynqmp_dma.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index f6a812e49ddc..b7c561280694 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -483,8 +483,10 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_= chan *dchan) return ret; =20 chan->sw_desc_pool =3D kzalloc_objs(*desc, ZYNQMP_DMA_NUM_DESCS); - if (!chan->sw_desc_pool) - return -ENOMEM; + if (!chan->sw_desc_pool) { + ret =3D -ENOMEM; + goto err_pm; + } =20 chan->idle =3D true; chan->desc_free_cnt =3D ZYNQMP_DMA_NUM_DESCS; @@ -502,8 +504,10 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_= chan *dchan) (2 * ZYNQMP_DMA_DESC_SIZE(chan) * ZYNQMP_DMA_NUM_DESCS), &chan->desc_pool_p, GFP_KERNEL); - if (!chan->desc_pool_v) - return -ENOMEM; + if (!chan->desc_pool_v) { + ret =3D -ENOMEM; + goto err_free_sw_desc_pool; + } =20 for (i =3D 0; i < ZYNQMP_DMA_NUM_DESCS; i++) { desc =3D chan->sw_desc_pool + i; @@ -516,6 +520,13 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_= chan *dchan) } =20 return ZYNQMP_DMA_NUM_DESCS; + +err_free_sw_desc_pool: + kfree(chan->sw_desc_pool); + chan->sw_desc_pool =3D NULL; +err_pm: + pm_runtime_put_autosuspend(chan->dev); + return ret; } =20 /** --=20 2.43.7 From nobody Fri Oct 2 01:08:04 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011067.outbound.protection.outlook.com [40.107.208.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAAAF12FF69; Thu, 6 Aug 2026 12:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019440; cv=fail; b=mwogGB45uK4sRxu4kbMd3faa2E+lYUCiGb3SCAgXPEdcx6kvZtvKeYJFo+dfHPAERN2NVcKwjaB9Xe/68c1XIlwzayPyKUdxC0FAOa9fA1Y9U0oZmOE+kQR3hddsyNImqGYpVESLFE8db8NU4Hy+Wl8Ndw1oFbVMXMKqidmq2KY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019440; c=relaxed/simple; bh=gzoy7k5uDwfQT9Lao/bdbubZ+YA3a8cUVFNP3pztxLo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FrA0auC1Zpsr2OLkWiHg65HdTsgeXD2E+1wVw4LkI8b1PFixD4I5q1Xk015PZIb4A4yatdjmpRbOIMiOpqDvgl4pkhj+Pa6WNC8Uazp5Pap3UamMp0odu1HpYZhw8SBNaIpg/1P2a3vxpXSkuivmiSP+kbdQKuo18vPcegSoK70= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Qr45z4sB; arc=fail smtp.client-ip=40.107.208.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Qr45z4sB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PWfqXBbXvbqtP7qtuFzmDj4Nwu2W2CcYglI97XV0Kproerd46UhNuIBtFv1LeA/S5GHVhMq9omIs1K3PODDQBoNsrLCQFZ6lUa2qMoXUTBc7WQHU8nJX032QLlArDeQomVoHq9MOR2v1wOhV2rerSPRjFk8UyA0eRlb/8BW7hAuKEG4czAVsrZ/D/O03yxvdxWDqe1DFXVHNt4jJEMhSpRTNdCNC5UVsCuyKsBL0m7bcrA8tqP22KZKIXuqZJdGfh1SrCGpz7fBdDClpXEuwYVN8DYV8k5s0wRBaZxULeCHl8bg9lbKwQE52+LeNTuRLSVlnS1YLpb0sD9zq3oVbSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U9ZkHzijdIOgvEH7DTBf41lbH2iJAJiAThDaWo1Kn6o=; b=LTxnUQVM4Z4q4430ejjzP5oibUn5n89x8kJ7HAyNdwg5Y4IqJDDm5Q9j4J3p08gnV9io6D8gH6kBK5edG4ZHpiW1MlUS9R0N1mTSrqXObZsV5ZmfRGQlqtxamf6440r8jvFRze5Qgqsn/Li4yiKNdb4ONTaTPyJL9WF82wmeRB0GFap2bic67F+ODtDGPDXgV+U2mRCcIOzYz55SLv3HjANU9TfTqHguT4XpsQ3jDdYUf9Jbv2f+B9GX8x0EsvHN/HgmX96/3TwGsa8HGzOoIZ88g2LcQwZz9IMYM2XvrmJnvyFiR5mq4G9TCeBROFhCZvy3n1GFniLJx9IuVotA0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U9ZkHzijdIOgvEH7DTBf41lbH2iJAJiAThDaWo1Kn6o=; b=Qr45z4sBpgioLD2X8B52BMhJ2XWv9Daw504dtlPZFa3r47Txlo1VA+HnaCUDUPZfIkWCVekFjyUqWXYNweUBVdJb2c/V9OSCNG1d8F6F12J5qgHdw+Pkaec6GN2CSLUfo9GbgYtUTN79Tu+OZlZhSyzNDLgtDdkwQEKEU1oliys= Received: from CH0PR08CA0008.namprd08.prod.outlook.com (2603:10b6:610:33::13) by CH3PR12MB8236.namprd12.prod.outlook.com (2603:10b6:610:121::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 12:30:28 +0000 Received: from CH2PEPF00000099.namprd02.prod.outlook.com (2603:10b6:610:33:cafe::47) by CH0PR08CA0008.outlook.office365.com (2603:10b6:610:33::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.21 via Frontend Transport; Thu, 6 Aug 2026 12:30:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH2PEPF00000099.mail.protection.outlook.com (10.167.244.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 12:30:28 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:27 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:26 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 07:30:23 -0500 From: Golla Nagendra To: , , , , , , , , CC: , , , , Subject: [PATCH 2/6] dmaengine: zynqmp_dma: Fix chan probe error handling Date: Thu, 6 Aug 2026 18:00:10 +0530 Message-ID: <20260806123014.2120447-3-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260806123014.2120447-1-nagendra.golla@amd.com> References: <20260806123014.2120447-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000099:EE_|CH3PR12MB8236:EE_ X-MS-Office365-Filtering-Correlation-Id: b84f37b1-a1a7-4250-ba72-08def3b67f93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|36860700016|1800799024|82310400026|10067099003|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ARHmq+LvqCpq12G2vhHF9/PMaTWpQJHcNA+3Xhiji0Rlc7/ic1CuiwviZv1N7hze8KfGyabtAIFS4g1r+BiKGvaRA6Wrl0LFTSERM2kExMVQi00DK1cAAq1lnnaWuvGqMbQp3j5ZreUt+X8WDhnUGhLvWrf5m/H9zMZ2hT0IUTHE8ElbzQ0Alo8dobgTjILAer02NKxobSOQFj/SofgM55ejLLPMo/R11F/dJiXLYVPK9/AGA0/iD/bgggwFUtOexOgQPcXIhBK8tEKUESI/qmI07XvoTZjiEgzH/YCxnEgGnf/LDsIkmV/GxKpNmQ94YHdy8PNV39WQFLr7mlCichTIViVvFlVTzyv2ATydeKwt2Zyh9RTELUlfz7m+gDoMayOyl8ZTVAmzSKL1GY3vtWhRISdNzRyyr5Tb2hG9SRNUfwOQasZurVs9Xt5nHmo5MXEZLXsRIlJ5O8OthdN7sq79Nm3CctUfIa8Nr3ukDR5C+ZbyoU9pGQw+CtZotYGq2b2vDN2LtsJr06N/b7UFb21kIe1sxVy4BFoomaFWjAd1mYZN7mNJtpSlMgPkkrkPuwfgHYyp76YKdyk1l8nyUxZeDq7tOZKwKUzakTYoZna/LY2pbbfoPaemGMXyIRW9McCVATVwZF7GUTFm2wM9PQZQAjBqjTNFfSNeoFFgNDZTA8cts4XruAjvatzUl5FdOZ370MywPekwXXRmEZ9jGg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(36860700016)(1800799024)(82310400026)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YXRPVfEK9hjOYW8EuWHiGKRSQdBlvoMCHtBOcfyfTO4VbcrrVq1228JWOpt4KtjjPCeK43Y7SnzVDmoY8RgTLKeITCKV1zyqcmg0atCTesKpBlxK/dX2I4UCaWmQY93SftPOtokan/i4grJPGU7lp5WoKw6pzoVd5c0xgFERCfzZnsQ7odC9LciT5NO1Y3Vh5BieDj/x/QTjN820Ap9RTk/XlcAL1DQk1MRS+Vr9ZbRtTQZjsOOAG1Lz4HYJXXCXF5puux3lgbTZlmDtkaHnCYjECfgTlF9bwj4Xb2KJtn455+hD2qVnZCGEL5HQ88ZJSycZhBNyt/SBFPvJJZfOm5oAtQkw4b+Sl3WR6DiEOtNqKxBvKWvftbSxIB65Cu0DIpeP3+kPT04Ti/ye+30wN/m/qmKgRv2WFumobAPUJf86F0myys4ypShtRQaIleKL X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 12:30:28.2817 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b84f37b1-a1a7-4250-ba72-08def3b67f93 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000099.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8236 Content-Type: text/plain; charset="utf-8" Keep the real platform_get_irq() error value by returning ret directly, initialize chan->irq to -1, and only assign chan->irq after devm_request_irq() succeeds. In remove, free IRQ only for valid numbers and delete device_node only when linked. Move channel list registration to after successful IRQ registration, initialize device_node list head during probe setup, and kill the tasklet in the outer probe failure path when channel probe fails. Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver suppor= t") Signed-off-by: Golla Nagendra --- drivers/dma/xilinx/zynqmp_dma.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index b7c561280694..f7e4a177bd17 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -205,7 +205,7 @@ struct zynqmp_dma_desc_sw { * @desc_pool_p: Physical allocated descriptor base * @desc_free_cnt: Descriptor available count * @dev: The dma device - * @irq: Channel IRQ + * @irq: Linux IRQ number, or -1 when not registered * @is_dmacoherent: Tells whether dma operations are coherent or not * @tasklet: Cleanup work after irq * @idle : Channel status; @@ -896,10 +896,11 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_= chan *chan) if (!chan) return; =20 - if (chan->irq) + if (chan->irq >=3D 0) devm_free_irq(chan->zdev->dev, chan->irq, chan); tasklet_kill(&chan->tasklet); - list_del(&chan->common.device_node); + if (!list_empty(&chan->common.device_node)) + list_del(&chan->common.device_node); } =20 /** @@ -915,13 +916,14 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_de= vice *zdev, struct zynqmp_dma_chan *chan; struct device_node *node =3D pdev->dev.of_node; const struct zynqmp_dma_config *match_data; - int err; + int err, ret; =20 chan =3D devm_kzalloc(zdev->dev, sizeof(*chan), GFP_KERNEL); if (!chan) return -ENOMEM; chan->dev =3D zdev->dev; chan->zdev =3D zdev; + chan->irq =3D -1; =20 chan->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(chan->regs)) @@ -954,22 +956,26 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_de= vice *zdev, INIT_LIST_HEAD(&chan->pending_list); INIT_LIST_HEAD(&chan->done_list); INIT_LIST_HEAD(&chan->free_list); + INIT_LIST_HEAD(&chan->common.device_node); =20 dma_cookie_init(&chan->common); chan->common.device =3D &zdev->common; - list_add_tail(&chan->common.device_node, &zdev->common.channels); - zynqmp_dma_init(chan); - chan->irq =3D platform_get_irq(pdev, 0); - if (chan->irq < 0) - return -ENXIO; - err =3D devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0, + ret =3D platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + + err =3D devm_request_irq(&pdev->dev, ret, zynqmp_dma_irq_handler, 0, "zynqmp-dma", chan); if (err) return err; =20 + chan->irq =3D ret; + chan->desc_size =3D sizeof(struct zynqmp_dma_desc_ll); chan->idle =3D true; + list_add_tail(&chan->common.device_node, &zdev->common.channels); + return 0; } =20 @@ -1134,6 +1140,8 @@ static int zynqmp_dma_probe(struct platform_device *p= dev) ret =3D zynqmp_dma_chan_probe(zdev, pdev); if (ret) { dev_err_probe(&pdev->dev, ret, "Probing channel failed\n"); + if (zdev->chan) + tasklet_kill(&zdev->chan->tasklet); goto err_disable_pm; } =20 --=20 2.43.7 From nobody Fri Oct 2 01:08:04 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012043.outbound.protection.outlook.com [40.107.209.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 025BB1A5B9E; Thu, 6 Aug 2026 12:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019441; cv=fail; b=F/DJEhFhiavpz1gX33qWmQHkUBmKvPKD6q2XUY0Y+mD2T4MZ6WVeFdybdCy1vk3fMD+WY131D1Hu6f/qG6dx50VLRVnb65Xmbh/XkYWfsHYp3MNbz54qpU5uPI9SHOsONUMhwurnpSnCJ+BN8xpYIqGcjxIYbiO1FLh7nEFmL6Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019441; c=relaxed/simple; bh=nsYAJR5NfHc7wOmytKL5IOeTdlI0/UMrRAsw1tbjpzs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nJ/523+c26UDHGAatmz7m5R8puEnfZUdfYWIVgkcu6bnlUrPPzuEAf2JFUJ60vzcrgIuvWm6d25X+wmeUAuOMGF6gQKw+8MINlilnayCo6t/2GwkelHDyol6I73Kbjz3vH7Kww+kAqt1UsMlNJi0/WNyQlM44MnCvD0DKlAd+tM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=rlCluOU2; arc=fail smtp.client-ip=40.107.209.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="rlCluOU2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=toCxXlA0qtE9lsYg3BAPqm01lTmfEmtZMttu/y1X5pvz2seCWGFiCcjMlnGs2+njWYsB5SQVyANUIUK3Zh0PIcEbsY4dJa6ZAzrIUR8VQWnWDOZdflymeeY3SHqMmBPzZOxIS2ACc4zn8rQ7B9alMl8/MRNErrIbZJSs8GcYL6gmQ8Cpdz6Y3q8xOnaIzSib++BLHQWAR72cEoT3sS7AXq654VVtpYYNjwGutlykjviLaJjxix1DtQHA8taDMqFz0KX9aCmFdKRSKBhzAJjz53aK3aGE+wlVdOp20g7LJJbd8CXTpFoPECuGqVIx1WaSrPxgLCtsxXc9Z+PYa7/x4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZZjFZPmHThjK7DlIeLngIq+c6rm361d0lIEUlIr/zyk=; b=azDPXbiNqn0RuPZ9ramDoT4/ujUFCyyN3GHpJYRIU+0u13H61R0JiL0hM8H9IS61Iir5XELsqPozJSGTUTIXszqtJDdrSZ4thq1WsyOTaJjp5GU+r5GpHkfMW18gyxfJq3WdkI5iz5yx21EgZyDSZFbCHp5LywqflBwPbCRp7YCC2iBLqwLYJOhu5Po9JZXVVUtNvppfCceceyfax+4N26N5ULf2xcWbSimpwF5PspzqdvE0IWQUvLq9M5ZTZaBxyaFchoq268SGGQYvoFvPoxtFfcIKqmeExdhzchd6zPwtJiuuL/8x26FsL3bg1MA8PXvD/SjmEVYNFL/HBcX83A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZjFZPmHThjK7DlIeLngIq+c6rm361d0lIEUlIr/zyk=; b=rlCluOU2C2kxJXArIXEXzfY+/mHvZc5kh5NxjmqR7S0bED6ZQNmWs+AlNAPqxcvD5+y/cUP9NS2oiWGzm3ZD/CzI3Rf8siDYQS56Ctp1IhsYoFqfXyqxtJhnsJ4LYpZcf9oOpGG2hmIuokbl9t4v9gXXY9zzIqVG0z6uGI9Ni4s= Received: from SA1P222CA0007.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::22) by DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Thu, 6 Aug 2026 12:30:35 +0000 Received: from SA2PEPF00003F66.namprd04.prod.outlook.com (2603:10b6:806:22c:cafe::3a) by SA1P222CA0007.outlook.office365.com (2603:10b6:806:22c::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.21 via Frontend Transport; Thu, 6 Aug 2026 12:30:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F66.mail.protection.outlook.com (10.167.248.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 12:30:34 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:32 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 05:30:31 -0700 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 07:30:27 -0500 From: Golla Nagendra To: , , , , , , , , CC: , , , , Subject: [PATCH 3/6] dmaengine: zynqmp_dma: Fix stale kerneldoc comments Date: Thu, 6 Aug 2026 18:00:11 +0530 Message-ID: <20260806123014.2120447-4-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260806123014.2120447-1-nagendra.golla@amd.com> References: <20260806123014.2120447-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F66:EE_|DS7PR12MB9473:EE_ X-MS-Office365-Filtering-Correlation-Id: e08c42a4-ed09-4a87-9dc9-08def3b68380 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|23010399003|82310400026|7416014|376014|5023799004|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: kl6lj8S4wphHHctW2HBqcpC0rQcE2EH/inCUSRb4SgvOuzb+Ahq3jUbNfsmk0eBlSEkR/Y5Zr28/oTXYJD3NI7EKoOmqRcxs99HmeJPCkAhorG49Z1szZs1gXc7nZgV83+rKQrNOXO4t2a+D2EIN42ntADHs41fpMl+88LpH7BdqCkEZL6BqS2TM5RYPyG9IJXVbcPTrNadytdv9yjdKDOkzt+QNe/dJDp9mcAtTaUgU6lVlfIH5Ko+HkNYGMNcCGgclp2R/t+2CtGNCURlxSAzUOPCAHLMlDtQbcghwaLSb6Knrh9aZYw2V9zgXiSErlQ+mj/qySFvl5dH3al2qoG+tem2sgO/ltFTZWDmvdHVoCGX/pkP5eL6vvkBCwL9+RNP4yMCQ6AjKOIVRS5d+oNrjxYCrNnuo75Pc4UxUIeWpe1EGYzYYlQ2I5L0akHr+SM96wplG//12mzfw0xbp45sudmanyg0p0Tygi1H0pyOAhgOJv3QnU+1wqBmsr1yIhfea6D8nZYQg3crqA1mD2J845eYK+sIJnTUBtHfJ8U+xNuKj0pBhK/MYuycYHKOW/krs6wvgCY98HJrwOVejwPHOcaoPeCqRt0p8mFF9J2TtkAYUJy0MOnzI+Wl5BxBUfvwCWljNVsiDjOjfqwH+sqAYMVvu0i0AMrUYhAY6IMYCi2xGCEwZyit0onzcQTuaG985gcmm9ec4hmECLz/cAg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(23010399003)(82310400026)(7416014)(376014)(5023799004)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LndDt5E6ktYWbpA0YWINaldwl3WqzYeRqKmD9e9L4Zo0J87+7qpMbmBKeW3JSzDKcA8dUuhcqT+Irt7ciWUu9QGUHolqwZmHlCH+JOZHKLTOlSyR2cPnr/7JAQqbkXmzRmAhNESZ14DPCWRCLXC9NobluviIHkIp/ox5Fw6Epbl8Us49L8R+BHlIXz0NqNTH6HQErpTS0DYigsoAg/CxYbo75J+wRbwmEoRYEM4qfOchcWqbv25+vr7Iy6QyF6G9FdDU6MYmzE3t1O7l2R4PyOf0fm9XwEYLrzIat9juVnUbcmnfsOtJJp+Z4xd/i5rGJSx026ZdgszZs3ZGLZF17xZzUVQzT1KMpVCdj1iHUiT1NM2kKQoK2hCZluf6eIs+SGhPqsqf724xEKhlXSLju1KsJL18wVic3b+cGabm50d9J1RAoOBRV1sZgQxyrVSK X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 12:30:34.8215 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e08c42a4-ed09-4a87-9dc9-08def3b68380 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F66.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9473 Content-Type: text/plain; charset="utf-8" Correct kerneldoc comments that no longer matched the code. Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- drivers/dma/xilinx/zynqmp_dma.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index f7e4a177bd17..c5b05fd52e9d 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -208,7 +208,7 @@ struct zynqmp_dma_desc_sw { * @irq: Linux IRQ number, or -1 when not registered * @is_dmacoherent: Tells whether dma operations are coherent or not * @tasklet: Cleanup work after irq - * @idle : Channel status; + * @idle: Channel status * @desc_size: Size of the low level descriptor * @err: Channel has errors * @bus_width: Bus width @@ -435,7 +435,7 @@ zynqmp_dma_get_descriptor(struct zynqmp_dma_chan *chan) } =20 /** - * zynqmp_dma_free_descriptor - Issue pending transactions + * zynqmp_dma_free_descriptor - Return a descriptor to the free pool * @chan: ZynqMP DMA channel pointer * @sdesc: Transaction descriptor pointer */ @@ -617,7 +617,6 @@ static void zynqmp_dma_start_transfer(struct zynqmp_dma= _chan *chan) zynqmp_dma_start(chan); } =20 - /** * zynqmp_dma_chan_desc_cleanup - Cleanup the completed descriptors * @chan: ZynqMP DMA channel @@ -908,7 +907,7 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_ch= an *chan) * @zdev: Driver specific device structure * @pdev: Pointer to the platform_device structure * - * Return: '0' on success and failure value on error + * Return: 0 on success and negative error code on failure */ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, struct platform_device *pdev) @@ -1042,11 +1041,11 @@ static int __maybe_unused zynqmp_dma_runtime_suspen= d(struct device *dev) } =20 /** - * zynqmp_dma_runtime_resume - Runtime suspend method for the driver + * zynqmp_dma_runtime_resume - Runtime resume method for the driver * @dev: Address of the device structure * - * Put the driver into low power mode. - * Return: 0 always + * Enable device clocks. + * Return: 0 on success and failure value on error */ static int __maybe_unused zynqmp_dma_runtime_resume(struct device *dev) { --=20 2.43.7 From nobody Fri Oct 2 01:08:04 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010066.outbound.protection.outlook.com [52.101.56.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 367112264AB; Thu, 6 Aug 2026 12:30:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019443; cv=fail; b=WfoUgv/sUQ5hPM0PwobxJxiCapmTT/DUsFWS6l6As426LQPYaTvZS10Fj10mt1AsvYpEhJpUp7tEgLczmi8ScNZvRu7qvUdCLXj8D550nTjkOT8kj5HXGzyx2ilU1LFHHdcZrvD6rcdFJ9a/obQnsiSjI2+URlgwjgQXlqXCwRg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019443; c=relaxed/simple; bh=Mxcc5DXF805kIeEDkHpjg/gRh3gBDfeGNGSFWkMvfTI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sMa7rPz9QNBABIIWOfvdP3j1ab5Q+qR7tou6LI/CBWJikcnxRb9bPX3iPa0h8kPyUVMrFfkVi9WIas3h6KJ1z+Pwqz4bgW47nxo/ggJs3CbxMcGabCm2iznEgRjvQM0h3yAAjWVKryIhWs6mP86UAKwB5IXFJuIA600uNZTqSIE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=HgDqBOZn; arc=fail smtp.client-ip=52.101.56.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="HgDqBOZn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kF5ibd7EJv64wPQCuclNsnrAoRlkjFGfQN+RGdszetnFA8tY66EFeiBOUptK6nUKWNHrHiMPbszecD0wlPvCWNIsEVtaMAEhaHh2MBPWdvuaHpxiJPAFJSPGk6yyDiCblK+O0B6FvYJ+Xfo4du7Hf49XLGTxkcgDGYR99h+zM1YVqHVcYbbMeJsIp2Gc10+iVc8FnvmMg69YAekUpmFPBE2z+TWAMq0kqtXjmTrcV9PtNw3uYpY7giyB9X5z9wdJ+KT95m8djVoKf6t+yXc04y+TWn+bxwOyJPwtTy7gfCwe27T/0ylok6ss4jjyJ92pT1xCKDJZqUj2QEKMEpNcng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dSVqQF2GWaRBIO/enpIoViDq1n1ewAvl33Xc2Eafg24=; b=Fo9RIGpfalJeMwZG/OimQJtguXPSpNkGVWcdip7NAsxeDfu4v/dQUPqmmqbwkAzO3ChY64Xc82Oz0T301X7LZoAhKPnemMiThZZ4+NUj37t9CTTMkW8/FEZGM0Q2iAecwbKqpdz4g3z0Dlz/abi7N/eXRKJJfbaJ5QFF1nCnmNqcjPmbEl465lnytIZRSiokzK1an3swx5BwSgVGLHt1oUAgYXp+0zhsLq9aKt2faMeDU5Xy1GUnLfBdx11TrZvEPvKaBoVBc2HymaFrXizgdglW/w7qREdb6+YvP/vx/8l3EtT1/r/3ObCPSHKv61i0LnQqVsrg+aOkVGzacXmRYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSVqQF2GWaRBIO/enpIoViDq1n1ewAvl33Xc2Eafg24=; b=HgDqBOZnEwGf+nxC2TC0DexnRpkCnWnP09uHTK7ryBAH5XBiHW1IiC4aodzLBaO1GNlBjT87JtEpJK0AsV/81eIdug14VKQMDQOYepGh4mjgM4OkFgibIOPszNu0bwVimmniz8pmuTtRC2Vb3PAIyHTiGz4NAGnHGWbDNtr3GFc= Received: from SA1P222CA0029.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::24) by IA1PR12MB8359.namprd12.prod.outlook.com (2603:10b6:208:3fc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 12:30:37 +0000 Received: from SA2PEPF00003F66.namprd04.prod.outlook.com (2603:10b6:806:22c:cafe::6e) by SA1P222CA0029.outlook.office365.com (2603:10b6:806:22c::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.21 via Frontend Transport; Thu, 6 Aug 2026 12:30:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F66.mail.protection.outlook.com (10.167.248.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 12:30:37 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:35 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 07:30:31 -0500 From: Golla Nagendra To: , , , , , , , , CC: , , , , Subject: [PATCH 4/6] dmaengine: zynqmp_dma: Fix minor whitespace Date: Thu, 6 Aug 2026 18:00:12 +0530 Message-ID: <20260806123014.2120447-5-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260806123014.2120447-1-nagendra.golla@amd.com> References: <20260806123014.2120447-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F66:EE_|IA1PR12MB8359:EE_ X-MS-Office365-Filtering-Correlation-Id: 951af6ad-8b34-4e4c-fed3-08def3b68504 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|36860700016|82310400026|1800799024|10067099003|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: cXldNTJMpLo5n+8qvUF1LOdFJidsoTSg5gKT3iimozoQeK/rf6GTrYyrDuIPD0Z4vieofvLJ6Vu8J+ZB6X94zv2QA+u5pYH6kMR16CBcoqqQj6VZOEtPCYu0DZF96XEijN3Cnlk22qlP6CGsU7PxSf3vEwb5d/lq4LDl8flsQXxqTVC6a3xbe02zISnu6Khd0wGsBOmN7LdWcRpEY33VHlbOMbG8VKHlgqOwvvZaqWrGng07UfF0hJ2Sfo1fcyr8bjiSbF2K6nl3bzaqOxwWZz9FD3jVPcLJiuOSEJW28xdyQhf5tVNMTwqN8ZxeMgCAE9qMHv3diTzu6BSGoUCJbHru064/SFGXx+31gJGlgzOub/R9z+ljhYgUEob5QRjoImYWMvDAILb2s0hp0VZJEB1owBRNJEzCjIs4F5gR8rt6TfydGl9/PataFk4DAceS2Rac/BbhHrI8y+8H5Fda/qgmF+pailC4A6wM3coxS2aU7w7L5chIvgssxKEkUV6SaniUq97dhXYo1L4Pd0KbZmciQKwyGwZdTx7FIJVWE8Wl9YjjgfZNEfhTmheCYtJQNVvAwMneM8pIpZE6wNP5rktf6+1lL0Hw434naK9kiHpE51TuNE+B6tiDFpz6uD2xcZXdlNbJ7RK12zPwhxYCXLNJag9mv5qmk3XXm3iOrAMPyVexznk5R7mNUW5a6Nb14F1hUoPkFO//a7onyQ0Nlw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(36860700016)(82310400026)(1800799024)(10067099003)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LKIQbKdszX9xHkthWgz3QsnOAHamvdgtMo82i4bc9Mur9CrA10lP3h4zSaEXiy0IBG543spKkPZUnBUgaV0tA+lBfoO+XVXWbAoaePL1iT/VYxRjiR+5yynGzQZus0ZfiOx5mixTls41p/6REVSvstGqW8NVOXmNccYYvImUYbluSz22T96V/wwsNfLECmbVyadHG4KFYiVseplop8OoOPmExH8SBDxswGcV70CeI7esDXw3P1BvvZoOYH8T8y207ctD0PsfdhNur38MBwlkQ7D+m/sOeNY9AMBVMszrImNkeCKyzdNtyLzUo29ghWwr4C1fWOga9Pl8P1MWaF6MS9XrNCuWWi6KSck//9LtapUyYOgn51Tybvc59NSao5OypD74q0HdiJn9pU0DPRJ/2972u46BFNQkV69dyW3bxiCmW/r+cGxwHJoWgzWHI1CP X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 12:30:37.3670 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 951af6ad-8b34-4e4c-fed3-08def3b68504 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F66.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8359 Content-Type: text/plain; charset="utf-8" Fix minor whitespace formatting in zynqmp_dma_chan_probe(). Signed-off-by: Golla Nagendra --- drivers/dma/xilinx/zynqmp_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index c5b05fd52e9d..2d56ea08ce45 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -947,7 +947,7 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_devi= ce *zdev, if (match_data) chan->irq_offset =3D match_data->offset; =20 - chan->is_dmacoherent =3D of_property_read_bool(node, "dma-coherent"); + chan->is_dmacoherent =3D of_property_read_bool(node, "dma-coherent"); zdev->chan =3D chan; tasklet_setup(&chan->tasklet, zynqmp_dma_do_tasklet); spin_lock_init(&chan->lock); @@ -959,6 +959,7 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_devi= ce *zdev, =20 dma_cookie_init(&chan->common); chan->common.device =3D &zdev->common; + zynqmp_dma_init(chan); ret =3D platform_get_irq(pdev, 0); if (ret < 0) --=20 2.43.7 From nobody Fri Oct 2 01:08:04 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010060.outbound.protection.outlook.com [52.101.85.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A7191FCFFC; Thu, 6 Aug 2026 12:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019458; cv=fail; b=RonT/kvpw3RLI/cZrtU2S7gzccrX39iX+sVWkPOaqCkidzLjVS0IbAEfe1BTSaufJBotED1A68Ss5pUTP8HMpaueenuP0P2FqBcv0FPcoXjfObZP8TzkMOAJ45/VplYNUS8xKMo2uHc7a5ab3hdNWJ+rT3I1T259YG3+6mZ8oRI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019458; c=relaxed/simple; bh=5wE9TuE6IkcAgd9H+eP4RVpxpz684IEosoG61s9qAeA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PqolIGxey2xFpsRbsVIItw4rHz0n3e339ZJ1BEbXCFYT9sMQwceXflMZSouGsGJfLF0l2j3VUyUi4jQu/4Ud/4TAxy4XmBGh/nErsE/3aO8+SrRYB8aCh/O+2JXEn9EIp5suvwBbDEekvZYZgR+IwOfvajzzh2skbk+2UB+I96U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=hNprmBP0; arc=fail smtp.client-ip=52.101.85.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="hNprmBP0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k+RIEjXm0774zPR70yrs+WKuOY63/+JLu+6wMPp3xTKyJ85BP2Ayu9OZKDe9N1NaqYXQh7Zqwhy2jDSvN1gdNFYqeTN/saJqGZD4o8dFekdwqrTy7tvFn3iZnB3EpE2ysVJI5qLynYsV0JJgHjG8ArMzBANuc33bmwgTJrH43vAX8JIxJ0H0xJU4pQaTORy6sTPFwIsGtJkiT/vHhTFa4qddWCXyDvLcT4qzWfVESXGBz3GmoX+epyOa4oMsx6iCZzPn6jS7rF3ROxh223vjLaBMQv5+TniXcP9Y1T2Os86+gPeKFDRnJnPll2AcjildL7fzPwyxFSp8z+HLNXyImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uz/0QLtoO6Ht4cHpgxRB3mMpt5uDyBa2kwI4zN90unI=; b=LUTBcV0DS0JaiTbuxmMnTGt18Hs76zafwydm0Piu3o8rdpLm9EqUCxPrCKuShI20Y/DI5prLRyfRevb7F2J/h5xRLP4P/tVx76U400CgEv2GTpSCMfmiCg+nksm0iZv/o8a8g30H2eZ78Q2ueLO9X5UbkoQwrfP7jVFZ1ytnhrQarTfgZzFBQ+a4iDMS4rMfVOM2OGrKXpG+LTIjObCoeeM7Cp3rcbGYuZIPtWh3sCk6vtPJW+jqxMQUq1DAEqIeEb28yoxDBOLiTVBVk2YFl59qeO9mt+6G/upy1q7CQSE5h0DsJJA1o8mVhd3DpSdVJrpPFWG6swnSRxPjKAAvUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uz/0QLtoO6Ht4cHpgxRB3mMpt5uDyBa2kwI4zN90unI=; b=hNprmBP044Dvkh3RANh3UwMPlT0xvPHTmZHJTUVtEWmjd2P8tu7ISfI0JSqi3BSLJOp604SXl0UCuDmjpSDTuDGgweTU44LnlIIXitseRVdyS+rOmBNdZB8JRBcXngIeCTgMEc+U/ccWExrWdzSfOMbTFl0ISSqjDX2ruYho1jo= Received: from SA1PR05CA0005.namprd05.prod.outlook.com (2603:10b6:806:2d2::7) by PH7PR12MB7870.namprd12.prod.outlook.com (2603:10b6:510:27b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Thu, 6 Aug 2026 12:30:40 +0000 Received: from SA2PEPF00003F61.namprd04.prod.outlook.com (2603:10b6:806:2d2:cafe::2) by SA1PR05CA0005.outlook.office365.com (2603:10b6:806:2d2::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.8 via Frontend Transport; Thu, 6 Aug 2026 12:30:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SA2PEPF00003F61.mail.protection.outlook.com (10.167.248.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 12:30:40 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:39 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 07:30:35 -0500 From: Golla Nagendra To: , , , , , , , , CC: , , , , Subject: [PATCH 5/6] dmaengine: zynqmp_dma: Reject zero-length memcpy transfers Date: Thu, 6 Aug 2026 18:00:13 +0530 Message-ID: <20260806123014.2120447-6-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260806123014.2120447-1-nagendra.golla@amd.com> References: <20260806123014.2120447-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F61:EE_|PH7PR12MB7870:EE_ X-MS-Office365-Filtering-Correlation-Id: cb3c61bf-0d95-4312-6d3c-08def3b68701 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|36860700016|82310400026|1800799024|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 9CVdp9EuNP4h4+f0at3+XaAFwzT8YKFs2zQymnVt/QvNj5bcWti2YjkJfqut6/ulAELr4+L/MRIFSmlkt/WSXyx3bKh+HWDH14b9Ns6yBb5BqZB1QC00DtPn8dtbolQMSQis5ZdzSk1AaXR3wrAG7h/Ca76p5ErmKNPDB+8v5cJzjYH4ebfyaqd2S4qx1go92VnORiYPt1bLqKEeKoTSDL0ww3FofBi3GEttSOBUuQsb6MFFAp92Dsk9ZQWvqGn4SyNCl/kLCTBZjFDtlcujmoKbzk1pLWPmUxK3E7MjEHmJtIUzIejNv9Ej0HeECd5cUTaZUBN44XboKHKyuej7P6pWbWiqUJGeVbtRzVs7VBoN0tpOGE4U/0IyrYCOxQn3HI8oeLgYe+saQlRC7zub2wnTjcxcEGjyPz7paRrtzzCfxVjnRMlCzhjKf53nwQZFJkBoQQSzt3LWe7SGG43H04352+Z7HRnsZUJya3WJB7R4U1fVJF/bqUhso2gNNrHD/NEI+NjGoIL49Uwz2ckVezyxZptWuYFRSwGJE2NOPL2YNTtcd5TJiWeEc1IouTfbD+w96ed/13ltEi+zVA4C/dx0J31fANZVo+2wzvaCgI7KG8Fx6qyFSOUW8C/PSAGxtpC4CQ4y+a1uxr6JOj1eKfYOGdrGUyX0XmjYreQij0ahWAiZ2J5eM/UaGclx02iFDp0+ukyQ7OSVOdtVz8ZZvA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(36860700016)(82310400026)(1800799024)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: G0tUkKUt283pKSljuHCku6LQeD7gr0+ZdBQ+xfJFxlNlv0ZGbJXmu+GQAvzAvkb6jMPcrqvmSwtX+uNCECSPVbpNvaed45E+2S9h54qNmbbucOdufTZgzmDXrYdaXhvn0k/iEADxRR01Hb6nmgxKCjAXzhPA0Egry9YmxCkQIWGQQ2koJ06PfVYbY55wDOXllwrKkC5UzRq9k9kjovIpyBlkndZIQrz1jRLOFUaD2cTugseXrlh/VBr6iAdfZKoD8zivaKVMoGkHQyJ/UZ2mZ+alRQ77xElWHOy/Zcfe72nmdyf1R8k7CTsRIPDzr/YqgetWY/1uqocda5TpxfCjfsC0V9HA9GliFdRFwM9Ax/t/HPuUYy5PCkl/T6gh5HiNufUN5srRYiPSCgqZfyavZuQ+UANjMonr6rCNI/Yc+5Tb/DZ8IECiKwtHvlirlJE/ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 12:30:40.7055 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb3c61bf-0d95-4312-6d3c-08def3b68701 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F61.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7870 Content-Type: text/plain; charset="utf-8" Zero-length prep_memcpy() needlessly consumed a descriptor slot. Reject zero-length memcpy at prep time and document the behaviour. Signed-off-by: Golla Nagendra --- drivers/dma/xilinx/zynqmp_dma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index 2d56ea08ce45..e70874d65123 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -836,7 +836,8 @@ static void zynqmp_dma_synchronize(struct dma_chan *dch= an) * @len: Transfer length * @flags: transfer ack flags * - * Return: Async transaction descriptor on success and NULL on failure + * Return: Async transaction descriptor on success and NULL on failure or + * zero length transfer */ static struct dma_async_tx_descriptor *zynqmp_dma_prep_memcpy( struct dma_chan *dchan, dma_addr_t dma_dst, @@ -851,6 +852,9 @@ static struct dma_async_tx_descriptor *zynqmp_dma_prep_= memcpy( =20 chan =3D to_chan(dchan); =20 + if (!len) + return NULL; + desc_cnt =3D DIV_ROUND_UP(len, ZYNQMP_DMA_MAX_TRANS_LEN); =20 spin_lock_irqsave(&chan->lock, irqflags); --=20 2.43.7 From nobody Fri Oct 2 01:08:04 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010005.outbound.protection.outlook.com [52.101.201.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C6F1FCFFC; Thu, 6 Aug 2026 12:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019451; cv=fail; b=PqDXNsHC9DQSXEe2oM6fcY4G8mscPQSEGATshyldildUlbm0tK38VCHORmmJmD0sseA1v5Z9AnOSv9R/POB6V7hF6ftHZfM73dYdxc0rE6EI7UcHJfV8qQh5LPMMcHZ8wJVl/02p54uRKOv4/134fGcp2t16CxkH62V7ORx54Eo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786019451; c=relaxed/simple; bh=OISmsJuFC794aH5kGl5TPtE4h12m8S6j31gmY5cal98=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r60zY/1kwCK/M6DMSlPWMm2gPEm9WWPu9spyGlOcmiOs8SZ2j7fWkixEKRhyT7McgsJbsJmO09ptF5XI38G/Vbz0kSgM5umBWc1esXdcEskyxCKrOplN65qEbA3FUj6vbtEZWNzk5dMAiGKX3SUNRFkLEhsa2gwBYnKKaq3fqpY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=n7bkV6Zw; arc=fail smtp.client-ip=52.101.201.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="n7bkV6Zw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ixMHr2euEPJDj4BLNtKr4JJJNRIknhLs8B4HNrjg1f8pkc6eZx/DVBcXwLz2toBzKJbADhx89DiyReOJQNbEzbDmRyMOAGKkgb6hkqdt8KG7BlMb8/gL0AsKP7YfWCERylVVpqxfrTEdWAgCheq6AbxnEhEtK3IAzSxZw9+x+md1vAiKchqlcaUWQFWJjKdmg3RxQAuLQZ8tpo5mn+j9O8On16vqOYsDMxouqjDQ0IndQjiyyspRHi2VxeFCrPqBrou1m/7umuHqbr7ilwG2JmB7qcNX6vumkgd9GwEyuz+duWZa5SMTP+Px25XrBbp+Hh6f+BVlUJEmKaGKQDB+6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HtDrko0b9u2qZYKEW+zp+qQUu01jh71H+e8wcxP9L40=; b=nZ0nQNKAADATSN9b/9iqPvqNqh+lPK84QFb5N3Pg+sXWd16cel4UJCUKVbVOHw9O5Kd9EWx4bpK2XVKCkv9xSz9xBeeAl1zIaP+8mYQUkhDckhEG2pIrjSBY7R8m/HSbmfShPEBEpIiXzDZdWTkRvXXoliXI0sWh27B6voez8VzH523uqMZGWa4Q7aL6XwxkeHR9EjrjCphNzxiRQLdAXzfK+4Idn6StR5UhHXKD9F9GFX6gZrh5PMuVA+M1qUCQEpz0SdAqxmkBe55pb0JFwLezRtDjJQClefcfqEFpyVNwBW5fsjd9ZaRUqwjimBnh83DD4Js3mUPO3ylUGNTXJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtDrko0b9u2qZYKEW+zp+qQUu01jh71H+e8wcxP9L40=; b=n7bkV6ZwJLDVdlxGDNPWn6P5nhP/dSDAGOJ0+RA7aPY7tDFC2HaVhaSWekhktk97FbnN3xBCPVgCmy1Bw+RV36jJjvFpovl3vwjW37O4fWaEfUMabWZIjuX/SQZMUgtyBhxxJHbDeYlh9s7BwoAoWHE9qaD3nCACkDeZXzT/y8g= Received: from CH0PR03CA0076.namprd03.prod.outlook.com (2603:10b6:610:cc::21) by LVUPR12MB999137.namprd12.prod.outlook.com (2603:10b6:408:39e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.20; Thu, 6 Aug 2026 12:30:44 +0000 Received: from CH2PEPF0000009C.namprd02.prod.outlook.com (2603:10b6:610:cc:cafe::14) by CH0PR03CA0076.outlook.office365.com (2603:10b6:610:cc::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.21 via Frontend Transport; Thu, 6 Aug 2026 12:30:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH2PEPF0000009C.mail.protection.outlook.com (10.167.244.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 12:30:44 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 07:30:43 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 07:30:40 -0500 From: Golla Nagendra To: , , , , , , , , CC: , , , , Subject: [PATCH 6/6] dmaengine: zynqmp_dma: Remove unused define and duplicate IRQ bit Date: Thu, 6 Aug 2026 18:00:14 +0530 Message-ID: <20260806123014.2120447-7-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260806123014.2120447-1-nagendra.golla@amd.com> References: <20260806123014.2120447-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000009C:EE_|LVUPR12MB999137:EE_ X-MS-Office365-Filtering-Correlation-Id: 37791acd-1f14-440b-34ab-08def3b6896c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|82310400026|36860700016|23010399003|11063799006|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: NqEf2vrn0sSqdHWQOd1Nseft/xB+BLA0CXqcLUgwcyjIATN/Q3FVheSQl++VtzC0p10ngHW7Tg2eVFNy6VYp358/C5wRw3Jw3z8Fk2/wlcvw7fhzbb+HRbFYpipWl9AFWRqqvmQ/JsCyeESe0Jk7n1mRPyNvpX///aPGsi/1nVcYh+XRGkfU2J/e4jt6HrmiwVG3R6VPs3poQTEUWfqad9nRy/x3xCOHc5GLGYxts2mck8IJXVkWc4XzCtdGJlADKbrvHDV6+kzy6dvCeaaX7rGhgwfx/QSoiK8RkguTGJk2myQwwjgRA9fC+/1y9yzjiUFu+FyzJdN3nJZ0vYijkQMQuImBb38fQ3WbErXF34nT3PP3fpi55IHVZ9a3pTyssYtuX285qxhrQgALC5yW9R10fjZb0VqChKBAYLvv67DF5zBj19V9fJZLgKqJpasCsppMdMbdm2N9v7rXBFPvARGMUjNbVqwYOsisP71YWCcX2GHkzNRFuRzmukRVgA4voVdVs1RSjTu4BAbz8mWwykWKe1xs8faBtyhJ0AxctnrArasZmSU03VIfFw9TuUOIL2KKaDWpgig9FuCsZAKAIU2+JpH0QX/s/XS8kNCTTc/XYYkSXXR0lBvS8KD2hLjRMaorK4kddaUG5jqC/RRsPg3KvUl/5/0YJUXmyq3YyS0veajB4YNQg7XFpJ5GiyMHBsmZgtB3gAd3y8J9//C5IQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(82310400026)(36860700016)(23010399003)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qzchuBRrEEVpeACRAm7LMe/FYGQQMJUhLpl5i32hSEtMVJLranndWN4YvUDtUn823L9EZvxyCxge6i1M9pxp1jk6cgtlsQn0R3TEwpHHImXFu9Gn60WULlB1sAqzvYpw13cqirZivfDLZU4bHMmtT6W2PY7e/eYgDe6FV4VWW/emH9TBLNlzZhIlh+9MjqvtZGPxuxuwRyfn5Nce7rx3iBQNIxX2Y/bGASqk7PnSj+UFEdIG7dibLohA3Rvg6xdkXWIzkqLgZ9OajbrLO9XKng00vokKhakPMG0jYpIMIfryL4GgbQ0yvIU6Qo7RfwBw/ATrSqHemx6SIsIlPI8dPVHmtiKzF33L2wE01OAPk7G/b3hEuyDwjLyQkZ0s27EZtu3OV6vhJE+d3p/bY96o/zoMS9wFFXYXkEbE0NtQvWRvX4opVUrhf09t/vjFE4wX X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 12:30:44.7712 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37791acd-1f14-440b-34ab-08def3b6896c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000009C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LVUPR12MB999137 Content-Type: text/plain; charset="utf-8" Remove the unused ZYNQMP_DMA_SRC_ISSUE_RST_VAL define. ZYNQMP_DMA_DST_DSCR_DONE was also set twice in the default interrupt enable mask; remove the duplicate bit. Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- drivers/dma/xilinx/zynqmp_dma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index e70874d65123..fd2dee4ea17f 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -112,8 +112,7 @@ #define ZYNQMP_DMA_INT_DONE (ZYNQMP_DMA_DONE | ZYNQMP_DMA_DST_DSCR_DONE) #define ZYNQMP_DMA_INT_EN_DEFAULT_MASK (ZYNQMP_DMA_INT_DONE | \ ZYNQMP_DMA_INT_ERR | \ - ZYNQMP_DMA_INT_OVRFL | \ - ZYNQMP_DMA_DST_DSCR_DONE) + ZYNQMP_DMA_INT_OVRFL) =20 /* Max number of descriptors per channel */ #define ZYNQMP_DMA_NUM_DESCS 32 @@ -128,8 +127,6 @@ /* Reset values for data attributes */ #define ZYNQMP_DMA_AXCACHE_VAL 0xF =20 -#define ZYNQMP_DMA_SRC_ISSUE_RST_VAL 0x1F - #define ZYNQMP_DMA_IDS_DEFAULT_MASK 0xFFF =20 /* Bus width in bits */ --=20 2.43.7