From nobody Fri Oct 2 01:10:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F0D33E7BB5 for ; Thu, 6 Aug 2026 11:27:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786015640; cv=none; b=AO2xAK9JpRNzhDBjgKXs6ptKd+0kEWlsGkAUaIoRFHX8yDtQq9syuFwDynh/5uZqmD0XzoWTVCA1SFV288PD1uHNTzM6DH4CX6JV38A2WFh71pjvCgCXGaTuzXxM2QfrelIPf/3S3ABTrCD1I7IDY5kKdFk8HP5ZYj7VYZ384dg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786015640; c=relaxed/simple; bh=eLxWKGBLkeDz1JqZfOpD3989Sf1YC3mQCfUbBD7ETJM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qYyRMysNadZJ1ttqlHTQ9+39jB7RjWZs7iHInqBXc6QyeBRBYXuD1RJsha169Ji2IWfuqfHRPmtu2EHMPT/FWCN/dafX3AfLCdrksgUjirIgu2uqofnRfqPHbG8kpEJxsgac/Eciwkz6vhSCh/iyTH+TN9bxHvnyEgU0uLIRogE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gHd+5V6J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Wk3smVUQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gHd+5V6J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Wk3smVUQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6769nvRr2725115 for ; Thu, 6 Aug 2026 11:27:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=L77CxXnq1djU2pUkBfQBfZiw6HJYKEniR5r AZJORZao=; b=gHd+5V6JIZMWbOyStYdT5QI3UAU4V7RLQiewfXcT+AnMk7l2Rzz P417krtiqT1YjMhQaYcL0Lm5i0gLfJDt/uHTO1QEpvUCfwOW1m1iZzoE2UCBcUbq /6e0Ua0JSd66d9J/3SCCZ4sHtCVpNMZnoGLbMkt9DJqmhrxVXxbxcqgECMOcClF/ b9uiMasfzMPT6oTqYeo72s5bu3uGLznIffUUskflCCWQ5IQw3z7urpEuMwvtIHaM e/UfuVrxZxJWM/gwFxfn4Dhmot+F33lra/yxcqq6Hf2lF4npWi6L6sVrmwc1apQt DI0PAg36RGsTtoQm5RM4G7NT9zmJRmDOLGw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fv9dmm27k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Aug 2026 11:27:17 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-848568a6f62so3640371b3a.0 for ; Thu, 06 Aug 2026 04:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786015637; x=1786620437; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=L77CxXnq1djU2pUkBfQBfZiw6HJYKEniR5rAZJORZao=; b=Wk3smVUQYUECDGfkkgCcTjdRsV5X49pITRzqbKsaFHZTvK50IFCePsOHDV8wqJLyLw oJXbQGr37iLTCmMpEbpHGsVFmajDhIj3vUIshCykfd3BSY9uyviEzOGzXxnSXLk5MAS7 lIH8zH48xaOk3ZFO1Xx6A1q0i1hzEUQNO6NfFQAOb1t5u+G6pwsYq79i420frD7rnESV EH9XeYfjN/YM1VeTStr0SlM14EJEtoCpnS7w6x5eAjTvFkKzw6MQQjicZyQf0A3u4Nbo 3SByEy8mO01eueaoAn6gZzPIaErH8+LK2w9tQ2qWKGYo1KtOo5a+fVM8dgN0//h2mbms bE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786015637; x=1786620437; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L77CxXnq1djU2pUkBfQBfZiw6HJYKEniR5rAZJORZao=; b=F8qZoQqi1vaY/48epyxmEOjcIeZw8y4fe3fbjeL1QkhyhnM/7blCX3wgmj7lIHmL6C 6+EK1QGsFiTrhFH6+2G+uGV5hT2HiAj3BRq4l56R09Q+P/2fwuTl4x1kzH2gIiF57fhv Sz2LVDDg5gCkrsc1BcX7DZjBRKshqcN56RkdTd8EnukyNmr4nrv+Exiqjx0o8vci5q5M MrTFJcszWDAzlQdTAFj20go9nMKGjFyZ+aXoOm7r1jqFm5+wV2tW3O4t7FAP8GTYhVo9 5lBox24L+yXwC6p0sAEMHxQU+cD4QzHvyOTyj/klLleltDtU+yh73JnBZRhf/Zm5X2zs +lKQ== X-Forwarded-Encrypted: i=1; AHgh+RrDZVVDSgkXjNU7qOqHJiFGHP1iOwSUGERkxTf4o6mjBBH1NYNmFH3XivSsv8h/Txls1oBIuMNZYfdUtsM=@vger.kernel.org X-Gm-Message-State: AOJu0YzGe+N/9qfRjpggvpm1wgOM98kTZ7IrH3jLCYu9oWXIfPWgnAG9 HDKhinTAMAUQDONA7aATAkTOmDU/VwLTOov+CVuiLTqoQjrfoYFzRRticY7/uhatw4z2mZCYDWx /fz0DB9T4Xg69M6YGHKjQEy83egdQXn2S2J1CzGGWwJMgBiYVvNIMcKVF9LVwQr0/cBU= X-Gm-Gg: AR+sD116GG3PHBRyiBs6/+kN82du4McDo8G9H+DDinq0B+e/yEQX9Ey9R5mVnMB5qlQ /8+EgxCf/TY8F1Q180rUfLGeI5TuRfyFX57hYSPiHPzZOOyDIkAOwC83pNWMNQFz2QzK4UrfQ8m I2mXNuwsfplWzp1BKC2Hs5rPwU0xCCotDeZTDkoLW7VyeX6zDXfENnfbzDaynBwmRvR95PMf6G6 hfsIQIuHlEKxBxuxVDpU/VjU4h/PWglKR/3Y/5h7wfwmAAWMzW17kIcKPevfJhSRH783wfjCUMB isK7hsWMIjQ/9GLcZrHFxPAmVY90zRcUgyKXUam9fjZVGSKCFcg1f0qZL/PaWs95uC1bsGVlYuO F4eNWjabMlAPjSahloAD33hqO8g0= X-Received: by 2002:a05:6a00:3996:b0:84a:2fff:ced2 with SMTP id d2e1a72fcca58-84f2e0edf21mr13222378b3a.35.1786015636668; Thu, 06 Aug 2026 04:27:16 -0700 (PDT) X-Received: by 2002:a05:6a00:3996:b0:84a:2fff:ced2 with SMTP id d2e1a72fcca58-84f2e0edf21mr13222328b3a.35.1786015636119; Thu, 06 Aug 2026 04:27:16 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f453b2688sm1216484b3a.22.2026.08.06.04.27.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 04:27:15 -0700 (PDT) From: Mukesh Ojha To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Mukesh Ojha Cc: Bartosz Golaszewski , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: [PATCH] firmware: qcom: tzmem: Use DO_ONCE_SLEEPABLE() in qcom_tzmem_enable() Date: Thu, 6 Aug 2026 16:57:09 +0530 Message-ID: <20260806112709.4018596-1-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=TJR1jVla c=1 sm=1 tr=0 ts=6a746f95 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=hD80L64hAAAA:8 a=EUspDBNiAAAA:8 a=B3sWOgbLTSL5GjQ8n9oA:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: 8Z03sdZ29veBVxRSWT2JsA2ChgkFUf2_ X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDA5MCBTYWx0ZWRfX5M6e+r8YztTK 2Wi3p/0bebiPhQOlCnHYPDdXtFyhvmsQrgEnWIK+S9jjeawxzsFDCupacQQFxHUV7c5cM3EKlJ8 xa+6Si92sHKQDsXF5RTJ2xeB7byLPIU= X-Proofpoint-ORIG-GUID: 8Z03sdZ29veBVxRSWT2JsA2ChgkFUf2_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDA5MCBTYWx0ZWRfX6bGPX1VwplOR 6lSOmnI7n9LeNhbFcyzhjGhYH3tBj0b31RS9bjQp1qeZlWYpF9xtnxxIgOp0AB26S0Hg/6/wIko ypI7fUi5/vz4s5FvKklPGcMK7kdMWyiQjaDf+QqkL6qV+fzRPozUN7qp0cxkabhvcIqbc098U7p bvHHUT0iwPUX3bBWAsmOGC5SG5ZGGMNJoREkQrQQ59uitnyF+k6nwXn8v+0smbFf8cEMWPhAo2B 8Yt8gyR/Dh/4UBf+bfKn/BfG1hfdSNwzIZHb4PmI8xBE9DQEVObG3bYQiBrhfg9Pv+p00ng2+uK h1g8kkqJoKkMVSXs5p1643Meq/X2AEHfxZqtZD4E882JH376tEwLa1WcB6YCKhAW9KzEPVIdzGw 3J5KH9c0NFSqHF86U6nZEdbZomMhcnhq0gBKWi1yW5WmuNFsUnv8+WP99T6p3VUw02a4akJDFh1 yXWj6D3BbS+yzIQwDcQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_06,2026-08-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608060090 Content-Type: text/plain; charset="utf-8" qcom_tzmem_enable() is called from qcom_scm_probe() in a sleepable process context. The helper it wraps, qcom_tzmem_init(), calls qcom_scm_shm_bridge_enable() -> qcom_scm_call(), which invokes might_sleep() and later acquires the qcom_scm_lock mutex via __scm_smc_do(). DO_ONCE() takes the once_lock spinlock with IRQs disabled, so invoking qcom_tzmem_init() from inside DO_ONCE() runs a sleepable call chain in atomic context. CONFIG_DEBUG_ATOMIC_SLEEP=3Dy catches this on boot: BUG: sleeping function called from invalid context at drivers/firmware/qc= om/qcom_scm.c:334 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 49, name: kworker/= u16:2 ... __might_resched+0x148/0x24c __might_sleep+0x48/0x7c qcom_scm_call+0x30/0xc0 __qcom_scm_is_call_available+0x98/0x100 qcom_scm_shm_bridge_enable+0x60/0xbc qcom_tzmem_enable+0xf8/0x118 qcom_scm_probe+0x2d0/0x680 [ BUG: Invalid wait context ] ... kworker/u16:2/49 is trying to lock: ffffa83e8a485e38 (qcom_scm_lock){....}-{4:4}, at: __scm_smc_do+0x70/0x488 Switch to DO_ONCE_SLEEPABLE(), which guards the one-shot init with a mutex-style path (__do_once_sleepable_start/done) that is safe to hold across sleeping callees. All callers of qcom_tzmem_enable() are in process context (driver probe), so this is safe. Fixes: 9941fe8a04f3 ("firmware: qcom: scm: Fix tzmem state on probe retry") Reported-by: Marek Szyprowski Closes: https://lore.kernel.org/lkml/5ea74dd3-7471-4c7c-9242-c2005312b1ab@s= amsung.com/ Signed-off-by: Mukesh Ojha Reviewed-by: Bartosz Golaszewski --- drivers/firmware/qcom/qcom_tzmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qco= m_tzmem.c index 0fd9581275f1..ebcdee3c5975 100644 --- a/drivers/firmware/qcom/qcom_tzmem.c +++ b/drivers/firmware/qcom/qcom_tzmem.c @@ -518,7 +518,7 @@ int qcom_tzmem_enable(struct device *dev) static int result; =20 qcom_tzmem_dev =3D dev; - DO_ONCE(qcom_tzmem_do_init, &result); + DO_ONCE_SLEEPABLE(qcom_tzmem_do_init, &result); return result; } EXPORT_SYMBOL_GPL(qcom_tzmem_enable); --=20 2.53.0