From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E848731ED7C for ; Thu, 6 Aug 2026 05:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993724; cv=none; b=camhGkjZtBVBqjI+aURoDEebk9A8s7PbsaIsth9sp+f4rBiSw5QE7s8cC6hFhoGG6c7ItzZ+uituXCV0xccih93JU+x91kgEmV4iudOeOx/sDHb0P07sxF87NrEH+1FziSLR9AcLNDbDuwTPEWBkjQ34o6npxiWqH2ddkCyaiYo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993724; c=relaxed/simple; bh=0iWtgDDIFrHYDk4E+PsLQmmYM0+L8OeY1QwmiBglMDw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sh4w9Xg4XD26O5KqxHMk7nwNGziZBHlCB0+p+VQTvlvgGa06fSv3gNNeckCKvHUYBp60DDUm+sKrqf7O9onbgCydoxd5P7b2/Wbgy2uu/Qp+tYEEwAMb5MbtIep9M5ALxdhDPOKTatWuXVzbeqGYpDRld6787bbY1JaafwIC9JI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZfXrl9Hr; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZfXrl9Hr" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84e3007a2b7so1659973b3a.0 for ; Wed, 05 Aug 2026 22:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993722; x=1786598522; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eVcxW4CrMFPdiaxkpRl6bL+HxVIt7TtpKeqoh/VcgyE=; b=ZfXrl9HrFLN/VWxLAarYEHct2xbCNzjKX6akDwmhuDApFLopxqM+5DSSJ+Yfp2MH1Q ljad3realcuIZp/rKk1EQky6gcnVPZFLPGz8Di9DpvpAWqPkwOcCnAD70f9tFV67Ze/b MmU0HvH4Fp2y6qRdvvdRveImBpAl/OS9JD+IOUZlmsfbXit53n/vx7Q/Z8x0CV+b4xSS eZV233+2UkPyG61LQeYNWDX6NBO4sB5psoNRkvkquTEI5wyb2QcJtuUkk7wUFr0q19Ho gp/bNaiySOBWtWCFlwURasqiMNqFdApmVQhMcmPwCGwzy5Xs6shS8w5mhFRKsoEhqA81 zzjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993722; x=1786598522; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eVcxW4CrMFPdiaxkpRl6bL+HxVIt7TtpKeqoh/VcgyE=; b=tBgOJCrUcntx9zLdY58YghttXNm5M1nRpPQNQQGKUfSmRVAJOfCs3toTvJPlOqZ5Gj ZeO8axfv4YXY/7WspFaFtQ0HMSm0ZWH4WP+V8vjlIh1nORT0mxTRTtofIT5cKXb3SJJf R50XPgkKkheKxIKTU3JPGxV4kIv3px9asuii1E4dul0KX0OKomDQHZPD+RQM7kHg3ihQ jlxLbh7GwuY+6idGO98PiAWLzxYqaBpTeWroZOMCjXtd6JRtkUpoUruyPhJpoMHA0ReO C6KeAYM1go5QccW+NHcOphUQU8TXrninYhIHi8h28UbL9UCH1E35T5MOEWjOkyUafTEf r1+g== X-Gm-Message-State: AOJu0YwxO/S4pZSr8CCFSZDc8TZnq2nCbZVFolq56VOATJDJLYH/DWal rdP0B5Bey5SUR9kjhRZr6vr8ndc3MoHZwWZA8o2VimusSpwonk71mOL9 X-Gm-Gg: AR+sD12snZS5uU1DaJx0J2Vt4qzYxzhP4OejV3T6WQv1Y4ipa1nnbvLw93ytgUpeGqt 6FE5/RieBsebX8Dcm08TA/yfJ/2kNtSrh29wl2Ng4iVMt9eWBmu0YGOx7vBZBTskfu9NXhPy3IZ overKmwxvIAzTdbZ/7iWdvZdnHAx/OZpZptKtuwWeklilsWZDV72EQUhEF5kZogS9xG6H4sAXq+ Ef6aUO0nKQpV0Q7R21GQSgslDI7BToTDU93iMG/5PuLfkZjPDrxCfKivKbn81tvg8y32v1nse1V 7lKVX4p62LJA5MRnrH/ioPnEFmqjeO5v5Gx1QKgwifQLyUPM+mJznXM6gXz+jX4kJVBwW4G+D3g zyq+4wq+YE1qfEhWni/0WBgRsSy3xnrSIoUi22/+W4nS7DcZofpfu26dEzdEtq7cUFuNXlBkRxA w88TsldTApv2S0YIEBEwuLuDnKhWV3X4d6RvXXsOPykZ0y36H4do6RCm8KoCmyokOv+0VcU3ocL 4C/r69B2IkiM5hy6NBbhBdnArodyznLIWGO3Q5r5sNr5o4vm712NkG8r87nB1PD9O6XThlTOpD5 FJGF X-Received: by 2002:a05:6a00:14d3:b0:848:63c9:ee38 with SMTP id d2e1a72fcca58-84f2e13adafmr13246503b3a.39.1785993722219; Wed, 05 Aug 2026 22:22:02 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:01 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 01/14] ASoC: rockchip: rk3288_hdmi_analog: Drop redundant probe error messages Date: Thu, 6 Aug 2026 12:21:23 +0700 Message-ID: <20260806052136.21034-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rk3288_hdmi_analog.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/sound/soc/rockchip/rk3288_hdmi_analog.c b/sound/soc/rockchip/r= k3288_hdmi_analog.c index cf642a23c38a..d88d5ccfcdb2 100644 --- a/sound/soc/rockchip/rk3288_hdmi_analog.c +++ b/sound/soc/rockchip/rk3288_hdmi_analog.c @@ -185,10 +185,8 @@ static int snd_rk_mc_probe(struct platform_device *pde= v) gpiod_set_consumer_name(machine->gpio_hp_en, "hp_en"); =20 ret =3D snd_soc_of_parse_card_name(card, "rockchip,model"); - if (ret) { - dev_err(card->dev, "SoC parse card name failed %d\n", ret); + if (ret) return ret; - } =20 rk_dailink.codecs[0].of_node =3D of_parse_phandle(np, "rockchip,audio-codec", @@ -223,11 +221,8 @@ static int snd_rk_mc_probe(struct platform_device *pde= v) rk_dailink.platforms->of_node =3D rk_dailink.cpus->of_node; =20 ret =3D snd_soc_of_parse_audio_routing(card, "rockchip,routing"); - if (ret) { - dev_err(&pdev->dev, - "Unable to parse 'rockchip,routing' property\n"); + if (ret) return ret; - } =20 snd_soc_card_set_drvdata(card, machine); =20 --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A13730DD22 for ; Thu, 6 Aug 2026 05:22:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993728; cv=none; b=NNQaC2dQp5odFsmbJeh+XOghHak1ErM+RCFK0iuO+gce5AToKS+j3LvmTckaYVlSR4YqF4XuFLAZzepky6jEwamRG5sCPCjuQgWVN2p2EJtgK+5VN2ZWZ5vvAYHzTOfDaD80Km0ACcZgx5HCYKXqB6t56TC9ToWs3Aq6oHsz2MU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993728; c=relaxed/simple; bh=FqZUrEDZcpuyBcWy3h2r4UG7JkoqFXQUnqFWVQUwCtA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WkpGB9cix/ORdK6nSH/AXkiWHizc8qqxU5DNY1xyfehP8UMXdy0BGKVvgxzG1nu0E/fJOkqfpzW36qY2yFt97pa4NzHCW7Vr6YlD9XXD4Ic9QabE5/oEFzuU3lDlNglOomuEMI0dR0b6h88ljkcKnpoCGaezQV4/z7q5qOTmZgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fwhQiUzl; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fwhQiUzl" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso2203447b3a.1 for ; Wed, 05 Aug 2026 22:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993727; x=1786598527; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wS5N1HI6JBb7BYnde9ZKmg1y6INP5OTp62HALVYGh98=; b=fwhQiUzlkovGVjzXbJVMNYhWCoCTZITJIFaASQADaHGp6VAsnANFRbKQkZjzzi/EbR FNP3ZmUrE9nPVqgkSffuBgnqCO3tFtNixL5jpyHGX3AM76Lo9WOfwde5MZWLj+PsXo1V UbgrzCcFb/fyl6A+mniu9rXpHPHtlSjUSg+WNMeRvc6fpAv1ipbLsaciX9TcuzjdKdrq Yrfg973tt0DxFUmSzh8/icyY1xoQuqA31GSP5oxaNr7gsxrVqv93yq9csfToQB790twg 3/5idRw7lvViLpNKKuOzTRXpALxjULxS2uGrLVpW0nud+6expEt20Fjf39pJFREtdBFF oxEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993727; x=1786598527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wS5N1HI6JBb7BYnde9ZKmg1y6INP5OTp62HALVYGh98=; b=i3hJfAvdZnQuBb5lNA+9qEOWj9x5Nb8Y6di9Kws7br9maDKatnUn87KK6xW/dIL9oB aG5t8l5Kl9wZ6QxpKNCSCxiSsyDQ5h3cpGJRURw5eA1NkKBisNNLJ8XpXbnmL8BWn414 lctDh7VSIxuYopvnah8+akgWkCwQjCVeuUb1ROSb037Gs+RmUX/4rwVX6+g+WeyatOoU Cq17fsQrkPNbu+oFYuY7hnLR4zzvbx1+CBN0aZgO38PZ+SXYWjHuHQV/Y2anzRZCnj9n P+aG+mFzo00EFV76t2+XArW+F6FswXsR/e0dJDby9nUv4CBrRguRsuXo3BdxxXvo61nu bUtw== X-Gm-Message-State: AOJu0YzJYW9Aj53igBus8yPsVi+ju+JS7Yenedx+Sfe9cd1ZnaPTFd9t S9xn4q7ixmOAiI9i5M49jtQQyp/2wmQOKYpizVEP2APHcX4oc4fUeNmt X-Gm-Gg: AR+sD111M480yBxzVYCyEBWSmpD/sXtbJ60bJMMbcsKw+QAkc0i97DOD1H3Yc+UOXr9 /3PDG67WoczlbtGhX3r/YOBYYKd4R4QeqwHuEvfwzM401fpGnSin4DfXp0O1DH9rq87mIqXNFjK lIOLYbq/XOpVEID4XQ/Nf97yojgQK+Vn98buUL2NLK7PigSR8P8McapccX/FWXbXu7/FApA5A1O YrFt4r6ipjXfUCSBQkH3AJwCFtYPyZMGOb7mtNsr1Zh2DWTr52U4ufh1zlmDbaZuZAl61QNLuV8 Uzs1ypbYqlq6JVzw8rLDXaVUmR/ZH7ipOHUTVXC1+Ji8E38B3iwHBcN6Xp2gDFdrh64zg7pOK4F otpL9NDr3e32gaPFufjBQfar4Z2+nUV6TWaLsr367l+rBzsBAEJY4c+wcn/lH/QpXIYbubAw9ut yxIgSHaOdO849j5vaopT9gLE2cwvzdCny3TE+SuXtC/pS7XtvdWyxF4WQLOlNPaEMFFK358TnNo 25OsaaT+92/3zwulPF5fCB7kKlC/jcSrl1nOB2QhurJY+SlzDOxASuqjwveP4gBby9UJAk7MQBQ RHKD X-Received: by 2002:a05:6a00:4b05:b0:848:56ff:6ced with SMTP id d2e1a72fcca58-84f2e0148a8mr13181609b3a.8.1785993727007; Wed, 05 Aug 2026 22:22:07 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:06 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 02/14] ASoC: rockchip: rk3288_hdmi_analog: Use dev_err_probe() for error handling Date: Thu, 6 Aug 2026 12:21:24 +0700 Message-ID: <20260806052136.21034-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rk3288_hdmi_analog.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/rockchip/rk3288_hdmi_analog.c b/sound/soc/rockchip/r= k3288_hdmi_analog.c index d88d5ccfcdb2..541163ed56fc 100644 --- a/sound/soc/rockchip/rk3288_hdmi_analog.c +++ b/sound/soc/rockchip/rk3288_hdmi_analog.c @@ -205,10 +205,9 @@ static int snd_rk_mc_probe(struct platform_device *pde= v) } =20 ret =3D snd_soc_get_dai_name(&args, &rk_dailink.codecs[0].dai_name); - if (ret) { - dev_err(&pdev->dev, "Unable to get codec_dai_name\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Unable to get codec_dai_name\n"); =20 rk_dailink.cpus->of_node =3D of_parse_phandle(np, "rockchip,i2s-controlle= r", 0); --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E78638551D for ; Thu, 6 Aug 2026 05:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993733; cv=none; b=p7yTzGt1i2Gk2mZAXWQ4X1Ke1erty0HfmKBz4/GGCFSmQznnT2YwaDpCcCuic6OUNvubp40fA1Tw2PkjyJduHQ30/s0PyQMjISbiGgzldEATvwcyaxWFVBZG8Th8oVng/K7qvOceC2/mzljI0Soykr4RWzrS88iZH8zoiomFYoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993733; c=relaxed/simple; bh=mlmqnn4Q4LPR6Lrz7pE4C7Sgql/X8hf1PPLJlq0NjVQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uTO8IjlwpXoZEuSemtLNTmEGbR+wu+I3i6c/e5BOEQZtqiEr8PtlC3UmQR4WQFgmrZm+jQO8P/+d7gUlyZQ8yI2j+04iEQg886AoJdML/KMQR5VE2nPBD/QPXEQnw9kZ8KDmc8MAZFJea/gmF7vMN2pHbLbjYHN4IRg8nlpIMHc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lciSMdWQ; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lciSMdWQ" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8453427d3f4so2127561b3a.3 for ; Wed, 05 Aug 2026 22:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993732; x=1786598532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AjOMq1XsUpQov1kpLT0My6RNRrW7igNYjy0AQ6ioFe8=; b=lciSMdWQv3uDulFcodaRNVyjLHYDR7fhJd9BfhrzfBg+u3RDw29KDybInkapCJ+Svq /NX8bK6hv7K1so+/zHdUDSzYnRU3dg8e2Xy5NKxoP0O/Bb7PKH+hEh3qEFGNKwTKRgja lrodHbU9rihlpYqHtXZrN6SdY76vbqOwtfFHP97yZ1RjQZ5ruEJMLIU8F/zS0aA3nkmi yL0bd5aDuI9iDGrAi1wmZDo8p5lfMptGGZLxZTEr1b1vDDylRrN3wxqEFjWriNTOew4s TSwHr/G1GN3oFqZtpDJ/rtl0PBhEHl355ghpQGXnLKzkGK8uw7H7u+gThRbs5xxUiOey DhkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993732; x=1786598532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AjOMq1XsUpQov1kpLT0My6RNRrW7igNYjy0AQ6ioFe8=; b=oBjyS/syNC5kB4mjpW5ZIuywjpqKyoqh8OdUSByc1wFrKn9UrJnXl+2h7HkmXp19g+ bpsDBmXV+Cr5a+rxcUH3SVgyq/Ju59SBkuUIH7lYMg5S+ewOkZixTwWyjXHwLNkZsS/L TieyTSHkOWH5C3wVbasULvJggXANW1dsKQSxkRSfXz0vVk9K8Jbe/JxJvpUMAd94jA8/ 6HgOHtpsoYNqWIHIiktwm8FlH+oDimjAhnrNMHqH9l2tOAiTIiylgDcUVlRlwILGd2l9 gM1pDQofvAYRGz7Xr5cp6neGdxk95Ot5RLX7fYPnA9s+IwDTgw3O+6vIM64hFg5pIgVZ SNyg== X-Gm-Message-State: AOJu0YyMY+MJqEBUKqUXwxQnlhUsf86pbhJAuxA6kKuSl67bLhPWkEc7 0T6LMn2JxyfMnWH9vodx3IipTvhNBCRQYYgSLaEDdLCYWcFXQV+NHw8A+nfJBg== X-Gm-Gg: AR+sD1050VB/rM/PWgwXYiXvUsJwu+1Fb8Luoy95NB4y3d7mroksVzq0UPTruDu8utV 5oCQUO7HlyUYxzmaDCBQjnJI/aBrlVpzKRRahNETtjv6r4iKro9AgKLjmpkSF1nU++dNzTl0NG+ 74dqYc2QoGqS3koF3ZBKwYKW7Vzb8eMwj8+sXymnaOq5jn/AGOPsDgML2gYNXdSuOJHsYwPbUKg M+zIPjUqy8JYIUxtjzhNj2kJzJuL1XQrht8OCMx1/ct2Rc9y0n1XxUZk9eM23IEg2YpGnAVUBUp dd0wzupi9gP1JmAb9LTXcz0XjDv/g9Lu8NjYjuiZue045gmvcRk1DI5oJYxeqAwIetXOeS6V/Vn Ifi0lVIbmyjpj0h4S88lNBJ+lcUrIwvXB3Oi05tFbDHfnB3ZeYGbODgQ32uwRPqJ7NehrkerPZ/ /vGQ2qKb9SpwLuJvbrYNexvbl9PaStD88i4DChFVMjxeIAEjWZ1YTWawQhD6KXa6502Mk7LgY71 kyIVg2filFZYHSJP+hdiQu4ICUHfwJbDOc66ENDb79q6UPoAKGf3rZ1Y6j4B5XNDRz2rV+vvkQm dutO X-Received: by 2002:a05:6a00:3cce:b0:847:711f:49ab with SMTP id d2e1a72fcca58-84f2e006c85mr11362332b3a.22.1785993731714; Wed, 05 Aug 2026 22:22:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 03/14] ASoC: rockchip: rockchip_i2s: Use dev_err_probe() for error handling Date: Thu, 6 Aug 2026 12:21:25 +0700 Message-ID: <20260806052136.21034-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_i2s.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchi= p_i2s.c index 64c90316fa02..3e8d07b3fc1e 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -767,16 +767,14 @@ static int rockchip_i2s_probe(struct platform_device = *pdev) =20 /* try to prepare related clocks */ i2s->hclk =3D devm_clk_get_enabled(&pdev->dev, "i2s_hclk"); - if (IS_ERR(i2s->hclk)) { - dev_err(&pdev->dev, "Can't retrieve i2s bus clock\n"); - return PTR_ERR(i2s->hclk); - } + if (IS_ERR(i2s->hclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->hclk), + "Can't retrieve i2s bus clock\n"); =20 i2s->mclk =3D devm_clk_get(&pdev->dev, "i2s_clk"); - if (IS_ERR(i2s->mclk)) { - dev_err(&pdev->dev, "Can't retrieve i2s master clock\n"); - return PTR_ERR(i2s->mclk); - } + if (IS_ERR(i2s->mclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->mclk), + "Can't retrieve i2s master clock\n"); =20 regs =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(regs)) --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E997D3876BA for ; Thu, 6 Aug 2026 05:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993740; cv=none; b=pgmmyOlqH+pqcB3D/3drzgHhJJbDir40lNIYBZLl1oFciRO3xpm+T8IGL+I6oKWhE1AWoRZHk2sPidGmwKf5eYik8Ov6AgESxhhQcBBj7RYc/+1xddq47UtpqAHa2CLosVoKQB88P8zs/+pvpVjp1fX3x9kybNGjjtjKZYpjVcM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993740; c=relaxed/simple; bh=O1Br8zer3tpUhuZjx3avPjjguADNJ0WpAdjii9APXzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PP2tVUUACQ17R/j28HTGrjpV6qblhsk3DJvbQIj+21hb+Owu6B+/wzpTX6yv3XNoTFrLB+khBjDFNAG0O3EeMoEpzvyTEMwTPtfZ3Pm05gzGBB+XOE8iQgigOfzn4fBFiNvGfQHl0Kie1t7vm5315Q0Rnsz0viByOKn7FoACKPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hacg03a7; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hacg03a7" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-84e507b079dso1156384b3a.0 for ; Wed, 05 Aug 2026 22:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993736; x=1786598536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NDuDwKR82JLi7EFxiha+vT2mlqKphTJuE7gvFBWzRzw=; b=Hacg03a7Fc0/Jz2OGbHBxWewly29Etuvy5+OyADmxlzhejMSqEcQmICy1Tpn7skvr/ Iusb1sLvcbjIS8wP6PJ7y7nOa3byO9MW1tIVDrx7XLa8hqTUhhFsebYGcbHiVZmiKpCg EIE5/mXFPoZaLMExwVBCX9SDFI4QWGtbfOPBSuZSCz1J1uEr202J0bw2/LFsvEaxy+gr +0od018RAhPZQlJDknCvcP59XvWw9P9PlbKcBPIHqQVpKY7E86j+S/GS0US6xf5MADdo cOG1ERVmK+smkvFMFjUpuwdzv6G7mtcnlsparSYA3eCojEJC/j5Jbvb94pi2RE1mKb+1 6oYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993736; x=1786598536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NDuDwKR82JLi7EFxiha+vT2mlqKphTJuE7gvFBWzRzw=; b=r+tZf+TgMqd57qc21OtDB8gEhjLbGB99gXXbNHMYaQavdaT8U51MZR1eD2FzNlTgsg KZGjC5QcJF0uWH4tVky8wjnd2isQN2w8GecGCFl2+vP+8/atdnndx8h3jahF4bjvmzqE UaaABk5L/JDHcmQV54EDZAFXHhAoX5T6Oop01BMzaEFTECjscbZSpTEXnlI8sntAj89U 7KvXihXwWH9JHM7r0f7Mb05rtIuUMhzNevp+Tt9h73gBiAFK4KK6nA3BjyRtFKPlavBe eWRGI/vhFtpA91+5k5vQ0KjDkhnGSMnNGPN0Pe2qqRDFCrwhjSVRwmY3Qcxn1Q8WNLlm cg4w== X-Gm-Message-State: AOJu0YyURUvM4gcnVi9t4ERBbAEcWi6XqTrXOtB6xRnBDgnUcwRJNo1O TEObIHYRl9gu1GUorrUlMjj1vnu1Z8obwVa9DS0PQ/Z3Caoh0QnxJSW3 X-Gm-Gg: AR+sD1118rAVJuQByxHbBzIABm6BVbSFO5uRc8WZmyDheObXkp2ECExiy7Dv6WO4TH9 dRAX1Uj2kCwDjz8jBPNYrxhzOMW0tPJKCgKpmHV28xVsKhM+7uOBUg8k4xeivFTCQE7DpdueBcR k5CCgs8jgMGdaoxqHBB5f3g7gc5fM2uV2dD2FBnPPPnhQtKcvA3C0HhoJaWlOUhwldr0p4qdCxo WQa+QjGzUlKi3Skh2VyC5x8tkotk0nR/QOQenB/w8jq5fgJ5DKVeR6mAkVABpfmGhYhXf1oPbmv pQ4kiV5+Cqwgykhac80XsbowFOxq/WBSxC/l3ysIeFiIZb21oX7spe6hpjUQwQjVc41zKyfaOcQ rzyymRiwtzBGJzjw6uestdRNW9IEEajU9LMWiDJQppUZ4DGZczcwCStgNDP/6o4oUFNQJKRqG1W t56Kz2Gqi6ewOkLDkNsAgWYMwfzJYNy7qm/9qOz+yWs3eC8l3Om2OXIEWChPFxU4M8hqx/Qe8UQ gooed87Ldis5GogfOdpTli0TOTbZpiKGZfec/lx0M+6iWHGxOLc0Nll97ex8TQHEtH+WVodHtOe jw8DtstdGRY1eYbQ X-Received: by 2002:a05:6a00:218d:b0:845:d6a5:716b with SMTP id d2e1a72fcca58-84f2e07129fmr13301068b3a.23.1785993736232; Wed, 05 Aug 2026 22:22:16 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:15 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 04/14] ASoC: rockchip: rockchip_i2s: Drop redundant probe error messages Date: Thu, 6 Aug 2026 12:21:26 +0700 Message-ID: <20260806052136.21034-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_i2s.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchi= p_i2s.c index 3e8d07b3fc1e..354430f916f9 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -829,16 +829,12 @@ static int rockchip_i2s_probe(struct platform_device = *pdev) &rockchip_i2s_component, dai, 1); =20 - if (ret) { - dev_err(&pdev->dev, "Could not register DAI\n"); + if (ret) return ret; - } =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); - if (ret) { - dev_err(&pdev->dev, "Could not register PCM\n"); + if (ret) return ret; - } =20 return 0; } --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2461D38B127 for ; Thu, 6 Aug 2026 05:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993753; cv=none; b=dg/94HGZ2b60Sql2o/nIJi1wiN8S4eYPFLnFAmA/8UpfIGTIdsz4HHM8Ukl7fmVKHjs5q6tZZWm585HOxwz5ZiI1Wd6p3bHpq/Q51h2BSQv+YgSrNI3d/FcYsKmQFEVZkJ9JDiNA/iZGPbzVM5bNXvxwps9yB5M33vzHqQs7WNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993753; c=relaxed/simple; bh=fGO9oOIoR8JXXEZxk5RW9dNEvSflPgscDS+z7rGXpnI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GNmzbJg0yvMOakiCir+HENdSqNFK58Khf2Q7iFBF/UU8oKTunC4rCjUU+NmpTQed15mi0NMu7Z4gS9tE0nlYbvt9NRyj/Ry/2lWA7cCpfrATBJgkAG+sXEqf2T/PQrc/m2SFjyPPm2oN/zHyCZ0GblssUvJwYXDiQpVxw3OrzJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DacBQmGB; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DacBQmGB" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8487214ad2bso2775172b3a.1 for ; Wed, 05 Aug 2026 22:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993751; x=1786598551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SYDtAASES468elSTBLIDdmGvVbZC7pKU/2qFW6TvMTI=; b=DacBQmGBPHbuZ7Mlyuilw6k5H1qfcJ46qxS4VrlgEWBtY+vjQ3O1ueLzfgvBaltmem K9hisggx2hhfjIlLa0FMoKo6VjNu0LlRYxgUgkXSHvqcs0SrKrd9naNRTWR2eLP7mtRC GDDP/8+caetM/nQxKHYS5QRu+37wYXZr2T2Q1K2yx3Dz2KjfoN9I4/p6aM9n6FPQteh2 gB9GFjRdssbFenIaUiHWBhhERIa2Z4F3xr6TFSOvdMFgfkU75hyWx06D7OWANN5m5jNT gn6ocp9hcFzYRaCfG21Tdw+Lsb4BZPRrEVjcae0guudk4oBjJpchhA3WsQ6SAXBCEj8z aSoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993751; x=1786598551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SYDtAASES468elSTBLIDdmGvVbZC7pKU/2qFW6TvMTI=; b=bdgxFgmanrv9j8U0LjXwjhL4b3gHlORGCw/ksGMZFw6MUmiQEXy5hf33q+0HsLkBil wYE1po1Se9ma5FoBs30sDEw0dNHCEJGg3f3MBJycrsAQVBkB+PxIvuWblIkGROI/+sPi 2SmywxXo4GjJ3imSV6ToiTP5hE6YlzeE8dJRXiKktFrugcwvlmqqk8MVCDKnid6E+5K5 vv1YXs7uc8kvrCvP6fm1wfe4aXhl2vSID9fnzran/YQARL+CZlzACvWIvhLNr6EsBSis iU3rB0hAvLT+rRuF5tbOoCLxqN8VECVaRBOb+QePCHry504BCwptdqva8sIcGwiQKFM3 1uJw== X-Gm-Message-State: AOJu0YyCbUsjBvD4ffzfavMl5CT7qNuZkPHNO5UqcJAHtFZ5jkppaWVP esmkuPVnR1QNNgxC9c/jjp9XKHOUERe9FaEmAK6rR44675iXfa320Krs X-Gm-Gg: AR+sD11bItkX0Ijj131Gt6a/HihzUc4HiAKr4nvGLhgz9gpmjrB2r6jk1Nj6LS/WI+t xewZ2QE84U+Cx5prKEHEs7fQSmKkzx+GM/vUl+nHs5xTooiSBzgxEHyDpROMA5r0kRo9jiQkblo VETmAemDIJWNhCpWWPWbIfMFkK2T720OWti7PDDiNwroLlE8DLsPgPTCmyW5ILQHXKSqNdVhfBp 09IcqIjhfscbj3ihIuscosLVBu5/oFCTLuKOagC80U4EV4adH5ns4bKxNfvJIUNMESCHw//8jjQ 1P8XIhbK7AZhhzldyViQ3nZqsiU3nFtaugf2r3GDJX19fNK9tENfbjtqn4cABIX8l4FVEUVc86i 1+Y4AQhj+T9AcWTjt++2cFflZz8K3LZKdmXaU/EjtdLBq2gp+reMP8IPY8Nca873UrGY9INZq6V HsS9px4mtNoNnjfAwg0vMSpSDDsLO5zhbNdKV1bPwTiDhG18blHG7gwulsW6d1v3YHUE8l2c/Vt A7wE/K+GofqX5wWLW6G/0FsK5FRV+uoIjhOc74PJEH0KUbCrIe3nSm/j/Ji0b4ya9EHUwqwqfwI Rjh7 X-Received: by 2002:a05:6a00:4650:b0:848:2c2e:c7a3 with SMTP id d2e1a72fcca58-84f2dfd6b8emr12646865b3a.16.1785993751213; Wed, 05 Aug 2026 22:22:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:30 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 05/14] ASoC: rockchip: rockchip_i2s: Propagate -EPROBE_DEFER from devm_pinctrl_get() Date: Thu, 6 Aug 2026 12:21:27 +0700 Message-ID: <20260806052136.21034-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Return -EPROBE_DEFER from devm_pinctrl_get() instead of ignoring it and continuing probe. This allows the driver to be reprobed once the pinctrl provider becomes available. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_i2s.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchi= p_i2s.c index 354430f916f9..261f36d4c2fd 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -790,7 +790,11 @@ static int rockchip_i2s_probe(struct platform_device *= pdev) =20 i2s->bclk_ratio =3D 64; i2s->pinctrl =3D devm_pinctrl_get(&pdev->dev); - if (!IS_ERR(i2s->pinctrl)) { + if (IS_ERR(i2s->pinctrl)) { + if (PTR_ERR(i2s->pinctrl) =3D=3D -EPROBE_DEFER) + return -EPROBE_DEFER; + dev_dbg(&pdev->dev, "failed to find i2s pinctrl\n"); + } else { i2s->bclk_on =3D pinctrl_lookup_state(i2s->pinctrl, "bclk_on"); if (!IS_ERR_OR_NULL(i2s->bclk_on)) { i2s->bclk_off =3D pinctrl_lookup_state(i2s->pinctrl, "bclk_off"); @@ -799,8 +803,6 @@ static int rockchip_i2s_probe(struct platform_device *p= dev) return -EINVAL; } } - } else { - dev_dbg(&pdev->dev, "failed to find i2s pinctrl\n"); } =20 i2s_pinctrl_select_bclk_off(i2s); --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9AEC35C6AB for ; Thu, 6 Aug 2026 05:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993758; cv=none; b=BtN4fNAm6vjY+QK8vbHvssnaBv+9gjspi2b1dQCjA5DnlIyyVBN9hEzHK024hRAaK+Cz+QlrMxxyIuMvO5VKxPGBQv+1YwD/QlPTgHiTupxec9AYWBGhf4iqJMW+nugkkVleyJvQrKPcsKMTNY9EzOgq61smc/WHLF2G+JeGR4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993758; c=relaxed/simple; bh=p6eRh+Xygm9NS0x2TQpIk58cVyp9tlFLU6gbH3d0RrQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P1eglCgUPM2bQzcAjRUHZoPE+HGTXiGoFmbLHDd+JWYJoW/0Mj0fFBDAf6YRAW1vBDdRN3QIvP7Z8ilnWRqpH4EKNxEceDZuThQZ4q++eb0O/CBWGhm6INdKL1cQmcm9l5wfkcDVjGMtJsE5fXsoHUAA/3Vr662vF88qd1cPacE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A/BY3v2B; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A/BY3v2B" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso2203762b3a.1 for ; Wed, 05 Aug 2026 22:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993756; x=1786598556; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6vOL7cmzT8i6DixZXZmGfCOr4Bi06fOU2/O4s9agm2c=; b=A/BY3v2BNkT7CjNNSigde0m9Qo0iL478NLX4rjxr/ARZXRdE07u1lUMI0AP2XFGB7R lZaHjQYegPubdgXmssUN6aINxwQNb0qP4nDq+iy78pS2VK5KLEnPdw3H3U8LwyKenpQ5 jWVaAE4Ew8H+WPaMW3hyWF/l/4Bj8zElIiNGTTXraxbp3/doG8uIdxjywwTy+7z+mDGc WKq14dY/VOWrQXDr8rdsbF3RmuHwYfpoiNZ/KhUl5rFzC1+4jhPDJXoVRlKlvKG4W/NK vvY0dbziYrNYC6+BL2TLG1+b6Z5ZhcjaMcpk8CNY7bPuwBUWGEBY1a52atXpI7ytv3fZ aDfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993756; x=1786598556; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6vOL7cmzT8i6DixZXZmGfCOr4Bi06fOU2/O4s9agm2c=; b=SuWYg0kfh147X2urtUWpx+ZjvuM3MeG6TNqW7f959PhbACqlB65Qgp7gHX/QTzkf1z KwtuVqtoDQK3IGJr4WWsgZYKuffYOiljx/+OgN34m0vIXLBfBLJCRRw4OY8ZENgO79FJ ByKj98nKI9/zwbXF3Dzq+29gxP6TDD4dx+BeWkqJp1+PI6+0PneEVlOhxkgMebAQT884 GbGgMdEEe697Ri++PGfZ6HkaFAVBbnXVU9LEDGR1eBPMjQiF/OtNT3JJoWhl8xe+XvHM zrKcWYSVQ67TgmuUUfC9NCjLruroE/Y35ef7hGYS0SFaz4/3a66JkzdpOn3Pglwa/BS3 heag== X-Gm-Message-State: AOJu0Yz3hqx7cuTYiqpqu1SDb2pwWBkkC60rOjKO8d2x/etnChd15ksI DD9kAgDMFOu9R0HC0srYvAcFkwx7sphfNMe9LNgFl8vgdd0Zc98L5aSC X-Gm-Gg: AR+sD13oQwvzjq6i2QSar54UbCxTDqJIFuzy539v3yYsX+lPpQly8OaL3rBDsuVqzcC ieyVMIn8oNb3/e9aCJEPuhlh4EVk6vd3//pwkAkYKMCdhomgiKv0MpolzQsmBFsQ/IIw2FplYM8 IBKs/2beRc2Nqs31r8DIURtyDXhvwFvJwTn7X1I2+O0VTmQHsNTEIfriNi3P7BWWZDtwev226Vx eyw+WydJ8yMhtQJDNOaJB2ZNpOkhRiZLKCD6MV1Ls4k9+hQbNBA6MqtNn5Za5zN35LQqWutTi92 sL7HS6XaZKuzJDQpj/x5gaujbMeCTt/6UzjJMioUU+NLaCG7B8XChCA2p1lTXYIL/CcYWl+k1on 6WscnAHsY0isKgnZ482wpK6/uZJIvHi9Rjx0O3tv02IbiKrF0O8LfDkwg+x5M5r28dW6MhC5Iov A1KNyfS4azKENPym7DKbkKTwCKwI6w1QstnWEX0J24NOzzWMCJv/Ijj2rfEccEPBE94M3Sn+vBF FYbjkbKR/bprOdv8kg8h6GRX6fDd/vpE/4xCRsRndHvRJ0dufOx0PxLFgW4xr2KRd9AqVicKBvk +Fvw X-Received: by 2002:a05:6a00:2d8b:b0:848:3e74:85eb with SMTP id d2e1a72fcca58-84f2e014749mr13013714b3a.1.1785993755907; Wed, 05 Aug 2026 22:22:35 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:35 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 06/14] ASoC: rockchip: i2s-tdm: Inline PTR_ERR() in dev_err_probe() Date: Thu, 6 Aug 2026 12:21:28 +0700 Message-ID: <20260806052136.21034-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Pass PTR_ERR() directly to dev_err_probe() and avoid assigning it to the local variable first. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_i2s_tdm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/roc= kchip_i2s_tdm.c index e6229a325ffe..c9ad769a4072 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.c +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c @@ -1263,16 +1263,14 @@ static int rockchip_i2s_tdm_probe(struct platform_d= evice *pdev) i2s_tdm->tx_reset =3D devm_reset_control_get_optional_exclusive(&pdev->de= v, "tx-m"); if (IS_ERR(i2s_tdm->tx_reset)) { - ret =3D PTR_ERR(i2s_tdm->tx_reset); - return dev_err_probe(i2s_tdm->dev, ret, + return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->tx_reset), "Error in tx-m reset control\n"); } =20 i2s_tdm->rx_reset =3D devm_reset_control_get_optional_exclusive(&pdev->de= v, "rx-m"); if (IS_ERR(i2s_tdm->rx_reset)) { - ret =3D PTR_ERR(i2s_tdm->rx_reset); - return dev_err_probe(i2s_tdm->dev, ret, + return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->rx_reset), "Error in rx-m reset control\n"); } =20 --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 125B035C6AB for ; Thu, 6 Aug 2026 05:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993762; cv=none; b=OmqS535r3jVhiCoYj41kUklPzrMPKx7PslVWqQbmExKvxNom43B3JlYD5Lh8DuTHrNqGWN5NSZBNAEYPUfp0jJh6+tDRq3k3ijT3TlonQ0CcpplbYzcGQMwRT7aC3ILc16c9OVcL+J7igdDxSg6qMxYRVu5uzPfT0goot+jJI+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993762; c=relaxed/simple; bh=QbrsH3Ye3OVwGF+o/qAklVVTMlaBOcFIHP8AU4D7yvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mBUz/jYn4EgkPky69VISz7zdyPnR0tljfulwJwuBPv4+WjK2ATSlIxqN0JPDVuo/AfGxSvU317yEBNEnywyShrKkAzzpJd7sDU9yO8FJ0TPAORLPai4nTgBaBMFlE0OHmNEeR9ELzgGHlMhRtpxCC3OXrE456AKAsiXKXRAWnyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d+gGC4bA; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d+gGC4bA" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-84830c774a0so1875191b3a.1 for ; Wed, 05 Aug 2026 22:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993760; x=1786598560; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YJadDqh/AXReHASvk+eJve0FUluChS8L4Z4vpvFJSCs=; b=d+gGC4bAIuHPYOknwFjn8+s6/HkZKYB2QmiihclkNbvNJ5W+6ofzdYhvTWPbhmWOK9 xgNCiYEFBz6xvRxv5uUH7E+IH21bpVOpxdNZ4fL7oIv68rXEeDTnZgswvtzrjVRhJWef RM5ZQWJVQ0MAvKO5BeqaA0FUy6I8wEyU9xbzmMB5ATk4h/PuGVeRb8U6ufncq4db3gpt /OHvuJlf2qHh3gNVy7Smn7jOXorp85X2HdF26CF7dBF0zibpdZ0/sn8Itu+SURiEz85E y1DIr+u1fAzSdM75HDIIxlJphP8BfOsmg9kPS/9o7cRZREcdqK5jEpT8JQHwR+HbQW9f V25g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993760; x=1786598560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YJadDqh/AXReHASvk+eJve0FUluChS8L4Z4vpvFJSCs=; b=p/XU6emboQw49jaZRpX+Uy5jmO8ZVicVe6OAUYT3Q544IvzcmiGEcYiBU+mWIMFRpv qCk/7/j0PZJLThWFzSHvVn5EGdYbPIujBJHhnzkK8TV1tID/we+c5cfACVKvzbBP7eVa rN5C9H4sM8+O4HpQOyYagtRWEIR1RCkMWeRUHlwB5R2ZH5uSKUTLl0gsTFiqf4EifR60 zyLJUxrJe+4OY3aRyPLNI4JOgGRhuZFILrfN7dTGNympImDvNQkGU9jHIjCIaWehtMMw Adc2hmyPu9knMec4YWMgeBKr2kL4TxpBusuInbuVVqRABiLyd/Y0RnUCohwJYo2jzuMY JVEw== X-Gm-Message-State: AOJu0YyixB9/jqyalZ/xQTeo4wFN/4lJzIfR56DopdxYm5WPHj0z07jT SBXqgmh0lKvFrf4q8eLaWtR5Ep1Aw4bdNHCjDXsvslIjh/wUTV6awKTY X-Gm-Gg: AR+sD11VjmwFteWYvxAGG5W3hEYJrrJbw66YskfVBV2FZZ74KerbZmZWFtk1khiYxmw 5Jvgot8Xkjhl4qlPH9CfoSwq2Zbn4aU/Q8iCiciNfHlIHbvf07BhsBMVW04UHAkZ8xJql1brC5+ mPBTVsu/BJ+w5DulKDEP2NYDX7tLoA+1plFtYTMeVY72rUk3suqa6TKRVye/f6xoFbmV0QdLNlh 7PB/16oxwUazOx0wx1FSJKRA7Y9ZGCRvSRrtB6uDr1vNPzDZLZ7YeuoxuJbzvFdfb3Rot1iMU+6 nZYQC+U7cPxQp9aGACaPjCKubS9OFZXqOVxDDKKtO4EHaIAfCMeAJsEi5TzFrAD/VXrg7Q1sY63 nHyKQOu5WJgJc0w0QzkuUt4M5RkCa2U36HV48lIBjc56NqlmeIvSs9hMKECkVqNrhWPuMvNdV+Y 68FguThZ2mVMnCs5bBjcsgn3EnixYcE9ywef81PJpCkyAI1S1QpBGX7dixDloDQtyrjLYqkXraM 9GI747OKnQn/YFrWkaUDSc37Dp62v0C0iBzrtho4ZW6h2WEj8maEAHczI18LAyHASrmKfWKZQLp TiSi X-Received: by 2002:a05:6a00:1250:b0:847:97a4:d6b3 with SMTP id d2e1a72fcca58-84f2e05124dmr12546494b3a.16.1785993760355; Wed, 05 Aug 2026 22:22:40 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:40 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 07/14] ASoC: rockchip: i2s-tdm: Drop redundant probe error messages Date: Thu, 6 Aug 2026 12:21:29 +0700 Message-ID: <20260806052136.21034-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_i2s_tdm.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/roc= kchip_i2s_tdm.c index c9ad769a4072..5ef7f109706d 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.c +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c @@ -1361,17 +1361,12 @@ static int rockchip_i2s_tdm_probe(struct platform_d= evice *pdev) ret =3D devm_snd_soc_register_component(&pdev->dev, &rockchip_i2s_tdm_component, i2s_tdm->dai, 1); - - if (ret) { - dev_err(&pdev->dev, "Could not register DAI\n"); + if (ret) goto err_suspend; - } =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); - if (ret) { - dev_err(&pdev->dev, "Could not register PCM\n"); + if (ret) goto err_suspend; - } =20 return 0; =20 --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 820FE38DC77 for ; Thu, 6 Aug 2026 05:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993766; cv=none; b=bH7KBBK2FK1gO4Djsuq+TS940ThXbUZybPOOKMwh0wNZienixJvMntvr/7INPpnUsHILRhOdB7xx6M5llvV8evqVmDCSg8bxa3IaX+PNz2UIKwvFp55parG3r5JOppbuUay1s3xX+hAAS3wRS077NwPg9ThUkSwsq8pstLEtVik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993766; c=relaxed/simple; bh=gbdNai/yyrvBcy3tjk5+d2/CebPxq3UL1AqPKIy6wy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cdSpHZOgoIlLvYfma0SZZlvNK5fCpUd4W1OlcfN3sqkWUtfus8mWHggHOjevmAdnkp/T5AXBTaD8U8SnuJEylHChZSw7n5eUoCA9oahwrjU81UMJddSq2qtmM/lVcHX2ZC6q5uMDdHczaHe7VKKoJygFXWEUNlWEsCtMfdkcUcU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TZzOaWL1; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TZzOaWL1" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso2203847b3a.1 for ; Wed, 05 Aug 2026 22:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993765; x=1786598565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Wed7zRTG0fPLK7b8aSvZs5TBxnd4+YK7ALZwX/ab6vo=; b=TZzOaWL14ofpMCN9SwmBxLoyJaLUne/ZWUKoZNUFhMjNmGCF46oz8s6CsxhK+8wgmZ nc/AyoTCW/8kbEXgYyOVRonv7XEwAueaDJZDp8jMVenSCk6N6vKwtH0nIH0B/VJiy1G3 8eBwskyQmMtyCxKhhgYpDTjuIlbqsMsnyKROjdtifjvIF7t1f7GbC7k7nl42fByn+ZEi fjqOwWqdKIEIsbtyj2+mbckr0UpFka4OjoZ9eVffyyAeYzS2uubCbNo9UIpVpWAt4YJx lEtPrsPf978MwPr0X3qOcc81JTl9fvebTdqT1d7q1mFJyDVw9ikpMy2CmlSleiy7TQ+O L28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993765; x=1786598565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Wed7zRTG0fPLK7b8aSvZs5TBxnd4+YK7ALZwX/ab6vo=; b=X4X49R26MoWqsGsOkkljZca4ntEiiteEKtzNrRLOUoFBr4T+Qx1A0xHOoDHcmqhuOA UJDC01nw4m7S9qnRmOUWdGdWWlDI/gsFNX85k3Jta/PuInTZTtNUzJYOQogKIxmDrBRF ivJEoCjgzXNw735HI8Je7hSzUZcFBirarvgLV4wrtnBVctTUCcJd3QxRjNR75cA5HkZi YlDSxRU+hp2f+vDv3dCV4IeUPbKRBiI8tkJZXzmeICYEbh+6s/oQ7c54syQzgkzpEnMN 43dv8xOtBN9cAypx/sKEfOqX6sq5EVfeQyyRnccr5PXoDvE8wK+8+Wq27Kcv9wtei0qS qiLQ== X-Gm-Message-State: AOJu0YyHVnQ5mbz8t0oE1pdwJc7151VkQcz0jA1WPTlYAMtvAwxDyZRS nEFk8z0YXG6sqrNH4GnqhrD8QeOoo412t3lEsimlm6ooyf/u8T73JJEE X-Gm-Gg: AR+sD11NT0VremHbxkoRXvr2E4240VPdVjJqtXDoL9sCPW1fz8oZqpOHCxM03B5wsCh Pyl/FZwkOwcyhIUoRnGxP4Xd/QN0/ApS15eIzbk738uE9T1Cj7EoxDVzP3bEB7+8AuEEsCpXkUx DOc79Hvy9Yc9MEMMB4COeHh6dYY0K7tebSXOK+NTEWMvjj7skU/Raz4oOYKbEFak+pjT8zy3QZ5 Pp2K8Jr6gpGmglEWDCfP2xWwIBEit+V5nmdbdgQoT56cyBTzSsKdg0kLF5MZrPpckimAjyV/L94 Veca7qFBt1qgMsS5M8uM5ft8FO1+0D9Xd68nWxtHQQhA7Vd7u0esxU7A/EdjnkbqaZLTewP5rG3 0qDSU1DKPd97/t8rMqqZIRD2L/zp2Tsjy0INFVOgNDc1LHSlMZ46Lp/yd1H1joSxxYd/+YbuXP5 QHilY9JllzbpJYu3T9nqGiZPB4oTpCJzJ+K8YXP/wnl99vGmQi1KFyIjAuoV/LP8n5JVgmOlEP7 Ktmqt1R55aMM9lUh3lpD5Cp1RNcA8hA1vm9MPOfpNZzKH7MkjztcxJz6Aynz6D20GnFkGQr5CPu cVjfXUTtnP3UjEM= X-Received: by 2002:a05:6a00:a226:b0:848:2a55:7110 with SMTP id d2e1a72fcca58-84f2e13b00emr13190693b3a.36.1785993764917; Wed, 05 Aug 2026 22:22:44 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:44 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 08/14] ASoC: rockchip: rockchip_max98090: Drop redundant probe error messages Date: Thu, 6 Aug 2026 12:21:30 +0700 Message-ID: <20260806052136.21034-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_max98090.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/ro= ckchip_max98090.c index 075d0990a126..426506a8e18e 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c @@ -428,11 +428,8 @@ static int snd_rk_mc_probe(struct platform_device *pde= v) =20 /* Parse card name. */ ret =3D snd_soc_of_parse_card_name(card, "rockchip,model"); - if (ret) { - dev_err(&pdev->dev, - "Soc parse card name failed %d\n", ret); + if (ret) return ret; - } =20 /* register the soc card */ ret =3D devm_snd_soc_register_card(&pdev->dev, card); --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BB5038D412 for ; Thu, 6 Aug 2026 05:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993771; cv=none; b=cPSgciaQLmzp+0l0elbRXRIEMcxuzzdI/qOD9UTCQ3GiiLavjrEi4/Fr7amgHjp1gcV3Z8xqKx+BaeSKBg2lfEYXgaxqOPLcjm5Cdbljc4F3NAoYz+H39aV0r2NwDvrplQVY0SGHVyyOuFUd3qnGOh7kM61Tw7ZYNaz9MwjqN1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993771; c=relaxed/simple; bh=uht1wtGkO3dc/GBpw/WuVtCYhBwXB0XSudDAS5+3MPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HTdasY7t95gSLMDnEVdT6TuBA5FaUE7681SHQ2POWa3sdhEeNK9BV2j7qdSnNQpqMOKbq0ZwXjnzzMs6jJrOBkdxIUUjoRLyv/Ft/hVu2MV+7p+CF2WZS3SvMQbtHZK2MX7OlkCnGJPqnW+kSC2UjmYGjbQ+NZF5/CIGGhwBfzY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lDGb2g8y; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lDGb2g8y" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso2203898b3a.1 for ; Wed, 05 Aug 2026 22:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993769; x=1786598569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0hWHLReiVEFXDAdvhyF4GcFfDKUrHwAoJwgfx7kXGn4=; b=lDGb2g8yIPHj9B5rI5WIs+/JX7vvFbZ8a16fiehgnAIfuu2DF9MiAeW/gmGURYd+Kb uwXETm8YTssTlWrzhM1Oyuh+2pbILqxL6KwBkZLh82twisOHxK19eT5VPLCDjlDQzER4 4X5uF4yqW/d+duIt/ymu3mt2OnOPvy+qf2DopF/VBo8edsE+Iweybgdsat+QtYm5Aw9a sah64txlhEyNSY80lscDIff0sWKdUPZVpLSSc9LABwFZk08JC+qfqXL0Vid78NhdNnQx Y/aUMrYmce/AFZ2xG+sxQqa/9IsDXp7pTZ1ghxtSD8k2IO5RrDmqHfowSkTKpbKZw6IL u0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993769; x=1786598569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0hWHLReiVEFXDAdvhyF4GcFfDKUrHwAoJwgfx7kXGn4=; b=m+iN7eQ1AOkfAovZkniCY8Alpa5TB4HzxjWm6PejWCNwsn68hShtsiMZh1gUOQI2AY 66YaIcW8e5bsWet+EMNQOdMT1dchxOwLSp9MNHtnE+vkGnXTQkeMKrZzgC0wuLnTYFnf /cheB78Zuziishg/aBjuJsAMtaUNdHOiePpKdl2DAB3gAmilAvJi3qsq01+sxFuhFGgC xK0ffRmyZnS7jbTnrtF1mzHqqyW1nlqwanew4vZ/X4SP5RZQ8BeybcavfJt505ZSbc1O fonK0EWVJ+4SnN6KMQ4yd6eVtv+7N+7pyEF/hsDvfceMOFjRj5CIL4Wr0H+luQkoGAMO VPWg== X-Gm-Message-State: AOJu0Yzlu7qvocYbi0gUAqNnYFnWw+huCGzaP2GWuib/q6vEb1vO+98j Ht8uPLIxJLazEkzTwXSiCFcAkBu7xw1G9skmjZlOiyKvuNPLsg8rWAQf X-Gm-Gg: AR+sD11nGSAAF97tlE9sYBKVgrCmzzl5kqtOnGGz02+QVEvnvTBGSZiPPN26mhslhzJ 5Pxhmndo7u911VGaswu3PyCthYulvgBG6ia4QbRnmm8bD1MELQCRQPIP8gJYgIS3Z58Qi8Pa5bW eXHW0Dg1F5tfwaKDeYRqEKkxTgXhujdmx70RxIO+z9QTkSIFHSjQeQpJTPzrBO5abFiYBbHvmtd MxoLtblRC7hqt17RmTY91CyPS7EfydqRxQGmvr4Jewh8WboKPFAaQU30t8T4KgwqQ3rLHBhv9jn 08q9HVsLIaZhDjJoVzH1rMQoOZBwbVWvQVplki1SNM+AlDuy6UTLmZsKI/zr/1oi8+7jhwmSD5X Qa+cKqmouLOZoVs1Uhyco3hWKJ/lGixjF4DP0RIP7QTGKHrltSOfU73dc4dZRC5OLyg5wyb9M76 H+IkpJuNhQxfsSeKJRhJ/Un58Z+HTsrQOG/O3fLCjexmNcJ2nNTTbhp88qpRJEuNJnNC5IVFFth JC65IrrcWyrFsieKMzSjxkaBLnjDkpcIrVeAdecaClqosyrw8MseSVvLviGaHfK+pFAqhFDOCNp qaOB X-Received: by 2002:a05:6a00:2295:b0:848:62ab:7b7 with SMTP id d2e1a72fcca58-84f2e0402b9mr12960128b3a.16.1785993769555; Wed, 05 Aug 2026 22:22:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 09/14] ASoC: rockchip: rockchip_pdm: Drop redundant probe error messages Date: Thu, 6 Aug 2026 12:21:31 +0700 Message-ID: <20260806052136.21034-10-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_pdm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchi= p_pdm.c index 115e90d3bbfe..343fda478901 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -630,10 +630,8 @@ static int rockchip_pdm_probe(struct platform_device *= pdev) &rockchip_pdm_component, &rockchip_pdm_dai, 1); =20 - if (ret) { - dev_err(&pdev->dev, "could not register dai: %d\n", ret); + if (ret) goto err_suspend; - } =20 rockchip_pdm_rxctrl(pdm, 0); =20 @@ -642,10 +640,8 @@ static int rockchip_pdm_probe(struct platform_device *= pdev) goto err_suspend; =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); - if (ret) { - dev_err(&pdev->dev, "could not register pcm: %d\n", ret); + if (ret) goto err_suspend; - } =20 return 0; =20 --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF1038B15B for ; Thu, 6 Aug 2026 05:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993776; cv=none; b=Of8g119hksohe1Efadr7AaxIDKFe68to94PNYxpCgxDnqQQA+/h5V8INJrHqjO2SVNV/vVCpFoXCngGRNqzOMcG04dnA2CXRFQPkSwHqdj+rQC8oZnbjvROZg67pZVR18RnxxpUCZO6k2bhuPJnTb+pku/zoDiYj7QYFdb4Ikt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993776; c=relaxed/simple; bh=kYnY41XhHrs9l3jYEaLnOloNXLVqx0TGcKVXK25SR7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kQu7/vkvsxj6SvGwQKoMjbyvrG1BMzGLt1C9lr47eCGCqS66l17BoP8+wxd/lD9XyYMNGPjZVPVMT3xX7Zu2r1wKsDNw5NZ2s+VqvlKQSRR6telePlSCoV3m8sQvwVME1D3nL1GTt5x/Cc2lQaLJpQlIMghEjkUjozHi16eP/Vw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cMnrHsA8; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cMnrHsA8" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8486ac3f347so631956b3a.1 for ; Wed, 05 Aug 2026 22:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993774; x=1786598574; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VI1znOBQLbz/1vQkVjAXYLg+Z0oCTtt7na+x+SnaEEA=; b=cMnrHsA8qb8ODp8Yxk0v5cGa+JOCVAM+4PtbtQc1CLhmt3hnjX8lJEBGFjdStvSE48 Hp+n9MHS2EbmR6dLMX7sp8NoHE9yxrMzK1sxWUvWGT2FtfZoud3/RYJXkEchasVUe0M4 F9bLnUuH8uGgXvp2iJlPT0kigLShAGbu7Ipxz/B0xL7hMxxW+nlMgAlEDWUfmcDA02Eb /ETKxngHfH0+jUVipujZY2iwIBRzZUzAiyCu6q2RwpjB8H36s5L0EXJHCHM7NNYdQOl5 gsIwUXQQTRaUN4EkSCAbIX+p48ZyJFAs4RQf5uZFGD2t9MfZ4FX84/rH7+Dy/+4j483U 35tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993774; x=1786598574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VI1znOBQLbz/1vQkVjAXYLg+Z0oCTtt7na+x+SnaEEA=; b=tHM6fZbJ0/OlgCiessQkskFFCryzyRu3dcipECWtHzPKxJa/zDuYiKu7C079oj0M3J LuAwhfOLf6HhfzfGDivjCEfLxal3wmnRTOsUahgLf6ka84fiDFKGNf/bPqxjePiQA1aj KK/9c9ftZe6/mPTxpy33jZm/d8DKYFMsnHM5syZy/jBQ16xn5Ttt0qLu/TDjQWq+Se8x HzmSkTU8X5zFY46v6cm4VULEuHjd9NVJ6B8pM8UGTszanPb2K/Djt1BGHzH4ppuwdtl2 c8G5YBHTzMSOqTIwB9NXd5qM7h0+FoCNrms9xIq8FVf+6MGjOlID//Nue8fsScWRiA4c ZqoA== X-Gm-Message-State: AOJu0Yz2l6pnhAnbtljqeB2sH4KmnTh92goPDDExLKPa84AjT0iGs9Kt 1kOEy0+ZFs0PcjjtfZSeAKPNi9/soZmQw2WDmYmYN8Cv/vbIvVf0ffVf X-Gm-Gg: AR+sD1371qOlUA4rXSnL/lSMjnTmY5AX0XanVvZti0hnfwGwWzES7si68rSKLxY3pXw Y8/8OnxXbjeeAc2eJJVfD91M4UqLvfFfkOcS1GkFEUrZpPDlMZ41yRFGgAK6nT5M/+clKUDQBxZ EgX4ZSUJrrM8F5kXLLratWcyGgQW9K7nyI9fwWLBAwdHVW/RNYiBAu3QxLkyGw1LqG+yJSh9Nk1 XI1Lmip9Ybd/5yOmwr+nJaROag57kHcWPRq1keqn/mHhvNTLXj9CbSKH6uVRJscI+hxk7d/P2t7 bqHUdd0r+CCfg9vyUnZy6vr1A6yNGDTHI1GaMcUqwgg0R0Zeok/yv8y3W191y7MBZPuweWwgc4m Z6aPeiQBTrTkhbV5NJOnw45bhgzwnzYmP/31dCUh6Qr6DcBro4JXyo1ffyOv5UgJxcVBrXqn4wK c9FirduNIHjfrQjwH4D/89yofV3gsrX2cXC8QI1QhCIIYqbgKqAo9tn3qHxFHgtt1QLr5ZaRay4 Ly9iM0oPPR9H7hrI5oALQbMVvKdRK9lXYN0GeWCMlwUXTdFy/1NXF5Dh6f2aAQQgnDFQOk0CsU9 Voao X-Received: by 2002:a05:6a00:b56:b0:847:9d6c:a56d with SMTP id d2e1a72fcca58-84f47dbc610mr1869903b3a.12.1785993774069; Wed, 05 Aug 2026 22:22:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:53 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 10/14] ASoC: rockchip: rockchip_rt5645: Drop redundant probe error messages Date: Thu, 6 Aug 2026 12:21:32 +0700 Message-ID: <20260806052136.21034-11-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_rt5645.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/rockchip/rockchip_rt5645.c b/sound/soc/rockchip/rock= chip_rt5645.c index 590b64b362f6..0432eeabc64e 100644 --- a/sound/soc/rockchip/rockchip_rt5645.c +++ b/sound/soc/rockchip/rockchip_rt5645.c @@ -191,11 +191,8 @@ static int snd_rk_mc_probe(struct platform_device *pde= v) rk_dailink.platforms->of_node =3D rk_dailink.cpus->of_node; =20 ret =3D snd_soc_of_parse_card_name(card, "rockchip,model"); - if (ret) { - dev_err(&pdev->dev, - "Soc parse card name failed %d\n", ret); + if (ret) goto put_cpu_of_node; - } =20 ret =3D devm_snd_soc_register_card(&pdev->dev, card); if (ret) { --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ADDA3914EE for ; Thu, 6 Aug 2026 05:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993780; cv=none; b=dLGVctN8VKTlwwDtbY7/IG+yt1iijxpuBoQ2gqnaELeLJAaW/3ma6zlz56ivPhFZFLGISEa3gAPqkdOyyI5sH/EJS56aJ6/lrSN9TUz8taVlPxcrgoqy/iD6hwGu7U3Z2WKhH8vcNIaSyfs8Z1Af2FC1mOZzg16+KOMWdrHjiXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993780; c=relaxed/simple; bh=KAAr5zoIJwlBk/iLdsACy777/GugcNzG+D87af2gC3c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fulTw7vQmyCZzgozKp7nwmBYSFG86ih7Cw2PfnupZfV0vOGczi1qtntx/ZjK0xI6o8461B0qkBHHuvSnbFsr7hgVVsmZHbs1GrMDgBr+FKiOA8+BvLT7+tRUd/ANKyHY6Wzmc0i4zIXST8Au5zM91IcXCnQzKLrsoj8P6S2z0Eg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TANfSXfc; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TANfSXfc" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-84f10e55beaso544182b3a.1 for ; Wed, 05 Aug 2026 22:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993779; x=1786598579; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3tvFFAh4lS3mG6cJ5ZjUOGQHSvP38stbFXiDSwTmBNI=; b=TANfSXfcpZzhnoaGE5vkiJTALtupjfrMBFddrBh60m76NyuO8epnHbF9SV//L5o3mC OrBLrQGZgB2v84T0yLYHaV+IPEXNG/hnvAv9GBDvney3kvvpDEo94a0cP/O5gia2BzbJ P6cQ/3OM8a+Rl//OgXYmCJp0aho/ILIWQr2A+N7emFBQpVmU5B/zX9hnU3+SsiYBo4GL 7RaS70XpN+O4kyroVTY7E1u5wx0ho7ir8c6LT0Qs6Jx4ivue6nMCZT7mnbwnI7DVxat6 c6TI76Z2CPT7riai2EllHXM2HPh5xRvTGqQ9tBDAPFFgEh1u71Bv2HKc9p86451PH3bI 65Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993779; x=1786598579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3tvFFAh4lS3mG6cJ5ZjUOGQHSvP38stbFXiDSwTmBNI=; b=aTsn7s6K9agmnF9HSgW9Cdv4Lw+id3tRbaB0KXsfM8PX1IX/TzzVGNSb6xGdyGamFV zFzZeTalCKSmgNTMOVmbCXqSBcmaNc1jWXYWFnJjdlcFi5x0ALHvYlT5xDh3NM/QTXwA 4khrpN6Z7gxnKz6H9E/3gR6Gp/0aX2n3Tgzt8SjPZdHSlX5XiuwO7r3Ea0a+nZtZMnsB B3H2MzlUxLhx7fJFD6OoeamESdChXhTQRnaYoJLSeWyeP/ym352BqNdCtzzdAryaoUhn qHVcxmygCTMJJkbp6Ywh5H3E+4FGrZl3ofhOShdedlf3cAjKs43pLcn/hMUFQJV653nw zIbQ== X-Gm-Message-State: AOJu0Ywu72/jb2WUEgqy96SEFGG1SnKKfz0kkGWvVSfrx024ITmofNCk N4WyD+D4eBhKyGJi940zbgWCSL9UGwo38juoqCaIwLDMo1JwpJCyb7UK X-Gm-Gg: AR+sD13z6SH+Q6NstJepzQpRGecCHyfPhxsIEOLJbLcPhOFnsyXThSgR3FLV0aQqtNS ICH6yvr/2KJNhV1V0486VCYkQsKGg0HX1FiT2bQuJ0bGGOnQCgyGpZQv9cjo5FPhCxiRxg9348W Df/fTu6FGFy4e1ipgTCgEgqR/f9fqH744ysv4ccTkLTkFQ8eECdjDZ2e1cVJHvrgqNmTIc8C4CD k6Exx74CSCXppXChU3kpKx+VEF5khJOJRbZn2iyfrZ/cWcprdtbXRm9Z6mUOgi6GEQOUYGUlnIs R1ABFugq/kCAdYKVNPClNIu0k1k3Kusz++sx2JHYLu/1JJtKOyx4NGMM6sE0sLPRkWnWe9qrE3n 0DINDdaxR4avyvzYBjPM1AUVMMIwj1moluALrkRASmsCBlE9l7GuUR9mhLET67IW1CUNVA7GYVG TNv3KoEfzTXEntkrxkSfHe9l8pR3X/Lm6N8yFh57qjg6k6N5FYX5OdscJNiVd3kaKvNBx6t21TJ yHOrhxgKbdfBwF8bu8Kje1mQGjtWraktydnE70jqvdlHFYV2SVPoDPV6MMiv/hXlwZPcRZN7Vyq m/bo X-Received: by 2002:a05:6a00:1310:b0:848:8027:cac with SMTP id d2e1a72fcca58-84f2e04d03fmr13506845b3a.23.1785993778592; Wed, 05 Aug 2026 22:22:58 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:22:58 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 11/14] ASoC: rockchip: rockchip_sai: Propagate -EPROBE_DEFER from IRQ lookup Date: Thu, 6 Aug 2026 12:21:33 +0700 Message-ID: <20260806052136.21034-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Return -EPROBE_DEFER from platform_get_irq_optional() so the driver is re-probed when the interrupt resource becomes available instead of continuing probe without an IRQ. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_sai.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/rockchip/rockchip_sai.c b/sound/soc/rockchip/rockchi= p_sai.c index 585e89f61f0d..522b4f4f6a7a 100644 --- a/sound/soc/rockchip/rockchip_sai.c +++ b/sound/soc/rockchip/rockchip_sai.c @@ -1428,6 +1428,8 @@ static int rockchip_sai_probe(struct platform_device = *pdev) "Failed to initialize regmap\n"); =20 irq =3D platform_get_irq_optional(pdev, 0); + if (irq =3D=3D -EPROBE_DEFER) + return irq; if (irq > 0) { ret =3D devm_request_irq(&pdev->dev, irq, rockchip_sai_isr, IRQF_SHARED, node->name, sai); --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDDB0387375 for ; Thu, 6 Aug 2026 05:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993785; cv=none; b=irA9QU0FKVhO1JYwzzSuto4qrw2ojb8F5oZw24NuRYu61A54SnpMHQF+R9t5Tx4NGwft43JwcJRsHhvwAlQM1QD2Mhc6dQ0ta3LSixU0o7Qim/3+SCrKaDSfURsmxFdx9oak5GhYQheQJcdkHp+UzE4m29P/0LvG9yJcIoIHfIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993785; c=relaxed/simple; bh=AdAcsu+F2nHo0B9JO6GhlAQMeLvpoicLvleufnIkTJY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iNBW8OeuYGnurssV1dtxmtVQTCgD72Mig0spQfo+vKix7Va1uSOvNtJ/rIuXu2Q0fFbGrEWrvrblWQn/8/QyiCG/01dUFxFReQ/p87qbLWA27ITPu/CiLt2SpTo6Nn5emHpjVgMRpKGYi4IsyYYEHHoxFyIUC+Q8wjHX+Fv6aj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AqjvNoS3; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AqjvNoS3" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84e0688b7e8so1717863b3a.1 for ; Wed, 05 Aug 2026 22:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993783; x=1786598583; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GBK+k3DpjSm3fu5kk5NiqqkKTtgyJPYe4ia8RdreH3g=; b=AqjvNoS3w090ki1APhxW6BBC+09w3LIs7CQCwyOWMo3Euy0AVsh0y7LK+/zoRwC5ZA PQrLTRS4TwQh+1u7iukp3Xdqo8wZMbTNyZJ/YDATxUMSlLJSOWiY4/to+BUPb5gh5V4R zcVLyzMs2ZoKSeL5H3H4FlDE27304tXWy/j9AY/cGDmvaNzVwhrLJfMcam/OsCsz9PB3 9X4OlNbGieF/rNaEtlJbK67IOSwVsP4duBTRWt2HubB7wfVDNE7QJq3HkEbU2rJmUlVn 9LGvmPF0Puiu7XE1kJrlhCV+2XXsfF0FoBZTxnvGbA7Ui7syLNTHO4qEPx99TV6EmmlX Hd6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993783; x=1786598583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GBK+k3DpjSm3fu5kk5NiqqkKTtgyJPYe4ia8RdreH3g=; b=pTkJUtRUjb26Q9sui6cZ6n3JWqswpWnd5IIF7AiBvxEFhYxW/fiNo8KA+wRumY7/6c DHrz20qMwfCSikjiVifjaoiyz1WIaN5hFvqcp0Y710ctKVn10xM+P53ZLr1JwLkK6hVf YxEb4NFatVHWeThzFNWhWMSdSTp1Yk9slgtXhDUAQyqKDyOIAhR0Dw4QH7I+6NhcXYvG 6NPLsWxUR+TQNy1hBhYAZER93rM6aPRztMeeJTrOVZ6+TmZR3LfoeB6lQUj4IUv3Dhj7 Awf5IM1zXouD1Ur8NonT6jMlji0SLV8hE9Y9VVOdLw8pq0Ty7SaB6eLwWyBkdG3VyXLo fyQw== X-Gm-Message-State: AOJu0YzfCKja0e7Da6OtkkYY8rroQfqfE0EyiVxSJhivVEDMoiZqbMwE lAt+CWqXF7lBqU2lh7CE/iuwEQHIXN551k2bniDrGUwp6kKf1N80+0Hs X-Gm-Gg: AR+sD10TZk9IyLZPxWO77NmOuzoWaSxKGgACJEQu3NM68hnD7LfNkLkDPpn1ErIbMuV s8jPQp7Tl2lf7YCpxCOz6gs7/IYpiIaRbP615da2WeCRRX3PkXGQYy8DGvx4tkbVJWqXsypB46G KryjAF/235KhwuRKLnl/faqCKuGZAiLUM6wT6WBgg4T/cEhsG6lAAxFnz3lSbpeQUzRs22MV/D7 9SkIbOoHehVn4gpuaDoXkE2X3G5BQO+/yg0Gl28wAyn38NjgJ23/VLA4g0o02sVRFrVF9Rgqfa2 GwESIVdl4c40dVRPl6IuvxzvE2A7LPZsdH/EelqAxEsF89U4N5uRD1WTUsf9nLZwcZL3+2t6RDH bL/FzeF8ORX96S60kO/9N2R2rn1FMLgAGoAgLOYamXYVMEDWh7UYDCpuOmdqV/Spza/HUx3QIy4 +2Hu2l4TkWmxd8M6o1CWc2cxNqp7t+rSw3GN/QieygJ4syl4ryRDhoxVHVWuGdeC9XSNH5tn/yj QXG0FiALs3egxoiq2dK47DMVyD1joM0jw9cifW2QQmWaWVVJYYp+P/fmt6KcuWn9zzcvOzXcaJF OQ8PVF8v7kpuAKYo X-Received: by 2002:a05:6a00:c81:b0:845:cdc1:a803 with SMTP id d2e1a72fcca58-84f2dfc4763mr13549981b3a.11.1785993783204; Wed, 05 Aug 2026 22:23:03 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:23:02 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 12/14] ASoC: rockchip: rockchip_sai: Return the original error code Date: Thu, 6 Aug 2026 12:21:34 +0700 Message-ID: <20260806052136.21034-13-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Return the original error code directly and drop the redundant error message since the called function already reports the failure. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_sai.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_sai.c b/sound/soc/rockchip/rockchi= p_sai.c index 522b4f4f6a7a..1fdec12a0d4e 100644 --- a/sound/soc/rockchip/rockchip_sai.c +++ b/sound/soc/rockchip/rockchip_sai.c @@ -1434,8 +1434,7 @@ static int rockchip_sai_probe(struct platform_device = *pdev) ret =3D devm_request_irq(&pdev->dev, irq, rockchip_sai_isr, IRQF_SHARED, node->name, sai); if (ret) - return dev_err_probe(&pdev->dev, ret, - "Failed to request irq %d\n", irq); + return ret; } else { dev_dbg(&pdev->dev, "Asked for an IRQ but got %d\n", irq); } @@ -1458,7 +1457,7 @@ static int rockchip_sai_probe(struct platform_device = *pdev) =20 ret =3D rockchip_sai_parse_paths(sai, node); if (ret) - return dev_err_probe(&pdev->dev, ret, "Failed to parse paths\n"); + return ret; =20 /* * From here on, all register accesses need to be wrapped in --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA2E390C85 for ; Thu, 6 Aug 2026 05:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993789; cv=none; b=ce9NbFmXK71+uneXilapi71MbF8flgjDjJ/4xB9afWaAgtq8dJ12cFNeNrAmrgGCGzwV0vcPdlLCxeKxzFcZoZo5NOvQtGG7C3CLO2cTpk3xzjRPkZLf/5fD1sHkCvRWCMfy7Yvdv734mduvIGLpo8f6O6Y1D14HQTWrc5ANgvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993789; c=relaxed/simple; bh=9x7/N0DyiD4BxS4+aIJAxVJ5PjBthzbB8em/M/0p6iw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g1LWVuquKGgPg89daZdeTxo8TUUABIY1o/4m+DRdFdaI8/evi5p/DlqjtJHZTXCLQICoqZ+p1oYHrIM7vTMCNnpQslzK90sIqTePXndi0++gwvTbkqvA0t7bW/XxgACd7QOIUIROo3kTizAbEBjsUQwDZ8EfxapnDTT6GUkhxbw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bXhpkFYs; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bXhpkFYs" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-84864086bfeso1464511b3a.1 for ; Wed, 05 Aug 2026 22:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993788; x=1786598588; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1Ex53QN8qUaM4ezvj3nywtUMeXIR5OlcqRfF6FOJ3bY=; b=bXhpkFYszGrV3dNzouIXyup/ldndg/q6tlM5PyTP5tCHXcHFpSYTq27JQPpoGvDm9A szvMeHqAG3ccpKiRJCghevYTEn+beocJtJkMo67L51H2z0F40kRl3WmB237fcXgndgQt JnQdptMEQ3BVZT83d2kwBGk7EnfSGFg4MXc/z+cTOJKxKlv5YwxE+pcGpUfbXKsi5FRM aO9kYEX0WZqeyb8IWNLr6PXaHPPj7SymJZ9RxRSgaV5S94IWNOX8e/fX50yjXCBIYy6m VudE76jKlhDPgf22gcZZcEk8QUK2aGUyxbbwKe5sv5RUnjX+ijjVx0Z/9B3fwEOtvl+g hhYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993788; x=1786598588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1Ex53QN8qUaM4ezvj3nywtUMeXIR5OlcqRfF6FOJ3bY=; b=McRSAlxZ8Ix4zYe2RSaa8qsxOG7Pf5PP0SaAoPKjfe1MuL3FCaoNxEmedyLND7ASoI clN7eV+uxt0M+8/ByrVslid1qOF+eGds/pkPFtO6ypbZD1bN+iqY0EZyhYYjpAHwyqRe qYmnRvthy165Td/VfOFmHdG/ZJk05fTDm7udUtU/mctHgMC8lEbMVK0ykwdcJ7X0Yxeg iKoR1DYikv1YaRGklj7KsLwgfcLfcMlu3g0dZf8Jh/LiyhD4njy1TL0r89G81BrFb/ap 670mvBLLC0QGl7bD1Pg/fMF0GQsTMskOMlScpshXgbhSbHcEr7CiJqOsPsZzSj3mkqRb J9hQ== X-Gm-Message-State: AOJu0YxZzG5eZRzUAmZmXiNacb2KuSccf4RGb2lEXR/ofoXNghBqRhZO Czsfjg+CnAFbDY0CrTmdcagUbxdqDDJhhVEB3KBA8nBklK7StYK6kBJu X-Gm-Gg: AR+sD13jljQBohWhIwFDFSzs538I/qyqIl9ybLYNsTuwkVNFBIqJUpJUj3i7WKPnYEL S6Co53NJywmH9dV3IenRbYUxDK1MLWSjn0/3rQwn45Rwad0BiqPnourPC3LmGpoYlGi2j0oRU57 x+/pi322HTKstrgQqrZb3i5F26BvvPx96F8j4oF9xSaFLYd8mbHvIiU1zc5drxdMiMEra31P0RY iLzwlwYDGszyAAWGFS8RPHHWROtJAzmq15DbUzaBb7N8zNBCqi3YoP+tiRI4b2uTC7P8aKFUnKI 6RRGSHE4OGktn4gvMaWmeWiW/Pe4EXGJKlX9HxO2rJSivEcLXWvaW4+PnJ+/pAdYF0yub6UHgVb u/RwK8l2Ic/ibWiKGv10Yfjid7Zvgo0jws9vDnDbZIhyaPbJkxy9PDG1keShUdnWiSLDMz/QyHu d5/EJK3hUjjbwqYkaf8xt6bFh1SmW8Voyzo6n5tfExb6ZNWx+0P1xb7f1OtCV0QSALhxRYYgJIb W/WhGmI5NHSu617CHPyg2EDvQs+uCZTl/vVw4+8F9333YLJjDH4L62Uc8zLi+1/tOM89EOO8nIx 8J7J X-Received: by 2002:a05:6a00:3c89:b0:848:7f56:1e44 with SMTP id d2e1a72fcca58-84f2dfcfcfbmr13260578b3a.7.1785993787706; Wed, 05 Aug 2026 22:23:07 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:23:07 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 13/14] ASoC: rockchip: rockchip_sai: Drop redundant probe error messages Date: Thu, 6 Aug 2026 12:21:35 +0700 Message-ID: <20260806052136.21034-14-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_sai.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/rockchip/rockchip_sai.c b/sound/soc/rockchip/rockchi= p_sai.c index 1fdec12a0d4e..30b5e71d0937 100644 --- a/sound/soc/rockchip/rockchip_sai.c +++ b/sound/soc/rockchip/rockchip_sai.c @@ -1472,18 +1472,14 @@ static int rockchip_sai_probe(struct platform_devic= e *pdev) return dev_err_probe(&pdev->dev, ret, "Failed to resume device\n"); =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); - if (ret) { - dev_err(&pdev->dev, "Failed to register PCM: %d\n", ret); + if (ret) goto err_runtime_suspend; - } =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &rockchip_sai_component, dai, 1); - if (ret) { - dev_err(&pdev->dev, "Failed to register component: %d\n", ret); + if (ret) goto err_runtime_suspend; - } =20 pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_put(&pdev->dev); --=20 2.43.0 From nobody Fri Oct 2 01:54:21 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D67387375 for ; Thu, 6 Aug 2026 05:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993794; cv=none; b=FWDWefzPgYZxi4ohd//I5r7yA1Qmy4Fk/nRqqM7ozBQ3i6FVto6CKMtSx9ZdsZXq/PLdzSBDsEYEUn/FtIhUjfWRX3yglSeO5G/R+UA+OIjHhIz5ub25IpZFt+2L3hL3smRpR8k7yaMrjScu7lB2byL6TjtRTId532rQZjbIzfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993794; c=relaxed/simple; bh=sSXF3ao+JS2PxAoloNsB354hf3yu0bleah103QwAXjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tqO0bt2rC7dzv7SNXDdXNRQ19ddBewDafGXgU+nlmKVNZrpawSrmVSVAX7o23fq/y6XKYx7X7lPZ5VeR+y51LwbPZZ+E+EyydB/9bUw4vSHgBUR+QNcEIsMqGSMeK8TJgTaNW2eqzodBe3pxUOylIsZPFMNB5g2F8Zz8RpVITB8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lnp0iEUN; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lnp0iEUN" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-84f38f3b36eso1067809b3a.1 for ; Wed, 05 Aug 2026 22:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993792; x=1786598592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rju6HFe/S+MJe8cf6yB0HBsbdDH7a0Yg40XL1i/Z1yY=; b=lnp0iEUNcwv5RkyyqZQt9BkmcSBquzQ4oj7ZWd/JUtTnruKiyHV0K1rQXqf/APh1xJ 5X2jlg04j69SqWVw9OnKsUeWxB5+2xeMHePeemK1uNSse6MpGyJ/pvkFY4jHYZMI8Cso hLlQ+CII3bDM/NEfbVQs5ZAYH2iYSIfAsQ1ZeU81/XjdalNaHakBUDXkaFl9Z4/CpN59 r6S/99vKFXFmZgxj9WURY6LDtVmoOvIt+P/BhLtPuOg7iwb2xlCoOqjEEGbwlQOs9EoU +8zNjhD09gVKooy+Et06nlb/cH5yDPQQmn/12dp83ibnjO0MovPbvL8RMbwm3r3l0xYO 2bjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993792; x=1786598592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rju6HFe/S+MJe8cf6yB0HBsbdDH7a0Yg40XL1i/Z1yY=; b=mtj/h+aIrtbn+Daz8TgcUaO96iuDba/gqPDbg3+F0PeyliAhH0F3hQrzbaxZqbPTlT 15AJUMsrG3ZLeaHoovICUHhsy8CE6vcWtWOZHLxrXmo7aapQLOdW2+Afjxt8AviVE1ZJ 65DI502wNkQ/6HFx9xXF081vN+YiVWE/rn3VtxdwEIlCsY9U0oUGi6bLROo1cEE9Uj3j 5DIdq6bmm1M1LGCvfvx+OuyZRkI06ICX0vFvr/WJeBkC7a9jZ77itYVSQeAKm1T6HN6b TW1GiGgPYpqwmdrwxd/2bJEHQ9MnT3Tebg144O/sDa4Uf2oVNaqFya13wBceJbxHmTcY oe5w== X-Gm-Message-State: AOJu0Yxc7ntdgtNW/9Yxzlgf6hc0D3ZSduwJ6j/O467LGZfgQE32nUaQ DFe0/68dAhTT0DicKqSQ5ZPz1wz6NlHunc33et2G09410L2NosttqkRwsuVqfQ== X-Gm-Gg: AR+sD13BxEJYoiLHFNfjJHQAaysuKWYs+O63bpXA/nOhlpl73Ip9mpy4WBCVx1o8PGF wJvAQ0xxDhYSdcH40Ey7zgoMNYF2OGRakBJJ89hNTmzvN7gYJcL9elUVMqMHsMGME5xrUXUnneQ 5gmbsgZAbrlfyxHN2//x6FRputEIUwviMpUrcVY2a7MxbEgN269Wx3KjMrPaPnrpoDeyJCi+VxK aZnE9xF37wco6z0O80OgHJHltxpDHCJJjJ92rTv2deH8di9AOLN87xFf6qmML5rN602eH8TD035 q+6MKzrwfs7NTcoyhv2CVeByWIGFNIbsGpUWOJ5BaE5aEQIgTL/tIKEjXrzbJNqOvJ84NlepwK4 PJJ5QCm6EAfah17pcZS1K2r7QNqj7msyJyuyhbvi7aR3LKnHBnyIjeGJc3Q64ibWlj87rux/nsK Ca4QTkOujFC+BepLa7VgmxGxOtrjqvYiY0veIS9jshS5QrXSV9JJ2xAQxWPtCeLRJIJdtFsxp+T EwQFTGxsRYX28XFo15X8iN9UrhpK5ajYoPOvwmSZ+ohaYs+A5Ht7T1OtXDM+WyrXUV042I/rD82 /Xa/ X-Received: by 2002:a05:6a00:2e1a:b0:848:42a7:1854 with SMTP id d2e1a72fcca58-84f2e0c9c90mr12879556b3a.39.1785993792226; Wed, 05 Aug 2026 22:23:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:23:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 14/14] ASoC: rockchip: spdif: Return the original error code Date: Thu, 6 Aug 2026 12:21:36 +0700 Message-ID: <20260806052136.21034-15-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Return the original error code directly and drop the redundant error message since the called function already reports the failure. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_spdif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockc= hip_spdif.c index 7f15bc7f8f35..2d53efd5dd2e 100644 --- a/sound/soc/rockchip/rockchip_spdif.c +++ b/sound/soc/rockchip/rockchip_spdif.c @@ -396,13 +396,13 @@ static int rk_spdif_probe(struct platform_device *pde= v) =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); if (ret) - return dev_err_probe(&pdev->dev, ret, "Could not register PCM\n"); + return ret; =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &rk_spdif_component, &rk_spdif_dai, 1); if (ret) - return dev_err_probe(&pdev->dev, ret, "Could not register DAI\n"); + return ret; =20 return 0; } --=20 2.43.0