From nobody Fri Oct 2 03:37:07 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC35931AABF for ; Thu, 6 Aug 2026 02:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983982; cv=none; b=jmkK8QbbCAD+l/Cw7aC3QlKB264eqikiuIvJb/vpCBTLiZX+rMyTOQA1YBp57zJAyW7V+j0fBiRWLZMaaDcuqgSM+ZypnuPchcZXklY1XI9nViCdLIZ3h3cYw2bG795q5klfpGMwnuKsM0zw1L4ucSsWCO2Ha35+nkd+l9F1jd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983982; c=relaxed/simple; bh=5C7wceqaQFO2f4qXEFx21ohpcplYEZ+eV+kQkbGuCaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lqut1iUtEquFGEgDmwb4uVEQ4c5Fy47OACCTLYUjZXBZhM+jfJUMUXRTl72yjZPMrbDYtywO7fB9U19cDEt8rJ/tbdGQHRDtlBarDwn0B9bZEmpiyTyYi34lSWkDKa1BNlbFrCuVRI2mJAAcJ3wjNcjepJRh6tms3uSD9SAbR7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g0FA+eSA; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g0FA+eSA" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cc891373e0so21326145ad.2 for ; Wed, 05 Aug 2026 19:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785983979; x=1786588779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=g0FA+eSADRw2B6119f5psjPTMxSFsLI71y2D96eZDdxzSErTKUVi9TlvLcLanOm2va X/18z8nqaHoRzu2QiQ6h+94I2cngetdRuNdg9cP3Rk1x56d46OFQcr+075Uthx7L+n4h Tsz7uyKmt2us2tkI60bY4lm335es1ODUNVdqY3JsNIGTb/pbr+Ef7MzjPtKnRwL/ufx+ 7CTIMPuhiAkn183BcWEM292JD1NURmj0BhLcW5l/dRmoPXe9mhPFAIGL5ISUfHsm7+xh 3S8ZQi87ZodZJE7aMMbgSU2AQ/i43bImLWqe3wJda5SILd2AYSJgCouLtbANl0EznlqC 3csw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785983979; x=1786588779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=ll/k50LFkIpJX4jktHVvMxj7Ui2YeELy4lxVZpYqzEbF+/L5rDL0u7xPJNwqJqi1xw CIq5ZCZ/XalKH5BoG+NN7iXD20npq9XY6KpDKm9ZEQN3A2uZThXNzMRTmJkLqd/LWXHz y6wvLQt3ZGVenup0I1j+0YCsthsKO/GPbPOxEmxfu16c2h64UWg/DtCZ8RWMDvdAfvzk Bjv2/T8RQslAz3m6up4QUzS0HDut+h/5YIiS2YXihNgbQF3d0PIa2Gh7z/QP9TAvG3fz fxyioYBdOmIJOMZwM8XL5hDEanqLb3bzfsq294Ld/M2qmEsQT2ycQh8eWf+1V12BZUSY zcAQ== X-Forwarded-Encrypted: i=1; AHgh+RrwO9/V3CkoPz+NzCClyPMOE2My3hkry6AI5f99cW3Ras8jObkxXFZ2Rlpf9PmK/HEcXEkE2BV+SfilO3k=@vger.kernel.org X-Gm-Message-State: AOJu0YxCqAuH2GQuHy3lu0DyoKKEdVhA2oUZ4d3M9CdsYecTiURII7xF LlUG0b5HA+MgtY5IfYON8YcUgzvQ7Kcbqby8Z9b0SGWks2q3Gnt1akIE X-Gm-Gg: AR+sD134OL3ipYEgFrtDPKJkIYvKuLwm4O+SV7jKVAZH8nPH1/tPnHiaxZWf6yv6q6L jeVLwdxZuMLOM+fw6fx/mTVXveSGLY15Q8Qvnt4UZTKOWjTChu4ACknNLmh5ooQt3iV9emfWzgl bp/01RsrO95PQK/5bBanJZKgcagtiyzAiE2xdnijM428u8dt2UMzAXFID206i4j1n3lXbzyZxoz D5pN1M3zXPb+UnxtR1UE8qSXL/YKjrEZQY6t+5R4ohCOGlfHOCpqkajnlHuCLXZnMbz0ySCUDNb T1M+JUEF6PPsAy/RCpxCtLHg8f5wxGMcMerlLp5AlSWG+pRrxqClWdROrs9upnwkGzEoBQSNM6p G4MwIQgP86xX0Z6plHoXXaBCjmSbw0UwEKiGLsJmMsup4TbWVfpzLKmDw6b0q7toAftv4q+2ry6 20miuH+6+oJlywgX4UtHjFoS57g5Otya1sYMJ/7PqJc5kf4qzEzTHp7meNgzqyC6nkSJMP6Q== X-Received: by 2002:a05:6a20:430b:b0:3bf:9b3d:61bb with SMTP id adf61e73a8af0-3cb85ee779fmr13430627637.16.1785983978646; Wed, 05 Aug 2026 19:39:38 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:3194:1e48:e141:80ab]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867d4929sm22404383eec.30.2026.08.05.19.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 19:39:38 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v6 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages Date: Thu, 6 Aug 2026 08:09:00 +0530 Message-ID: <20260806023902.8608-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806023902.8608-1-mdshahid03@gmail.com> References: <20260806023902.8608-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid devm_request_threaded_irq() already logs an error when the request fails, making the explicit dev_err() redundant. Similarly, iproc_adc_enable() already reports failures, making the additional dev_err() in the probe path redundant. Remove both duplicate messages. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Suggested-by: Andy Shevchenko --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index cf4738b16e62..7c2e2770cd61 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); - if (ret) { - dev_err(&pdev->dev, "request_irq error %d\n", ret); + if (ret) return ret; - } =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); if (ret) { @@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) } =20 ret =3D iproc_adc_enable(indio_dev); - if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } =20 indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; --=20 2.43.0 From nobody Fri Oct 2 03:37:07 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1659931DDBF for ; Thu, 6 Aug 2026 02:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983990; cv=none; b=jJryNDGEB4mvLvj4he2IVxWGhx2JTQWqYGpauWTeEfEAPfyXupKWUNX5gAc7DhuRzZxS3jLqBAVWw6whmtzo8vNSUpUrLk0SG46e7prxCfUMreGVg2GTCF6c10p+ZXNzNuo2QPUHqtxnvb1LR6p0s/+rmJzwpbm4JZ6uYVUP+Z8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983990; c=relaxed/simple; bh=YFBQMGpv/fzc68+3vSr4+6oulYuybifQYme219waj9A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X0Q5gWJBH8PCAWicXv+vpT+qRDSt2iisWcWP4HavgByyniRTpa0YYVN/N8tz4/kneXQoe0oF7waNNOQEtra8EP+IiyYId3FqA5LXqPW3puB8TCPRspcfOeVpaitalH+/jpLif4mTzYaznVNKcbVfiVwOgn1Mrx6up8QW7yI62uo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cx9Z2X9p; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cx9Z2X9p" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2caced6038eso5645135ad.0 for ; Wed, 05 Aug 2026 19:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785983987; x=1786588787; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xYUmODFIR/IRQId3RZvFC3D9rE53RZwWUE1u52S9Ovc=; b=Cx9Z2X9prG439Qpc1BuI/mdzQ0g/aNXm6fqBbRIwslDjNMB07dYiavSAntdw62kRcc f75lIqRP5JJucDPXMR0gm4yDJUWiBlVstD5oFzFByoSL9byl9lzMVGX0HBFvAt5pTNtX jgEB0qR1cqJAFajTITa6s7A+ymQC8WmBt/rvyYSlcqRaFBL/1rOY2gSq6fUAqlLSbBDc atzYttF+u4P5wH1XftEZSggWvs1yCT+evqykA200DXuJcjo4sQXy5rlRyRKrNTJo4FMN GTLSkDOkkHb2+k+JlWT3kKDciVisRKc7Ioif60mbahDbBuKcBYQwnzR5BJyXKinnqumz n4/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785983987; x=1786588787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xYUmODFIR/IRQId3RZvFC3D9rE53RZwWUE1u52S9Ovc=; b=IWUSnXdth3EHDaJucDQ2F7TpHxZ1HgL4erae+kVnBbndHA0I3SI+ySxGi6VXZUvPiJ SzB1M1bgmn+1xZtlT5LKOGdl1e5ryhqWWutk0lC5KYizTGg1yRgytPg3MRU2BaN+fjw9 SlTNXu5P5z3/chiZboaLztxyWGukSZ2sDLvBaBt24iFUlwFvITzXm7f7bJVERg7J6Zts aTyq/Oer4DuxdMr+Wf1IiBzbZgwdPpiGEbmijM5my9Y0JApVAuLqd7/9iHYMIbyIAskO lYXhYT0QL7WK/C9lDsejEmcXdjmLG0IDYr5WtMJQKFgZukhzWecCaTBMR3/eE15BV0lm yjHA== X-Forwarded-Encrypted: i=1; AHgh+RqBuhSPpT5okty7d2xNeK+C0J+EDjQ5FYfpg/XxJkDYOu8MiO/mz/BZZGLspzV5goCDdrQQSbb0pst5SzY=@vger.kernel.org X-Gm-Message-State: AOJu0YxqH9TFONNkhCXKN5D2g6gddi82qiRxFKy+3roKdKmPDmibCfw5 l4d8BAgFYGG8Co8jZUzYdVbUr0NJ8StTHCT36pdaJSG7f1a3k4oQy195 X-Gm-Gg: AR+sD13/VW72BIB7VsTtXwvf8rsXZza8ndDnctYdgnlHOA4HpbyzEZFuNI3OntKBxGS Stm0pXuF2Y+q/dA5RW+P8aotVsgOA8Dq7MAWuxjlZCD1Ggj65wMeoLPE7CBC3Wokzl7N7BfXnWy zJMIbV3GNF3cjWLiexqFsA6zigC4vjaPjo5wBzGlcGIJkWj5vetGt5oRBsODy36VTf3D81QJVNa LgG3OQsGITgP6sR30ja+40itD2xcBmAK9ijL8/m3kdVQs/Z437jdxF5H0KDYdfRsmTk2Oglxdcv DTUhcqinYTZnKEddSUyOJMx0w0dIoocmDB16p81MFdVF9qJ7PUyiQck9wktsQHRVo6tKX5VfNg2 wzLSgGvV1LFDuVFnOdLlLxzqrTCbKmz9BmeQztcYq9/fo5ZYcJo6CLrWMkLwV/d1STkJ7MIIZGA wcS+ku4sW01znZPAeNoZjvSTkpzm28VV8XolpFAbNsrXaHeSSM1pQ4lrBTgCw= X-Received: by 2002:a17:903:38c4:b0:2ce:a6a4:451b with SMTP id d9443c01a7336-2d0f1c130bamr41161845ad.11.1785983986900; Wed, 05 Aug 2026 19:39:46 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:3194:1e48:e141:80ab]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867d4929sm22404383eec.30.2026.08.05.19.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 19:39:46 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v6 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer Date: Thu, 6 Aug 2026 08:09:01 +0530 Message-ID: <20260806023902.8608-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806023902.8608-1-mdshahid03@gmail.com> References: <20260806023902.8608-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Introduce a local 'struct device *dev' variable in iproc_adc_probe() and use it for device-managed helper calls instead of repeatedly referencing '&pdev->dev'. No functional change intended. Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko Suggested-by: Andy Shevchenko --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 7c2e2770cd61..a07a590662c4 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -506,10 +506,10 @@ static int iproc_adc_probe(struct platform_device *pd= ev) { struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev =3D NULL; + struct device *dev =3D &pdev->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&pdev->dev, - sizeof(*adc_priv)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*adc_priv)); if (!indio_dev) return -ENOMEM; =20 @@ -528,7 +528,7 @@ static int iproc_adc_probe(struct platform_device *pdev) return ret; } =20 - adc_priv->adc_clk =3D devm_clk_get(&pdev->dev, "tsc_clk"); + adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); if (IS_ERR(adc_priv->adc_clk)) { dev_err(&pdev->dev, "failed getting clock tsc_clk\n"); @@ -547,7 +547,7 @@ static int iproc_adc_probe(struct platform_device *pdev) return ret; } =20 - ret =3D devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, + ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); --=20 2.43.0 From nobody Fri Oct 2 03:37:07 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E6F730C146 for ; Thu, 6 Aug 2026 02:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983998; cv=none; b=qplxRYGokiNzyDfUx0ThC5A/jG8cQJNPhAFydtWCl1IZDgM3KFjVBj1NJvfsVEodXMiuAp+0xKcyKM0NR5dHftPRcsMhSB+iMxpTor/ljbW1B3FIhR8ui4TKV7IeFisnBmVAIqJpQg8NKfEfJzIra7+njuKNbdgL81LD9bxtxfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983998; c=relaxed/simple; bh=M8tT0y/IrWzDMnOAxgfoVUtKKOFefTBOA3AwkfDqohc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Msbg7il0/ITaK7U+b5grJWOUrOzQpCjelXFhGYL/860kaYsJQFiCIKRtQOf+M7QpYvUYCkBvsz5UB2yrmWxreJFKWm3xZpbrs7DleMTACTNYhlSNEX8sab05SAFFIqIenBRPU8+3mHPm8PsfEr+CIp62ElM2DufSrrwcADZmHxk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XTbWHkFo; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XTbWHkFo" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ccf2360620so16971415ad.3 for ; Wed, 05 Aug 2026 19:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785983997; x=1786588797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j1R+uohEcau7J3FUtUcinA4r58oNSFhdAhr/+2ENdYk=; b=XTbWHkFoVJW/HaarYXOg2XaBgSgGg4hmNWkBc6xdP5JSr1D3eEC42lcshX0j+rCbgp syaxEpIFR6x+nxms3FKgOcpNvJ/QKv9K8pF6TvRJXkCmNWdb8R3bvrnEumBr8eaXQuBV bKH8AMIp+3c5oW9YGb3lywu1pxB2IfvFJT06OyJo31JTB/cm5PhkKJsnCrPmftKSHsDz T6CKnMpHa0eT6edEjMW2o3QpiMWb1ONo3GskFutZAkQKUZB8YyGOecjUmL5yq5SOWqBY l4dpGv/k0Z/tYyN9a4DCdQq6tMoXHAw/zDCMZ15EDy53f1UN5pKFAI426WRE0iuh4OBa amYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785983997; x=1786588797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=j1R+uohEcau7J3FUtUcinA4r58oNSFhdAhr/+2ENdYk=; b=foRgk8iMqFZR2f/0Cmb/F6xmYIIwfIhaXD15nb39gPChklhyWelCd+H1e3OJfHM0UP Lj5wEIJUsWAIRxjYsQHRI53m6L5aKJcIroOu6NrLbB7a8adPxnIgusdqAac6jmK5Kcit xaSh+WOsebQiTqqOWiO/sz3uEsCmgCyaUn57d2DSRNLxXKNAWxPeGQGHHIdL66W6434I zO+/oD9d5QeiaSRSy0lCuNtgpEOXZwcRGiLj0YiScrCgr4CyJrvF2t+OSL/agn13ofbr WUuAvjDe4ne54fCK5xNQ5tNS+QuwvkvhHefsNn9zp06MX2faxN3D+tN9zIXEXhxGIBem 0r1Q== X-Forwarded-Encrypted: i=1; AHgh+RofEdZceaPSNHRB23JWBuqQOVncoagSrN9Ux5pvVqS1vS1GaKpnjyT3IrwWjn4gTUejERQwPSLd4J+nQ20=@vger.kernel.org X-Gm-Message-State: AOJu0YwTM79zzWt3/3eorq/E61g31OOwwhlbHqC94grZKUfF6pU0na0u wkABYBkKM94r+Uh2OzeGKbFddoWv5xRBXVbs/XiXDU5UY0X+tzot416q X-Gm-Gg: AR+sD132V0dIu3A70OB8wp1PY5iiRHZ7to6S+UWFNavJQ1NEPHYMWXwtqo0sd9VSbcg tEF9wDO6ILkECRL1OtOte6cvQdFhmdO4zWXmA267RRqKaCes5/R2MxiemoRk3A8xcDgxnCy4Afi T95zri8T7mnLhJ33fQ23AbZT5O8dg6tofKvqwnLBCcPdIwu7Qx2z8zWmtbPH4wyKD9vsNwb9Sja cn3TnmsMAsJNwkZdXVxNKp97XtP/LAKhSXHPPiJ9XyZmrtvfwn7N36pzHGqhcSWD5X9quPT4HpT kRN4NfLWgA0H7fmAEzeUhBsaiaD5z8uOVMgGzmQhfH3vPvn+LAef9O1pNyglNvV7ejFdwM4xVLt 8f+A1er/t3mW7ZJwrRPqPM6w7AnkYg35rksCD22OtR7COCKTA+vthZngEsEGNLNLnZzYS/MSs9m yzAr7mqO/mH3ExR78X7b3RUWvakkVTLBQABLDzlH2T7tsKEsAnrp5OAI5e3nQ= X-Received: by 2002:a17:903:3888:b0:2ca:eea:eb5c with SMTP id d9443c01a7336-2d0ca98137amr124962515ad.18.1785983996637; Wed, 05 Aug 2026 19:39:56 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:3194:1e48:e141:80ab]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867d4929sm22404383eec.30.2026.08.05.19.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 19:39:56 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v6 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Thu, 6 Aug 2026 08:09:02 +0530 Message-ID: <20260806023902.8608-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806023902.8608-1-mdshahid03@gmail.com> References: <20260806023902.8608-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Replace open-coded dev_err() followed by return with dev_err_probe() for probe failures that immediately return. Leave error paths that jump to cleanup labels unchanged to reduce code churn. These paths will be converted separately together with the planned devm-managed cleanup using devm_add_action_or_reset(). Signed-off-by: Mohammad Shahid Reviewed-by: Andy Shevchenko --- drivers/iio/adc/bcm_iproc_adc.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index a07a590662c4..ab66b97d2f04 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -522,19 +522,14 @@ static int iproc_adc_probe(struct platform_device *pd= ev) =20 adc_priv->regmap =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); - ret =3D PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(dev, PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); =20 adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, - "failed getting clock tsc_clk\n"); - ret =3D PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); =20 adc_priv->irqno =3D platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -542,10 +537,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) =20 ret =3D regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to write IPROC_REGCTL2\n"); =20 ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, @@ -555,11 +548,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) return ret; =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(&pdev->dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to enable clock\n"); =20 ret =3D iproc_adc_enable(indio_dev); if (ret) --=20 2.43.0