From nobody Fri Oct 2 02:32:17 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F0037C908 for ; Thu, 6 Aug 2026 00:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785977900; cv=none; b=sD0VlDxNbDPdSSkramR/Q1ADOYfxo1cK5WhCHTyIvkmI5LTLjarVQ7o3gKpXafJJ5TRumU9jrWB+pZ3MnueTkPAuFgZBEFSIHpIo9qRP+I/aEwtQASuGYfxGHEUPMi2QAGVa+4BgGmhRFQZ2qF7OrZm3FM0R69kzZAFYzu5kquc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785977900; c=relaxed/simple; bh=p3gQ3V5lPrbBodmGXYYPbqLC+6rJ5taHak+64LJOvCk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QcSh2jGVZnJ8jv2TdbOmR37Nrosw/Xt33+x/74zLCxOUOXaooLQCjoioDbGgD0Ge2Mq5tyPgKlv+Ip7/yh0SvIcBGZtSTVmwlwr7R8XcAFqwEkVfArfBMQk79OXTFIMxZ007h/g5r8L9NUX0Wb7bD1sr/m1mR1tP0i19N/IYW20= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: e6108190913111f1aa26b74ffac11d73-20260806 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:8fb739e1-cd3d-41da-a0ee-0b9c72446819,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:23ec8dd0e744401c2117368f56c3174c,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|136|865|898,TC:nil,Content:0|15|50,E DM:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA :0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: e6108190913111f1aa26b74ffac11d73-20260806 X-User: xiongweimin@kylinos.cn Received: from xwm-tianyi510pro-14imb.. [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1369375574; Thu, 06 Aug 2026 08:58:12 +0800 From: Xiong Weimin To: Brett Creeley , "Michael S. Tsirkin" , Jason Wang Cc: Jason Wang , Xuan Zhuo , Eugenio Perez , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Xiong Weimin Subject: [PATCH v2] vdpa/pds: check virtqueue notify mapping Date: Thu, 6 Aug 2026 08:58:09 +0800 Message-ID: <20260806005809.1875257-1-xiongweimin@kylinos.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vp_modern_map_vq_notify() can fail and return NULL. Check the notify mapping while adding a pds vDPA device and use the existing teardown path instead of storing a NULL doorbell pointer in the virtqueue state. Signed-off-by: Xiong Weimin Reviewed-by: Brett Creeley --- Changes in v2: - use dev_err() instead of dev_warn() for the map failure (Brett) - collect Reviewed-by drivers/vdpa/pds/vdpa_dev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/vdpa/pds/vdpa_dev.c b/drivers/vdpa/pds/vdpa_dev.c index 43426bd97..77d679f67 100644 --- a/drivers/vdpa/pds/vdpa_dev.c +++ b/drivers/vdpa/pds/vdpa_dev.c @@ -731,6 +731,12 @@ static int pds_vdpa_dev_add(struct vdpa_mgmt_dev *mdev= , const char *name, =20 notify =3D vp_modern_map_vq_notify(&pdsv->vdpa_aux->vd_mdev, i, &pdsv->vqs[i].notify_pa); + if (!notify) { + err =3D -EINVAL; + dev_err(dev, "Fail to map vq notify %d\n", i); + goto err_unmap; + } + pds_vdpa_init_vqs_entry(pdsv, i, notify); } =20 --=20 2.43.0