From nobody Mon Aug 24 02:11:24 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE2B3438A6; Wed, 5 Aug 2026 18:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954717; cv=none; b=odJon3mSwRJeYag7Bb3vmGzmJ/tvo0puHfoPu7IzTzU9deUlxQLm1ecDBgjL3g8RNuSqbkNYvLwuYwuzpp1cDuVsCeVTeNEXasAkwaqs8Gnj73qBtG0NHafE/Eq8aUyIs1OlctcK9hzu4gF1oP6P9bnoCavkF+zyIkhLvZNYAC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954717; c=relaxed/simple; bh=/1xd9FcrcuoZEf0AG2YzECqSMJoaXrUJV3FPwrR9cfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U2Bf0uYfBZMSXPGd5D8ufmNOnp37AYD9zwIPvkFFSWUIf7As+dsc0+rT2KqHpVdFxRxDkrWoURfBt7iweJSJvtRiqFMZyU2UKfR/Wfj4uUqOgz3JBF2u2KgWs/On4vEhDN2DQpNozkJ1/mKkn+zqfTRBU2IsIUy0ePviIzZ02Mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=K4Kr0nOU; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="K4Kr0nOU" Received: from mail01.layka.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 32590C2AD3; Wed, 05 Aug 2026 20:31:48 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sLTtvQBgWqNd; Wed, 5 Aug 2026 20:31:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1785954707; bh=/1xd9FcrcuoZEf0AG2YzECqSMJoaXrUJV3FPwrR9cfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=K4Kr0nOUGDO94ypW6ZhHUNX5ArfCLcyaWqdYL7zLasqwZRsdKiu9Lx4uWxYO8iIXb sLCX9LBe2I2fjJyaGIB4qwLN4rAcoTwG/e0qH3vExmO89UDrQS5gHqPlA3L8/eMg4K EcnUP4W1aEHLPBQKUBJnV2vhAjXMuIVl96RCygOZV7aOdKq2DxPS7yDOM7fpuUQRDQ oBMbznSqVZForEOMxbE1kXRLgBeBltDD3bJcDeMyMMkVUu2Bmaae2bGJF5nydJ67MU 171DEKahZPKwNtcGFOpO80iVFQIJZb5yXXyc/4PqYnJn7tqwXfbAAyLLYhmMZLEsOI rFoF59wKuuJ8Q== From: Marco Scardovi To: Corentin Chary , "Luke D . Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Scardovi Subject: [PATCH 1/3] platform/x86: asus-wmi: Add ASUS_WMI_DEVID_DGPU_POWER_STATE define Date: Wed, 5 Aug 2026 20:28:06 +0200 Message-ID: <20260805183131.3075-2-scardracs@disroot.org> In-Reply-To: <20260805183131.3075-1-scardracs@disroot.org> References: <20260805183131.3075-1-scardracs@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add WMI device ID 0x00120097 (ASUS_WMI_DEVID_DGPU_POWER_STATE) to the asus-wmi platform header. This device ID is used on ASUS ROG laptops to query the discrete GPU (dGPU) power state level. Suggested-by: Denis Benato Signed-off-by: Marco Scardovi --- include/linux/platform_data/x86/asus-wmi.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/pla= tform_data/x86/asus-wmi.h index b5ed8c83ace1..289be6ac7335 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -140,8 +140,9 @@ =20 #define ASUS_WMI_DEVID_APU_MEM 0x000600C1 =20 -#define ASUS_WMI_DEVID_DGPU_BASE_TGP 0x00120099 +#define ASUS_WMI_DEVID_DGPU_POWER_STATE 0x00120097 #define ASUS_WMI_DEVID_DGPU_SET_TGP 0x00120098 +#define ASUS_WMI_DEVID_DGPU_BASE_TGP 0x00120099 =20 /* gpu mux switch, 0 =3D dGPU, 1 =3D Optimus */ #define ASUS_WMI_DEVID_GPU_MUX 0x00090016 --=20 2.55.0 From nobody Mon Aug 24 02:11:24 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 714173A254D; Wed, 5 Aug 2026 18:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954719; cv=none; b=rmFDvDcDJWbGBd7x5jUMyDkFnEzUwDZP2QA9iiSw9WtBBB4Gi+aKLW0pQ4aL1G/U+2sHnYIJhfGdqCaIDMUNNW/GofHA4rCVkqoLkqF4TgJ6pJKG3zcLO3o3FCkXGZdPjuwd9pg+i2x4sNbLRhPsiGFfuHQ1LmF3Hi5UoQ6rFTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954719; c=relaxed/simple; bh=rkp5LBes3zlk0gX4asRgFgJIKzIRzcrn6/epkt4x4ZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CoIKQONO3vy+4UzPSBhy0MbM6u5BXzCUY72LcbrvGxACMVLY9YuxPkNYK05riYL/SxQNOV7zFQly7BZkOYMPrvViVFm5IosssVmpWpUnWI6qXOJe06Ff1AKNUfm9lem55ZBXeC/L4PaRaxCqMsM9FcPIy3VAwFOOZg5Atm0jOt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=VjpmUrwW; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="VjpmUrwW" Received: from mail01.layka.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 19FDEC2972; Wed, 05 Aug 2026 20:31:49 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ikZn9S3hmXgJ; Wed, 5 Aug 2026 20:31:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1785954707; bh=rkp5LBes3zlk0gX4asRgFgJIKzIRzcrn6/epkt4x4ZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VjpmUrwW/oWoOd/6vuS0XXTRKYUB6JsLmGY/SaJ9zAwuD1MKbaZIShpMGrf7z3ikk Y+ACBjFkRYpr9t3RdNPnMPX9Li8a3RR54zisUhDgOo6jk0EGFUho+qaLtmJerza3u2 Pxvl6aOtuKjdKb8g6bILtotNSTdZCyaOpdkBtTtOHyK/rOiH7D6TWCPOrKox87Ebwu 2BLiSclVqq6kJbSHY4Pc4+AjprH2hIa5koXz9s0CJdFsbZBww5TaP/gw035Hj6wsn4 a5UYd8C02MDv88FEbc1KkqAnxOUZhzcEKVFAI/hmxDn1lw5fMqd28/6tEBeRruFKmc zur4+/7WowWRQ== From: Marco Scardovi To: Corentin Chary , "Luke D . Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Scardovi Subject: [PATCH 2/3] platform/x86: asus-armoury: Add dgpu_power_state attribute Date: Wed, 5 Aug 2026 20:28:07 +0200 Message-ID: <20260805183131.3075-3-scardracs@disroot.org> In-Reply-To: <20260805183131.3075-1-scardracs@disroot.org> References: <20260805183131.3075-1-scardracs@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for WMI device ID 0x00120097 (ASUS_WMI_DEVID_DGPU_POWER_STATE) in the asus-armoury driver. This exposes a read-only sysfs attribute 'dgpu_power_state' under the firmware_attributes class to query the discrete GPU power state (0: D3 cold, 1: D0 active). Suggested-by: Denis Benato Signed-off-by: Marco Scardovi --- drivers/platform/x86/asus-armoury.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asu= s-armoury.c index 93d9665717af..f745924af8a8 100644 --- a/drivers/platform/x86/asus-armoury.c +++ b/drivers/platform/x86/asus-armoury.c @@ -786,6 +786,8 @@ ASUS_ATTR_GROUP_BOOL_RW(screen_auto_brightness, "screen= _auto_brightness", "Set the panel brightness to Off<0> or On<1>"); ASUS_ATTR_GROUP_BOOL_RO(egpu_connected, "egpu_connected", ASUS_WMI_DEVID_E= GPU_CONNECTED, "Show the eGPU connection status"); +ASUS_ATTR_GROUP_BOOL_RO(dgpu_power_state, "dgpu_power_state", ASUS_WMI_DEV= ID_DGPU_POWER_STATE, + "Show the dGPU power state (0: D3 cold, 1: D0 active)"); ASUS_ATTR_GROUP_ROG_TUNABLE(ppt_pl1_spl, ATTR_PPT_PL1_SPL, ASUS_WMI_DEVID_= PPT_PL1_SPL, "Set the CPU slow package limit"); ASUS_ATTR_GROUP_ROG_TUNABLE(ppt_pl2_sppt, ATTR_PPT_PL2_SPPT, ASUS_WMI_DEVI= D_PPT_PL2_SPPT, @@ -810,6 +812,7 @@ static const struct asus_attr_group armoury_attr_groups= [] =3D { { &egpu_connected_attr_group, ASUS_WMI_DEVID_EGPU_CONNECTED }, { &egpu_enable_attr_group, ASUS_WMI_DEVID_EGPU }, { &dgpu_disable_attr_group, ASUS_WMI_DEVID_DGPU }, + { &dgpu_power_state_attr_group, ASUS_WMI_DEVID_DGPU_POWER_STATE }, { &apu_mem_attr_group, ASUS_WMI_DEVID_APU_MEM }, =20 { &ppt_pl1_spl_attr_group, ASUS_WMI_DEVID_PPT_PL1_SPL }, --=20 2.55.0 From nobody Mon Aug 24 02:11:24 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71397395AC7; Wed, 5 Aug 2026 18:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954718; cv=none; b=OzT1pDhdnCp8NjAEy+1EoGwD7D1fwsE+N9FkOEchmsGIg4bxeQYGkTnpVs95kpW3vg9cX1FiaGrX8EVTz/LWPwcH6t0PW51Tbl6GM1JYY45PJfyRPbGCy+DCGjAeECEPA2VDexELXi74DanqhtlyA6ZoQa2qUdPA2QJqNk6qnbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954718; c=relaxed/simple; bh=S91DiBBlcMR6mfD1rEa3LCPErql7ntLg/323ddcrQkU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H5ZWzf3FDkNZN0mQrU42NsIjnBm1nqfhVjkWuiqfThjFl+4zFk3PHZdFkB5zPCojjHpsSOLuhk0NMzDt0ZRaszo9l1lWKzAvbJLDytYVhc2nyxY+D8DZMde9Krvkh5zBQjUBu7nVW6c8BX8xqpZIcsvGfYPA2FInwWGoFbcahUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=Ir/lWtLG; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="Ir/lWtLG" Received: from mail01.layka.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id CB7FEC2AD4; Wed, 05 Aug 2026 20:31:48 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kQOYn5AyvDjB; Wed, 5 Aug 2026 20:31:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1785954708; bh=S91DiBBlcMR6mfD1rEa3LCPErql7ntLg/323ddcrQkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ir/lWtLGJuBRxTobaRA1JoK+xQ/zCVbj2hSg0QlKBRa3bW4bZaqfFMyIgJ3J8VxAI T9lt9DOMGWhYd91pVsyN9BvwB8zeO9Hb1v+t84zMdOYjfpvaQi/z9Qh2HK6qxvT09x jPIezWB0NRmmX9hXSmEisfAX0odlMSqcX2+SaCWhsAP8s+30AQlSMl4yKZ4zjKRdFy 3TJTVTrcxXtvDACuvW/cHYtrqtsQS3atVZdXFoSgxgI2U2HK1Dnv4kJUWDfWrYvihS vY3Z7az0XmbrFGkwn2m0fypNpiapp6VZpE979iaS6NL52zYlST/5udwNHmwuWQArqh vooKMvJ2RTKQw== From: Marco Scardovi To: Corentin Chary , "Luke D . Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Scardovi Subject: [PATCH 3/3] platform/x86: asus-armoury: Prevent disabling dGPU when in use Date: Wed, 5 Aug 2026 20:28:08 +0200 Message-ID: <20260805183131.3075-4-scardracs@disroot.org> In-Reply-To: <20260805183131.3075-1-scardracs@disroot.org> References: <20260805183131.3075-1-scardracs@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Check ASUS_WMI_DEVID_DGPU_POWER_STATE before attempting to disable the discrete GPU in dgpu_disable_current_value_store(). Return -EBUSY if the dGPU is currently active and in use. Fixes: f99eb098090e ("platform/x86: asus-armoury: move existing tunings to = asus-armoury module") Suggested-by: Denis Benato Signed-off-by: Marco Scardovi --- drivers/platform/x86/asus-armoury.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asu= s-armoury.c index f745924af8a8..2d5ca75bc727 100644 --- a/drivers/platform/x86/asus-armoury.c +++ b/drivers/platform/x86/asus-armoury.c @@ -515,13 +515,25 @@ static ssize_t dgpu_disable_current_value_store(struc= t kobject *kobj, if (err) return err; =20 - if (asus_armoury.gpu_mux_dev_id) { - err =3D armoury_get_devstate(NULL, &result, asus_armoury.gpu_mux_dev_id); - if (err) - return err; - if (!result && disable) { - pr_warn("Cannot disable dGPU when the MUX is in dGPU mode\n"); - return -EBUSY; + if (disable) { + if (asus_armoury.gpu_mux_dev_id) { + err =3D armoury_get_devstate(NULL, &result, asus_armoury.gpu_mux_dev_id= ); + if (err) + return err; + if (!result) { + pr_warn("Cannot disable dGPU when the MUX is in dGPU mode\n"); + return -EBUSY; + } + } + + if (armoury_has_devstate(ASUS_WMI_DEVID_DGPU_POWER_STATE)) { + err =3D armoury_get_devstate(NULL, &result, ASUS_WMI_DEVID_DGPU_POWER_S= TATE); + if (err) + return err; + if (result) { + pr_warn("Cannot disable dGPU when it is in use\n"); + return -EBUSY; + } } } =20 --=20 2.55.0