From nobody Fri Oct 2 04:33:10 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FEC131A572 for ; Wed, 5 Aug 2026 12:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785933197; cv=none; b=lJobz7eiSFAAYlg3V5FKQJyGqe9TbYsvI4+YSmBicUDj+p5EdT7t98qNKdCMHEGGBabLs2QR33m7kV00H37vMlvGjJrpwNvCKD/ShGa2ii5EyHiNPwPYPuLcrD5c/13aNq/swk0EU1KFO7E0UnQ9QyPtUvF3rIq59WaUf+xSeeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785933197; c=relaxed/simple; bh=7xB8g3Iq2b2YwoKXH+QIeqhcQ8+NE37RjeD5rBHRwks=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iqQ+yI3dH2xM1TPodcN1XdgLzNIMmQ8uIvFB5JyOawZ7pIONflBb/eRicKj0T+E1vAO+wXxVbtVzVOuagYkw9lVHW5wEZ1p8Fa0FfLl6VoDp17Gq2Kwkp9ShR7tOUE4TPjfNG6sV2LNKnfyMtF2HGoLsF6SKlGX7wxVaNm02XlU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VJRGVlVD; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VJRGVlVD" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-47fe45db360so112740f8f.2 for ; Wed, 05 Aug 2026 05:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785933193; x=1786537993; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=87GixfRmkz4UiL/TsgmQVGo0Qsy/9UQMNwfCm4Wh3ko=; b=VJRGVlVD55Pa0VMkaSF5NDK3EDBrq4aJdOtxI4ndgl+Da3uDMNvbHmelf1fxBRm2Bz qFUSkNPSBMNOBNz3deV2YR3Gwxf/njFcI1HqXNY3pDKI/e0WHljMSJd0FUrdWtLkaCD+ xb5DeVYrVX5jpNTHVVrP4H9C4+u9kqNQTfqK/KZfgFx2pd7ER1tr/TLaTy+C2D1yK5j4 /eO5BUBcAQSl+SJs8ycpSgLEsHVUsHxugX7MfCe4ib59EDarh6syu5FO/gHm97N6cP8G HdORj5JmY5RjiQLnad5+bNfp/DPUDwKRmZKvU3SaYQhd+CI1TT9l5ejXrxmYmKd92OxC WrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933193; x=1786537993; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=87GixfRmkz4UiL/TsgmQVGo0Qsy/9UQMNwfCm4Wh3ko=; b=GIHcXAvl71J/P0TlupGJV4aBUKosJ6FvkkrG1ey08RfDZo9YAwGgFQKdc+4y/qEedh QfG+IQSXQWEo+bqM0lVtNXtuDh83h3VjPj5++fOI2Qx53+Gp7dIXa+Y9Khngg6+Xk7x2 2S8EHkTAVcw8sA5vq4/EQMb3iYw+YZ3xIt/9XB5blOPa4mwdPwnFKNGTu0oUZkXleUta Hp1FbbbMw4cpqkR2O/rT0JqPKzbVmy6skphSDPi0PFHsxWv68zZV0LO2KUMiwSZU+D/e voGN/C1vIVfl61dJe6cDWULm7+10y/bs8pNrRX/mCC4mf2eyOjLF2WG2HSSdGgbt3UfR UkgA== X-Forwarded-Encrypted: i=1; AHgh+RrqVKf1Qq/SVQ1CiO0xLLZJO50FwEm+J1k1ixHrcdgl3lKxWL1CebjzPpyJvtwPgFZjJs+xHCuLD1bxYVY=@vger.kernel.org X-Gm-Message-State: AOJu0YxvjnUOgsMPTt48F6pprvTm4UogTYpUXm1ebwTyvhWXudQV5A6q 9HZyLoc+eKL6igjJjqgFTrBkIQkoIzvrDf9oooZrCork2FN9sF/Ah5w8 X-Gm-Gg: AR+sD12sHwlWQ2MsCM/rRHucF01tYLh3ECuEb2x0hxkBcLbZ063Kd59nug60MmwiUEM nDkPqR5HYhUNK/XAeKVQlZtdoB8sMfyHVKOB+3RI42cB4GEVZA/v/bvdaNiobnl8piwPuLWJZXN n6dQojeusWsZL1mEuL0toD4cH7Y/MmdWorNx4dxL5fqDH70NpvUHgs02GZgspVJ0XoPAPXo3wa9 DS6lkSJtkYWu4QyJAV5j9hWEbIZPyUYxd/p6v3eXh8cKqzalqh2rc+emqwC9WSyHzQ1s4LKVGt6 42ZASa9Ql5rd6YUxb+8BJGRW2x52NQN+hxIq5VO14SgNZxcF7qUEd3tKhNgtMZ+7tQOfXvMQyHM LbDgmVJ3RT4zjav0aJsXudDo9gQXOeMuOsW0cfzLa9sMO4d+cpD5OrY0L4D/hWa/4KZfBnEix8i w6plm+qh1pApnLuKEbPDhOOYb9ey1hhIWl6WCQ4600GmnjDPnpGYo9Eq3X2bWaadHj3BjL7TPQE oXZ7D5tB68P0VGwyZGVl5WyZw37ozy/YGwUV5tCA9qaNibMXZfus4EUWbcx8FY9hjnWkMgNS/vf BYHbFpg25QiY+w== X-Received: by 2002:a05:600c:3b20:b0:492:4a7a:e415 with SMTP id 5b1f17b1804b1-4994e7c898bmr38003015e9.2.1785933192303; Wed, 05 Aug 2026 05:33:12 -0700 (PDT) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e03589asm75983315e9.9.2026.08.05.05.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 05:33:11 -0700 (PDT) From: Giorgi Tchankvetadze To: Jonathan Cameron Cc: Giorgi Tchankvetadze , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Takashi Sakamoto , Dixit Parmar , Keerthy , Samuel Ortiz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: adc: twl4030-madc: read MADC_CTRL1 from the correct module Date: Wed, 5 Aug 2026 16:31:59 +0400 Message-ID: <20260805123201.219547-2-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Giorgi Tchankvetadze twl4030_madc_set_power() does a read-modify-write on MADC_CTRL1 but reads it from TWL_MODULE_MAIN_CHARGE while writing it back to TWL4030_MODULE_MADC. Fix it by reading MADC_CTRL1 from TWL4030_MODULE_MADC so the read-modify-write operates on the register's actual contents. Fixes: f99c1d4f94f9 ("mfd: Add twl4030 madc driver") Signed-off-by: Giorgi Tchankvetadze Reviewed-by: Joshua Crofts --- drivers/iio/adc/twl4030-madc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c index 0ee7e16b5e24..1156e68ebd91 100644 --- a/drivers/iio/adc/twl4030-madc.c +++ b/drivers/iio/adc/twl4030-madc.c @@ -718,7 +718,7 @@ static int twl4030_madc_set_power(struct twl4030_madc_d= ata *madc, int on) u8 regval; int ret; =20 - ret =3D twl_i2c_read_u8(TWL_MODULE_MAIN_CHARGE, + ret =3D twl_i2c_read_u8(TWL4030_MODULE_MADC, ®val, TWL4030_MADC_CTRL1); if (ret) { dev_err(madc->dev, "unable to read madc ctrl1 reg 0x%X\n", --=20 2.52.0