From nobody Fri Oct 2 08:28:23 2026 Received: from mail-ot1-f98.google.com (mail-ot1-f98.google.com [209.85.210.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AEBC40097D for ; Wed, 5 Aug 2026 09:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785922912; cv=none; b=YjovnhG08iWVEVgyk+7+N9F+VFYkAnyTboYeuR1/YvBnuxL/PPhH3REOEXp56Q8BhsXkHNkBl4Nx7Dncc8eGL4mnUUvGSSRGXI1CTOKCBzeFr0SOiu1h2i54xes9jZkWjxV9qakozsMMGHdKivIhSF0Q7QzWhrx26CkDU0p6IY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785922912; c=relaxed/simple; bh=gKhD9uzcTs6ZkGqBbh/L1p5FfLiWUK43uRNvxA1pEfA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Kw1MY8jkVudo5wsRG/Xb3dnWnlANt7H/2klYs7VT3vrAlgP9wqWcQXiYb6fT0CaPKc4+WftffXeqDk4kDxIZpIVA3orhMXwJtAR4JfG+52EC5HCZfUR4rqLbsmhINf8r/cbFzVQMB7wxp2I7A3QRvkG3b12Ks5VT8Qa0Kwu00Yg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=OPFtnBT/; arc=none smtp.client-ip=209.85.210.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="OPFtnBT/" Received: by mail-ot1-f98.google.com with SMTP id 46e09a7af769-7eb6573bd52so585351a34.3 for ; Wed, 05 Aug 2026 02:41:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785922909; x=1786527709; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=qjJiLC9fkagfT2Fe4y8Vi9rY7+5d6Oe0cJwGKTVGzJY=; b=F257HE3ECWfBMPjGRnXeP1QwdMkotlaKKu3zmbTsaE4B2WqPolSru3+RQel1wJT5Yy Kwoc7nYSHxcwVKPZEY2bSCTR0WqxAxsoZ4rVG9cPC5KRZJvngBdzpOL8F5G1RY3ewHKK cHTOKJooUtST2ogKlvylf/lxjThyVHTHxSBOyPtnXKpz8wT4RWBB+yR3g2EuHhH8XSM3 PQ9gbeUMiAr5ROcpaopLrq+9/VbbrpIq9qw+9fxLhH1OPIemKJZ12Hhg9YENW0g91P4S sEOWFtdiHOgFfF8Nn6OdOy/VNceiXxA6r3OwJaRW7ulB+iqw4p0rI8jxhco+HomsDMLn PsxA== X-Forwarded-Encrypted: i=1; AHgh+RqozOqES7oS0ePhJzXmm4h6xhx3sfiwagRS9xirXEirN8AgSXoPKzmdEFBM9MtlsrsE8RApeYqyg2G6Iyk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyzkzsz1yYAOBfrqm1tw3KVrcQZFAJu2LmLDWcGjJ8bBHRaPy31 P5BTXAQuYylxj3+ROp3dKpMGL4FHPOl+hqPU5+h9sNflSGvlQSeeCHSb9HKexslqAlzhLBVi9Xa DWQSrhJN4TTX3BZdOyFVdP8AX4eCfDWBmilIQ1+m5Gslz105sq1P6A0zbCtBKAp3Om8UOnqXEAx jLHRrf6Z5F9rUuVFIz61tmRlbTi2uDYvI4cCbiMps2KLGhzNSNPAsY1ZiyYYz38b7QK2wgWwbSV VEU8z23j8MySD2vHJdcJUTY7g== X-Gm-Gg: AR+sD10xDkOygT2YNvxltdFoeMRaBr45by7t254dhv6xU/AqfRgUHoa5Igp3uPe9W92 7CQakKKFkHtHf7BbWgC0Rfvt3gLmWfj5WQgJ5o3m38m8Czl6HIOF9mk4oZzmgfQXJgW8bh5Sf2v F8RakCtFDtBjoe2jNOAa0doB4K3kFeCUew+FiNSnm4oIfZpSz1VV1tjYz2pYOkeGKCDb/RDgq9g 178/MbCm+W5cw30aXvlw6afHA8ClyQ+b3ztrpUDe8kh2Z/iLgegLmGbFi4PXYoyM9R/4QqEMjHc fIYuYf1JDQZYXbUll9kWHp/cPBn0GNbNQNak4XgwEae5pkfgU3L0qHsN/295in3weXVrVt18zMk PzJMzpN6eQrFfzD8UlIQ9p/p3Isei9t6xVJrT5EbPK3u7oyI3bi3uJm1BL5Ikcha+uloUA6JP7Z uvjrVZ24sF0DszqQygzc8TMZRBH6RBhtdsui2QuII7rA== X-Received: by 2002:a05:6830:680c:b0:7e6:eb9c:3781 with SMTP id 46e09a7af769-7f1e5e93b32mr3817632a34.12.1785922908865; Wed, 05 Aug 2026 02:41:48 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id 46e09a7af769-7f1df5d2725sm428568a34.7.2026.08.05.02.41.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Aug 2026 02:41:48 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e475f83a2so1264651a91.1 for ; Wed, 05 Aug 2026 02:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785922907; x=1786527707; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qjJiLC9fkagfT2Fe4y8Vi9rY7+5d6Oe0cJwGKTVGzJY=; b=OPFtnBT/dBTlbKL4vg29cqOvjEVgpJ/Ydz2hMmHhbuUsL3r+tmQNSu9Kc5iug2yryi awven/1zeES+pRTOH4rjhFWS6DR0MAfvFl97nMAtElLWh6yTn9gTaOWrSrsQGMuGyTkR LKnPEDufqgziHJ7jZKiRemfIM4qkb/JBJhSNc= X-Forwarded-Encrypted: i=1; AHgh+RqC9vVAFe2EJ7y7qd1nGwLsVbb7sQkbKvZRHP08rLdt2Q7G0FW9u8HERt4gUtLeE3lntPWeU5HdJPDl24U=@vger.kernel.org X-Received: by 2002:a17:90b:1e53:b0:38e:6d4c:14e6 with SMTP id 98e67ed59e1d1-3903c5501efmr4607408a91.3.1785922906957; Wed, 05 Aug 2026 02:41:46 -0700 (PDT) X-Received: by 2002:a17:90b:1e53:b0:38e:6d4c:14e6 with SMTP id 98e67ed59e1d1-3903c5501efmr4607359a91.3.1785922906445; Wed, 05 Aug 2026 02:41:46 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fca92ada6sm12358662c88.15.2026.08.05.02.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 02:41:45 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Dharmender Garg , Rajashekar Hudumula Subject: [PATCH net] bnge: Fix resource leak in bnge_init_nic() error path Date: Wed, 5 Aug 2026 15:10:22 +0530 Message-ID: <20260805094022.15487-1-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" If bnge_init_chip() fails, bnge_init_nic() jumps to err_free_ring_grps and returns immediately, skipping cleanup for RX ring pair buffers. Remove the early return so execution falls through to err_free_rx_ring_pair_bufs to properly free resources on error. Fixes: 23df6aebf803 ("bng_en: Allocate stat contexts") Signed-off-by: Bhargava Marreddy Reviewed-by: Dharmender Garg Reviewed-by: Rajashekar Hudumula --- drivers/net/ethernet/broadcom/bnge/bnge_netdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index c2e865f8d9c..a4288f0258f 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2820,8 +2820,6 @@ static int bnge_init_nic(struct bnge_net *bn) =20 err_free_ring_grps: bnge_free_ring_grps(bn); - return rc; - err_free_rx_ring_pair_bufs: bnge_free_rx_ring_pair_bufs(bn); return rc; --=20 2.47.3