From nobody Fri Oct 2 03:56:30 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6EF3E51C5 for ; Wed, 5 Aug 2026 07:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785915368; cv=none; b=PMQJZil5mqbKJanFuBhFH4pqAvflmGSIkLQMBCgsIbSez2B6v8pragpQC3mULl/5+RmXYISEGWh4vGQh6c4D+lIpavEvbUJOg4At6yrDlpXvq4ejBPwBTHJfBuPj6aRvCBcovkASIeXF3VZ+cyLeJBhLskuSSZGhzLF7voot4Nc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785915368; c=relaxed/simple; bh=z7jxl+e8jm06YnFJ7ulXVe01RvsrUZ9KccYhJgKrkFo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=neb4NnEFUQGkHHfm4b6xMk8TIUlWqC2/WhievQgj8qKir9bczm3+FnL4/0t7xN8lo7XE1/zToVrQnoGWedWST5egMJTJZXdt63pYJudXTw0AO8bmIfQ45kiX+3B0sPxKkRFQQSiwmjmMvTC/F9xgP/HGOsyP8+VTePu+E0zW5JA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=l/eU8euy; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="l/eU8euy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=qj 5zTRFYCHrbHIr5mSW+KX7DKQUhqYyAxwN+L12YP6M=; b=l/eU8euyk1d+ifnEuc 3L4QdUwkTabWrFwhJcHKMOqvy/wiXpAJqSPZwqfi9/cY1rrZSurO3VXMMm8JzQ+D hJ+4iu2d3PWOBbtCvzCoT+AB0oDWnzrezksL8Eqr/qH05vGQyGBgPbFXR4yQ8OnU PoWylrgTCyHIUt2Mom0IW+2Kk= Received: from liubaolin-ThinkPad-E15-Gen-2 (unknown []) by gzsmtp4 (Coremail) with SMTP id PygvCgD3fyzL53JqTdA7Kw--.16788S2; Wed, 05 Aug 2026 15:35:41 +0800 (CST) From: Baolin Liu To: almaz.alexandrovich@paragon-software.com Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, liubaolin12138@gmail.com, Baolin Liu Subject: [PATCH] fs/ntfs3: check wnd_set_used() in ntfs_look_free_mft() Date: Wed, 5 Aug 2026 15:35:37 +0800 Message-ID: <20260805073537.2044570-1-liubaolin12138@163.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PygvCgD3fyzL53JqTdA7Kw--.16788S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF1xJw1rtFy5Cry8Jw4xZwb_yoWkuFX_Ja 4xC3WfA345AFnI9aykWrWa9rW7X3y8twn8Wayxta4SkrWDu3Z8AFZ5Aw45tFW8W3yUJa4r A3srGrWrJr1ayjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbg_-tUUUUU== X-CM-SenderInfo: xolxutxrol0iasrtmqqrwthudrp/xtbCwQ5kL2py586-3QAA3X Content-Type: text/plain; charset="utf-8" From: Baolin Liu wnd_set_used() can fail, but ntfs_look_free_mft() ignored the error and could return success after leaving the MFT bitmap unmarked. Check the return value and unwind the new subrecord on failure. Signed-off-by: Baolin Liu --- fs/ntfs3/fsntfs.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c index d0434756029b..ab9e03156cce 100644 --- a/fs/ntfs3/fsntfs.c +++ b/fs/ntfs3/fsntfs.c @@ -741,10 +741,19 @@ int ntfs_look_free_mft(struct ntfs_sb_info *sbi, CLST= *rno, bool mft, } =20 /* We have found a record that are not reserved for next MFT. */ - if (*rno >=3D MFT_REC_FREE) - wnd_set_used(wnd, *rno, 1); - else if (*rno >=3D MFT_REC_RESERVED && sbi->mft.reserved_bitmap_inited) + if (*rno >=3D MFT_REC_FREE) { + err =3D wnd_set_used(wnd, *rno, 1); + if (err) { + if (ni) { + ni_remove_mi(ni, *mi); + mi_put(*mi); + *mi =3D NULL; + } + goto out; + } + } else if (*rno >=3D MFT_REC_RESERVED && sbi->mft.reserved_bitmap_inited)= { __set_bit(*rno - MFT_REC_RESERVED, &sbi->mft.reserved_bitmap); + } =20 out: if (!mft) --=20 2.51.0