From nobody Fri Oct 2 05:32:02 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A1E1349CD1 for ; Wed, 5 Aug 2026 01:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785894042; cv=none; b=c6bmvm4Yhe+8oleZpdSbR/htIdjc8dEVTwGLjPbZVNajbRWKumOMt99HLKqw2bVLS0jV1TrwjrqetOawaPCSPK6g/fnpqaK2ayuiyzQylLWikKbUPklmQp0/HbNQQ3UUOLexlytyxtXT6q0A+kGeCosTPdoxz0rIhkQ09j6P9PQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785894042; c=relaxed/simple; bh=K1ifCEZgy2vf7g1KjYV2bqP1kJwiiG3EFKfMlDYCJF8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NzZwupx5yHtmVeh0gURiYnQaoaexDU0QPgWaOdncQKEQIxWnlURf4+pvAkA48b7avXEBPWwuNuslaXpwLL+fnKixpKaQ77Bu7fJB846EpJfdrJ6AllNtuW9CVd6VUOtelIS6pstoeg6lTTe6ufTMiyjzDyHlGH3aMROGWVxQA58= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: a5c7c206906e11f1aa26b74ffac11d73-20260805 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:1f2c7576-33ad-4d24-a8ec-c6c33668a728,IP:0,U RL:0,TC:0,Content:-5,EDM:-20,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-25 X-CID-META: VersionHash:e7bac3a,CLOUDID:6b1a6476745786bdfe51569937b46ee3,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|865|898,TC:nil,Content:0|15|50,E DM:1,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA: 0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: a5c7c206906e11f1aa26b74ffac11d73-20260805 X-User: fangqiurong@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1342068696; Wed, 05 Aug 2026 09:40:32 +0800 From: fangqiurong To: Ingo Molnar , Peter Zijlstra Cc: Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , linux-kernel@vger.kernel.org, fangqiurong Subject: [PATCH] sched/fair: Remove dead throttled check in pick_task_fair() Date: Wed, 5 Aug 2026 09:39:49 +0800 Message-Id: <20260805013949.151089-1-fangqiurong@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit f666241e6bd5 ("sched/fair: Unify cfs_rq throttling via account_cfs_rq_runtime()") removed the only assignment to @throttled in the pick_task_fair() walk loop, making the variable and the trailing task_throttle_setup_work() call dead code. Drop them. No functional change. Assisted-by: Z.ai:glm-5.2 Signed-off-by: fangqiurong --- kernel/sched/fair.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index bee6050a8f3a..967986212b43 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9941,7 +9941,6 @@ struct task_struct *pick_task_fair(struct rq *rq, str= uct rq_flags *rf) struct sched_entity *se; struct cfs_rq *cfs_rq; struct task_struct *p; - bool throttled; int new_tasks; =20 again: @@ -9949,8 +9948,6 @@ struct task_struct *pick_task_fair(struct rq *rq, str= uct rq_flags *rf) if (!cfs_rq->nr_queued) goto idle; =20 - throttled =3D false; - do { /* Might not have done put_prev_entity() */ if (cfs_rq->curr && cfs_rq->curr->on_rq) @@ -9963,8 +9960,6 @@ struct task_struct *pick_task_fair(struct rq *rq, str= uct rq_flags *rf) } while (cfs_rq); =20 p =3D task_of(se); - if (unlikely(throttled)) - task_throttle_setup_work(p); return p; =20 idle: --=20 2.43.0