From nobody Tue Aug 25 03:43:32 2026 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E5F3D3CE3 for ; Wed, 5 Aug 2026 18:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954218; cv=none; b=bfQVu23C38qePcl410qZMea1oHCG6H4qTG6Nz9PZTdEw2PiSItqdeHgyPZnlyOIJ3cyGZ924oPxqboKf1G2YNU6jOrjt7FGpGk84tzbzunDgrliLulOZWG1XXQL+9nleoWxvrioqtDyZuq7ENRswuV6Cdy5+zktuGSwhDAUi8ho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954218; c=relaxed/simple; bh=G+WX7CtesiRe4DTj7Tlv8U8LdjJ4Jmxn7ClKoT6FFH4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G2A4Xkl+I8ysTntr8AWDeP/bhbU3CDxotRnifM4F5D7jSV/Tb9hD93Uuu8D8Su2dU7EMeFxTCEYWClSkQL8SBk+7Uj8YdFUhFKPu6y2/8SsHnkGKws1gKomYepGzi4OG3MhmyzNCqE6rePTjTC9YRrXpdRE490R7Cet5bdXqaHI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lqc5ulDr; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lqc5ulDr" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5aeb8c19017so1764268e87.0 for ; Wed, 05 Aug 2026 11:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785954213; x=1786559013; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=THhDdldiuemutk8N2Fd3TSyJfgkNcZYGTnH4JKvIOFs=; b=lqc5ulDrEN3q8DrtU8nKYIUPSgwemzriDsJaU2b3vLoVgY0SvgJMabk1bccb2JK0h9 12WtT6Hra4JN2+B7tEbX9r4X0MTW6tQlefLRDu/IkH2YxrvZiO2eNeLY4Bv9ZdJN5eQl rIm8ThRHe0qrw+1DRWWtJCuLfRCw1eYcCdChNSSft2fbAWjREWhzWf1bT76V5K/FY77r mCJs68usHV7fPg1OdinTgtlRCXL5yUfLWE23WKtOmLlAm36gxXAnqAPo8F6tPzc4qVH0 DjKgQK8Mu72Co5mFyiY3gtugq5vkXHpRt6j9fGJ3ydFOKgN3HB/IVr9VvbfPN/NTFyoi FoRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785954213; x=1786559013; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=THhDdldiuemutk8N2Fd3TSyJfgkNcZYGTnH4JKvIOFs=; b=EOoQE/wtUAXz7PSOkKoWC2VZj/udR5HdHROf7CLdfBgjRKdwCRUmlrusTY2BpVCuLu 3I40EfvMxE2y3A0XUTkStdNovD8LboVAaKJtFL5uqWUdf9H2+ADqTazeTr43MjDr1fnz GWNjbntgfjtFec+giIU5+tCqkUh7+J/EvoaLrFf2zZQAAUWqduGa0p0/rLGSX29wbk1a CO+TUmSFnEss308hscVwEDF39SVEXzpMy36P3DOdEKWPo1eUdlUGFaoLK8rhJJ50lAdF z02Pj94dWK8jK7PuotqojG8NQU6MG8FolUM+wu/TUjBdde6AJUVx3HPCkCCZ5DPzgQV6 4m3w== X-Gm-Message-State: AOJu0YzkHFv6Io9SWbeeyqHBRz8DZIJziLXWtjQWCmZwa3/Bi+03zIBL 2OUK+k0Zh9rog4aiNcuj3j8mNQeBjz1V18JKfCBIXp6RFWqP1lmb1kan X-Gm-Gg: AR+sD10QrDeh1xv+AHdeHi7O8uc2fOSXClEGFvwBMJruT89pDJ4MRebjAU1+Ag2NWfz +5gHpFcMOsMEKe2o2hrPVqRgR3svNKTVFFj+ibWyHKVYmuHs0K7S4V+uj48B5kc8n4JImBVUjee ZLO6QkiVnUfQoWnyYkzKU+vlv2stvCCI05W15HSYm5EXuBnXENRIpkL66NdnEXQQbRUI+498A+3 5Tahs1eJvHO65h8cPV/wkni85Tt+On+rrICuxtnO+lNsh1mElxkFtX3f9+TLR79AoEDJEHUD/95 PNnasYPElGZAnJ8WLDeL5PHaD3ITvW9uo1QhU/2X/UaaINcc7cQ+KRxL3i0WwVxMwhAoMmuUzuo Lmr/E8MQz26WZOGms3Uj5HYy8UypOTgErrMW0ky9bN9vCRXKoADeASaOemFXAb6MdGsJ2LgizTi 1jJChb+vwUSzCwMdAI55017kH/1iXKVnZB0nfGYDfRk4xx/moQ+K6UvdU9A713kLMm0eF3Mg== X-Received: by 2002:a05:6512:1319:b0:5ae:c48a:1dc6 with SMTP id 2adb3069b0e04-5b2f4cd8c72mr1344590e87.48.1785954213255; Wed, 05 Aug 2026 11:23:33 -0700 (PDT) Received: from [192.168.243.250] ([94.229.19.199]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fb9a32bb7sm11954811fa.29.2026.08.05.11.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 11:23:32 -0700 (PDT) From: Nikolay Kulikov Date: Wed, 05 Aug 2026 21:23:05 +0300 Subject: [PATCH 1/4] staging: media: ipu7: remove unused structures from abi/ headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260805-ipu7_abi-v1-1-46d420cef267@gmail.com> References: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> In-Reply-To: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> To: Sakari Ailus , Bingbu Cao , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Nikolay Kulikov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785954209; l=10885; i=nikolayof23@gmail.com; s=20260402; h=from:subject:message-id; bh=G+WX7CtesiRe4DTj7Tlv8U8LdjJ4Jmxn7ClKoT6FFH4=; b=Hr/abx6q0S1pDt+qFpYox79lkubPlGIwPHz+89Mf8LJjwJNAD7P0yz2smvOgvFFEb/Fx/oQl5 3/AKH8CExErB486zPFLqUSoLz3d4jLmfXnNWchIsrE7CGMByG0LhNiP X-Developer-Key: i=nikolayof23@gmail.com; a=ed25519; pk=2GWUU1isl5NJpkwSCQ4OG80EinZ3EUZXlrgAg6Pz5zI= Remove the declarations of these structures, as they are not used in the driver code. Remove the abi/ipu7_fw_psys_config_abi.h file because it contains nothing but an unused structure and is not included anywhere. Signed-off-by: Nikolay Kulikov --- drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h | 11 -- .../staging/media/ipu7/abi/ipu7_fw_common_abi.h | 37 ----- drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h | 4 - drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h | 172 -----------------= ---- .../media/ipu7/abi/ipu7_fw_psys_config_abi.h | 24 --- 5 files changed, 248 deletions(-) diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h b/drivers/st= aging/media/ipu7/abi/ipu7_fw_boot_abi.h index 56b90aab83ea..8d5c9b06d158 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h @@ -91,17 +91,6 @@ struct ia_gofo_boot_config { struct syscom_config_s syscom_context_config; }; =20 -struct ia_gofo_secondary_boot_config { - u32 length; - struct ia_gofo_version_s config_version; - struct ia_gofo_msg_version_list client_version_support; - u8 reserved1[IA_GOFO_BOOT_SECONDARY_RESERVED_FIELDS]; - u16 checksum; - u8 padding[2]; - u32 reserved2[IA_GOFO_BOOT_SECONDARY_RESERVED_SIZE]; - struct syscom_config_s syscom_context_config; -}; - #pragma pack(pop) =20 #define IA_GOFO_WDT_TIMEOUT_ERR 0xdead0401 diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h b/drivers/= staging/media/ipu7/abi/ipu7_fw_common_abi.h index 398a13350480..c50b355b04d8 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h @@ -41,16 +41,6 @@ struct ia_gofo_msg_version_list { =20 #define IA_GOFO_ABI_BITS_PER_BYTE (8U) =20 -struct ia_gofo_tlv_header { - u16 tlv_type; - u16 tlv_len32; -}; - -struct ia_gofo_tlv_list { - u16 num_elems; - u16 head_offset; -}; - #define TLV_ITEM_ALIGNMENT ((u32)sizeof(u32)) #define TLV_MSG_ALIGNMENT ((u32)sizeof(u64)) #define TLV_LIST_ALIGNMENT TLV_ITEM_ALIGNMENT @@ -97,22 +87,6 @@ enum ia_gofo_msg_err_general { #define IA_GOFO_MSG_TYPE_LOG 2 #define IA_GOFO_MSG_TYPE_GENERAL_ERR 3 =20 -struct ia_gofo_msg_header { - struct ia_gofo_tlv_header tlv_header; - struct ia_gofo_tlv_list msg_options; - u64 user_token; -}; - -struct ia_gofo_msg_header_ack { - struct ia_gofo_msg_header header; - struct ia_gofo_msg_err err; - -}; - -struct ia_gofo_msg_general_err { - struct ia_gofo_msg_header_ack header; -}; - #pragma pack(pop) =20 #pragma pack(push, 1) @@ -132,12 +106,6 @@ enum ia_gofo_soc_pbk_instance_id { =20 #define IA_GOFO_MSG_LINK_PBK_MAX_SLOTS (2U) =20 -struct ia_gofo_msg_indirect { - struct ia_gofo_msg_header header; - struct ia_gofo_tlv_header ref_header; - ia_gofo_addr_t ref_msg_ptr; -}; - #pragma pack(pop) =20 #pragma pack(push, 1) @@ -161,11 +129,6 @@ struct ia_gofo_msg_log_info_ts { struct ia_gofo_msg_log_info log_info; }; =20 -struct ia_gofo_msg_log { - struct ia_gofo_msg_header header; - struct ia_gofo_msg_log_info_ts log_info_ts; -}; - #pragma pack(pop) =20 #define IA_GOFO_MSG_ABI_OUT_ACK_QUEUE_ID (0U) diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h b/drivers/st= aging/media/ipu7/abi/ipu7_fw_isys_abi.h index c42d0b7a2627..87bf2bd5576c 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h @@ -315,10 +315,6 @@ struct ipu7_insys_resp { u8 pad[2]; }; =20 -struct ipu7_insys_resp_queue_token { - struct ipu7_insys_resp resp_info; -}; - struct ipu7_insys_send_queue_token { u64 buf_handle; ia_gofo_addr_t addr; diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h b/drivers/sta= ging/media/ipu7/abi/ipu7_fw_msg_abi.h index 311248385993..1d0541b1ae9d 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h @@ -55,18 +55,6 @@ enum ipu7_msg_node_profile_type { IPU_MSG_NODE_PROFILE_TYPE_N }; =20 -struct ipu7_msg_node_profile { - struct ia_gofo_tlv_header tlv_header; - ipu7_msg_teb_t teb; -}; - -struct ipu7_msg_cb_profile { - struct ipu7_msg_node_profile profile_base; - ipu7_msg_deb_t deb; - ipu7_msg_rbm_t rbm; - ipu7_msg_rbm_t reb; -}; - #define IPU_MSG_NODE_MAX_PROFILES (2U) #define IPU_MSG_NODE_DEF_PROFILE_IDX (0U) #define IPU_MSG_NODE_RSRC_ID_EXT_IP (0xff) @@ -75,17 +63,6 @@ struct ipu7_msg_cb_profile { #define IPU_MSG_NODE_DONT_CARE_TEB_LO (0xffffffff) #define IPU_MSG_NODE_RSRC_ID_IS (0xfe) =20 -struct ipu7_msg_node { - struct ia_gofo_tlv_header tlv_header; - u8 node_rsrc_id; - u8 node_ctx_id; - u8 num_frags; - u8 reserved[1]; - struct ia_gofo_tlv_list profiles_list; - struct ia_gofo_tlv_list terms_list; - struct ia_gofo_tlv_list node_options; -}; - enum ipu7_msg_node_option_types { IPU_MSG_NODE_OPTION_TYPES_PADDING =3D 0, IPU_MSG_NODE_OPTION_TYPES_N @@ -118,62 +95,16 @@ enum ipu7_msg_link_cmprs_option_bit_depth { #define IPU_MSG_LINK_CMPRS_SPACE_SAVING_NUM_MAX \ (IPU_MSG_LINK_CMPRS_SPACE_SAVING_DENOM - 1U) =20 -struct ipu7_msg_link_cmprs_plane_desc { - u8 plane_enable; - u8 cmprs_enable; - u8 encoder_plane_id; - u8 decoder_plane_id; - u8 cmprs_is_lossy; - u8 cmprs_is_footprint; - u8 bit_depth; - u8 space_saving_numerator; - u32 pixels_offset; - u32 ts_offset; - u32 tile_row_to_tile_row_stride; - u32 rows_of_tiles; - u32 lossy_cfg[IPU_MSG_LINK_CMPRS_LOSSY_CFG_PAYLOAD_SIZE]; -}; - #define IPU_MSG_LINK_CMPRS_MAX_PLANES (2U) #define IPU_MSG_LINK_CMPRS_NO_ALIGN_INTERVAL (0U) #define IPU_MSG_LINK_CMPRS_MIN_ALIGN_INTERVAL (16U) #define IPU_MSG_LINK_CMPRS_MAX_ALIGN_INTERVAL (1024U) -struct ipu7_msg_link_cmprs_option { - struct ia_gofo_tlv_header header; - u32 cmprs_buf_size; - u16 align_interval; - u8 reserved[2]; - struct ipu7_msg_link_cmprs_plane_desc plane_descs[2]; -}; - -struct ipu7_msg_link_ep { - u8 node_ctx_id; - u8 term_id; -}; - -struct ipu7_msg_link_ep_pair { - struct ipu7_msg_link_ep ep_src; - struct ipu7_msg_link_ep ep_dst; -}; - #define IPU_MSG_LINK_FOREIGN_KEY_NONE (65535U) #define IPU_MSG_LINK_FOREIGN_KEY_MAX (64U) #define IPU_MSG_LINK_PBK_ID_DONT_CARE (255U) #define IPU_MSG_LINK_PBK_SLOT_ID_DONT_CARE (255U) #define IPU_MSG_LINK_TERM_ID_DONT_CARE (0xff) =20 -struct ipu7_msg_link { - struct ia_gofo_tlv_header tlv_header; - struct ipu7_msg_link_ep_pair endpoints; - u16 foreign_key; - u8 streaming_mode; - u8 pbk_id; - u8 pbk_slot_id; - u8 delayed_link; - u8 reserved[2]; - struct ia_gofo_tlv_list link_options; -}; - #pragma pack(pop) =20 enum ipu7_msg_dev_state { @@ -208,30 +139,6 @@ enum ipu7_msg_err_groups { }; =20 #pragma pack(push, 1) -struct ipu7_msg_task { - struct ia_gofo_msg_header header; - u8 graph_id; - u8 profile_idx; - u8 node_ctx_id; - u8 frame_id; - u8 frag_id; - u8 req_done_msg; - u8 req_done_irq; - u8 reserved[1]; - ipu7_msg_teb_t payload_reuse_bm; - ia_gofo_addr_t term_buffers[IPU_MSG_MAX_NODE_TERMS]; -}; - -struct ipu7_msg_task_done { - struct ia_gofo_msg_header_ack header; - u8 graph_id; - u8 frame_id; - u8 node_ctx_id; - u8 profile_idx; - u8 frag_id; - u8 reserved[3]; -}; - enum ipu7_msg_err_task { IPU_MSG_ERR_TASK_OK =3D IA_GOFO_MSG_ERR_OK, IPU_MSG_ERR_TASK_GRAPH_ID =3D 1, @@ -262,33 +169,11 @@ enum ipu7_msg_term_type { #define IPU_MSG_TERM_EVENT_TYPE_PROGRESS 1U #define IPU_MSG_TERM_EVENT_TYPE_N (IPU_MSG_TERM_EVENT_TYPE_PROGRESS + 1U) =20 -struct ipu7_msg_term { - struct ia_gofo_tlv_header tlv_header; - u8 term_id; - u8 event_req_bm; - u8 reserved[2]; - u32 payload_size; - struct ia_gofo_tlv_list term_options; -}; - enum ipu7_msg_term_option_types { IPU_MSG_TERM_OPTION_TYPES_PADDING =3D 0, IPU_MSG_TERM_OPTION_TYPES_N }; =20 -struct ipu7_msg_term_event { - struct ia_gofo_msg_header header; - u8 graph_id; - u8 frame_id; - u8 node_ctx_id; - u8 profile_idx; - u8 frag_id; - u8 term_id; - u8 event_type; - u8 reserved[1]; - u64 event_ts; -}; - #pragma pack(pop) =20 #pragma pack(push, 1) @@ -301,28 +186,6 @@ struct ipu7_msg_term_event { #define IPU_MSG_DEVICE_CLOSE_SEND_RESP BIT(0) #define IPU_MSG_DEVICE_CLOSE_SEND_IRQ BIT(1) =20 -struct ipu7_msg_dev_open { - struct ia_gofo_msg_header header; - u32 max_graphs; - u8 dev_msg_map; - u8 enable_power_gating; - u8 reserved[2]; -}; - -struct ipu7_msg_dev_open_ack { - struct ia_gofo_msg_header_ack header; -}; - -struct ipu7_msg_dev_close { - struct ia_gofo_msg_header header; - u8 dev_msg_map; - u8 reserved[7]; -}; - -struct ipu7_msg_dev_close_ack { - struct ia_gofo_msg_header_ack header; -}; - enum ipu7_msg_err_device { IPU_MSG_ERR_DEVICE_OK =3D IA_GOFO_MSG_ERR_OK, IPU_MSG_ERR_DEVICE_MAX_GRAPHS =3D 1, @@ -343,47 +206,12 @@ enum ipu7_msg_err_device { #define IPU_MSG_GRAPH_CLOSE_SEND_RESP BIT(0) #define IPU_MSG_GRAPH_CLOSE_SEND_IRQ BIT(1) =20 -struct ipu7_msg_graph_open { - struct ia_gofo_msg_header header; - struct ia_gofo_tlv_list nodes; - struct ia_gofo_tlv_list links; - u8 graph_id; - u8 graph_msg_map; - u8 reserved[6]; -}; - enum ipu7_msg_graph_ack_option_types { IPU_MSG_GRAPH_ACK_OPTION_TYPES_PADDING =3D 0, IPU_MSG_GRAPH_ACK_TASK_Q_INFO, IPU_MSG_GRAPH_ACK_OPTION_TYPES_N }; =20 -struct ipu7_msg_graph_open_ack_task_q_info { - struct ia_gofo_tlv_header header; - u8 node_ctx_id; - u8 q_id; - u8 reserved[2]; -}; - -struct ipu7_msg_graph_open_ack { - struct ia_gofo_msg_header_ack header; - u8 graph_id; - u8 reserved[7]; -}; - -struct ipu7_msg_graph_close { - struct ia_gofo_msg_header header; - u8 graph_id; - u8 graph_msg_map; - u8 reserved[6]; -}; - -struct ipu7_msg_graph_close_ack { - struct ia_gofo_msg_header_ack header; - u8 graph_id; - u8 reserved[7]; -}; - enum ipu7_msg_err_graph { IPU_MSG_ERR_GRAPH_OK =3D IA_GOFO_MSG_ERR_OK, IPU_MSG_ERR_GRAPH_GRAPH_STATE =3D 1, diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_psys_config_abi.h b/dri= vers/staging/media/ipu7/abi/ipu7_fw_psys_config_abi.h deleted file mode 100644 index 0af04c8c6a88..000000000000 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_psys_config_abi.h +++ /dev/null @@ -1,24 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * Copyright (C) 2020 - 2025 Intel Corporation - */ - -#ifndef IPU7_PSYS_CONFIG_ABI_H_INCLUDED__ -#define IPU7_PSYS_CONFIG_ABI_H_INCLUDED__ - -#include - -#include "ipu7_fw_boot_abi.h" -#include "ipu7_fw_config_abi.h" - -struct ipu7_psys_config { - u32 use_debug_manifest; - u32 timeout_val_ms; - u32 compression_support_enabled; - struct ia_gofo_logger_config logger_config; - struct ipu7_wdt_abi wdt_config; - u8 ipu_psys_debug_bitmask; - u8 padding[3]; -}; - -#endif --=20 2.55.0 From nobody Tue Aug 25 03:43:32 2026 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5973D3D19 for ; Wed, 5 Aug 2026 18:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954220; cv=none; b=G4wv2Pkmr6hA3x5cf78tdCUxxsqPSLtlSNBUv/FEnMg+aYqXbNPIkxO5nPyyi4bWW/5MZGPWwStEPB0iWuJNlS630RgfjpGl9SXmny0zjkpw60FI4jwyzQ/ChSyLQ+eZciOwFnG8+yoXe10gBUySQ4ScWVX3kM5Ml0Rvu+KSFL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954220; c=relaxed/simple; bh=DFov8f1K1EbEd9BCm8EY+BJjRY5CMVbevtL+vTctO0g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bBuMs7KkxO4CA/8tKuhPqLH2LM+Ex2saEQFQFeCCrlBKvgR7jmftA9GK/VZBWUkAU/LcXonNAWgtU2ud0V+iTnA6CIWnTuTVNat1iVrpABO7qo3pfgrUCLy0PR1FydL+vLnt5N+HIOSkPE4ppHwWnT4zlLQoczW+6eV2feMdX3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l1GXL47s; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l1GXL47s" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-39faa67fabaso9650201fa.3 for ; Wed, 05 Aug 2026 11:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785954215; x=1786559015; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=D3mew32AtlJj3/s2JKE+RBW/bETbC6CThl0+JdvO3NM=; b=l1GXL47s/DHeOURfG2K/7PIMz6SCcGE4nLh2jHesudeObbq4TFL6yQWYB2rpo5k2nw Xp4/qHIAaZZrgg6k4XY/LCQ/WQvai4ZvebTaezsWSeRZ426FiXPME3CCRQRzlCVgAMO9 tHlFhiL3ehcQahIFWV0SRA5nTjKx4DEO0aP0v9+PwVXcM8wVNRyuRyk2smN2KSyH3yhv +CAwk1eJhJ7mLgygwpVdXyvcunAEsXL7UALtB7WNAZPZjGd3h3Bz0008HEGh2v7Y7RLi vUF0KyI2Y/N3EA+IyJztk7/E93b9nM99PuTMHl00TZInaTvzfqs8OLsfQM3UF/nal+w3 pTqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785954215; x=1786559015; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=D3mew32AtlJj3/s2JKE+RBW/bETbC6CThl0+JdvO3NM=; b=nj/iJeq+8Gnwz8pYg4quJ+KcpYHdaZ7IuxTpQFRY0nKiF9arEvKyo3N4KcBp3I3GT8 DInV9l/H6dUHMtwoN/t+BZ5P0JBIB+061vKv/qF1iWMsFq3RLROcY0FCy5ng2QiCEpiv vXUH/6jYBzwoUDzzPU+s5vWOCbHARMT1eFo+GrEFfXasYFqz7EH2obhkaev13Ds5g0Vl b2i9HAaHcGMcf7gc7+RHeTOo8a+jGFsE7+FD0yhHKAdQdAmBn/4VGb6OeGNQ4t6nhl3p PzXl3Kj4hh+PK9vMCcF1zeeiSuImInd0EsIu0KzqAk4RsMp1ydR/jZcuXrqrYgAsfjCh Zw5A== X-Gm-Message-State: AOJu0YwSRK9p0qXVexhrAuhRsbHp3TqicSx4r5b1hxX3bktiz/1QVx13 xANwucwD3NExt7jmTRp9F0RyfxuDf0ruX3M7xgPbsmkt4EygFLClVdGhkHvuDg== X-Gm-Gg: AR+sD12Na4Lyt0aFzdkcTOmIWlIY0B/Sy2GEDntAVVC4hiAnRazfsS9fv6SKo8h+6tU r+wTCng0J5Uoy78BSV10B8Pm1jgsC8tHew1n/EVJ+An15FRsY/BvtA66FTjDkhw7lOQkYTftKDl IZZlxx0GqZwyCIByQAa8fpXST1t+Tu+XE42Z6FkA65M6qoEFULJh5jC88Hz2j47qV3wJpKMJVmd N+mPT5GfHhwQJcuXFbRKDVRo5vub/QVfz4W1uZc0z0JNMGATuL3dWXIrvN0Bfm9635BzYxecl5f NR9jkrKeptOZ+KO/olgSMviU5yAlcRe/QSYqCUKtPE3hbBAEA1gufNEtRYWlyn1M7iVdIGPhSji WNCt7VGB1pwgC0uiNwvAYa+CbJjhLj8dclsWhS1m3fi+f5No2Sjd/zA63D34bku7PspmlD0YyQy xmwKFnZGzfY8CZkCdsTXYQhtIUhcxK19s9igrKjr13YWWclR2e9i8BFZhZmqlxnQhIPdLmJQ== X-Received: by 2002:a05:651c:a385:10b0:39d:ba1e:aaf4 with SMTP id 38308e7fff4ca-39fbb295ff9mr8603911fa.24.1785954215019; Wed, 05 Aug 2026 11:23:35 -0700 (PDT) Received: from [192.168.243.250] ([94.229.19.199]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fb9a32bb7sm11954811fa.29.2026.08.05.11.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 11:23:34 -0700 (PDT) From: Nikolay Kulikov Date: Wed, 05 Aug 2026 21:23:06 +0300 Subject: [PATCH 2/4] staging: media: ipu7: remove unused abi/ macros Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260805-ipu7_abi-v1-2-46d420cef267@gmail.com> References: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> In-Reply-To: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> To: Sakari Ailus , Bingbu Cao , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Nikolay Kulikov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785954209; l=14147; i=nikolayof23@gmail.com; s=20260402; h=from:subject:message-id; bh=DFov8f1K1EbEd9BCm8EY+BJjRY5CMVbevtL+vTctO0g=; b=fCEz3uVaIAL6RvwFSCGGLTIJaFwJQDvtGgFhqwJ2I1ctoRgf7dyI9y9FpGRYnxSxMUBRRmlwX JcPXPa0g56RAw6eexQH/ZgWq9HQnl2siPq9wIxr7hhWYgatoCYBAqKM X-Developer-Key: i=nikolayof23@gmail.com; a=ed25519; pk=2GWUU1isl5NJpkwSCQ4OG80EinZ3EUZXlrgAg6Pz5zI= These macros are defined but never used, so remove them. Signed-off-by: Nikolay Kulikov --- drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h | 31 ------------ .../staging/media/ipu7/abi/ipu7_fw_common_abi.h | 28 ---------- .../staging/media/ipu7/abi/ipu7_fw_config_abi.h | 3 -- drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h | 29 ----------- drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h | 59 ------------------= ---- .../staging/media/ipu7/abi/ipu7_fw_syscom_abi.h | 1 - 6 files changed, 151 deletions(-) diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h b/drivers/st= aging/media/ipu7/abi/ipu7_fw_boot_abi.h index 8d5c9b06d158..00c04ee8dd0b 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h @@ -9,19 +9,9 @@ #include "ipu7_fw_common_abi.h" #include "ipu7_fw_syscom_abi.h" =20 -#define IA_GOFO_FWLOG_SEVERITY_CRIT (0U) -#define IA_GOFO_FWLOG_SEVERITY_ERROR (1U) -#define IA_GOFO_FWLOG_SEVERITY_WARNING (2U) -#define IA_GOFO_FWLOG_SEVERITY_INFO (3U) -#define IA_GOFO_FWLOG_SEVERITY_DEBUG (4U) -#define IA_GOFO_FWLOG_SEVERITY_VERBOSE (5U) #define IA_GOFO_FWLOG_MAX_LOGGER_SOURCES (64U) =20 -#define LOGGER_CONFIG_CHANNEL_ENABLE_HWPRINTF_BITMASK BIT(0) #define LOGGER_CONFIG_CHANNEL_ENABLE_SYSCOM_BITMASK BIT(1) -#define LOGGER_CONFIG_CHANNEL_ENABLE_ALL_BITMASK \ - (LOGGER_CONFIG_CHANNEL_ENABLE_HWPRINTF_BITMASK | \ - LOGGER_CONFIG_CHANNEL_ENABLE_SYSCOM_BITMASK) =20 struct ia_gofo_logger_config { u8 use_source_severity; @@ -35,27 +25,7 @@ struct ia_gofo_logger_config { =20 #pragma pack(push, 1) =20 -#define IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX_PER_APP \ - ((u32)IA_GOFO_FW_BOOT_ID_MAX) -#define IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_IS_OFFSET (0U) -#define IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_PS_OFFSET \ - ((IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_IS_OFFSET) + \ - (u32)(IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX_PER_APP)) -#define IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_PRIMARY_OFFSET (0U) -#define IA_GOFO_CCG_IPU_BUTTRESS_FW_BOOT_PARAMS_SECONDARY_OFFSET (0x3000 /= 4U) -#define IA_GOFO_HKR_IPU_BUTTRESS_FW_BOOT_PARAMS_SECONDARY_OFFSET \ - (IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX_PER_APP * 2U) -#define IA_GOFO_HKR_HIF_BUTTRESS_FW_BOOT_PARAMS_SECONDARY_OFFSET \ - (IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX_PER_APP) -#define IA_GOFO_CCG_IPU_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX \ - (IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX_PER_APP * 4U) -#define IA_GOFO_HKR_IPU_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX \ - (IA_GOFO_BUTTRESS_FW_BOOT_PARAMS_MAX_REG_IDX_PER_APP * 4U) - #define IA_GOFO_BOOT_RESERVED_SIZE (58U) -#define IA_GOFO_BOOT_SECONDARY_RESERVED_SIZE (IA_GOFO_BOOT_RESERVED_SIZE) -#define IA_GOFO_BOOT_SECONDARY_RESERVED_FIELDS \ - (sizeof(ia_gofo_addr_t) + sizeof(ia_gofo_addr_t) + sizeof(u32)) =20 enum ia_gofo_buttress_reg_id { IA_GOFO_FW_BOOT_CONFIG_ID =3D 0, @@ -101,7 +71,6 @@ struct ia_gofo_boot_config { #define IA_GOFO_MEM_UNCORRECTABLE_CACHE_ERR 0xdead0805 #define IA_GOFO_DOUBLE_EXCEPTION_ERR 0xdead0806 #define IA_GOFO_BIST_DMEM_FAULT_DETECTION_ERR 0xdead1000 -#define IA_GOFO_BIST_DATA_INTEGRITY_FAILURE 0xdead1010 =20 enum ia_gofo_boot_state { IA_GOFO_FW_BOOT_STATE_SECONDARY_BOOT_CONFIG_READY =3D 0x57a7b000, diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h b/drivers/= staging/media/ipu7/abi/ipu7_fw_common_abi.h index c50b355b04d8..dab4476f83ff 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h @@ -11,8 +11,6 @@ #pragma pack(push, 1) typedef u32 ia_gofo_addr_t; =20 -#define IA_GOFO_ADDR_NULL (0U) - struct ia_gofo_version_s { u8 patch; u8 subminor; @@ -20,10 +18,6 @@ struct ia_gofo_version_s { u8 major; }; =20 -#define IA_GOFO_MSG_VERSION_INIT(major_val, minor_val, subminor_val, patch= _val)\ - {.major =3D (major_val), .minor =3D (minor_val), .subminor =3D \ - (subminor_val), .patch =3D (patch_val)} - #define IA_GOFO_MSG_VERSION_LIST_MAX_ENTRIES (3U) #define IA_GOFO_MSG_RESERVED_SIZE (3U) =20 @@ -35,22 +29,11 @@ struct ia_gofo_msg_version_list { =20 #pragma pack(pop) =20 -#define TLV_TYPE_PADDING (0U) - #pragma pack(push, 1) - -#define IA_GOFO_ABI_BITS_PER_BYTE (8U) - -#define TLV_ITEM_ALIGNMENT ((u32)sizeof(u32)) -#define TLV_MSG_ALIGNMENT ((u32)sizeof(u64)) -#define TLV_LIST_ALIGNMENT TLV_ITEM_ALIGNMENT #pragma pack(pop) =20 -#define IA_GOFO_MODULO(dividend, divisor) ((dividend) % (divisor)) - #define IA_GOFO_MSG_ERR_MAX_DETAILS (4U) #define IA_GOFO_MSG_ERR_OK (0U) -#define IA_GOFO_MSG_ERR_UNSPECIFED (0xffffffff) #define IA_GOFO_MSG_ERR_GROUP_UNSPECIFIED (0U) #define IA_GOFO_MSG_ERR_IS_OK(err) (IA_GOFO_MSG_ERR_OK =3D=3D (err).err_co= de) =20 @@ -63,9 +46,6 @@ struct ia_gofo_msg_err { =20 #pragma pack(pop) =20 -#define IA_GOFO_MSG_ERR_GROUP_APP_EXT_START (16U) -#define IA_GOFO_MSG_ERR_GROUP_MAX (31U) -#define IA_GOFO_MSG_ERR_GROUP_INTERNAL_START (IA_GOFO_MSG_ERR_GROUP_MAX + = 1U) #define IA_GOFO_MSG_ERR_GROUP_RESERVED IA_GOFO_MSG_ERR_GROUP_UNSPECIFIED #define IA_GOFO_MSG_ERR_GROUP_GENERAL 1 =20 @@ -104,16 +84,10 @@ enum ia_gofo_soc_pbk_instance_id { IA_GOFO_SOC_PBK_ID_N }; =20 -#define IA_GOFO_MSG_LINK_PBK_MAX_SLOTS (2U) - #pragma pack(pop) =20 #pragma pack(push, 1) #define IA_GOFO_MSG_LOG_MAX_PARAMS (4U) -#define IA_GOFO_MSG_LOG_DOC_FMT_ID_MIN (0U) - -#define IA_GOFO_MSG_LOG_DOC_FMT_ID_MAX (4095U) -#define IA_GOFO_MSG_LOG_FMT_ID_INVALID (0xfffffff) =20 struct ia_gofo_msg_log_info { u16 log_counter; @@ -131,8 +105,6 @@ struct ia_gofo_msg_log_info_ts { =20 #pragma pack(pop) =20 -#define IA_GOFO_MSG_ABI_OUT_ACK_QUEUE_ID (0U) #define IA_GOFO_MSG_ABI_OUT_LOG_QUEUE_ID (1U) -#define IA_GOFO_MSG_ABI_IN_DEV_QUEUE_ID (2U) =20 #endif diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_config_abi.h b/drivers/= staging/media/ipu7/abi/ipu7_fw_config_abi.h index c3f62aaedd86..cd6c6add0333 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_config_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_config_abi.h @@ -8,9 +8,6 @@ =20 #include =20 -#define IPU_CONFIG_ABI_WDT_TIMER_DISABLED 0U -#define IPU_CONFIG_ABI_CMD_TIMER_DISABLED 0U - struct ipu7_wdt_abi { u32 wdt_timer1_us; u32 wdt_timer2_us; diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h b/drivers/st= aging/media/ipu7/abi/ipu7_fw_isys_abi.h index 87bf2bd5576c..f1dbcfefaa10 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h @@ -19,19 +19,8 @@ #define IPU_INSYS_OUTPUT_LOG_QUEUE (IPU_INSYS_OUTPUT_FIRST_QUEUE + 1U) #define IPU_INSYS_OUTPUT_RESERVED_QUEUE (IPU_INSYS_OUTPUT_LAST_QUEUE) #define IPU_INSYS_INPUT_FIRST_QUEUE (IPU_INSYS_MAX_OUTPUT_QUEUES) -#define IPU_INSYS_INPUT_LAST_QUEUE \ - (IPU_INSYS_INPUT_FIRST_QUEUE + IPU_INSYS_MAX_INPUT_QUEUES - 1U) #define IPU_INSYS_INPUT_DEV_QUEUE (IPU_INSYS_INPUT_FIRST_QUEUE) #define IPU_INSYS_INPUT_MSG_QUEUE (IPU_INSYS_INPUT_FIRST_QUEUE + 1U) -#define IPU_INSYS_INPUT_MSG_MAX_QUEUE (IPU_INSYS_MAX_INPUT_QUEUES - 1U) - -#define MAX_OPINS_FOR_SINGLE_IPINS (3U) -#define DEV_SEND_QUEUE_SIZE (IPU_INSYS_STREAM_ID_MAX) - -#define PIN_PLANES_MAX (4U) - -#define INSYS_MSG_ERR_STREAM_INSUFFICIENT_RESOURCES_INPUT \ - INSYS_MSG_ERR_STREAM_INSUFFICIENT_RESOURCES =20 typedef u64 ipu7_insys_return_token; =20 @@ -129,7 +118,6 @@ enum ipu7_insys_frame_format_type { N_IPU_INSYS_FRAME_FORMAT }; =20 -#define IPU_INSYS_FRAME_FORMAT_RAW (IPU_INSYS_FRAME_FORMAT_RAW16) #define N_IPU_INSYS_MIPI_DATA_TYPE 0x40 =20 enum ipu7_insys_mipi_dt_rename_mode { @@ -138,27 +126,10 @@ enum ipu7_insys_mipi_dt_rename_mode { N_IPU_INSYS_MIPI_DT_MODE }; =20 -#define IPU_INSYS_SEND_MSG_ENABLED 1U -#define IPU_INSYS_SEND_MSG_DISABLED 0U - #define IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_SOF BIT(0) -#define IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_EOF BIT(1) #define IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_SOF BIT(2) -#define IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_EOF BIT(3) #define IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_SOF_DISCARDED BIT(4) -#define IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_EOF_DISCARDED BIT(5) #define IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_SOF_DISCARDED BIT(6) -#define IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_EOF_DISCARDED BIT(7) -#define IPU_INSYS_STREAM_SYNC_MSG_ENABLE_MSG_SEND_RESP ( \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_SOF | \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_EOF | \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_SOF_DISCARDED | \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_EOF_DISCARDED) -#define IPU_INSYS_STREAM_SYNC_MSG_ENABLE_MSG_SEND_IRQ ( \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_SOF | \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_EOF | \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_SOF_DISCARDED | \ - IPU_INSYS_STREAM_SYNC_MSG_SEND_IRQ_EOF_DISCARDED) =20 #define IPU_INSYS_STREAM_MSG_SEND_RESP_STREAM_OPEN_DONE BIT(0) #define IPU_INSYS_STREAM_MSG_SEND_IRQ_STREAM_OPEN_DONE BIT(1) diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h b/drivers/sta= ging/media/ipu7/abi/ipu7_fw_msg_abi.h index 1d0541b1ae9d..3f2c065dfe14 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h @@ -28,9 +28,6 @@ enum ipu7_msg_type { IPU_MSG_TYPE_N, }; =20 -#define IPU_MSG_MAX_NODE_TERMS (64U) -#define IPU_MSG_MAX_FRAGS (7U) - enum ipu7_msg_node_type { IPU_MSG_NODE_TYPE_PAD =3D 0, IPU_MSG_NODE_TYPE_BASE, @@ -55,14 +52,6 @@ enum ipu7_msg_node_profile_type { IPU_MSG_NODE_PROFILE_TYPE_N }; =20 -#define IPU_MSG_NODE_MAX_PROFILES (2U) -#define IPU_MSG_NODE_DEF_PROFILE_IDX (0U) -#define IPU_MSG_NODE_RSRC_ID_EXT_IP (0xff) - -#define IPU_MSG_NODE_DONT_CARE_TEB_HI (0xffffffff) -#define IPU_MSG_NODE_DONT_CARE_TEB_LO (0xffffffff) -#define IPU_MSG_NODE_RSRC_ID_IS (0xfe) - enum ipu7_msg_node_option_types { IPU_MSG_NODE_OPTION_TYPES_PADDING =3D 0, IPU_MSG_NODE_OPTION_TYPES_N @@ -90,20 +79,9 @@ enum ipu7_msg_link_cmprs_option_bit_depth { IPU_MSG_LINK_CMPRS_OPTION_12BPP =3D 2, }; =20 -#define IPU_MSG_LINK_CMPRS_SPACE_SAVING_DENOM (128U) -#define IPU_MSG_LINK_CMPRS_LOSSY_CFG_PAYLOAD_SIZE (5U) -#define IPU_MSG_LINK_CMPRS_SPACE_SAVING_NUM_MAX \ - (IPU_MSG_LINK_CMPRS_SPACE_SAVING_DENOM - 1U) - -#define IPU_MSG_LINK_CMPRS_MAX_PLANES (2U) -#define IPU_MSG_LINK_CMPRS_NO_ALIGN_INTERVAL (0U) -#define IPU_MSG_LINK_CMPRS_MIN_ALIGN_INTERVAL (16U) -#define IPU_MSG_LINK_CMPRS_MAX_ALIGN_INTERVAL (1024U) #define IPU_MSG_LINK_FOREIGN_KEY_NONE (65535U) -#define IPU_MSG_LINK_FOREIGN_KEY_MAX (64U) #define IPU_MSG_LINK_PBK_ID_DONT_CARE (255U) #define IPU_MSG_LINK_PBK_SLOT_ID_DONT_CARE (255U) -#define IPU_MSG_LINK_TERM_ID_DONT_CARE (0xff) =20 #pragma pack(pop) =20 @@ -165,10 +143,6 @@ enum ipu7_msg_term_type { IPU_MSG_TERM_TYPE_N, }; =20 -#define IPU_MSG_TERM_EVENT_TYPE_NONE 0U -#define IPU_MSG_TERM_EVENT_TYPE_PROGRESS 1U -#define IPU_MSG_TERM_EVENT_TYPE_N (IPU_MSG_TERM_EVENT_TYPE_PROGRESS + 1U) - enum ipu7_msg_term_option_types { IPU_MSG_TERM_OPTION_TYPES_PADDING =3D 0, IPU_MSG_TERM_OPTION_TYPES_N @@ -177,14 +151,6 @@ enum ipu7_msg_term_option_types { #pragma pack(pop) =20 #pragma pack(push, 1) -#define IPU_MSG_DEVICE_SEND_MSG_ENABLED 1U -#define IPU_MSG_DEVICE_SEND_MSG_DISABLED 0U - -#define IPU_MSG_DEVICE_OPEN_SEND_RESP BIT(0) -#define IPU_MSG_DEVICE_OPEN_SEND_IRQ BIT(1) - -#define IPU_MSG_DEVICE_CLOSE_SEND_RESP BIT(0) -#define IPU_MSG_DEVICE_CLOSE_SEND_IRQ BIT(1) =20 enum ipu7_msg_err_device { IPU_MSG_ERR_DEVICE_OK =3D IA_GOFO_MSG_ERR_OK, @@ -196,15 +162,6 @@ enum ipu7_msg_err_device { #pragma pack(pop) =20 #pragma pack(push, 1) -#define IPU_MSG_GRAPH_ID_UNKNOWN (0xff) -#define IPU_MSG_GRAPH_SEND_MSG_ENABLED 1U -#define IPU_MSG_GRAPH_SEND_MSG_DISABLED 0U - -#define IPU_MSG_GRAPH_OPEN_SEND_RESP BIT(0) -#define IPU_MSG_GRAPH_OPEN_SEND_IRQ BIT(1) - -#define IPU_MSG_GRAPH_CLOSE_SEND_RESP BIT(0) -#define IPU_MSG_GRAPH_CLOSE_SEND_IRQ BIT(1) =20 enum ipu7_msg_graph_ack_option_types { IPU_MSG_GRAPH_ACK_OPTION_TYPES_PADDING =3D 0, @@ -259,16 +216,12 @@ enum ipu7_msg_err_graph { =20 #define FWPS_MSG_ABI_MAX_INPUT_QUEUES (60U) #define FWPS_MSG_ABI_MAX_OUTPUT_QUEUES (2U) -#define FWPS_MSG_ABI_MAX_QUEUES \ - (FWPS_MSG_ABI_MAX_OUTPUT_QUEUES + FWPS_MSG_ABI_MAX_INPUT_QUEUES) =20 -#define FWPS_MSG_ABI_OUT_ACK_QUEUE_ID (IA_GOFO_MSG_ABI_OUT_ACK_QUEUE_ID) #define FWPS_MSG_ABI_OUT_LOG_QUEUE_ID (IA_GOFO_MSG_ABI_OUT_LOG_QUEUE_ID) #if (FWPS_MSG_ABI_OUT_LOG_QUEUE_ID >=3D FWPS_MSG_ABI_MAX_OUTPUT_QUEUES) #error "Maximum output queues configuration is too small to fit ACK and LO= G \ queues" #endif -#define FWPS_MSG_ABI_IN_DEV_QUEUE_ID (IA_GOFO_MSG_ABI_IN_DEV_QUEUE_ID) #define FWPS_MSG_ABI_IN_RESERVED_QUEUE_ID (3U) #define FWPS_MSG_ABI_IN_FIRST_TASK_QUEUE_ID \ (FWPS_MSG_ABI_IN_RESERVED_QUEUE_ID + 1U) @@ -278,16 +231,4 @@ queues" useful queues" #endif =20 -#define FWPS_MSG_ABI_IN_LAST_TASK_QUEUE_ID (FWPS_MSG_ABI_MAX_QUEUES - 1U) -#define FWPS_MSG_ABI_IN_MAX_TASK_QUEUES \ - (FWPS_MSG_ABI_IN_LAST_TASK_QUEUE_ID - \ - FWPS_MSG_ABI_IN_FIRST_TASK_QUEUE_ID + 1U) -#define FWPS_MSG_ABI_OUT_FIRST_QUEUE_ID (FWPS_MSG_ABI_OUT_ACK_QUEUE_ID) -#define FWPS_MSG_ABI_OUT_LAST_QUEUE_ID (FWPS_MSG_ABI_MAX_OUTPUT_QUEUES - 1= U) -#define FWPS_MSG_ABI_IN_FIRST_QUEUE_ID (FWPS_MSG_ABI_IN_DEV_QUEUE_ID) -#define FWPS_MSG_ABI_IN_LAST_QUEUE_ID (FWPS_MSG_ABI_IN_LAST_TASK_QUEUE_ID) - -#define FWPS_MSG_HOST2FW_MAX_SIZE (2U * 1024U) -#define FWPS_MSG_FW2HOST_MAX_SIZE (256U) - #endif diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_syscom_abi.h b/drivers/= staging/media/ipu7/abi/ipu7_fw_syscom_abi.h index bfa5258d5b97..19b5149279c3 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_syscom_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_syscom_abi.h @@ -11,7 +11,6 @@ #include "ipu7_fw_common_abi.h" =20 #pragma pack(push, 1) -#define SYSCOM_QUEUE_MIN_CAPACITY 2U =20 struct syscom_queue_params_config { ia_gofo_addr_t token_array_mem; --=20 2.55.0 From nobody Tue Aug 25 03:43:32 2026 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 404F73D1CA0 for ; Wed, 5 Aug 2026 18:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954221; cv=none; b=U7Bmzlum4RTFG98jfr9lTgDKzCcOvwdPzFdrFf8pM/0J8nOMTCqEXonhHb3rutLRuYrfScgpYr+AKFibC1TSRibLqGi41Yp2u+q0zGjE+QosYmckXhHVkRI/UAB53k19eL3YeDLdDbBdaCQr+lOra1pmgAeSn8BtanXvO+bDiuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954221; c=relaxed/simple; bh=1eEGL7A0dMavzZrvhCKZT8bMnGIebqmL+KjF3tzRagc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rPrpEFMCgY0SzB/bFixggN0LEthfdiUa0P3UQyyaishkmrLyFTrm4iTTJA6+vwIgNfqckq03M7S9KInCsnb8zoT79+SN+Kwg9MwDv/gjEg37hU4za1ZYUZFlX9HHVXglTb/6EBfugFHcHtZAx6CaeXOLcaZYnoJOr8CXE1s2aeo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FFloF0Yv; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FFloF0Yv" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-39c95395230so13548081fa.2 for ; Wed, 05 Aug 2026 11:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785954217; x=1786559017; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mciNMHer4yecSnmT/u7HJTGY8Xf5T8qm1lfeFBZ+yes=; b=FFloF0YvNcXvbSG2PD5Jsyd8VvXkk1d9Njdvk+Vv6jrml0D1T25UMp53dIjzkD2o1P l+lWA0YBlPE1ugiA2oSnPaX4kPGiIJ7XFJGAlr1TQo4xtkUOqt9ctak4jiu4JABG909r 45Ukc899w7iFg3PN/6Uy99Po+6kKi5xfXhQw9/qQ4adamtOIIE2QtUpKg1jPcI4dPaBf D40qtWqdlQW8GKHBy1Nc36tYp4ixK0fQdy+R6hEe+BCdNPTZOMuxwT3CVLY09xYa0tcy hnIn3hXgfNn4AdPw4BGRyxcH8YiYc+bdl3HREEM/FxIrNZ6xFZpqEyFegqSWWCWS7tOh rKIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785954217; x=1786559017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mciNMHer4yecSnmT/u7HJTGY8Xf5T8qm1lfeFBZ+yes=; b=JU3FPtiIsLg54ElQ6bq35TSm8/IN9WUQ4EO9auxVxpPrVScWTkYM+tFlwISutjV75f I4x7HMZqEH30IwKT2Pre38cdS5RBekiiigLq5zUtjo8skkqqUJhvA30eUMx76ookVYXF 6WLIGOT/e16xhT08+0ESPxv2omlQbZGwn1L257R9pBmAb2EgTfFopPrBoipYTvdvVvWO 3P4+bTckDLtAostJaXAG3WwzVCbMxj6zP4uGonu7VBnu5AOnGCjcFjUx1eLWjqIp7jg0 qaLFKTU0W7HK1OstzCbSjCXPm4ynfRaBwR6qrqTv5FcG/ygres3dGeGGvfHcxbUgnycF BftQ== X-Gm-Message-State: AOJu0YyG+uWkKop7/uNsKBla6uCT7x4/5mvRNwUZXn2D3yZy5NGso9JH jWSsLXyPHVUk/zSYiQ9/evdrjr5g43MCXZADzvek8biUxKlGzBnJ7FIM X-Gm-Gg: AR+sD11rh4cHYI/WIKHv4FbMesO/WMXIirNGyK/GOzGE88Nw+zupeJ3y59AwnMo8Bzp sIY4uQ7mjpSg4CIp+/Pjoto9A8IQuYtwy6mkE4G4MVwVZxWFrbxQC6J5eRqoX01vWclErdTJXlz T/9QIQJXtuU+dfp4jksNcRuGIhMjpBhNcxbx8BqkhoGMXqUjIYotkOmG1ROA7GVmEIGkFQArXqK Aw8MIxiYlKXWsGbCpIAnUxA/SjZO4FeTuaByXI1X1h/DGZu2vwPQ1kPp+soE7j1OpZjqQnVUxkN LOzn3SoF+CXLNrNfOm0/08J8hDXuTL7TfXQR+IHTw6glWsXKZMkgfRRPb3LtQxQmPRIGKmiegxF qyQWhhvXeWceGHPc4KOZyUNYQH+5vQXumpPCeTOjpQth1yD4j2AhkEo0FwFyujPxMkfptoJ4XtT QR3eBofVlf41+e+p+Khn920kiuc41ikIxgUlbSSWZojiHxofVsIXwS4hRQOdpDxiAvXXQqCw== X-Received: by 2002:a2e:bc25:0:b0:39b:2b7d:9c77 with SMTP id 38308e7fff4ca-39fbb22aba4mr11456861fa.30.1785954216734; Wed, 05 Aug 2026 11:23:36 -0700 (PDT) Received: from [192.168.243.250] ([94.229.19.199]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fb9a32bb7sm11954811fa.29.2026.08.05.11.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 11:23:36 -0700 (PDT) From: Nikolay Kulikov Date: Wed, 05 Aug 2026 21:23:07 +0300 Subject: [PATCH 3/4] staging: media: ipu7: remove unused abi enums Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260805-ipu7_abi-v1-3-46d420cef267@gmail.com> References: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> In-Reply-To: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> To: Sakari Ailus , Bingbu Cao , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Nikolay Kulikov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785954209; l=19244; i=nikolayof23@gmail.com; s=20260402; h=from:subject:message-id; bh=1eEGL7A0dMavzZrvhCKZT8bMnGIebqmL+KjF3tzRagc=; b=79L5BphP9T/TJQUwVw9nDCE9H22fFJSx33DVR2VOOj93FyK+4XvJak8l2BfAIIkLoJfzzdPip fzpSD5eJ0BTAKy61f7SxSxB6gbVT+QZFWrWLpuvPmJveOG2PMJ3fe+J X-Developer-Key: i=nikolayof23@gmail.com; a=ed25519; pk=2GWUU1isl5NJpkwSCQ4OG80EinZ3EUZXlrgAg6Pz5zI= These enumerations and their members are defined but never used, so we can remove them. Signed-off-by: Nikolay Kulikov --- drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h | 44 ------ .../staging/media/ipu7/abi/ipu7_fw_common_abi.h | 22 --- drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h | 150 ------------------ drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h | 170 -----------------= ---- 4 files changed, 386 deletions(-) diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h b/drivers/st= aging/media/ipu7/abi/ipu7_fw_boot_abi.h index 00c04ee8dd0b..c65c88101234 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_boot_abi.h @@ -30,18 +30,13 @@ struct ia_gofo_logger_config { enum ia_gofo_buttress_reg_id { IA_GOFO_FW_BOOT_CONFIG_ID =3D 0, IA_GOFO_FW_BOOT_STATE_ID =3D 1, - IA_GOFO_FW_BOOT_RESERVED1_ID =3D IA_GOFO_FW_BOOT_STATE_ID, IA_GOFO_FW_BOOT_SYSCOM_QUEUE_INDICES_BASE_ID =3D 2, - IA_GOFO_FW_BOOT_UNTRUSTED_ADDR_MIN_ID =3D 3, - IA_GOFO_FW_BOOT_RESERVED0_ID =3D IA_GOFO_FW_BOOT_UNTRUSTED_ADDR_MIN_ID, IA_GOFO_FW_BOOT_MESSAGING_VERSION_ID =3D 4, IA_GOFO_FW_BOOT_ID_MAX }; =20 enum ia_gofo_boot_uc_tile_frequency_units { IA_GOFO_FW_BOOT_UC_FREQUENCY_UNITS_MHZ =3D 0, - IA_GOFO_FW_BOOT_UC_FREQUENCY_UNITS_HZ =3D 1, - IA_GOFO_FW_BOOT_UC_FREQUENCY_UNITS_N }; =20 #define IA_GOFO_FW_BOOT_STATE_IS_CRITICAL(boot_state) \ @@ -73,49 +68,10 @@ struct ia_gofo_boot_config { #define IA_GOFO_BIST_DMEM_FAULT_DETECTION_ERR 0xdead1000 =20 enum ia_gofo_boot_state { - IA_GOFO_FW_BOOT_STATE_SECONDARY_BOOT_CONFIG_READY =3D 0x57a7b000, IA_GOFO_FW_BOOT_STATE_UNINIT =3D 0x57a7e000, - IA_GOFO_FW_BOOT_STATE_STARTING_0 =3D 0x57a7d000, - IA_GOFO_FW_BOOT_STATE_CACHE_INIT_DONE =3D 0x57a7d010, - IA_GOFO_FW_BOOT_STATE_MEM_INIT_DONE =3D 0x57a7d020, - IA_GOFO_FW_BOOT_STATE_STACK_INIT_DONE =3D 0x57a7d030, - IA_GOFO_FW_BOOT_STATE_EARLY_BOOT_DONE =3D 0x57a7d100, - IA_GOFO_FW_BOOT_STATE_BOOT_CONFIG_START =3D 0x57a7d200, - IA_GOFO_FW_BOOT_STATE_QUEUE_INIT_DONE =3D 0x57a7d300, IA_GOFO_FW_BOOT_STATE_READY =3D 0x57a7e100, - IA_GOFO_FW_BOOT_STATE_CRIT_UNSPECIFIED =3D 0xdead0001, - IA_GOFO_FW_BOOT_STATE_CRIT_CFG_PTR =3D 0xdead0101, - IA_GOFO_FW_BOOT_STATE_CRIT_CFG_VERSION =3D 0xdead0201, - IA_GOFO_FW_BOOT_STATE_CRIT_MSG_VERSION =3D 0xdead0301, - IA_GOFO_FW_BOOT_STATE_CRIT_WDT_TIMEOUT =3D IA_GOFO_WDT_TIMEOUT_ERR, - IA_GOFO_FW_BOOT_STATE_WRONG_DATA_SECTION_UNPACKING =3D 0xdead0501, - IA_GOFO_FW_BOOT_STATE_WRONG_RO_DATA_SECTION_UNPACKING =3D 0xdead0601, - IA_GOFO_FW_BOOT_STATE_INVALID_UNTRUSTED_ADDR_MIN =3D 0xdead0701, - IA_GOFO_FW_BOOT_STATE_CRIT_MEM_FATAL_DME =3D IA_GOFO_MEM_FATAL_DME_ERR, - IA_GOFO_FW_BOOT_STATE_CRIT_MEM_UNCORRECTABLE_LOCAL =3D - IA_GOFO_MEM_UNCORRECTABLE_LOCAL_ERR, - IA_GOFO_FW_BOOT_STATE_CRIT_MEM_UNCORRECTABLE_DIRTY =3D - IA_GOFO_MEM_UNCORRECTABLE_DIRTY_ERR, - IA_GOFO_FW_BOOT_STATE_CRIT_MEM_UNCORRECTABLE_DTAG =3D - IA_GOFO_MEM_UNCORRECTABLE_DTAG_ERR, - IA_GOFO_FW_BOOT_STATE_CRIT_MEM_UNCORRECTABLE_CACHE =3D - IA_GOFO_MEM_UNCORRECTABLE_CACHE_ERR, - IA_GOFO_FW_BOOT_STATE_CRIT_DOUBLE_EXCEPTION =3D - IA_GOFO_DOUBLE_EXCEPTION_ERR, - IA_GOFO_FW_BOOT_STATE_CRIT_BIST_DMEM_FAULT_DETECTION_ERR =3D - IA_GOFO_BIST_DMEM_FAULT_DETECTION_ERR, - IA_GOFO_FW_BOOT_STATE_CRIT_DATA_INTEGRITY_FAILURE =3D 0xdead1010, - IA_GOFO_FW_BOOT_STATE_CRIT_STACK_CHK_FAILURE =3D 0xdead1011, - IA_GOFO_FW_BOOT_STATE_CRIT_SYSCOM_CONTEXT_INTEGRITY_FAILURE =3D - 0xdead1012, - IA_GOFO_FW_BOOT_STATE_CRIT_MPU_CONFIG_FAILURE =3D 0xdead1013, - IA_GOFO_FW_BOOT_STATE_CRIT_SHARED_BUFFER_FAILURE =3D 0xdead1014, - IA_GOFO_FW_BOOT_STATE_CRIT_CMEM_FAILURE =3D 0xdead1015, IA_GOFO_FW_BOOT_STATE_SHUTDOWN_CMD =3D 0x57a7f001, - IA_GOFO_FW_BOOT_STATE_SHUTDOWN_START =3D 0x57a7e200, IA_GOFO_FW_BOOT_STATE_INACTIVE =3D 0x57a7e300, - IA_GOFO_FW_BOOT_HW_CMD_ACK_TIMEOUT =3D 0x57a7e400, - IA_GOFO_FW_BOOT_SYSTEM_CYCLES_ERROR =3D 0x57a7e500 }; =20 #endif diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h b/drivers/= staging/media/ipu7/abi/ipu7_fw_common_abi.h index dab4476f83ff..b85dcc519a31 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h @@ -49,18 +49,6 @@ struct ia_gofo_msg_err { #define IA_GOFO_MSG_ERR_GROUP_RESERVED IA_GOFO_MSG_ERR_GROUP_UNSPECIFIED #define IA_GOFO_MSG_ERR_GROUP_GENERAL 1 =20 -enum ia_gofo_msg_err_general { - IA_GOFO_MSG_ERR_GENERAL_OK =3D IA_GOFO_MSG_ERR_OK, - IA_GOFO_MSG_ERR_GENERAL_MSG_TOO_SMALL =3D 1, - IA_GOFO_MSG_ERR_GENERAL_MSG_TOO_LARGE =3D 2, - IA_GOFO_MSG_ERR_GENERAL_DEVICE_STATE =3D 3, - IA_GOFO_MSG_ERR_GENERAL_ALIGNMENT =3D 4, - IA_GOFO_MSG_ERR_GENERAL_INDIRECT_REF_PTR_INVALID =3D 5, - IA_GOFO_MSG_ERR_GENERAL_INVALID_MSG_TYPE =3D 6, - IA_GOFO_MSG_ERR_GENERAL_SYSCOM_FAIL =3D 7, - IA_GOFO_MSG_ERR_GENERAL_N -}; - #pragma pack(push, 1) #define IA_GOFO_MSG_TYPE_RESERVED 0 #define IA_GOFO_MSG_TYPE_INDIRECT 1 @@ -72,16 +60,6 @@ enum ia_gofo_msg_err_general { #pragma pack(push, 1) enum ia_gofo_msg_link_streaming_mode { IA_GOFO_MSG_LINK_STREAMING_MODE_SOFF =3D 0, - IA_GOFO_MSG_LINK_STREAMING_MODE_DOFF =3D 1, - IA_GOFO_MSG_LINK_STREAMING_MODE_BCLM =3D 2, - IA_GOFO_MSG_LINK_STREAMING_MODE_BCSM_FIX =3D 3, - IA_GOFO_MSG_LINK_STREAMING_MODE_N -}; - -enum ia_gofo_soc_pbk_instance_id { - IA_GOFO_SOC_PBK_ID0 =3D 0, - IA_GOFO_SOC_PBK_ID1 =3D 1, - IA_GOFO_SOC_PBK_ID_N }; =20 #pragma pack(pop) diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h b/drivers/st= aging/media/ipu7/abi/ipu7_fw_isys_abi.h index f1dbcfefaa10..29ea0355fdde 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_isys_abi.h @@ -36,7 +36,6 @@ enum ipu7_insys_resp_type { IPU_INSYS_RESP_TYPE_FRAME_EOF =3D 8, IPU_INSYS_RESP_TYPE_STREAM_START_AND_CAPTURE_DONE =3D 9, IPU_INSYS_RESP_TYPE_STREAM_CAPTURE_DONE =3D 10, - IPU_INSYS_RESP_TYPE_PWM_IRQ =3D 11, N_IPU_INSYS_RESP_TYPE }; =20 @@ -44,86 +43,26 @@ enum ipu7_insys_send_type { IPU_INSYS_SEND_TYPE_STREAM_OPEN =3D 0, IPU_INSYS_SEND_TYPE_STREAM_START_AND_CAPTURE =3D 1, IPU_INSYS_SEND_TYPE_STREAM_CAPTURE =3D 2, - IPU_INSYS_SEND_TYPE_STREAM_ABORT =3D 3, IPU_INSYS_SEND_TYPE_STREAM_FLUSH =3D 4, IPU_INSYS_SEND_TYPE_STREAM_CLOSE =3D 5, N_IPU_INSYS_SEND_TYPE }; =20 -enum ipu7_insys_mipi_vc { - IPU_INSYS_MIPI_VC_0 =3D 0, - IPU_INSYS_MIPI_VC_1 =3D 1, - IPU_INSYS_MIPI_VC_2 =3D 2, - IPU_INSYS_MIPI_VC_3 =3D 3, - IPU_INSYS_MIPI_VC_4 =3D 4, - IPU_INSYS_MIPI_VC_5 =3D 5, - IPU_INSYS_MIPI_VC_6 =3D 6, - IPU_INSYS_MIPI_VC_7 =3D 7, - IPU_INSYS_MIPI_VC_8 =3D 8, - IPU_INSYS_MIPI_VC_9 =3D 9, - IPU_INSYS_MIPI_VC_10 =3D 10, - IPU_INSYS_MIPI_VC_11 =3D 11, - IPU_INSYS_MIPI_VC_12 =3D 12, - IPU_INSYS_MIPI_VC_13 =3D 13, - IPU_INSYS_MIPI_VC_14 =3D 14, - IPU_INSYS_MIPI_VC_15 =3D 15, - N_IPU_INSYS_MIPI_VC -}; - -enum ipu7_insys_mipi_port { - IPU_INSYS_MIPI_PORT_0 =3D 0, - IPU_INSYS_MIPI_PORT_1 =3D 1, - IPU_INSYS_MIPI_PORT_2 =3D 2, - IPU_INSYS_MIPI_PORT_3 =3D 3, - IPU_INSYS_MIPI_PORT_4 =3D 4, - IPU_INSYS_MIPI_PORT_5 =3D 5, - NA_IPU_INSYS_MIPI_PORT -}; - enum ipu7_insys_frame_format_type { - IPU_INSYS_FRAME_FORMAT_NV11 =3D 0, - IPU_INSYS_FRAME_FORMAT_NV12 =3D 1, - IPU_INSYS_FRAME_FORMAT_NV12_16 =3D 2, - IPU_INSYS_FRAME_FORMAT_NV12_TILEY =3D 3, - IPU_INSYS_FRAME_FORMAT_NV16 =3D 4, - IPU_INSYS_FRAME_FORMAT_NV21 =3D 5, - IPU_INSYS_FRAME_FORMAT_NV61 =3D 6, - IPU_INSYS_FRAME_FORMAT_YV12 =3D 7, - IPU_INSYS_FRAME_FORMAT_YV16 =3D 8, - IPU_INSYS_FRAME_FORMAT_YUV420 =3D 9, - IPU_INSYS_FRAME_FORMAT_YUV420_10 =3D 10, - IPU_INSYS_FRAME_FORMAT_YUV420_12 =3D 11, - IPU_INSYS_FRAME_FORMAT_YUV420_14 =3D 12, - IPU_INSYS_FRAME_FORMAT_YUV420_16 =3D 13, - IPU_INSYS_FRAME_FORMAT_YUV422 =3D 14, - IPU_INSYS_FRAME_FORMAT_YUV422_16 =3D 15, IPU_INSYS_FRAME_FORMAT_UYVY =3D 16, IPU_INSYS_FRAME_FORMAT_YUYV =3D 17, - IPU_INSYS_FRAME_FORMAT_YUV444 =3D 18, - IPU_INSYS_FRAME_FORMAT_YUV_LINE =3D 19, IPU_INSYS_FRAME_FORMAT_RAW8 =3D 20, IPU_INSYS_FRAME_FORMAT_RAW10 =3D 21, IPU_INSYS_FRAME_FORMAT_RAW12 =3D 22, - IPU_INSYS_FRAME_FORMAT_RAW14 =3D 23, IPU_INSYS_FRAME_FORMAT_RAW16 =3D 24, IPU_INSYS_FRAME_FORMAT_RGB565 =3D 25, - IPU_INSYS_FRAME_FORMAT_PLANAR_RGB888 =3D 26, IPU_INSYS_FRAME_FORMAT_RGBA888 =3D 27, - IPU_INSYS_FRAME_FORMAT_QPLANE6 =3D 28, - IPU_INSYS_FRAME_FORMAT_BINARY_8 =3D 29, - IPU_INSYS_FRAME_FORMAT_Y_8 =3D 30, - IPU_INSYS_FRAME_FORMAT_ARGB888 =3D 31, - IPU_INSYS_FRAME_FORMAT_BGRA888 =3D 32, - IPU_INSYS_FRAME_FORMAT_ABGR888 =3D 33, - N_IPU_INSYS_FRAME_FORMAT }; =20 #define N_IPU_INSYS_MIPI_DATA_TYPE 0x40 =20 enum ipu7_insys_mipi_dt_rename_mode { IPU_INSYS_MIPI_DT_NO_RENAME =3D 0, - IPU_INSYS_MIPI_DT_RENAMED_MODE =3D 1, - N_IPU_INSYS_MIPI_DT_MODE }; =20 #define IPU_INSYS_STREAM_SYNC_MSG_SEND_RESP_SOF BIT(0) @@ -171,27 +110,10 @@ enum ipu7_insys_mipi_dt_rename_mode { =20 enum ipu7_insys_output_link_dest { IPU_INSYS_OUTPUT_LINK_DEST_MEM =3D 0, - IPU_INSYS_OUTPUT_LINK_DEST_PSYS =3D 1, - IPU_INSYS_OUTPUT_LINK_DEST_IPU_EXTERNAL =3D 2 -}; - -enum ipu7_insys_dpcm_type { - IPU_INSYS_DPCM_TYPE_DISABLED =3D 0, - IPU_INSYS_DPCM_TYPE_10_8_10 =3D 1, - IPU_INSYS_DPCM_TYPE_12_8_12 =3D 2, - IPU_INSYS_DPCM_TYPE_12_10_12 =3D 3, - N_IPU_INSYS_DPCM_TYPE -}; - -enum ipu7_insys_dpcm_predictor { - IPU_INSYS_DPCM_PREDICTOR_1 =3D 0, - IPU_INSYS_DPCM_PREDICTOR_2 =3D 1, - N_IPU_INSYS_DPCM_PREDICTOR }; =20 enum ipu7_insys_send_queue_token_flag { IPU_INSYS_SEND_QUEUE_TOKEN_FLAG_NONE =3D 0, - IPU_INSYS_SEND_QUEUE_TOKEN_FLAG_FLUSH_FORCE =3D 1 }; =20 #pragma pack(push, 1) @@ -296,84 +218,12 @@ struct ipu7_insys_send_queue_token { =20 #pragma pack(pop) =20 -enum insys_msg_err_stream { - INSYS_MSG_ERR_STREAM_OK =3D IA_GOFO_MSG_ERR_OK, - INSYS_MSG_ERR_STREAM_STREAM_ID =3D 1, - INSYS_MSG_ERR_STREAM_MAX_OPINS =3D 2, - INSYS_MSG_ERR_STREAM_MAX_IPINS =3D 3, - INSYS_MSG_ERR_STREAM_STREAM_MESSAGES_MAP =3D 4, - INSYS_MSG_ERR_STREAM_SYNC_MESSAGES_MAP =3D 5, - INSYS_MSG_ERR_STREAM_SENSOR_TYPE =3D 6, - INSYS_MSG_ERR_STREAM_FOREIGN_KEY =3D 7, - INSYS_MSG_ERR_STREAM_STREAMING_MODE =3D 8, - INSYS_MSG_ERR_STREAM_DPCM_EN =3D 9, - INSYS_MSG_ERR_STREAM_DPCM_TYPE =3D 10, - INSYS_MSG_ERR_STREAM_DPCM_PREDICTOR =3D 11, - INSYS_MSG_ERR_STREAM_GRANULARITY_POINTER_UPDATE =3D 12, - INSYS_MSG_ERR_STREAM_MPF_LUT_ENTRY_RESOURCES_BUSY =3D 13, - INSYS_MSG_ERR_STREAM_MPF_DEV_ID =3D 14, - INSYS_MSG_ERR_STREAM_BUFFER_LINES =3D 15, - INSYS_MSG_ERR_STREAM_IPIN_ID =3D 16, - INSYS_MSG_ERR_STREAM_DATA_TYPE =3D 17, - INSYS_MSG_ERR_STREAM_STREAMING_PROTOCOL_STATE =3D 18, - INSYS_MSG_ERR_STREAM_SYSCOM_FLUSH =3D 19, - INSYS_MSG_ERR_STREAM_MIPI_VC =3D 20, - INSYS_MSG_ERR_STREAM_STREAM_SRC =3D 21, - INSYS_MSG_ERR_STREAM_PBK_ID =3D 22, - INSYS_MSG_ERR_STREAM_CMD_QUEUE_DEALLOCATE =3D 23, - INSYS_MSG_ERR_STREAM_INSUFFICIENT_RESOURCES =3D 24, - INSYS_MSG_ERR_STREAM_IPIN_CONFIGURATION =3D 25, - INSYS_MSG_ERR_STREAM_INVALID_STATE =3D 26, - INSYS_MSG_ERR_STREAM_SW_MANAGED =3D 27, - INSYS_MSG_ERR_STREAM_PBK_SLOT_ID =3D 28, - INSYS_MSG_ERR_STREAM_FLUSH_TIMEOUT =3D 29, - INSYS_MSG_ERR_STREAM_IPIN_WIDTH =3D 30, - INSYS_MSG_ERR_STREAM_IPIN_HEIGHT =3D 31, - INSYS_MSG_ERR_STREAM_OUTPUT_PIN_EARLY_ACK_EN =3D 32, - INSYS_MSG_ERR_STREAM_INCONSISTENT_PARAMS =3D 33, - INSYS_MSG_ERR_STREAM_PLANE_COUNT =3D 34, - INSYS_MSG_ERR_STREAM_FRAME_FORMAT_TYPE =3D 35, - INSYS_MSG_ERR_STREAM_INSUFFICIENT_RESOURCES_OUTPUT =3D 36, - INSYS_MSG_ERR_STREAM_WIDTH_OUTPUT_SIZE =3D 37, - INSYS_MSG_ERR_STREAM_CLOSED =3D 38, - INSYS_MSG_ERR_STREAM_N -}; - enum insys_msg_err_capture { - INSYS_MSG_ERR_CAPTURE_OK =3D IA_GOFO_MSG_ERR_OK, - INSYS_MSG_ERR_CAPTURE_STREAM_ID =3D 1, - INSYS_MSG_ERR_CAPTURE_PAYLOAD_PTR =3D 2, - INSYS_MSG_ERR_CAPTURE_MEM_SLOT =3D 3, - INSYS_MSG_ERR_CAPTURE_STREAMING_MODE =3D 4, - INSYS_MSG_ERR_CAPTURE_AVAILABLE_CMD_SLOT =3D 5, - INSYS_MSG_ERR_CAPTURE_CONSUMED_CMD_SLOT =3D 6, - INSYS_MSG_ERR_CAPTURE_CMD_SLOT_PAYLOAD_PTR =3D 7, - INSYS_MSG_ERR_CAPTURE_CMD_PREPARE =3D 8, - INSYS_MSG_ERR_CAPTURE_OUTPUT_PIN =3D 9, INSYS_MSG_ERR_CAPTURE_SYNC_FRAME_DROP =3D 10, - INSYS_MSG_ERR_CAPTURE_FRAME_MESSAGES_MAP =3D 11, - INSYS_MSG_ERR_CAPTURE_TIMEOUT =3D 12, - INSYS_MSG_ERR_CAPTURE_INVALID_STREAM_STATE =3D 13, - INSYS_MSG_ERR_CAPTURE_HW_ERR_MULTIBIT_PH_ERROR_DETECTED =3D 14, - INSYS_MSG_ERR_CAPTURE_HW_ERR_PAYLOAD_CRC_ERROR =3D 15, - INSYS_MSG_ERR_CAPTURE_HW_ERR_INPUT_DATA_LOSS_ELASTIC_FIFO_OVFL =3D 16, - INSYS_MSG_ERR_CAPTURE_HW_ERR_PIXEL_BUFFER_OVERFLOW =3D 17, - INSYS_MSG_ERR_CAPTURE_HW_ERR_BAD_FRAME_DIM =3D 18, - INSYS_MSG_ERR_CAPTURE_HW_ERR_PHY_SYNC_ERR =3D 19, - INSYS_MSG_ERR_CAPTURE_HW_ERR_SECURE_TOUCH =3D 20, - INSYS_MSG_ERR_CAPTURE_HW_ERR_MASTER_SLAVE_SYNC_ERR =3D 21, - INSYS_MSG_ERR_CAPTURE_FRAME_SKIP_ERR =3D 22, - INSYS_MSG_ERR_CAPTURE_FE_INPUT_FIFO_OVERFLOW_ERR =3D 23, - INSYS_MSG_ERR_CAPTURE_CMD_SUBMIT_TO_HW =3D 24, - INSYS_MSG_ERR_CAPTURE_N }; =20 enum insys_msg_err_groups { - INSYS_MSG_ERR_GROUP_RESERVED =3D IA_GOFO_MSG_ERR_GROUP_RESERVED, - INSYS_MSG_ERR_GROUP_GENERAL =3D IA_GOFO_MSG_ERR_GROUP_GENERAL, - INSYS_MSG_ERR_GROUP_STREAM =3D 2, INSYS_MSG_ERR_GROUP_CAPTURE =3D 3, - INSYS_MSG_ERR_GROUP_N, }; =20 #endif diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h b/drivers/sta= ging/media/ipu7/abi/ipu7_fw_msg_abi.h index 3f2c065dfe14..b2e6bd9159f2 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h @@ -9,30 +9,6 @@ #include "ipu7_fw_common_abi.h" =20 #pragma pack(push, 1) -enum ipu7_msg_type { - IPU_MSG_TYPE_RESERVED =3D IA_GOFO_MSG_TYPE_RESERVED, - IPU_MSG_TYPE_INDIRECT =3D IA_GOFO_MSG_TYPE_INDIRECT, - IPU_MSG_TYPE_DEV_LOG =3D IA_GOFO_MSG_TYPE_LOG, - IPU_MSG_TYPE_GENERAL_ERR =3D IA_GOFO_MSG_TYPE_GENERAL_ERR, - IPU_MSG_TYPE_DEV_OPEN =3D 4, - IPU_MSG_TYPE_DEV_OPEN_ACK =3D 5, - IPU_MSG_TYPE_GRAPH_OPEN =3D 6, - IPU_MSG_TYPE_GRAPH_OPEN_ACK =3D 7, - IPU_MSG_TYPE_TASK_REQ =3D 8, - IPU_MSG_TYPE_TASK_DONE =3D 9, - IPU_MSG_TYPE_GRAPH_CLOSE =3D 10, - IPU_MSG_TYPE_GRAPH_CLOSE_ACK =3D 11, - IPU_MSG_TYPE_DEV_CLOSE =3D 12, - IPU_MSG_TYPE_DEV_CLOSE_ACK =3D 13, - IPU_MSG_TYPE_TERM_EVENT =3D 14, - IPU_MSG_TYPE_N, -}; - -enum ipu7_msg_node_type { - IPU_MSG_NODE_TYPE_PAD =3D 0, - IPU_MSG_NODE_TYPE_BASE, - IPU_MSG_NODE_TYPE_N -}; =20 #define IPU_MSG_NODE_MAX_DEVICES (128U) #define DEB_NUM_UINT32 (IPU_MSG_NODE_MAX_DEVICES / (sizeof(u32) * 8U)) @@ -45,173 +21,27 @@ typedef u32 ipu7_msg_deb_t[DEB_NUM_UINT32]; =20 typedef u32 ipu7_msg_rbm_t[RBM_NUM_UINT32]; =20 -enum ipu7_msg_node_profile_type { - IPU_MSG_NODE_PROFILE_TYPE_PAD =3D 0, - IPU_MSG_NODE_PROFILE_TYPE_BASE, - IPU_MSG_NODE_PROFILE_TYPE_CB, - IPU_MSG_NODE_PROFILE_TYPE_N -}; - -enum ipu7_msg_node_option_types { - IPU_MSG_NODE_OPTION_TYPES_PADDING =3D 0, - IPU_MSG_NODE_OPTION_TYPES_N -}; - #pragma pack(pop) =20 #pragma pack(push, 1) =20 -enum ipu7_msg_link_type { - IPU_MSG_LINK_TYPE_PAD =3D 0, - IPU_MSG_LINK_TYPE_GENERIC =3D 1, - IPU_MSG_LINK_TYPE_N -}; - -enum ipu7_msg_link_option_types { - IPU_MSG_LINK_OPTION_TYPES_PADDING =3D 0, - IPU_MSG_LINK_OPTION_TYPES_CMPRS =3D 1, - IPU_MSG_LINK_OPTION_TYPES_N -}; - -enum ipu7_msg_link_cmprs_option_bit_depth { - IPU_MSG_LINK_CMPRS_OPTION_8BPP =3D 0, - IPU_MSG_LINK_CMPRS_OPTION_10BPP =3D 1, - IPU_MSG_LINK_CMPRS_OPTION_12BPP =3D 2, -}; - #define IPU_MSG_LINK_FOREIGN_KEY_NONE (65535U) #define IPU_MSG_LINK_PBK_ID_DONT_CARE (255U) #define IPU_MSG_LINK_PBK_SLOT_ID_DONT_CARE (255U) =20 #pragma pack(pop) =20 -enum ipu7_msg_dev_state { - IPU_MSG_DEV_STATE_CLOSED =3D 0, - IPU_MSG_DEV_STATE_OPEN_WAIT =3D 1, - IPU_MSG_DEV_STATE_OPEN =3D 2, - IPU_MSG_DEV_STATE_CLOSE_WAIT =3D 3, - IPU_MSG_DEV_STATE_N -}; - -enum ipu7_msg_graph_state { - IPU_MSG_GRAPH_STATE_CLOSED =3D 0, - IPU_MSG_GRAPH_STATE_OPEN_WAIT =3D 1, - IPU_MSG_GRAPH_STATE_OPEN =3D 2, - IPU_MSG_GRAPH_STATE_CLOSE_WAIT =3D 3, - IPU_MSG_GRAPH_STATE_N -}; - -enum ipu7_msg_task_state { - IPU_MSG_TASK_STATE_DONE =3D 0, - IPU_MSG_TASK_STATE_WAIT_DONE =3D 1, - IPU_MSG_TASK_STATE_N -}; - -enum ipu7_msg_err_groups { - IPU_MSG_ERR_GROUP_RESERVED =3D IA_GOFO_MSG_ERR_GROUP_RESERVED, - IPU_MSG_ERR_GROUP_GENERAL =3D IA_GOFO_MSG_ERR_GROUP_GENERAL, - IPU_MSG_ERR_GROUP_DEVICE =3D 2, - IPU_MSG_ERR_GROUP_GRAPH =3D 3, - IPU_MSG_ERR_GROUP_TASK =3D 4, - IPU_MSG_ERR_GROUP_N, -}; - #pragma pack(push, 1) -enum ipu7_msg_err_task { - IPU_MSG_ERR_TASK_OK =3D IA_GOFO_MSG_ERR_OK, - IPU_MSG_ERR_TASK_GRAPH_ID =3D 1, - IPU_MSG_ERR_TASK_NODE_CTX_ID =3D 2, - IPU_MSG_ERR_TASK_PROFILE_IDX =3D 3, - IPU_MSG_ERR_TASK_CTX_MEMORY_TASK =3D 4, - IPU_MSG_ERR_TASK_TERM_PAYLOAD_PTR =3D 5, - IPU_MSG_ERR_TASK_FRAME_ID =3D 6, - IPU_MSG_ERR_TASK_FRAG_ID =3D 7, - IPU_MSG_ERR_TASK_EXEC_EXT =3D 8, - IPU_MSG_ERR_TASK_EXEC_SBX =3D 9, - IPU_MSG_ERR_TASK_EXEC_INT =3D 10, - IPU_MSG_ERR_TASK_EXEC_UNKNOWN =3D 11, - IPU_MSG_ERR_TASK_PRE_EXEC =3D 12, - IPU_MSG_ERR_TASK_N -}; - #pragma pack(pop) =20 #pragma pack(push, 1) -enum ipu7_msg_term_type { - IPU_MSG_TERM_TYPE_PAD =3D 0, - IPU_MSG_TERM_TYPE_BASE, - IPU_MSG_TERM_TYPE_N, -}; - -enum ipu7_msg_term_option_types { - IPU_MSG_TERM_OPTION_TYPES_PADDING =3D 0, - IPU_MSG_TERM_OPTION_TYPES_N -}; - #pragma pack(pop) =20 #pragma pack(push, 1) =20 -enum ipu7_msg_err_device { - IPU_MSG_ERR_DEVICE_OK =3D IA_GOFO_MSG_ERR_OK, - IPU_MSG_ERR_DEVICE_MAX_GRAPHS =3D 1, - IPU_MSG_ERR_DEVICE_MSG_MAP =3D 2, - IPU_MSG_ERR_DEVICE_N -}; - #pragma pack(pop) =20 #pragma pack(push, 1) - -enum ipu7_msg_graph_ack_option_types { - IPU_MSG_GRAPH_ACK_OPTION_TYPES_PADDING =3D 0, - IPU_MSG_GRAPH_ACK_TASK_Q_INFO, - IPU_MSG_GRAPH_ACK_OPTION_TYPES_N -}; - -enum ipu7_msg_err_graph { - IPU_MSG_ERR_GRAPH_OK =3D IA_GOFO_MSG_ERR_OK, - IPU_MSG_ERR_GRAPH_GRAPH_STATE =3D 1, - IPU_MSG_ERR_GRAPH_MAX_GRAPHS =3D 2, - IPU_MSG_ERR_GRAPH_GRAPH_ID =3D 3, - IPU_MSG_ERR_GRAPH_NODE_CTX_ID =3D 4, - IPU_MSG_ERR_GRAPH_NODE_RSRC_ID =3D 5, - IPU_MSG_ERR_GRAPH_PROFILE_IDX =3D 6, - IPU_MSG_ERR_GRAPH_TERM_ID =3D 7, - IPU_MSG_ERR_GRAPH_TERM_PAYLOAD_SIZE =3D 8, - IPU_MSG_ERR_GRAPH_LINK_NODE_CTX_ID =3D 9, - IPU_MSG_ERR_GRAPH_LINK_TERM_ID =3D 10, - IPU_MSG_ERR_GRAPH_PROFILE_TYPE =3D 11, - IPU_MSG_ERR_GRAPH_NUM_FRAGS =3D 12, - IPU_MSG_ERR_GRAPH_QUEUE_ID_USAGE =3D 13, - IPU_MSG_ERR_GRAPH_QUEUE_OPEN =3D 14, - IPU_MSG_ERR_GRAPH_QUEUE_CLOSE =3D 15, - IPU_MSG_ERR_GRAPH_QUEUE_ID_TASK_REQ_MISMATCH =3D 16, - IPU_MSG_ERR_GRAPH_CTX_MEMORY_FGRAPH =3D 17, - IPU_MSG_ERR_GRAPH_CTX_MEMORY_NODE =3D 18, - IPU_MSG_ERR_GRAPH_CTX_MEMORY_NODE_PROFILE =3D 19, - IPU_MSG_ERR_GRAPH_CTX_MEMORY_TERM =3D 20, - IPU_MSG_ERR_GRAPH_CTX_MEMORY_LINK =3D 21, - IPU_MSG_ERR_GRAPH_CTX_MSG_MAP =3D 22, - IPU_MSG_ERR_GRAPH_CTX_FOREIGN_KEY =3D 23, - IPU_MSG_ERR_GRAPH_CTX_STREAMING_MODE =3D 24, - IPU_MSG_ERR_GRAPH_CTX_PBK_RSRC =3D 25, - IPU_MSG_ERR_GRAPH_UNSUPPORTED_EVENT_TYPE =3D 26, - IPU_MSG_ERR_GRAPH_TOO_MANY_EVENTS =3D 27, - IPU_MSG_ERR_GRAPH_CTX_MEMORY_CMPRS =3D 28, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_ALIGN_INTERVAL =3D 29, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_PLANE_ID =3D 30, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_UNSUPPORTED_MODE =3D 31, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_BIT_DEPTH =3D 32, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_STRIDE_ALIGNMENT =3D 33, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_SUB_BUFFER_ALIGNMENT =3D 34, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_LAYOUT_ORDER =3D 35, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_LAYOUT_OVERLAP =3D 36, - IPU_MSG_ERR_GRAPH_CTX_CMPRS_BUFFER_TOO_SMALL =3D 37, - IPU_MSG_ERR_GRAPH_CTX_DELAYED_LINK =3D 38, - IPU_MSG_ERR_GRAPH_N -}; - #pragma pack(pop) =20 #define FWPS_MSG_ABI_MAX_INPUT_QUEUES (60U) --=20 2.55.0 From nobody Tue Aug 25 03:43:32 2026 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12863D45CB for ; Wed, 5 Aug 2026 18:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954222; cv=none; b=u7E+4ZGJ3QS1Wb1f36cyIm92BVIYIucaGf4U4EEY6dDwR9Fpx3QDVrpcxbHyhPFkx2EX1PWekSntdwE7IS9T6WKB+4S60waWOcYzjmHMgs4FpLfWmZnKUq5qm8/wkqYNLJ6KFhsofYFUr49cPhQYoe+z5ETJGGiu29QneEwCgRA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785954222; c=relaxed/simple; bh=b54ks5RNORzdzaeeeOGGQzaGcigoOryJQNXEuvkvRQ8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lWzw98/C3UDLDRa8DN3DM7J9gVlz0gcJr+xiPovZ2AU/jVzjvMTq3EB+AaG4FNsupqsikpHVMp3IVSji80Eyw69z0J5NsjY9ShYsObtPHXE5Fa57agzr0QlbobiHMsL7C7Z+XuUjV20qswjgala9YJ6ZEhh9kU9C4TF2yuMe8ew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qjTpnK+3; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qjTpnK+3" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-39c7fd21b63so11870421fa.0 for ; Wed, 05 Aug 2026 11:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785954219; x=1786559019; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/etY9O7l1mJNeqKFZj30VOo1bjana+xUrE/MK1RUdyE=; b=qjTpnK+3fZovVumjroNiAZT3jYwZntI8KKhZUdeHMfNIvxBnx9w+gOdcZK9L+FuYXO mT7lC0m2yTgyMdZppRTvXqzWtpL392oicQBtfcinZhBhbXmaoxbL6dKNYHRgzaDDUwSg 3JOIuBOqBmpa8D+MRxs3sLLZkysd/WWsujqBe5Wa/Z+Ckv+PZAys8RXTssnEs+hdOkOD C24NPyyuMFsjZvaKz97YGTSEOOjhiGFpmQ6Bjj4BWnYm5hq31l9fKxaHAjr4HpLGZT27 wb91IleX8TSd+oKOZGaoJIEGn8CLoLa+/XCk8j9JHUBKpE8lFTgxsAf7vqwk4phlcGoN Z5zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785954219; x=1786559019; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/etY9O7l1mJNeqKFZj30VOo1bjana+xUrE/MK1RUdyE=; b=GCAftKo2tn9kCz3/SQdVMO27s9BSzIsJVgOIbr+f+N1B0giZGry4n/2W+A3B38UCXs oDTPp88/E9uIBWhfuSQ7wGXfFbKjlV2eNZd6o+tYNizAR2OnDZlti38Mv0a+m0Apxol0 rWzonQm1mQXZt0IyZmYx49yGQzDdabC+MDlj1c2EiYQZmhVMIZj299Ow3cKvT/JbZdHr M9er3z21uSLNfAe/Is6LbfmTQhOaFC3jiGLX+ZPq4CwKQMX9fgR7lXpgSBFRjk73WXoQ i0IOatBNbsmi9CjfmN/RWPiiqhm2le8TsxptIA4yB7cAqPnXJQA4j9k7M/ihJntOXIlL YSTw== X-Gm-Message-State: AOJu0YyEZOVszbNOp6CYZUiXi+kku+2Zt9wh4/6TbABdtZXvZeKSZZEq dC7h5qtStH0ItooaihpsLfMZNShSHf9WAioq+S8P9gCLNueHEO16OJ7X X-Gm-Gg: AR+sD12dv7K0hmGPs9IEPpUfBeR/AhwY181GoyZQhh3NzkI8I/LClEaqZ+k2Mvwh21m 39CrEM9S5M30x151XWSr9xNR3EwITNht8TPg8jxITJ02F8DnXLiZgq1H4k5F/jnyOkOHNfYAQ/S /IgxDnsdAOFsNISjbYhDxZ72dqv48NqJvtWtqPjKpE58gpe62x9R7F+zJ/e4zCAdmOTwf+SEYzD NuEhjHqxZt+JmMqPr6VCvNwffdwTo8pfQkc4ALJsHMKZJ+4CYGUfEAuTXIXHKj6P3C6lieTSSMh PnT9fzvHnxMhmGwlPlRWBa77cqZAwHO8CP50CMBkfj4s550u/Nhxu9lEGOzPlLc7SX5SF5phUpD w6gEzhM5XxSTMWxBbWbCzWDBrxA48qvSqm2NiWXfEt5WWPsjnuioeRiXyOK8h0QEwKYuUmdqyuQ 3qH3AEzViueHUIh5k2KtDqUXDCaGCYePGvkGrNndnXB16DvADedP6KgLgMZwxlq4dXY519oQ== X-Received: by 2002:a05:651c:1993:b0:39b:2757:c1d3 with SMTP id 38308e7fff4ca-39fbae29cffmr10788271fa.9.1785954218658; Wed, 05 Aug 2026 11:23:38 -0700 (PDT) Received: from [192.168.243.250] ([94.229.19.199]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fb9a32bb7sm11954811fa.29.2026.08.05.11.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 11:23:38 -0700 (PDT) From: Nikolay Kulikov Date: Wed, 05 Aug 2026 21:23:08 +0300 Subject: [PATCH 4/4] staging: media: ipu7: remove unnecessary "#pragma pack()" directives Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260805-ipu7_abi-v1-4-46d420cef267@gmail.com> References: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> In-Reply-To: <20260805-ipu7_abi-v1-0-46d420cef267@gmail.com> To: Sakari Ailus , Bingbu Cao , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Nikolay Kulikov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785954209; l=2463; i=nikolayof23@gmail.com; s=20260402; h=from:subject:message-id; bh=b54ks5RNORzdzaeeeOGGQzaGcigoOryJQNXEuvkvRQ8=; b=4eo1I39brWWCs0IUeATVCS5ndG8QZkYOSCVi//iFbniZQwQWN+4W9556F5oQikt39mz3Gypcr YpXAbp0+zAUDYx7GmRBr7/Lp1blbWYuBtoGv/jTFXb5folTRXWsXue9 X-Developer-Key: i=nikolayof23@gmail.com; a=ed25519; pk=2GWUU1isl5NJpkwSCQ4OG80EinZ3EUZXlrgAg6Pz5zI= After the removeal of unused structures, these directives have no effect and can be removed. Signed-off-by: Nikolay Kulikov --- drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h | 6 ------ drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h | 20 -----------------= --- 2 files changed, 26 deletions(-) diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h b/drivers/= staging/media/ipu7/abi/ipu7_fw_common_abi.h index b85dcc519a31..40c7843ad7a7 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_common_abi.h @@ -29,9 +29,6 @@ struct ia_gofo_msg_version_list { =20 #pragma pack(pop) =20 -#pragma pack(push, 1) -#pragma pack(pop) - #define IA_GOFO_MSG_ERR_MAX_DETAILS (4U) #define IA_GOFO_MSG_ERR_OK (0U) #define IA_GOFO_MSG_ERR_GROUP_UNSPECIFIED (0U) @@ -49,14 +46,11 @@ struct ia_gofo_msg_err { #define IA_GOFO_MSG_ERR_GROUP_RESERVED IA_GOFO_MSG_ERR_GROUP_UNSPECIFIED #define IA_GOFO_MSG_ERR_GROUP_GENERAL 1 =20 -#pragma pack(push, 1) #define IA_GOFO_MSG_TYPE_RESERVED 0 #define IA_GOFO_MSG_TYPE_INDIRECT 1 #define IA_GOFO_MSG_TYPE_LOG 2 #define IA_GOFO_MSG_TYPE_GENERAL_ERR 3 =20 -#pragma pack(pop) - #pragma pack(push, 1) enum ia_gofo_msg_link_streaming_mode { IA_GOFO_MSG_LINK_STREAMING_MODE_SOFF =3D 0, diff --git a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h b/drivers/sta= ging/media/ipu7/abi/ipu7_fw_msg_abi.h index b2e6bd9159f2..01f4ce857238 100644 --- a/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h +++ b/drivers/staging/media/ipu7/abi/ipu7_fw_msg_abi.h @@ -8,8 +8,6 @@ =20 #include "ipu7_fw_common_abi.h" =20 -#pragma pack(push, 1) - #define IPU_MSG_NODE_MAX_DEVICES (128U) #define DEB_NUM_UINT32 (IPU_MSG_NODE_MAX_DEVICES / (sizeof(u32) * 8U)) =20 @@ -21,28 +19,10 @@ typedef u32 ipu7_msg_deb_t[DEB_NUM_UINT32]; =20 typedef u32 ipu7_msg_rbm_t[RBM_NUM_UINT32]; =20 -#pragma pack(pop) - -#pragma pack(push, 1) - #define IPU_MSG_LINK_FOREIGN_KEY_NONE (65535U) #define IPU_MSG_LINK_PBK_ID_DONT_CARE (255U) #define IPU_MSG_LINK_PBK_SLOT_ID_DONT_CARE (255U) =20 -#pragma pack(pop) - -#pragma pack(push, 1) -#pragma pack(pop) - -#pragma pack(push, 1) -#pragma pack(pop) - -#pragma pack(push, 1) - -#pragma pack(pop) - -#pragma pack(push, 1) -#pragma pack(pop) =20 #define FWPS_MSG_ABI_MAX_INPUT_QUEUES (60U) #define FWPS_MSG_ABI_MAX_OUTPUT_QUEUES (2U) --=20 2.55.0