From nobody Fri Oct 2 05:29:31 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2966391507 for ; Tue, 4 Aug 2026 21:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785879317; cv=none; b=VmOfK3OWLmZ2tfrkRhzG8Jm1q+MxlPTC9brvyJF7n0SnAG3EipGxQ2Nr2r/ug5FEQVbD/mP0ibuaf7DZ6V1qO5rN5FZSn/pr3d9WyOLBmunCHdqxo8fGF/rbf8yrXr0F5rxei4jtVP+BE1HPrrUGaBtrRvb9kF5EcJU6lGgHqpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785879317; c=relaxed/simple; bh=bqg0NehwVXA1rTLhVpjps1ZsW0rmS/bRW52n0SrYjxs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GVIbFzMkkxJofZA5X4OUsMUIvGKo20gc7lWV1vaFrQ9hNdDgMwmyO3qr+Z2a6x7dX+ZSMazbTUtWeIx6sz3cmRWOiEU9OYD3Ell76WPO6hRaotle50Y3jMIkAT3HyBDkME2U9D5FJ1MLYnPcrXmkfLqKDIDSC4vJHO5ClKu7ENM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IPnOX4E2; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IPnOX4E2" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso240763a91.1 for ; Tue, 04 Aug 2026 14:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785879314; x=1786484114; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lbbKhcHxWg4c2CE8Ge9QTVBenagHkPrYHIB1asS02ng=; b=IPnOX4E2+wbZkIwfsElv9Z18xfSgZJhELm7qCQZzOaVQjzJAIsAdlWFokKiW5eGFM7 ibdbU6PGCYu0HM/+B/T5ePpuUJGfPa92F4evVITCeT0wEHqWj5tFAynXkzQls1CxgCk8 zy6gkVa/cIHGhjxqNbJjArlo8s2x+1iJDgF47RlNPiLgcilz5R7KYKOV2Bhkh9KWRsVZ BIayLUzK/12b7xjQ1o3lUbfF8AMUMfb25xI5mQkynVPkU2wcteMUibQVJ17VNmb9vQkR tpAC3MjIFwgrrYnYfndqTiwIF5X16HtO68/AUeXT5Nch0ZGvJMpZQy2w0s/Mi4ZtDsx8 TO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785879314; x=1786484114; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lbbKhcHxWg4c2CE8Ge9QTVBenagHkPrYHIB1asS02ng=; b=YxWNO9ELliSKDQjDd/4WjpNDbv6CiDYRYNNlanJBXnqhHtxz4t+NiRVlZSqUDtot13 wSdbXiEo1gDJdpq++M7p8sFRpoSILskyGc+6nFd8eQRqAROc+/mzwlHdIDchYng08e2b 17SVa0+lpAn5Gug7VPhuuQG9CVY7lmFeFi8nnLVpEk6SjTuO72sq7N8qLmZYSEIHdxnT 1YW/zJy4GjoLj1zO4wM5/tPMGMsY8RNMcsNnZMfmGLantdw8cM2vPl0jVt7sYXjfruEp eesq+iZfvY07Dbovl/um9ik05/XYGxjuSqYyo1FVJaAx8dDtUhShuhoGHEf7V8kgN+iv u1uw== X-Gm-Message-State: AOJu0Yxs7BUQnFq6d516y3a3HaZy9aqScXee+7VivZfHKVw8v94lNlm3 HsuE92MKkvzXj/IulEfbT/5U9SYGWij3a2zrzCHkBzL5ZQDwxPhCOZxy X-Gm-Gg: AR+sD11/+dVSpyP85na5HSquU8EoVBs+vAczQCGs/kgWNc2OCDyGfiM4b9jThXw2WHp aUaIUtPVgEMVmAzuF2Bwcxv2ayuyLzuVENc7NeIWIZ0z7FNp9ovYVBuL8B8xk3YLIhf9GaTY+MC KGCg86iP5anvOq6MWrOr9GDmTGUZPZDterOLeM6mpy+Mq2Ki9KiGm26RoTkJ6SvOJT3w9DENNVX r6NXcl5CpCqnSaBBHMn3D5uwk/KG0EgnUvE+TmC2CdlfWwEkWcTcHv8+RdTmjie0GGL9GOsLgd/ doXxeHWLm7rKB5zmbxo0r3bZPBD5lmyy1JWCwSjjdd8qEpnONJd8AUKTkm1SkQRgyHt0MD/GWWF x1rZoqMOHV2AmNKj6h7b+jjZhXJuQ6YFuPYFsE0GaKBYMWk6u3ZJNVU22oRjZngCCkucvxiyGwt WySDlkVCuyldyBDIciDQdtSPCcSmecjtm7xgP1StnhyKMPP4+mMULSpyIPbDVYcXvkBhnHTlfIc RwOuCNl2iTcl/M0rba0yjufOb0+4YxMU/rZlzaNeHo= X-Received: by 2002:a17:90b:224e:b0:38e:9ef9:eb97 with SMTP id 98e67ed59e1d1-3903c5c443dmr1316461a91.16.1785879314070; Tue, 04 Aug 2026 14:35:14 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315863b761asm13069487eec.1.2026.08.04.14.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 14:35:13 -0700 (PDT) From: Yifei Gao To: Maxim Levitsky , Alex Dubov , Ulf Hansson , linux-mmc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Yifei Gao , stable@vger.kernel.org Subject: [PATCH] memstick: ms_block: destroy io_queue workqueue on removal Date: Tue, 4 Aug 2026 21:34:56 +0000 Message-ID: <20260804213458.3408662-1-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" msb_init_disk() creates the per-card ordered workqueue msb->io_queue with alloc_ordered_workqueue(). It is torn down with destroy_workqueue() only on the init error path; msb_remove() never destroys it. msb_stop() merely flushes the queue, and neither msb_data_clear() nor put_disk() free it. As a result every card insert/remove cycle leaks the workqueue and its kworker, exhausting kernel memory over repeated cycles. Destroy the workqueue in msb_remove() after the disk has been removed and the queue drained. Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Yifei Gao --- drivers/memstick/core/ms_block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_bl= ock.c index ce33907bfc24..65154e569a9e 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -2204,6 +2204,8 @@ static void msb_remove(struct memstick_dev *card) msb_data_clear(msb); mutex_unlock(&msb_disk_lock); =20 + destroy_workqueue(msb->io_queue); + put_disk(msb->disk); memstick_set_drvdata(card, NULL); } --=20 2.43.0