From nobody Fri Oct 2 06:17:22 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE5E84949E0 for ; Tue, 4 Aug 2026 17:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863177; cv=none; b=Sf4Dqmdzi6UU6n1niLJFXUjU1xEhnmgd+BL13WL2BuWgiHBDX7+iz8pE2Gzq3+mY5f8CtGqUjLU5+IF2wN/OTrCodrvKqmhxrlJOiNJjpggJUw3vzF8ao91DQ/TNHfrrAVTnpGRizbI+2iHLpeBYObqOYMz0N89bB59H+76ZNxY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863177; c=relaxed/simple; bh=5C7wceqaQFO2f4qXEFx21ohpcplYEZ+eV+kQkbGuCaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DDAz3MwQuqrF0yODbqpgBDUr4nN5qG6zXtZwIKN5AJsuHok2Kab48GzQXEeBlfTQPCBLVhArFeAzfnMdgjy2rGDk1jY67hFCkcmz8EM8yF0A8KZJ9Kd+uMeADnAkKIPswmCiOppP+6MmpTbp3is/mK7bxQOqU5VNcGkCk8D3Ajw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pSJ2aHsB; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pSJ2aHsB" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-381b831d535so81275a91.0 for ; Tue, 04 Aug 2026 10:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785863159; x=1786467959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=pSJ2aHsBgQ6DL5gi6QbaGjTM6rc/bkTS77S7qjXdRm5uyJu3pWNFErW9ATxgfqSJtP Rn1c98RI71BS8AhipDVcryunmUPLsOqtE7P7bGp4FgP6HDJnFxE7x5vQTYoP2FFF6aIH ONPCUwKtWkD0L0aUTMH45QFVirmafiBsCmepw+frY33sJz1gzoAShMD/+3lda3iiQFSE SwkT9jy408zhbg7vQBXSW2NKA1IzB6Vo2am2lCsVAjcLqSk8Ut8IP1gYF6/Nzl0Mq3EY YoJoDmp1Mlk2xBP3yxFe1HYU4N/Zj69RcRakK72f9lHWLNWPXWMDpObS81RLqPbRUw09 h9NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785863159; x=1786467959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=NfHRTdxImGQVYocIDt9LY9+EIu88XOtkTa0fzVMw88jA+x+0o+JKtMSRDErldim5mp bh+eO5p9+Hh2rNzxCDBBy6qIlYpDu89c62sHFNxv/NE7mThgAivnN0FXqADCVW09o/Sj fVSqGh88hjSihXwUfQFXAT/STCXsKPtYzJupGK3wJnS+FkMzxS7mxEntatx27bqo/HqD eYYcTn/7DJp3uXvmenzrVHnZHlgGdR/vLnjwvg41faCJ/LODnNNUdNhC37vTQ5Av6GlV LZQcVS3Ma8z8CntdqearghLFYjQy5sUclv9A9s8GSSg3X2wk6I2DQtduYLIbuX5q5t/y sC8w== X-Forwarded-Encrypted: i=1; AHgh+RrbkBQnAxi8VqByoTpePMiUB3YPJFf5vN8o/j/XgC4bkZJ/oqk0gUrtrNpSVma7H5OGDYiuO0oyBrx74Xk=@vger.kernel.org X-Gm-Message-State: AOJu0YxIU/2KA5xPFO1L3jKVA/Uv6MRm6oPvvrtZJrScgPL91dZ+FPRG SxFKkiLRY/OxLsevQFghH01+VNl2Egvgk7enthkMjA3rSOd/WiNxWlG/ X-Gm-Gg: AR+sD11d6hA8wUa5FvQ8wwABursTg+4WLhR9MWEf8zwIzuZa3ShTGcDL37U/Z0b3XcM pYL7rxt+/O2UzkuA35TwuihRZC1+NjcpPsKqIzZX6QHIWXavOYUwqsFBFsxbVJ/RWlS6goelSDU oWok4+2kv03rwbEXpgh1swaQZZW0UaJT3onVcxvyvCycgydzvZyiQ6GX5UhScRT+Kq7Hij0/tSU LTvPXYZFjH/0t7zb6wIABg1Xucx0xU69vcCEFGgZyitJRX7HjiTcTUZ9ivOChePlDMZ1NX2BEjO mE6mBbpym2tWhFikV4uxurOqOEUco4WCmQ6REcFKD3ljSaDcXD78d2muPe85mo1AKPQmIMDJZjp mmjOK8eIVVEuyJZsWhH3KMJlw37UmoIVccqu3MW0Pq7YOU4vFbGpifDz92gF9XAusH413hM4VuN n/1slQeek2yppOEQ3+gCG0+1ahQQl2TEkntxs36a9Py7r66gzWMoszs9uYRGA= X-Received: by 2002:a17:90b:5823:b0:38d:dbc7:5178 with SMTP id 98e67ed59e1d1-3903c632441mr378816a91.22.1785863159404; Tue, 04 Aug 2026 10:05:59 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:1461:a94d:d559:948d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586162e80sm7230582eec.0.2026.08.04.10.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:05:58 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v5 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages Date: Tue, 4 Aug 2026 22:35:19 +0530 Message-ID: <20260804170521.196393-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804170521.196393-1-mdshahid03@gmail.com> References: <20260804170521.196393-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid devm_request_threaded_irq() already logs an error when the request fails, making the explicit dev_err() redundant. Similarly, iproc_adc_enable() already reports failures, making the additional dev_err() in the probe path redundant. Remove both duplicate messages. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index cf4738b16e62..7c2e2770cd61 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); - if (ret) { - dev_err(&pdev->dev, "request_irq error %d\n", ret); + if (ret) return ret; - } =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); if (ret) { @@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pde= v) } =20 ret =3D iproc_adc_enable(indio_dev); - if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } =20 indio_dev->name =3D "iproc-static-adc"; indio_dev->info =3D &iproc_adc_iio_info; --=20 2.43.0 From nobody Fri Oct 2 06:17:22 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43E4748C8CD for ; Tue, 4 Aug 2026 17:06:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863181; cv=none; b=ZX6RnPO/5jxXeVs6m2Odv2Gyp8M3/YHhJbmiGk+Pfbs7JT/Y5wf4uYupnGCQCOYVduxOjGCTcu9O8LY5v7gCaVJiDBZN7AjFdPvBttPuC5/yCdwRcMWAgOISW38eCXeVrv52KD6C21NiJp+WRlqA0Po4jGpsjdvp2hRCOM5rB7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863181; c=relaxed/simple; bh=dsaxg7vkdnu1jZjqwuR1twivrSIw2gVVPmu/aM5RmjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AskyGVsPiTGODP2gP+iDidCyx+xA0R5grLfcUn8TGtQJ0CwJsj9vOqU1EpgLsDeOR8bQB9FUCnQGArSDmRW/xeTAnIkCGadBH2qmjONEK2eBc347vbqZE3YgHnYeiHm7ODb4nXR3IcCUJNVY1zujZbz56xRUm0Q3RFpoPrs+fGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HuFPnblN; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HuFPnblN" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c9cf07d2df6so3707019a12.2 for ; Tue, 04 Aug 2026 10:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785863170; x=1786467970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aqQolFyy9CteLDWszj4sftvNtB4+0GIquieHeua55fE=; b=HuFPnblNLrEu+fezIr2MZhjwDkMHX7S1NeQ82Peft5mHuhdodkL9MX0S8ds4Gs3547 NgdqjJI4XFg07VbCvBLCHEFdj+2thuLnZ61HQwoGgBsUVGIs1VY0+RvorcL8RjKFPjms grSlgu8qgQ1tmrKKe263bniObCpSAIKyW36ILZZBKTdRrLhE+gm2TcUF1v7xAyIqyFxW YFoeMix7kWvcujJVV6kEw+1IApRjXOeXOXxPplb+j1N3XwrK2Y/Hri2FFQeXTRW0p9wP RM3hIpj+n9RAL6CxElhtOUwpEB/Q1ioSpS7RGp0OcyqI/E1GqvoLM/burlMSqMUPYzwE +FBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785863170; x=1786467970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aqQolFyy9CteLDWszj4sftvNtB4+0GIquieHeua55fE=; b=PiUJ/YlDJJB/Aux8f4LZ2cnxxdVNImeRfGLHsiDoFqRXdaXoGnsJmsPGgvtg6hD7Cl XEAO7dUwaicc9aCutwPf3ZPNsNELGQ+2OG6j1l9c//X0BxGO/Zr9YWQejdK1GVHC7mP+ 5f8uOQKrLm428KC92rFj1xIVNUgayOmK46Wpk2OHsQnI28u4obpwinKnK0qCs1EPUBTq Cu1wRon3TN9BqN4Tty6y7Nys/v4V+t/mo/PF7fuNeFneWCb4orRLf9a+Uz2hfCHDqwna Ri2AQwsKz2zFhr00Hw7KqMoOwclpwRxt7CyvfiMBPSpqIJoeqrUi3dSSJDrK0Ih2jr7I ImsQ== X-Forwarded-Encrypted: i=1; AHgh+RpJYGlkjSP0yG7xFGAvurDuoc5Bkhn39UO4Hhyz7UrfPeDoqLYicpz+P4VtObXEjOx/+2Qiypr4NvgHXxM=@vger.kernel.org X-Gm-Message-State: AOJu0YxvB0eQyI+BS4/wKrCXcGHV8usOSNPMp6o1UFFH35iF1Zmv82BA oL1x1B1HY3xOKrtneOyOp/tPPFOHB+bbLvZ6k4IbLixOZ6r7Z4X5Vd68 X-Gm-Gg: AR+sD11/DZlSLC31Z9oU09y/kOnTEnc8JHxKbfOiE8d45VVJV/e66dZaXccvF19Kcqk GiCOZhalJFlFl/8kBRQxIHiYx28PJg47b3ErrgqpDIqBte2tcnx2Cptfa4sXU7nhCPqASTh4E0a ZjQ/Z1n6gJjAlMZ2T4KwDOhKNROsFYcL4D6YbgYnlNu7XpgTRACwb8wTpas7lucOUzmBw1FLVvZ +2zpVYp/Fbh9//j9i8+v89LcjojqQAtzbQjS3bhuN2hu4fbiRVXu4F+Lqs/PJ6zntC8RHZuXnuo 68eCHZzmXYtjGoP/fRxLs0o6qxuqn9lJ3AHoexOei1mMB9ZKT5mpD42FsqTZqx3QejSOM5jdf2J pi18gA9TC73L5rfFR4Lw8mkzVxjMUSmQ96xOLnxurLPlH1N10kem0FKj67Phu0sNRMrCvY9kbpd ZijTMo9Q4kB97EVw0oV2ONDfBMbkKOJx91zj2vuQS2FqnSsY9nE4FyHnhX5p8qpojuf03P5Q== X-Received: by 2002:a17:902:cecd:b0:2ca:53e9:1277 with SMTP id d9443c01a7336-2d0ca712f17mr2879415ad.1.1785863169414; Tue, 04 Aug 2026 10:06:09 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:1461:a94d:d559:948d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586162e80sm7230582eec.0.2026.08.04.10.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:06:08 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v5 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer Date: Tue, 4 Aug 2026 22:35:20 +0530 Message-ID: <20260804170521.196393-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804170521.196393-1-mdshahid03@gmail.com> References: <20260804170521.196393-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Introduce a local 'struct device *dev' variable in iproc_adc_probe() and use it for device-managed helper calls instead of repeatedly referencing '&pdev->dev'. No functional change intended. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 7c2e2770cd61..312be7c12e58 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -506,10 +506,10 @@ static int iproc_adc_probe(struct platform_device *pd= ev) { struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev =3D NULL; + struct device *dev =3D &pdev->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&pdev->dev, - sizeof(*adc_priv)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*adc_priv)); if (!indio_dev) return -ENOMEM; =20 @@ -528,10 +528,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) return ret; } =20 - adc_priv->adc_clk =3D devm_clk_get(&pdev->dev, "tsc_clk"); + adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, - "failed getting clock tsc_clk\n"); + dev_err(&pdev->dev, "failed getting clock tsc_clk\n"); ret =3D PTR_ERR(adc_priv->adc_clk); return ret; } @@ -547,7 +546,7 @@ static int iproc_adc_probe(struct platform_device *pdev) return ret; } =20 - ret =3D devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, + ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); --=20 2.43.0 From nobody Fri Oct 2 06:17:22 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02F284963CC for ; Tue, 4 Aug 2026 17:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863197; cv=none; b=PdKshWpIsaruSOH6j52lXo9i4oEOXExMb4kjqhPAXsD4jzwrK5pv0Bu7vWyniThstQTaTCRHUjenoQ8btMdoEF/FXbtaO3dwY9rcVG/FN+Y7va1z+TGGOC6PrruCl9qcDJVB4mB+xXsTNjLJ3tMW3JFV2XdMPI2GkPcWwaw4t5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863197; c=relaxed/simple; bh=aaG3fmxJFvgG+2hFmR/kUuEaeX8ZQwfOcPELccRjOzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VoLZumlqBZgoiilDVuLTVBgnFZJ/u45EddmtOvHxJ/S6b/uMxmylXTYJNiLWUKdlutKvxYHAH4OzvN1KAIlPi6g31E1kX/VUxnNzlTTdWRfBqnA9ltLwTiD1n/DC+dlNUsPySO5vpvi7rqnjUM22sX9Z7IcWc7oBdg6z1FvE9co= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WBbvmu0C; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WBbvmu0C" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ceb096e675so1405545ad.0 for ; Tue, 04 Aug 2026 10:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785863180; x=1786467980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/WxyWYexSwoS0Xhfap20Ecck/ANPlEcZKb1zpjgFsT0=; b=WBbvmu0C6DRhghhkcJl+g0iMqEkLHvApWeA3H/ftbbVto+TQem8J3G7UftYCL3eYeL 8iCzxIvzeDwrABHO81i7X/62hWSHX3s46ZXwFXD6v+Z7bWS9aRmn4DAR26SpRlaX66zm X5+OG4ab10xgzuxB8uHZnKhvrGBkOOCfzq6igx43XdlBNX2S8JaRGqvYeqGvyeKAwuSc gf2LvDM8RhQMDiZpbN5/9ga93uKwSBUdEgOMEYmwGig7FatoODaAz2QHlhrmFLHSOKio m0lnutkD7HrNtdAdFvEW+5YOlU7U5lIbCuvlBkfXGWVHdGIgPi5aOYOBaQE4NDGgPRS8 fWmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785863180; x=1786467980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/WxyWYexSwoS0Xhfap20Ecck/ANPlEcZKb1zpjgFsT0=; b=diZYc27HIK93IdzTwPfBTZGDlFQB6ighT/kyaP47yevET/m3StIp0Ttf6enxs/4Um+ W+dDtrWxcmKIezMGRndvq8+AICXLYf1K9xFF9RjXK2KGABQOFfOdqSM099CcE3IY1sVq DrzVLzo8gDRyWINRMMWhqy3pfiaMTscEEk2J10ZioaiCFvMuWDtxEvQzaclybcn+dEpK vWxEw8skExfoWPT1NPLg7Lj6k5/Cq+VC8pQ+hHgPpbmOfzq8Gr0fvWDgwxj3fTScvRfO 9Hw4yIs2Ea6SYLublMxltIcFHbxSEzOeiZH0N9EC0ZMIVUdif1NQ66EEhNkIw1TDNdpj eisw== X-Forwarded-Encrypted: i=1; AHgh+RqHz/qK/sw258LRHXGGR8omm5TpGEe3AA9UPny3YyhovfA3KU31q6RWdffnUVO2U3kBDdhQmpktcpYOySk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+wojvEBVONPD6wIbmZc35svYWlil2MQOkU6bi4/M9/334pAqa C3BWKk5S9o8WsPlPUCg1Kj4GOiKTcF7DVDZ7JUjivC2CQEQoTHHPF9Kk X-Gm-Gg: AR+sD12zkapjMNcu3cN7F34GTEF3/hQN04stEqualWzVdfuk4k2N1hsoThUkkz2EApx Dr7xfujHdRDPNGPlJmYCc+0CpUYhdwhTmdkeKbQn8MWbIfGR7dzCDnye24wCVm0XYN4ABbhjdJ1 BT1FJcTAuXZ9q6kZY1gqDgCArPi88tJVTAivC7BBBeeug1UfNi03A+oMxK98psM7Dm8h2b6O7kI Zim+iW6jt4tFxoRs/PometnRTSdtxsbs3tVSbxXfLPtPFK+8kdOAwxyqmX4lQtUglJwRUt0QqM/ ZGL+BBygmGbJbDWW0KP1OsPCYT6rq/CZM0odWiDRclfJdxFpU+yDgXXGZ55nC1fFiBXpmlZ+1n/ woodWA4OayceXCBl/fXFRn4mdEFrZuHNFandAf3wCMVy7ae9eF2rYZi0nyDkiu3f2urDNv9/e8Z BMJlYU0m+RJQZZbfzm2Q/yKSkglmLQpDe4Af8iGMcY+pIPb5PRhmho739kGqAJ82zr+/+fUdfna 2i3sFPy5A== X-Received: by 2002:a17:903:2b0d:b0:2ce:faa6:7cbb with SMTP id d9443c01a7336-2d0ca7afcc1mr2775625ad.4.1785863180300; Tue, 04 Aug 2026 10:06:20 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:1461:a94d:d559:948d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586162e80sm7230582eec.0.2026.08.04.10.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:06:19 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v5 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Tue, 4 Aug 2026 22:35:21 +0530 Message-ID: <20260804170521.196393-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804170521.196393-1-mdshahid03@gmail.com> References: <20260804170521.196393-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Replace open-coded dev_err() followed by return with dev_err_probe() for probe failures that immediately return. Leave error paths that jump to cleanup labels unchanged to reduce code churn. These paths will be converted separately together with the planned devm-managed cleanup using devm_add_action_or_reset(). Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 31 ++++++++++++------------------- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_ad= c.c index 312be7c12e58..9238dc8c8873 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -522,18 +522,14 @@ static int iproc_adc_probe(struct platform_device *pd= ev) =20 adc_priv->regmap =3D syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); - ret =3D PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(dev, PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); =20 adc_priv->adc_clk =3D devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, "failed getting clock tsc_clk\n"); - ret =3D PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); =20 adc_priv->irqno =3D platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -541,10 +537,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) =20 ret =3D regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to write IPROC_REGCTL2\n"); =20 ret =3D devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, @@ -554,11 +549,9 @@ static int iproc_adc_probe(struct platform_device *pde= v) return ret; =20 ret =3D clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(&pdev->dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to enable clock\n"); =20 ret =3D iproc_adc_enable(indio_dev); if (ret) --=20 2.43.0