From nobody Fri Oct 2 06:58:32 2026 Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F316414DDD for ; Tue, 4 Aug 2026 08:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.194.254.142 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785830964; cv=none; b=AJNTPVZ5NPSg2ut7MWQf4KTjznSMdp7dIkJrA2Ifqx6MXeo/Rcu8oNdUteQ8GMbswCkY3TqeXJ8jaQn2riiS3L/+2XuGSdzN7kPc/ikIStE/ccvzYDe7x3kAVEj3OWLxut0oyTKudRn/3udEOAdywFlXuUINCEb5xN8ZtfyBP0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785830964; c=relaxed/simple; bh=N0VAx82Z0pl2kmJzqfSw80vcuRWERPow0xgmGUGZAQo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=d1UGW1a6ZSQ8oupUIPLdtGrFX9ctbA1NHKEzQuAk+ReCXrAmXinJU7tNXQxTaN/ludXal/iKHarCLWS3BpIE/fZUik9ptQaVMnFqILcH12kJh6sgzgwLBpLiKTBbuMxDnF6MWVDXixHwc8oTpOI435mIIP5suAj5OL35woEjydY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=MR0NvHX7; arc=none smtp.client-ip=18.194.254.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="MR0NvHX7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1785830946; bh=8hlLFvPI47IgOf7Z+mIT5C+rxncp91T7wP5JRHjMlsQ=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=MR0NvHX7pTFy3lypdQtgiYo103mgD73N+xprMWPve+gnlNx97wBI4IbYzcTI7sbNq Nf5B/hxwoX3Zi5IUqg+WO4ZyxA5xwRS40X65KL/DVX38+4bJYM2Rv2plEAfjDngsoQ JUC7tCoYpU0DjJdrziXn6tx0d8IcvbvuMHv05uLM= X-QQ-mid: zesmtpsz3t1785830927td19e2a16 X-QQ-Originating-IP: Nfke0aqJeC0Sj0e71/sNaKK0oBOqR95XdnP/r7c/s4g= Received: from localhost.localdomain ( [113.57.152.160]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 04 Aug 2026 16:08:45 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 301149970869404048 EX-QQ-RecipientCnt: 6 From: Wentao Guan To: wentong.wu@intel.com, alexander.usyskin@intel.com Cc: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, linux-kernel@vger.kernel.org, Wentao Guan Subject: [PATCH] mei: vsc: Fix packet CRC computed over pointer size Date: Tue, 4 Aug 2026 16:08:42 +0800 Message-Id: <20260804080842.31325-1-guanwentao@uniontech.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:uniontech.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: OWhN4QRntHSGF+BBxrmvFV6vL0ZbXbcqQYdKpCOwxu3RfriSw5zLGZ6b wroQKroWENzIw19dlhnUc3RHzbO0LPlDYQr6OUNaGybUHjUYe6gDW5jppHzQdypdV1AXN8v ajvROQ0/K5/8geCr3/EmuFufPDk5TrmvWyJKsL+lA0fjvJ1qa1L6xbtaTDlHMYKvg6mln1+ 3mlRI7yeBVSRclcFY6Q0GBaddqOYMqZwbzMRHkDTZvpRx3M9Ct1yYPX9CcyKYIIO2ypXNHN xqKOQT7+YWe7aSL4YG41Xao5XxabsAKK3U0eItl4BdMqFDWswyZR7vbr3cZk5PlxqDK4Q8q kW6WxGUQ5GQsQ+r8aNYpAs7EIN8SxzK6zZbJjsu2Hw3sVhel7STe6NVAeYaTQ3I0ET/eFO6 cMgaI7EJAB/BxaGwlolCsmB4g6Du3JkKeng4SKg4fRiFD8YD7BhawYIfZmmux05WvrQKSL+ enEPgoSF8cb7O7KRXDOsyNoIG+5w2+KzlkBJR6Y0yX3FL8M6abxLrggsGUqHMkQEmX5FSrC AGBIp1y2XAPR1lxqeLerBv//wgHMQ06wAjfR+9zjTQujshAgrel6E7Fkx0qpQY6DxabYTMc aQvf+lqcZ092zTuY46fZ0ENhrM7nhDymHE1MvEIvZ8AckVz2lSkpT0IcUa8ikR1pzFrpOKR u8KDOD7YEPdB3gVS36jBJT2cwlfI1DPXyJh88KddIPihgKQrWENRTjUVQkFA3+OGqFGSsUm RdFGhKcjBzNW6GJLR4YY0BKDDzMXeGQJdLaK9u4jxHSNxRrkvokXDHZRea9hCSjKZEINRvE 97yoDnk6eOf9nMRwTn/Ho9BWCOp4RUMgG/6c1nh+SJzmSmvLjVnhblELf0vUYZdvzil2NPC LjnVef0go5VCPmy/HnsvMxXth7PJXeUuzMrpSCsPg6A3CKqEWGuDSGHa/qHawVFGaG93lyU 52+rqKniKbbkqgD7wKiUXikr0LE/JR/r1qSRHPk4hR/5//fmnc9AtozOZkDIN6Z7VxLBE6F iHBY6sdhnqix1jZcfz73RNw8Dy0AyBWMaXu4toVF1VQR+44VjCOBvNEqvyxjI= X-QQ-XMRINFO: OD9hHCdaPRBwH5bRRRw8tsiH4UAatJqXfg== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" vsc_tp_xfer() computes the packet CRC over sizeof(pkt) + olen bytes, but pkt is a pointer, so sizeof(pkt) evaluates to the pointer size instead of the size of struct vsc_tp_packet_hdr. The value correctly match the 8-byte header on 64-bit builds. Use sizeof(pkt->hdr), consistent with the header size used everywhere else in the driver, e.g. in VSC_TP_PACKET_SIZE(). Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Wentao Guan Reviewed-by: Sakari Ailus --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 5ecf99883996b..e70c07aa0d604 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -293,7 +293,7 @@ int vsc_tp_xfer(struct vsc_tp *tp, u8 cmd, const void *= obuf, size_t olen, pkt->hdr.seq =3D cpu_to_le32(++tp->seq); memcpy(pkt->buf, obuf, olen); =20 - crc =3D ~crc32(~0, (u8 *)pkt, sizeof(pkt) + olen); + crc =3D ~crc32(~0, (u8 *)pkt, sizeof(pkt->hdr) + olen); memcpy(pkt->buf + olen, &crc, sizeof(crc)); =20 ret =3D vsc_tp_wakeup_request(tp); --=20 2.30.2