From nobody Fri Oct 2 06:58:33 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B3AA32E143; Tue, 4 Aug 2026 07:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785828053; cv=none; b=or97HgP/VOcPDUJBcQtsbp2DBdj0km9RjTNqgjU3GwhfWxD5nj6I+0dpefdGRkdPs7lavbi8PZbu+COzkrfy7j7VSZvy4ZzoadBn08ZzjrE+Iuc//jQmV2/B4U8eogcotf73koMAsGpEqQacQqKUn0NVA2VqRQ37OibHjDJm4y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785828053; c=relaxed/simple; bh=Z5ehI4sjc8J24Wh0VCw0y6vqNh3dc46pzsE40x/+Cfc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YWH/JBlag9dRZ0vIHJri83fiy/jEvixx0IgyPxMhyUT/offZuEB3XhZQVikgMDsPYDEf1LddyLS+CerBO96FnZ2i3bD/sZvnfXCNFOIH6FtshLjKQ9hZoNRQPxRxY/eIpfvokEPck3hTixm1XaPKhh2fJx/5LunVANIfIPKdxHc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: fd6cec608fd411f1aa26b74ffac11d73-20260804 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_UNTRUSTED, SRC_UNTRUSTED, IP_UNFAMILIAR, SRC_UNFAMILIAR DN_TRUSTED, SRC_TRUSTED, SA_TRUSTED, SA_EXISTED, SN_TRUSTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, OB_FP X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:3ac7add4-69d3-4ae8-8ae1-f61a803b28f3,IP:10, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:5 X-CID-INFO: VERSION:1.3.12,REQID:3ac7add4-69d3-4ae8-8ae1-f61a803b28f3,IP:10,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:5 X-CID-META: VersionHash:e7bac3a,CLOUDID:14282bff1daeaae735d1ea8dfb4cdc94,BulkI D:260804152043RIF8VH0T,BulkQuantity:0,Recheck:0,SF:10|38|66|78|85|102|127| 136|865|898,TC:nil,Content:0|15|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk :nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0, BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: fd6cec608fd411f1aa26b74ffac11d73-20260804 X-User: pengcan@kylinos.cn Received: from lenovo [(42.200.176.183)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1100653409; Tue, 04 Aug 2026 15:20:37 +0800 From: Can Peng To: jonas.gorski@gmail.com, william.zhang@broadcom.com, kursad.oney@broadcom.com, broonie@kernel.org Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Can Peng , stable@vger.kernel.org Subject: [PATCH] spi: bcm63xx-hsspi: disable clocks on resume failure Date: Tue, 4 Aug 2026 15:20:17 +0800 Message-ID: <20260804072017.860974-1-pengcan@kylinos.cn> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bcm63xx_hsspi_resume() enables the HSSPI clock, and optionally the PLL clock, before restarting the SPI controller queue. If spi_controller_resume() fails, the function currently reports success and leaves those clocks enabled. Propagate the error and disable the clocks before returning. Fixes: 142168eba9dc ("spi: bcm63xx-hsspi: add bcm63xx HSSPI driver") Cc: stable@vger.kernel.org Signed-off-by: Can Peng Reviewed-by: Kursad Oney --- drivers/spi/spi-bcm63xx-hsspi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hssp= i.c index 37b3534d0b0a..633164e5a856 100644 --- a/drivers/spi/spi-bcm63xx-hsspi.c +++ b/drivers/spi/spi-bcm63xx-hsspi.c @@ -919,7 +919,13 @@ static int bcm63xx_hsspi_resume(struct device *dev) } } =20 - spi_controller_resume(host); + ret =3D spi_controller_resume(host); + if (ret) { + if (bs->pll_clk) + clk_disable_unprepare(bs->pll_clk); + clk_disable_unprepare(bs->clk); + return ret; + } =20 return 0; } --=20 2.53.0