From nobody Fri Oct 2 06:59:09 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FAFF41A4EF; Tue, 4 Aug 2026 07:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785827977; cv=none; b=Cq0dZ8eaJ04X9pdFMF7Ll0xdhQYq+FEl6TTnY7ZgQFheFp4gYgXdVcpN3FY2SINa35gDhPyc/43RTTSmAYmF4Nn0HBA7aKn6sBimvs9TF9DPAhAgrNOkJwGVbsamTOaAEBuiKOBWksksRsBe/mSNNahxtGGAr9k4MEkOu9m2HxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785827977; c=relaxed/simple; bh=2iX4aWnrc5DiSUVFDJ02pa3yAaMHZiQSOj8tMxI0J6M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=S76XVtDTBbTGd8yIHG5PfQFO7ENh12DkXkdJ1AuIA9JU0ZJdk3ObkLXeWw66mvlwXsOksa3RgRvSsidaHJ+nNpUIU+KAj/5rR2YesiTwKpaea9T50Z2+71sERapHTd0jGVbZb3HBJJsEnyoQcY/YCAxF5CgcDElYk7PK1YIR920= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: d29f6ecc8fd411f1aa26b74ffac11d73-20260804 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_UNTRUSTED, SRC_UNTRUSTED, IP_UNFAMILIAR, SRC_UNFAMILIAR, DN_TRUSTED SRC_TRUSTED, SA_TRUSTED, SA_EXISTED, SN_TRUSTED, SN_EXISTED SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF CIE_UNKNOWN, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU, AMN_GOOD X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:ffcf58f4-2a69-4bb8-a75f-96567f04af4a,IP:10, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:5 X-CID-INFO: VERSION:1.3.12,REQID:ffcf58f4-2a69-4bb8-a75f-96567f04af4a,IP:10,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:5 X-CID-META: VersionHash:e7bac3a,CLOUDID:64c595675bf92ef91576a527aa2448e8,BulkI D:260804151928HQ4OKOC0,BulkQuantity:0,Recheck:0,SF:10|38|66|78|85|102|127| 136|865|898,TC:nil,Content:0|15|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk :nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0, BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: d29f6ecc8fd411f1aa26b74ffac11d73-20260804 X-User: pengcan@kylinos.cn Received: from lenovo [(42.200.176.183)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 562483907; Tue, 04 Aug 2026 15:19:25 +0800 From: Can Peng To: jonas.gorski@gmail.com, william.zhang@broadcom.com, kursad.oney@broadcom.com, broonie@kernel.org, anand.gore@broadcom.com, florian.fainelli@broadcom.com, rafal@milecki.pl Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Can Peng , stable@vger.kernel.org Subject: [PATCH] spi: bcmbca-hsspi: disable clocks on resume failure Date: Tue, 4 Aug 2026 15:19:04 +0800 Message-ID: <20260804071904.860842-1-pengcan@kylinos.cn> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bcmbca_hsspi_resume() enables the HSSPI clock, and optionally the PLL clock, before restarting the SPI controller queue. If spi_controller_resume() fails, the function currently reports success and leaves those clocks enabled. Propagate the error and disable the clocks before returning. Fixes: a38a2233f23b ("spi: bcmbca-hsspi: Add driver for newer HSSPI control= ler") Cc: stable@vger.kernel.org Signed-off-by: Can Peng Reviewed-by: Kursad Oney --- drivers/spi/spi-bcmbca-hsspi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcmbca-hsspi.c b/drivers/spi/spi-bcmbca-hsspi.c index af88ce04948b..2aed876e5deb 100644 --- a/drivers/spi/spi-bcmbca-hsspi.c +++ b/drivers/spi/spi-bcmbca-hsspi.c @@ -598,7 +598,13 @@ static int bcmbca_hsspi_resume(struct device *dev) } } =20 - spi_controller_resume(host); + ret =3D spi_controller_resume(host); + if (ret) { + if (bs->pll_clk) + clk_disable_unprepare(bs->pll_clk); + clk_disable_unprepare(bs->clk); + return ret; + } =20 return 0; } --=20 2.53.0