From nobody Fri Oct 2 06:59:09 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910E8429803; Tue, 4 Aug 2026 07:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785827942; cv=none; b=ac/sjWD0a1UrvlDdZbvz37xODgubfnE3nEHR0HceLZGh7Pd02HRSX7X9prFf0QZRggBATjmuDxM5UHhxlOPuElZ0CfepLfS2ZGNKk4qAgiWMnHKu1Liw/DhhQOu6oUbyqDaVLCFLQLcErwcqKaiWNROov9e80zlnroxcI85BRBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785827942; c=relaxed/simple; bh=CX6o/N5o1avkkBL/5xmjTxr9sVFm8v/U2nhmtqp/ljU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Pct6gvFJRfs3bYqTtD4jyvSwbpcPwgZWhQLoWIKuSHPsBEE8N7p6p553q1UiBsV4/KwDI2t7YijNdcCWluJJFjuLsQTv4R6gq7jnyDRlLGxVer5I5OFeMjIuEHBm4QmrjU8j7cz9XiiVruC7FruxtbyVx9f+TRy9Izne49Zg8IQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: ba1aed408fd411f1aa26b74ffac11d73-20260804 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_UNTRUSTED, SRC_UNTRUSTED, IP_UNFAMILIAR, SRC_UNFAMILIAR DN_TRUSTED, SRC_TRUSTED, SA_TRUSTED, SA_EXISTED, SN_TRUSTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:7390a256-812d-4a8d-bf6c-64fa0767ff61,IP:10, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:5 X-CID-INFO: VERSION:1.3.12,REQID:7390a256-812d-4a8d-bf6c-64fa0767ff61,IP:10,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:5 X-CID-META: VersionHash:e7bac3a,CLOUDID:8c147ce4ce05ce5fe79a12776bc462ef,BulkI D:260804151849OV0UBDCP,BulkQuantity:0,Recheck:0,SF:10|38|66|78|85|102|127| 136|865|898,TC:nil,Content:0|15|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk :nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0, BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: ba1aed408fd411f1aa26b74ffac11d73-20260804 X-User: pengcan@kylinos.cn Received: from lenovo [(42.200.176.183)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 910985419; Tue, 04 Aug 2026 15:18:44 +0800 From: Can Peng To: jonas.gorski@gmail.com, broonie@kernel.org Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Can Peng , stable@vger.kernel.org Subject: [PATCH] spi: bcm63xx: disable clock on resume failure Date: Tue, 4 Aug 2026 15:18:31 +0800 Message-ID: <20260804071831.860784-1-pengcan@kylinos.cn> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bcm63xx_spi_resume() enables the controller clock before restarting the SPI controller queue. If spi_controller_resume() fails, the function currently reports success and leaves the clock enabled. Propagate the error and disable the clock before returning. Fixes: b42dfed83d95 ("spi: add Broadcom BCM63xx SPI controller driver") Cc: stable@vger.kernel.org Signed-off-by: Can Peng --- drivers/spi/spi-bcm63xx.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index 8cef725aab26..1d8e257bad30 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -653,7 +653,11 @@ static int bcm63xx_spi_resume(struct device *dev) if (ret) return ret; =20 - spi_controller_resume(host); + ret =3D spi_controller_resume(host); + if (ret) { + clk_disable_unprepare(bs->clk); + return ret; + } =20 return 0; } --=20 2.53.0