From nobody Fri Oct 2 06:17:07 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E18ED46AF10 for ; Tue, 4 Aug 2026 15:24:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785857070; cv=none; b=sJM7YuoxMeL2/iTwhOuVkDXQg9S+1V4SueeNE+xIEzoGfOn5ARwcNxL3/DRndCrlnVHjALH/hFFIGZMlE52gYPdPz4WbuWeF6TVU0woYo7fh0xV3rpmSWiWLmbTgTdRTuAQuelJ+3gmKYw05vMn48jfG+tsVMdIFt8mYGGuOtfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785857070; c=relaxed/simple; bh=f3dBut9WSJ6O3srcSvXsdGYa6Ngpl9cC3b61R3xBFnU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s3AcnsWYHTpYnvepYCrVU9E2Rk2uyGnnxPl0uD2DL6vCGz3omBhPahwIi0FAEEaTY5a62fJQCXgFqZunhFj0ZcAdsI98pD+USdRnsTWUFY/XWJ6JZ6V137yRpp3iGE2Er/JDtCekB5Fwq+8U76F2gfOLjttuH3OwMDGCBSdZ+kk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h32Yhpw+; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h32Yhpw+" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8487214ad2bso6658512b3a.1 for ; Tue, 04 Aug 2026 08:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785857068; x=1786461868; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TjMEIKou8AZx5p3jNLvJo9ap4iKsldeOQJzsD8DXaLs=; b=h32Yhpw+NQ5PhmmPgQNTfdAvfartX4hjGOTtVA4KYmn1mBqRxO9P5IcAZzja7MK4Ur VNB4SoCU2xYBvq4FWdeDwTMgC56Df6uyst5Se+E5wgjnnTm62Tz7OJZ7cgjHblXgNQaX ZMJsHhaS1dnGtUDAOxna4MPud4wYqZLXNh/m+YmehZDABDI0KH6gWnc7Kq4utQymBlFp 53Bpf38ospgO7Ydraxi7Nd+K2lAgA2NLqE4gc+hJGzt+W1Rf6vrPNwO9FNoFdbHGCLgs gIoCL+FENTZnlzSJacF1+YShl/ybziq3vCUlMVks3jRhdae3haV/FlHTd1YTxkZZUy/C qqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785857068; x=1786461868; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TjMEIKou8AZx5p3jNLvJo9ap4iKsldeOQJzsD8DXaLs=; b=C4888lAdaA+H9eY7RIyzTJOUB+tf4c72edsiGyrGqJaJk4SivGeDxwti496A+AjKAw zWiczW0D4YtZdqIs5z8VXcVE7IGNBk3k/qCygrrYo5Idt/niukzRcKlVqffzQHFYe9VH 9Oo0EN9d6rJJJqtGQpxZP0dO44Z2Vdz7Ss5/FOw3SrexxMW9qgwgWBiIzposhi79zui8 UtMdkaFCTCvm/yUO7nDyGtSM4b1tmKc9pgT4IYBl5VQst4XrOhv3yNlX27Rsh8BOdil4 8tizlg8LInGRkmCYY0fOAN468MeYAVkIh55SJ56dkVF5W7niI+ee1Y9ng4E++sWzeX+y RQnQ== X-Forwarded-Encrypted: i=1; AHgh+RqG5fs7cpQfIukdRVYog13EXgZ5ybro4z/j1SL/b3H21+YoJtUDStvwok/CSDI+Pl5dxvtNyjW9Cz6ssFs=@vger.kernel.org X-Gm-Message-State: AOJu0YzjDlj7AsBYPPWnZqib8lT3xHfOR9herHHOmbIBQx4wIIFiXqyc x8UWsV0a4V1d5M5m2CQPJTSDWN3AdHrW9ZKfOUQayxlakL6jpBDuQ7k/ X-Gm-Gg: AR+sD10UwTcUkCqDYPkcnKlFN53WpEBZn8xfyQ10PuR6F2pScFJ/yj3jod4LIABHd7u UaoYPPyw1oBFaXKdKAHParU7yr/8nXGqQNHD5KbR8nJWzDKCv7zVEx5B5wvi02VM5LEwdnA949R ST6wXyjd/RvO+G/VGKiBnOt3fszOJGuO+SmQN/+pIvLnSx9XcLSY+p0mvPE66eNr1roUqkPxySd /AkpaJFEArgEoDTVUxSmU0moicu/GkZLiaT63DtfRSnoFgGxqyTbnY7HeUgN+NSeC2J9uKY0qlZ WrKwc2pVw2rlltS8eUBiJU3AbzktIMgTvLKWABDnU02g5c0oBmuG42EmXo51jcTNTTV/vDhf6f9 lL23DXE9CcPfvZYCXBTcR4pLpFEpYBNC/eqZfOD8o7uVBLZoxh2cqZPyk+L7KmdC0snZUEkZgt8 xB1rJvA/jYak/XhxveyAbj4oftVxIoDbFU1k3yPULtSQZORuJQaT4j4JStxhrNAnVqpTaSF7j/C v+ZN1NUFiWbB0eEJXoprPVVs/UDGz3KeirV3w== X-Received: by 2002:a05:6a00:12ca:b0:848:4424:2b8e with SMTP id d2e1a72fcca58-84ee47e39cfmr13869162b3a.3.1785857068002; Tue, 04 Aug 2026 08:24:28 -0700 (PDT) Received: from [127.0.0.1] ([103.17.98.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbe564b3sm5586778b3a.14.2026.08.04.08.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:24:27 -0700 (PDT) From: Felix Gu Date: Tue, 04 Aug 2026 23:24:17 +0800 Subject: [PATCH v2 1/3] phy: renesas: rcar-gen2: Fix double of_node_put on phy creation failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260804-rcar-gen2-v2-1-829cb84112ca@gmail.com> References: <20260804-rcar-gen2-v2-0-829cb84112ca@gmail.com> In-Reply-To: <20260804-rcar-gen2-v2-0-829cb84112ca@gmail.com> To: Vinod Koul , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Krzysztof Kozlowski , Kishon Vijay Abraham I , Sergei Shtylyov Cc: linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785857060; l=1051; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=f3dBut9WSJ6O3srcSvXsdGYa6Ngpl9cC3b61R3xBFnU=; b=gLup/i0APDsOHIFwtl+FN3WpFHapDtHlYLsmr8oH1S5EVBCSC7MGJ7idmHzl3X3W4/ya968LP 6WC7TgGO/jyCsczkUgS0s2PIUTZyfRacwyMWkXw5eP9cG7cqew1hMDY X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= for_each_child_of_node_scoped() releases the node reference on scope exit, so the explicit of_node_put(np) in the devm_phy_create() error path drops it twice. Drop the redundant of_node_put() and let the scoped cleanup handle it. Fixes: b64b32791fb5 ("phy: renesas: rcar-gen2: Simplify with scoped for eac= h OF child loop") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Felix Gu Reviewed-by: Manivannan Sadhasivam --- drivers/phy/renesas/phy-rcar-gen2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen2.c b/drivers/phy/renesas/phy-= rcar-gen2.c index 6c671254c625..5a272e25e051 100644 --- a/drivers/phy/renesas/phy-rcar-gen2.c +++ b/drivers/phy/renesas/phy-rcar-gen2.c @@ -405,7 +405,6 @@ static int rcar_gen2_phy_probe(struct platform_device *= pdev) data->gen2_phy_ops); if (IS_ERR(phy->phy)) { dev_err(dev, "Failed to create PHY\n"); - of_node_put(np); return PTR_ERR(phy->phy); } phy_set_drvdata(phy->phy, phy); --=20 2.43.0 From nobody Fri Oct 2 06:17:07 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E4763CB562 for ; Tue, 4 Aug 2026 15:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785857075; cv=none; b=ATk21NFTcmLLlSsbCQ5+t/FVteX4gk6TnaRWpsyLZ5r3MQ1AZYj8kqOnUhocIUEBDi9BMs/a0tRsRGV9B56iLok8Cc9pLT/60sf9SFqopHZb76iLYUpg6lMEHifGSsxb+/uee6K7R8Ndb0deufkIQhkjwnTswtwI1uPJXzf9Y2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785857075; c=relaxed/simple; bh=OopYQvhAzOgtFkvIvP9rtCLorwAIPYHcEYrvhnabJkA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NS3MLpCNcWoDOxIV73FDZGgTAGRwZ0FQcaNZRnaU2iP5nmY8B5HueLxlStTiQM1/AbO/gKXQzeqo+N+sGssEeJ4zAgVx9tWldq8tgBN6ZWlRCKIV6pJlaOG3L4d7hwTfRv98TCw2+wEPpDIgYjJuGWCSpz+x4+ZTx9wtI+tMftw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WFpMbg2I; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WFpMbg2I" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-848479c9bd5so4093897b3a.3 for ; Tue, 04 Aug 2026 08:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785857074; x=1786461874; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FBV25FHnbtj4yfXf4y/tjyzU6LlfwbEPVATRcbf7jt0=; b=WFpMbg2IZuRMFAlez4+9xN2P0uRMk00N9kBvw9FXruvoTZdhg0L+AS9xJxQ4C3v/ZM 4NB/eZpMxgMC2Y+GfVcDObdE5mrIB9BnvtKIXA8ZHrCPgkhY7b+9hLRxL3+Wvm6ZBdyr 7SlItK0+tK+m+mY22IhqY5O8oWH1U34VUvRajZ5E/63422c4LaUVr6glEUnXNIlZ3UKr VF6kjxnkUauAHpTt2dbut2GCh/lRDecFY1xKMFRjkBfuYk0Jl8PO4wrU1gPZYPwcB1j5 9V6NvI7vAuMILnNqDY6tGwBrSKX+0zazwbofiqWYv+Bf68ivcwBambyMd8QNMe6NRbHY Oc8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785857074; x=1786461874; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FBV25FHnbtj4yfXf4y/tjyzU6LlfwbEPVATRcbf7jt0=; b=cB8XEyuKIvgvB/pNhffeoqDbrq2bc5E+884C7Yo33DB1te3zB8HMOWJTXQscecs1s9 xzMdTcx0KhPDk9FVeoXjiYjunOq2A2bdT+Mt0lgBbFBBjQM0wBiNBvTRKXJoMs3LvRo8 WPNvQi3Yukf3Kqv54RDiYaEGFq7sbRKHwr6dS4QAMB2KImA5hp0+vFiEq9FDkt6cVYkh 1TSiADMzE5vz8BUGdpIOOcaMK+QvyslT0MusfpI8Odh9Yjrq10ymW6rWKMIeuZWiu8GV CM0uXA1aqeb9DcP3Lg8xBaNuXiGpUKBPxzbmKLpMejLyCsGr0KfE8fLNLVuvrG2A6vsf 4QYQ== X-Forwarded-Encrypted: i=1; AHgh+RqywddRARx7+ZnfI7b+BKg3ABsrjU3JH3eOw6Dn8Lr0FGMEY5LL61vgFb82XygCU95qDJvKltqjtxR/TEs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0tBzvKCJCU8qSBTQMFGiKOoiKN9mc3ljeEKMvU6u8Q9VhVm2G 7L+dZCgxltABYWf+hUdpi1Y9vVGBmB6/90321EKbjczHkE43F/bBEdYJ X-Gm-Gg: AR+sD12qOOifpe+pxF99aI+xcdBGMcbt1Kp85Dj2S9kDcB41WA1EpJqCrMeDlFPhWyQ kPEs9ziSdtuWz3UjzWUb0MyddGdcgEPkP9c4+j9ppt+blm1vLHQ7tSuyieyYUDTJ7dAlF8BpnKP 0lYFPxtu3DbLjsxONsPnWoDMoaT7DYFd9eW7+a13nuGhsLkE0i7PzZLtCjW8FXzV0Be1Mnv9rxy 68a6XKC5o+EzBIBxe5GI88JEuZh5fcVoppPR36f4b1rke/1TzWq5+tLsvjR1qY4oBsvx5Jqiy03 NwheJy55f3m1fxFUywSvxL9rfNotcspnmgMB+5KzZYpn8/P2yf+PQH/Ozn8xmV8r1qtjQ0du8wW w4R+ZsqT7NKOJftHGK8Mo0toJV+nBrMyRkPSrXPQKAYMWGQZpYlQSgAE+y4yxSSspR2weMZBiXz Apnt3xBAY8i7d3qUa7zRkazXgoWw0YsTPAxj6V6fbWOi6eKUK5CsrOTOhgDgjtA7VHotqvH3qZT +ihSrgv9/9s1jjca/PEDVkhsM6MCE8OccmsoctYUgO87I+o X-Received: by 2002:a05:6a00:3d44:b0:845:2ff5:b66d with SMTP id d2e1a72fcca58-84ee48bc72bmr12127911b3a.35.1785857073491; Tue, 04 Aug 2026 08:24:33 -0700 (PDT) Received: from [127.0.0.1] ([103.17.98.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbe564b3sm5586778b3a.14.2026.08.04.08.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:24:33 -0700 (PDT) From: Felix Gu Date: Tue, 04 Aug 2026 23:24:18 +0800 Subject: [PATCH v2 2/3] phy: renesas: rcar-gen2: Return -EINVAL for out-of-range channel reg Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260804-rcar-gen2-v2-2-829cb84112ca@gmail.com> References: <20260804-rcar-gen2-v2-0-829cb84112ca@gmail.com> In-Reply-To: <20260804-rcar-gen2-v2-0-829cb84112ca@gmail.com> To: Vinod Koul , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Krzysztof Kozlowski , Kishon Vijay Abraham I , Sergei Shtylyov Cc: linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785857060; l=1024; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=OopYQvhAzOgtFkvIvP9rtCLorwAIPYHcEYrvhnabJkA=; b=BsDksh2TdDHRuuWFLX2lyAqs3HxunCcOgfL9ctOYsr3hJ8MAEq/fJvK3TGgzc+SXCD58Mqjag BWpevYb9t1uBC4XdEjt8ivY5n2ryEPBd5wOmV2P/WXBB2U86s1LEReX X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When of_property_read_u32() succeeds but channel_num exceeds data->num_channels, rcar_gen2_phy_probe() returns error which is 0, so probe reports success even though no PHY provider is registered. Return -EINVAL in that case. Fixes: 1233f59f745b ("phy: Renesas R-Car Gen2 PHY driver") Signed-off-by: Felix Gu Reviewed-by: Manivannan Sadhasivam --- drivers/phy/renesas/phy-rcar-gen2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen2.c b/drivers/phy/renesas/phy-= rcar-gen2.c index 5a272e25e051..b18727ed41a1 100644 --- a/drivers/phy/renesas/phy-rcar-gen2.c +++ b/drivers/phy/renesas/phy-rcar-gen2.c @@ -390,7 +390,7 @@ static int rcar_gen2_phy_probe(struct platform_device *= pdev) error =3D of_property_read_u32(np, "reg", &channel_num); if (error || channel_num >=3D data->num_channels) { dev_err(dev, "Invalid \"reg\" property\n"); - return error; + return error ?: -EINVAL; } channel->select_mask =3D select_mask[channel_num]; =20 --=20 2.43.0 From nobody Fri Oct 2 06:17:07 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9F712931CD for ; Tue, 4 Aug 2026 15:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785857080; cv=none; b=PC60dtOky/eXmu3BVkQ9MsPFCs7knnazsijuCw/mhb0gRXDISjV/HJAUQcd3ZpzfVyueR88l/+hehj+jqJOv30nOeLilaAYKO/fCL6cQpJYfQJJ6Fz1QmgxLw9pnLT3GPyjmgge3lKh7aKpBFkoX8dl4Up9SUi+IExSaiUK0k5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785857080; c=relaxed/simple; bh=8N1KfRu3c/EnqBJdu7xl5UdInSkm8t3S/TsB4emkZQ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DjwdmYlMi8bXBgEG/GAjRDYFmYF3CfZq9PLERaX0S5Yph6SOxJoAlvV4anLnZ/xwXnuFTDRR24X/UFc/CAo/SbpE4zqMdabr7smSkiQ8umNBYFMHlNXSyQl5DlEdesyGljG5v3uNnfHrp4F8zgyiu33aXW4IXL5uQxaBw16kdMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ct/HiA0k; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ct/HiA0k" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8487088510aso4957711b3a.0 for ; Tue, 04 Aug 2026 08:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785857078; x=1786461878; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sbVRLeDoCCW2STTQ73SaS5bPQTwsTGlS1LT09DSg3jg=; b=ct/HiA0k9oow8xg1Jub9wlcsEE4IRmeLRh+yovITJp2JIXCYTELgTOmughJB93uBgr H/jC8KOPKnQVHJnMOFK14hUbICBQ2m7rhv9NXDwJpIKXai5UhYar73y0CJs/L3HBfZwE 2cnOTOuMNdZVLnqrj2f+G0MSvlnFy3gFkzW/SWsE1BqY9uFyHbcv2NprVAdzHz6LV8tp nGl/dYFVpw1YcEk9dpWPyXPDA47vlxj4b9FgyQ+dWJ3fwv9EwOpBt2LDsZgIUXpcdHlK 9SdX+ak3fAUaohR1Q7PaOwKR8WFrYnOmywIr6RlGQx5t8bjRbzXl2H3KQkPLQ22nQ5pK Nfhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785857078; x=1786461878; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sbVRLeDoCCW2STTQ73SaS5bPQTwsTGlS1LT09DSg3jg=; b=og/n79ADeKKtuIctoJguL0W17EIfWvONPLSpP1tJyscfwKznJgNo66f0hU8DSA+9NM UrNd87J2qbw2Hb1uGxrhwjE/7noywWngEF5GwQsY4/tUCEgbqu5VshahCX8aISGE97r8 ZB/EBLRhGX9bcC4H1gHItusmhF/cMbVb3qORjVc8Sl/NHEOOe9JBD3uGIUvJzSAwtAnp rB/RLMirLNF0JPOhKOwM/KYRBBzEUi+Pf4ZKUdU+vnCQwCxScbxqYWfuA070nTH9PBh9 GZqVxVjHp01mcqSJzM0dNdUjfxk9IQLexypXnO4GjTCKZ+5aiV+9s5lpOxiNK5JQKYcY 5Sig== X-Forwarded-Encrypted: i=1; AHgh+RrpVNYIWBVDvY/ZgXsEpSkWnq+HkX70nzxqjgK+0zwvxvI+yBU9WfDoy1Mcg0X5XkjN7fIFefE6eZ9dRso=@vger.kernel.org X-Gm-Message-State: AOJu0YwF6Bq0kfVkC9MJVqpag+1Z68o4ELFb+qs7ceLSdfEXrQ2WOnKT o3MV1ByG99HYKUq+zx3sQJEYVzRTLXA+77ZDzIBvqM4QqK/0hPZ70w0sJx0g/w== X-Gm-Gg: AR+sD10zQX5DnY4XjrGS/NTAylKa9AuG9Iu06L76CDzMCyvHpi5qyTMIRFpi5e7c2b3 Vj/ppFwn2IErxIqQAITD4jWfeFKC6sPn5qg/74g9mJi5wEv61HS7OG1wWxerZsuZqhYcJaW+wlC OpUBk59/Uqm/a1msYNEiSrNi9cTWQB99g8axlQQ5XVDWh/BVozOn6JFyTDCKpbX3/9JjhgtycLT 9i3hIXZ/PYGOEPkLPhgm+DXqeAIn/oqxv+RfoJLXFzDrhTkxrRfCAz90FaSe2KNOxpghE1AdHJ6 UK+tfEEXJNJIB/slHzEWZQVp5dniNK3fTU8iAqlRNkSis11ZiSkT242lybcmziZ9yh6S59/M6ob YfqHDxZLgCFfc+gQQQPYDO439C68wpxnU9YhGXXmjUMAfmemQX3nePCktEDRm4PMw6DMET/fWgV wCVy3s1SY7ETBPG3ucEiysf4Nc60HZBY/sy/gRBC1Uey7mArIseTyXYIXOArofa+njUjaPo/C13 zEzJiQ29LCW05Dy7TqjsKilf8Z3KdzQ7UExwQ== X-Received: by 2002:a05:6a00:cc6:b0:848:5f4f:2899 with SMTP id d2e1a72fcca58-84ee478fd67mr14141258b3a.16.1785857077965; Tue, 04 Aug 2026 08:24:37 -0700 (PDT) Received: from [127.0.0.1] ([103.17.98.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbe564b3sm5586778b3a.14.2026.08.04.08.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:24:37 -0700 (PDT) From: Felix Gu Date: Tue, 04 Aug 2026 23:24:19 +0800 Subject: [PATCH v2 3/3] phy: renesas: rcar-gen2: Use dev_err_probe() in probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260804-rcar-gen2-v2-3-829cb84112ca@gmail.com> References: <20260804-rcar-gen2-v2-0-829cb84112ca@gmail.com> In-Reply-To: <20260804-rcar-gen2-v2-0-829cb84112ca@gmail.com> To: Vinod Koul , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Krzysztof Kozlowski , Kishon Vijay Abraham I , Sergei Shtylyov Cc: linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785857060; l=2645; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=8N1KfRu3c/EnqBJdu7xl5UdInSkm8t3S/TsB4emkZQ4=; b=Rve/4xIJsDxKCs7TWRvKkUJiFC7y7Q8VnWFhUj6ehAGQibpGsY4JLqD9UGNLM96kyh7Z8XXPi OsJjqtds8o+B9P0N4r4GburlQvqrsUW3aaYQaJ/7fjSfZoHw1IAGVI6 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Convert the error paths in rcar_gen2_phy_probe() to dev_err_probe(). Signed-off-by: Felix Gu Reviewed-by: Manivannan Sadhasivam --- drivers/phy/renesas/phy-rcar-gen2.c | 35 ++++++++++++++-------------------= -- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen2.c b/drivers/phy/renesas/phy-= rcar-gen2.c index b18727ed41a1..581f6768e2bb 100644 --- a/drivers/phy/renesas/phy-rcar-gen2.c +++ b/drivers/phy/renesas/phy-rcar-gen2.c @@ -342,17 +342,13 @@ static int rcar_gen2_phy_probe(struct platform_device= *pdev) const struct rcar_gen2_phy_data *data; int i =3D 0; =20 - if (!dev->of_node) { - dev_err(dev, - "This driver is required to be instantiated from device tree\n"); - return -EINVAL; - } + if (!dev->of_node) + return dev_err_probe(dev, -EINVAL, + "This driver is required to be instantiated from device tree\n"); =20 clk =3D devm_clk_get(dev, "usbhs"); - if (IS_ERR(clk)) { - dev_err(dev, "Can't get USBHS clock\n"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "Can't get USBHS clock\n"); =20 base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) @@ -388,10 +384,9 @@ static int rcar_gen2_phy_probe(struct platform_device = *pdev) channel->selected_phy =3D -1; =20 error =3D of_property_read_u32(np, "reg", &channel_num); - if (error || channel_num >=3D data->num_channels) { - dev_err(dev, "Invalid \"reg\" property\n"); - return error ?: -EINVAL; - } + if (error || channel_num >=3D data->num_channels) + return dev_err_probe(dev, error ?: -EINVAL, + "Invalid \"reg\" property\n"); channel->select_mask =3D select_mask[channel_num]; =20 for (n =3D 0; n < PHYS_PER_CHANNEL; n++) { @@ -403,10 +398,9 @@ static int rcar_gen2_phy_probe(struct platform_device = *pdev) =20 phy->phy =3D devm_phy_create(dev, NULL, data->gen2_phy_ops); - if (IS_ERR(phy->phy)) { - dev_err(dev, "Failed to create PHY\n"); - return PTR_ERR(phy->phy); - } + if (IS_ERR(phy->phy)) + return dev_err_probe(dev, PTR_ERR(phy->phy), + "Failed to create PHY\n"); phy_set_drvdata(phy->phy, phy); } =20 @@ -414,10 +408,9 @@ static int rcar_gen2_phy_probe(struct platform_device = *pdev) } =20 provider =3D devm_of_phy_provider_register(dev, rcar_gen2_phy_xlate); - if (IS_ERR(provider)) { - dev_err(dev, "Failed to register PHY provider\n"); - return PTR_ERR(provider); - } + if (IS_ERR(provider)) + return dev_err_probe(dev, PTR_ERR(provider), + "Failed to register PHY provider\n"); =20 dev_set_drvdata(dev, drv); =20 --=20 2.43.0