From nobody Fri Oct 2 06:18:51 2026 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AD90468C02 for ; Tue, 4 Aug 2026 13:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851152; cv=none; b=pfJa+XMxY1bPIJDK1afusmXPhYMUjB8gV5OWNFyJf74EmZ+wVHvMDI3RAi8b+D9qaXKRshhUuWN+p9SbFO3xT3q2DGV82Gp4A4nkeIU7TV8ItlwYMx9x4h8iW0cBN7xt/c7PSMoBqi4ACToKu9yU5p/iDo/h3tj94GcbaKprNs0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851152; c=relaxed/simple; bh=wki1FX69Wx9RsDK/lnRG+8Sc28rI/xMT0bA8+mQXhBA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=lpR+8zWg1KJoK8icirWWmsrmtG5VPhsxEnvhpm2aJbAJ7lqDCzsyeF5hdIBtUDKwn309wk1rn4gXJbZ9pdf6Ln/MU6pJqt/sJsMb9W9jXPtEdAvQpe9Airf1yrLqXEzSptTiuK83il8VObCVR/toQRJ1khcc+GlamTEOTEb3fuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=Mq1xS84L; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="Mq1xS84L" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 674CWlTh3702901; Tue, 4 Aug 2026 14:45:27 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=dk201812; bh=RYLFTl1DGM85kMXnCePjrdu 7Z5iB9AcVp/HX6FDQOk0=; b=Mq1xS84LZk7v+T///HmwbYNKKTegLDn/T6yzwM/ VQe7ZHhkHkQ5715FbxjDfdEWuUA4nHr55RgWNxsXIuN7fq+83Aso+AmuUuIxgDPH NWYCDlVfqNnT0Bv6qx1XnIpRvUG6Brl23+OzQ8N5OxeiN/IVVt8Yrc8Xub0iaTun 8/d7ExOOuHxmu03iOEKCOYwbhcOB8Bxg8GJ9XUQioP+IEmn87N23REroD+vq3VX4 WdNwQVXMrimHgeZPbfrLAv3/DwI24GDZoQD5VLgyqQrL1bCYuurWPtrYi5GlQH+T 64ShcTxLTCJJ2K9zZhSAfBJ2SeTS12td+yE5pKWuPiCPB7g== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4fs8vttrt7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Aug 2026 14:45:27 +0100 (BST) Received: from [127.0.1.1] (172.25.5.47) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 4 Aug 2026 14:45:24 +0100 From: Alexandru Dadu Date: Tue, 4 Aug 2026 16:45:04 +0300 Subject: [PATCH] drm/imagination: Explicitly set CACHED flag on META FW Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260804-b4-cached-flag-on-meta-fw-v1-1-333bccf10d3a@imgtec.com> X-B4-Tracking: v=1; b=H4sIAN/scWoC/x3MTQqEMAxA4atI1gZq6fh3FXGR1lQDWqUVHRDvP mWW3+K9BxJH4QR98UDkS5LsIaMqC3ALhZlRpmzQSteqVQatQUdu4Qn9SjPuATc+Cf2NVnmrP21 nqdGQ+yOyl+//PYzv+wN4sjv4awAAAA== To: Alessio Belle , Luigi Santivetti , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , , Matt Coster , Alexandru Dadu , Matt Coster X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785851124; l=1493; i=alexandru.dadu@imgtec.com; s=20260304; h=from:subject:message-id; bh=aBcrOPlE91O4pvHKvdOwFFp/N9zkjaWAgioEhllmshs=; b=7i0fhj8kCEQd6em3XQKqckQAKG6ilBEC6XZBIfjNyPcwLka2x5S4pjS0hzm1NGTRXjlBkQXyj jxiKfinM9UGDwkiFrx5a/+KO2NXsI1uBApmyS1iro9okPEtwrgOHYqA X-Developer-Key: i=alexandru.dadu@imgtec.com; a=ed25519; pk=FU07SyNrYGwhahqSxbWEuzyXlUh47xBXvLvOR7UA6+U= X-Proofpoint-ORIG-GUID: dAXDPUZS1Q7rgsCuipcSaubnDF687BvR X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDExMCBTYWx0ZWRfX4E0u6CaemMav P7FI6ValIfbykG1qX8WBnUWrBnTVK9pgCq/6pCFnHt8i8GcWJuyJ2VyykvqMl1tXO/jXfIORmQH ptO6urRJjtppI1dPR/NkDxz1loGIxvQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDExMCBTYWx0ZWRfX/1dxdt2k2wfL wt4c65k5lTuw78BNrBrEwpyxHOdlPDfltWf5kd2MnFfKl/5y9IOjbBrMBSbBjph8fxJna8z6jOx GUs8EkPeiNC3j6qW6tod+RUAJOkFEGPnGzRwEdHV1y7ZsJSnApMd7tS3+30zQQHqjArRmUBb4B6 NanLARHlYoxmJkOwDTr3yjU10hDrbKy2u+xtK3je5zFDg9W3KKW1ybSR/bMxew1FeI4UZJEj5C2 4zNoV3NXGl2bw3XjjqGVyhQ6hdL38qlNEYYL+eDJRHfR7wwqHzg3h9e+5XmfPESHEdhfzWkrz6u gWYQsGiDpCYwRZCY1CDRDR+TUt7IClNmomyyCkHXarDcKRzyqluy3jzWHcYOoXtGm27bw9YGx6i p//uEm48TAJJruffPaaPy/MMtRz2BuLfCJCtPUO52RDQywwr4InqSdtPgt2ZmfQpLEhakjp1SFJ 0UEJjSFPc7jxuPNdBEg== X-Proofpoint-GUID: dAXDPUZS1Q7rgsCuipcSaubnDF687BvR X-Authority-Analysis: v=2.4 cv=D7V37PRj c=1 sm=1 tr=0 ts=6a71ecf7 cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=Ft80G52YQMEA:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=iB0s77fEAAAA:8 a=r_1tXGB3AAAA:8 a=DMDJWULzLjs8hIaqJQgA:9 a=QEXdDO2ut3YA:10 a=HyUCkmmLtCL0fD60kmUx:22 a=t8nPyN_e6usw4ciXM-Pk:22 From: Matt Coster For completeness, OR in the CACHED flags when we're not ORing in the UNCACHED counterparts. One of these is probably zero, but (a) it isn't evident just by reading these lines, and (b) the compiler will make it disappear in that case. Signed-off-by: Matt Coster Signed-off-by: Alexandru Dadu --- drivers/gpu/drm/imagination/pvr_fw_meta.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_fw_meta.c b/drivers/gpu/drm/im= agination/pvr_fw_meta.c index 9ff03bc60a08..b5837ba56e33 100644 --- a/drivers/gpu/drm/imagination/pvr_fw_meta.c +++ b/drivers/gpu/drm/imagination/pvr_fw_meta.c @@ -509,9 +509,13 @@ pvr_meta_get_fw_addr_with_offset(struct pvr_fw_object = *fw_obj, u32 offset) u32 fw_addr =3D fw_obj->fw_addr_offset + offset + ROGUE_FW_SEGMMU_DATA_BA= SE_ADDRESS; =20 /* META cacheability is determined by address. */ - if (fw_obj->gem->flags & PVR_BO_FW_FLAGS_DEVICE_UNCACHED) + if (fw_obj->gem->flags & PVR_BO_FW_FLAGS_DEVICE_UNCACHED) { fw_addr |=3D ROGUE_FW_SEGMMU_DATA_META_UNCACHED | ROGUE_FW_SEGMMU_DATA_VIVT_SLC_UNCACHED; + } else { + fw_addr |=3D ROGUE_FW_SEGMMU_DATA_META_CACHED | + ROGUE_FW_SEGMMU_DATA_VIVT_SLC_CACHED; + } =20 return fw_addr; } --- base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e change-id: 20260804-b4-cached-flag-on-meta-fw-b0fb2589ba72 Best regards, --=20 Alexandru Dadu